[jira] [Commented] (IGNITE-5983) REST: Memory policy metrics should be available via REST.
[ https://issues.apache.org/jira/browse/IGNITE-5983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16735159#comment-16735159 ] Roman Shtykh commented on IGNITE-5983: -- PR at https://github.com/apache/ignite/pull/5778 > REST: Memory policy metrics should be available via REST. > - > > Key: IGNITE-5983 > URL: https://issues.apache.org/jira/browse/IGNITE-5983 > Project: Ignite > Issue Type: Improvement > Components: cache >Reporter: Andrew Mashenkov >Assignee: Roman Shtykh >Priority: Major > Fix For: 2.8 > > Time Spent: 10m > Remaining Estimate: 0h > > For now it is possible to get some of cache metrics via REST, but not memory > metrics. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-5983) REST: Memory policy metrics should be available via REST.
[
https://issues.apache.org/jira/browse/IGNITE-5983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16735467#comment-16735467
]
Ignite TC Bot commented on IGNITE-5983:
---
{panel:title=--> Run :: All: Possible
Blockers|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}
{color:#d04437}ZooKeeper (Discovery) 2{color} [[tests 0 TIMEOUT , Exit Code
|https://ci.ignite.apache.org/viewLog.html?buildId=2734718]]
{color:#d04437}Cache (Restarts) 1{color} [[tests
7|https://ci.ignite.apache.org/viewLog.html?buildId=2734740]]
* IgniteCacheRestartTestSuite: GridCachePartitionedNodeRestartTest.testRestart
- 0,0% fails in last 514 master runs.
* IgniteCacheRestartTestSuite:
GridCachePartitionedNodeRestartTest.testRestartWithPutTwoNodesNoBackups - 0,0%
fails in last 514 master runs.
* IgniteCacheRestartTestSuite:
GridCachePartitionedNodeRestartTest.testRestartWithPutFourNodesNoBackups - 0,0%
fails in last 514 master runs.
{color:#d04437}Cache (Restarts) 2{color} [[tests
3|https://ci.ignite.apache.org/viewLog.html?buildId=2734741]]
* IgniteCacheRestartTestSuite2:
IgniteCacheAtomicReplicatedNodeRestartSelfTest.testRestartWithPutTenNodesTwoBackups
- 0,0% fails in last 553 master runs.
* IgniteCacheRestartTestSuite2:
IgniteCacheAtomicReplicatedNodeRestartSelfTest.testRestartWithPutFourNodesNoBackups
- 0,0% fails in last 553 master runs.
* IgniteCacheRestartTestSuite2:
IgniteCacheAtomicReplicatedNodeRestartSelfTest.testRestartWithTxPutAllTenNodesTwoBackups
- 0,0% fails in last 553 master runs.
{color:#d04437}Java Client{color} [[tests
23|https://ci.ignite.apache.org/viewLog.html?buildId=2734698]]
* IgniteClientTestSuite:
JettyRestProcessorAuthenticationWithCredsSelfTest.testPutWithExpiration - 0,0%
fails in last 549 master runs.
* IgniteClientTestSuite:
JettyRestProcessorAuthenticationWithCredsSelfTest.testDataStorageMetricsEnabled
* IgniteClientTestSuite:
JettyRestProcessorAuthenticationWithCredsSelfTest.testIncorrectFilterQueryScan
- 0,0% fails in last 549 master runs.
* IgniteClientTestSuite:
JettyRestProcessorAuthenticationWithCredsSelfTest.testRemoveAll - 0,0% fails in
last 549 master runs.
* IgniteClientTestSuite:
JettyRestProcessorAuthenticationWithCredsSelfTest.testAppend - 0,0% fails in
last 549 master runs.
* IgniteClientTestSuite:
JettyRestProcessorAuthenticationWithCredsSelfTest.testVisorGateway - 0,0% fails
in last 549 master runs.
* IgniteClientTestSuite:
JettyRestProcessorAuthenticationWithCredsSelfTest.testGetAndRemove - 0,0% fails
in last 549 master runs.
* IgniteClientTestSuite:
JettyRestProcessorAuthenticationWithCredsSelfTest.testDecrement - 0,0% fails in
last 549 master runs.
* IgniteClientTestSuite:
JettyRestProcessorAuthenticationWithCredsSelfTest.testGetAll - 0,0% fails in
last 549 master runs.
* IgniteClientTestSuite:
JettyRestProcessorAuthenticationWithTokenSelfTest.testDataStorageMetricsEnabled
* IgniteClientTestSuite:
JettyRestProcessorAuthenticationWithCredsSelfTest.testAddWithExpiration - 0,0%
fails in last 549 master runs.
* IgniteClientTestSuite:
JettyRestProcessorAuthenticationWithCredsSelfTest.testFilterQueryScan - 0,0%
fails in last 549 master runs.
* IgniteClientTestSuite:
JettyRestProcessorAuthenticationWithCredsSelfTest.testPutAll - 0,0% fails in
last 549 master runs.
* IgniteClientTestSuite:
JettyRestProcessorAuthenticationWithCredsSelfTest.testPutIfAbsent2 - 0,0% fails
in last 549 master runs.
* IgniteClientTestSuite:
JettyRestProcessorAuthenticationWithCredsSelfTest.testDeactivateActivate - 0,0%
fails in last 549 master runs.
* IgniteClientTestSuite:
JettyRestProcessorAuthenticationWithCredsSelfTest.testMetrics - 0,0% fails in
last 549 master runs.
* IgniteClientTestSuite:
JettyRestProcessorAuthenticationWithCredsSelfTest.testReplaceValue - 0,0% fails
in last 549 master runs.
* IgniteClientTestSuite:
JettyRestProcessorAuthenticationWithCredsSelfTest.testReplace - 0,0% fails in
last 549 master runs.
* IgniteClientTestSuite:
JettyRestProcessorAuthenticationWithCredsSelfTest.testMetadataRemote - 0,0%
fails in last 549 master runs.
* IgniteClientTestSuite:
JettyRestProcessorAuthenticationWithCredsSelfTest.testCasRemove - 0,0% fails in
last 549 master runs.
* IgniteClientTestSuite:
JettyRestProcessorAuthenticationWithCredsSelfTest.testRemove - 0,0% fails in
last 549 master runs.
* IgniteClientTestSuite:
JettyRestProcessorAuthenticationWithCredsSelfTest.testSqlFieldsQuery - 0,0%
fails in last 549 master runs.
* IgniteClientTestSuite:
JettyRestProcessorAuthenticationWithCredsSelfTest.testGetAndPut - 0,0% fails in
last 549 master runs.
{panel}
[TeamCity *--> Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=2734781&buildTypeId=IgniteTests24Java8_RunAll]
> REST: Memory policy metrics should be available via REST.
> -
>
> Key: IGNITE-5983
>
[jira] [Commented] (IGNITE-5983) REST: Memory policy metrics should be available via REST.
[ https://issues.apache.org/jira/browse/IGNITE-5983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16735474#comment-16735474 ] Roman Shtykh commented on IGNITE-5983: -- TC failures doesn't look related to this task. > REST: Memory policy metrics should be available via REST. > - > > Key: IGNITE-5983 > URL: https://issues.apache.org/jira/browse/IGNITE-5983 > Project: Ignite > Issue Type: Improvement > Components: cache >Reporter: Andrew Mashenkov >Assignee: Roman Shtykh >Priority: Major > Fix For: 2.8 > > Time Spent: 10m > Remaining Estimate: 0h > > For now it is possible to get some of cache metrics via REST, but not memory > metrics. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-5983) REST: Memory policy metrics should be available via REST.
[ https://issues.apache.org/jira/browse/IGNITE-5983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16752419#comment-16752419 ] Andrew Mashenkov commented on IGNITE-5983: -- [~roman_s], Seems, there is an issue in testDataStorageMetricsDisabled and testDataStorageMetricsEnabled. Let's make simple changes to allow these test passes regardless of their execution order, as it is undefined actually. Please, find my comment in the PR. > REST: Memory policy metrics should be available via REST. > - > > Key: IGNITE-5983 > URL: https://issues.apache.org/jira/browse/IGNITE-5983 > Project: Ignite > Issue Type: Improvement > Components: cache >Reporter: Andrew Mashenkov >Assignee: Roman Shtykh >Priority: Major > Fix For: 2.8 > > Time Spent: 20m > Remaining Estimate: 0h > > For now it is possible to get some of cache metrics via REST, but not memory > metrics. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-5983) REST: Memory policy metrics should be available via REST.
[ https://issues.apache.org/jira/browse/IGNITE-5983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16753316#comment-16753316 ] Roman Shtykh commented on IGNITE-5983: -- [~amashenkov] Thank you for the review. Sorry, can you please elaborate on what check is needed? I think _memoryMetricsEnabled_ is always _false_, unless we force the restart in _testDataStorageMetricsEnabled_. > REST: Memory policy metrics should be available via REST. > - > > Key: IGNITE-5983 > URL: https://issues.apache.org/jira/browse/IGNITE-5983 > Project: Ignite > Issue Type: Improvement > Components: cache >Reporter: Andrew Mashenkov >Assignee: Roman Shtykh >Priority: Major > Fix For: 2.8 > > Time Spent: 20m > Remaining Estimate: 0h > > For now it is possible to get some of cache metrics via REST, but not memory > metrics. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-5983) REST: Memory policy metrics should be available via REST.
[
https://issues.apache.org/jira/browse/IGNITE-5983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16753869#comment-16753869
]
Andrew Mashenkov commented on IGNITE-5983:
--
[~roman_s],
Usually, we do not restart the grid between 2 tests in same class to save TC
time.
So, if testDataStorageMetricsEnabled run before
testDataStorageMetricsDisabled, the last one will fails.
I mean an additional check should be added in testDataStorageMetricsDisabled:
{code:java}
if (memoryMetricsEnabled) {
memoryMetricsEnabled = false;
restartgrid();
}
{code}
Or memoryMetricsEnabled default value should be restored in e.g. beforeTest
method. I'd prefer this approach.
{code:java}
void beforeTest() {
if (memoryMetricsEnabled) {
memoryMetricsEnabled = false;
restartgrid();
}
}
{code}
> REST: Memory policy metrics should be available via REST.
> -
>
> Key: IGNITE-5983
> URL: https://issues.apache.org/jira/browse/IGNITE-5983
> Project: Ignite
> Issue Type: Improvement
> Components: cache
>Reporter: Andrew Mashenkov
>Assignee: Roman Shtykh
>Priority: Major
> Fix For: 2.8
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> For now it is possible to get some of cache metrics via REST, but not memory
> metrics.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-5983) REST: Memory policy metrics should be available via REST.
[ https://issues.apache.org/jira/browse/IGNITE-5983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16754496#comment-16754496 ] Roman Shtykh commented on IGNITE-5983: -- [~amashenkov] Thank you for the explanation! Now I see what you mean, and fixed the issue. Please have a look. > REST: Memory policy metrics should be available via REST. > - > > Key: IGNITE-5983 > URL: https://issues.apache.org/jira/browse/IGNITE-5983 > Project: Ignite > Issue Type: Improvement > Components: cache >Reporter: Andrew Mashenkov >Assignee: Roman Shtykh >Priority: Major > Fix For: 2.8 > > Time Spent: 20m > Remaining Estimate: 0h > > For now it is possible to get some of cache metrics via REST, but not memory > metrics. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-5983) REST: Memory policy metrics should be available via REST.
[ https://issues.apache.org/jira/browse/IGNITE-5983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16768125#comment-16768125 ] Roman Shtykh commented on IGNITE-5983: -- [~amashenkov] Have you had a chance to look at the issue? > REST: Memory policy metrics should be available via REST. > - > > Key: IGNITE-5983 > URL: https://issues.apache.org/jira/browse/IGNITE-5983 > Project: Ignite > Issue Type: Improvement > Components: cache >Reporter: Andrew Mashenkov >Assignee: Roman Shtykh >Priority: Major > Fix For: 2.8 > > Time Spent: 20m > Remaining Estimate: 0h > > For now it is possible to get some of cache metrics via REST, but not memory > metrics. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-5983) REST: Memory policy metrics should be available via REST.
[ https://issues.apache.org/jira/browse/IGNITE-5983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16768405#comment-16768405 ] Andrew Mashenkov commented on IGNITE-5983: -- [~roman_s], yes, now look good. I've just merged your PR this with latest master and re-run TC. > REST: Memory policy metrics should be available via REST. > - > > Key: IGNITE-5983 > URL: https://issues.apache.org/jira/browse/IGNITE-5983 > Project: Ignite > Issue Type: Improvement > Components: cache >Reporter: Andrew Mashenkov >Assignee: Roman Shtykh >Priority: Major > Fix For: 2.8 > > Time Spent: 20m > Remaining Estimate: 0h > > For now it is possible to get some of cache metrics via REST, but not memory > metrics. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-5983) REST: Memory policy metrics should be available via REST.
[ https://issues.apache.org/jira/browse/IGNITE-5983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16768838#comment-16768838 ] Roman Shtykh commented on IGNITE-5983: -- [~amashenkov] Thank you for reviewing and further improving the tests! > REST: Memory policy metrics should be available via REST. > - > > Key: IGNITE-5983 > URL: https://issues.apache.org/jira/browse/IGNITE-5983 > Project: Ignite > Issue Type: Improvement > Components: cache >Reporter: Andrew Mashenkov >Assignee: Roman Shtykh >Priority: Major > Fix For: 2.8 > > Time Spent: 40m > Remaining Estimate: 0h > > For now it is possible to get some of cache metrics via REST, but not memory > metrics. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-5983) REST: Memory policy metrics should be available via REST.
[ https://issues.apache.org/jira/browse/IGNITE-5983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16144709#comment-16144709 ] Roman Shtykh commented on IGNITE-5983: -- [~kuaw26] I think you use REST API a lot for web console. What do you think about this implementation? > REST: Memory policy metrics should be available via REST. > - > > Key: IGNITE-5983 > URL: https://issues.apache.org/jira/browse/IGNITE-5983 > Project: Ignite > Issue Type: Improvement > Components: cache >Reporter: Andrew Mashenkov >Assignee: Roman Shtykh > Fix For: 2.3 > > > For now it is possible to get some of cache metrics via REST, but not memory > metrics. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (IGNITE-5983) REST: Memory policy metrics should be available via REST.
[ https://issues.apache.org/jira/browse/IGNITE-5983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16629979#comment-16629979 ] Vladimir Ozerov commented on IGNITE-5983: - Moved to 2.8 due to inactivity. Please feel free to move back if you will be able to complete the ticket by AI 2.7 code freeze date, September 30, 2018. > REST: Memory policy metrics should be available via REST. > - > > Key: IGNITE-5983 > URL: https://issues.apache.org/jira/browse/IGNITE-5983 > Project: Ignite > Issue Type: Improvement > Components: cache >Reporter: Andrew Mashenkov >Assignee: Roman Shtykh >Priority: Major > Fix For: 2.8 > > > For now it is possible to get some of cache metrics via REST, but not memory > metrics. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-5983) REST: Memory policy metrics should be available via REST.
[ https://issues.apache.org/jira/browse/IGNITE-5983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16189676#comment-16189676 ] Vladimir Ozerov commented on IGNITE-5983: - [~roman_s], [~akuznetsov], Folks, currently our memory/persistence API undergoes significant redesign [1]. When finished, changes in this PR will become obsolete. So I propose to wait until IGNITE-6030 is finished and re-work PR then. Let's move it to 2.4 release. [1] https://issues.apache.org/jira/browse/IGNITE-6030 > REST: Memory policy metrics should be available via REST. > - > > Key: IGNITE-5983 > URL: https://issues.apache.org/jira/browse/IGNITE-5983 > Project: Ignite > Issue Type: Improvement > Components: cache >Reporter: Andrew Mashenkov >Assignee: Roman Shtykh > Fix For: 2.4 > > > For now it is possible to get some of cache metrics via REST, but not memory > metrics. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
