[jira] [Commented] (IGNITE-6250) .NET: Thin client: Basic exception handling

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-6250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16173204#comment-16173204
 ] 

ASF GitHub Bot commented on IGNITE-6250:


Github user asfgit closed the pull request at:

https://github.com/apache/ignite/pull/2698


> .NET: Thin client: Basic exception handling
> ---
>
> Key: IGNITE-6250
> URL: https://issues.apache.org/jira/browse/IGNITE-6250
> Project: Ignite
>  Issue Type: Improvement
>  Components: platforms, thin client
>Reporter: Pavel Tupitsyn
>Assignee: Pavel Tupitsyn
>  Labels: .NET
> Fix For: 2.3
>
>
> Exception handling in thin client: response includes a success flag. Define 
> exception format protocol in case of failure.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-6250) .NET: Thin client: Basic exception handling

[Pavel Tupitsyn (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-6250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16173200#comment-16173200
 ] 

Pavel Tupitsyn commented on IGNITE-6250:


TC is fine, merged to master: {{904f6a0317f47fa65b802f535fe7da63343285ff}}

> .NET: Thin client: Basic exception handling
> ---
>
> Key: IGNITE-6250
> URL: https://issues.apache.org/jira/browse/IGNITE-6250
> Project: Ignite
>  Issue Type: Improvement
>  Components: platforms, thin client
>Reporter: Pavel Tupitsyn
>Assignee: Pavel Tupitsyn
>  Labels: .NET
> Fix For: 2.3
>
>
> Exception handling in thin client: response includes a success flag. Define 
> exception format protocol in case of failure.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-6250) .NET: Thin client: Basic exception handling

[Pavel Tupitsyn (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-6250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16173128#comment-16173128
 ] 

Pavel Tupitsyn commented on IGNITE-6250:


1) Ok
2) Removed

> .NET: Thin client: Basic exception handling
> ---
>
> Key: IGNITE-6250
> URL: https://issues.apache.org/jira/browse/IGNITE-6250
> Project: Ignite
>  Issue Type: Improvement
>  Components: platforms, thin client
>Reporter: Pavel Tupitsyn
>Assignee: Pavel Tupitsyn
>  Labels: .NET
> Fix For: 2.3
>
>
> Exception handling in thin client: response includes a success flag. Define 
> exception format protocol in case of failure.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-6250) .NET: Thin client: Basic exception handling

[Vladimir Ozerov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-6250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16173114#comment-16173114
 ] 

Vladimir Ozerov commented on IGNITE-6250:
-

[~ptupitsyn], my comment:
1) I did some cosmetical changes, please review (in particular - changed one 
error message)
2) {{ClientStatus.ParsingFailed}} - still there. Is it ok?

> .NET: Thin client: Basic exception handling
> ---
>
> Key: IGNITE-6250
> URL: https://issues.apache.org/jira/browse/IGNITE-6250
> Project: Ignite
>  Issue Type: Improvement
>  Components: platforms, thin client
>Reporter: Pavel Tupitsyn
>Assignee: Pavel Tupitsyn
>  Labels: .NET
> Fix For: 2.3
>
>
> Exception handling in thin client: response includes a success flag. Define 
> exception format protocol in case of failure.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-6250) .NET: Thin client: Basic exception handling

[Pavel Tupitsyn (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-6250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16173097#comment-16173097
 ] 

Pavel Tupitsyn commented on IGNITE-6250:


1) Fixed
2) If you mean handshake error handling, see {{ClientSocket.Handshake}}
3) Fixed
4) Handshake failure is handled by {{ClientListenerNioListener.onHandshake}} 
for all client types, there is a boolean flag, not an error code. Not sure if 
we should change this.

> .NET: Thin client: Basic exception handling
> ---
>
> Key: IGNITE-6250
> URL: https://issues.apache.org/jira/browse/IGNITE-6250
> Project: Ignite
>  Issue Type: Improvement
>  Components: platforms, thin client
>Reporter: Pavel Tupitsyn
>Assignee: Pavel Tupitsyn
>  Labels: .NET
> Fix For: 2.3
>
>
> Exception handling in thin client: response includes a success flag. Define 
> exception format protocol in case of failure.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-6250) .NET: Thin client: Basic exception handling

[Pavel Tupitsyn (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-6250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16173050#comment-16173050
 ] 

Pavel Tupitsyn commented on IGNITE-6250:


1) Closing connection is bad usability. How are you going to know what went 
wrong? I think we should provide a response when possible. See how web servers 
work.
2) Neither do I. Where do you think we need it in that file?
3,4) Fixed

> .NET: Thin client: Basic exception handling
> ---
>
> Key: IGNITE-6250
> URL: https://issues.apache.org/jira/browse/IGNITE-6250
> Project: Ignite
>  Issue Type: Improvement
>  Components: platforms, thin client
>Reporter: Pavel Tupitsyn
>Assignee: Pavel Tupitsyn
>  Labels: .NET
> Fix For: 2.3
>
>
> Exception handling in thin client: response includes a success flag. Define 
> exception format protocol in case of failure.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-6250) .NET: Thin client: Basic exception handling

[Pavel Tupitsyn (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-6250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16171882#comment-16171882
 ] 

Pavel Tupitsyn commented on IGNITE-6250:


Done, [~vozerov], please have a look.

> .NET: Thin client: Basic exception handling
> ---
>
> Key: IGNITE-6250
> URL: https://issues.apache.org/jira/browse/IGNITE-6250
> Project: Ignite
>  Issue Type: Improvement
>  Components: platforms, thin client
>Reporter: Pavel Tupitsyn
>Assignee: Pavel Tupitsyn
>  Labels: .NET
> Fix For: 2.3
>
>
> Exception handling in thin client: response includes a success flag. Define 
> exception format protocol in case of failure.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-6250) .NET: Thin client: Basic exception handling

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-6250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16171866#comment-16171866
 ] 

ASF GitHub Bot commented on IGNITE-6250:


GitHub user ptupitsyn opened a pull request:

https://github.com/apache/ignite/pull/2698

IGNITE-6250 .NET: Thin client: Basic exception handling



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gridgain/apache-ignite ignite-6250

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/2698.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2698


commit dd94981c250070d0b36b6da398b032c2b745b73d
Author: Pavel Tupitsyn 
Date:   2017-09-19T15:13:49Z

IGNITE-6250 .NET: Thin client: Basic exception handling




> .NET: Thin client: Basic exception handling
> ---
>
> Key: IGNITE-6250
> URL: https://issues.apache.org/jira/browse/IGNITE-6250
> Project: Ignite
>  Issue Type: Improvement
>  Components: platforms, thin client
>Reporter: Pavel Tupitsyn
>Assignee: Pavel Tupitsyn
>  Labels: .NET
> Fix For: 2.3
>
>
> Exception handling in thin client: response includes a success flag. Define 
> exception format protocol in case of failure.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-6250) .NET: Thin client: Basic exception handling

[Pavel Tupitsyn (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-6250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16171575#comment-16171575
 ] 

Pavel Tupitsyn commented on IGNITE-6250:


Let's provide basic exception propagation in form of success flag and (if any) 
string exception message in every response.

Ticket for extended errors: IGNITE-6438

> .NET: Thin client: Basic exception handling
> ---
>
> Key: IGNITE-6250
> URL: https://issues.apache.org/jira/browse/IGNITE-6250
> Project: Ignite
>  Issue Type: Improvement
>  Components: platforms, thin client
>Reporter: Pavel Tupitsyn
>Assignee: Pavel Tupitsyn
>  Labels: .NET
> Fix For: 2.3
>
>
> Exception handling in thin client: response includes a success flag. Define 
> exception format protocol in case of failure.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)