[jira] [Commented] (IGNITE-6612) Wrap ack methods in their own class
[ https://issues.apache.org/jira/browse/IGNITE-6612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16488851#comment-16488851 ] ASF GitHub Bot commented on IGNITE-6612: Github user 1vanan closed the pull request at: https://github.com/apache/ignite/pull/3046 > Wrap ack methods in their own class > --- > > Key: IGNITE-6612 > URL: https://issues.apache.org/jira/browse/IGNITE-6612 > Project: Ignite > Issue Type: Improvement >Affects Versions: None >Reporter: Ivan Fedotov >Assignee: Ivan Fedotov >Priority: Trivial > Labels: refactor > Fix For: 2.6 > > > Several methods in IgniteKernal implement similar functions: “ackAsciiLogo”, > “ackConfigUrl”, “ackDaemon”, “ackOsInfo”, “ackLanguageRuntime”, > “ackRemoteManagement”, “ackVmArguments”, “ackClassPaths”, > “ackSystemProperties”, “ackEnviromentVariables”, “ackMemoryConfiguration”, > “ackCacheConfiguration”, “ackP2PConfiguration”, “ackRebalanceConfiguration”. > These methods should be placed in separate class “AckVariousInformation” and > called from the class instance in IgniteKernal. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-6612) Wrap ack methods in their own class
[ https://issues.apache.org/jira/browse/IGNITE-6612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16272338#comment-16272338 ] Ivan Fedotov commented on IGNITE-6612: -- The issue is ready for review. > Wrap ack methods in their own class > --- > > Key: IGNITE-6612 > URL: https://issues.apache.org/jira/browse/IGNITE-6612 > Project: Ignite > Issue Type: Improvement >Affects Versions: None >Reporter: Ivan Fedotov >Assignee: Ivan Fedotov >Priority: Trivial > Labels: refactor > Fix For: 2.4 > > > Several methods in IgniteKernal implement similar functions: “ackAsciiLogo”, > “ackConfigUrl”, “ackDaemon”, “ackOsInfo”, “ackLanguageRuntime”, > “ackRemoteManagement”, “ackVmArguments”, “ackClassPaths”, > “ackSystemProperties”, “ackEnviromentVariables”, “ackMemoryConfiguration”, > “ackCacheConfiguration”, “ackP2PConfiguration”, “ackRebalanceConfiguration”. > These methods should be placed in separate class “AckVariousInformation” and > called from the class instance in IgniteKernal. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
