[jira] [Commented] (IGNITE-6734) Java 9: do not use sun.misc.BASE64Encoder

2017-12-26 Thread Andrey Gura (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-6734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303906#comment-16303906
 ] 

Andrey Gura commented on IGNITE-6734:
-

LGTM. Merged to master. Thanks for contribution!

Note: this solution is temp. See IGNITE-7315.

> Java 9: do not use sun.misc.BASE64Encoder
> -
>
> Key: IGNITE-6734
> URL: https://issues.apache.org/jira/browse/IGNITE-6734
> Project: Ignite
>  Issue Type: Task
>  Components: general, rest
>Reporter: Vladimir Ozerov
>Assignee: Andrey Kuznetsov
> Fix For: 2.4
>
>
> For some reason we use {{sun.misc.BASE64Encoder}} in several places:
> 1) {{jiraslurp.groovy}}
> 2) Several REST-related classes in {{ignite-clients}} module.
> Need to remove this usages and use {{Base64}}. Note that this class is 
> available since Java 8. Hopefully we will move to Java 8 in the same release. 
> Otherwise we will have to apply some reflection-based hacks, I think.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-6734) Java 9: do not use sun.misc.BASE64Encoder

2017-12-26 Thread Andrey Kuznetsov (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-6734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303872#comment-16303872
 ] 

Andrey Kuznetsov commented on IGNITE-6734:
--

Switched to reflective approach. Created [1], it shoud be done after language 
level = 8. 

[1] https://issues.apache.org/jira/browse/IGNITE-7312

> Java 9: do not use sun.misc.BASE64Encoder
> -
>
> Key: IGNITE-6734
> URL: https://issues.apache.org/jira/browse/IGNITE-6734
> Project: Ignite
>  Issue Type: Task
>  Components: general, rest
>Reporter: Vladimir Ozerov
>Assignee: Andrey Kuznetsov
> Fix For: 2.4
>
>
> For some reason we use {{sun.misc.BASE64Encoder}} in several places:
> 1) {{jiraslurp.groovy}}
> 2) Several REST-related classes in {{ignite-clients}} module.
> Need to remove this usages and use {{Base64}}. Note that this class is 
> available since Java 8. Hopefully we will move to Java 8 in the same release. 
> Otherwise we will have to apply some reflection-based hacks, I think.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-6734) Java 9: do not use sun.misc.BASE64Encoder

2017-12-26 Thread Andrey Kuznetsov (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-6734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303779#comment-16303779
 ] 

Andrey Kuznetsov commented on IGNITE-6734:
--

[~vozerov], reflection will work, of course, as a temporary mean. But we 
planned to switch to 8th language level in 2.4.

> Java 9: do not use sun.misc.BASE64Encoder
> -
>
> Key: IGNITE-6734
> URL: https://issues.apache.org/jira/browse/IGNITE-6734
> Project: Ignite
>  Issue Type: Task
>  Components: general, rest
>Reporter: Vladimir Ozerov
>Assignee: Andrey Kuznetsov
> Fix For: 2.4
>
>
> For some reason we use {{sun.misc.BASE64Encoder}} in several places:
> 1) {{jiraslurp.groovy}}
> 2) Several REST-related classes in {{ignite-clients}} module.
> Need to remove this usages and use {{Base64}}. Note that this class is 
> available since Java 8. Hopefully we will move to Java 8 in the same release. 
> Otherwise we will have to apply some reflection-based hacks, I think.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-6734) Java 9: do not use sun.misc.BASE64Encoder

2017-12-26 Thread Vladimir Ozerov (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-6734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303770#comment-16303770
 ] 

Vladimir Ozerov commented on IGNITE-6734:
-

[~andrey-kuznetsov], why can't we use reflection and this avoid dependency on 
Java 8 upgrade?

> Java 9: do not use sun.misc.BASE64Encoder
> -
>
> Key: IGNITE-6734
> URL: https://issues.apache.org/jira/browse/IGNITE-6734
> Project: Ignite
>  Issue Type: Task
>  Components: general, rest
>Reporter: Vladimir Ozerov
>Assignee: Andrey Kuznetsov
> Fix For: 2.4
>
>
> For some reason we use {{sun.misc.BASE64Encoder}} in several places:
> 1) {{jiraslurp.groovy}}
> 2) Several REST-related classes in {{ignite-clients}} module.
> Need to remove this usages and use {{Base64}}. Note that this class is 
> available since Java 8. Hopefully we will move to Java 8 in the same release. 
> Otherwise we will have to apply some reflection-based hacks, I think.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-6734) Java 9: do not use sun.misc.BASE64Encoder

2017-12-21 Thread Andrey Kuznetsov (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-6734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16299945#comment-16299945
 ] 

Andrey Kuznetsov commented on IGNITE-6734:
--

This change is ready, just waits for changing to Java 8 project-wide.

> Java 9: do not use sun.misc.BASE64Encoder
> -
>
> Key: IGNITE-6734
> URL: https://issues.apache.org/jira/browse/IGNITE-6734
> Project: Ignite
>  Issue Type: Task
>  Components: general, rest
>Reporter: Vladimir Ozerov
>Assignee: Andrey Kuznetsov
> Fix For: 2.4
>
>
> For some reason we use {{sun.misc.BASE64Encoder}} in several places:
> 1) {{jiraslurp.groovy}}
> 2) Several REST-related classes in {{ignite-clients}} module.
> Need to remove this usages and use {{Base64}}. Note that this class is 
> available since Java 8. Hopefully we will move to Java 8 in the same release. 
> Otherwise we will have to apply some reflection-based hacks, I think.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)