[jira] [Commented] (IGNITE-6811) JDBC Thin: SQLException("Batch is empty.") when batch list is empty
[
https://issues.apache.org/jira/browse/IGNITE-6811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16663647#comment-16663647
]
ASF GitHub Bot commented on IGNITE-6811:
Github user asfgit closed the pull request at:
https://github.com/apache/ignite/pull/5051
> JDBC Thin: SQLException("Batch is empty.") when batch list is empty
> ---
>
> Key: IGNITE-6811
> URL: https://issues.apache.org/jira/browse/IGNITE-6811
> Project: Ignite
> Issue Type: Bug
> Components: jdbc
>Affects Versions: 2.3
>Reporter: Vasily Bukharev
>Assignee: Pavel Kuznetsov
>Priority: Trivial
> Fix For: 2.8
>
>
> The method executeBatch() throws SQLException("Batch is empty.") when batch
> list is empty.
> The api doc of java.sql.Statement.executeBatch()
> does not require an exception to be thrown in such situation.
> I guess it is more convinient for client code if the exception is not thrown.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-6811) JDBC Thin: SQLException("Batch is empty.") when batch list is empty
[
https://issues.apache.org/jira/browse/IGNITE-6811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16662512#comment-16662512
]
Pavel Kuznetsov commented on IGNITE-6811:
-
removed merge conflicts; re-ran only SQL tests:
https://ci.ignite.apache.org/viewQueued.html?itemId=2157062
> JDBC Thin: SQLException("Batch is empty.") when batch list is empty
> ---
>
> Key: IGNITE-6811
> URL: https://issues.apache.org/jira/browse/IGNITE-6811
> Project: Ignite
> Issue Type: Bug
> Components: jdbc
>Affects Versions: 2.3
>Reporter: Vasily Bukharev
>Assignee: Pavel Kuznetsov
>Priority: Trivial
>
> The method executeBatch() throws SQLException("Batch is empty.") when batch
> list is empty.
> The api doc of java.sql.Statement.executeBatch()
> does not require an exception to be thrown in such situation.
> I guess it is more convinient for client code if the exception is not thrown.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-6811) JDBC Thin: SQLException("Batch is empty.") when batch list is empty
[
https://issues.apache.org/jira/browse/IGNITE-6811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16662473#comment-16662473
]
Pavel Kuznetsov commented on IGNITE-6811:
-
Changes are trivial and are located only in Jdbc thin driver, so problems seems
to be not related to this changes.
> JDBC Thin: SQLException("Batch is empty.") when batch list is empty
> ---
>
> Key: IGNITE-6811
> URL: https://issues.apache.org/jira/browse/IGNITE-6811
> Project: Ignite
> Issue Type: Bug
> Components: jdbc
>Affects Versions: 2.3
>Reporter: Vasily Bukharev
>Assignee: Pavel Kuznetsov
>Priority: Trivial
>
> The method executeBatch() throws SQLException("Batch is empty.") when batch
> list is empty.
> The api doc of java.sql.Statement.executeBatch()
> does not require an exception to be thrown in such situation.
> I guess it is more convinient for client code if the exception is not thrown.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-6811) JDBC Thin: SQLException("Batch is empty.") when batch list is empty
[
https://issues.apache.org/jira/browse/IGNITE-6811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16662470#comment-16662470
]
Ignite TC Bot commented on IGNITE-6811:
---
{panel:title=Possible
Blockers|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}
{color:#d04437}Queries (Binary Objects Simple Mapper){color} [[tests 0 TIMEOUT
, Exit Code |https://ci.ignite.apache.org/viewLog.html?buildId=2148134]]
* IgniteSqlSplitterSelfTest.testDistributedJoinsPlan (last started)
{color:#d04437}MVCC Cache{color} [[tests 0 TIMEOUT , Exit Code
|https://ci.ignite.apache.org/viewLog.html?buildId=2148084]]
{color:#d04437}Queries 1{color} [[tests
1|https://ci.ignite.apache.org/viewLog.html?buildId=2148135]]
* IgniteBinaryCacheQueryTestSuite:
OptimizedMarshallerIndexNameTest.testOptimizedMarshallerIndex - 0,0% fails in
last 100 master runs.
{color:#d04437}Cache 1{color} [[tests
2|https://ci.ignite.apache.org/viewLog.html?buildId=2148103]]
* IgniteBinaryCacheTestSuite:
IgniteCacheEntryListenerTxReplicatedTest.testNoOldValue - 0,0% fails in last
100 master runs.
* IgniteBinaryCacheTestSuite:
IgniteCacheEntryListenerTxReplicatedTest.testSynchronousEvents - 0,0% fails in
last 100 master runs.
{color:#d04437}PDS 1{color} [[tests
2|https://ci.ignite.apache.org/viewLog.html?buildId=2148124]]
* IgnitePdsTestSuite:
IgnitePdsDestroyCacheWithoutCheckpointsTest.testDestroyCachesAbruptlyWithoutCheckpoints
- 0,0% fails in last 100 master runs.
* IgnitePdsTestSuite:
BPlusTreeReuseListPageMemoryImplTest.testMassiveRemove2_true - 0,0% fails in
last 100 master runs.
{color:#d04437}Compute (Grid){color} [[tests
1|https://ci.ignite.apache.org/viewLog.html?buildId=2148040]]
* IgniteBinaryObjectsComputeGridTestSuite:
GridEventStorageCheckAllEventsSelfTest.testFailoverJobTask - 0,0% fails in last
100 master runs.
{panel}
[TeamCity Run
All|http://ci.ignite.apache.org/viewLog.html?buildId=2148137buildTypeId=IgniteTests24Java8_RunAll]
> JDBC Thin: SQLException("Batch is empty.") when batch list is empty
> ---
>
> Key: IGNITE-6811
> URL: https://issues.apache.org/jira/browse/IGNITE-6811
> Project: Ignite
> Issue Type: Bug
> Components: jdbc
>Affects Versions: 2.3
>Reporter: Vasily Bukharev
>Assignee: Pavel Kuznetsov
>Priority: Trivial
>
> The method executeBatch() throws SQLException("Batch is empty.") when batch
> list is empty.
> The api doc of java.sql.Statement.executeBatch()
> does not require an exception to be thrown in such situation.
> I guess it is more convinient for client code if the exception is not thrown.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-6811) JDBC Thin: SQLException("Batch is empty.") when batch list is empty
[
https://issues.apache.org/jira/browse/IGNITE-6811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16660560#comment-16660560
]
Pavel Kuznetsov commented on IGNITE-6811:
-
Sure, fixed JdbcThinStatementSelfTest.testBatchEmpty - I forgot to update it
The other tests seems to be flacky
Run All: https://ci.ignite.apache.org/viewQueued.html?itemId=2148137
> JDBC Thin: SQLException("Batch is empty.") when batch list is empty
> ---
>
> Key: IGNITE-6811
> URL: https://issues.apache.org/jira/browse/IGNITE-6811
> Project: Ignite
> Issue Type: Bug
> Components: jdbc
>Affects Versions: 2.3
>Reporter: Vasily Bukharev
>Assignee: Pavel Kuznetsov
>Priority: Trivial
>
> The method executeBatch() throws SQLException("Batch is empty.") when batch
> list is empty.
> The api doc of java.sql.Statement.executeBatch()
> does not require an exception to be thrown in such situation.
> I guess it is more convinient for client code if the exception is not thrown.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-6811) JDBC Thin: SQLException("Batch is empty.") when batch list is empty
[
https://issues.apache.org/jira/browse/IGNITE-6811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659484#comment-16659484
]
ASF GitHub Bot commented on IGNITE-6811:
GitHub user pavel-kuznetsov opened a pull request:
https://github.com/apache/ignite/pull/5051
IGNITE-6811: Allowed empty batch in JDBC thin driver.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gridgain/apache-ignite ignite-6811
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ignite/pull/5051.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5051
commit 7cd8faa9280c9708989604f17c1859f25450a6b5
Author: Pavel Kuznetsov
Date: 2018-10-22T14:30:01Z
ignite-6811: Added tests that reproduce the bug.
When streaming is OFF we can't perform empty batch neither for Statement
nor for PreparedStatement.
commit 7cd9dd1b250655b19dafd95ad54ced751ab6f3c9
Author: Pavel Kuznetsov
Date: 2018-10-22T15:19:38Z
ignite-6811: Fixed empty batch.
Now if empty batch is executed, no error is thrown. Empty updates counts
array is returned. This is done due to usability reasons.
commit 6ed512e24f3e0184f1ad9236dbe2e518942324c4
Author: Pavel Kuznetsov
Date: 2018-10-22T15:53:21Z
Merge remote-tracking branch 'origin/master' into ignite-6811
> JDBC Thin: SQLException("Batch is empty.") when batch list is empty
> ---
>
> Key: IGNITE-6811
> URL: https://issues.apache.org/jira/browse/IGNITE-6811
> Project: Ignite
> Issue Type: Bug
> Components: jdbc
>Affects Versions: 2.3
>Reporter: Vasily Bukharev
>Assignee: Pavel Kuznetsov
>Priority: Trivial
>
> The method executeBatch() throws SQLException("Batch is empty.") when batch
> list is empty.
> The api doc of java.sql.Statement.executeBatch()
> does not require an exception to be thrown in such situation.
> I guess it is more convinient for client code if the exception is not thrown.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-6811) JDBC Thin: SQLException("Batch is empty.") when batch list is empty
[
https://issues.apache.org/jira/browse/IGNITE-6811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659107#comment-16659107
]
Pavel Kuznetsov commented on IGNITE-6811:
-
SQL Test run: https://ci.ignite.apache.org/viewQueued.html?itemId=2140637
> JDBC Thin: SQLException("Batch is empty.") when batch list is empty
> ---
>
> Key: IGNITE-6811
> URL: https://issues.apache.org/jira/browse/IGNITE-6811
> Project: Ignite
> Issue Type: Bug
> Components: jdbc
>Affects Versions: 2.3
>Reporter: Vasily Bukharev
>Assignee: Pavel Kuznetsov
>Priority: Trivial
>
> The method executeBatch() throws SQLException("Batch is empty.") when batch
> list is empty.
> The api doc of java.sql.Statement.executeBatch()
> does not require an exception to be thrown in such situation.
> I guess it is more convinient for client code if the exception is not thrown.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
