[jira] [Commented] (IGNITE-7114) CPP: C++ node can't start without java examples folder
[
https://issues.apache.org/jira/browse/IGNITE-7114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16409423#comment-16409423
]
ASF GitHub Bot commented on IGNITE-7114:
Github user isapego closed the pull request at:
https://github.com/apache/ignite/pull/3160
> CPP: C++ node can't start without java examples folder
> --
>
> Key: IGNITE-7114
> URL: https://issues.apache.org/jira/browse/IGNITE-7114
> Project: Ignite
> Issue Type: Bug
> Components: platforms
>Affects Versions: 2.1
>Reporter: Evgenii Zhuravlev
>Assignee: Igor Sapego
>Priority: Critical
> Fix For: 2.4
>
> Attachments: sample.png
>
>
> Error message:
> ERROR: Java classpath is empty (did you set {{IGNITE_HOME}} environment
> variable?)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-7114) CPP: C++ node can't start without java examples folder
[
https://issues.apache.org/jira/browse/IGNITE-7114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16285987#comment-16285987
]
Sergey Kalashnikov commented on IGNITE-7114:
[~isapego], I did review the code and I'm OK with the changes.
> CPP: C++ node can't start without java examples folder
> --
>
> Key: IGNITE-7114
> URL: https://issues.apache.org/jira/browse/IGNITE-7114
> Project: Ignite
> Issue Type: Bug
> Components: platforms
>Affects Versions: 2.1
>Reporter: Evgenii Zhuravlev
>Assignee: Igor Sapego
>Priority: Critical
> Fix For: 2.4
>
> Attachments: sample.png
>
>
> Error message:
> ERROR: Java classpath is empty (did you set {{IGNITE_HOME}} environment
> variable?)
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (IGNITE-7114) CPP: C++ node can't start without java examples folder
[
https://issues.apache.org/jira/browse/IGNITE-7114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16285619#comment-16285619
]
Alexey Popov commented on IGNITE-7114:
--
[~isapego], it should be detected. Btw, changes look good for me too.
> CPP: C++ node can't start without java examples folder
> --
>
> Key: IGNITE-7114
> URL: https://issues.apache.org/jira/browse/IGNITE-7114
> Project: Ignite
> Issue Type: Bug
> Components: platforms
>Affects Versions: 2.1
>Reporter: Evgenii Zhuravlev
>Assignee: Igor Sapego
>Priority: Critical
> Fix For: 2.4
>
> Attachments: sample.png
>
>
> Error message:
> ERROR: Java classpath is empty (did you set {{IGNITE_HOME}} environment
> variable?)
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (IGNITE-7114) CPP: C++ node can't start without java examples folder
[
https://issues.apache.org/jira/browse/IGNITE-7114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16283415#comment-16283415
]
Igor Sapego commented on IGNITE-7114:
-
[~ptupitsyn], it's an inherent thing. I've created a ticket to remove code
duplication - IGNITE-7151.
> CPP: C++ node can't start without java examples folder
> --
>
> Key: IGNITE-7114
> URL: https://issues.apache.org/jira/browse/IGNITE-7114
> Project: Ignite
> Issue Type: Bug
> Components: platforms
>Affects Versions: 2.1
>Reporter: Evgenii Zhuravlev
>Assignee: Igor Sapego
>Priority: Critical
> Fix For: 2.4
>
> Attachments: sample.png
>
>
> Error message:
> ERROR: Java classpath is empty (did you set {{IGNITE_HOME}} environment
> variable?)
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (IGNITE-7114) CPP: C++ node can't start without java examples folder
[
https://issues.apache.org/jira/browse/IGNITE-7114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16281974#comment-16281974
]
Pavel Tupitsyn commented on IGNITE-7114:
[~isapego] logic looks good to me, but there is a lot of code duplication.
I thin Windows and Linux logic differs only in path separators and jvm library
names, so all the logic can be shared.
> CPP: C++ node can't start without java examples folder
> --
>
> Key: IGNITE-7114
> URL: https://issues.apache.org/jira/browse/IGNITE-7114
> Project: Ignite
> Issue Type: Bug
> Components: platforms
>Affects Versions: 2.1
>Reporter: Evgenii Zhuravlev
>Assignee: Igor Sapego
>Priority: Critical
> Fix For: 2.4
>
> Attachments: sample.png
>
>
> Error message:
> ERROR: Java classpath is empty (did you set {{IGNITE_HOME}} environment
> variable?)
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (IGNITE-7114) CPP: C++ node can't start without java examples folder
[
https://issues.apache.org/jira/browse/IGNITE-7114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16281940#comment-16281940
]
Igor Sapego commented on IGNITE-7114:
-
[~ptupitsyn], can you take a look on a new version?
> CPP: C++ node can't start without java examples folder
> --
>
> Key: IGNITE-7114
> URL: https://issues.apache.org/jira/browse/IGNITE-7114
> Project: Ignite
> Issue Type: Bug
> Components: platforms
>Affects Versions: 2.1
>Reporter: Evgenii Zhuravlev
>Assignee: Igor Sapego
>Priority: Critical
> Fix For: 2.4
>
> Attachments: sample.png
>
>
> Error message:
> ERROR: Java classpath is empty (did you set {{IGNITE_HOME}} environment
> variable?)
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (IGNITE-7114) CPP: C++ node can't start without java examples folder
[
https://issues.apache.org/jira/browse/IGNITE-7114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16281894#comment-16281894
]
Igor Sapego commented on IGNITE-7114:
-
[~apopov], I've seen the attached file. So should it be detected or should not?
By the way, these checks only used when user did not provide us {{IGNITE_HOME}}
and we are trying to find it by ourselves. If user provides us {{IGNITE_HOME}}
that points to any existent directory, no additional checks performed now, so
user can rename libs however they want now, if only he point out
{{IGNITE_HOME}} for us.
> CPP: C++ node can't start without java examples folder
> --
>
> Key: IGNITE-7114
> URL: https://issues.apache.org/jira/browse/IGNITE-7114
> Project: Ignite
> Issue Type: Bug
> Components: platforms
>Affects Versions: 2.1
>Reporter: Evgenii Zhuravlev
>Assignee: Igor Sapego
>Priority: Critical
> Fix For: 2.4
>
> Attachments: sample.png
>
>
> Error message:
> ERROR: Java classpath is empty (did you set {{IGNITE_HOME}} environment
> variable?)
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (IGNITE-7114) CPP: C++ node can't start without java examples folder
[
https://issues.apache.org/jira/browse/IGNITE-7114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16281874#comment-16281874
]
Alexey Popov commented on IGNITE-7114:
--
[~isapego], please see the attached .png. It has {{/libs/ignite-core.jar}}
file.
{{/libs/ignite-core*.jar}} is ok
> CPP: C++ node can't start without java examples folder
> --
>
> Key: IGNITE-7114
> URL: https://issues.apache.org/jira/browse/IGNITE-7114
> Project: Ignite
> Issue Type: Bug
> Components: platforms
>Affects Versions: 2.1
>Reporter: Evgenii Zhuravlev
>Assignee: Igor Sapego
>Priority: Critical
> Fix For: 2.4
>
> Attachments: sample.png
>
>
> Error message:
> ERROR: Java classpath is empty (did you set {{IGNITE_HOME}} environment
> variable?)
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (IGNITE-7114) CPP: C++ node can't start without java examples folder
[
https://issues.apache.org/jira/browse/IGNITE-7114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16281863#comment-16281863
]
Igor Sapego commented on IGNITE-7114:
-
[~apopov], what do you mean by "check the absence of "-x.y.z" part with some
error indication"?
Currently, I simply check for existence of the {{/libs/ignite-core*.jar}} file.
Is it Ok for your case?
> CPP: C++ node can't start without java examples folder
> --
>
> Key: IGNITE-7114
> URL: https://issues.apache.org/jira/browse/IGNITE-7114
> Project: Ignite
> Issue Type: Bug
> Components: platforms
>Affects Versions: 2.1
>Reporter: Evgenii Zhuravlev
>Assignee: Igor Sapego
>Priority: Critical
> Fix For: 2.4
>
> Attachments: sample.png
>
>
> Error message:
> ERROR: Java classpath is empty (did you set {{IGNITE_HOME}} environment
> variable?)
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (IGNITE-7114) CPP: C++ node can't start without java examples folder
[
https://issues.apache.org/jira/browse/IGNITE-7114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16281747#comment-16281747
]
Alexey Popov commented on IGNITE-7114:
--
just FYI, sample files for regexp:
ignite-core-2.1.7-p1.jar
ignite-core-2.1.7.b3.jar
> CPP: C++ node can't start without java examples folder
> --
>
> Key: IGNITE-7114
> URL: https://issues.apache.org/jira/browse/IGNITE-7114
> Project: Ignite
> Issue Type: Bug
> Components: platforms
>Affects Versions: 2.1
>Reporter: Evgenii Zhuravlev
>Assignee: Igor Sapego
>Priority: Critical
> Fix For: 2.4
>
> Attachments: sample.png
>
>
> Error message:
> ERROR: Java classpath is empty (did you set {{IGNITE_HOME}} environment
> variable?)
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (IGNITE-7114) CPP: C++ node can't start without java examples folder
[
https://issues.apache.org/jira/browse/IGNITE-7114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16281740#comment-16281740
]
Alexey Popov commented on IGNITE-7114:
--
[~isapego], Please look through the attached sample.png. Can you please check
the absence of "-x.y.z" part with some error indication as well. That's a
real-world example )
> CPP: C++ node can't start without java examples folder
> --
>
> Key: IGNITE-7114
> URL: https://issues.apache.org/jira/browse/IGNITE-7114
> Project: Ignite
> Issue Type: Bug
> Components: platforms
>Affects Versions: 2.1
>Reporter: Evgenii Zhuravlev
>Assignee: Igor Sapego
>Priority: Critical
> Fix For: 2.4
>
> Attachments: sample.png
>
>
> Error message:
> ERROR: Java classpath is empty (did you set {{IGNITE_HOME}} environment
> variable?)
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (IGNITE-7114) CPP: C++ node can't start without java examples folder
[
https://issues.apache.org/jira/browse/IGNITE-7114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16281622#comment-16281622
]
Igor Sapego commented on IGNITE-7114:
-
[~ptupitsyn], agree. I'll try to implement proposed logic.
> CPP: C++ node can't start without java examples folder
> --
>
> Key: IGNITE-7114
> URL: https://issues.apache.org/jira/browse/IGNITE-7114
> Project: Ignite
> Issue Type: Bug
> Components: platforms
>Affects Versions: 2.1
>Reporter: Evgenii Zhuravlev
>Assignee: Igor Sapego
>Priority: Critical
> Fix For: 2.4
>
>
> Error message:
> ERROR: Java classpath is empty (did you set {{IGNITE_HOME}} environment
> variable?)
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (IGNITE-7114) CPP: C++ node can't start without java examples folder
[
https://issues.apache.org/jira/browse/IGNITE-7114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16280557#comment-16280557
]
Pavel Tupitsyn commented on IGNITE-7114:
[~isapego] source release logic looks good to me.
But for binary releases I would check {{libs\ignite-core-x.y.z.jar}} presence
instead of {{ignite-indexing}} and {{ignite-spring}} folders, because that is
the main JAR file, and you can run Ignite without indexing or spring.
> CPP: C++ node can't start without java examples folder
> --
>
> Key: IGNITE-7114
> URL: https://issues.apache.org/jira/browse/IGNITE-7114
> Project: Ignite
> Issue Type: Bug
> Components: platforms
>Affects Versions: 2.1
>Reporter: Evgenii Zhuravlev
>Assignee: Igor Sapego
>Priority: Critical
> Fix For: 2.4
>
>
> Error message:
> ERROR: Java classpath is empty (did you set {{IGNITE_HOME}} environment
> variable?)
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
