[jira] [Commented] (IGNITE-7454) Wrong package in IgniteExamplesMLTestSuite after it was moved per IGNITE-7203
[
https://issues.apache.org/jira/browse/IGNITE-7454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16328750#comment-16328750
]
ASF GitHub Bot commented on IGNITE-7454:
GitHub user oignatenko opened a pull request:
https://github.com/apache/ignite/pull/3393
IGNITE-7454 Wrong package in IgniteExamplesMLTestSuite
- completed work for ML examples
-- verified with diffs overview, clean rebuild and execution of
IgniteExamplesSelfTestSuite
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gridgain/apache-ignite ignite-7203-ml-examples
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ignite/pull/3393.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3393
> Wrong package in IgniteExamplesMLTestSuite after it was moved per IGNITE-7203
> -
>
> Key: IGNITE-7454
> URL: https://issues.apache.org/jira/browse/IGNITE-7454
> Project: Ignite
> Issue Type: Bug
> Components: examples, ml
>Reporter: Oleg Ignatenko
>Assignee: Oleg Ignatenko
>Priority: Major
> Fix For: 2.4
>
>
> Wrong package in IgniteExamplesMLTestSuite after it was moved per
> IGNITE-7203: \{{org.apache.ignite.ml.testsuites}}. Also, it is not added to
> the list in {{IgniteExamplesSelfTestSuite{{ which is supposed to run all
> examples self-tests.
> Change to correct package: \{{org.apache.ignite.testsuites}} and add to main
> testsuite.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-7454) Wrong package in IgniteExamplesMLTestSuite after it was moved per IGNITE-7203
[
https://issues.apache.org/jira/browse/IGNITE-7454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16330258#comment-16330258
]
Peter Ivanov commented on IGNITE-7454:
--
As much as I see, Java specification does not force classes to be in certain
directories. And *Package name does not correspond to the file path* error is
strictly IntelliJ IDEA's one.
> Wrong package in IgniteExamplesMLTestSuite after it was moved per IGNITE-7203
> -
>
> Key: IGNITE-7454
> URL: https://issues.apache.org/jira/browse/IGNITE-7454
> Project: Ignite
> Issue Type: Bug
> Components: examples, ml, yardstick
>Reporter: Oleg Ignatenko
>Assignee: Oleg Ignatenko
>Priority: Major
> Fix For: 2.4
>
>
> Wrong package in IgniteExamplesMLTestSuite after it was moved per
> IGNITE-7203: \{{org.apache.ignite.ml.testsuites}}. Also, it is not added to
> the list in {{IgniteExamplesSelfTestSuite{{ which is supposed to run all
> examples self-tests.
> Change to correct package: \{{org.apache.ignite.testsuites}} and add to main
> testsuite.
> For the sake of completeness, a bunch of newer ml benchmarks (done per
> IGNITE-7214 and IGNITE-7097) were forgotten to be moved in yardstick module
> when merging to master. These should be fixed (moved to proper folder).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-7454) Wrong package in IgniteExamplesMLTestSuite after it was moved per IGNITE-7203
[
https://issues.apache.org/jira/browse/IGNITE-7454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16330259#comment-16330259
]
Peter Ivanov commented on IGNITE-7454:
--
As much as I see, Java specification does not force classes to be in certain
directories. And *Package name does not correspond to the file path* error is
strictly IntelliJ IDEA's one.
> Wrong package in IgniteExamplesMLTestSuite after it was moved per IGNITE-7203
> -
>
> Key: IGNITE-7454
> URL: https://issues.apache.org/jira/browse/IGNITE-7454
> Project: Ignite
> Issue Type: Bug
> Components: examples, ml, yardstick
>Reporter: Oleg Ignatenko
>Assignee: Oleg Ignatenko
>Priority: Major
> Fix For: 2.4
>
>
> Wrong package in IgniteExamplesMLTestSuite after it was moved per
> IGNITE-7203: \{{org.apache.ignite.ml.testsuites}}. Also, it is not added to
> the list in {{IgniteExamplesSelfTestSuite{{ which is supposed to run all
> examples self-tests.
> Change to correct package: \{{org.apache.ignite.testsuites}} and add to main
> testsuite.
> For the sake of completeness, a bunch of newer ml benchmarks (done per
> IGNITE-7214 and IGNITE-7097) were forgotten to be moved in yardstick module
> when merging to master. These should be fixed (moved to proper folder).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-7454) Wrong package in IgniteExamplesMLTestSuite after it was moved per IGNITE-7203
[
https://issues.apache.org/jira/browse/IGNITE-7454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16330900#comment-16330900
]
Oleg Ignatenko commented on IGNITE-7454:
Confirmed above observation from [~vveider]: "incorrect" package indeed doesn't
break the compilation. I just tested this by creating a trial class in some
code I worked with injected artificial package name that didn't match
containing directory: build with {{mvn clean package}} passed successfully.
^^^ [~avinogradov] - you might be interested in this as we yesterday discussed
this issue. You may even try similar test with your own code - it turned out
very easy to make and try and see for yourself.
> Wrong package in IgniteExamplesMLTestSuite after it was moved per IGNITE-7203
> -
>
> Key: IGNITE-7454
> URL: https://issues.apache.org/jira/browse/IGNITE-7454
> Project: Ignite
> Issue Type: Bug
> Components: examples, ml, yardstick
>Reporter: Oleg Ignatenko
>Assignee: Oleg Ignatenko
>Priority: Major
> Fix For: 2.4
>
>
> Wrong package in IgniteExamplesMLTestSuite after it was moved per
> IGNITE-7203: \{{org.apache.ignite.ml.testsuites}}. Also, it is not added to
> the list in {{IgniteExamplesSelfTestSuite{{ which is supposed to run all
> examples self-tests.
> Change to correct package: \{{org.apache.ignite.testsuites}} and add to main
> testsuite.
> For the sake of completeness, a bunch of newer ml benchmarks (done per
> IGNITE-7214 and IGNITE-7097) were forgotten to be moved in yardstick module
> when merging to master. These should be fixed (moved to proper folder).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-7454) Wrong package in IgniteExamplesMLTestSuite after it was moved per IGNITE-7203
[
https://issues.apache.org/jira/browse/IGNITE-7454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16332156#comment-16332156
]
ASF GitHub Bot commented on IGNITE-7454:
Github user asfgit closed the pull request at:
https://github.com/apache/ignite/pull/3393
> Wrong package in IgniteExamplesMLTestSuite after it was moved per IGNITE-7203
> -
>
> Key: IGNITE-7454
> URL: https://issues.apache.org/jira/browse/IGNITE-7454
> Project: Ignite
> Issue Type: Bug
> Components: examples, ml, yardstick
>Reporter: Oleg Ignatenko
>Assignee: Oleg Ignatenko
>Priority: Major
> Fix For: 2.4
>
>
> Wrong package in IgniteExamplesMLTestSuite after it was moved per
> IGNITE-7203: \{{org.apache.ignite.ml.testsuites}}. Also, it is not added to
> the list in {{IgniteExamplesSelfTestSuite{{ which is supposed to run all
> examples self-tests.
> Change to correct package: \{{org.apache.ignite.testsuites}} and add to main
> testsuite.
> For the sake of completeness, a bunch of newer ml benchmarks (done per
> IGNITE-7214 and IGNITE-7097) were forgotten to be moved in yardstick module
> when merging to master. These should be fixed (moved to proper folder).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
