[jira] [Commented] (IGNITE-7648) Fix IGNITE_ENABLE_FORCIBLE_NODE_KILL system property.
[ https://issues.apache.org/jira/browse/IGNITE-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16763557#comment-16763557 ] Pavel Voronkin commented on IGNITE-7648: We changed behaviour of ENABLED_FORCIBLE_NODE_KILL=true in this ticket. Only server node can kill client node in case if property is enabled. client can't kill server, server can't kill server. Timeout logic changed in case of failure detection enabled scenario We start connect and hanshake from timeout 500ms. If failed we increase timeout using exponential backoff strategy timeout = Math.min(Math.min(timeout * 2, maxTimeout), remainingTiimeTillFailureDetection) > Fix IGNITE_ENABLE_FORCIBLE_NODE_KILL system property. > - > > Key: IGNITE-7648 > URL: https://issues.apache.org/jira/browse/IGNITE-7648 > Project: Ignite > Issue Type: Improvement >Affects Versions: 2.3 >Reporter: Alexei Scherbakov >Assignee: Pavel Voronkin >Priority: Major > Fix For: 2.8 > > > IGNITE_ENABLE_FORCIBLE_NODE_KILL system property was introduced in > IGNITE-5718 as a way to prevent unnecessary node drops in case of short > network problems. > I suppose it's wrong decision to fix it in such way. > We had faced some issues in our production due to lack of automatic kicking > of ill-behaving nodes (on example, hanging due to long GC pauses) until we > realised the necessity of changing default behavior via property. > Right solution is to kick nodes only if failure threshold is reached. Such > behavior should be always enabled. > UPDATE: During a discussion it was decided what the property will remain > disabled by default. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-7648) Fix IGNITE_ENABLE_FORCIBLE_NODE_KILL system property.
[ https://issues.apache.org/jira/browse/IGNITE-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16763556#comment-16763556 ] Pavel Voronkin commented on IGNITE-7648: We changed behaviour of ENABLED_FORCIBLE_NODE_KILL=true in this ticket. Only server node can kill client node in case if property is enabled. client can't kill server, server can't kill server. Timeout logic changed in case of failure detection enabled scenario We start connect and hanshake from timeout 500ms. If failed we increase timeout using exponential backoff strategy timeout = Math.min(Math.min(timeout * 2, maxTimeout), remainingTiimeTillFailureDetection) > Fix IGNITE_ENABLE_FORCIBLE_NODE_KILL system property. > - > > Key: IGNITE-7648 > URL: https://issues.apache.org/jira/browse/IGNITE-7648 > Project: Ignite > Issue Type: Improvement >Affects Versions: 2.3 >Reporter: Alexei Scherbakov >Assignee: Pavel Voronkin >Priority: Major > Fix For: 2.8 > > > IGNITE_ENABLE_FORCIBLE_NODE_KILL system property was introduced in > IGNITE-5718 as a way to prevent unnecessary node drops in case of short > network problems. > I suppose it's wrong decision to fix it in such way. > We had faced some issues in our production due to lack of automatic kicking > of ill-behaving nodes (on example, hanging due to long GC pauses) until we > realised the necessity of changing default behavior via property. > Right solution is to kick nodes only if failure threshold is reached. Such > behavior should be always enabled. > UPDATE: During a discussion it was decided what the property will remain > disabled by default. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-7648) Fix IGNITE_ENABLE_FORCIBLE_NODE_KILL system property.
[
https://issues.apache.org/jira/browse/IGNITE-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762541#comment-16762541
]
Ignite TC Bot commented on IGNITE-7648:
---
{panel:title=-- Run :: All: No blockers
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
[TeamCity *-- Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=3020115buildTypeId=IgniteTests24Java8_RunAll]
> Fix IGNITE_ENABLE_FORCIBLE_NODE_KILL system property.
> -
>
> Key: IGNITE-7648
> URL: https://issues.apache.org/jira/browse/IGNITE-7648
> Project: Ignite
> Issue Type: Improvement
>Affects Versions: 2.3
>Reporter: Alexei Scherbakov
>Assignee: Pavel Voronkin
>Priority: Major
> Fix For: 2.8
>
>
> IGNITE_ENABLE_FORCIBLE_NODE_KILL system property was introduced in
> IGNITE-5718 as a way to prevent unnecessary node drops in case of short
> network problems.
> I suppose it's wrong decision to fix it in such way.
> We had faced some issues in our production due to lack of automatic kicking
> of ill-behaving nodes (on example, hanging due to long GC pauses) until we
> realised the necessity of changing default behavior via property.
> Right solution is to kick nodes only if failure threshold is reached. Such
> behavior should be always enabled.
> UPDATE: During a discussion it was decided what the property will remain
> disabled by default.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-7648) Fix IGNITE_ENABLE_FORCIBLE_NODE_KILL system property.
[
https://issues.apache.org/jira/browse/IGNITE-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16761519#comment-16761519
]
Ignite TC Bot commented on IGNITE-7648:
---
{panel:title=-- Run :: All: No blockers
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
[TeamCity *-- Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=3004295buildTypeId=IgniteTests24Java8_RunAll]
> Fix IGNITE_ENABLE_FORCIBLE_NODE_KILL system property.
> -
>
> Key: IGNITE-7648
> URL: https://issues.apache.org/jira/browse/IGNITE-7648
> Project: Ignite
> Issue Type: Improvement
>Affects Versions: 2.3
>Reporter: Alexei Scherbakov
>Assignee: Pavel Voronkin
>Priority: Major
> Fix For: 2.8
>
>
> IGNITE_ENABLE_FORCIBLE_NODE_KILL system property was introduced in
> IGNITE-5718 as a way to prevent unnecessary node drops in case of short
> network problems.
> I suppose it's wrong decision to fix it in such way.
> We had faced some issues in our production due to lack of automatic kicking
> of ill-behaving nodes (on example, hanging due to long GC pauses) until we
> realised the necessity of changing default behavior via property.
> Right solution is to kick nodes only if failure threshold is reached. Such
> behavior should be always enabled.
> UPDATE: During a discussion it was decided what the property will remain
> disabled by default.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-7648) Fix IGNITE_ENABLE_FORCIBLE_NODE_KILL system property.
[ https://issues.apache.org/jira/browse/IGNITE-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16760895#comment-16760895 ] Alexei Scherbakov commented on IGNITE-7648: --- [~voropava] I left some comments if PR. > Fix IGNITE_ENABLE_FORCIBLE_NODE_KILL system property. > - > > Key: IGNITE-7648 > URL: https://issues.apache.org/jira/browse/IGNITE-7648 > Project: Ignite > Issue Type: Improvement >Affects Versions: 2.3 >Reporter: Alexei Scherbakov >Assignee: Pavel Voronkin >Priority: Major > Fix For: 2.8 > > > IGNITE_ENABLE_FORCIBLE_NODE_KILL system property was introduced in > IGNITE-5718 as a way to prevent unnecessary node drops in case of short > network problems. > I suppose it's wrong decision to fix it in such way. > We had faced some issues in our production due to lack of automatic kicking > of ill-behaving nodes (on example, hanging due to long GC pauses) until we > realised the necessity of changing default behavior via property. > Right solution is to kick nodes only if failure threshold is reached. Such > behavior should be always enabled. > UPDATE: During a discussion it was decided what the property will remain > disabled by default. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-7648) Fix IGNITE_ENABLE_FORCIBLE_NODE_KILL system property.
[ https://issues.apache.org/jira/browse/IGNITE-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16742056#comment-16742056 ] Alexei Scherbakov commented on IGNITE-7648: --- [~voropava], I have concerns about your recent changes in the branch. # Removing waiting logic in handling socket exception seems wrong because it detracts main idea of the fix - try to establish connection with exact respect to user defined reconnect and timeout properties. If failure detection is set equal to 10 seconds TCP client have to try no less than 10 seconds. Consider the case when connection cannot be established due to short network issue and connect fails immediately and reconnect count is small. In such case defined failure detection will not be respected and destination node will be failed false positively. This is why the IGNITE_ENABLE_FORCIBLE_NODE_KILL was introduced in the first time, see IGNITE-5718. I suggest to return waiting logic and undo wrong test condition in TcpCommunicationSpiFaultyClientTest and make sure it works in all cases in the described way. # handshakeTimeoutException should contain suppressed IOException if it's happened after timeout in *safeTcpHandshake*. # Please remove all explicit timeout overrides from tests, on example from o.a.i.i.processors.cache.index.SchemaExchangeSelfTest#startNoCache(int, boolean) and make sure everything works without them. # We should somehow address the scenario described early by [~ilyak]. What if node stays isolated by the communication but fully accessible by discovery ? In such case all other nodes will be failed, but this is wrong. Only minority of nodes must be failed. I think it's necessary to extend org.apache.ignite.spi.IgniteSpiContext#resolveCommunicationFailure for TCP discovery. Probably this should be done as separate ticket. > Fix IGNITE_ENABLE_FORCIBLE_NODE_KILL system property. > - > > Key: IGNITE-7648 > URL: https://issues.apache.org/jira/browse/IGNITE-7648 > Project: Ignite > Issue Type: Improvement >Affects Versions: 2.3 >Reporter: Alexei Scherbakov >Assignee: Alexei Scherbakov >Priority: Major > Fix For: 2.8 > > > IGNITE_ENABLE_FORCIBLE_NODE_KILL system property was introduced in > IGNITE-5718 as a way to prevent unnecessary node drops in case of short > network problems. > I suppose it's wrong decision to fix it in such way. > We had faced some issues in our production due to lack of automatic kicking > of ill-behaving nodes (on example, hanging due to long GC pauses) until we > realised the necessity of changing default behavior via property. > Right solution is to kick nodes only if failure threshold is reached. Such > behavior should be always enabled. > UPDATE: During a discussion it was decided what the property will remain > disabled by default. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-7648) Fix IGNITE_ENABLE_FORCIBLE_NODE_KILL system property.
[
https://issues.apache.org/jira/browse/IGNITE-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16738166#comment-16738166
]
Ignite TC Bot commented on IGNITE-7648:
---
{panel:title=-- Run :: All: No blockers
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
[TeamCity *-- Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=2678567buildTypeId=IgniteTests24Java8_RunAll]
> Fix IGNITE_ENABLE_FORCIBLE_NODE_KILL system property.
> -
>
> Key: IGNITE-7648
> URL: https://issues.apache.org/jira/browse/IGNITE-7648
> Project: Ignite
> Issue Type: Improvement
>Affects Versions: 2.3
>Reporter: Alexei Scherbakov
>Assignee: Alexei Scherbakov
>Priority: Major
> Fix For: 2.8
>
>
> IGNITE_ENABLE_FORCIBLE_NODE_KILL system property was introduced in
> IGNITE-5718 as a way to prevent unnecessary node drops in case of short
> network problems.
> I suppose it's wrong decision to fix it in such way.
> We had faced some issues in our production due to lack of automatic kicking
> of ill-behaving nodes (on example, hanging due to long GC pauses) until we
> realised the necessity of changing default behavior via property.
> Right solution is to kick nodes only if failure threshold is reached. Such
> behavior should be always enabled.
> UPDATE: During a discussion it was decided what the property will remain
> disabled by default.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-7648) Fix IGNITE_ENABLE_FORCIBLE_NODE_KILL system property.
[ https://issues.apache.org/jira/browse/IGNITE-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16624629#comment-16624629 ] Alexei Scherbakov commented on IGNITE-7648: --- I have plans to finish this next week. > Fix IGNITE_ENABLE_FORCIBLE_NODE_KILL system property. > - > > Key: IGNITE-7648 > URL: https://issues.apache.org/jira/browse/IGNITE-7648 > Project: Ignite > Issue Type: Improvement >Affects Versions: 2.3 >Reporter: Alexei Scherbakov >Assignee: Alexei Scherbakov >Priority: Major > Fix For: 2.7 > > > IGNITE_ENABLE_FORCIBLE_NODE_KILL system property was introduced in > IGNITE-5718 as a way to prevent unnecessary node drops in case of short > network problems. > I suppose it's wrong decision to fix it in such way. > We had faced some issues in our production due to lack of automatic kicking > of ill-behaving nodes (on example, hanging due to long GC pauses) until we > realised the necessity of changing default behavior via property. > Right solution is to kick nodes only if failure threshold is reached. Such > behavior should be always enabled. > UPDATE: During a discussion it was decided what the property will remain > disabled by default. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-7648) Fix IGNITE_ENABLE_FORCIBLE_NODE_KILL system property.
[ https://issues.apache.org/jira/browse/IGNITE-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623512#comment-16623512 ] Nikolay Izhikov commented on IGNITE-7648: - [~ascherbakov] Do we have a chance to resolve this ticket until the code freeze of 2.7? > Fix IGNITE_ENABLE_FORCIBLE_NODE_KILL system property. > - > > Key: IGNITE-7648 > URL: https://issues.apache.org/jira/browse/IGNITE-7648 > Project: Ignite > Issue Type: Improvement >Affects Versions: 2.3 >Reporter: Alexei Scherbakov >Assignee: Alexei Scherbakov >Priority: Major > Fix For: 2.7 > > > IGNITE_ENABLE_FORCIBLE_NODE_KILL system property was introduced in > IGNITE-5718 as a way to prevent unnecessary node drops in case of short > network problems. > I suppose it's wrong decision to fix it in such way. > We had faced some issues in our production due to lack of automatic kicking > of ill-behaving nodes (on example, hanging due to long GC pauses) until we > realised the necessity of changing default behavior via property. > Right solution is to kick nodes only if failure threshold is reached. Such > behavior should be always enabled. > UPDATE: During a discussion it was decided what the property will remain > disabled by default. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-7648) Fix IGNITE_ENABLE_FORCIBLE_NODE_KILL system property.
[ https://issues.apache.org/jira/browse/IGNITE-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16527588#comment-16527588 ] Alexey Goncharuk commented on IGNITE-7648: -- I see quite a lot of failures on TC, need to trigger a re-run. > Fix IGNITE_ENABLE_FORCIBLE_NODE_KILL system property. > - > > Key: IGNITE-7648 > URL: https://issues.apache.org/jira/browse/IGNITE-7648 > Project: Ignite > Issue Type: Improvement >Affects Versions: 2.3 >Reporter: Alexei Scherbakov >Assignee: Alexei Scherbakov >Priority: Major > Fix For: 2.7 > > > IGNITE_ENABLE_FORCIBLE_NODE_KILL system property was introduced in > IGNITE-5718 as a way to prevent unnecessary node drops in case of short > network problems. > I suppose it's wrong decision to fix it in such way. > We had faced some issues in our production due to lack of automatic kicking > of ill-behaving nodes (on example, hanging due to long GC pauses) until we > realised the necessity of changing default behavior via property. > Right solution is to kick nodes only if failure threshold is reached. Such > behavior should be always enabled. > UPDATE: During a discussion it was decided what the property will remain > disabled by default. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
