[jira] [Commented] (IGNITE-7699) BinaryMetadata exchange should not be triggered if metadata was not updated
[ https://issues.apache.org/jira/browse/IGNITE-7699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16367292#comment-16367292 ] ASF GitHub Bot commented on IGNITE-7699: Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/3523 > BinaryMetadata exchange should not be triggered if metadata was not updated > --- > > Key: IGNITE-7699 > URL: https://issues.apache.org/jira/browse/IGNITE-7699 > Project: Ignite > Issue Type: Improvement >Reporter: Sergey Chugunov >Assignee: Sergey Chugunov >Priority: Major > Fix For: 2.5 > > > It was found that DiscoveryCustomEvent-based implementation of BinaryMetadata > exchange protocol triggers propose-accept process even when it is not needed. > In some situations BinaryObjects may be built with exactly the same scheme > many times, and registering of BinaryMetatada only once is enough. > However current implementation executes expensive propose-accept process for > each *addMeta* request even if requesting meta is the same. > Implementation should be improved so that prop-ack process is executed only > if BinaryMetadata really changed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-7699) BinaryMetadata exchange should not be triggered if metadata was not updated
[ https://issues.apache.org/jira/browse/IGNITE-7699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16366919#comment-16366919 ] Sergey Chugunov commented on IGNITE-7699: - TC status looks acceptable comparing to master branch: [pull/3523/head|https://ci.ignite.apache.org/viewLog.html?buildId=1096760&;] [~agoncharuk] could you please take a look at the change? > BinaryMetadata exchange should not be triggered if metadata was not updated > --- > > Key: IGNITE-7699 > URL: https://issues.apache.org/jira/browse/IGNITE-7699 > Project: Ignite > Issue Type: Improvement >Reporter: Sergey Chugunov >Assignee: Sergey Chugunov >Priority: Major > Fix For: 2.5 > > > It was found that DiscoveryCustomEvent-based implementation of BinaryMetadata > exchange protocol triggers propose-accept process even when it is not needed. > In some situations BinaryObjects may be built with exactly the same scheme > many times, and registering of BinaryMetatada only once is enough. > However current implementation executes expensive propose-accept process for > each *addMeta* request even if requesting meta is the same. > Implementation should be improved so that prop-ack process is executed only > if BinaryMetadata really changed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-7699) BinaryMetadata exchange should not be triggered if metadata was not updated
[ https://issues.apache.org/jira/browse/IGNITE-7699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364021#comment-16364021 ] ASF GitHub Bot commented on IGNITE-7699: GitHub user sergey-chugunov-1985 opened a pull request: https://github.com/apache/ignite/pull/3523 IGNITE-7699 ObjectBinaryProcessor improvements discovery protocol should not be triggered if requested metadata is the same as already existing; logging improvements You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-7699 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/3523.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3523 > BinaryMetadata exchange should not be triggered if metadata was not updated > --- > > Key: IGNITE-7699 > URL: https://issues.apache.org/jira/browse/IGNITE-7699 > Project: Ignite > Issue Type: Improvement >Reporter: Sergey Chugunov >Assignee: Sergey Chugunov >Priority: Major > Fix For: 2.5 > > > It was found that DiscoveryCustomEvent-based implementation of BinaryMetadata > exchange protocol triggers propose-accept process even when it is not needed. > In some situations BinaryObjects may be built with exactly the same scheme > many times, and registering of BinaryMetatada only once is enough. > However current implementation executes expensive propose-accept process for > each *addMeta* request even if requesting meta is the same. > Implementation should be improved so that prop-ack process is executed only > if BinaryMetadata really changed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
