[jira] [Commented] (IGNITE-7771) Names of Ignite JMX beans should not be quoted unless required
[ https://issues.apache.org/jira/browse/IGNITE-7771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16948509#comment-16948509 ] Maxim Muzafarov commented on IGNITE-7771: - Folks, Does this issue still actual due to IEP-35 metrics activity? > Names of Ignite JMX beans should not be quoted unless required > -- > > Key: IGNITE-7771 > URL: https://issues.apache.org/jira/browse/IGNITE-7771 > Project: Ignite > Issue Type: Bug >Affects Versions: 2.4 >Reporter: Stanislav Lukyanov >Assignee: Andrey Aleksandrov >Priority: Major > Labels: newbie > > Names of Ignite JMX beans and bean groups are currently quoted if they > contain non-alphanumeric characters. This leads to names with spaces, e.g. > Thread Pools, appearing as "Thread Pools". Moreover, Thread Pools and "Thread > Pools" are recognized by JMX as distinct names, so code accessing that MBean > needs to take that into account. > It would be better not to quote the bean and group names unless they contain > specific control characters. That way users won't need to quote names in > their JMX clients. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-7771) Names of Ignite JMX beans should not be quoted unless required
[ https://issues.apache.org/jira/browse/IGNITE-7771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16829543#comment-16829543 ] Dmitriy Pavlov commented on IGNITE-7771: [~DmitriyGovorukhin], [~aealeksandrov] could you please finalize merge if needed: PR is still open, or please close the issue as Won't fix. > Names of Ignite JMX beans should not be quoted unless required > -- > > Key: IGNITE-7771 > URL: https://issues.apache.org/jira/browse/IGNITE-7771 > Project: Ignite > Issue Type: Bug >Affects Versions: 2.4 >Reporter: Stanislav Lukyanov >Assignee: Andrey Aleksandrov >Priority: Major > Labels: newbie > Fix For: 2.8 > > > Names of Ignite JMX beans and bean groups are currently quoted if they > contain non-alphanumeric characters. This leads to names with spaces, e.g. > Thread Pools, appearing as "Thread Pools". Moreover, Thread Pools and "Thread > Pools" are recognized by JMX as distinct names, so code accessing that MBean > needs to take that into account. > It would be better not to quote the bean and group names unless they contain > specific control characters. That way users won't need to quote names in > their JMX clients. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-7771) Names of Ignite JMX beans should not be quoted unless required
[ https://issues.apache.org/jira/browse/IGNITE-7771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16630118#comment-16630118 ] Vladimir Ozerov commented on IGNITE-7771: - Moved to 2.8 due to inactivity. Please feel free to move back if you will be able to complete the ticket by AI 2.7 code freeze date, September 30, 2018. Also please pay especial attention to API compatibility. JMX bean names are a part of public API which might be already used by existing users. Changes to bean names may break their applications. > Names of Ignite JMX beans should not be quoted unless required > -- > > Key: IGNITE-7771 > URL: https://issues.apache.org/jira/browse/IGNITE-7771 > Project: Ignite > Issue Type: Bug >Affects Versions: 2.4 >Reporter: Stanislav Lukyanov >Assignee: Andrey Aleksandrov >Priority: Major > Labels: newbie > Fix For: 2.8 > > > Names of Ignite JMX beans and bean groups are currently quoted if they > contain non-alphanumeric characters. This leads to names with spaces, e.g. > Thread Pools, appearing as "Thread Pools". Moreover, Thread Pools and "Thread > Pools" are recognized by JMX as distinct names, so code accessing that MBean > needs to take that into account. > It would be better not to quote the bean and group names unless they contain > specific control characters. That way users won't need to quote names in > their JMX clients. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-7771) Names of Ignite JMX beans should not be quoted unless required
[ https://issues.apache.org/jira/browse/IGNITE-7771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16492426#comment-16492426 ] Dmitriy Govorukhin commented on IGNITE-7771: [~aealeksandrov] Looks good, thanks! Please merge if TC status is OK. > Names of Ignite JMX beans should not be quoted unless required > -- > > Key: IGNITE-7771 > URL: https://issues.apache.org/jira/browse/IGNITE-7771 > Project: Ignite > Issue Type: Bug >Affects Versions: 2.4 >Reporter: Stanislav Lukyanov >Assignee: Andrey Aleksandrov >Priority: Major > Labels: newbie > Fix For: 2.6 > > > Names of Ignite JMX beans and bean groups are currently quoted if they > contain non-alphanumeric characters. This leads to names with spaces, e.g. > Thread Pools, appearing as "Thread Pools". Moreover, Thread Pools and "Thread > Pools" are recognized by JMX as distinct names, so code accessing that MBean > needs to take that into account. > It would be better not to quote the bean and group names unless they contain > specific control characters. That way users won't need to quote names in > their JMX clients. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-7771) Names of Ignite JMX beans should not be quoted unless required
[ https://issues.apache.org/jira/browse/IGNITE-7771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16465977#comment-16465977 ] Dmitriy Pavlov commented on IGNITE-7771: [~aealeksandrov] please set In Progress or Open status if you are working on proposals. > Names of Ignite JMX beans should not be quoted unless required > -- > > Key: IGNITE-7771 > URL: https://issues.apache.org/jira/browse/IGNITE-7771 > Project: Ignite > Issue Type: Bug >Affects Versions: 2.4 >Reporter: Stanislav Lukyanov >Assignee: Andrey Aleksandrov >Priority: Major > Labels: newbie > Fix For: 2.6 > > > Names of Ignite JMX beans and bean groups are currently quoted if they > contain non-alphanumeric characters. This leads to names with spaces, e.g. > Thread Pools, appearing as "Thread Pools". Moreover, Thread Pools and "Thread > Pools" are recognized by JMX as distinct names, so code accessing that MBean > needs to take that into account. > It would be better not to quote the bean and group names unless they contain > specific control characters. That way users won't need to quote names in > their JMX clients. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-7771) Names of Ignite JMX beans should not be quoted unless required
[ https://issues.apache.org/jira/browse/IGNITE-7771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16457535#comment-16457535 ] Dmitriy Govorukhin commented on IGNITE-7771: [~aealeksandrov] I review your changes, please looks my comments [IGNT-CR-594|https://reviews.ignite.apache.org/ignite/review/IGNT-CR-594] > Names of Ignite JMX beans should not be quoted unless required > -- > > Key: IGNITE-7771 > URL: https://issues.apache.org/jira/browse/IGNITE-7771 > Project: Ignite > Issue Type: Bug >Affects Versions: 2.4 >Reporter: Stanislav Lukyanov >Assignee: Andrey Aleksandrov >Priority: Major > Labels: newbie > Fix For: 2.6 > > > Names of Ignite JMX beans and bean groups are currently quoted if they > contain non-alphanumeric characters. This leads to names with spaces, e.g. > Thread Pools, appearing as "Thread Pools". Moreover, Thread Pools and "Thread > Pools" are recognized by JMX as distinct names, so code accessing that MBean > needs to take that into account. > It would be better not to quote the bean and group names unless they contain > specific control characters. That way users won't need to quote names in > their JMX clients. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-7771) Names of Ignite JMX beans should not be quoted unless required
[ https://issues.apache.org/jira/browse/IGNITE-7771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16456379#comment-16456379 ] Dmitriy Pavlov commented on IGNITE-7771: [~DmitriyGovorukhin] could you please take a look to patch itself? > Names of Ignite JMX beans should not be quoted unless required > -- > > Key: IGNITE-7771 > URL: https://issues.apache.org/jira/browse/IGNITE-7771 > Project: Ignite > Issue Type: Bug >Affects Versions: 2.4 >Reporter: Stanislav Lukyanov >Assignee: Andrey Aleksandrov >Priority: Major > Labels: newbie > > Names of Ignite JMX beans and bean groups are currently quoted if they > contain non-alphanumeric characters. This leads to names with spaces, e.g. > Thread Pools, appearing as "Thread Pools". Moreover, Thread Pools and "Thread > Pools" are recognized by JMX as distinct names, so code accessing that MBean > needs to take that into account. > It would be better not to quote the bean and group names unless they contain > specific control characters. That way users won't need to quote names in > their JMX clients. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-7771) Names of Ignite JMX beans should not be quoted unless required
[ https://issues.apache.org/jira/browse/IGNITE-7771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16456377#comment-16456377 ] Dmitriy Pavlov commented on IGNITE-7771: TC is OK > Names of Ignite JMX beans should not be quoted unless required > -- > > Key: IGNITE-7771 > URL: https://issues.apache.org/jira/browse/IGNITE-7771 > Project: Ignite > Issue Type: Bug >Affects Versions: 2.4 >Reporter: Stanislav Lukyanov >Assignee: Andrey Aleksandrov >Priority: Major > Labels: newbie > > Names of Ignite JMX beans and bean groups are currently quoted if they > contain non-alphanumeric characters. This leads to names with spaces, e.g. > Thread Pools, appearing as "Thread Pools". Moreover, Thread Pools and "Thread > Pools" are recognized by JMX as distinct names, so code accessing that MBean > needs to take that into account. > It would be better not to quote the bean and group names unless they contain > specific control characters. That way users won't need to quote names in > their JMX clients. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-7771) Names of Ignite JMX beans should not be quoted unless required
[ https://issues.apache.org/jira/browse/IGNITE-7771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16456286#comment-16456286 ] Andrey Aleksandrov commented on IGNITE-7771: [~dpavlov] results of test run - [https://ci.ignite.apache.org/project.html?projectId=IgniteTests24Java8&branch_IgniteTests24Java8=pull%2F3715%2Fhead] Could you please take a look and merge if everything ok? > Names of Ignite JMX beans should not be quoted unless required > -- > > Key: IGNITE-7771 > URL: https://issues.apache.org/jira/browse/IGNITE-7771 > Project: Ignite > Issue Type: Bug >Affects Versions: 2.4 >Reporter: Stanislav Lukyanov >Assignee: Andrey Aleksandrov >Priority: Major > Labels: newbie > > Names of Ignite JMX beans and bean groups are currently quoted if they > contain non-alphanumeric characters. This leads to names with spaces, e.g. > Thread Pools, appearing as "Thread Pools". Moreover, Thread Pools and "Thread > Pools" are recognized by JMX as distinct names, so code accessing that MBean > needs to take that into account. > It would be better not to quote the bean and group names unless they contain > specific control characters. That way users won't need to quote names in > their JMX clients. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-7771) Names of Ignite JMX beans should not be quoted unless required
[ https://issues.apache.org/jira/browse/IGNITE-7771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16449377#comment-16449377 ] Andrey Aleksandrov commented on IGNITE-7771: [~dpavlov], I merged master to current branch and restart the tests. Will provide the results soon. > Names of Ignite JMX beans should not be quoted unless required > -- > > Key: IGNITE-7771 > URL: https://issues.apache.org/jira/browse/IGNITE-7771 > Project: Ignite > Issue Type: Bug >Affects Versions: 2.4 >Reporter: Stanislav Lukyanov >Assignee: Andrey Aleksandrov >Priority: Major > Labels: newbie > > Names of Ignite JMX beans and bean groups are currently quoted if they > contain non-alphanumeric characters. This leads to names with spaces, e.g. > Thread Pools, appearing as "Thread Pools". Moreover, Thread Pools and "Thread > Pools" are recognized by JMX as distinct names, so code accessing that MBean > needs to take that into account. > It would be better not to quote the bean and group names unless they contain > specific control characters. That way users won't need to quote names in > their JMX clients. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-7771) Names of Ignite JMX beans should not be quoted unless required
[ https://issues.apache.org/jira/browse/IGNITE-7771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16448222#comment-16448222 ] Stanislav Lukyanov commented on IGNITE-7771: Changes look good to me. [~dpavlov], could you please review and merge into master? > Names of Ignite JMX beans should not be quoted unless required > -- > > Key: IGNITE-7771 > URL: https://issues.apache.org/jira/browse/IGNITE-7771 > Project: Ignite > Issue Type: Bug >Affects Versions: 2.4 >Reporter: Stanislav Lukyanov >Assignee: Andrey Aleksandrov >Priority: Major > Labels: newbie > > Names of Ignite JMX beans and bean groups are currently quoted if they > contain non-alphanumeric characters. This leads to names with spaces, e.g. > Thread Pools, appearing as "Thread Pools". Moreover, Thread Pools and "Thread > Pools" are recognized by JMX as distinct names, so code accessing that MBean > needs to take that into account. > It would be better not to quote the bean and group names unless they contain > specific control characters. That way users won't need to quote names in > their JMX clients. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-7771) Names of Ignite JMX beans should not be quoted unless required
[ https://issues.apache.org/jira/browse/IGNITE-7771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16448186#comment-16448186 ] Dmitriy Pavlov commented on IGNITE-7771: Folks, are there any news about this issue? > Names of Ignite JMX beans should not be quoted unless required > -- > > Key: IGNITE-7771 > URL: https://issues.apache.org/jira/browse/IGNITE-7771 > Project: Ignite > Issue Type: Bug >Affects Versions: 2.4 >Reporter: Stanislav Lukyanov >Assignee: Andrey Aleksandrov >Priority: Major > Labels: newbie > > Names of Ignite JMX beans and bean groups are currently quoted if they > contain non-alphanumeric characters. This leads to names with spaces, e.g. > Thread Pools, appearing as "Thread Pools". Moreover, Thread Pools and "Thread > Pools" are recognized by JMX as distinct names, so code accessing that MBean > needs to take that into account. > It would be better not to quote the bean and group names unless they contain > specific control characters. That way users won't need to quote names in > their JMX clients. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-7771) Names of Ignite JMX beans should not be quoted unless required
[ https://issues.apache.org/jira/browse/IGNITE-7771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16418620#comment-16418620 ] Andrey Aleksandrov commented on IGNITE-7771: [~slukyanov] could you please take a look at [https://github.com/apache/ignite/pull/3715.] Also I started the test run https://ci.ignite.apache.org/viewQueued.html?itemId=1165868&tab=queuedBuildOverviewTab. > Names of Ignite JMX beans should not be quoted unless required > -- > > Key: IGNITE-7771 > URL: https://issues.apache.org/jira/browse/IGNITE-7771 > Project: Ignite > Issue Type: Bug >Affects Versions: 2.4 >Reporter: Stanislav Lukyanov >Assignee: Andrey Aleksandrov >Priority: Major > Labels: newbie > > Names of Ignite JMX beans and bean groups are currently quoted if they > contain non-alphanumeric characters. This leads to names with spaces, e.g. > Thread Pools, appearing as "Thread Pools". Moreover, Thread Pools and "Thread > Pools" are recognized by JMX as distinct names, so code accessing that MBean > needs to take that into account. > It would be better not to quote the bean and group names unless they contain > specific control characters. That way users won't need to quote names in > their JMX clients. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-7771) Names of Ignite JMX beans should not be quoted unless required
[ https://issues.apache.org/jira/browse/IGNITE-7771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16418612#comment-16418612 ] ASF GitHub Bot commented on IGNITE-7771: GitHub user aealeksandrov opened a pull request: https://github.com/apache/ignite/pull/3715 IGNITE-7771 Names of Ignite JMX beans should not be quoted unless required Names of Ignite JMX beans and bean groups are currently quoted if they contain non-alphanumeric characters. This leads to names with spaces, e.g. Thread Pools, appearing as "Thread Pools". Moreover, Thread Pools and "Thread Pools" are recognized by JMX as distinct names, so code accessing that MBean needs to take that into account. It would be better not to quote the bean and group names unless they contain specific control characters. That way users won't need to quote names in their JMX clients. Logic of generation of the ObjectName instances was updates. Also new tests were added. You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-7771 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/3715.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3715 commit 262e4d56c855ec1e6a44b32a6e46d82a176dc4dc Author: Andrei Aleksandrov Date: 2018-03-29T08:35:05Z IGNITE-7771 Names of Ignite JMX beans should not be quoted unless required > Names of Ignite JMX beans should not be quoted unless required > -- > > Key: IGNITE-7771 > URL: https://issues.apache.org/jira/browse/IGNITE-7771 > Project: Ignite > Issue Type: Bug >Affects Versions: 2.4 >Reporter: Stanislav Lukyanov >Assignee: Andrey Aleksandrov >Priority: Major > Labels: newbie > > Names of Ignite JMX beans and bean groups are currently quoted if they > contain non-alphanumeric characters. This leads to names with spaces, e.g. > Thread Pools, appearing as "Thread Pools". Moreover, Thread Pools and "Thread > Pools" are recognized by JMX as distinct names, so code accessing that MBean > needs to take that into account. > It would be better not to quote the bean and group names unless they contain > specific control characters. That way users won't need to quote names in > their JMX clients. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-7771) Names of Ignite JMX beans should not be quoted unless required
[ https://issues.apache.org/jira/browse/IGNITE-7771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16415467#comment-16415467 ] Stanislav Lukyanov commented on IGNITE-7771: [~aealeksandrov], sure, go ahead. Big thanks! > Names of Ignite JMX beans should not be quoted unless required > -- > > Key: IGNITE-7771 > URL: https://issues.apache.org/jira/browse/IGNITE-7771 > Project: Ignite > Issue Type: Bug >Affects Versions: 2.4 >Reporter: Stanislav Lukyanov >Assignee: Andrey Aleksandrov >Priority: Major > Labels: newbie > > Names of Ignite JMX beans and bean groups are currently quoted if they > contain non-alphanumeric characters. This leads to names with spaces, e.g. > Thread Pools, appearing as "Thread Pools". Moreover, Thread Pools and "Thread > Pools" are recognized by JMX as distinct names, so code accessing that MBean > needs to take that into account. > It would be better not to quote the bean and group names unless they contain > specific control characters. That way users won't need to quote names in > their JMX clients. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-7771) Names of Ignite JMX beans should not be quoted unless required
[ https://issues.apache.org/jira/browse/IGNITE-7771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16415458#comment-16415458 ] Andrey Aleksandrov commented on IGNITE-7771: [~slukyanov], I am going to fix this issue if you don't mind. > Names of Ignite JMX beans should not be quoted unless required > -- > > Key: IGNITE-7771 > URL: https://issues.apache.org/jira/browse/IGNITE-7771 > Project: Ignite > Issue Type: Bug >Affects Versions: 2.4 >Reporter: Stanislav Lukyanov >Assignee: Andrey Aleksandrov >Priority: Major > Labels: newbie > > Names of Ignite JMX beans and bean groups are currently quoted if they > contain non-alphanumeric characters. This leads to names with spaces, e.g. > Thread Pools, appearing as "Thread Pools". Moreover, Thread Pools and "Thread > Pools" are recognized by JMX as distinct names, so code accessing that MBean > needs to take that into account. > It would be better not to quote the bean and group names unless they contain > specific control characters. That way users won't need to quote names in > their JMX clients. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-7771) Names of Ignite JMX beans should not be quoted unless required
[ https://issues.apache.org/jira/browse/IGNITE-7771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16371184#comment-16371184 ] Stanislav Lukyanov commented on IGNITE-7771: GridMBeansTest checks that JMX beans are available, but the bean names are not hardcoded there - it would be better to alter the test to use hardcoded names to make sure we don't miss an incompatible change in our JMX API. Need to update that test together with this fix. > Names of Ignite JMX beans should not be quoted unless required > -- > > Key: IGNITE-7771 > URL: https://issues.apache.org/jira/browse/IGNITE-7771 > Project: Ignite > Issue Type: Bug >Reporter: Stanislav Lukyanov >Assignee: Stanislav Lukyanov >Priority: Major > > Names of Ignite JMX beans and bean groups are currently quoted if they > contain non-alphanumeric characters. This leads to names with spaces, e.g. > Thread Pools, appearing as "Thread Pools". Moreover, Thread Pools and "Thread > Pools" are recognized by JMX as distinct names, so code accessing that MBean > needs to take that into account. > It would be better not to quote the bean and group names unless they contain > specific control characters. That way users won't need to quote names in > their JMX clients. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
