[jira] [Commented] (IGNITE-8426) Some classes creates JavaLogger directly which lead to SEVERE message in logs if JUL config file is missing
[
https://issues.apache.org/jira/browse/IGNITE-8426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16527731#comment-16527731
]
ASF GitHub Bot commented on IGNITE-8426:
Github user asfgit closed the pull request at:
https://github.com/apache/ignite/pull/4249
> Some classes creates JavaLogger directly which lead to SEVERE message in logs
> if JUL config file is missing
> ---
>
> Key: IGNITE-8426
> URL: https://issues.apache.org/jira/browse/IGNITE-8426
> Project: Ignite
> Issue Type: Bug
>Reporter: Evgenii Zhuravlev
>Assignee: Evgenii Zhuravlev
>Priority: Blocker
> Fix For: 2.7
>
>
> Here is the error message:
> SEVERE: Failed to resolve default logging config file:
> config/java.util.logging.properties
> For example, problem code is placed in LongJVMPauseDetector and
> IgniteJdbcDriver classes.
> Reproducer:
> IgniteConfiguration configuration = new IgniteConfiguration();
> configuration.setGridLogger(new
> Slf4jLogger(LoggerFactory.getLogger("ignite")));
> Ignition.start(configuration);
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-8426) Some classes creates JavaLogger directly which lead to SEVERE message in logs if JUL config file is missing
[
https://issues.apache.org/jira/browse/IGNITE-8426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16526622#comment-16526622
]
Evgenii Zhuravlev commented on IGNITE-8426:
---
Here is the new TC run for this suite and it looks good:
https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_Basic1_IgniteTests24Java8=pull%2F4249%2Fhead=buildTypeStatusDiv
> Some classes creates JavaLogger directly which lead to SEVERE message in logs
> if JUL config file is missing
> ---
>
> Key: IGNITE-8426
> URL: https://issues.apache.org/jira/browse/IGNITE-8426
> Project: Ignite
> Issue Type: Bug
>Reporter: Evgenii Zhuravlev
>Assignee: Evgenii Zhuravlev
>Priority: Blocker
> Fix For: 2.7
>
>
> Here is the error message:
> SEVERE: Failed to resolve default logging config file:
> config/java.util.logging.properties
> For example, problem code is placed in LongJVMPauseDetector and
> IgniteJdbcDriver classes.
> Reproducer:
> IgniteConfiguration configuration = new IgniteConfiguration();
> configuration.setGridLogger(new
> Slf4jLogger(LoggerFactory.getLogger("ignite")));
> Ignition.start(configuration);
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-8426) Some classes creates JavaLogger directly which lead to SEVERE message in logs if JUL config file is missing
[
https://issues.apache.org/jira/browse/IGNITE-8426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16526457#comment-16526457
]
Evgenii Zhuravlev commented on IGNITE-8426:
---
[~EdShangGG], Thank you for your review! I will re-run TC again after changes
and check it
> Some classes creates JavaLogger directly which lead to SEVERE message in logs
> if JUL config file is missing
> ---
>
> Key: IGNITE-8426
> URL: https://issues.apache.org/jira/browse/IGNITE-8426
> Project: Ignite
> Issue Type: Bug
>Reporter: Evgenii Zhuravlev
>Assignee: Evgenii Zhuravlev
>Priority: Blocker
> Fix For: 2.7
>
>
> Here is the error message:
> SEVERE: Failed to resolve default logging config file:
> config/java.util.logging.properties
> For example, problem code is placed in LongJVMPauseDetector and
> IgniteJdbcDriver classes.
> Reproducer:
> IgniteConfiguration configuration = new IgniteConfiguration();
> configuration.setGridLogger(new
> Slf4jLogger(LoggerFactory.getLogger("ignite")));
> Ignition.start(configuration);
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-8426) Some classes creates JavaLogger directly which lead to SEVERE message in logs if JUL config file is missing
[
https://issues.apache.org/jira/browse/IGNITE-8426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16526455#comment-16526455
]
Eduard Shangareev commented on IGNITE-8426:
---
Looks good for me. Thank you, [~ezhuravl].
> Some classes creates JavaLogger directly which lead to SEVERE message in logs
> if JUL config file is missing
> ---
>
> Key: IGNITE-8426
> URL: https://issues.apache.org/jira/browse/IGNITE-8426
> Project: Ignite
> Issue Type: Bug
>Reporter: Evgenii Zhuravlev
>Assignee: Evgenii Zhuravlev
>Priority: Blocker
> Fix For: 2.7
>
>
> Here is the error message:
> SEVERE: Failed to resolve default logging config file:
> config/java.util.logging.properties
> For example, problem code is placed in LongJVMPauseDetector and
> IgniteJdbcDriver classes.
> Reproducer:
> IgniteConfiguration configuration = new IgniteConfiguration();
> configuration.setGridLogger(new
> Slf4jLogger(LoggerFactory.getLogger("ignite")));
> Ignition.start(configuration);
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-8426) Some classes creates JavaLogger directly which lead to SEVERE message in logs if JUL config file is missing
[
https://issues.apache.org/jira/browse/IGNITE-8426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16526434#comment-16526434
]
Evgenii Zhuravlev commented on IGNITE-8426:
---
[~agoncharuk], added stopping of LongJVMPauseDetector on node stop
> Some classes creates JavaLogger directly which lead to SEVERE message in logs
> if JUL config file is missing
> ---
>
> Key: IGNITE-8426
> URL: https://issues.apache.org/jira/browse/IGNITE-8426
> Project: Ignite
> Issue Type: Bug
>Reporter: Evgenii Zhuravlev
>Assignee: Evgenii Zhuravlev
>Priority: Blocker
> Fix For: 2.7
>
>
> Here is the error message:
> SEVERE: Failed to resolve default logging config file:
> config/java.util.logging.properties
> For example, problem code is placed in LongJVMPauseDetector and
> IgniteJdbcDriver classes.
> Reproducer:
> IgniteConfiguration configuration = new IgniteConfiguration();
> configuration.setGridLogger(new
> Slf4jLogger(LoggerFactory.getLogger("ignite")));
> Ignition.start(configuration);
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-8426) Some classes creates JavaLogger directly which lead to SEVERE message in logs if JUL config file is missing
[
https://issues.apache.org/jira/browse/IGNITE-8426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16526409#comment-16526409
]
Evgenii Zhuravlev commented on IGNITE-8426:
---
[~EdShangGG] Here is the TC run with this test:
https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_Basic1_IgniteTests24Java8=pull%2F4249%2Fhead=buildTypeStatusDiv
> Some classes creates JavaLogger directly which lead to SEVERE message in logs
> if JUL config file is missing
> ---
>
> Key: IGNITE-8426
> URL: https://issues.apache.org/jira/browse/IGNITE-8426
> Project: Ignite
> Issue Type: Bug
>Reporter: Evgenii Zhuravlev
>Assignee: Evgenii Zhuravlev
>Priority: Blocker
> Fix For: 2.7
>
>
> Here is the error message:
> SEVERE: Failed to resolve default logging config file:
> config/java.util.logging.properties
> For example, problem code is placed in LongJVMPauseDetector and
> IgniteJdbcDriver classes.
> Reproducer:
> IgniteConfiguration configuration = new IgniteConfiguration();
> configuration.setGridLogger(new
> Slf4jLogger(LoggerFactory.getLogger("ignite")));
> Ignition.start(configuration);
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-8426) Some classes creates JavaLogger directly which lead to SEVERE message in logs if JUL config file is missing
[
https://issues.apache.org/jira/browse/IGNITE-8426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16526407#comment-16526407
]
Alexey Goncharuk commented on IGNITE-8426:
--
[~ezhuravl], after your fix, if I start and shut down Ignite nodes in a loop, I
will end up with multiple daemon threads started, but not stopped, each of them
printing out the same output to the log + this is a major resource leak in
tests.
Please fix the thread lifecycle.
> Some classes creates JavaLogger directly which lead to SEVERE message in logs
> if JUL config file is missing
> ---
>
> Key: IGNITE-8426
> URL: https://issues.apache.org/jira/browse/IGNITE-8426
> Project: Ignite
> Issue Type: Bug
>Reporter: Evgenii Zhuravlev
>Assignee: Evgenii Zhuravlev
>Priority: Blocker
> Fix For: 2.7
>
>
> Here is the error message:
> SEVERE: Failed to resolve default logging config file:
> config/java.util.logging.properties
> For example, problem code is placed in LongJVMPauseDetector and
> IgniteJdbcDriver classes.
> Reproducer:
> IgniteConfiguration configuration = new IgniteConfiguration();
> configuration.setGridLogger(new
> Slf4jLogger(LoggerFactory.getLogger("ignite")));
> Ignition.start(configuration);
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-8426) Some classes creates JavaLogger directly which lead to SEVERE message in logs if JUL config file is missing
[
https://issues.apache.org/jira/browse/IGNITE-8426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16526301#comment-16526301
]
Eduard Shangareev commented on IGNITE-8426:
---
Can I see it on some TC Run?
> Some classes creates JavaLogger directly which lead to SEVERE message in logs
> if JUL config file is missing
> ---
>
> Key: IGNITE-8426
> URL: https://issues.apache.org/jira/browse/IGNITE-8426
> Project: Ignite
> Issue Type: Bug
>Reporter: Evgenii Zhuravlev
>Assignee: Evgenii Zhuravlev
>Priority: Blocker
> Fix For: 2.7
>
>
> Here is the error message:
> SEVERE: Failed to resolve default logging config file:
> config/java.util.logging.properties
> For example, problem code is placed in LongJVMPauseDetector and
> IgniteJdbcDriver classes.
> Reproducer:
> IgniteConfiguration configuration = new IgniteConfiguration();
> configuration.setGridLogger(new
> Slf4jLogger(LoggerFactory.getLogger("ignite")));
> Ignition.start(configuration);
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-8426) Some classes creates JavaLogger directly which lead to SEVERE message in logs if JUL config file is missing
[
https://issues.apache.org/jira/browse/IGNITE-8426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16526289#comment-16526289
]
Evgenii Zhuravlev commented on IGNITE-8426:
---
[~EdShangGG], There is a config file for JUL in Ignite, so, I will need to
remove it for reproducing this error right from source code. I don't think that
it's a good idea. I've implemented another one - added debug message that
LongJVMPauseDetector was started successfully. If we see this message in
GridLogger, then it was configured properly. Please check
LongJVMPauseDetectorTest.
> Some classes creates JavaLogger directly which lead to SEVERE message in logs
> if JUL config file is missing
> ---
>
> Key: IGNITE-8426
> URL: https://issues.apache.org/jira/browse/IGNITE-8426
> Project: Ignite
> Issue Type: Bug
>Reporter: Evgenii Zhuravlev
>Assignee: Evgenii Zhuravlev
>Priority: Blocker
> Fix For: 2.7
>
>
> Here is the error message:
> SEVERE: Failed to resolve default logging config file:
> config/java.util.logging.properties
> For example, problem code is placed in LongJVMPauseDetector and
> IgniteJdbcDriver classes.
> Reproducer:
> IgniteConfiguration configuration = new IgniteConfiguration();
> configuration.setGridLogger(new
> Slf4jLogger(LoggerFactory.getLogger("ignite")));
> Ignition.start(configuration);
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-8426) Some classes creates JavaLogger directly which lead to SEVERE message in logs if JUL config file is missing
[
https://issues.apache.org/jira/browse/IGNITE-8426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525193#comment-16525193
]
Eduard Shangareev commented on IGNITE-8426:
---
[~ezhuravl] Could we add checking that there is no such log message?
We could use {{org.apache.ignite.testframework.GridStringLogger}} for this
purpose.
> Some classes creates JavaLogger directly which lead to SEVERE message in logs
> if JUL config file is missing
> ---
>
> Key: IGNITE-8426
> URL: https://issues.apache.org/jira/browse/IGNITE-8426
> Project: Ignite
> Issue Type: Bug
>Reporter: Evgenii Zhuravlev
>Assignee: Evgenii Zhuravlev
>Priority: Blocker
> Fix For: 2.7
>
>
> Here is the error message:
> SEVERE: Failed to resolve default logging config file:
> config/java.util.logging.properties
> For example, problem code is placed in LongJVMPauseDetector and
> IgniteJdbcDriver classes.
> Reproducer:
> IgniteConfiguration configuration = new IgniteConfiguration();
> configuration.setGridLogger(new
> Slf4jLogger(LoggerFactory.getLogger("ignite")));
> Ignition.start(configuration);
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-8426) Some classes creates JavaLogger directly which lead to SEVERE message in logs if JUL config file is missing
[
https://issues.apache.org/jira/browse/IGNITE-8426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525187#comment-16525187
]
Andrew Mashenkov commented on IGNITE-8426:
--
Looks good.
[~ezhuravl], thanks for contribution!
> Some classes creates JavaLogger directly which lead to SEVERE message in logs
> if JUL config file is missing
> ---
>
> Key: IGNITE-8426
> URL: https://issues.apache.org/jira/browse/IGNITE-8426
> Project: Ignite
> Issue Type: Bug
>Reporter: Evgenii Zhuravlev
>Assignee: Evgenii Zhuravlev
>Priority: Blocker
> Fix For: 2.7
>
>
> Here is the error message:
> SEVERE: Failed to resolve default logging config file:
> config/java.util.logging.properties
> For example, problem code is placed in LongJVMPauseDetector and
> IgniteJdbcDriver classes.
> Reproducer:
> IgniteConfiguration configuration = new IgniteConfiguration();
> configuration.setGridLogger(new
> Slf4jLogger(LoggerFactory.getLogger("ignite")));
> Ignition.start(configuration);
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-8426) Some classes creates JavaLogger directly which lead to SEVERE message in logs if JUL config file is missing
[
https://issues.apache.org/jira/browse/IGNITE-8426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525106#comment-16525106
]
Evgenii Zhuravlev commented on IGNITE-8426:
---
[~amashenkov] Thank you for comments, I've applied your recommendations!
> Some classes creates JavaLogger directly which lead to SEVERE message in logs
> if JUL config file is missing
> ---
>
> Key: IGNITE-8426
> URL: https://issues.apache.org/jira/browse/IGNITE-8426
> Project: Ignite
> Issue Type: Bug
>Reporter: Evgenii Zhuravlev
>Assignee: Evgenii Zhuravlev
>Priority: Blocker
> Fix For: 2.7
>
>
> Here is the error message:
> SEVERE: Failed to resolve default logging config file:
> config/java.util.logging.properties
> For example, problem code is placed in LongJVMPauseDetector and
> IgniteJdbcDriver classes.
> Reproducer:
> IgniteConfiguration configuration = new IgniteConfiguration();
> configuration.setGridLogger(new
> Slf4jLogger(LoggerFactory.getLogger("ignite")));
> Ignition.start(configuration);
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-8426) Some classes creates JavaLogger directly which lead to SEVERE message in logs if JUL config file is missing
[
https://issues.apache.org/jira/browse/IGNITE-8426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525094#comment-16525094
]
Evgenii Zhuravlev commented on IGNITE-8426:
---
Looks like JDBC Driver is a standalone component and this is ok to have such
error for it, since it should have explicit logger configuration.
As for LongJvmPauseDetector - It was static and out of Ignite context. I had to
add IgniteLogger to it and make it non-static.
> Some classes creates JavaLogger directly which lead to SEVERE message in logs
> if JUL config file is missing
> ---
>
> Key: IGNITE-8426
> URL: https://issues.apache.org/jira/browse/IGNITE-8426
> Project: Ignite
> Issue Type: Bug
>Reporter: Evgenii Zhuravlev
>Assignee: Evgenii Zhuravlev
>Priority: Blocker
> Fix For: 2.7
>
>
> Here is the error message:
> SEVERE: Failed to resolve default logging config file:
> config/java.util.logging.properties
> For example, problem code is placed in LongJVMPauseDetector and
> IgniteJdbcDriver classes.
> Reproducer:
> IgniteConfiguration configuration = new IgniteConfiguration();
> configuration.setGridLogger(new
> Slf4jLogger(LoggerFactory.getLogger("ignite")));
> Ignition.start(configuration);
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-8426) Some classes creates JavaLogger directly which lead to SEVERE message in logs if JUL config file is missing
[
https://issues.apache.org/jira/browse/IGNITE-8426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524976#comment-16524976
]
Andrew Mashenkov commented on IGNITE-8426:
--
[~ezhuravl],
I've left some comments in PR. Please, take a look.
> Some classes creates JavaLogger directly which lead to SEVERE message in logs
> if JUL config file is missing
> ---
>
> Key: IGNITE-8426
> URL: https://issues.apache.org/jira/browse/IGNITE-8426
> Project: Ignite
> Issue Type: Bug
>Reporter: Evgenii Zhuravlev
>Assignee: Evgenii Zhuravlev
>Priority: Blocker
> Fix For: 2.7
>
>
> Here is the error message:
> SEVERE: Failed to resolve default logging config file:
> config/java.util.logging.properties
> For example, problem code is placed in LongJVMPauseDetector and
> IgniteJdbcDriver classes.
> Reproducer:
> IgniteConfiguration configuration = new IgniteConfiguration();
> configuration.setGridLogger(new
> Slf4jLogger(LoggerFactory.getLogger("ignite")));
> Ignition.start(configuration);
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-8426) Some classes creates JavaLogger directly which lead to SEVERE message in logs if JUL config file is missing
[
https://issues.apache.org/jira/browse/IGNITE-8426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16522454#comment-16522454
]
Evgenii Zhuravlev commented on IGNITE-8426:
---
I've checked TC:
https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_RunAll_IgniteTests24Java8=pull%2F4249%2Fhead=buildTypeStatusDiv
and it looks good, there is no new test failures
> Some classes creates JavaLogger directly which lead to SEVERE message in logs
> if JUL config file is missing
> ---
>
> Key: IGNITE-8426
> URL: https://issues.apache.org/jira/browse/IGNITE-8426
> Project: Ignite
> Issue Type: Bug
>Reporter: Evgenii Zhuravlev
>Assignee: Evgenii Zhuravlev
>Priority: Blocker
> Fix For: 2.7
>
>
> Here is the error message:
> SEVERE: Failed to resolve default logging config file:
> config/java.util.logging.properties
> For example, problem code is placed in LongJVMPauseDetector and
> IgniteJdbcDriver classes.
> Reproducer:
> IgniteConfiguration configuration = new IgniteConfiguration();
> configuration.setGridLogger(new
> Slf4jLogger(LoggerFactory.getLogger("ignite")));
> Ignition.start(configuration);
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-8426) Some classes creates JavaLogger directly which lead to SEVERE message in logs if JUL config file is missing
[
https://issues.apache.org/jira/browse/IGNITE-8426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16520507#comment-16520507
]
ASF GitHub Bot commented on IGNITE-8426:
GitHub user ezhuravl opened a pull request:
https://github.com/apache/ignite/pull/4249
IGNITE-8426 LongJVMPauseDetector add logger from context
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gridgain/apache-ignite ignite-8426
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ignite/pull/4249.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4249
> Some classes creates JavaLogger directly which lead to SEVERE message in logs
> if JUL config file is missing
> ---
>
> Key: IGNITE-8426
> URL: https://issues.apache.org/jira/browse/IGNITE-8426
> Project: Ignite
> Issue Type: Bug
>Reporter: Evgenii Zhuravlev
>Assignee: Evgenii Zhuravlev
>Priority: Blocker
> Fix For: 2.7
>
>
> Here is the error message:
> SEVERE: Failed to resolve default logging config file:
> config/java.util.logging.properties
> For example, problem code is placed in LongJVMPauseDetector and
> IgniteJdbcDriver classes.
> Reproducer:
> IgniteConfiguration configuration = new IgniteConfiguration();
> configuration.setGridLogger(new
> Slf4jLogger(LoggerFactory.getLogger("ignite")));
> Ignition.start(configuration);
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
