[jira] [Commented] (IGNITE-8462) DataStreamerImpl.close(true) should throw exception

[Ivan Fedotov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-8462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16519490#comment-16519490
 ] 

Ivan Fedotov commented on IGNITE-8462:
--

According to [~avinogradov] corrections this ticket has a new design. It's 
necessary to done all futures from thread buffer in 
DataStreamerImpl.close(true) case. 
Also I implement inner class in DataStreamerImpl to make work with 
IgniteCacheFuture, List pair easier and prevent null values.

> DataStreamerImpl.close(true) should throw exception
> ---
>
> Key: IGNITE-8462
> URL: https://issues.apache.org/jira/browse/IGNITE-8462
> Project: Ignite
>  Issue Type: Bug
>Reporter: Ivan Fedotov
>Assignee: Ivan Fedotov
>Priority: Major
>
> DataStreamerImpl.close(true) should throw CacheException in case if there was 
> addition data to DataStreamerImpl. Future, returned by 
> DataStreamerImpl.addData() also should be done after close streamer.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-8462) DataStreamerImpl.close(true) should throw exception

[Ryabov Dmitrii (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-8462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16493320#comment-16493320
 ] 

Ryabov Dmitrii commented on IGNITE-8462:


I think we shouldn't throw any exception if there was any unflushed data, 
because {{DataStreamerImpl.close(true)}} should cancel all existing operations 
and reject new operations.

> DataStreamerImpl.close(true) should throw exception
> ---
>
> Key: IGNITE-8462
> URL: https://issues.apache.org/jira/browse/IGNITE-8462
> Project: Ignite
>  Issue Type: Bug
>Reporter: Ivan Fedotov
>Assignee: Ivan Fedotov
>Priority: Major
>
> DataStreamerImpl.close(true) should throw CacheException in case if there was 
> addition data to DataStreamerImpl. Future, returned by 
> DataStreamerImpl.addData() also should be done after close streamer.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-8462) DataStreamerImpl.close(true) should throw exception

[Ivan Fedotov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-8462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16470252#comment-16470252
 ] 

Ivan Fedotov commented on IGNITE-8462:
--

[~dpavlov], of course, I've prepared test-reproducer [1], that is green with my 
fix. Also it's green on the previous version of DataStreamerImpl, before 
pre-caching per thread, so I think CacheException is appropriate behavior. 
Besides that, future, returned by DataStreamerImpl.addData() is not done after 
DataStreamerImpl.close(true). I suppose that it's due to data was not flushed 
from thread buffer in this case.

 

[1] 
https://github.com/1vanan/ignite/blob/IGNITE-8462/modules/core/src/test/java/org/apache/ignite/internal/processors/datastreamer/DataStreamerImplSelfTest.java#L116

> DataStreamerImpl.close(true) should throw exception
> ---
>
> Key: IGNITE-8462
> URL: https://issues.apache.org/jira/browse/IGNITE-8462
> Project: Ignite
>  Issue Type: Bug
>Reporter: Ivan Fedotov
>Assignee: Ivan Fedotov
>Priority: Major
>
> DataStreamerImpl.close(true) should throw CacheException in case if there was 
> addition data to DataStreamerImpl. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-8462) DataStreamerImpl.close(true) should throw exception

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-8462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16470240#comment-16470240
 ] 

ASF GitHub Bot commented on IGNITE-8462:


GitHub user 1vanan opened a pull request:

https://github.com/apache/ignite/pull/3971

IGNITE-8462



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/1vanan/ignite IGNITE-8462

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/3971.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3971


commit 79144205c7066d12b43751c14899cc73afe2a5b0
Author: Fedotov 
Date:   2018-05-10T09:40:06Z

fix DataStreamerImpl.close(true) and add appropriate test

commit 38b80f4cccdbd24b884c70c36d793dd1eab31298
Author: Fedotov 
Date:   2018-05-10T11:23:47Z

fix test




> DataStreamerImpl.close(true) should throw exception
> ---
>
> Key: IGNITE-8462
> URL: https://issues.apache.org/jira/browse/IGNITE-8462
> Project: Ignite
>  Issue Type: Bug
>Reporter: Ivan Fedotov
>Assignee: Ivan Fedotov
>Priority: Major
>
> DataStreamerImpl.close(true) should throw CacheException in case if there was 
> addition data to DataStreamerImpl. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-8462) DataStreamerImpl.close(true) should throw exception

[Dmitriy Pavlov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-8462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16470176#comment-16470176
 ] 

Dmitriy Pavlov commented on IGNITE-8462:


Not clear for me why it should throw exception. Could you add more 
context/linked problems/etc?

> DataStreamerImpl.close(true) should throw exception
> ---
>
> Key: IGNITE-8462
> URL: https://issues.apache.org/jira/browse/IGNITE-8462
> Project: Ignite
>  Issue Type: Bug
>Reporter: Ivan Fedotov
>Assignee: Ivan Fedotov
>Priority: Major
>
> DataStreamerImpl.close(true) should throw CacheException in case if there was 
> addition data to DataStreamerImpl. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)