[jira] [Commented] (IGNITE-8571) Baseline auto-adjust feature
[ https://issues.apache.org/jira/browse/IGNITE-8571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16759782#comment-16759782 ] Ivan Bessonov commented on IGNITE-8571: --- [~akalashnikov] code looks good, thank you! > Baseline auto-adjust feature > > > Key: IGNITE-8571 > URL: https://issues.apache.org/jira/browse/IGNITE-8571 > Project: Ignite > Issue Type: New Feature >Reporter: Eduard Shangareev >Assignee: Anton Kalashnikov >Priority: Major > Labels: IEP-4, Phase-2 > Fix For: 2.8 > > Time Spent: 20m > Remaining Estimate: 0h > > Now we have only one way to change BLAT - manually update it via console.sh > or API. > We need to add the possibility to change it automatically. Adjust to current > topology. > So, I propose 3 new parameters which would be responsible to tune this > feature. > 1. Flag autoAdjustEnabled - true/false. Easy. Manual baseline control or auto > adjusting baseline. > 2. autoAdjustTimeout - time which we would wait after the actual topology > change. But it would be reset if new discovery event happened. (node > join/exit). > 3. autoAdjustMaxTimeout - time which we would wait from the first dicovery > event in the chain. If we achieved it than we would change BLAT right away > (no matter were another node join/exit happened or not). > We need to change API next way: > 1. org.apache.ignite.IgniteCluster > *Add* > isBaselineAutoAdjustEnabled() > setBaselineAutoAdjustEnabled(boolean enabled); > setBaselineAutoAdjustTimeout(long timeoutInMs); > setBaselineAutoAdjustMaxTimeout(long timeoutInMs); > 2. org.apache.ignite.configuration.IgniteConfiguration > *Add* > IgniteConfiguration setBaselineAutoAdjustEnabled(boolean enabled); > IgniteConfiguration setBaselineAutoAdjustTimeout(long timeoutInMs); > IgniteConfiguration setBaselineAutoAdjustMaxTimeout(long timeoutInMs); > Also, we need to ensure that all nodes would have the same parameters. > And we should be able to survive coordinator left during parameters changes. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-8571) Baseline auto-adjust feature
[
https://issues.apache.org/jira/browse/IGNITE-8571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16760597#comment-16760597
]
Ignite TC Bot commented on IGNITE-8571:
---
{panel:title=--> Run :: All: No blockers
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
[TeamCity *--> Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=2995267&buildTypeId=IgniteTests24Java8_RunAll]
> Baseline auto-adjust feature
>
>
> Key: IGNITE-8571
> URL: https://issues.apache.org/jira/browse/IGNITE-8571
> Project: Ignite
> Issue Type: New Feature
>Reporter: Eduard Shangareev
>Assignee: Anton Kalashnikov
>Priority: Major
> Labels: IEP-4, Phase-2
> Fix For: 2.8
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Now we have only one way to change BLAT - manually update it via console.sh
> or API.
> We need to add the possibility to change it automatically. Adjust to current
> topology.
> So, I propose 3 new parameters which would be responsible to tune this
> feature.
> 1. Flag autoAdjustEnabled - true/false. Easy. Manual baseline control or auto
> adjusting baseline.
> 2. autoAdjustTimeout - time which we would wait after the actual topology
> change. But it would be reset if new discovery event happened. (node
> join/exit).
> 3. autoAdjustMaxTimeout - time which we would wait from the first dicovery
> event in the chain. If we achieved it than we would change BLAT right away
> (no matter were another node join/exit happened or not).
> We need to change API next way:
> 1. org.apache.ignite.IgniteCluster
> *Add*
> isBaselineAutoAdjustEnabled()
> setBaselineAutoAdjustEnabled(boolean enabled);
> setBaselineAutoAdjustTimeout(long timeoutInMs);
> setBaselineAutoAdjustMaxTimeout(long timeoutInMs);
> 2. org.apache.ignite.configuration.IgniteConfiguration
> *Add*
> IgniteConfiguration setBaselineAutoAdjustEnabled(boolean enabled);
> IgniteConfiguration setBaselineAutoAdjustTimeout(long timeoutInMs);
> IgniteConfiguration setBaselineAutoAdjustMaxTimeout(long timeoutInMs);
> Also, we need to ensure that all nodes would have the same parameters.
> And we should be able to survive coordinator left during parameters changes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-8571) Baseline auto-adjust feature
[
https://issues.apache.org/jira/browse/IGNITE-8571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16767337#comment-16767337
]
Ignite TC Bot commented on IGNITE-8571:
---
{panel:title=--> Run :: All: No blockers
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
[TeamCity *--> Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=3070785&buildTypeId=IgniteTests24Java8_RunAll]
> Baseline auto-adjust feature
>
>
> Key: IGNITE-8571
> URL: https://issues.apache.org/jira/browse/IGNITE-8571
> Project: Ignite
> Issue Type: New Feature
>Reporter: Eduard Shangareev
>Assignee: Anton Kalashnikov
>Priority: Major
> Labels: IEP-4, Phase-2
> Fix For: 2.8
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Now we have only one way to change BLAT - manually update it via console.sh
> or API.
> We need to add the possibility to change it automatically. Adjust to current
> topology.
> So, I propose 2 new distributed parameters which would be responsible to tune
> this feature.
> 1. Flag autoAdjustEnabled - true/false. Easy. Manual baseline control or auto
> adjusting baseline.
> 2. autoAdjustTimeout - time which we would wait after the actual topology
> change. But it would be reset if new discovery event happened. (node
> join/exit).
> We need to change API next way:
> org.apache.ignite.IgniteCluster:
> * isBaselineAutoAdjustEnabled()
> * setBaselineAutoAdjustEnabled(boolean enabled);
> * setBaselineAutoAdjustTimeout(long timeoutInMs);
> Also, we need to ensure that all nodes would have the same
> parameters(distributed parameters).
> And we should be able to survive coordinator left during parameters changes.
> When autoAdjustEnabled is true we should be block ability to manual baseline
> change.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-8571) Baseline auto-adjust feature
[ https://issues.apache.org/jira/browse/IGNITE-8571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16768049#comment-16768049 ] Ivan Bessonov commented on IGNITE-8571: --- DistributedBaselineConfiguration - AUTO_ADJUST_CONFIGURED_MESSAGE - %d for timeout - //set default value. - code style ChangeTopologyWatcher - "...lost partitions was detected" - typo ChangeTopologyWatcherTest - maybe GridFunc#nodeConsistentIds can be used, maybe not Everything else looks good. > Baseline auto-adjust feature > > > Key: IGNITE-8571 > URL: https://issues.apache.org/jira/browse/IGNITE-8571 > Project: Ignite > Issue Type: New Feature >Reporter: Eduard Shangareev >Assignee: Anton Kalashnikov >Priority: Major > Labels: IEP-4, Phase-2 > Fix For: 2.8 > > Time Spent: 20m > Remaining Estimate: 0h > > Now we have only one way to change BLAT - manually update it via console.sh > or API. > We need to add the possibility to change it automatically. Adjust to current > topology. > So, I propose 2 new distributed parameters which would be responsible to tune > this feature. > 1. Flag autoAdjustEnabled - true/false. Easy. Manual baseline control or auto > adjusting baseline. > 2. autoAdjustTimeout - time which we would wait after the actual topology > change. But it would be reset if new discovery event happened. (node > join/exit). > We need to change API next way: > org.apache.ignite.IgniteCluster: > * isBaselineAutoAdjustEnabled() > * setBaselineAutoAdjustEnabled(boolean enabled); > * setBaselineAutoAdjustTimeout(long timeoutInMs); > Also, we need to ensure that all nodes would have the same > parameters(distributed parameters). > And we should be able to survive coordinator left during parameters changes. > When autoAdjustEnabled is true we should be block ability to manual baseline > change. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-8571) Baseline auto-adjust feature
[ https://issues.apache.org/jira/browse/IGNITE-8571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16771149#comment-16771149 ] Anton Kalashnikov commented on IGNITE-8571: --- [~ibessonov], thanks for notes I have fixed it. > Baseline auto-adjust feature > > > Key: IGNITE-8571 > URL: https://issues.apache.org/jira/browse/IGNITE-8571 > Project: Ignite > Issue Type: New Feature >Reporter: Eduard Shangareev >Assignee: Anton Kalashnikov >Priority: Major > Labels: IEP-4, Phase-2 > Fix For: 2.8 > > Time Spent: 20m > Remaining Estimate: 0h > > Now we have only one way to change BLAT - manually update it via console.sh > or API. > We need to add the possibility to change it automatically. Adjust to current > topology. > So, I propose 2 new distributed parameters which would be responsible to tune > this feature. > 1. Flag autoAdjustEnabled - true/false. Easy. Manual baseline control or auto > adjusting baseline. > 2. autoAdjustTimeout - time which we would wait after the actual topology > change. But it would be reset if new discovery event happened. (node > join/exit). > We need to change API next way: > org.apache.ignite.IgniteCluster: > * isBaselineAutoAdjustEnabled() > * setBaselineAutoAdjustEnabled(boolean enabled); > * setBaselineAutoAdjustTimeout(long timeoutInMs); > Also, we need to ensure that all nodes would have the same > parameters(distributed parameters). > And we should be able to survive coordinator left during parameters changes. > When autoAdjustEnabled is true we should be block ability to manual baseline > change. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-8571) Baseline auto-adjust feature
[ https://issues.apache.org/jira/browse/IGNITE-8571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16771723#comment-16771723 ] Dmitriy Govorukhin commented on IGNITE-8571: [~akalashnikov], [~ibessonov] Many thanks, LGTM, merged to master. > Baseline auto-adjust feature > > > Key: IGNITE-8571 > URL: https://issues.apache.org/jira/browse/IGNITE-8571 > Project: Ignite > Issue Type: New Feature >Reporter: Eduard Shangareev >Assignee: Anton Kalashnikov >Priority: Major > Labels: IEP-4, Phase-2 > Fix For: 2.8 > > Time Spent: 20m > Remaining Estimate: 0h > > Now we have only one way to change BLAT - manually update it via console.sh > or API. > We need to add the possibility to change it automatically. Adjust to current > topology. > So, I propose 2 new distributed parameters which would be responsible to tune > this feature. > 1. Flag autoAdjustEnabled - true/false. Easy. Manual baseline control or auto > adjusting baseline. > 2. autoAdjustTimeout - time which we would wait after the actual topology > change. But it would be reset if new discovery event happened. (node > join/exit). > We need to change API next way: > org.apache.ignite.IgniteCluster: > * isBaselineAutoAdjustEnabled() > * setBaselineAutoAdjustEnabled(boolean enabled); > * setBaselineAutoAdjustTimeout(long timeoutInMs); > Also, we need to ensure that all nodes would have the same > parameters(distributed parameters). > And we should be able to survive coordinator left during parameters changes. > When autoAdjustEnabled is true we should be block ability to manual baseline > change. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
