[jira] [Commented] (IGNITE-8610) Searching checkpoint / WAL history for rebalancing is not properly working in case of local/global WAL disabling
[ https://issues.apache.org/jira/browse/IGNITE-8610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16513634#comment-16513634 ] ASF GitHub Bot commented on IGNITE-8610: Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/4090 > Searching checkpoint / WAL history for rebalancing is not properly working in > case of local/global WAL disabling > > > Key: IGNITE-8610 > URL: https://issues.apache.org/jira/browse/IGNITE-8610 > Project: Ignite > Issue Type: Bug > Components: cache >Affects Versions: 2.5 >Reporter: Pavel Kovalenko >Assignee: Pavel Kovalenko >Priority: Major > Fix For: 2.6 > > > After implementation IGNITE-6411 and IGNITE-8087 we can face with situation > when after some checkpoint, WAL was temporarily disabled and enabled again. > In this case we can't treat that checkpoint as start point to rebalance, > because WAL history after such checkpoint may contain gaps. > We should rework our checkpoint / wal history searching mechanism and ignore > such checkpoints. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-8610) Searching checkpoint / WAL history for rebalancing is not properly working in case of local/global WAL disabling
[
https://issues.apache.org/jira/browse/IGNITE-8610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16503419#comment-16503419
]
Alexey Goncharuk commented on IGNITE-8610:
--
[~Jokser], a few comments:
* In {{GridDhtPreloader}} you've added the following code:
{code}
if (!assignments.isEmpty() && grp.persistenceEnabled()) {
ctx.database().checkpointReadLock();
try {
((GridCacheDatabaseSharedManager)
ctx.database()).lastCheckpointInapplicableForWalRebalance(grp.groupId());
}
finally {
ctx.database().checkpointReadUnlock();
}
}
{code}
I suggest to introduce such a method to the DatabaseSharedManager and have it
empty for default implementation, while persistence-enabled implementation will
acquire checkpoint read lock and du necessary work. This will hide both
{{instanceof}} and {{if (persistenceEnabled())}}
* You've added a synchronous wait for partition re-creation in
{{generateAssignments}}, which happens in exchange thread. Let's add our
generic timed-spin-wait and warn if the wait is too long.
> Searching checkpoint / WAL history for rebalancing is not properly working in
> case of local/global WAL disabling
>
>
> Key: IGNITE-8610
> URL: https://issues.apache.org/jira/browse/IGNITE-8610
> Project: Ignite
> Issue Type: Bug
> Components: cache
>Affects Versions: 2.5
>Reporter: Pavel Kovalenko
>Assignee: Pavel Kovalenko
>Priority: Major
> Fix For: 2.6
>
>
> After implementation IGNITE-6411 and IGNITE-8087 we can face with situation
> when after some checkpoint, WAL was temporarily disabled and enabled again.
> In this case we can't treat that checkpoint as start point to rebalance,
> because WAL history after such checkpoint may contain gaps.
> We should rework our checkpoint / wal history searching mechanism and ignore
> such checkpoints.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-8610) Searching checkpoint / WAL history for rebalancing is not properly working in case of local/global WAL disabling
[ https://issues.apache.org/jira/browse/IGNITE-8610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16500245#comment-16500245 ] Ilya Lantukh commented on IGNITE-8610: -- Looks good. > Searching checkpoint / WAL history for rebalancing is not properly working in > case of local/global WAL disabling > > > Key: IGNITE-8610 > URL: https://issues.apache.org/jira/browse/IGNITE-8610 > Project: Ignite > Issue Type: Bug > Components: cache >Affects Versions: 2.5 >Reporter: Pavel Kovalenko >Assignee: Pavel Kovalenko >Priority: Major > Fix For: 2.6 > > > After implementation IGNITE-6411 and IGNITE-8087 we can face with situation > when after some checkpoint, WAL was temporarily disabled and enabled again. > In this case we can't treat that checkpoint as start point to rebalance, > because WAL history after such checkpoint may contain gaps. > We should rework our checkpoint / wal history searching mechanism and ignore > such checkpoints. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-8610) Searching checkpoint / WAL history for rebalancing is not properly working in case of local/global WAL disabling
[ https://issues.apache.org/jira/browse/IGNITE-8610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16493856#comment-16493856 ] ASF GitHub Bot commented on IGNITE-8610: GitHub user Jokser opened a pull request: https://github.com/apache/ignite/pull/4090 IGNITE-8610 Checkpoint history search fix + refactoring You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-8610 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/4090.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4090 commit df3fb2a24d4d43771094e56fea6680f23e3790e6 Author: Pavel Kovalenko Date: 2018-05-18T09:37:13Z IGNITE-8459 WIP commit 54e88d22bfd4c0b61593b4a8f0d5c319288593b7 Author: Pavel Kovalenko Date: 2018-05-18T16:22:01Z IGNITE-8459 WIP commit e8aeeea9d6c30df2ee03bfada3a8a399cfef7b6b Author: Pavel Kovalenko Date: 2018-05-21T12:42:33Z IGNITE-8459 WIP commit 7d58eb9e3c3fa2358c7937ce3f73715d850a33f1 Author: Pavel Kovalenko Date: 2018-05-24T19:46:24Z IGNITE-8459 Rework. commit bd8ef85034bbf7c03d6c8b40b36fa4398a3b23ca Author: Pavel Kovalenko Date: 2018-05-24T19:50:11Z IGNITE-8459 Remove trash. commit b5addf2b44f8ebebc59823397e134d6796a7e3b6 Author: Pavel Kovalenko Date: 2018-05-25T01:18:45Z IGNITE-8459 Fixed tests. commit fe4d681ae4341accf047b8408a97a22d34f5520f Author: Pavel Kovalenko Date: 2018-05-28T12:09:21Z IGNITE-8459 Tests refactoring. commit 702b88c7466555091c95890a4aa024d869c399f3 Author: Pavel Kovalenko Date: 2018-05-28T12:14:14Z IGNITE-8459 Increase test running time. commit 5b2ccaacafb2ef3c3e02730958c7708768b7c265 Author: Pavel Kovalenko Date: 2018-05-28T13:22:54Z Merge branch 'master' into ignite-8459 # Conflicts: # modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/IgnitePdsCacheRebalancingAbstractTest.java commit cc2fda56ecc48ae878baffe5079d25c917a1280c Author: Pavel Kovalenko Date: 2018-05-28T14:25:30Z IGNITE-8482 Tests improvements. commit edd27a9ba264581e1d0541c2aafc30451dc469b3 Author: Pavel Kovalenko Date: 2018-05-28T14:28:18Z IGNITE-8482 Remove unused import. commit e4e1cb92e016230dc8c8b270c2f8dfe72cc3d098 Author: Pavel Kovalenko Date: 2018-05-29T14:36:01Z IGNITE-8610 WIP commit bae83681794bd02e708647494eba094a4213a9f9 Author: Pavel Kovalenko Date: 2018-05-29T16:55:22Z IGNITE-8610 WIP > Searching checkpoint / WAL history for rebalancing is not properly working in > case of local/global WAL disabling > > > Key: IGNITE-8610 > URL: https://issues.apache.org/jira/browse/IGNITE-8610 > Project: Ignite > Issue Type: Bug > Components: cache >Affects Versions: 2.5 >Reporter: Pavel Kovalenko >Assignee: Pavel Kovalenko >Priority: Major > Fix For: 2.6 > > > After implementation IGNITE-6411 and IGNITE-8087 we can face with situation > when after some checkpoint, WAL was temporarily disabled and enabled again. > In this case we can't treat that checkpoint as start point to rebalance, > because WAL history after such checkpoint may contain gaps. > We should rework our checkpoint / wal history searching mechanism and ignore > such checkpoints. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
