[jira] [Commented] (IGNITE-8645) CacheMetrics.getCacheTxCommits() doesn't include transactions started on client node
[ https://issues.apache.org/jira/browse/IGNITE-8645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16559459#comment-16559459 ] Alexey Kuznetsov commented on IGNITE-8645: -- [~dpavlov] Hi, sorry for delay. The ticket appeared to be not truly implemented. The root cause of the bug is that client metrics protocol is incorrect. Clients have got local cache metrics, e.g. tx-commits-count, but these metrics are not distributed to nodes(see metrics distribution message *TcpDiscoveryClientMetricsUpdateMessage* carries no cache metrics, only cluster metrics). This leads to current bug. So client metrics protocol shall be fixed in first place. Im going to fix it within current ticket. > CacheMetrics.getCacheTxCommits() doesn't include transactions started on > client node > > > Key: IGNITE-8645 > URL: https://issues.apache.org/jira/browse/IGNITE-8645 > Project: Ignite > Issue Type: Bug > Components: cache >Affects Versions: 2.4 >Reporter: Roman Guseinov >Assignee: Alexey Kuznetsov >Priority: Major > Fix For: 2.7 > > Attachments: CacheTxCommitsMetricTest.java > > > The test is attached [^CacheTxCommitsMetricTest.java] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-8645) CacheMetrics.getCacheTxCommits() doesn't include transactions started on client node
[ https://issues.apache.org/jira/browse/IGNITE-8645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16555895#comment-16555895 ] Dmitriy Pavlov commented on IGNITE-8645: Why ticket status is 'In progress'? > CacheMetrics.getCacheTxCommits() doesn't include transactions started on > client node > > > Key: IGNITE-8645 > URL: https://issues.apache.org/jira/browse/IGNITE-8645 > Project: Ignite > Issue Type: Bug > Components: cache >Affects Versions: 2.4 >Reporter: Roman Guseinov >Assignee: Alexey Kuznetsov >Priority: Major > Fix For: 2.7 > > Attachments: CacheTxCommitsMetricTest.java > > > The test is attached [^CacheTxCommitsMetricTest.java] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-8645) CacheMetrics.getCacheTxCommits() doesn't include transactions started on client node
[ https://issues.apache.org/jira/browse/IGNITE-8645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527303#comment-16527303 ] Alexey Kuznetsov commented on IGNITE-8645: -- [~guseinov] Hi Ticket is ready for review. Can you review it or ask somebody to review it? > CacheMetrics.getCacheTxCommits() doesn't include transactions started on > client node > > > Key: IGNITE-8645 > URL: https://issues.apache.org/jira/browse/IGNITE-8645 > Project: Ignite > Issue Type: Bug > Components: cache >Affects Versions: 2.4 >Reporter: Roman Guseinov >Assignee: Alexey Kuznetsov >Priority: Major > Fix For: 2.7 > > Attachments: CacheTxCommitsMetricTest.java > > > The test is attached [^CacheTxCommitsMetricTest.java] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-8645) CacheMetrics.getCacheTxCommits() doesn't include transactions started on client node
[ https://issues.apache.org/jira/browse/IGNITE-8645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16525129#comment-16525129 ] Aleksey Plekhanov commented on IGNITE-8645: --- [~Alexey Kuznetsov] fix looks good to me. > CacheMetrics.getCacheTxCommits() doesn't include transactions started on > client node > > > Key: IGNITE-8645 > URL: https://issues.apache.org/jira/browse/IGNITE-8645 > Project: Ignite > Issue Type: Bug > Components: cache >Affects Versions: 2.4 >Reporter: Roman Guseinov >Assignee: Alexey Kuznetsov >Priority: Major > Fix For: 2.7 > > Attachments: CacheTxCommitsMetricTest.java > > > The test is attached [^CacheTxCommitsMetricTest.java] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-8645) CacheMetrics.getCacheTxCommits() doesn't include transactions started on client node
[ https://issues.apache.org/jira/browse/IGNITE-8645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16507022#comment-16507022 ] Ryabov Dmitrii commented on IGNITE-8645: Looks good. > CacheMetrics.getCacheTxCommits() doesn't include transactions started on > client node > > > Key: IGNITE-8645 > URL: https://issues.apache.org/jira/browse/IGNITE-8645 > Project: Ignite > Issue Type: Bug > Components: cache >Affects Versions: 2.4 >Reporter: Roman Guseinov >Assignee: Alexey Kuznetsov >Priority: Major > Fix For: 2.6 > > Attachments: CacheTxCommitsMetricTest.java > > > The test is attached [^CacheTxCommitsMetricTest.java] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-8645) CacheMetrics.getCacheTxCommits() doesn't include transactions started on client node
[ https://issues.apache.org/jira/browse/IGNITE-8645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16505845#comment-16505845 ] ASF GitHub Bot commented on IGNITE-8645: GitHub user voipp reopened a pull request: https://github.com/apache/ignite/pull/4154 IGNITE-8645 fix for client tx metrics aren't included to cache metrics You can merge this pull request into a Git repository by running: $ git pull https://github.com/voipp/ignite IGNITE-8645 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/4154.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4154 commit c3ed2cf9ebadea7e78ef34de0914c16603d9352a Author: voipp Date: 2018-06-01T16:28:55Z IGNITE-8645 fix for client tx metrics aren't included to cache metrics > CacheMetrics.getCacheTxCommits() doesn't include transactions started on > client node > > > Key: IGNITE-8645 > URL: https://issues.apache.org/jira/browse/IGNITE-8645 > Project: Ignite > Issue Type: Bug > Components: cache >Affects Versions: 2.4 >Reporter: Roman Guseinov >Assignee: Alexey Kuznetsov >Priority: Major > Fix For: 2.6 > > Attachments: CacheTxCommitsMetricTest.java > > > The test is attached [^CacheTxCommitsMetricTest.java] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-8645) CacheMetrics.getCacheTxCommits() doesn't include transactions started on client node
[ https://issues.apache.org/jira/browse/IGNITE-8645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16505843#comment-16505843 ] ASF GitHub Bot commented on IGNITE-8645: Github user voipp closed the pull request at: https://github.com/apache/ignite/pull/4154 > CacheMetrics.getCacheTxCommits() doesn't include transactions started on > client node > > > Key: IGNITE-8645 > URL: https://issues.apache.org/jira/browse/IGNITE-8645 > Project: Ignite > Issue Type: Bug > Components: cache >Affects Versions: 2.4 >Reporter: Roman Guseinov >Assignee: Alexey Kuznetsov >Priority: Major > Fix For: 2.6 > > Attachments: CacheTxCommitsMetricTest.java > > > The test is attached [^CacheTxCommitsMetricTest.java] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-8645) CacheMetrics.getCacheTxCommits() doesn't include transactions started on client node
[ https://issues.apache.org/jira/browse/IGNITE-8645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16505839#comment-16505839 ] ASF GitHub Bot commented on IGNITE-8645: GitHub user voipp opened a pull request: https://github.com/apache/ignite/pull/4154 IGNITE-8645 fix for client tx metrics aren't included to cache metrics You can merge this pull request into a Git repository by running: $ git pull https://github.com/voipp/ignite IGNITE-8645 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/4154.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4154 commit c3ed2cf9ebadea7e78ef34de0914c16603d9352a Author: voipp Date: 2018-06-01T16:28:55Z IGNITE-8645 fix for client tx metrics aren't included to cache metrics > CacheMetrics.getCacheTxCommits() doesn't include transactions started on > client node > > > Key: IGNITE-8645 > URL: https://issues.apache.org/jira/browse/IGNITE-8645 > Project: Ignite > Issue Type: Bug > Components: cache >Affects Versions: 2.4 >Reporter: Roman Guseinov >Assignee: Alexey Kuznetsov >Priority: Major > Fix For: 2.6 > > Attachments: CacheTxCommitsMetricTest.java > > > The test is attached [^CacheTxCommitsMetricTest.java] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-8645) CacheMetrics.getCacheTxCommits() doesn't include transactions started on client node
[ https://issues.apache.org/jira/browse/IGNITE-8645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16505835#comment-16505835 ] ASF GitHub Bot commented on IGNITE-8645: Github user voipp closed the pull request at: https://github.com/apache/ignite/pull/4111 > CacheMetrics.getCacheTxCommits() doesn't include transactions started on > client node > > > Key: IGNITE-8645 > URL: https://issues.apache.org/jira/browse/IGNITE-8645 > Project: Ignite > Issue Type: Bug > Components: cache >Affects Versions: 2.4 >Reporter: Roman Guseinov >Assignee: Alexey Kuznetsov >Priority: Major > Fix For: 2.6 > > Attachments: CacheTxCommitsMetricTest.java > > > The test is attached [^CacheTxCommitsMetricTest.java] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-8645) CacheMetrics.getCacheTxCommits() doesn't include transactions started on client node
[ https://issues.apache.org/jira/browse/IGNITE-8645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16504586#comment-16504586 ] Alexey Kuznetsov commented on IGNITE-8645: -- [~guseinov] ok > CacheMetrics.getCacheTxCommits() doesn't include transactions started on > client node > > > Key: IGNITE-8645 > URL: https://issues.apache.org/jira/browse/IGNITE-8645 > Project: Ignite > Issue Type: Bug > Components: cache >Affects Versions: 2.4 >Reporter: Roman Guseinov >Assignee: Alexey Kuznetsov >Priority: Major > Fix For: 2.6 > > Attachments: CacheTxCommitsMetricTest.java > > > The test is attached [^CacheTxCommitsMetricTest.java] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-8645) CacheMetrics.getCacheTxCommits() doesn't include transactions started on client node
[ https://issues.apache.org/jira/browse/IGNITE-8645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16504582#comment-16504582 ] Roman Guseinov commented on IGNITE-8645: Hi [~Alexey Kuznetsov] , I don't mind. Could you please create an additional ticket for that? > CacheMetrics.getCacheTxCommits() doesn't include transactions started on > client node > > > Key: IGNITE-8645 > URL: https://issues.apache.org/jira/browse/IGNITE-8645 > Project: Ignite > Issue Type: Bug > Components: cache >Affects Versions: 2.4 >Reporter: Roman Guseinov >Assignee: Alexey Kuznetsov >Priority: Major > Fix For: 2.6 > > Attachments: CacheTxCommitsMetricTest.java > > > The test is attached [^CacheTxCommitsMetricTest.java] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-8645) CacheMetrics.getCacheTxCommits() doesn't include transactions started on client node
[ https://issues.apache.org/jira/browse/IGNITE-8645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16500300#comment-16500300 ] Alexey Kuznetsov commented on IGNITE-8645: -- [~guseinov] , [~kuaw26] hi. I have nearly fixed cache metrics(now, calling _cache(CACHE_NAME).metrics().getCacheTxCommits()_ result in correct value). But have some problems with fixing Visor metrics. I propose to create a separate ticket for fixing Visor metrics, and assign it to [~kuaw26] Are you agree ? > CacheMetrics.getCacheTxCommits() doesn't include transactions started on > client node > > > Key: IGNITE-8645 > URL: https://issues.apache.org/jira/browse/IGNITE-8645 > Project: Ignite > Issue Type: Bug > Components: cache >Affects Versions: 2.4 >Reporter: Roman Guseinov >Assignee: Alexey Kuznetsov >Priority: Major > Attachments: CacheTxCommitsMetricTest.java > > > The test is attached [^CacheTxCommitsMetricTest.java] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-8645) CacheMetrics.getCacheTxCommits() doesn't include transactions started on client node
[
https://issues.apache.org/jira/browse/IGNITE-8645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16497529#comment-16497529
]
Roman Guseinov commented on IGNITE-8645:
[~Alexey Kuznetsov], thank you for the comment. I think it can be used as a
workaround:
{code:java}
cache.metrics(grid.cluster().forCacheNodes(cache.getName())).getCacheTxCommits(){code}
But when we call `ignite.cache(CACHE_NAME).metrics()` we expect to *'Get whole
cluster snapshot metrics (statistics) for this cache*' (JavaDoc) not only
metrics from server nodes
[https://github.com/apache/ignite/blob/master/modules/core/src/main/java/org/apache/ignite/IgniteCache.java#L1469]
Maybe it is obvious behavior for developers but not for users.
> CacheMetrics.getCacheTxCommits() doesn't include transactions started on
> client node
>
>
> Key: IGNITE-8645
> URL: https://issues.apache.org/jira/browse/IGNITE-8645
> Project: Ignite
> Issue Type: Bug
> Components: cache
>Affects Versions: 2.4
>Reporter: Roman Guseinov
>Assignee: Alexey Kuznetsov
>Priority: Major
> Attachments: CacheTxCommitsMetricTest.java
>
>
> The test is attached [^CacheTxCommitsMetricTest.java]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-8645) CacheMetrics.getCacheTxCommits() doesn't include transactions started on client node
[
https://issues.apache.org/jira/browse/IGNITE-8645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496802#comment-16496802
]
Alexey Kuznetsov commented on IGNITE-8645:
--
[~guseinov] hi
I think your test is incorrect.
You spawn transactions from *client* node, but check tx metrics on server nodes.
You check metrics as follows,
{code:java}
long actual =
ignite.cache(CACHE_NAME).metrics().getCacheTxCommits();
assertEquals("Check CacheMetrics.getCacheTxCommits()",
EXPECTED_TX_COMMITS_TOTAL, actual);
{code}
When you start transaction from client node, transaction mertics would be
collected on client node only.
Note that _ignite.cache(CACHE_NAME).metrics()_ returns only cluster-wide
metrics from *server* nodes(this change was introduced here :
https://issues.apache.org/jira/browse/IGNITE-4264)
I propose to change your test like this:
{code:java}
long actual =
cache.metrics(grid.cluster().forCacheNodes(cache.getName())).getCacheTxCommits();
assertEquals("Check CacheMetrics.getCacheTxCommits()",
EXPECTED_TX_COMMITS_TOTAL, actual);
{code}
Are you agree ?
> CacheMetrics.getCacheTxCommits() doesn't include transactions started on
> client node
>
>
> Key: IGNITE-8645
> URL: https://issues.apache.org/jira/browse/IGNITE-8645
> Project: Ignite
> Issue Type: Bug
> Components: cache
>Affects Versions: 2.4
>Reporter: Roman Guseinov
>Assignee: Alexey Kuznetsov
>Priority: Major
> Attachments: CacheTxCommitsMetricTest.java
>
>
> The test is attached [^CacheTxCommitsMetricTest.java]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
