[jira] [Commented] (IGNITE-8685) Incorrect size for switch segment record
[ https://issues.apache.org/jira/browse/IGNITE-8685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16503379#comment-16503379 ] ASF GitHub Bot commented on IGNITE-8685: Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/4130 > Incorrect size for switch segment record > - > > Key: IGNITE-8685 > URL: https://issues.apache.org/jira/browse/IGNITE-8685 > Project: Ignite > Issue Type: Bug >Reporter: Dmitriy Govorukhin >Assignee: Dmitriy Govorukhin >Priority: Critical > Fix For: 2.6 > > > We have invariant that switch segment record should have the size of one byte. > Although, in the current implementation, size calculation with overhard for > storing CRC and WAL pointer. > In current implementation, we can suddenly stop WAL iteration which may > result in random data store corruptions or missing updates on node recovery. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-8685) Incorrect size for switch segment record
[ https://issues.apache.org/jira/browse/IGNITE-8685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16503105#comment-16503105 ] Dmitriy Govorukhin commented on IGNITE-8685: [~agoncharuk] I fixed all your comments, please review again. > Incorrect size for switch segment record > - > > Key: IGNITE-8685 > URL: https://issues.apache.org/jira/browse/IGNITE-8685 > Project: Ignite > Issue Type: Bug >Reporter: Dmitriy Govorukhin >Assignee: Dmitriy Govorukhin >Priority: Critical > Fix For: 2.6 > > > We have invariant that switch segment record should have the size of one byte. > Although, in the current implementation, size calculation with overhard for > storing CRC and WAL pointer. > In current implementation, we can suddenly stop WAL iteration which may > result in random data store corruptions or missing updates on node recovery. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-8685) Incorrect size for switch segment record
[ https://issues.apache.org/jira/browse/IGNITE-8685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16503008#comment-16503008 ] Dmitriy Govorukhin commented on IGNITE-8685: [~agoncharuk] Thanks for the review, maybe I can add a unit test within the scope of this issue? > Incorrect size for switch segment record > - > > Key: IGNITE-8685 > URL: https://issues.apache.org/jira/browse/IGNITE-8685 > Project: Ignite > Issue Type: Bug >Reporter: Dmitriy Govorukhin >Assignee: Dmitriy Govorukhin >Priority: Critical > Fix For: 2.6 > > > We have invariant that switch segment record should have the size of one byte. > Although, in the current implementation, size calculation with overhard for > storing CRC and WAL pointer. > In current implementation, we can suddenly stop WAL iteration which may > result in random data store corruptions or missing updates on node recovery. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-8685) Incorrect size for switch segment record
[ https://issues.apache.org/jira/browse/IGNITE-8685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16502990#comment-16502990 ] Alexey Goncharuk commented on IGNITE-8685: -- [~DmitriyGovorukhin], please add a comment on why switch segment record should be of specific size. Also, should we add a unit-test for serializer and check that switch segment is 1 byte exactly? If you think it makes sense, please create a separate ticket. > Incorrect size for switch segment record > - > > Key: IGNITE-8685 > URL: https://issues.apache.org/jira/browse/IGNITE-8685 > Project: Ignite > Issue Type: Bug >Reporter: Dmitriy Govorukhin >Assignee: Dmitriy Govorukhin >Priority: Critical > Fix For: 2.6 > > > We have invariant that switch segment record should have the size of one byte. > Although, in the current implementation, size calculation with overhard for > storing CRC and WAL pointer. > In current implementation, we can suddenly stop WAL iteration which may > result in random data store corruptions or missing updates on node recovery. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-8685) Incorrect size for switch segment record
[ https://issues.apache.org/jira/browse/IGNITE-8685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16501670#comment-16501670 ] ASF GitHub Bot commented on IGNITE-8685: GitHub user DmitriyGovorukhin opened a pull request: https://github.com/apache/ignite/pull/4130 IGNITE-8685 Incorrect size for switch segment record You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-8685 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/4130.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4130 commit 316ae35376058896b29db86d188147c6780c5ac2 Author: Dmitriy Govorukhin Date: 2018-06-05T11:53:36Z IGNITE-8685 remove unused baseline record commit f42620ba4bfc2805d6ec581036d9bc6e947c458c Author: Dmitriy Govorukhin Date: 2018-06-05T11:56:10Z IGNITE-8685 add test reproducer commit 1cd5282184b5eca62a54a86e1d58e7660aefd3eb Author: Dmitriy Govorukhin Date: 2018-06-05T12:02:59Z IGNITE-8685 fix calculation switch segment record size commit 4a999e397d7c5d3ddc1a764e1080b807b92d9749 Author: Dmitriy Govorukhin Date: 2018-06-05T12:14:58Z Merge branch 'master' into ignite-8685 > Incorrect size for switch segment record > - > > Key: IGNITE-8685 > URL: https://issues.apache.org/jira/browse/IGNITE-8685 > Project: Ignite > Issue Type: Bug >Reporter: Dmitriy Govorukhin >Assignee: Dmitriy Govorukhin >Priority: Major > Fix For: 2.6 > > > We have invariant that switch segment record should have the size of one byte. > Although, in the current implementation, size calculation with overhard for > storing CRC and WAL pointer. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
