[jira] [Commented] (IGNITE-8766) TcpDiscoverySpi: discovery threads naming
[
https://issues.apache.org/jira/browse/IGNITE-8766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16728421#comment-16728421
]
Ignite TC Bot commented on IGNITE-8766:
---
{panel:title=--> Run :: All: No blockers
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
[TeamCity *--> Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=2536409&buildTypeId=IgniteTests24Java8_RunAll]
> TcpDiscoverySpi: discovery threads naming
> -
>
> Key: IGNITE-8766
> URL: https://issues.apache.org/jira/browse/IGNITE-8766
> Project: Ignite
> Issue Type: Improvement
> Components: general
>Reporter: Sergey Chugunov
>Assignee: Sergey Chugunov
>Priority: Major
> Labels: discovery
> Fix For: 2.8
>
>
> Including information about next/prev nodes into names of discovery-related
> threads could be very helpful when investigating situations of network
> glitches.
> tcp-disco-sock-reader and tcp-disco-msg-worker threads must include such
> information in their names.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-8766) TcpDiscoverySpi: discovery threads naming
[ https://issues.apache.org/jira/browse/IGNITE-8766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16728422#comment-16728422 ] Sergey Chugunov commented on IGNITE-8766: - [~agoncharuk], No blockers emerged after my change, so could you please take a look one more time? > TcpDiscoverySpi: discovery threads naming > - > > Key: IGNITE-8766 > URL: https://issues.apache.org/jira/browse/IGNITE-8766 > Project: Ignite > Issue Type: Improvement > Components: general >Reporter: Sergey Chugunov >Assignee: Sergey Chugunov >Priority: Major > Labels: discovery > Fix For: 2.8 > > > Including information about next/prev nodes into names of discovery-related > threads could be very helpful when investigating situations of network > glitches. > tcp-disco-sock-reader and tcp-disco-msg-worker threads must include such > information in their names. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-8766) TcpDiscoverySpi: discovery threads naming
[ https://issues.apache.org/jira/browse/IGNITE-8766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16719821#comment-16719821 ] Sergey Chugunov commented on IGNITE-8766: - [~agoncharuk], Good catch! I changed ServerImpl implementation so when the very first node starts up or the very last node becomes coordinator, *tcp-disco-msg-worker* thread's name is modified only once. New TC Run is triggered. > TcpDiscoverySpi: discovery threads naming > - > > Key: IGNITE-8766 > URL: https://issues.apache.org/jira/browse/IGNITE-8766 > Project: Ignite > Issue Type: Improvement > Components: general >Reporter: Sergey Chugunov >Assignee: Sergey Chugunov >Priority: Major > Labels: discovery > Fix For: 2.8 > > > Including information about next/prev nodes into names of discovery-related > threads could be very helpful when investigating situations of network > glitches. > tcp-disco-sock-reader and tcp-disco-msg-worker threads must include such > information in their names. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-8766) TcpDiscoverySpi: discovery threads naming
[
https://issues.apache.org/jira/browse/IGNITE-8766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717434#comment-16717434
]
Alexey Goncharuk commented on IGNITE-8766:
--
[~sergey-chugunov], can we improve the code to call {{enhanceThreadName}} on
coordinator only once, when node becomes the coordinator? Otherwise we will
generate a string on each processed message on coordinator.
> TcpDiscoverySpi: discovery threads naming
> -
>
> Key: IGNITE-8766
> URL: https://issues.apache.org/jira/browse/IGNITE-8766
> Project: Ignite
> Issue Type: Improvement
> Components: general
>Reporter: Sergey Chugunov
>Assignee: Dmitry Karachentsev
>Priority: Major
> Labels: discovery
> Fix For: 2.8
>
>
> Including information about next/prev nodes into names of discovery-related
> threads could be very helpful when investigating situations of network
> glitches.
> tcp-disco-sock-reader and tcp-disco-msg-worker threads must include such
> information in their names.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-8766) TcpDiscoverySpi: discovery threads naming
[ https://issues.apache.org/jira/browse/IGNITE-8766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16714856#comment-16714856 ] Sergey Chugunov commented on IGNITE-8766: - I reviewed changes one more time and merged latest master, according to TC Bot there are no blocker tests. I think we could proceed with merging this to master branch. > TcpDiscoverySpi: discovery threads naming > - > > Key: IGNITE-8766 > URL: https://issues.apache.org/jira/browse/IGNITE-8766 > Project: Ignite > Issue Type: Improvement > Components: general >Reporter: Sergey Chugunov >Assignee: Dmitry Karachentsev >Priority: Major > Labels: discovery > Fix For: 2.8 > > > Including information about next/prev nodes into names of discovery-related > threads could be very helpful when investigating situations of network > glitches. > tcp-disco-sock-reader and tcp-disco-msg-worker threads must include such > information in their names. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-8766) TcpDiscoverySpi: discovery threads naming
[
https://issues.apache.org/jira/browse/IGNITE-8766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16714847#comment-16714847
]
Ignite TC Bot commented on IGNITE-8766:
---
{panel:title=--> Run :: All: No blockers
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
[TeamCity *--> Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=2509249&buildTypeId=IgniteTests24Java8_RunAll]
> TcpDiscoverySpi: discovery threads naming
> -
>
> Key: IGNITE-8766
> URL: https://issues.apache.org/jira/browse/IGNITE-8766
> Project: Ignite
> Issue Type: Improvement
> Components: general
>Reporter: Sergey Chugunov
>Assignee: Dmitry Karachentsev
>Priority: Major
> Labels: discovery
> Fix For: 2.8
>
>
> Including information about next/prev nodes into names of discovery-related
> threads could be very helpful when investigating situations of network
> glitches.
> tcp-disco-sock-reader and tcp-disco-msg-worker threads must include such
> information in their names.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-8766) TcpDiscoverySpi: discovery threads naming
[ https://issues.apache.org/jira/browse/IGNITE-8766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16638380#comment-16638380 ] Dmitry Karachentsev commented on IGNITE-8766: - [~NIzhikov] it's just waiting to be merged to master as I can see. > TcpDiscoverySpi: discovery threads naming > - > > Key: IGNITE-8766 > URL: https://issues.apache.org/jira/browse/IGNITE-8766 > Project: Ignite > Issue Type: Improvement > Components: general >Reporter: Sergey Chugunov >Assignee: Dmitry Karachentsev >Priority: Major > Labels: discovery > Fix For: 2.8 > > > Including information about next/prev nodes into names of discovery-related > threads could be very helpful when investigating situations of network > glitches. > tcp-disco-sock-reader and tcp-disco-msg-worker threads must include such > information in their names. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-8766) TcpDiscoverySpi: discovery threads naming
[ https://issues.apache.org/jira/browse/IGNITE-8766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16623553#comment-16623553 ] Nikolay Izhikov commented on IGNITE-8766: - [~dkarachentsev], [~sergey-chugunov] Do we have a chance to resolve this ticket until the code freeze of 2.7? > TcpDiscoverySpi: discovery threads naming > - > > Key: IGNITE-8766 > URL: https://issues.apache.org/jira/browse/IGNITE-8766 > Project: Ignite > Issue Type: Improvement > Components: general >Reporter: Sergey Chugunov >Assignee: Dmitry Karachentsev >Priority: Major > Labels: discovery > Fix For: 2.7 > > > Including information about next/prev nodes into names of discovery-related > threads could be very helpful when investigating situations of network > glitches. > tcp-disco-sock-reader and tcp-disco-msg-worker threads must include such > information in their names. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-8766) TcpDiscoverySpi: discovery threads naming
[ https://issues.apache.org/jira/browse/IGNITE-8766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16558531#comment-16558531 ] Sergey Chugunov commented on IGNITE-8766: - [~dkarachentsev], Change looks good to me, I triggered TC Run All although there is only a minimal chance this improvement could break any tests. In case on no test failures please proceed with merging. Thank you for contribution! > TcpDiscoverySpi: discovery threads naming > - > > Key: IGNITE-8766 > URL: https://issues.apache.org/jira/browse/IGNITE-8766 > Project: Ignite > Issue Type: Improvement > Components: general >Reporter: Sergey Chugunov >Assignee: Dmitry Karachentsev >Priority: Major > Labels: discovery > Fix For: 2.7 > > > Including information about next/prev nodes into names of discovery-related > threads could be very helpful when investigating situations of network > glitches. > tcp-disco-sock-reader and tcp-disco-msg-worker threads must include such > information in their names. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-8766) TcpDiscoverySpi: discovery threads naming
[ https://issues.apache.org/jira/browse/IGNITE-8766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16534495#comment-16534495 ] Dmitry Karachentsev commented on IGNITE-8766: - [TC results|https://ci.ignite.apache.org/project.html?projectId=IgniteTests24Java8&branch_IgniteTests24Java8=pull%2F4317%2Fhead] > TcpDiscoverySpi: discovery threads naming > - > > Key: IGNITE-8766 > URL: https://issues.apache.org/jira/browse/IGNITE-8766 > Project: Ignite > Issue Type: Improvement > Components: general >Reporter: Sergey Chugunov >Assignee: Dmitry Karachentsev >Priority: Major > Labels: discovery > Fix For: 2.7 > > > Including information about next/prev nodes into names of discovery-related > threads could be very helpful when investigating situations of network > glitches. > tcp-disco-sock-reader and tcp-disco-msg-worker threads must include such > information in their names. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-8766) TcpDiscoverySpi: discovery threads naming
[
https://issues.apache.org/jira/browse/IGNITE-8766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16533963#comment-16533963
]
Dmitry Karachentsev commented on IGNITE-8766:
-
Added coordinator flag. If local node is coordinator "crd" will be adder to
ring message worker thread name:
{noformat}
"tcp-disco-msg-worker-[ebd1a087 127.0.0.1:47501 crd]-#2"
{noformat}
> TcpDiscoverySpi: discovery threads naming
> -
>
> Key: IGNITE-8766
> URL: https://issues.apache.org/jira/browse/IGNITE-8766
> Project: Ignite
> Issue Type: Improvement
> Components: general
>Reporter: Sergey Chugunov
>Assignee: Dmitry Karachentsev
>Priority: Major
> Labels: discovery
> Fix For: 2.7
>
>
> Including information about next/prev nodes into names of discovery-related
> threads could be very helpful when investigating situations of network
> glitches.
> tcp-disco-sock-reader and tcp-disco-msg-worker threads must include such
> information in their names.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-8766) TcpDiscoverySpi: discovery threads naming
[ https://issues.apache.org/jira/browse/IGNITE-8766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16533928#comment-16533928 ] ASF GitHub Bot commented on IGNITE-8766: GitHub user dkarachentsev opened a pull request: https://github.com/apache/ignite/pull/4317 IGNITE-8766 - TcpDiscoverySpi: discovery threads naming You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-8766 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/4317.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4317 commit 8971f29cefe49b1b30bd885919dedef71811fe99 Author: dkarachentsev Date: 2018-07-05T17:25:18Z IGNITE-8766 - TcpDiscoverySpi: discovery threads naming > TcpDiscoverySpi: discovery threads naming > - > > Key: IGNITE-8766 > URL: https://issues.apache.org/jira/browse/IGNITE-8766 > Project: Ignite > Issue Type: Improvement > Components: general >Reporter: Sergey Chugunov >Assignee: Dmitry Karachentsev >Priority: Major > Labels: discovery > > Including information about next/prev nodes into names of discovery-related > threads could be very helpful when investigating situations of network > glitches. > tcp-disco-sock-reader and tcp-disco-msg-worker threads must include such > information in their names. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
