[jira] [Commented] (IGNITE-8905) Incorrect assertion in GridDhtPartitionsExchangeFuture
[ https://issues.apache.org/jira/browse/IGNITE-8905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16540324#comment-16540324 ] ASF GitHub Bot commented on IGNITE-8905: Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/4288 > Incorrect assertion in GridDhtPartitionsExchangeFuture > -- > > Key: IGNITE-8905 > URL: https://issues.apache.org/jira/browse/IGNITE-8905 > Project: Ignite > Issue Type: Bug >Reporter: Sergey Chugunov >Assignee: Sergey Chugunov >Priority: Major > Fix For: 2.7 > > Original Estimate: 2h > Time Spent: 2h > Remaining Estimate: 59m > > Assertion was added as part IGNITE-8657 into GridDhtPartitionsExchangeFuture > which is correct only in situation when client has to reconnect due to too > short EXCHANGE_HISTORY. > Exceptions from other situations like not being able to acquire file lock are > also passed to client node in FullMessage. > This assertion should be removed and check should be introduced instead: if > this exception is intended to be thrown on current client node, we should do > this, otherwise old program flow should be executed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-8905) Incorrect assertion in GridDhtPartitionsExchangeFuture
[ https://issues.apache.org/jira/browse/IGNITE-8905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16540276#comment-16540276 ] Sergey Chugunov commented on IGNITE-8905: - [~Mmuzaf], Could you send me a link to TC run with failed test? I don't see it in TC report, this particular test seems passing: [link|https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_Cache5&branch_IgniteTests24Java8=pull%2F4288%2Fhead&tab=buildTypeStatusDiv] > Incorrect assertion in GridDhtPartitionsExchangeFuture > -- > > Key: IGNITE-8905 > URL: https://issues.apache.org/jira/browse/IGNITE-8905 > Project: Ignite > Issue Type: Bug >Reporter: Sergey Chugunov >Assignee: Sergey Chugunov >Priority: Major > Fix For: 2.7 > > Original Estimate: 2h > Time Spent: 2h > Remaining Estimate: 59m > > Assertion was added as part IGNITE-8657 into GridDhtPartitionsExchangeFuture > which is correct only in situation when client has to reconnect due to too > short EXCHANGE_HISTORY. > Exceptions from other situations like not being able to acquire file lock are > also passed to client node in FullMessage. > This assertion should be removed and check should be introduced instead: if > this exception is intended to be thrown on current client node, we should do > this, otherwise old program flow should be executed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-8905) Incorrect assertion in GridDhtPartitionsExchangeFuture
[
https://issues.apache.org/jira/browse/IGNITE-8905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16540149#comment-16540149
]
Maxim Muzafarov commented on IGNITE-8905:
-
[~sergey-chugunov],
Make sense. Changes looks good to me.
Can you clarify: {{CacheSerializableTransactionsTest#testIncrementTxRestart}} –
I see fails on TC but can't reprcoduce error locally. What should I tune?
> Incorrect assertion in GridDhtPartitionsExchangeFuture
> --
>
> Key: IGNITE-8905
> URL: https://issues.apache.org/jira/browse/IGNITE-8905
> Project: Ignite
> Issue Type: Bug
>Reporter: Sergey Chugunov
>Assignee: Sergey Chugunov
>Priority: Major
> Fix For: 2.7
>
> Original Estimate: 2h
> Time Spent: 2h
> Remaining Estimate: 59m
>
> Assertion was added as part IGNITE-8657 into GridDhtPartitionsExchangeFuture
> which is correct only in situation when client has to reconnect due to too
> short EXCHANGE_HISTORY.
> Exceptions from other situations like not being able to acquire file lock are
> also passed to client node in FullMessage.
> This assertion should be removed and check should be introduced instead: if
> this exception is intended to be thrown on current client node, we should do
> this, otherwise old program flow should be executed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-8905) Incorrect assertion in GridDhtPartitionsExchangeFuture
[ https://issues.apache.org/jira/browse/IGNITE-8905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16539857#comment-16539857 ] Anton Kalashnikov commented on IGNITE-8905: --- Looks good for me. We need to wait TC run and if it's ok, this branch can be merged. > Incorrect assertion in GridDhtPartitionsExchangeFuture > -- > > Key: IGNITE-8905 > URL: https://issues.apache.org/jira/browse/IGNITE-8905 > Project: Ignite > Issue Type: Bug >Reporter: Sergey Chugunov >Assignee: Sergey Chugunov >Priority: Major > Fix For: 2.7 > > Original Estimate: 2h > Time Spent: 2h > Remaining Estimate: 59m > > Assertion was added as part IGNITE-8657 into GridDhtPartitionsExchangeFuture > which is correct only in situation when client has to reconnect due to too > short EXCHANGE_HISTORY. > Exceptions from other situations like not being able to acquire file lock are > also passed to client node in FullMessage. > This assertion should be removed and check should be introduced instead: if > this exception is intended to be thrown on current client node, we should do > this, otherwise old program flow should be executed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-8905) Incorrect assertion in GridDhtPartitionsExchangeFuture
[ https://issues.apache.org/jira/browse/IGNITE-8905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16538475#comment-16538475 ] Sergey Chugunov commented on IGNITE-8905: - IGNITE-8853 will be fixed as part of this issue. > Incorrect assertion in GridDhtPartitionsExchangeFuture > -- > > Key: IGNITE-8905 > URL: https://issues.apache.org/jira/browse/IGNITE-8905 > Project: Ignite > Issue Type: Bug >Reporter: Sergey Chugunov >Assignee: Sergey Chugunov >Priority: Major > Fix For: 2.7 > > Original Estimate: 2h > Time Spent: 2h > Remaining Estimate: 59m > > Assertion was added as part IGNITE-8657 into GridDhtPartitionsExchangeFuture > which is correct only in situation when client has to reconnect due to too > short EXCHANGE_HISTORY. > Exceptions from other situations like not being able to acquire file lock are > also passed to client node in FullMessage. > This assertion should be removed and check should be introduced instead: if > this exception is intended to be thrown on current client node, we should do > this, otherwise old program flow should be executed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-8905) Incorrect assertion in GridDhtPartitionsExchangeFuture
[
https://issues.apache.org/jira/browse/IGNITE-8905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535717#comment-16535717
]
Maxim Muzafarov commented on IGNITE-8905:
-
[~dpavlov], [~sergey-chugunov],
Folks,
As we have stable execution timeouts for some test suites (e.g. currently at
Activate\Deactivate cluster suite) TeamCity Run:All would not show as that we
on the safe side with this fix.
Thus I think it's a good practice to have for PR a special reproducer for
described case.
I've reviewed test cases added by IGNITE-8657
{{testClientReconnectOnExchangeHistoryExhaustion}},
{{testClientInForceServerModeStopsOnExchangeHistoryExhaustion}} and they are
not cover this issue.
What do you think?
> Incorrect assertion in GridDhtPartitionsExchangeFuture
> --
>
> Key: IGNITE-8905
> URL: https://issues.apache.org/jira/browse/IGNITE-8905
> Project: Ignite
> Issue Type: Bug
>Reporter: Sergey Chugunov
>Assignee: Sergey Chugunov
>Priority: Major
> Fix For: 2.7
>
> Original Estimate: 2h
> Time Spent: 1h 1m
> Remaining Estimate: 59m
>
> Assertion was added as part IGNITE-8657 into GridDhtPartitionsExchangeFuture
> which is correct only in situation when client has to reconnect due to too
> short EXCHANGE_HISTORY.
> Exceptions from other situations like not being able to acquire file lock are
> also passed to client node in FullMessage.
> This assertion should be removed and check should be introduced instead: if
> this exception is intended to be thrown on current client node, we should do
> this, otherwise old program flow should be executed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-8905) Incorrect assertion in GridDhtPartitionsExchangeFuture
[ https://issues.apache.org/jira/browse/IGNITE-8905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535012#comment-16535012 ] Sergey Chugunov commented on IGNITE-8905: - [~dpavlov], Thanks for spotting the situation with IgniteAtomicLongChangingTopologySelfTest tests. I found an issue and pushed a fix, will rerun TC to make sure that tests are OK now. > Incorrect assertion in GridDhtPartitionsExchangeFuture > -- > > Key: IGNITE-8905 > URL: https://issues.apache.org/jira/browse/IGNITE-8905 > Project: Ignite > Issue Type: Bug >Reporter: Sergey Chugunov >Assignee: Sergey Chugunov >Priority: Major > Fix For: 2.7 > > Original Estimate: 2h > Time Spent: 1h 1m > Remaining Estimate: 59m > > Assertion was added as part IGNITE-8657 into GridDhtPartitionsExchangeFuture > which is correct only in situation when client has to reconnect due to too > short EXCHANGE_HISTORY. > Exceptions from other situations like not being able to acquire file lock are > also passed to client node in FullMessage. > This assertion should be removed and check should be introduced instead: if > this exception is intended to be thrown on current client node, we should do > this, otherwise old program flow should be executed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-8905) Incorrect assertion in GridDhtPartitionsExchangeFuture
[ https://issues.apache.org/jira/browse/IGNITE-8905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16534812#comment-16534812 ] Dmitriy Pavlov commented on IGNITE-8905: [~sergey-chugunov] couple of suspicious failures here are - ZookeeperDiscoverySpiTestSuite1: ZookeeperDiscoverySpiTest.testRandomTopologyChanges_CloseClients (fail rate 0,0%) - ZookeeperDiscoverySpiTestSuite1: ZookeeperDiscoverySpiTest.testTopologyChangeMultithreaded_RestartZk_CloseClients (fail rate 0,0%) - IgniteCacheFailoverTestSuite: IgniteAtomicLongChangingTopologySelfTest.testClientQueueCreateCloseFailover (fail rate 0,0%) - IgniteCacheFailoverTestSuite: IgniteAtomicLongChangingTopologySelfTest.testClientSetCreateCloseFailover (fail rate 0,0%) I quite sure it is just 0.0 statisctic and tests are flaky, but could you please double check it anyway? > Incorrect assertion in GridDhtPartitionsExchangeFuture > -- > > Key: IGNITE-8905 > URL: https://issues.apache.org/jira/browse/IGNITE-8905 > Project: Ignite > Issue Type: Bug >Reporter: Sergey Chugunov >Assignee: Sergey Chugunov >Priority: Major > Fix For: 2.7 > > Original Estimate: 2h > Time Spent: 1h 1m > Remaining Estimate: 59m > > Assertion was added as part IGNITE-8657 into GridDhtPartitionsExchangeFuture > which is correct only in situation when client has to reconnect due to too > short EXCHANGE_HISTORY. > Exceptions from other situations like not being able to acquire file lock are > also passed to client node in FullMessage. > This assertion should be removed and check should be introduced instead: if > this exception is intended to be thrown on current client node, we should do > this, otherwise old program flow should be executed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-8905) Incorrect assertion in GridDhtPartitionsExchangeFuture
[ https://issues.apache.org/jira/browse/IGNITE-8905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16534810#comment-16534810 ] Dmitriy Pavlov commented on IGNITE-8905: [~Mmuzaf], as far as I know you've also researched activate-deactivate, so could I ask to do a favor and review this change? > Incorrect assertion in GridDhtPartitionsExchangeFuture > -- > > Key: IGNITE-8905 > URL: https://issues.apache.org/jira/browse/IGNITE-8905 > Project: Ignite > Issue Type: Bug >Reporter: Sergey Chugunov >Assignee: Sergey Chugunov >Priority: Major > Fix For: 2.7 > > Original Estimate: 2h > Time Spent: 1h 1m > Remaining Estimate: 59m > > Assertion was added as part IGNITE-8657 into GridDhtPartitionsExchangeFuture > which is correct only in situation when client has to reconnect due to too > short EXCHANGE_HISTORY. > Exceptions from other situations like not being able to acquire file lock are > also passed to client node in FullMessage. > This assertion should be removed and check should be introduced instead: if > this exception is intended to be thrown on current client node, we should do > this, otherwise old program flow should be executed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-8905) Incorrect assertion in GridDhtPartitionsExchangeFuture
[ https://issues.apache.org/jira/browse/IGNITE-8905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16534809#comment-16534809 ] Dmitriy Pavlov commented on IGNITE-8905: [~Mmuzaf], as far as I know you've also researched activate-deactivate, so could I ask to do a favor and review this change? > Incorrect assertion in GridDhtPartitionsExchangeFuture > -- > > Key: IGNITE-8905 > URL: https://issues.apache.org/jira/browse/IGNITE-8905 > Project: Ignite > Issue Type: Bug >Reporter: Sergey Chugunov >Assignee: Sergey Chugunov >Priority: Major > Fix For: 2.7 > > Original Estimate: 2h > Time Spent: 1h 1m > Remaining Estimate: 59m > > Assertion was added as part IGNITE-8657 into GridDhtPartitionsExchangeFuture > which is correct only in situation when client has to reconnect due to too > short EXCHANGE_HISTORY. > Exceptions from other situations like not being able to acquire file lock are > also passed to client node in FullMessage. > This assertion should be removed and check should be introduced instead: if > this exception is intended to be thrown on current client node, we should do > this, otherwise old program flow should be executed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-8905) Incorrect assertion in GridDhtPartitionsExchangeFuture
[ https://issues.apache.org/jira/browse/IGNITE-8905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16529709#comment-16529709 ] ASF GitHub Bot commented on IGNITE-8905: GitHub user sergey-chugunov-1985 opened a pull request: https://github.com/apache/ignite/pull/4288 IGNITE-8905 incorrect assertion was replaced with if-check You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-8905 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/4288.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4288 commit f2194169e9eda7232bc642bf3b1b5a1ad4967af0 Author: Sergey Chugunov Date: 2018-07-02T10:54:55Z IGNITE-8905 incorrect assertion was replaced with if-check > Incorrect assertion in GridDhtPartitionsExchangeFuture > -- > > Key: IGNITE-8905 > URL: https://issues.apache.org/jira/browse/IGNITE-8905 > Project: Ignite > Issue Type: Bug >Reporter: Sergey Chugunov >Assignee: Sergey Chugunov >Priority: Major > Fix For: 2.7 > > Original Estimate: 2h > Remaining Estimate: 2h > > Assertion was added as part IGNITE-8657 into GridDhtPartitionsExchangeFuture > which is correct only in situation when client has to reconnect due to too > short EXCHANGE_HISTORY. > Exceptions from other situations like not being able to acquire file lock are > also passed to client node in FullMessage. > This assertion should be removed and check should be introduced instead: if > this exception is intended to be thrown on current client node, we should do > this, otherwise old program flow should be executed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
