[jira] [Commented] (IGNITE-9054) ScanQuery responses are serialized with Optimized Marshaller
[ https://issues.apache.org/jira/browse/IGNITE-9054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16603189#comment-16603189 ] ASF GitHub Bot commented on IGNITE-9054: Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/4592 > ScanQuery responses are serialized with Optimized Marshaller > > > Key: IGNITE-9054 > URL: https://issues.apache.org/jira/browse/IGNITE-9054 > Project: Ignite > Issue Type: Bug > Components: cache >Affects Versions: 2.5 >Reporter: Ilya Kasnacheev >Assignee: Ilya Kasnacheev >Priority: Major > Labels: easyfix > Attachments: 22530.diff > > > When you do ContinuousQuery on a cache, its initial query sends results via > OptimizedMarshaller (which has binary compatibility implications) but its > continuous part uses BinaryMarshaller. They should both be using > BinaryMarshaller. Fix seems to be one-liner, see patch and userlist thread. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-9054) ScanQuery responses are serialized with Optimized Marshaller
[ https://issues.apache.org/jira/browse/IGNITE-9054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16603099#comment-16603099 ] ASF GitHub Bot commented on IGNITE-9054: GitHub user alamar reopened a pull request: https://github.com/apache/ignite/pull/4592 IGNITE-9054 Avoid using OptimizedMarshaller with initial ScanQuery. You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-gg-14092 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/4592.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4592 commit d5ae876319086dacb1f7ff7fde8aed113892f744 Author: Ilya Kasnacheev Date: 2018-08-22T15:17:51Z IGNITE-9054 Avoid using OptimizedMarshaller with initial ScanQuery. > ScanQuery responses are serialized with Optimized Marshaller > > > Key: IGNITE-9054 > URL: https://issues.apache.org/jira/browse/IGNITE-9054 > Project: Ignite > Issue Type: Bug > Components: cache >Affects Versions: 2.5 >Reporter: Ilya Kasnacheev >Assignee: Ilya Kasnacheev >Priority: Major > Labels: easyfix > Attachments: 22530.diff > > > When you do ContinuousQuery on a cache, its initial query sends results via > OptimizedMarshaller (which has binary compatibility implications) but its > continuous part uses BinaryMarshaller. They should both be using > BinaryMarshaller. Fix seems to be one-liner, see patch and userlist thread. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-9054) ScanQuery responses are serialized with Optimized Marshaller
[ https://issues.apache.org/jira/browse/IGNITE-9054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16603094#comment-16603094 ] ASF GitHub Bot commented on IGNITE-9054: Github user alamar closed the pull request at: https://github.com/apache/ignite/pull/4592 > ScanQuery responses are serialized with Optimized Marshaller > > > Key: IGNITE-9054 > URL: https://issues.apache.org/jira/browse/IGNITE-9054 > Project: Ignite > Issue Type: Bug > Components: cache >Affects Versions: 2.5 >Reporter: Ilya Kasnacheev >Assignee: Ilya Kasnacheev >Priority: Major > Labels: easyfix > Attachments: 22530.diff > > > When you do ContinuousQuery on a cache, its initial query sends results via > OptimizedMarshaller (which has binary compatibility implications) but its > continuous part uses BinaryMarshaller. They should both be using > BinaryMarshaller. Fix seems to be one-liner, see patch and userlist thread. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-9054) ScanQuery responses are serialized with Optimized Marshaller
[ https://issues.apache.org/jira/browse/IGNITE-9054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16590260#comment-16590260 ] Ilya Kasnacheev commented on IGNITE-9054: - [~agoncharuk] please review proposed fix! > ScanQuery responses are serialized with Optimized Marshaller > > > Key: IGNITE-9054 > URL: https://issues.apache.org/jira/browse/IGNITE-9054 > Project: Ignite > Issue Type: Bug > Components: cache >Affects Versions: 2.5 >Reporter: Ilya Kasnacheev >Assignee: Ilya Kasnacheev >Priority: Major > Labels: easyfix > Attachments: 22530.diff > > > When you do ContinuousQuery on a cache, its initial query sends results via > OptimizedMarshaller (which has binary compatibility implications) but its > continuous part uses BinaryMarshaller. They should both be using > BinaryMarshaller. Fix seems to be one-liner, see patch and userlist thread. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-9054) ScanQuery responses are serialized with Optimized Marshaller
[ https://issues.apache.org/jira/browse/IGNITE-9054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16590167#comment-16590167 ] Stanislav Lukyanov commented on IGNITE-9054: LGTM! > ScanQuery responses are serialized with Optimized Marshaller > > > Key: IGNITE-9054 > URL: https://issues.apache.org/jira/browse/IGNITE-9054 > Project: Ignite > Issue Type: Bug > Components: cache >Affects Versions: 2.5 >Reporter: Ilya Kasnacheev >Assignee: Ilya Kasnacheev >Priority: Major > Labels: easyfix > Attachments: 22530.diff > > > When you do ContinuousQuery on a cache, its initial query sends results via > OptimizedMarshaller (which has binary compatibility implications) but its > continuous part uses BinaryMarshaller. They should both be using > BinaryMarshaller. Fix seems to be one-liner, see patch and userlist thread. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-9054) ScanQuery responses are serialized with Optimized Marshaller
[ https://issues.apache.org/jira/browse/IGNITE-9054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16588987#comment-16588987 ] ASF GitHub Bot commented on IGNITE-9054: Github user alamar closed the pull request at: https://github.com/apache/ignite/pull/4529 > ScanQuery responses are serialized with Optimized Marshaller > > > Key: IGNITE-9054 > URL: https://issues.apache.org/jira/browse/IGNITE-9054 > Project: Ignite > Issue Type: Bug > Components: cache >Affects Versions: 2.5 >Reporter: Ilya Kasnacheev >Assignee: Ilya Kasnacheev >Priority: Major > Labels: easyfix > Attachments: 22530.diff > > > When you do ContinuousQuery on a cache, its initial query sends results via > OptimizedMarshaller (which has binary compatibility implications) but its > continuous part uses BinaryMarshaller. They should both be using > BinaryMarshaller. Fix seems to be one-liner, see patch and userlist thread. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-9054) ScanQuery responses are serialized with Optimized Marshaller
[ https://issues.apache.org/jira/browse/IGNITE-9054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16588977#comment-16588977 ] Ilya Kasnacheev commented on IGNITE-9054: - [~slukyanov] please review new PR > ScanQuery responses are serialized with Optimized Marshaller > > > Key: IGNITE-9054 > URL: https://issues.apache.org/jira/browse/IGNITE-9054 > Project: Ignite > Issue Type: Bug > Components: cache >Affects Versions: 2.5 >Reporter: Ilya Kasnacheev >Assignee: Ilya Kasnacheev >Priority: Major > Labels: easyfix > Attachments: 22530.diff > > > When you do ContinuousQuery on a cache, its initial query sends results via > OptimizedMarshaller (which has binary compatibility implications) but its > continuous part uses BinaryMarshaller. They should both be using > BinaryMarshaller. Fix seems to be one-liner, see patch and userlist thread. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-9054) ScanQuery responses are serialized with Optimized Marshaller
[ https://issues.apache.org/jira/browse/IGNITE-9054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16588958#comment-16588958 ] ASF GitHub Bot commented on IGNITE-9054: GitHub user alamar opened a pull request: https://github.com/apache/ignite/pull/4592 IGNITE-9054 Avoid using OptimizedMarshaller with initial ScanQuery. You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-gg-14092 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/4592.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4592 commit a9e41f07d78f9b64d827303763155bc77da23224 Author: Ilya Kasnacheev Date: 2018-08-22T14:47:52Z IGNITE-9054 Avoid using OptimizedMarshaller with initial ScanQuery. > ScanQuery responses are serialized with Optimized Marshaller > > > Key: IGNITE-9054 > URL: https://issues.apache.org/jira/browse/IGNITE-9054 > Project: Ignite > Issue Type: Bug > Components: cache >Affects Versions: 2.5 >Reporter: Ilya Kasnacheev >Assignee: Ilya Kasnacheev >Priority: Major > Labels: easyfix > Attachments: 22530.diff > > > When you do ContinuousQuery on a cache, its initial query sends results via > OptimizedMarshaller (which has binary compatibility implications) but its > continuous part uses BinaryMarshaller. They should both be using > BinaryMarshaller. Fix seems to be one-liner, see patch and userlist thread. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-9054) ScanQuery responses are serialized with Optimized Marshaller
[ https://issues.apache.org/jira/browse/IGNITE-9054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16580896#comment-16580896 ] Ilya Kasnacheev commented on IGNITE-9054: - [~slukyanov] please review proposed fix! > ScanQuery responses are serialized with Optimized Marshaller > > > Key: IGNITE-9054 > URL: https://issues.apache.org/jira/browse/IGNITE-9054 > Project: Ignite > Issue Type: Bug > Components: cache >Affects Versions: 2.5 >Reporter: Ilya Kasnacheev >Assignee: Ilya Kasnacheev >Priority: Major > Labels: easyfix > Attachments: 22530.diff > > > When you do ContinuousQuery on a cache, its initial query sends results via > OptimizedMarshaller (which has binary compatibility implications) but its > continuous part uses BinaryMarshaller. They should both be using > BinaryMarshaller. Fix seems to be one-liner, see patch and userlist thread. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-9054) ScanQuery responses are serialized with Optimized Marshaller
[ https://issues.apache.org/jira/browse/IGNITE-9054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16578378#comment-16578378 ] ASF GitHub Bot commented on IGNITE-9054: GitHub user alamar opened a pull request: https://github.com/apache/ignite/pull/4529 IGNITE-9054 Avoid using OptimizedMarshaller with ScanQuery initial. You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-9054 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/4529.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4529 commit 2c66454e753e97db94d626d1ca1adba875cdb1f3 Author: Ilya Kasnacheev Date: 2018-08-13T14:54:52Z IGNITE-9054 Avoid using OptimizedMarshaller with ScanQuery initial. > ScanQuery responses are serialized with Optimized Marshaller > > > Key: IGNITE-9054 > URL: https://issues.apache.org/jira/browse/IGNITE-9054 > Project: Ignite > Issue Type: Bug > Components: cache >Affects Versions: 2.5 >Reporter: Ilya Kasnacheev >Priority: Major > Labels: easyfix > Attachments: 22530.diff > > > When you do ContinuousQuery on a cache, its initial query sends results via > OptimizedMarshaller (which has binary compatibility implications) but its > continuous part uses BinaryMarshaller. They should both be using > BinaryMarshaller. Fix seems to be one-liner, see patch and userlist thread. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-9054) ScanQuery responses are serialized with Optimized Marshaller
[ https://issues.apache.org/jira/browse/IGNITE-9054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564686#comment-16564686 ] Calvin Wong commented on IGNITE-9054: - Hi, Can we include this in next release? Thanks, Calvin > ScanQuery responses are serialized with Optimized Marshaller > > > Key: IGNITE-9054 > URL: https://issues.apache.org/jira/browse/IGNITE-9054 > Project: Ignite > Issue Type: Bug > Components: cache >Affects Versions: 2.5 >Reporter: Ilya Kasnacheev >Priority: Major > Labels: easyfix > Attachments: 22530.diff > > > When you do ContinuousQuery on a cache, its initial query sends results via > OptimizedMarshaller (which has binary compatibility implications) but its > continuous part uses BinaryMarshaller. They should both be using > BinaryMarshaller. Fix seems to be one-liner, see patch and userlist thread. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-9054) ScanQuery responses are serialized with Optimized Marshaller
[
https://issues.apache.org/jira/browse/IGNITE-9054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16552854#comment-16552854
]
Stanislav Lukyanov commented on IGNITE-9054:
Test idea: create a custom POJO like
class Foo implements Serializable, Binarylizable {
writeObject() { throw new Exception(); }
readObject() { throw new Exception(); }
writeBinary() { /* actual marshalling */ }
readBinary() { /* actual marshalling */ }
}
and use it in the queries. Ignite should never use writeObject()/readObject()
if a class is Binarylizable, so if something is wrong we'll see the exceptions.
> ScanQuery responses are serialized with Optimized Marshaller
>
>
> Key: IGNITE-9054
> URL: https://issues.apache.org/jira/browse/IGNITE-9054
> Project: Ignite
> Issue Type: Bug
> Components: cache
>Affects Versions: 2.5
>Reporter: Ilya Kasnacheev
>Priority: Major
> Labels: easyfix
> Attachments: 22530.diff
>
>
> When you do ContinuousQuery on a cache, its initial query sends results via
> OptimizedMarshaller (which has binary compatibility implications) but its
> continuous part uses BinaryMarshaller. They should both be using
> BinaryMarshaller. Fix seems to be one-liner, see patch and userlist thread.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
