[jira] [Updated] (IGNITE-12444) SQL: Query reduce can fail with NPE on retry.
[ https://issues.apache.org/jira/browse/IGNITE-12444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey Mashenkov updated IGNITE-12444: -- Issue Type: Bug (was: Test) > SQL: Query reduce can fail with NPE on retry. > - > > Key: IGNITE-12444 > URL: https://issues.apache.org/jira/browse/IGNITE-12444 > Project: Ignite > Issue Type: Bug > Components: sql >Reporter: Andrey Mashenkov >Assignee: Andrey Mashenkov >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > GridReduceQueryExecutor can fail with NPE on retry if it couldn't map during > retry timeout. > So, 'lastRun' can be null here > {code:java} >if (attempt > 0 && retryTimeout > 0 && (U.currentTimeMillis() - startTime > > retryTimeout)) { > UUID retryNodeId = lastRun.retryNodeId(); > String retryCause = lastRun.retryCause(); > assert !F.isEmpty(retryCause); > {code} > Also assertion above is not correct. > It is possible, we failed to send request, then retried with success to remap. > So, 'lastRun' would be not null, but cause is empty. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (IGNITE-12444) SQL: Query reduce can fail with NPE on retry.
[ https://issues.apache.org/jira/browse/IGNITE-12444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey Mashenkov updated IGNITE-12444: -- Ignite Flags: (was: Docs Required,Release Notes Required) > SQL: Query reduce can fail with NPE on retry. > - > > Key: IGNITE-12444 > URL: https://issues.apache.org/jira/browse/IGNITE-12444 > Project: Ignite > Issue Type: Bug > Components: sql >Reporter: Andrey Mashenkov >Assignee: Andrey Mashenkov >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > GridReduceQueryExecutor can fail with NPE on retry if it couldn't map during > retry timeout. > So, 'lastRun' can be null here > {code:java} >if (attempt > 0 && retryTimeout > 0 && (U.currentTimeMillis() - startTime > > retryTimeout)) { > UUID retryNodeId = lastRun.retryNodeId(); > String retryCause = lastRun.retryCause(); > assert !F.isEmpty(retryCause); > {code} > Also assertion above is not correct. > It is possible, we failed to send request, then retried with success to remap. > So, 'lastRun' would be not null, but cause is empty. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (IGNITE-12444) SQL: Query reduce can fail with NPE on retry.
[ https://issues.apache.org/jira/browse/IGNITE-12444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Pavlukhin updated IGNITE-12444: Reviewer: Ivan Pavlukhin > SQL: Query reduce can fail with NPE on retry. > - > > Key: IGNITE-12444 > URL: https://issues.apache.org/jira/browse/IGNITE-12444 > Project: Ignite > Issue Type: Bug > Components: sql >Affects Versions: 2.7.6 >Reporter: Andrey Mashenkov >Assignee: Andrey Mashenkov >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > GridReduceQueryExecutor can fail with NPE on retry if it couldn't map during > retry timeout. > So, 'lastRun' can be null here > {code:java} >if (attempt > 0 && retryTimeout > 0 && (U.currentTimeMillis() - startTime > > retryTimeout)) { > UUID retryNodeId = lastRun.retryNodeId(); > String retryCause = lastRun.retryCause(); > assert !F.isEmpty(retryCause); > {code} > Also assertion above is not correct. > It is possible, we failed to send request, then retried with success to remap. > So, 'lastRun' would be not null, but cause is empty. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (IGNITE-12444) SQL: Query reduce can fail with NPE on retry.
[ https://issues.apache.org/jira/browse/IGNITE-12444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Taras Ledkov updated IGNITE-12444: -- Fix Version/s: (was: 2.8) 2.8.1 2.9 > SQL: Query reduce can fail with NPE on retry. > - > > Key: IGNITE-12444 > URL: https://issues.apache.org/jira/browse/IGNITE-12444 > Project: Ignite > Issue Type: Bug > Components: sql >Affects Versions: 2.7.6 >Reporter: Andrey Mashenkov >Assignee: Andrey Mashenkov >Priority: Major > Fix For: 2.9, 2.8.1 > > Time Spent: 20m > Remaining Estimate: 0h > > GridReduceQueryExecutor can fail with NPE on retry if it couldn't map during > retry timeout. > So, 'lastRun' can be null here > {code:java} >if (attempt > 0 && retryTimeout > 0 && (U.currentTimeMillis() - startTime > > retryTimeout)) { > UUID retryNodeId = lastRun.retryNodeId(); > String retryCause = lastRun.retryCause(); > assert !F.isEmpty(retryCause); > {code} > Also assertion above is not correct. > It is possible, we failed to send request, then retried with success to remap. > So, 'lastRun' would be not null, but cause is empty. -- This message was sent by Atlassian Jira (v8.3.4#803005)