[jira] [Updated] (IGNITE-15278) Node start/stop refactoring
[ https://issues.apache.org/jira/browse/IGNITE-15278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Lapin updated IGNITE-15278: - Description: [~ibessonov] suggested simplifying the node start logic by: * Transferring the startup components management logic from IgnititionImpl to IgniteImpl. * Separating the logic of constructing and starting components even more: it is suggested to instantiate all the components first, and then start all of them. During implementation it occurred that the ClusterService constructor assumes that nodeConfiguarion is already started. In order to satisfy the need of full-construct-then-start-logic org.apache.ignite.network.ClusterServiceFactory#createClusterService was updated: # Instead of port parameter within CluserLocalConfiguration ClusterServiceFactory#createClusterService accepts nodeConfiguration. # Instead of NodeFinder that also depends on nodeConfiguration ClusterServiceFactory#createClusterService accepts node finder supplier. was: [~ibessonov] suggested simplifying the node start logic by: * Transferring the startup components management logic from IgnititionImpl to IgniteImpl. * Separating the logic of constructing and starting components even more. It is suggested to instantiate all the components first, and then start all of them. During implementation it occurred that the ClusterService constructor assumes that nodeConfiguarion is already started. In order to satisfy the need of full-construct-then-start-logic org.apache.ignite.network.ClusterServiceFactory#createClusterService was updated: # Instead of port parameter within CluserLocalConfiguration ClusterServiceFactory#createClusterService accepts nodeConfiguration. # Instead of NodeFinder that also depends on nodeConfiguration ClusterServiceFactory#createClusterService accepts node finder supplier. > Node start/stop refactoring > --- > > Key: IGNITE-15278 > URL: https://issues.apache.org/jira/browse/IGNITE-15278 > Project: Ignite > Issue Type: Improvement >Reporter: Alexander Lapin >Assignee: Alexander Lapin >Priority: Major > Labels: ignite-3 > Time Spent: 0.5h > Remaining Estimate: 0h > > [~ibessonov] suggested simplifying the node start logic by: > * Transferring the startup components management logic from IgnititionImpl > to IgniteImpl. > * Separating the logic of constructing and starting components even more: it > is suggested to instantiate all the components first, and then start all of > them. > During implementation it occurred that the ClusterService constructor assumes > that nodeConfiguarion is already started. In order to satisfy the need of > full-construct-then-start-logic > org.apache.ignite.network.ClusterServiceFactory#createClusterService was > updated: > # Instead of port parameter within CluserLocalConfiguration > ClusterServiceFactory#createClusterService accepts nodeConfiguration. > # Instead of NodeFinder that also depends on nodeConfiguration > ClusterServiceFactory#createClusterService accepts node finder supplier. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (IGNITE-15278) Node start/stop refactoring
[ https://issues.apache.org/jira/browse/IGNITE-15278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Lapin updated IGNITE-15278: - Description: [~ibessonov] suggested simplifying the node start logic by: * Transferring the startup components management logic from IgnititionImpl to IgniteImpl. * Separating the logic of constructing and starting components even more: it is suggested to instantiate all the components first, and then start all of them. During the implementation it occurred that the ClusterService constructor assumes that nodeConfiguarion is already started. In order to satisfy the need of full-construct-then-start-logic org.apache.ignite.network.ClusterServiceFactory#createClusterService was updated: # Instead of port parameter within CluserLocalConfiguration ClusterServiceFactory#createClusterService accepts nodeConfiguration. # Instead of NodeFinder that also depends on nodeConfiguration ClusterServiceFactory#createClusterService accepts node finder supplier. was: [~ibessonov] suggested simplifying the node start logic by: * Transferring the startup components management logic from IgnititionImpl to IgniteImpl. * Separating the logic of constructing and starting components even more: it is suggested to instantiate all the components first, and then start all of them. During implementation it occurred that the ClusterService constructor assumes that nodeConfiguarion is already started. In order to satisfy the need of full-construct-then-start-logic org.apache.ignite.network.ClusterServiceFactory#createClusterService was updated: # Instead of port parameter within CluserLocalConfiguration ClusterServiceFactory#createClusterService accepts nodeConfiguration. # Instead of NodeFinder that also depends on nodeConfiguration ClusterServiceFactory#createClusterService accepts node finder supplier. > Node start/stop refactoring > --- > > Key: IGNITE-15278 > URL: https://issues.apache.org/jira/browse/IGNITE-15278 > Project: Ignite > Issue Type: Improvement >Reporter: Alexander Lapin >Assignee: Alexander Lapin >Priority: Major > Labels: ignite-3 > Time Spent: 0.5h > Remaining Estimate: 0h > > [~ibessonov] suggested simplifying the node start logic by: > * Transferring the startup components management logic from IgnititionImpl > to IgniteImpl. > * Separating the logic of constructing and starting components even more: it > is suggested to instantiate all the components first, and then start all of > them. > During the implementation it occurred that the ClusterService constructor > assumes that nodeConfiguarion is already started. In order to satisfy the > need of full-construct-then-start-logic > org.apache.ignite.network.ClusterServiceFactory#createClusterService was > updated: > # Instead of port parameter within CluserLocalConfiguration > ClusterServiceFactory#createClusterService accepts nodeConfiguration. > # Instead of NodeFinder that also depends on nodeConfiguration > ClusterServiceFactory#createClusterService accepts node finder supplier. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (IGNITE-15278) Node start/stop refactoring
[ https://issues.apache.org/jira/browse/IGNITE-15278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Lapin updated IGNITE-15278: - Description: [~ibessonov] suggested simplifying the node start logic by: * Transferring the startup components management logic from IgnititionImpl to IgniteImpl. * Separating the logic of constructing and starting components even more. It is suggested to instantiate all the components first, and then start all of them. During implementation it occurred that the ClusterService constructor assumes that nodeConfiguarion is already started. In order to satisfy the need of full-construct-then-start-logic org.apache.ignite.network.ClusterServiceFactory#createClusterService was updated: # Instead of port parameter within CluserLocalConfiguration ClusterServiceFactory#createClusterService accepts nodeConfiguration. # Instead of NodeFinder that also depends on nodeConfiguration ClusterServiceFactory#createClusterService accepts node finder supplier. > Node start/stop refactoring > --- > > Key: IGNITE-15278 > URL: https://issues.apache.org/jira/browse/IGNITE-15278 > Project: Ignite > Issue Type: Improvement >Reporter: Alexander Lapin >Assignee: Alexander Lapin >Priority: Major > Labels: ignite-3 > > [~ibessonov] suggested simplifying the node start logic by: > * Transferring the startup components management logic from IgnititionImpl > to IgniteImpl. > * Separating the logic of constructing and starting components even more. It > is suggested to instantiate all the components first, and then start all of > them. > During implementation it occurred that the ClusterService constructor assumes > that nodeConfiguarion is already started. In order to satisfy the need of > full-construct-then-start-logic > org.apache.ignite.network.ClusterServiceFactory#createClusterService was > updated: > # Instead of port parameter within CluserLocalConfiguration > ClusterServiceFactory#createClusterService accepts nodeConfiguration. > # Instead of NodeFinder that also depends on nodeConfiguration > ClusterServiceFactory#createClusterService accepts node finder supplier. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (IGNITE-15278) Node start/stop refactoring
[ https://issues.apache.org/jira/browse/IGNITE-15278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Lapin updated IGNITE-15278: - Summary: Node start/stop refactoring (was: Top level node start/stop refactoring) > Node start/stop refactoring > --- > > Key: IGNITE-15278 > URL: https://issues.apache.org/jira/browse/IGNITE-15278 > Project: Ignite > Issue Type: Improvement >Reporter: Alexander Lapin >Assignee: Alexander Lapin >Priority: Major > Labels: ignite-3 > -- This message was sent by Atlassian Jira (v8.3.4#803005)
