[jira] [Updated] (IGNITE-1971) Refactor various streamers implementations
[ https://issues.apache.org/jira/browse/IGNITE-1971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Ozerov updated IGNITE-1971: Fix Version/s: (was: 2.3) > Refactor various streamers implementations > -- > > Key: IGNITE-1971 > URL: https://issues.apache.org/jira/browse/IGNITE-1971 > Project: Ignite > Issue Type: Bug > Components: streaming >Affects Versions: 1.5.0.final >Reporter: Denis Magda > > Re-visit streamers implementations and should address at least the following > points below. > 1) {{start}} method in streamers implementations throws > {{IllegalArgumentException}}. > According to the contract of IllegalArgumentException this exception is > thrown only when an invalid argument is passed into the function. However no > argument is passed to the method at all and we shouldn't throw this exception > from this point of execution. > My suggestion is to use org.apache.ignite.IgniteIllegalStateException if we > don't find better alternative. See how it's used in Ignite.ignite() method > description. > 2) Streamers perform the same basics checks in their implementation of > {{start}} method. > It makes sense to add {{start}} method to StreamAdapter and perform there > basic checks that are the same for every streamer. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (IGNITE-1971) Refactor various streamers implementations
[ https://issues.apache.org/jira/browse/IGNITE-1971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Ozerov updated IGNITE-1971: Fix Version/s: (was: 2.1) 2.2 > Refactor various streamers implementations > -- > > Key: IGNITE-1971 > URL: https://issues.apache.org/jira/browse/IGNITE-1971 > Project: Ignite > Issue Type: Bug > Components: streaming >Affects Versions: 1.5.0.final >Reporter: Denis Magda > Fix For: 2.2 > > > Re-visit streamers implementations and should address at least the following > points below. > 1) {{start}} method in streamers implementations throws > {{IllegalArgumentException}}. > According to the contract of IllegalArgumentException this exception is > thrown only when an invalid argument is passed into the function. However no > argument is passed to the method at all and we shouldn't throw this exception > from this point of execution. > My suggestion is to use org.apache.ignite.IgniteIllegalStateException if we > don't find better alternative. See how it's used in Ignite.ignite() method > description. > 2) Streamers perform the same basics checks in their implementation of > {{start}} method. > It makes sense to add {{start}} method to StreamAdapter and perform there > basic checks that are the same for every streamer. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (IGNITE-1971) Refactor various streamers implementations
[ https://issues.apache.org/jira/browse/IGNITE-1971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Ozerov updated IGNITE-1971: Fix Version/s: (was: 2.0) 2.1 > Refactor various streamers implementations > -- > > Key: IGNITE-1971 > URL: https://issues.apache.org/jira/browse/IGNITE-1971 > Project: Ignite > Issue Type: Bug > Components: streaming >Affects Versions: 1.5.0.final >Reporter: Denis Magda > Fix For: 2.1 > > > Re-visit streamers implementations and should address at least the following > points below. > 1) {{start}} method in streamers implementations throws > {{IllegalArgumentException}}. > According to the contract of IllegalArgumentException this exception is > thrown only when an invalid argument is passed into the function. However no > argument is passed to the method at all and we shouldn't throw this exception > from this point of execution. > My suggestion is to use org.apache.ignite.IgniteIllegalStateException if we > don't find better alternative. See how it's used in Ignite.ignite() method > description. > 2) Streamers perform the same basics checks in their implementation of > {{start}} method. > It makes sense to add {{start}} method to StreamAdapter and perform there > basic checks that are the same for every streamer. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (IGNITE-1971) Refactor various streamers implementations
[ https://issues.apache.org/jira/browse/IGNITE-1971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Ozerov updated IGNITE-1971: Fix Version/s: (was: 1.8) 2.0 > Refactor various streamers implementations > -- > > Key: IGNITE-1971 > URL: https://issues.apache.org/jira/browse/IGNITE-1971 > Project: Ignite > Issue Type: Bug > Components: streaming >Affects Versions: 1.5.0.final >Reporter: Denis Magda > Fix For: 2.0 > > > Re-visit streamers implementations and should address at least the following > points below. > 1) {{start}} method in streamers implementations throws > {{IllegalArgumentException}}. > According to the contract of IllegalArgumentException this exception is > thrown only when an invalid argument is passed into the function. However no > argument is passed to the method at all and we shouldn't throw this exception > from this point of execution. > My suggestion is to use org.apache.ignite.IgniteIllegalStateException if we > don't find better alternative. See how it's used in Ignite.ignite() method > description. > 2) Streamers perform the same basics checks in their implementation of > {{start}} method. > It makes sense to add {{start}} method to StreamAdapter and perform there > basic checks that are the same for every streamer. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (IGNITE-1971) Refactor various streamers implementations
[ https://issues.apache.org/jira/browse/IGNITE-1971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pavel Tupitsyn updated IGNITE-1971: --- Fix Version/s: (was: 1.7) 1.8 > Refactor various streamers implementations > -- > > Key: IGNITE-1971 > URL: https://issues.apache.org/jira/browse/IGNITE-1971 > Project: Ignite > Issue Type: Bug > Components: streaming >Affects Versions: 1.5.0.final >Reporter: Denis Magda > Fix For: 1.8 > > > Re-visit streamers implementations and should address at least the following > points below. > 1) {{start}} method in streamers implementations throws > {{IllegalArgumentException}}. > According to the contract of IllegalArgumentException this exception is > thrown only when an invalid argument is passed into the function. However no > argument is passed to the method at all and we shouldn't throw this exception > from this point of execution. > My suggestion is to use org.apache.ignite.IgniteIllegalStateException if we > don't find better alternative. See how it's used in Ignite.ignite() method > description. > 2) Streamers perform the same basics checks in their implementation of > {{start}} method. > It makes sense to add {{start}} method to StreamAdapter and perform there > basic checks that are the same for every streamer. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (IGNITE-1971) Refactor various streamers implementations
[ https://issues.apache.org/jira/browse/IGNITE-1971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roman Shtykh updated IGNITE-1971: - Component/s: streaming > Refactor various streamers implementations > -- > > Key: IGNITE-1971 > URL: https://issues.apache.org/jira/browse/IGNITE-1971 > Project: Ignite > Issue Type: Bug > Components: streaming >Affects Versions: 1.5 >Reporter: Denis Magda > Fix For: 1.6 > > > Re-visit streamers implementations and should address at least the following > points below. > 1) {{start}} method in streamers implementations throws > {{IllegalArgumentException}}. > According to the contract of IllegalArgumentException this exception is > thrown only when an invalid argument is passed into the function. However no > argument is passed to the method at all and we shouldn't throw this exception > from this point of execution. > My suggestion is to use org.apache.ignite.IgniteIllegalStateException if we > don't find better alternative. See how it's used in Ignite.ignite() method > description. > 2) Streamers perform the same basics checks in their implementation of > {{start}} method. > It makes sense to add {{start}} method to StreamAdapter and perform there > basic checks that are the same for every streamer. -- This message was sent by Atlassian JIRA (v6.3.4#6332)