[jira] [Updated] (IGNITE-19724) Remove redundant joins
[ https://issues.apache.org/jira/browse/IGNITE-19724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vyacheslav Koptilin updated IGNITE-19724: - Ignite Flags: (was: Docs Required,Release Notes Required) > Remove redundant joins > -- > > Key: IGNITE-19724 > URL: https://issues.apache.org/jira/browse/IGNITE-19724 > Project: Ignite > Issue Type: Task >Reporter: Kirill Gusakov >Assignee: Kirill Gusakov >Priority: Major > Labels: ignite-3 > Time Spent: 10m > Remaining Estimate: 0h > > We have some redundant joins: > - > [this|https://github.com/apache/ignite-3/blob/7bcea31c9eb6350120584c1ca060131504927d04/modules/table/src/integrationTest/java/org/apache/ignite/distributed/ReplicaUnavailableTest.java#L199] > must be replaced by assertThat(replicaManager.stopReplica(testGrpId), > willSuccseesFast()); > - > [this|https://github.com/apache/ignite-3/blob/7bcea31c9eb6350120584c1ca060131504927d04/modules/replicator/src/main/java/org/apache/ignite/internal/replicator/ReplicaManager.java#L409] > can be replaced by chaining maybe, need to check > - Also need to review tests from > https://github.com/apache/ignite-3/commit/7bcea31c9eb6350120584c1ca060131504927d04 > for join -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (IGNITE-19724) Remove redundant joins
[ https://issues.apache.org/jira/browse/IGNITE-19724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirill Gusakov updated IGNITE-19724: Description: We have some redundant joins: - [this|https://github.com/apache/ignite-3/blob/7bcea31c9eb6350120584c1ca060131504927d04/modules/table/src/integrationTest/java/org/apache/ignite/distributed/ReplicaUnavailableTest.java#L199] must be replaced by assertThat(replicaManager.stopReplica(testGrpId), willSuccseesFast()); - [this|https://github.com/apache/ignite-3/blob/7bcea31c9eb6350120584c1ca060131504927d04/modules/replicator/src/main/java/org/apache/ignite/internal/replicator/ReplicaManager.java#L409] can be replaced by chaining maybe, need to check - Also need to review tests from https://github.com/apache/ignite-3/commit/7bcea31c9eb6350120584c1ca060131504927d04 for join was: We have some redundant joins: - [this|https://github.com/apache/ignite-3/blob/7bcea31c9eb6350120584c1ca060131504927d04/modules/table/src/integrationTest/java/org/apache/ignite/distributed/ReplicaUnavailableTest.java#L199] must be replaced by assertThat(replicaManager.stopReplica(testGrpId), willSuccseesFast()); - [this|https://github.com/apache/ignite-3/blob/7bcea31c9eb6350120584c1ca060131504927d04/modules/replicator/src/main/java/org/apache/ignite/internal/replicator/ReplicaManager.java#L409] can be replaced by chaining maybe, need to check - In the TableManager#cleanUpTablesResources replace the join with get+timeout - Also need to review tests from https://github.com/apache/ignite-3/commit/7bcea31c9eb6350120584c1ca060131504927d04 for join > Remove redundant joins > -- > > Key: IGNITE-19724 > URL: https://issues.apache.org/jira/browse/IGNITE-19724 > Project: Ignite > Issue Type: Task >Reporter: Kirill Gusakov >Assignee: Kirill Gusakov >Priority: Major > Labels: ignite-3 > Time Spent: 10m > Remaining Estimate: 0h > > We have some redundant joins: > - > [this|https://github.com/apache/ignite-3/blob/7bcea31c9eb6350120584c1ca060131504927d04/modules/table/src/integrationTest/java/org/apache/ignite/distributed/ReplicaUnavailableTest.java#L199] > must be replaced by assertThat(replicaManager.stopReplica(testGrpId), > willSuccseesFast()); > - > [this|https://github.com/apache/ignite-3/blob/7bcea31c9eb6350120584c1ca060131504927d04/modules/replicator/src/main/java/org/apache/ignite/internal/replicator/ReplicaManager.java#L409] > can be replaced by chaining maybe, need to check > - Also need to review tests from > https://github.com/apache/ignite-3/commit/7bcea31c9eb6350120584c1ca060131504927d04 > for join -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (IGNITE-19724) Remove redundant joins
[ https://issues.apache.org/jira/browse/IGNITE-19724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vyacheslav Koptilin updated IGNITE-19724: - Labels: ignite-3 (was: ) > Remove redundant joins > -- > > Key: IGNITE-19724 > URL: https://issues.apache.org/jira/browse/IGNITE-19724 > Project: Ignite > Issue Type: Task >Reporter: Kirill Gusakov >Assignee: Kirill Gusakov >Priority: Major > Labels: ignite-3 > > We have some redundant joins: > - > [this|https://github.com/apache/ignite-3/blob/7bcea31c9eb6350120584c1ca060131504927d04/modules/table/src/integrationTest/java/org/apache/ignite/distributed/ReplicaUnavailableTest.java#L199] > must be replaced by assertThat(replicaManager.stopReplica(testGrpId), > willSuccseesFast()); > - > [this|https://github.com/apache/ignite-3/blob/7bcea31c9eb6350120584c1ca060131504927d04/modules/replicator/src/main/java/org/apache/ignite/internal/replicator/ReplicaManager.java#L409] > can be replaced by chaining maybe, need to check > - In the TableManager#cleanUpTablesResources replace the join with get+timeout > - Also need to review tests from > https://github.com/apache/ignite-3/commit/7bcea31c9eb6350120584c1ca060131504927d04 > for join -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (IGNITE-19724) Remove redundant joins
[ https://issues.apache.org/jira/browse/IGNITE-19724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirill Gusakov updated IGNITE-19724: Description: We have some redundant joins: - [this|https://github.com/apache/ignite-3/blob/7bcea31c9eb6350120584c1ca060131504927d04/modules/table/src/integrationTest/java/org/apache/ignite/distributed/ReplicaUnavailableTest.java#L199] must be replaced by assertThat(replicaManager.stopReplica(testGrpId), willSuccseesFast()); - [this|https://github.com/apache/ignite-3/blob/7bcea31c9eb6350120584c1ca060131504927d04/modules/replicator/src/main/java/org/apache/ignite/internal/replicator/ReplicaManager.java#L409] can be replaced by chaining maybe, need to check - In the TableManager#cleanUpTablesResources replace the join with get+timeout - Also need to review tests from https://github.com/apache/ignite-3/commit/7bcea31c9eb6350120584c1ca060131504927d04 for join was: We have some redundant joins: - [this|https://github.com/apache/ignite-3/blob/7bcea31c9eb6350120584c1ca060131504927d04/modules/table/src/integrationTest/java/org/apache/ignite/distributed/ReplicaUnavailableTest.java#L199] must be replaced by assertThat(replicaManager.stopReplica(testGrpId), willSuccseesFast()); - [this|https://github.com/apache/ignite-3/blob/7bcea31c9eb6350120584c1ca060131504927d04/modules/replicator/src/main/java/org/apache/ignite/internal/replicator/ReplicaManager.java#L409] can be replaced by chaining maybe, need to check - Also need to review tests from https://github.com/apache/ignite-3/commit/7bcea31c9eb6350120584c1ca060131504927d04 for join > Remove redundant joins > -- > > Key: IGNITE-19724 > URL: https://issues.apache.org/jira/browse/IGNITE-19724 > Project: Ignite > Issue Type: Task >Reporter: Kirill Gusakov >Assignee: Kirill Gusakov >Priority: Major > > We have some redundant joins: > - > [this|https://github.com/apache/ignite-3/blob/7bcea31c9eb6350120584c1ca060131504927d04/modules/table/src/integrationTest/java/org/apache/ignite/distributed/ReplicaUnavailableTest.java#L199] > must be replaced by assertThat(replicaManager.stopReplica(testGrpId), > willSuccseesFast()); > - > [this|https://github.com/apache/ignite-3/blob/7bcea31c9eb6350120584c1ca060131504927d04/modules/replicator/src/main/java/org/apache/ignite/internal/replicator/ReplicaManager.java#L409] > can be replaced by chaining maybe, need to check > - In the TableManager#cleanUpTablesResources replace the join with get+timeout > - Also need to review tests from > https://github.com/apache/ignite-3/commit/7bcea31c9eb6350120584c1ca060131504927d04 > for join -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (IGNITE-19724) Remove redundant joins
[ https://issues.apache.org/jira/browse/IGNITE-19724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirill Gusakov updated IGNITE-19724: Description: We have some redundant joins: - [this|https://github.com/apache/ignite-3/blob/7bcea31c9eb6350120584c1ca060131504927d04/modules/table/src/integrationTest/java/org/apache/ignite/distributed/ReplicaUnavailableTest.java#L199] must be replaced by assertThat(replicaManager.stopReplica(testGrpId), willSuccseesFast()); - [this|https://github.com/apache/ignite-3/blob/7bcea31c9eb6350120584c1ca060131504927d04/modules/replicator/src/main/java/org/apache/ignite/internal/replicator/ReplicaManager.java#L409] can be replaced by chaining maybe, need to check - Also need to review tests from https://github.com/apache/ignite-3/commit/7bcea31c9eb6350120584c1ca060131504927d04 for join was: We have some redundant joins: - [this|https://github.com/apache/ignite-3/blob/7bcea31c9eb6350120584c1ca060131504927d04/modules/table/src/integrationTest/java/org/apache/ignite/distributed/ReplicaUnavailableTest.java#L199] must be replaced by assertThat(replicaManager.stopReplica(testGrpId), willSuccseesFast()); - [this|https://github.com/apache/ignite-3/blob/7bcea31c9eb6350120584c1ca060131504927d04/modules/replicator/src/main/java/org/apache/ignite/internal/replicator/ReplicaManager.java#L409] can be replaced by chaining maybe, need to check > Remove redundant joins > -- > > Key: IGNITE-19724 > URL: https://issues.apache.org/jira/browse/IGNITE-19724 > Project: Ignite > Issue Type: Task >Reporter: Kirill Gusakov >Assignee: Kirill Gusakov >Priority: Major > > We have some redundant joins: > - > [this|https://github.com/apache/ignite-3/blob/7bcea31c9eb6350120584c1ca060131504927d04/modules/table/src/integrationTest/java/org/apache/ignite/distributed/ReplicaUnavailableTest.java#L199] > must be replaced by assertThat(replicaManager.stopReplica(testGrpId), > willSuccseesFast()); > - > [this|https://github.com/apache/ignite-3/blob/7bcea31c9eb6350120584c1ca060131504927d04/modules/replicator/src/main/java/org/apache/ignite/internal/replicator/ReplicaManager.java#L409] > can be replaced by chaining maybe, need to check > - Also need to review tests from > https://github.com/apache/ignite-3/commit/7bcea31c9eb6350120584c1ca060131504927d04 > for join -- This message was sent by Atlassian Jira (v8.20.10#820010)
