[jira] [Commented] (KARAF-5298) config:update doesn't create the cfg file in the etc folder

2017-08-09 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/KARAF-5298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16121090#comment-16121090
 ] 

ASF subversion and git services commented on KARAF-5298:


Commit ae930b3922d5db7b383ffc217386c93716bfa9e8 in karaf's branch 
refs/heads/master from [~jbonofre]
[ https://git-wip-us.apache.org/repos/asf?p=karaf.git;h=ae930b3 ]

[KARAF-5298] Update storage when creating config


> config:update doesn't create the cfg file in the etc folder
> ---
>
> Key: KARAF-5298
> URL: https://issues.apache.org/jira/browse/KARAF-5298
> Project: Karaf
>  Issue Type: Bug
>  Components: karaf-config
>Affects Versions: 4.2.0
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
> Fix For: 4.2.0
>
>
> In previous Karaf versions, {{config:update}} command creates the {{cfg}} 
> file in the {{etc}} folder (if needed). For instance, it's possible to do:
> {code}
> karaf@root()> config:edit net.test
> karaf@root()> config:property-set foo bar
> karaf@root()> config:update
> {code}
> and then, {{etc/net.test.cfg}} is created.
> However, in Karaf 4.2.x, the configuration is created in memory, but the 
> {{cfg}} file is not created.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (KARAF-5298) config:update doesn't create the cfg file in the etc folder

2017-08-09 Thread JIRA

[ 
https://issues.apache.org/jira/browse/KARAF-5298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16121064#comment-16121064
 ] 

Jean-Baptiste Onofré commented on KARAF-5298:
-

Problem has been introduced by the following commit in {{ConfigRepositoryImpl}}:

{code}
commit 3cd6866bf9eb8d19b186441390d1e6d8719e652a
Author: Guillaume Nodet 
Date:   Wed Apr 5 17:53:15 2017 +0200

[KARAF-5074] Upgrade to Felix Utils 1.10, FileInstall 3.6 and use the new 
TypedProperties
{code}

I'm fixing/reverting the code in {{ConfigRepositoryImpl}} to actually call 
{{updateStorage}} method.

> config:update doesn't create the cfg file in the etc folder
> ---
>
> Key: KARAF-5298
> URL: https://issues.apache.org/jira/browse/KARAF-5298
> Project: Karaf
>  Issue Type: Bug
>  Components: karaf-config
>Affects Versions: 4.2.0
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
> Fix For: 4.2.0
>
>
> In previous Karaf versions, {{config:update}} command creates the {{cfg}} 
> file in the {{etc}} folder (if needed). For instance, it's possible to do:
> {code}
> karaf@root()> config:edit net.test
> karaf@root()> config:property-set foo bar
> karaf@root()> config:update
> {code}
> and then, {{etc/net.test.cfg}} is created.
> However, in Karaf 4.2.x, the configuration is created in memory, but the 
> {{cfg}} file is not created.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (KARAF-4756) Redeploying Features in the Deploy directory with install="auto" does not work for same feature versions

2017-08-09 Thread JIRA

 [ 
https://issues.apache.org/jira/browse/KARAF-4756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jean-Baptiste Onofré updated KARAF-4756:

Fix Version/s: 4.1.3
   4.2.0

> Redeploying Features in the Deploy directory with install="auto" does not 
> work for same feature versions
> 
>
> Key: KARAF-4756
> URL: https://issues.apache.org/jira/browse/KARAF-4756
> Project: Karaf
>  Issue Type: Bug
>  Components: karaf-feature
>Affects Versions: 4.0.6, 4.0.7, 4.0.9, 4.1.2
>Reporter: Cetra Free
>Assignee: Jean-Baptiste Onofré
> Fix For: 4.2.0, 4.1.3
>
>
> If you add a {{-features.xml}} file to the deploy directory, and then make 
> any changes to the file, except the name or version, then the feature will 
> stay uninstalled.
> You can manually install the feature with feature:install, but this defeats 
> the purpose of having install="auto"
> Here's a simple feature:
> {code}
> 
> http://karaf.apache.org/xmlns/features/v1.3.0; 
> name="example" >
>   
> mvn:org.apache.camel.karaf/apache-camel/2.17.0/xml/features
>   
> camel-blueprint
>   
> 
> {code}
> Steps to Reproduce:
> * Plop that example in the deploy directory
> * Notice that the feature is loaded:
> {code}
> feature:list | grep example-feature
> example-feature | 1.0.0| x| 
> Started | example |
> {code}
> * Change and update the file, leaving version and name the same
> * Notice that the feature stays uninstalled:
> {code}
> karaf@root()> feature:list | grep example-feature
> example-feature | 1.0.0|  | 
> Uninstalled | example |
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (KARAF-4756) Redeploying Features in the Deploy directory with install="auto" does not work for same feature versions

2017-08-09 Thread JIRA

 [ 
https://issues.apache.org/jira/browse/KARAF-4756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jean-Baptiste Onofré reassigned KARAF-4756:
---

Assignee: Jean-Baptiste Onofré

> Redeploying Features in the Deploy directory with install="auto" does not 
> work for same feature versions
> 
>
> Key: KARAF-4756
> URL: https://issues.apache.org/jira/browse/KARAF-4756
> Project: Karaf
>  Issue Type: Bug
>  Components: karaf-feature
>Affects Versions: 4.0.6, 4.0.7, 4.0.9, 4.1.2
>Reporter: Cetra Free
>Assignee: Jean-Baptiste Onofré
>
> If you add a {{-features.xml}} file to the deploy directory, and then make 
> any changes to the file, except the name or version, then the feature will 
> stay uninstalled.
> You can manually install the feature with feature:install, but this defeats 
> the purpose of having install="auto"
> Here's a simple feature:
> {code}
> 
> http://karaf.apache.org/xmlns/features/v1.3.0; 
> name="example" >
>   
> mvn:org.apache.camel.karaf/apache-camel/2.17.0/xml/features
>   
> camel-blueprint
>   
> 
> {code}
> Steps to Reproduce:
> * Plop that example in the deploy directory
> * Notice that the feature is loaded:
> {code}
> feature:list | grep example-feature
> example-feature | 1.0.0| x| 
> Started | example |
> {code}
> * Change and update the file, leaving version and name the same
> * Notice that the feature stays uninstalled:
> {code}
> karaf@root()> feature:list | grep example-feature
> example-feature | 1.0.0|  | 
> Uninstalled | example |
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (KARAF-5103) Quick start fails at the step "feature:install camel-spring"

2017-08-09 Thread Bob Hong (JIRA)

[ 
https://issues.apache.org/jira/browse/KARAF-5103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16121024#comment-16121024
 ] 

Bob Hong commented on KARAF-5103:
-

I don't believe this is fixed.  The Quick Start URL 
http://karaf.apache.org/manual/latest/#_deploy_a_sample_application still 
references 2.15.2.

I am able to add the repo using 2.18.4 as suggested in the prior comment and 
install the camel-spring feature, but get errors installing the bundle using 
2.18.4 or 2.15.2: 

karaf@root()> feature:repo-add camel 2.18.4
Adding feature url mvn:org.apache.camel.karaf/apache-camel/2.18.4/xml/features
karaf@root()> feature:install camel-spring
karaf@root()> bundle:install -s mvn:org.apache.camel/camel-example-osgi/2.18.4
Bundle IDs: 
Error executing command: Error installing bundles:
Unable to install bundle 
mvn:org.apache.camel/camel-example-osgi/2.18.4: 
org.osgi.framework.BundleException: Unable to cache bundle: 
mvn:org.apache.camel/camel-example-osgi/2.18.4
karaf@root()> bundle:install -s mvn:org.apache.camel/camel-example-osgi/2.15.2  
 
Bundle ID: 69
Error executing command: Error installing bundles:
Unable to start bundle mvn:org.apache.camel/camel-example-osgi/2.15.2: 
org.osgi.framework.BundleException: Unable to resolve camel-example-osgi [69](R 
69.0): missing requirement [camel-example-osgi [69](R 69.0)] 
osgi.wiring.package; 
(&(osgi.wiring.package=org.apache.camel.builder)(version>=2.15.0)(!(version>=2.16.0)))
 Unresolved requirements: [[camel-example-osgi [69](R 69.0)] 
osgi.wiring.package; 
(&(osgi.wiring.package=org.apache.camel.builder)(version>=2.15.0)(!(version>=2.16.0)))]


> Quick start fails at the step "feature:install camel-spring"
> 
>
> Key: KARAF-5103
> URL: https://issues.apache.org/jira/browse/KARAF-5103
> Project: Karaf
>  Issue Type: Bug
>Affects Versions: 4.1.1
> Environment: Ubuntu 14.04
>Reporter: Mike Fogg
>Assignee: Christian Schneider
> Fix For: 4.2.0, 4.1.2
>
>
> The quick start results in an error when entering the command to install 
> camel-spring.
> karaf@root()> feature:install camel-spring
> Error executing command: Unable to resolve root: missing requirement [root] 
> osgi.identity; osgi.identity=camel-spring; type=karaf.feature; 
> version="[2.15.2,2.15.2]"; 
> filter:="(&(osgi.identity=camel-spring)(type=karaf.feature)(version>=2.15.2)(version<=2.15.2))"
>  [caused by: Unable to resolve camel-spring/2.15.2: missing requirement 
> [camel-spring/2.15.2] osgi.identity; osgi.identity=spring; 
> type=karaf.feature; version="[3.2.0,4.0.0)"]
> It sounds like this is related to KARAF-4730, however since this is the first 
> thing I have tried after installing and is my introduction to Karaf (as it 
> would be presumably for anyone going through the Quick Start), I don't know 
> how I would go about removing the filter from the camel-spring dependency in 
> order to install it.  Considering this is a quick start, I probably shouldn't 
> have to do anything that isn't spelled out in the instructions.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (KARAF-4756) Redeploying Features in the Deploy directory with install="auto" does not work for same feature versions

2017-08-09 Thread Cetra Free (JIRA)

[ 
https://issues.apache.org/jira/browse/KARAF-4756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16120895#comment-16120895
 ] 

Cetra Free commented on KARAF-4756:
---

Confirmed this is still an issue in {{4.1.2}}

> Redeploying Features in the Deploy directory with install="auto" does not 
> work for same feature versions
> 
>
> Key: KARAF-4756
> URL: https://issues.apache.org/jira/browse/KARAF-4756
> Project: Karaf
>  Issue Type: Bug
>  Components: karaf-feature
>Affects Versions: 4.0.6, 4.0.7, 4.0.9, 4.1.2
>Reporter: Cetra Free
>
> If you add a {{-features.xml}} file to the deploy directory, and then make 
> any changes to the file, except the name or version, then the feature will 
> stay uninstalled.
> You can manually install the feature with feature:install, but this defeats 
> the purpose of having install="auto"
> Here's a simple feature:
> {code}
> 
> http://karaf.apache.org/xmlns/features/v1.3.0; 
> name="example" >
>   
> mvn:org.apache.camel.karaf/apache-camel/2.17.0/xml/features
>   
> camel-blueprint
>   
> 
> {code}
> Steps to Reproduce:
> * Plop that example in the deploy directory
> * Notice that the feature is loaded:
> {code}
> feature:list | grep example-feature
> example-feature | 1.0.0| x| 
> Started | example |
> {code}
> * Change and update the file, leaving version and name the same
> * Notice that the feature stays uninstalled:
> {code}
> karaf@root()> feature:list | grep example-feature
> example-feature | 1.0.0|  | 
> Uninstalled | example |
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (KARAF-4756) Redeploying Features in the Deploy directory with install="auto" does not work for same feature versions

2017-08-09 Thread Cetra Free (JIRA)

 [ 
https://issues.apache.org/jira/browse/KARAF-4756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Cetra Free updated KARAF-4756:
--
Affects Version/s: 4.0.9
   4.1.2

> Redeploying Features in the Deploy directory with install="auto" does not 
> work for same feature versions
> 
>
> Key: KARAF-4756
> URL: https://issues.apache.org/jira/browse/KARAF-4756
> Project: Karaf
>  Issue Type: Bug
>  Components: karaf-feature
>Affects Versions: 4.0.6, 4.0.7, 4.0.9, 4.1.2
>Reporter: Cetra Free
>
> If you add a {{-features.xml}} file to the deploy directory, and then make 
> any changes to the file, except the name or version, then the feature will 
> stay uninstalled.
> You can manually install the feature with feature:install, but this defeats 
> the purpose of having install="auto"
> Here's a simple feature:
> {code}
> 
> http://karaf.apache.org/xmlns/features/v1.3.0; 
> name="example" >
>   
> mvn:org.apache.camel.karaf/apache-camel/2.17.0/xml/features
>   
> camel-blueprint
>   
> 
> {code}
> Steps to Reproduce:
> * Plop that example in the deploy directory
> * Notice that the feature is loaded:
> {code}
> feature:list | grep example-feature
> example-feature | 1.0.0| x| 
> Started | example |
> {code}
> * Change and update the file, leaving version and name the same
> * Notice that the feature stays uninstalled:
> {code}
> karaf@root()> feature:list | grep example-feature
> example-feature | 1.0.0|  | 
> Uninstalled | example |
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (KARAF-5300) FeaturesService should use more specific classes for model

2017-08-09 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/KARAF-5300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16120093#comment-16120093
 ] 

ASF subversion and git services commented on KARAF-5300:


Commit 54dac91a87e1f1f076bddc9556146d3bd42f0d5f in karaf's branch 
refs/heads/model_features from [~ch...@die-schneider.net]
[ https://git-wip-us.apache.org/repos/asf?p=karaf.git;h=54dac91 ]

[KARAF-5300] Use FeatureReq instead of string for FeaturesService


> FeaturesService should use more specific classes for model
> --
>
> Key: KARAF-5300
> URL: https://issues.apache.org/jira/browse/KARAF-5300
> Project: Karaf
>  Issue Type: Bug
>  Components: karaf-feature
>Reporter: Christian Schneider
>Assignee: Christian Schneider
>
> Currently the feature service uses strings for many different purposes:
> - feature name
> - feature name glob
> - feature version
> - feature version range
> It is difficult to tell what purpose such a string has.
> I would like to create a type FeatureReq(name, VersionRange) that describes 
> better what we do. This should make the code a lot easier to understand.
> Ideally we would also reflect this in the service interface but the stay 
> backwards compatbile I will only use the new types internally.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (KARAF-5300) FeaturesService should use more specific classes for model

2017-08-09 Thread Christian Schneider (JIRA)
Christian Schneider created KARAF-5300:
--

 Summary: FeaturesService should use more specific classes for model
 Key: KARAF-5300
 URL: https://issues.apache.org/jira/browse/KARAF-5300
 Project: Karaf
  Issue Type: Bug
  Components: karaf-feature
Reporter: Christian Schneider
Assignee: Christian Schneider


Currently the feature service uses strings for many different purposes:
- feature name
- feature name glob
- feature version
- feature version range

It is difficult to tell what purpose such a string has.

I would like to create a type FeatureReq(name, VersionRange) that describes 
better what we do. This should make the code a lot easier to understand.

Ideally we would also reflect this in the service interface but the stay 
backwards compatbile I will only use the new types internally.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (KARAF-5299) fragment bundle not bound to its host when using the command bundle:install

2017-08-09 Thread Nicolas Brasey (JIRA)
Nicolas Brasey created KARAF-5299:
-

 Summary: fragment bundle not bound to its host when using the 
command bundle:install
 Key: KARAF-5299
 URL: https://issues.apache.org/jira/browse/KARAF-5299
 Project: Karaf
  Issue Type: Bug
Affects Versions: 4.1.2
Reporter: Nicolas Brasey
 Fix For: 4.1.3


When installing a fragment bundle with the command bundle:install, the fragment 
does not get bound to its host. The fragment is bound correctly after a restart 
of karaf.

Workaround:
Install the fragment bundle with the deploy directory.





--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (KARAF-5298) config:update doesn't create the cfg file in the etc folder

2017-08-09 Thread JIRA
Jean-Baptiste Onofré created KARAF-5298:
---

 Summary: config:update doesn't create the cfg file in the etc 
folder
 Key: KARAF-5298
 URL: https://issues.apache.org/jira/browse/KARAF-5298
 Project: Karaf
  Issue Type: Bug
  Components: karaf-config
Affects Versions: 4.2.0
Reporter: Jean-Baptiste Onofré
Assignee: Jean-Baptiste Onofré
 Fix For: 4.2.0


In previous Karaf versions, {{config:update}} command creates the {{cfg}} file 
in the {{etc}} folder (if needed). For instance, it's possible to do:

{code}
karaf@root()> config:edit net.test
karaf@root()> config:property-set foo bar
karaf@root()> config:update
{code}

and then, {{etc/net.test.cfg}} is created.

However, in Karaf 4.2.x, the configuration is created in memory, but the 
{{cfg}} file is not created.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (KARAF-4367) "Module has been uninstalled" during installing the feature

2017-08-09 Thread Christian Schneider (JIRA)

[ 
https://issues.apache.org/jira/browse/KARAF-4367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16119547#comment-16119547
 ] 

Christian Schneider commented on KARAF-4367:


I think a I found a possible cause for this. In 
org.apache.karaf.features.internal.service.FeaturesServiceImpl.installFeatures 
we first copy the current state and then do the provisioning in a 
SingleThreadExecutor. So while the provisioning is protected to be entered by 
one thread at a time this is not the case while we copy the state and do the 
computation of what to change.


> "Module has been uninstalled" during installing the feature
> ---
>
> Key: KARAF-4367
> URL: https://issues.apache.org/jira/browse/KARAF-4367
> Project: Karaf
>  Issue Type: Bug
>  Components: karaf-core, karaf-feature
>Affects Versions: 4.0.4
>Reporter: Pavlo Vasylchenko
>Assignee: Christian Schneider
> Attachments: jconsole2.png
>
>
> Separately feature works fine, but if I try to install it just after 
> uninstalling another feature, I get exception.
> Looks like karaf trying refresh something in this time.
> my code:
> featuresService.installFeature(feature, 
> EnumSet.of(Option.NoAutoRefreshBundles));
> ...
> Caused by: java.lang.IllegalStateException: Module has been uninstalled.
>   at 
> org.eclipse.osgi.container.Module.checkValid(Module.java:526)[org.eclipse.osgi-3.10.2.v20150203-1939.jar:]
>   at 
> org.eclipse.osgi.container.Module.getStartLevel(Module.java:243)[org.eclipse.osgi-3.10.2.v20150203-1939.jar:]
>   at 
> org.apache.karaf.features.internal.service.Deployer.deploy(Deployer.java:480)[9:org.apache.karaf.features.core:4.0.4]
>   at 
> org.apache.karaf.features.internal.service.FeaturesServiceImpl.doProvision(FeaturesServiceImpl.java:1089)[9:org.apache.karaf.features.core:4.0.4]
>   at 
> org.apache.karaf.features.internal.service.FeaturesServiceImpl$1.call(FeaturesServiceImpl.java:985)[9:org.apache.karaf.features.core:4.0.4]
>   at java.util.concurrent.FutureTask.run(FutureTask.java:266)[:1.8.0_60]
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)[:1.8.0_60]
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)[:1.8.0_60]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (KARAF-4367) "Module has been uninstalled" during installing the feature

2017-08-09 Thread Christian Schneider (JIRA)

 [ 
https://issues.apache.org/jira/browse/KARAF-4367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider reassigned KARAF-4367:
--

Assignee: Christian Schneider

> "Module has been uninstalled" during installing the feature
> ---
>
> Key: KARAF-4367
> URL: https://issues.apache.org/jira/browse/KARAF-4367
> Project: Karaf
>  Issue Type: Bug
>  Components: karaf-core, karaf-feature
>Affects Versions: 4.0.4
>Reporter: Pavlo Vasylchenko
>Assignee: Christian Schneider
> Attachments: jconsole2.png
>
>
> Separately feature works fine, but if I try to install it just after 
> uninstalling another feature, I get exception.
> Looks like karaf trying refresh something in this time.
> my code:
> featuresService.installFeature(feature, 
> EnumSet.of(Option.NoAutoRefreshBundles));
> ...
> Caused by: java.lang.IllegalStateException: Module has been uninstalled.
>   at 
> org.eclipse.osgi.container.Module.checkValid(Module.java:526)[org.eclipse.osgi-3.10.2.v20150203-1939.jar:]
>   at 
> org.eclipse.osgi.container.Module.getStartLevel(Module.java:243)[org.eclipse.osgi-3.10.2.v20150203-1939.jar:]
>   at 
> org.apache.karaf.features.internal.service.Deployer.deploy(Deployer.java:480)[9:org.apache.karaf.features.core:4.0.4]
>   at 
> org.apache.karaf.features.internal.service.FeaturesServiceImpl.doProvision(FeaturesServiceImpl.java:1089)[9:org.apache.karaf.features.core:4.0.4]
>   at 
> org.apache.karaf.features.internal.service.FeaturesServiceImpl$1.call(FeaturesServiceImpl.java:985)[9:org.apache.karaf.features.core:4.0.4]
>   at java.util.concurrent.FutureTask.run(FutureTask.java:266)[:1.8.0_60]
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)[:1.8.0_60]
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)[:1.8.0_60]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)