[jira] [Commented] (KARAF-5395) ResourceImpl/RequirementImpl/CapabilityImpl do not correctly implement their OSGi interface contracts
[ https://issues.apache.org/jira/browse/KARAF-5395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16193378#comment-16193378 ] ASF subversion and git services commented on KARAF-5395: Commit e5bd746b34300ff10ba4a0ead6e6c08efd357982 in karaf's branch refs/heads/master from [~gnt] [ https://git-wip-us.apache.org/repos/asf?p=karaf.git;h=e5bd746 ] [KARAF-5395] Further improve memory consumption for capabilities / requirements > ResourceImpl/RequirementImpl/CapabilityImpl do not correctly implement their > OSGi interface contracts > - > > Key: KARAF-5395 > URL: https://issues.apache.org/jira/browse/KARAF-5395 > Project: Karaf > Issue Type: Bug > Components: karaf-feature >Affects Versions: 4.2.0, 4.1.2, 4.0.10 >Reporter: Robert Varga >Assignee: Guillaume Nodet >Priority: Critical > > This is a follow-up of downstream issue tracked at > https://bugs.opendaylight.org/show_bug.cgi?id=9218. > OpenDaylight uses auto-generated features, which may end up packaging a > bundle multiple times in separate features -- which can be regarded as a bug, > but it certainly is counter-intuitive. > Using a simple test case of wanting to install all features at the same time > triggers huge memory usage spike in Felix Resolver. > Since ResourceImpl does not explictly override hashCode()/equals() according > to org.osgi.resource.Resource interface contract, every resource declaration > in a feature is treated as unique -- disregarding the fact that multiple > bundle declarations are actually pointing to the same bundle. > This cascades to both RequirementImpl and CapabilityImpl, hence each such > duplicate bundle is added to the set of Requirements to be resolved and its > capabilities are added to potential candidates -- leading to Felix Resolver > having a large problem space (what to resolve) and also having a large > solution space (how to resolve) -- leading to polynomial explosion in CPU and > memory requirements. > The amount of memory consumed by OpenDaylight Nitrogen RC3 has been observed > at 1.2GB, e.g. with a heap smaller than that, the container runs into OOM > during feature:install before actual installation starts. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (KARAF-5410) Bundle loaded before cfg file
Chow created KARAF-5410:
---
Summary: Bundle loaded before cfg file
Key: KARAF-5410
URL: https://issues.apache.org/jira/browse/KARAF-5410
Project: Karaf
Issue Type: Bug
Affects Versions: 4.0.9
Environment: I'm running a 4.0.9 version of Karaf.
The bundles are loaded with the help of feature:install.
The cfg file is loaded via a and he's physically present into the
/etc
Reporter: Chow
When i restart karaf some times i've got this exception :
{code:java}
Exception:
org.osgi.service.blueprint.container.ComponentDefinitionException: Error
setting property: PropertyDescriptor
[jira] [Commented] (KARAF-5394) maven-metadata-local.xml in KARs cause SAXParseException
[
https://issues.apache.org/jira/browse/KARAF-5394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16192990#comment-16192990
]
ASF subversion and git services commented on KARAF-5394:
Commit 07539de1edc335b34cc9561ecb102448dba00831 in karaf's branch
refs/heads/karaf-4.1.x from [~jbonofre]
[ https://git-wip-us.apache.org/repos/asf?p=karaf.git;h=07539de ]
[KARAF-5394] Exclude maven-metadata* from the kar FeatureDetector
> maven-metadata-local.xml in KARs cause SAXParseException
>
>
> Key: KARAF-5394
> URL: https://issues.apache.org/jira/browse/KARAF-5394
> Project: Karaf
> Issue Type: Bug
> Components: karaf-kar
>Affects Versions: 4.1.2
>Reporter: Kai Kreuzer
>Assignee: Jean-Baptiste Onofré
>Priority: Minor
> Fix For: 4.2.0, 4.1.3
>
>
> When deploying a kar file into my installation, I get a long list of DEBUG
> logs like:
> {code:java}
> 16:39:52.095 [DEBUG] [he.karaf.kar.internal.FeatureDetector] - File
> 'maven-metadata-local.xml' is not a features file.
> org.xml.sax.SAXParseException: Premature end of file.
> at
> com.sun.org.apache.xerces.internal.util.ErrorHandlerWrapper.createSAXParseException(ErrorHandlerWrapper.java:203)
> [?:?]
> at
> com.sun.org.apache.xerces.internal.util.ErrorHandlerWrapper.fatalError(ErrorHandlerWrapper.java:177)
> [?:?]
> at
> com.sun.org.apache.xerces.internal.impl.XMLErrorReporter.reportError(XMLErrorReporter.java:400)
> [?:?]
> at
> com.sun.org.apache.xerces.internal.impl.XMLErrorReporter.reportError(XMLErrorReporter.java:327)
> [?:?]
> at
> com.sun.org.apache.xerces.internal.impl.XMLScanner.reportFatalError(XMLScanner.java:1472)
> [?:?]
> at
> com.sun.org.apache.xerces.internal.impl.XMLDocumentScannerImpl$PrologDriver.next(XMLDocumentScannerImpl.java:1014)
> [?:?]
> at
> com.sun.org.apache.xerces.internal.impl.XMLDocumentScannerImpl.next(XMLDocumentScannerImpl.java:602)
> [?:?]
> at
> com.sun.org.apache.xerces.internal.impl.XMLNSDocumentScannerImpl.next(XMLNSDocumentScannerImpl.java:112)
> [?:?]
> at
> com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scanDocument(XMLDocumentFragmentScannerImpl.java:505)
> [?:?]
> at
> com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:841)
> [?:?]
> at
> com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:770)
> [?:?]
> at
> com.sun.org.apache.xerces.internal.parsers.XMLParser.parse(XMLParser.java:141)
> [?:?]
> at
> com.sun.org.apache.xerces.internal.parsers.DOMParser.parse(DOMParser.java:243)
> [?:?]
> at
> com.sun.org.apache.xerces.internal.jaxp.DocumentBuilderImpl.parse(DocumentBuilderImpl.java:339)
> [?:?]
> at javax.xml.parsers.DocumentBuilder.parse(DocumentBuilder.java:205)
> [?:?]
> at
> org.apache.karaf.kar.internal.FeatureDetector.parse(FeatureDetector.java:84)
> [56:org.apache.karaf.kar.core:4.1.2]
> at
> org.apache.karaf.kar.internal.FeatureDetector.isFeaturesRepository(FeatureDetector.java:53)
> [56:org.apache.karaf.kar.core:4.1.2]
> at org.apache.karaf.kar.internal.Kar.extract(Kar.java:122)
> [56:org.apache.karaf.kar.core:4.1.2]
> at
> org.apache.karaf.kar.internal.KarServiceImpl.install(KarServiceImpl.java:102)
> [56:org.apache.karaf.kar.core:4.1.2]
> at
> org.apache.karaf.kar.internal.KarServiceImpl.install(KarServiceImpl.java:94)
> [56:org.apache.karaf.kar.core:4.1.2]
> at
> org.apache.karaf.deployer.kar.KarArtifactInstaller.install(KarArtifactInstaller.java:50)
> [47:org.apache.karaf.deployer.kar:4.1.2]
> at
> org.apache.felix.fileinstall.internal.DirectoryWatcher.install(DirectoryWatcher.java:937)
> [8:org.apache.felix.fileinstall:3.6.0]
> at
> org.apache.felix.fileinstall.internal.DirectoryWatcher.install(DirectoryWatcher.java:871)
> [8:org.apache.felix.fileinstall:3.6.0]
> at
> org.apache.felix.fileinstall.internal.DirectoryWatcher.doProcess(DirectoryWatcher.java:485)
> [8:org.apache.felix.fileinstall:3.6.0]
> at
> org.apache.felix.fileinstall.internal.DirectoryWatcher.process(DirectoryWatcher.java:361)
> [8:org.apache.felix.fileinstall:3.6.0]
> at
> org.apache.felix.fileinstall.internal.DirectoryWatcher.run(DirectoryWatcher.java:312)
> [8:org.apache.felix.fileinstall:3.6.0]
> {code}
> According to KARAF-1198, it seems to be ok to have those files within the
> kar, so I would expect that the FeatureDetector is also aware of their
> existence and simply ignore them instead of logging exceptions.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (KARAF-5394) maven-metadata-local.xml in KARs cause SAXParseException
[
https://issues.apache.org/jira/browse/KARAF-5394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16192987#comment-16192987
]
ASF subversion and git services commented on KARAF-5394:
Commit 03bc8dfed90965d8fc9beed38305926d5f1e3a86 in karaf's branch
refs/heads/master from [~jbonofre]
[ https://git-wip-us.apache.org/repos/asf?p=karaf.git;h=03bc8df ]
[KARAF-5394] Exclude maven-metadata* from the kar FeatureDetector
> maven-metadata-local.xml in KARs cause SAXParseException
>
>
> Key: KARAF-5394
> URL: https://issues.apache.org/jira/browse/KARAF-5394
> Project: Karaf
> Issue Type: Bug
> Components: karaf-kar
>Affects Versions: 4.1.2
>Reporter: Kai Kreuzer
>Assignee: Jean-Baptiste Onofré
>Priority: Minor
> Fix For: 4.2.0, 4.1.3
>
>
> When deploying a kar file into my installation, I get a long list of DEBUG
> logs like:
> {code:java}
> 16:39:52.095 [DEBUG] [he.karaf.kar.internal.FeatureDetector] - File
> 'maven-metadata-local.xml' is not a features file.
> org.xml.sax.SAXParseException: Premature end of file.
> at
> com.sun.org.apache.xerces.internal.util.ErrorHandlerWrapper.createSAXParseException(ErrorHandlerWrapper.java:203)
> [?:?]
> at
> com.sun.org.apache.xerces.internal.util.ErrorHandlerWrapper.fatalError(ErrorHandlerWrapper.java:177)
> [?:?]
> at
> com.sun.org.apache.xerces.internal.impl.XMLErrorReporter.reportError(XMLErrorReporter.java:400)
> [?:?]
> at
> com.sun.org.apache.xerces.internal.impl.XMLErrorReporter.reportError(XMLErrorReporter.java:327)
> [?:?]
> at
> com.sun.org.apache.xerces.internal.impl.XMLScanner.reportFatalError(XMLScanner.java:1472)
> [?:?]
> at
> com.sun.org.apache.xerces.internal.impl.XMLDocumentScannerImpl$PrologDriver.next(XMLDocumentScannerImpl.java:1014)
> [?:?]
> at
> com.sun.org.apache.xerces.internal.impl.XMLDocumentScannerImpl.next(XMLDocumentScannerImpl.java:602)
> [?:?]
> at
> com.sun.org.apache.xerces.internal.impl.XMLNSDocumentScannerImpl.next(XMLNSDocumentScannerImpl.java:112)
> [?:?]
> at
> com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scanDocument(XMLDocumentFragmentScannerImpl.java:505)
> [?:?]
> at
> com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:841)
> [?:?]
> at
> com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:770)
> [?:?]
> at
> com.sun.org.apache.xerces.internal.parsers.XMLParser.parse(XMLParser.java:141)
> [?:?]
> at
> com.sun.org.apache.xerces.internal.parsers.DOMParser.parse(DOMParser.java:243)
> [?:?]
> at
> com.sun.org.apache.xerces.internal.jaxp.DocumentBuilderImpl.parse(DocumentBuilderImpl.java:339)
> [?:?]
> at javax.xml.parsers.DocumentBuilder.parse(DocumentBuilder.java:205)
> [?:?]
> at
> org.apache.karaf.kar.internal.FeatureDetector.parse(FeatureDetector.java:84)
> [56:org.apache.karaf.kar.core:4.1.2]
> at
> org.apache.karaf.kar.internal.FeatureDetector.isFeaturesRepository(FeatureDetector.java:53)
> [56:org.apache.karaf.kar.core:4.1.2]
> at org.apache.karaf.kar.internal.Kar.extract(Kar.java:122)
> [56:org.apache.karaf.kar.core:4.1.2]
> at
> org.apache.karaf.kar.internal.KarServiceImpl.install(KarServiceImpl.java:102)
> [56:org.apache.karaf.kar.core:4.1.2]
> at
> org.apache.karaf.kar.internal.KarServiceImpl.install(KarServiceImpl.java:94)
> [56:org.apache.karaf.kar.core:4.1.2]
> at
> org.apache.karaf.deployer.kar.KarArtifactInstaller.install(KarArtifactInstaller.java:50)
> [47:org.apache.karaf.deployer.kar:4.1.2]
> at
> org.apache.felix.fileinstall.internal.DirectoryWatcher.install(DirectoryWatcher.java:937)
> [8:org.apache.felix.fileinstall:3.6.0]
> at
> org.apache.felix.fileinstall.internal.DirectoryWatcher.install(DirectoryWatcher.java:871)
> [8:org.apache.felix.fileinstall:3.6.0]
> at
> org.apache.felix.fileinstall.internal.DirectoryWatcher.doProcess(DirectoryWatcher.java:485)
> [8:org.apache.felix.fileinstall:3.6.0]
> at
> org.apache.felix.fileinstall.internal.DirectoryWatcher.process(DirectoryWatcher.java:361)
> [8:org.apache.felix.fileinstall:3.6.0]
> at
> org.apache.felix.fileinstall.internal.DirectoryWatcher.run(DirectoryWatcher.java:312)
> [8:org.apache.felix.fileinstall:3.6.0]
> {code}
> According to KARAF-1198, it seems to be ok to have those files within the
> kar, so I would expect that the FeatureDetector is also aware of their
> existence and simply ignore them instead of logging exceptions.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Resolved] (KARAF-5394) maven-metadata-local.xml in KARs cause SAXParseException
[
https://issues.apache.org/jira/browse/KARAF-5394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jean-Baptiste Onofré resolved KARAF-5394.
-
Resolution: Fixed
> maven-metadata-local.xml in KARs cause SAXParseException
>
>
> Key: KARAF-5394
> URL: https://issues.apache.org/jira/browse/KARAF-5394
> Project: Karaf
> Issue Type: Bug
> Components: karaf-kar
>Affects Versions: 4.1.2
>Reporter: Kai Kreuzer
>Assignee: Jean-Baptiste Onofré
>Priority: Minor
> Fix For: 4.2.0, 4.1.3
>
>
> When deploying a kar file into my installation, I get a long list of DEBUG
> logs like:
> {code:java}
> 16:39:52.095 [DEBUG] [he.karaf.kar.internal.FeatureDetector] - File
> 'maven-metadata-local.xml' is not a features file.
> org.xml.sax.SAXParseException: Premature end of file.
> at
> com.sun.org.apache.xerces.internal.util.ErrorHandlerWrapper.createSAXParseException(ErrorHandlerWrapper.java:203)
> [?:?]
> at
> com.sun.org.apache.xerces.internal.util.ErrorHandlerWrapper.fatalError(ErrorHandlerWrapper.java:177)
> [?:?]
> at
> com.sun.org.apache.xerces.internal.impl.XMLErrorReporter.reportError(XMLErrorReporter.java:400)
> [?:?]
> at
> com.sun.org.apache.xerces.internal.impl.XMLErrorReporter.reportError(XMLErrorReporter.java:327)
> [?:?]
> at
> com.sun.org.apache.xerces.internal.impl.XMLScanner.reportFatalError(XMLScanner.java:1472)
> [?:?]
> at
> com.sun.org.apache.xerces.internal.impl.XMLDocumentScannerImpl$PrologDriver.next(XMLDocumentScannerImpl.java:1014)
> [?:?]
> at
> com.sun.org.apache.xerces.internal.impl.XMLDocumentScannerImpl.next(XMLDocumentScannerImpl.java:602)
> [?:?]
> at
> com.sun.org.apache.xerces.internal.impl.XMLNSDocumentScannerImpl.next(XMLNSDocumentScannerImpl.java:112)
> [?:?]
> at
> com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scanDocument(XMLDocumentFragmentScannerImpl.java:505)
> [?:?]
> at
> com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:841)
> [?:?]
> at
> com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:770)
> [?:?]
> at
> com.sun.org.apache.xerces.internal.parsers.XMLParser.parse(XMLParser.java:141)
> [?:?]
> at
> com.sun.org.apache.xerces.internal.parsers.DOMParser.parse(DOMParser.java:243)
> [?:?]
> at
> com.sun.org.apache.xerces.internal.jaxp.DocumentBuilderImpl.parse(DocumentBuilderImpl.java:339)
> [?:?]
> at javax.xml.parsers.DocumentBuilder.parse(DocumentBuilder.java:205)
> [?:?]
> at
> org.apache.karaf.kar.internal.FeatureDetector.parse(FeatureDetector.java:84)
> [56:org.apache.karaf.kar.core:4.1.2]
> at
> org.apache.karaf.kar.internal.FeatureDetector.isFeaturesRepository(FeatureDetector.java:53)
> [56:org.apache.karaf.kar.core:4.1.2]
> at org.apache.karaf.kar.internal.Kar.extract(Kar.java:122)
> [56:org.apache.karaf.kar.core:4.1.2]
> at
> org.apache.karaf.kar.internal.KarServiceImpl.install(KarServiceImpl.java:102)
> [56:org.apache.karaf.kar.core:4.1.2]
> at
> org.apache.karaf.kar.internal.KarServiceImpl.install(KarServiceImpl.java:94)
> [56:org.apache.karaf.kar.core:4.1.2]
> at
> org.apache.karaf.deployer.kar.KarArtifactInstaller.install(KarArtifactInstaller.java:50)
> [47:org.apache.karaf.deployer.kar:4.1.2]
> at
> org.apache.felix.fileinstall.internal.DirectoryWatcher.install(DirectoryWatcher.java:937)
> [8:org.apache.felix.fileinstall:3.6.0]
> at
> org.apache.felix.fileinstall.internal.DirectoryWatcher.install(DirectoryWatcher.java:871)
> [8:org.apache.felix.fileinstall:3.6.0]
> at
> org.apache.felix.fileinstall.internal.DirectoryWatcher.doProcess(DirectoryWatcher.java:485)
> [8:org.apache.felix.fileinstall:3.6.0]
> at
> org.apache.felix.fileinstall.internal.DirectoryWatcher.process(DirectoryWatcher.java:361)
> [8:org.apache.felix.fileinstall:3.6.0]
> at
> org.apache.felix.fileinstall.internal.DirectoryWatcher.run(DirectoryWatcher.java:312)
> [8:org.apache.felix.fileinstall:3.6.0]
> {code}
> According to KARAF-1198, it seems to be ok to have those files within the
> kar, so I would expect that the FeatureDetector is also aware of their
> existence and simply ignore them instead of logging exceptions.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (KARAF-5404) CLI autocompletion issue
[
https://issues.apache.org/jira/browse/KARAF-5404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16192957#comment-16192957
]
ASF subversion and git services commented on KARAF-5404:
Commit 412d2b3712a048f380675dbeb5e7cdc55a321a3a in karaf's branch
refs/heads/master from [~gnt]
[ https://git-wip-us.apache.org/repos/asf?p=karaf.git;h=412d2b3 ]
[KARAF-5404] CLI autocompletion issue
> CLI autocompletion issue
>
>
> Key: KARAF-5404
> URL: https://issues.apache.org/jira/browse/KARAF-5404
> Project: Karaf
> Issue Type: Bug
>Affects Versions: 4.1.2
>Reporter: Paolo Antinori
>Assignee: Guillaume Nodet
>Priority: Minor
>
> In a freshly extracted Karaf 4.1.2, running on JDK9, hitting TAB just moves
> the blinking cursor.
> No autocompletion is triggered.
> If I start typing any command instead, like pressing a single {{j}} and then
> hit TAB, I get the correct suggestion.
> I suspect this is either a bug or the help message at boot should be changed
> from:
> {code}
> Apache Karaf (4.1.2)
> Hit '' for a list of available commands
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (KARAF-5395) ResourceImpl/RequirementImpl/CapabilityImpl do not correctly implement their OSGi interface contracts
[ https://issues.apache.org/jira/browse/KARAF-5395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16192947#comment-16192947 ] Guillaume Nodet commented on KARAF-5395: The following commit could help reducing memory consumption for resources too: https://github.com/gnodet/karaf/tree/KARAF-5395 Let me know if it helps, in which case I can commit it. > ResourceImpl/RequirementImpl/CapabilityImpl do not correctly implement their > OSGi interface contracts > - > > Key: KARAF-5395 > URL: https://issues.apache.org/jira/browse/KARAF-5395 > Project: Karaf > Issue Type: Bug > Components: karaf-feature >Affects Versions: 4.2.0, 4.1.2, 4.0.10 >Reporter: Robert Varga >Assignee: Guillaume Nodet >Priority: Critical > > This is a follow-up of downstream issue tracked at > https://bugs.opendaylight.org/show_bug.cgi?id=9218. > OpenDaylight uses auto-generated features, which may end up packaging a > bundle multiple times in separate features -- which can be regarded as a bug, > but it certainly is counter-intuitive. > Using a simple test case of wanting to install all features at the same time > triggers huge memory usage spike in Felix Resolver. > Since ResourceImpl does not explictly override hashCode()/equals() according > to org.osgi.resource.Resource interface contract, every resource declaration > in a feature is treated as unique -- disregarding the fact that multiple > bundle declarations are actually pointing to the same bundle. > This cascades to both RequirementImpl and CapabilityImpl, hence each such > duplicate bundle is added to the set of Requirements to be resolved and its > capabilities are added to potential candidates -- leading to Felix Resolver > having a large problem space (what to resolve) and also having a large > solution space (how to resolve) -- leading to polynomial explosion in CPU and > memory requirements. > The amount of memory consumed by OpenDaylight Nitrogen RC3 has been observed > at 1.2GB, e.g. with a heap smaller than that, the container runs into OOM > during feature:install before actual installation starts. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (KARAF-5409) feature:uninstall displays an error when the feature is installed but not started
[ https://issues.apache.org/jira/browse/KARAF-5409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Baptiste Onofré updated KARAF-5409: Summary: feature:uninstall displays an error when the feature is installed but not started (was: feature:uninstall display an error when the feature is installed but not started) > feature:uninstall displays an error when the feature is installed but not > started > - > > Key: KARAF-5409 > URL: https://issues.apache.org/jira/browse/KARAF-5409 > Project: Karaf > Issue Type: Bug > Components: karaf-feature >Affects Versions: 4.1.2 >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré > Fix For: 4.1.3 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (KARAF-5409) feature:uninstall display an error when the feature is installed but not started
Jean-Baptiste Onofré created KARAF-5409: --- Summary: feature:uninstall display an error when the feature is installed but not started Key: KARAF-5409 URL: https://issues.apache.org/jira/browse/KARAF-5409 Project: Karaf Issue Type: Bug Components: karaf-feature Affects Versions: 4.1.2 Reporter: Jean-Baptiste Onofré Assignee: Jean-Baptiste Onofré Fix For: 4.1.3 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (KARAF-5408) Add feature:tree command/MBean (like bundle:tree-show)
Jean-Baptiste Onofré created KARAF-5408: --- Summary: Add feature:tree command/MBean (like bundle:tree-show) Key: KARAF-5408 URL: https://issues.apache.org/jira/browse/KARAF-5408 Project: Karaf Issue Type: New Feature Components: karaf-feature, karaf-shell Reporter: Jean-Baptiste Onofré Assignee: Jean-Baptiste Onofré -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KARAF-5395) ResourceImpl/RequirementImpl/CapabilityImpl do not correctly implement their OSGi interface contracts
[
https://issues.apache.org/jira/browse/KARAF-5395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16192665#comment-16192665
]
Guillaume Nodet commented on KARAF-5395:
To decrease memory consumption further, it could be interesting to investigate
the use of {{org.apache.felix.resolver.util.ArrayMap}} instead of {{HashMap}}
for attributes and directives. For small maps (capacity of 4), it should take
32 bytes instead of 128 afaik.
> ResourceImpl/RequirementImpl/CapabilityImpl do not correctly implement their
> OSGi interface contracts
> -
>
> Key: KARAF-5395
> URL: https://issues.apache.org/jira/browse/KARAF-5395
> Project: Karaf
> Issue Type: Bug
> Components: karaf-feature
>Affects Versions: 4.2.0, 4.1.2, 4.0.10
>Reporter: Robert Varga
>Assignee: Guillaume Nodet
>Priority: Critical
>
> This is a follow-up of downstream issue tracked at
> https://bugs.opendaylight.org/show_bug.cgi?id=9218.
> OpenDaylight uses auto-generated features, which may end up packaging a
> bundle multiple times in separate features -- which can be regarded as a bug,
> but it certainly is counter-intuitive.
> Using a simple test case of wanting to install all features at the same time
> triggers huge memory usage spike in Felix Resolver.
> Since ResourceImpl does not explictly override hashCode()/equals() according
> to org.osgi.resource.Resource interface contract, every resource declaration
> in a feature is treated as unique -- disregarding the fact that multiple
> bundle declarations are actually pointing to the same bundle.
> This cascades to both RequirementImpl and CapabilityImpl, hence each such
> duplicate bundle is added to the set of Requirements to be resolved and its
> capabilities are added to potential candidates -- leading to Felix Resolver
> having a large problem space (what to resolve) and also having a large
> solution space (how to resolve) -- leading to polynomial explosion in CPU and
> memory requirements.
> The amount of memory consumed by OpenDaylight Nitrogen RC3 has been observed
> at 1.2GB, e.g. with a heap smaller than that, the container runs into OOM
> during feature:install before actual installation starts.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Comment Edited] (KARAF-5404) CLI autocompletion issue
[
https://issues.apache.org/jira/browse/KARAF-5404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16192549#comment-16192549
]
Guillaume Nodet edited comment on KARAF-5404 at 10/5/17 8:28 AM:
-
Also, the tab insertion at the beginning of a line may not be really necessary
anymore since jline now supports bracketed paste, so I'm wondering if we should
include this line by default in the startup script (or even from the code that
creates the console)...
was (Author: gnt):
Also, that's not really necessary anymore since jline now supports bracketed
paste, so I'm wondering if we should include this line by default in the
startup script (or even from the code that creates the console)...
> CLI autocompletion issue
>
>
> Key: KARAF-5404
> URL: https://issues.apache.org/jira/browse/KARAF-5404
> Project: Karaf
> Issue Type: Bug
>Affects Versions: 4.1.2
>Reporter: Paolo Antinori
>Assignee: Guillaume Nodet
>Priority: Minor
>
> In a freshly extracted Karaf 4.1.2, running on JDK9, hitting TAB just moves
> the blinking cursor.
> No autocompletion is triggered.
> If I start typing any command instead, like pressing a single {{j}} and then
> hit TAB, I get the correct suggestion.
> I suspect this is either a bug or the help message at boot should be changed
> from:
> {code}
> Apache Karaf (4.1.2)
> Hit '' for a list of available commands
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (KARAF-5402) Fileinstall incorrectly parses .config files
[
https://issues.apache.org/jira/browse/KARAF-5402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16192567#comment-16192567
]
Guillaume Nodet commented on KARAF-5402:
First, Karaf only supports typed config from 4.2 onward, see
https://issues.apache.org/jira/browse/KARAF-5074.
Second, the config file syntax is incorrect, as non array values need to be
quoted:
{code}
role.one.name="Operator"
role.two.name="Shadow"
role.one.permission=["permission1", "permission2", "permission3",
"permission4", "permission5", "permission6"]
role.two.permission=["permission1", "permission2", "permission3",
"permission4", "permission5", "permission6"]
permission.everything="EverythingBut"
{code}
> Fileinstall incorrectly parses .config files
>
>
> Key: KARAF-5402
> URL: https://issues.apache.org/jira/browse/KARAF-5402
> Project: Karaf
> Issue Type: Bug
> Components: karaf-config
>Affects Versions: 4.0.8, 4.0.9, 4.0.10
> Environment: Karaf 4.0.x
>Reporter: Łukasz Dywicki
>Assignee: Guillaume Nodet
> Labels: configurationadmin, fileinstall, regresion
> Attachments: com.example.role.config
>
>
> Support for array values encoded as strings inside of .config files is broken
> in given Karaf versions. Reasons for that are different between them as Karaf
> 4.0.10 uses new version of fileinstall, however result is the same - config
> values are always strings regardless of correctness of value notation. Karaf
> 4.0.8 and 4.0.9 in general are broken due to bug in fileinstall or config
> admin as they tend to override source configuration with some partia
> representation malformed by configuration parser.
> For karaf 4.0.10, even if it uses fileinstall 3.6.0 there is no way, so far -
> to force configuration to be typed.
> {code:title="Error message for fileinstall 3.5.x:"}
> java.io.IOException: Unexpected token 78; expected: 61 (line=39, pos=4)
> at
> org.apache.felix.cm.file.ConfigurationHandler.readFailure(ConfigurationHandler.java:650)[4:org.apache.felix.fileinstall:3.5.4]
> at
> org.apache.felix.cm.file.ConfigurationHandler.readInternal(ConfigurationHandler.java:274)[4:org.apache.felix.fileinstall:3.5.4]
> at
> org.apache.felix.cm.file.ConfigurationHandler.read(ConfigurationHandler.java:237)[4:org.apache.felix.fileinstall:3.5.4]
> at
> org.apache.felix.fileinstall.internal.ConfigInstaller.setConfig(ConfigInstaller.java:237)[4:org.apache.felix.fileinstall:3.5.4]
> at
> org.apache.felix.fileinstall.internal.ConfigInstaller.install(ConfigInstaller.java:78)[4:org.apache.felix.fileinstall:3.5.4]
> at
> org.apache.felix.fileinstall.internal.DirectoryWatcher.install(DirectoryWatcher.java:937)[4:org.apache.felix.fileinstall:3.5.4]
> at
> org.apache.felix.fileinstall.internal.DirectoryWatcher.install(DirectoryWatcher.java:871)[4:org.apache.felix.fileinstall:3.5.4]
> at
> org.apache.felix.fileinstall.internal.DirectoryWatcher.doProcess(DirectoryWatcher.java:485)[4:org.apache.felix.fileinstall:3.5.4]
> at
> org.apache.felix.fileinstall.internal.DirectoryWatcher.process(DirectoryWatcher.java:361)[4:org.apache.felix.fileinstall:3.5.4]
> at
> org.apache.felix.fileinstall.internal.DirectoryWatcher.run(DirectoryWatcher.java:312)[4:org.apache.felix.fileinstall:3.5.4]
> {code}
> Line 39 and position 4 is middle of property key.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (KARAF-5404) CLI autocompletion issue
[
https://issues.apache.org/jira/browse/KARAF-5404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16192549#comment-16192549
]
Guillaume Nodet commented on KARAF-5404:
Also, that's not really necessary anymore since jline now supports bracketed
paste, so I'm wondering if we should include this line by default in the
startup script (or even from the code that creates the console)...
> CLI autocompletion issue
>
>
> Key: KARAF-5404
> URL: https://issues.apache.org/jira/browse/KARAF-5404
> Project: Karaf
> Issue Type: Bug
>Affects Versions: 4.1.2
>Reporter: Paolo Antinori
>Assignee: Guillaume Nodet
>Priority: Minor
>
> In a freshly extracted Karaf 4.1.2, running on JDK9, hitting TAB just moves
> the blinking cursor.
> No autocompletion is triggered.
> If I start typing any command instead, like pressing a single {{j}} and then
> hit TAB, I get the correct suggestion.
> I suspect this is either a bug or the help message at boot should be changed
> from:
> {code}
> Apache Karaf (4.1.2)
> Hit '' for a list of available commands
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (KARAF-5404) CLI autocompletion issue
[
https://issues.apache.org/jira/browse/KARAF-5404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16192543#comment-16192543
]
Guillaume Nodet commented on KARAF-5404:
That's the default behavior from Karaf >= 4.1, where tab does not complete at
the beginning of a line (same behavior as the zsh shell).
You can change it by adding the following in your startup script:
{code}
unsetopt insert-tab
{code}
> CLI autocompletion issue
>
>
> Key: KARAF-5404
> URL: https://issues.apache.org/jira/browse/KARAF-5404
> Project: Karaf
> Issue Type: Bug
>Affects Versions: 4.1.2
>Reporter: Paolo Antinori
>Priority: Minor
>
> In a freshly extracted Karaf 4.1.2, running on JDK9, hitting TAB just moves
> the blinking cursor.
> No autocompletion is triggered.
> If I start typing any command instead, like pressing a single {{j}} and then
> hit TAB, I get the correct suggestion.
> I suspect this is either a bug or the help message at boot should be changed
> from:
> {code}
> Apache Karaf (4.1.2)
> Hit '' for a list of available commands
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Reopened] (KARAF-5404) CLI autocompletion issue
[
https://issues.apache.org/jira/browse/KARAF-5404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guillaume Nodet reopened KARAF-5404:
Reopening as we definitely need to fix the welcome message...
> CLI autocompletion issue
>
>
> Key: KARAF-5404
> URL: https://issues.apache.org/jira/browse/KARAF-5404
> Project: Karaf
> Issue Type: Bug
>Affects Versions: 4.1.2
>Reporter: Paolo Antinori
>Assignee: Guillaume Nodet
>Priority: Minor
>
> In a freshly extracted Karaf 4.1.2, running on JDK9, hitting TAB just moves
> the blinking cursor.
> No autocompletion is triggered.
> If I start typing any command instead, like pressing a single {{j}} and then
> hit TAB, I get the correct suggestion.
> I suspect this is either a bug or the help message at boot should be changed
> from:
> {code}
> Apache Karaf (4.1.2)
> Hit '' for a list of available commands
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Resolved] (KARAF-5404) CLI autocompletion issue
[
https://issues.apache.org/jira/browse/KARAF-5404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guillaume Nodet resolved KARAF-5404.
Resolution: Not A Problem
Assignee: Guillaume Nodet
> CLI autocompletion issue
>
>
> Key: KARAF-5404
> URL: https://issues.apache.org/jira/browse/KARAF-5404
> Project: Karaf
> Issue Type: Bug
>Affects Versions: 4.1.2
>Reporter: Paolo Antinori
>Assignee: Guillaume Nodet
>Priority: Minor
>
> In a freshly extracted Karaf 4.1.2, running on JDK9, hitting TAB just moves
> the blinking cursor.
> No autocompletion is triggered.
> If I start typing any command instead, like pressing a single {{j}} and then
> hit TAB, I get the correct suggestion.
> I suspect this is either a bug or the help message at boot should be changed
> from:
> {code}
> Apache Karaf (4.1.2)
> Hit '' for a list of available commands
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
