[jira] [Commented] (KARAF-7667) Upgrade karaf-maven-plugin to latest maven-resolver

2023-02-07 Thread Mark Derricutt (Jira)


[ 
https://issues.apache.org/jira/browse/KARAF-7667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17685152#comment-17685152
 ] 

Mark Derricutt commented on KARAF-7667:
---

Further to this, I think the problem is more upstream of karaf-maven-plugin 
itself:

{{java.io.IOException: Error resolving artifact 
smx3:smx3.partyproduct.api:jar:47.0.20-SNAPSHOT: [Could not find artifact 
smx3:smx3.partyproduct.api:jar:47.0.20-SNAPSHOT]
at org.ops4j.pax.url.mvn.internal.AetherBasedResolver.configureIOException 
(AetherBasedResolver.java:803)
at org.ops4j.pax.url.mvn.internal.AetherBasedResolver.resolve 
(AetherBasedResolver.java:774)
at org.ops4j.pax.url.mvn.internal.AetherBasedResolver.resolve 
(AetherBasedResolver.java:657)
at org.ops4j.pax.url.mvn.internal.AetherBasedResolver.resolve 
(AetherBasedResolver.java:598)
at org.ops4j.pax.url.mvn.internal.AetherBasedResolver.resolve 
(AetherBasedResolver.java:565)
at org.apache.karaf.tooling.utils.ReactorMavenResolver.resolve 
(ReactorMavenResolver.java:63)
at 
org.apache.karaf.features.internal.download.impl.MavenDownloadTask.download 
(MavenDownloadTask.java:52)
at 
org.apache.karaf.features.internal.download.impl.AbstractRetryableDownloadTask.run
 (AbstractRetryableDownloadTask.java:60)
at java.util.concurrent.Executors$RunnableAdapter.call (Executors.java:511)
at java.util.concurrent.FutureTask.run (FutureTask.java:266)
at 
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201 
(ScheduledThreadPoolExecutor.java:180)
at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run 
(ScheduledThreadPoolExecutor.java:293)
at java.util.concurrent.ThreadPoolExecutor.runWorker 
(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run 
(ThreadPoolExecutor.java:624)
at java.lang.Thread.run (Thread.java:750)
Caused by: shaded.org.eclipse.aether.resolution.ArtifactResolutionException: 
Error resolving artifact smx3:smx3.partyproduct.api:jar:47.0.20-SNAPSHOT
at shaded.org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolve 
(DefaultArtifactResolver.java:431)
at 
shaded.org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolveArtifacts
 (DefaultArtifactResolver.java:235)
at 
shaded.org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolveArtifact 
(DefaultArtifactResolver.java:212)
at 
shaded.org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveArtifact 
(DefaultRepositorySystem.java:272)
at org.ops4j.pax.url.mvn.internal.AetherBasedResolver.resolve 
(AetherBasedResolver.java:767)
at org.ops4j.pax.url.mvn.internal.AetherBasedResolver.resolve 
(AetherBasedResolver.java:657)
at org.ops4j.pax.url.mvn.internal.AetherBasedResolver.resolve 
(AetherBasedResolver.java:598)
at org.ops4j.pax.url.mvn.internal.AetherBasedResolver.resolve 
(AetherBasedResolver.java:565)
at org.apache.karaf.tooling.utils.ReactorMavenResolver.resolve 
(ReactorMavenResolver.java:63)
at 
org.apache.karaf.features.internal.download.impl.MavenDownloadTask.download 
(MavenDownloadTask.java:52)
at 
org.apache.karaf.features.internal.download.impl.AbstractRetryableDownloadTask.run
 (AbstractRetryableDownloadTask.java:60)
at java.util.concurrent.Executors$RunnableAdapter.call (Executors.java:511)
at java.util.concurrent.FutureTask.run (FutureTask.java:266)
at 
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201 
(ScheduledThreadPoolExecutor.java:180)
at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run 
(ScheduledThreadPoolExecutor.java:293)
}}

It would appear to be Pax URL's shaded aether version.


> Upgrade karaf-maven-plugin to latest maven-resolver
> ---
>
> Key: KARAF-7667
> URL: https://issues.apache.org/jira/browse/KARAF-7667
> Project: Karaf
>  Issue Type: Improvement
>  Components: karaf
>Affects Versions: 4.4.3
>Reporter: Mark Derricutt
>Assignee: Jean-Baptiste Onofré
>Priority: Minor
>
> The newly released Maven 3.9.0 has switched to using the new maven resolver 
> 1.9.x releases, which add support for split repositories ( separating cached 
> downloads, local installs, and SNAPSHOTs ) which is great for working on 
> multiple branches without poisoning a local repository.
> However, Karaf Maven Plugin doesn't appear to use the resolver provided by 
> Maven, so doesn't pick up SNAPSHOTs when running in a split mode.
> 1.9.x is a binary breaking version of resolver however.
> Split repositories can be enabled by setting the following properties:
> truetruetrue
> See:
> - https://maven.apache.org/resolver/configuration.html
> - https://issues.apache.org/jira/browse/MNG-6270



--
This message was sent by Atlassia

[jira] [Comment Edited] (KARAF-7667) Upgrade karaf-maven-plugin to latest maven-resolver

2023-02-07 Thread Mark Derricutt (Jira)


[ 
https://issues.apache.org/jira/browse/KARAF-7667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17685152#comment-17685152
 ] 

Mark Derricutt edited comment on KARAF-7667 at 2/7/23 8:45 AM:
---

{{Further to this, I think the problem is more upstream of karaf-maven-plugin 
itself:}}

{{java.io.IOException: Error resolving artifact 
smx3:smx3.partyproduct.api:jar:47.0.20-SNAPSHOT: [Could not find artifact 
smx3:smx3.partyproduct.api:jar:47.0.20-SNAPSHOT]}}
{{at org.ops4j.pax.url.mvn.internal.AetherBasedResolver.configureIOException 
(AetherBasedResolver.java:803)}}
{{at org.ops4j.pax.url.mvn.internal.AetherBasedResolver.resolve 
(AetherBasedResolver.java:774)}}
{{at org.ops4j.pax.url.mvn.internal.AetherBasedResolver.resolve 
(AetherBasedResolver.java:657)}}
{{at org.ops4j.pax.url.mvn.internal.AetherBasedResolver.resolve 
(AetherBasedResolver.java:598)}}
{{at org.ops4j.pax.url.mvn.internal.AetherBasedResolver.resolve 
(AetherBasedResolver.java:565)}}
{{at org.apache.karaf.tooling.utils.ReactorMavenResolver.resolve 
(ReactorMavenResolver.java:63)}}
{{at 
org.apache.karaf.features.internal.download.impl.MavenDownloadTask.download 
(MavenDownloadTask.java:52)}}
{{at 
org.apache.karaf.features.internal.download.impl.AbstractRetryableDownloadTask.run
 (AbstractRetryableDownloadTask.java:60)}}
{{at java.util.concurrent.Executors$RunnableAdapter.call (Executors.java:511)}}
{{at java.util.concurrent.FutureTask.run (FutureTask.java:266)}}
{{at 
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201 
(ScheduledThreadPoolExecutor.java:180)}}
{{at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run 
(ScheduledThreadPoolExecutor.java:293)}}
{{at java.util.concurrent.ThreadPoolExecutor.runWorker 
(ThreadPoolExecutor.java:1149)}}
{{at java.util.concurrent.ThreadPoolExecutor$Worker.run 
(ThreadPoolExecutor.java:624)}}
{{at java.lang.Thread.run (Thread.java:750)}}
{{Caused by: shaded.org.eclipse.aether.resolution.ArtifactResolutionException: 
Error resolving artifact smx3:smx3.partyproduct.api:jar:47.0.20-SNAPSHOT}}
{{at shaded.org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolve 
(DefaultArtifactResolver.java:431)}}
{{at 
shaded.org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolveArtifacts
 (DefaultArtifactResolver.java:235)}}
{{at 
shaded.org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolveArtifact 
(DefaultArtifactResolver.java:212)}}
{{at 
shaded.org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveArtifact 
(DefaultRepositorySystem.java:272)}}
{{at org.ops4j.pax.url.mvn.internal.AetherBasedResolver.resolve 
(AetherBasedResolver.java:767)}}
{{at org.ops4j.pax.url.mvn.internal.AetherBasedResolver.resolve 
(AetherBasedResolver.java:657)}}
{{at org.ops4j.pax.url.mvn.internal.AetherBasedResolver.resolve 
(AetherBasedResolver.java:598)}}
{{at org.ops4j.pax.url.mvn.internal.AetherBasedResolver.resolve 
(AetherBasedResolver.java:565)}}
{{at org.apache.karaf.tooling.utils.ReactorMavenResolver.resolve 
(ReactorMavenResolver.java:63)}}
{{at 
org.apache.karaf.features.internal.download.impl.MavenDownloadTask.download 
(MavenDownloadTask.java:52)}}
{{at 
org.apache.karaf.features.internal.download.impl.AbstractRetryableDownloadTask.run
 (AbstractRetryableDownloadTask.java:60)}}
{{at java.util.concurrent.Executors$RunnableAdapter.call (Executors.java:511)}}
{{at java.util.concurrent.FutureTask.run (FutureTask.java:266)}}
{{at 
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201 
(ScheduledThreadPoolExecutor.java:180)}}
{{at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run 
(ScheduledThreadPoolExecutor.java:293)}}

It would appear to be Pax URL's shaded aether version.


was (Author: talios):
Further to this, I think the problem is more upstream of karaf-maven-plugin 
itself:

{{
java.io.IOException: Error resolving artifact 
smx3:smx3.partyproduct.api:jar:47.0.20-SNAPSHOT: [Could not find artifact 
smx3:smx3.partyproduct.api:jar:47.0.20-SNAPSHOT]
at org.ops4j.pax.url.mvn.internal.AetherBasedResolver.configureIOException 
(AetherBasedResolver.java:803)
at org.ops4j.pax.url.mvn.internal.AetherBasedResolver.resolve 
(AetherBasedResolver.java:774)
at org.ops4j.pax.url.mvn.internal.AetherBasedResolver.resolve 
(AetherBasedResolver.java:657)
at org.ops4j.pax.url.mvn.internal.AetherBasedResolver.resolve 
(AetherBasedResolver.java:598)
at org.ops4j.pax.url.mvn.internal.AetherBasedResolver.resolve 
(AetherBasedResolver.java:565)
at org.apache.karaf.tooling.utils.ReactorMavenResolver.resolve 
(ReactorMavenResolver.java:63)
at 
org.apache.karaf.features.internal.download.impl.MavenDownloadTask.download 
(MavenDownloadTask.java:52)
at 
org.apache.karaf.features.internal.download.impl.AbstractRetryableDownloadTask.run
 (AbstractRetryableDownloadTask.java:60)
at 

[jira] [Comment Edited] (KARAF-7667) Upgrade karaf-maven-plugin to latest maven-resolver

2023-02-07 Thread Mark Derricutt (Jira)


[ 
https://issues.apache.org/jira/browse/KARAF-7667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17685152#comment-17685152
 ] 

Mark Derricutt edited comment on KARAF-7667 at 2/7/23 8:45 AM:
---

Further to this, I think the problem is more upstream of karaf-maven-plugin 
itself:

{{
java.io.IOException: Error resolving artifact 
smx3:smx3.partyproduct.api:jar:47.0.20-SNAPSHOT: [Could not find artifact 
smx3:smx3.partyproduct.api:jar:47.0.20-SNAPSHOT]
at org.ops4j.pax.url.mvn.internal.AetherBasedResolver.configureIOException 
(AetherBasedResolver.java:803)
at org.ops4j.pax.url.mvn.internal.AetherBasedResolver.resolve 
(AetherBasedResolver.java:774)
at org.ops4j.pax.url.mvn.internal.AetherBasedResolver.resolve 
(AetherBasedResolver.java:657)
at org.ops4j.pax.url.mvn.internal.AetherBasedResolver.resolve 
(AetherBasedResolver.java:598)
at org.ops4j.pax.url.mvn.internal.AetherBasedResolver.resolve 
(AetherBasedResolver.java:565)
at org.apache.karaf.tooling.utils.ReactorMavenResolver.resolve 
(ReactorMavenResolver.java:63)
at 
org.apache.karaf.features.internal.download.impl.MavenDownloadTask.download 
(MavenDownloadTask.java:52)
at 
org.apache.karaf.features.internal.download.impl.AbstractRetryableDownloadTask.run
 (AbstractRetryableDownloadTask.java:60)
at java.util.concurrent.Executors$RunnableAdapter.call (Executors.java:511)
at java.util.concurrent.FutureTask.run (FutureTask.java:266)
at 
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201 
(ScheduledThreadPoolExecutor.java:180)
at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run 
(ScheduledThreadPoolExecutor.java:293)
at java.util.concurrent.ThreadPoolExecutor.runWorker 
(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run 
(ThreadPoolExecutor.java:624)
at java.lang.Thread.run (Thread.java:750)
Caused by: shaded.org.eclipse.aether.resolution.ArtifactResolutionException: 
Error resolving artifact smx3:smx3.partyproduct.api:jar:47.0.20-SNAPSHOT
at shaded.org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolve 
(DefaultArtifactResolver.java:431)
at 
shaded.org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolveArtifacts
 (DefaultArtifactResolver.java:235)
at 
shaded.org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolveArtifact 
(DefaultArtifactResolver.java:212)
at 
shaded.org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveArtifact 
(DefaultRepositorySystem.java:272)
at org.ops4j.pax.url.mvn.internal.AetherBasedResolver.resolve 
(AetherBasedResolver.java:767)
at org.ops4j.pax.url.mvn.internal.AetherBasedResolver.resolve 
(AetherBasedResolver.java:657)
at org.ops4j.pax.url.mvn.internal.AetherBasedResolver.resolve 
(AetherBasedResolver.java:598)
at org.ops4j.pax.url.mvn.internal.AetherBasedResolver.resolve 
(AetherBasedResolver.java:565)
at org.apache.karaf.tooling.utils.ReactorMavenResolver.resolve 
(ReactorMavenResolver.java:63)
at 
org.apache.karaf.features.internal.download.impl.MavenDownloadTask.download 
(MavenDownloadTask.java:52)
at 
org.apache.karaf.features.internal.download.impl.AbstractRetryableDownloadTask.run
 (AbstractRetryableDownloadTask.java:60)
at java.util.concurrent.Executors$RunnableAdapter.call (Executors.java:511)
at java.util.concurrent.FutureTask.run (FutureTask.java:266)
at 
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201 
(ScheduledThreadPoolExecutor.java:180)
at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run 
(ScheduledThreadPoolExecutor.java:293)
}}

It would appear to be Pax URL's shaded aether version.



was (Author: talios):
Further to this, I think the problem is more upstream of karaf-maven-plugin 
itself:

{{java.io.IOException: Error resolving artifact 
smx3:smx3.partyproduct.api:jar:47.0.20-SNAPSHOT: [Could not find artifact 
smx3:smx3.partyproduct.api:jar:47.0.20-SNAPSHOT]
at org.ops4j.pax.url.mvn.internal.AetherBasedResolver.configureIOException 
(AetherBasedResolver.java:803)
at org.ops4j.pax.url.mvn.internal.AetherBasedResolver.resolve 
(AetherBasedResolver.java:774)
at org.ops4j.pax.url.mvn.internal.AetherBasedResolver.resolve 
(AetherBasedResolver.java:657)
at org.ops4j.pax.url.mvn.internal.AetherBasedResolver.resolve 
(AetherBasedResolver.java:598)
at org.ops4j.pax.url.mvn.internal.AetherBasedResolver.resolve 
(AetherBasedResolver.java:565)
at org.apache.karaf.tooling.utils.ReactorMavenResolver.resolve 
(ReactorMavenResolver.java:63)
at 
org.apache.karaf.features.internal.download.impl.MavenDownloadTask.download 
(MavenDownloadTask.java:52)
at 
org.apache.karaf.features.internal.download.impl.AbstractRetryableDownloadTask.run
 (AbstractRetryableDownloadTask.java:60)
at java.u

[jira] [Commented] (KARAF-7660) Upgrade to orientdb-client 3.2.15

2023-02-07 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KARAF-7660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17685398#comment-17685398
 ] 

ASF GitHub Bot commented on KARAF-7660:
---

jbonofre merged PR #319:
URL: https://github.com/apache/karaf-decanter/pull/319




> Upgrade to orientdb-client 3.2.15
> -
>
> Key: KARAF-7660
> URL: https://issues.apache.org/jira/browse/KARAF-7660
> Project: Karaf
>  Issue Type: Dependency upgrade
>  Components: decanter
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Resolved] (KARAF-7660) Upgrade to orientdb-client 3.2.15

2023-02-07 Thread Jira


 [ 
https://issues.apache.org/jira/browse/KARAF-7660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jean-Baptiste Onofré resolved KARAF-7660.
-
Fix Version/s: decanter-2.10.0
   Resolution: Fixed

> Upgrade to orientdb-client 3.2.15
> -
>
> Key: KARAF-7660
> URL: https://issues.apache.org/jira/browse/KARAF-7660
> Project: Karaf
>  Issue Type: Dependency upgrade
>  Components: decanter
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: decanter-2.10.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (KARAF-7660) Upgrade to orientdb-client 3.2.15

2023-02-07 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/KARAF-7660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17685400#comment-17685400
 ] 

ASF subversion and git services commented on KARAF-7660:


Commit 8611f2fbb0d7510758ebbd549212bfa9aaed8c3f in karaf-decanter's branch 
refs/heads/main from JB Onofré
[ https://gitbox.apache.org/repos/asf?p=karaf-decanter.git;h=8611f2fb ]

Merge pull request #319 from jbonofre/KARAF-7660

[KARAF-7660] Upgrade to orientdb-client 3.2.15

> Upgrade to orientdb-client 3.2.15
> -
>
> Key: KARAF-7660
> URL: https://issues.apache.org/jira/browse/KARAF-7660
> Project: Karaf
>  Issue Type: Dependency upgrade
>  Components: decanter
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (KARAF-7660) Upgrade to orientdb-client 3.2.15

2023-02-07 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/KARAF-7660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17685399#comment-17685399
 ] 

ASF subversion and git services commented on KARAF-7660:


Commit f9f5af2c11cfa8a836681034d6a082e43aa807dc in karaf-decanter's branch 
refs/heads/main from JB Onofré
[ https://gitbox.apache.org/repos/asf?p=karaf-decanter.git;h=f9f5af2c ]

[KARAF-7660] Upgrade to orientdb-client 3.2.15


> Upgrade to orientdb-client 3.2.15
> -
>
> Key: KARAF-7660
> URL: https://issues.apache.org/jira/browse/KARAF-7660
> Project: Karaf
>  Issue Type: Dependency upgrade
>  Components: decanter
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (KARAF-5421) Better error while installing non OSGi bundles

2023-02-07 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KARAF-5421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17685484#comment-17685484
 ] 

ASF GitHub Bot commented on KARAF-5421:
---

awrb opened a new pull request, #1713:
URL: https://github.com/apache/karaf/pull/1713

   …via bundle:install




> Better error while installing non OSGi bundles
> --
>
> Key: KARAF-5421
> URL: https://issues.apache.org/jira/browse/KARAF-5421
> Project: Karaf
>  Issue Type: Improvement
>Affects Versions: 4.1.2
>Reporter: Paolo Antinori
>Priority: Major
>
> I understand installing a non OSGi bundle is wrong at a logical level, but 
> the error message when doing so, it's fairly cryptic:
> {code}
> karaf@root()> install mvn:org.keycloak/keycloak-undertow-adapter/3.3.0.CR2
> Bundle IDs: 
> Error executing command: Error installing bundles:
>   Unable to install bundle 
> mvn:org.keycloak/keycloak-undertow-adapter/3.3.0.CR2: 
> org.osgi.framework.BundleException: OSGi R3 bundle not supported
> {code}
> Does it make sense for the error message to suggest checking it's a valid 
> bundle?
> Manifest of the above file is:
> {code}
> 14:21 $ unzip -c  
> ~/.m2/repository/org/keycloak/keycloak-undertow-adapter/3.3.0.CR2/keycloak-undertow-adapter-3.3.0.CR2.jar
>  **MANIFEST.MF
> Archive:  
> /home/pantinor/.m2/repository/org/keycloak/keycloak-undertow-adapter/3.3.0.CR2/keycloak-undertow-adapter-3.3.0.CR2.jar
>   inflating: META-INF/MANIFEST.MF
> Manifest-Version: 1.0
> Implementation-Title: Keycloak Undertow Integration
> Implementation-Version: 3.3.0.CR2
> Java-Version: 1.8.0_144
> Built-By: pantinor
> Scm-Connection: scm:git:git://github.com/keycloak/keycloak.git/keycloa
>  k-undertow-adapter
> Specification-Vendor: JBoss by Red Hat
> Os-Arch: amd64
> Specification-Title: Keycloak Undertow Integration
> Implementation-Vendor-Id: org.keycloak
> Java-Vendor: Oracle Corporation
> Os-Name: Linux
> Scm-Url: https://github.com/keycloak/keycloak/tree/master/keycloak-und
>  ertow-adapter/
> Implementation-Vendor: JBoss by Red Hat
> Os-Version: 4.12.14-300.fc26.x86_64
> Scm-Revision: 08d5a7a062fdbf8f2b63ca2a6e14e0fce2d3e3f1
> Created-By: Apache Maven 3.5.0
> Build-Jdk: 1.8.0_144
> Specification-Version: 3.3
> Implementation-URL: http://keycloak.org/keycloak-undertow-adapter
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (KARAF-5421) Better error while installing non OSGi bundles

2023-02-07 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KARAF-5421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17685697#comment-17685697
 ] 

ASF GitHub Bot commented on KARAF-5421:
---

jbonofre commented on PR #1713:
URL: https://github.com/apache/karaf/pull/1713#issuecomment-1422069331

   Did you check if you directly install a blueprint xml ? The blueprint xml 
doesn't contain manifest so I think your change will block it. 




> Better error while installing non OSGi bundles
> --
>
> Key: KARAF-5421
> URL: https://issues.apache.org/jira/browse/KARAF-5421
> Project: Karaf
>  Issue Type: Improvement
>Affects Versions: 4.1.2
>Reporter: Paolo Antinori
>Priority: Major
>
> I understand installing a non OSGi bundle is wrong at a logical level, but 
> the error message when doing so, it's fairly cryptic:
> {code}
> karaf@root()> install mvn:org.keycloak/keycloak-undertow-adapter/3.3.0.CR2
> Bundle IDs: 
> Error executing command: Error installing bundles:
>   Unable to install bundle 
> mvn:org.keycloak/keycloak-undertow-adapter/3.3.0.CR2: 
> org.osgi.framework.BundleException: OSGi R3 bundle not supported
> {code}
> Does it make sense for the error message to suggest checking it's a valid 
> bundle?
> Manifest of the above file is:
> {code}
> 14:21 $ unzip -c  
> ~/.m2/repository/org/keycloak/keycloak-undertow-adapter/3.3.0.CR2/keycloak-undertow-adapter-3.3.0.CR2.jar
>  **MANIFEST.MF
> Archive:  
> /home/pantinor/.m2/repository/org/keycloak/keycloak-undertow-adapter/3.3.0.CR2/keycloak-undertow-adapter-3.3.0.CR2.jar
>   inflating: META-INF/MANIFEST.MF
> Manifest-Version: 1.0
> Implementation-Title: Keycloak Undertow Integration
> Implementation-Version: 3.3.0.CR2
> Java-Version: 1.8.0_144
> Built-By: pantinor
> Scm-Connection: scm:git:git://github.com/keycloak/keycloak.git/keycloa
>  k-undertow-adapter
> Specification-Vendor: JBoss by Red Hat
> Os-Arch: amd64
> Specification-Title: Keycloak Undertow Integration
> Implementation-Vendor-Id: org.keycloak
> Java-Vendor: Oracle Corporation
> Os-Name: Linux
> Scm-Url: https://github.com/keycloak/keycloak/tree/master/keycloak-und
>  ertow-adapter/
> Implementation-Vendor: JBoss by Red Hat
> Os-Version: 4.12.14-300.fc26.x86_64
> Scm-Revision: 08d5a7a062fdbf8f2b63ca2a6e14e0fce2d3e3f1
> Created-By: Apache Maven 3.5.0
> Build-Jdk: 1.8.0_144
> Specification-Version: 3.3
> Implementation-URL: http://keycloak.org/keycloak-undertow-adapter
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (KARAF-6210) NoClassDefFoundError: org/apache/karaf/shell/api/action/Action when starting Karaf

2023-02-07 Thread Amichai Rothman (Jira)


[ 
https://issues.apache.org/jira/browse/KARAF-6210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17685706#comment-17685706
 ] 

Amichai Rothman commented on KARAF-6210:


And the other bundles that get the same exception, like bundle.core or kar or 
others? Are you changing the shell bundle itself to run before all other karaf 
bundles that contain commands?

I have a feeling this may be a viable workaround, but still wont' solve the 
inherent circular dependency of how the mechanism currently works, and the 
issue may return if ever the shell bundle gets refreshed for any reason or 
such... what do you think?

> NoClassDefFoundError: org/apache/karaf/shell/api/action/Action when starting 
> Karaf
> --
>
> Key: KARAF-6210
> URL: https://issues.apache.org/jira/browse/KARAF-6210
> Project: Karaf
>  Issue Type: Bug
>  Components: karaf
>Affects Versions: 4.2.4, 4.3.2
> Environment: Stock Karaf 4.2.4 on Windows 10 with latest Oracle JDK 8.
>Reporter: Amichai Rothman
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Attachments: karaf_command_not_found.log
>
>
> When starting karaf using equinox and some bundle in the deploy folder, many 
> shell commands (such as bundle:* and others) are not recognized, and the log 
> shows NoClassDefFoundError: org/apache/karaf/shell/api/action/Action. Some 
> commands don't work, but others (e.g. shell:*) do.
> This happens consistently on Windows 10, but not on Linux, not sure why.
>  
> Steps to recreate:
> 1. Extract stock Karaf 4.2.4.
> 2. In etc/config.properties change karaf.framework=felix to 
> karaf.framework=equinox.
> 3. Place org.apache.aries.transaction.blueprint-2.2.0.jar (from maven) in 
> deploy folder. This is not the only bundle it happens with, just a public one 
> I found for this example. From several I tried, some recreated the issue and 
> some did not. The bundle is not resolved due to missing dependencies.
> 4. Start Karaf.
> 5. Try to run bundle:list and it'll say command not found. Or look at the 
> karaf log and see "java.lang.NoClassDefFoundError: 
> org/apache/karaf/shell/api/action/Action". Use shell completion to see that 
> some commands are available but others are not.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (KARAF-5421) Better error while installing non OSGi bundles

2023-02-07 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KARAF-5421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17685724#comment-17685724
 ] 

ASF GitHub Bot commented on KARAF-5421:
---

awrb commented on PR #1713:
URL: https://github.com/apache/karaf/pull/1713#issuecomment-1422136798

   Good point @jbonofre, I will check in the evening. If it doesn't work then 
I'll add a test since the current ones did not detect it if it broke. Although 
the previous code looks like it wouldn't work too, because it was either 
manifest version == "2" or exception (unless --r3-bundles is passed).




> Better error while installing non OSGi bundles
> --
>
> Key: KARAF-5421
> URL: https://issues.apache.org/jira/browse/KARAF-5421
> Project: Karaf
>  Issue Type: Improvement
>Affects Versions: 4.1.2
>Reporter: Paolo Antinori
>Priority: Major
>
> I understand installing a non OSGi bundle is wrong at a logical level, but 
> the error message when doing so, it's fairly cryptic:
> {code}
> karaf@root()> install mvn:org.keycloak/keycloak-undertow-adapter/3.3.0.CR2
> Bundle IDs: 
> Error executing command: Error installing bundles:
>   Unable to install bundle 
> mvn:org.keycloak/keycloak-undertow-adapter/3.3.0.CR2: 
> org.osgi.framework.BundleException: OSGi R3 bundle not supported
> {code}
> Does it make sense for the error message to suggest checking it's a valid 
> bundle?
> Manifest of the above file is:
> {code}
> 14:21 $ unzip -c  
> ~/.m2/repository/org/keycloak/keycloak-undertow-adapter/3.3.0.CR2/keycloak-undertow-adapter-3.3.0.CR2.jar
>  **MANIFEST.MF
> Archive:  
> /home/pantinor/.m2/repository/org/keycloak/keycloak-undertow-adapter/3.3.0.CR2/keycloak-undertow-adapter-3.3.0.CR2.jar
>   inflating: META-INF/MANIFEST.MF
> Manifest-Version: 1.0
> Implementation-Title: Keycloak Undertow Integration
> Implementation-Version: 3.3.0.CR2
> Java-Version: 1.8.0_144
> Built-By: pantinor
> Scm-Connection: scm:git:git://github.com/keycloak/keycloak.git/keycloa
>  k-undertow-adapter
> Specification-Vendor: JBoss by Red Hat
> Os-Arch: amd64
> Specification-Title: Keycloak Undertow Integration
> Implementation-Vendor-Id: org.keycloak
> Java-Vendor: Oracle Corporation
> Os-Name: Linux
> Scm-Url: https://github.com/keycloak/keycloak/tree/master/keycloak-und
>  ertow-adapter/
> Implementation-Vendor: JBoss by Red Hat
> Os-Version: 4.12.14-300.fc26.x86_64
> Scm-Revision: 08d5a7a062fdbf8f2b63ca2a6e14e0fce2d3e3f1
> Created-By: Apache Maven 3.5.0
> Build-Jdk: 1.8.0_144
> Specification-Version: 3.3
> Implementation-URL: http://keycloak.org/keycloak-undertow-adapter
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (KARAF-5421) Better error while installing non OSGi bundles

2023-02-07 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KARAF-5421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17685728#comment-17685728
 ] 

ASF GitHub Bot commented on KARAF-5421:
---

jbonofre commented on PR #1713:
URL: https://github.com/apache/karaf/pull/1713#issuecomment-1422146917

   Yes I think blueprint installer is creating a bundle on the fly. So that's 
why it works. 




> Better error while installing non OSGi bundles
> --
>
> Key: KARAF-5421
> URL: https://issues.apache.org/jira/browse/KARAF-5421
> Project: Karaf
>  Issue Type: Improvement
>Affects Versions: 4.1.2
>Reporter: Paolo Antinori
>Priority: Major
>
> I understand installing a non OSGi bundle is wrong at a logical level, but 
> the error message when doing so, it's fairly cryptic:
> {code}
> karaf@root()> install mvn:org.keycloak/keycloak-undertow-adapter/3.3.0.CR2
> Bundle IDs: 
> Error executing command: Error installing bundles:
>   Unable to install bundle 
> mvn:org.keycloak/keycloak-undertow-adapter/3.3.0.CR2: 
> org.osgi.framework.BundleException: OSGi R3 bundle not supported
> {code}
> Does it make sense for the error message to suggest checking it's a valid 
> bundle?
> Manifest of the above file is:
> {code}
> 14:21 $ unzip -c  
> ~/.m2/repository/org/keycloak/keycloak-undertow-adapter/3.3.0.CR2/keycloak-undertow-adapter-3.3.0.CR2.jar
>  **MANIFEST.MF
> Archive:  
> /home/pantinor/.m2/repository/org/keycloak/keycloak-undertow-adapter/3.3.0.CR2/keycloak-undertow-adapter-3.3.0.CR2.jar
>   inflating: META-INF/MANIFEST.MF
> Manifest-Version: 1.0
> Implementation-Title: Keycloak Undertow Integration
> Implementation-Version: 3.3.0.CR2
> Java-Version: 1.8.0_144
> Built-By: pantinor
> Scm-Connection: scm:git:git://github.com/keycloak/keycloak.git/keycloa
>  k-undertow-adapter
> Specification-Vendor: JBoss by Red Hat
> Os-Arch: amd64
> Specification-Title: Keycloak Undertow Integration
> Implementation-Vendor-Id: org.keycloak
> Java-Vendor: Oracle Corporation
> Os-Name: Linux
> Scm-Url: https://github.com/keycloak/keycloak/tree/master/keycloak-und
>  ertow-adapter/
> Implementation-Vendor: JBoss by Red Hat
> Os-Version: 4.12.14-300.fc26.x86_64
> Scm-Revision: 08d5a7a062fdbf8f2b63ca2a6e14e0fce2d3e3f1
> Created-By: Apache Maven 3.5.0
> Build-Jdk: 1.8.0_144
> Specification-Version: 3.3
> Implementation-URL: http://keycloak.org/keycloak-undertow-adapter
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (KARAF-5421) Better error while installing non OSGi bundles

2023-02-07 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KARAF-5421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17685729#comment-17685729
 ] 

ASF GitHub Bot commented on KARAF-5421:
---

awrb commented on code in PR #1713:
URL: https://github.com/apache/karaf/pull/1713#discussion_r1099753821


##
bundle/core/src/main/java/org/apache/karaf/bundle/command/Install.java:
##
@@ -82,15 +82,26 @@ public Object execute() throws Exception {
 for (URI url : urls) {
 try {
 Bundle bundle = bundleContext.installBundle(url.toString(), 
null);
-if 
(!"2".equals(bundle.getHeaders().get(Constants.BUNDLE_MANIFESTVERSION))) {
+String manifestVersion = 
bundle.getHeaders().get(Constants.BUNDLE_MANIFESTVERSION);
+
+if (!"2".equals(manifestVersion)) {
 if (allowR3) {
 if (!r3warned) {
 System.err.println("WARNING: use of OSGi r3 
bundles is discouraged");
 r3warned = true;
 }
 } else {
+String error;
+if (manifestVersion == null) {

Review Comment:
   Actually this needs to be checked independently of `allowR3` because with 
--allowR3 this will let non-OSGi bundles through.





> Better error while installing non OSGi bundles
> --
>
> Key: KARAF-5421
> URL: https://issues.apache.org/jira/browse/KARAF-5421
> Project: Karaf
>  Issue Type: Improvement
>Affects Versions: 4.1.2
>Reporter: Paolo Antinori
>Priority: Major
>
> I understand installing a non OSGi bundle is wrong at a logical level, but 
> the error message when doing so, it's fairly cryptic:
> {code}
> karaf@root()> install mvn:org.keycloak/keycloak-undertow-adapter/3.3.0.CR2
> Bundle IDs: 
> Error executing command: Error installing bundles:
>   Unable to install bundle 
> mvn:org.keycloak/keycloak-undertow-adapter/3.3.0.CR2: 
> org.osgi.framework.BundleException: OSGi R3 bundle not supported
> {code}
> Does it make sense for the error message to suggest checking it's a valid 
> bundle?
> Manifest of the above file is:
> {code}
> 14:21 $ unzip -c  
> ~/.m2/repository/org/keycloak/keycloak-undertow-adapter/3.3.0.CR2/keycloak-undertow-adapter-3.3.0.CR2.jar
>  **MANIFEST.MF
> Archive:  
> /home/pantinor/.m2/repository/org/keycloak/keycloak-undertow-adapter/3.3.0.CR2/keycloak-undertow-adapter-3.3.0.CR2.jar
>   inflating: META-INF/MANIFEST.MF
> Manifest-Version: 1.0
> Implementation-Title: Keycloak Undertow Integration
> Implementation-Version: 3.3.0.CR2
> Java-Version: 1.8.0_144
> Built-By: pantinor
> Scm-Connection: scm:git:git://github.com/keycloak/keycloak.git/keycloa
>  k-undertow-adapter
> Specification-Vendor: JBoss by Red Hat
> Os-Arch: amd64
> Specification-Title: Keycloak Undertow Integration
> Implementation-Vendor-Id: org.keycloak
> Java-Vendor: Oracle Corporation
> Os-Name: Linux
> Scm-Url: https://github.com/keycloak/keycloak/tree/master/keycloak-und
>  ertow-adapter/
> Implementation-Vendor: JBoss by Red Hat
> Os-Version: 4.12.14-300.fc26.x86_64
> Scm-Revision: 08d5a7a062fdbf8f2b63ca2a6e14e0fce2d3e3f1
> Created-By: Apache Maven 3.5.0
> Build-Jdk: 1.8.0_144
> Specification-Version: 3.3
> Implementation-URL: http://keycloak.org/keycloak-undertow-adapter
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (KARAF-5421) Better error while installing non OSGi bundles

2023-02-07 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KARAF-5421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17685731#comment-17685731
 ] 

ASF GitHub Bot commented on KARAF-5421:
---

awrb commented on PR #1713:
URL: https://github.com/apache/karaf/pull/1713#issuecomment-1422155593

   > Yes I think blueprint installer is creating a bundle on the fly. So that's 
why it works.
   
   The docs say it does 
https://karaf.apache.org/manual/latest/#_blueprint_deployer
   ```
   The generated OSGi MANIFEST will contain the following headers:
   
   Manifest-Version: 2
   Bundle-SymbolicName: [name of the file]
   Bundle-Version: [version of the file]
   Import-Package: [required packages]
   DynamicImport-Package: *
   ```
   but I am not sure when this happens compared to bundle:install.




> Better error while installing non OSGi bundles
> --
>
> Key: KARAF-5421
> URL: https://issues.apache.org/jira/browse/KARAF-5421
> Project: Karaf
>  Issue Type: Improvement
>Affects Versions: 4.1.2
>Reporter: Paolo Antinori
>Priority: Major
>
> I understand installing a non OSGi bundle is wrong at a logical level, but 
> the error message when doing so, it's fairly cryptic:
> {code}
> karaf@root()> install mvn:org.keycloak/keycloak-undertow-adapter/3.3.0.CR2
> Bundle IDs: 
> Error executing command: Error installing bundles:
>   Unable to install bundle 
> mvn:org.keycloak/keycloak-undertow-adapter/3.3.0.CR2: 
> org.osgi.framework.BundleException: OSGi R3 bundle not supported
> {code}
> Does it make sense for the error message to suggest checking it's a valid 
> bundle?
> Manifest of the above file is:
> {code}
> 14:21 $ unzip -c  
> ~/.m2/repository/org/keycloak/keycloak-undertow-adapter/3.3.0.CR2/keycloak-undertow-adapter-3.3.0.CR2.jar
>  **MANIFEST.MF
> Archive:  
> /home/pantinor/.m2/repository/org/keycloak/keycloak-undertow-adapter/3.3.0.CR2/keycloak-undertow-adapter-3.3.0.CR2.jar
>   inflating: META-INF/MANIFEST.MF
> Manifest-Version: 1.0
> Implementation-Title: Keycloak Undertow Integration
> Implementation-Version: 3.3.0.CR2
> Java-Version: 1.8.0_144
> Built-By: pantinor
> Scm-Connection: scm:git:git://github.com/keycloak/keycloak.git/keycloa
>  k-undertow-adapter
> Specification-Vendor: JBoss by Red Hat
> Os-Arch: amd64
> Specification-Title: Keycloak Undertow Integration
> Implementation-Vendor-Id: org.keycloak
> Java-Vendor: Oracle Corporation
> Os-Name: Linux
> Scm-Url: https://github.com/keycloak/keycloak/tree/master/keycloak-und
>  ertow-adapter/
> Implementation-Vendor: JBoss by Red Hat
> Os-Version: 4.12.14-300.fc26.x86_64
> Scm-Revision: 08d5a7a062fdbf8f2b63ca2a6e14e0fce2d3e3f1
> Created-By: Apache Maven 3.5.0
> Build-Jdk: 1.8.0_144
> Specification-Version: 3.3
> Implementation-URL: http://keycloak.org/keycloak-undertow-adapter
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)