[jira] [Comment Edited] (KARAF-1583) karaf-maven-plugin ignores dependency on feature

[Gary Kennedy (JIRA)]

[ 
https://issues.apache.org/jira/browse/KARAF-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14173177#comment-14173177
 ] 

Gary Kennedy edited comment on KARAF-1583 at 10/16/14 12:23 AM:


+1
This would be a much better idea than having the plugin handle/aggregate 
{{repository}} tags (which I don't think 3.0.1 does).

At the moment we are using maven project properties to handle GAV across the 
project pom and the feature file. This will certainly make things a bit more 
tidy and robust.



was (Author: gktheone):
+1
This would be a much better idea than having the plugin handle/aggregate 
{code}repository{code} tags (which I don't think 3.0.1 does).

At the moment we are using maven project properties to handle GAV across the 
project pom and the feature file. This will certainly make things a bit more 
tidy and robust.


 karaf-maven-plugin ignores dependency on feature
 

 Key: KARAF-1583
 URL: https://issues.apache.org/jira/browse/KARAF-1583
 Project: Karaf
  Issue Type: Bug
  Components: karaf-tooling
Affects Versions: 3.0.0.RC1
Reporter: Brian Topping
Assignee: Jean-Baptiste Onofré
 Fix For: 4.0.0, 3.0.3


 When a project has a dependency on a feature, the dependency should be 
 rendered in the features.xml generated by 
 {{karaf-maven-plugin:features-generate-descriptor}} as a {{repository}} 
 element.  
 I thought I added this, but it must have gotten lost in the patches and will 
 submit another patch after KARAF-1537 is applied.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (KARAF-3263) karaf-maven-plugin install=auto support for aggregate features

[Gary Kennedy (JIRA)]

Gary Kennedy created KARAF-3263:
---

 Summary: karaf-maven-plugin install=auto support for aggregate 
features
 Key: KARAF-3263
 URL: https://issues.apache.org/jira/browse/KARAF-3263
 Project: Karaf
  Issue Type: Improvement
  Components: karaf-tooling
Affects Versions: 3.0.1
Reporter: Gary Kennedy
Priority: Minor


When using karaf-maven-plugin:features-generate-descriptor, the generated 
feature tags for xml/feature dependencies are not merged with the feature.xml 
template so I cannot add install=auto to the feature tag.

eg,
POM:
{code}
...
packagingfeature/packaging
...
dependencies
dependency

artifactIdfeatureA/artifactId
typexml/type
classifierfeatures/classifier
/dependency
/dependencies
...
build
plugins
plugin
groupIdorg.apache.karaf.tooling/groupId
artifactIdkaraf-maven-plugin/artifactId
version3.0.1/version
extensionstrue/extensions
configuration
aggregateFeaturestrue/aggregateFeatures
/configuration
/plugins
/plugins
/build
{code}

feature.xml template (src/main/feature/feature.xml):
{code}
?xml ...
features ...
feature name=featureA install=auto /
/features
{code}

results in:
{code}
?xml ...
features ...
feature name=featureA install=auto /
feature name=featureA version=... description=...
!-- Generated descriptor --
/feature
/features
{code}

Since this is for generating an application feature from individual 
component features, and none of the component features are auto-install in 
one application and no-auto-install in another, I can work around this by 
specifying the install attribute in the component feature.xml.

So, would it be possible to merge aggregated features with the feature 
template? (eg, matching on name and only overriding the feature tag attributes 
except for version, so only install/description/resolver/start-level. Contents 
to be replaced with dependency feature content - we don't want to mess with 
those)




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)