[jira] [Commented] (KARAF-2307) ActiveMQ Karaf commands do not work with Karaf 3
[ https://issues.apache.org/jira/browse/KARAF-2307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13845376#comment-13845376 ] Jean-Baptiste Onofré commented on KARAF-2307: - Now, ActiveMQ 5.10-SNAPSHOT (next 5.9.1 and 5.10) works fine on Karaf 3.0.0 (including the completer). The problem was on the service guard. I'm working on an enhancement on the completer to manager the proxy guard. ActiveMQ Karaf commands do not work with Karaf 3 Key: KARAF-2307 URL: https://issues.apache.org/jira/browse/KARAF-2307 Project: Karaf Issue Type: Bug Components: karaf-shell Affects Versions: 3.0.0.RC1 Reporter: Christian Schneider Assignee: Jean-Baptiste Onofré Fix For: 3.0.0 Attachments: amq-4492.patch The ActiveMQ Karaf commands import the package org.apache.felix.gogo.commands.basic which was exported by karaf shell before version 3. I first tried to change the activemq commands like we did for cxf and camel. The problem is that the activemq commands are quite generic as they simply map the activemq console commands. So they really need the package above. So my aproach is to create the package in karaf shell with deperecated classes extending the new classes. So this should provide the necessary compat layer. There classes can be removed once all commands are switched to pure karaf 3. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (KARAF-2307) ActiveMQ Karaf commands do not work with Karaf 3
[ https://issues.apache.org/jira/browse/KARAF-2307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13844342#comment-13844342 ] Jean-Baptiste Onofré commented on KARAF-2307: - Now, the ActiveMQ commands work: karaf@root() activemq:list karaf@root() activemq:list brokerName = amq-broker I gonna fix: - activemq subshell is not there, and the activemq:* commands are not in CommandsCompleter - activemq:bstat command doesn't work due the JMX ACL on the uptime attribute (I gonna provision a jmx.acl file by the ActiveMQ feature) ActiveMQ Karaf commands do not work with Karaf 3 Key: KARAF-2307 URL: https://issues.apache.org/jira/browse/KARAF-2307 Project: Karaf Issue Type: Bug Components: karaf-shell Affects Versions: 3.0.0.RC1 Reporter: Christian Schneider Assignee: Jean-Baptiste Onofré Fix For: 3.0.0 Attachments: amq-4492.patch The ActiveMQ Karaf commands import the package org.apache.felix.gogo.commands.basic which was exported by karaf shell before version 3. I first tried to change the activemq commands like we did for cxf and camel. The problem is that the activemq commands are quite generic as they simply map the activemq console commands. So they really need the package above. So my aproach is to create the package in karaf shell with deperecated classes extending the new classes. So this should provide the necessary compat layer. There classes can be removed once all commands are switched to pure karaf 3. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (KARAF-2307) ActiveMQ Karaf commands do not work with Karaf 3
[ https://issues.apache.org/jira/browse/KARAF-2307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13844431#comment-13844431 ] Jean-Baptiste Onofré commented on KARAF-2307: - I added dual export version of the console package. I tested ActiveMQ 5.7.0, and it works fine (deployment OK, just some commands are not visible, I gonna check why). ActiveMQ Karaf commands do not work with Karaf 3 Key: KARAF-2307 URL: https://issues.apache.org/jira/browse/KARAF-2307 Project: Karaf Issue Type: Bug Components: karaf-shell Affects Versions: 3.0.0.RC1 Reporter: Christian Schneider Assignee: Jean-Baptiste Onofré Fix For: 3.0.0 Attachments: amq-4492.patch The ActiveMQ Karaf commands import the package org.apache.felix.gogo.commands.basic which was exported by karaf shell before version 3. I first tried to change the activemq commands like we did for cxf and camel. The problem is that the activemq commands are quite generic as they simply map the activemq console commands. So they really need the package above. So my aproach is to create the package in karaf shell with deperecated classes extending the new classes. So this should provide the necessary compat layer. There classes can be removed once all commands are switched to pure karaf 3. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (KARAF-2307) ActiveMQ Karaf commands do not work with Karaf 3
[ https://issues.apache.org/jira/browse/KARAF-2307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13843119#comment-13843119 ] Jean-Baptiste Onofré commented on KARAF-2307: - I fixed the issues in ActiveMQ (I gonna submit a new patch very soon). The other part is in the addition of the compatibility bundle in Karaf (KARAF-2606). ActiveMQ Karaf commands do not work with Karaf 3 Key: KARAF-2307 URL: https://issues.apache.org/jira/browse/KARAF-2307 Project: Karaf Issue Type: Bug Components: karaf-shell Affects Versions: 3.0.0.RC1 Reporter: Christian Schneider Assignee: Jean-Baptiste Onofré Fix For: 3.0.0 Attachments: amq-4492.patch The ActiveMQ Karaf commands import the package org.apache.felix.gogo.commands.basic which was exported by karaf shell before version 3. I first tried to change the activemq commands like we did for cxf and camel. The problem is that the activemq commands are quite generic as they simply map the activemq console commands. So they really need the package above. So my aproach is to create the package in karaf shell with deperecated classes extending the new classes. So this should provide the necessary compat layer. There classes can be removed once all commands are switched to pure karaf 3. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (KARAF-2307) ActiveMQ Karaf commands do not work with Karaf 3
[ https://issues.apache.org/jira/browse/KARAF-2307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13822243#comment-13822243 ] Christian Schneider commented on KARAF-2307: I now committed a patch that contains the classes and interfaces at the old location. ActiveMQ karaf still has the wrong import range for the unchanged parts of the api (org.apache.karaf.shell.console) though. We now can either open up the import range for activemq-karaf to include the 3.x versions of the package or we have to export the package in a 2.x version. I have tested a patched version of activemq-karaf where I opened the import ranges to [2.3,4). After this change the activemq feature loads but the commands still do not work. [~jbonofre] could you have a look at this. I think we are not too far from a solution. ActiveMQ Karaf commands do not work with Karaf 3 Key: KARAF-2307 URL: https://issues.apache.org/jira/browse/KARAF-2307 Project: Karaf Issue Type: Bug Components: karaf-shell Affects Versions: 3.0.0.RC1 Reporter: Christian Schneider Assignee: Christian Schneider Fix For: 3.0.0 Attachments: amq-4492.patch The ActiveMQ Karaf commands import the package org.apache.felix.gogo.commands.basic which was exported by karaf shell before version 3. I first tried to change the activemq commands like we did for cxf and camel. The problem is that the activemq commands are quite generic as they simply map the activemq console commands. So they really need the package above. So my aproach is to create the package in karaf shell with deperecated classes extending the new classes. So this should provide the necessary compat layer. There classes can be removed once all commands are switched to pure karaf 3. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (KARAF-2307) ActiveMQ Karaf commands do not work with Karaf 3
[ https://issues.apache.org/jira/browse/KARAF-2307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13822247#comment-13822247 ] Achim Nierbeck commented on KARAF-2307: --- I think we're safe to export old API in an old version ActiveMQ Karaf commands do not work with Karaf 3 Key: KARAF-2307 URL: https://issues.apache.org/jira/browse/KARAF-2307 Project: Karaf Issue Type: Bug Components: karaf-shell Affects Versions: 3.0.0.RC1 Reporter: Christian Schneider Assignee: Christian Schneider Fix For: 3.0.0 Attachments: amq-4492.patch The ActiveMQ Karaf commands import the package org.apache.felix.gogo.commands.basic which was exported by karaf shell before version 3. I first tried to change the activemq commands like we did for cxf and camel. The problem is that the activemq commands are quite generic as they simply map the activemq console commands. So they really need the package above. So my aproach is to create the package in karaf shell with deperecated classes extending the new classes. So this should provide the necessary compat layer. There classes can be removed once all commands are switched to pure karaf 3. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (KARAF-2307) ActiveMQ Karaf commands do not work with Karaf 3
[ https://issues.apache.org/jira/browse/KARAF-2307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13649810#comment-13649810 ] Christian Schneider commented on KARAF-2307: Unfortunately there is also a problem with the import range of org.apache.karaf.shell.console in the karaf commands. So we will have to still adjust the command bundle. ActiveMQ Karaf commands do not work with Karaf 3 Key: KARAF-2307 URL: https://issues.apache.org/jira/browse/KARAF-2307 Project: Karaf Issue Type: Bug Components: karaf-shell Affects Versions: 3.0.0.RC1 Reporter: Christian Schneider Assignee: Christian Schneider Fix For: 3.0.0 The ActiveMQ Karaf commands import the package org.apache.felix.gogo.commands.basic which was exported by karaf shell before version 3. I first tried to change the activemq commands like we did for cxf and camel. The problem is that the activemq commands are quite generic as they simply map the activemq console commands. So they really need the package above. So my aproach is to create the package in karaf shell with deperecated classes extending the new classes. So this should provide the necessary compat layer. There classes can be removed once all commands are switched to pure karaf 3. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KARAF-2307) ActiveMQ Karaf commands do not work with Karaf 3
[ https://issues.apache.org/jira/browse/KARAF-2307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13649817#comment-13649817 ] Jean-Baptiste Onofré commented on KARAF-2307: - To be honest, I don't like this solution: it's not the same sense at all. 1/ we go back to gogo dependencies (which is limited and not good) 2/ we invite the legacy projects to upgrade to that. Transition packages don't make sense as Karaf 2.3 and 2.4 are made for transition ! ActiveMQ Karaf commands do not work with Karaf 3 Key: KARAF-2307 URL: https://issues.apache.org/jira/browse/KARAF-2307 Project: Karaf Issue Type: Bug Components: karaf-shell Affects Versions: 3.0.0.RC1 Reporter: Christian Schneider Assignee: Christian Schneider Fix For: 3.0.0 The ActiveMQ Karaf commands import the package org.apache.felix.gogo.commands.basic which was exported by karaf shell before version 3. I first tried to change the activemq commands like we did for cxf and camel. The problem is that the activemq commands are quite generic as they simply map the activemq console commands. So they really need the package above. So my aproach is to create the package in karaf shell with deperecated classes extending the new classes. So this should provide the necessary compat layer. There classes can be removed once all commands are switched to pure karaf 3. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KARAF-2307) ActiveMQ Karaf commands do not work with Karaf 3
[ https://issues.apache.org/jira/browse/KARAF-2307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13649825#comment-13649825 ] Christian Schneider commented on KARAF-2307: If you have a better solution please go ahead. I think it makes sense as there should always be a version where you can use the old and new api as this allows a transition period for the projects. An alternative solution is to copy the classes from commands.basic into a package in activemq-karaf. This would involve a lot of duplicate code though. ActiveMQ Karaf commands do not work with Karaf 3 Key: KARAF-2307 URL: https://issues.apache.org/jira/browse/KARAF-2307 Project: Karaf Issue Type: Bug Components: karaf-shell Affects Versions: 3.0.0.RC1 Reporter: Christian Schneider Assignee: Christian Schneider Fix For: 3.0.0 The ActiveMQ Karaf commands import the package org.apache.felix.gogo.commands.basic which was exported by karaf shell before version 3. I first tried to change the activemq commands like we did for cxf and camel. The problem is that the activemq commands are quite generic as they simply map the activemq console commands. So they really need the package above. So my aproach is to create the package in karaf shell with deperecated classes extending the new classes. So this should provide the necessary compat layer. There classes can be removed once all commands are switched to pure karaf 3. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KARAF-2307) ActiveMQ Karaf commands do not work with Karaf 3
[ https://issues.apache.org/jira/browse/KARAF-2307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13649829#comment-13649829 ] Jean-Baptiste Onofré commented on KARAF-2307: - Agree, but why not providing the dual packages in 2.3 or 2.4 ? ActiveMQ Karaf commands do not work with Karaf 3 Key: KARAF-2307 URL: https://issues.apache.org/jira/browse/KARAF-2307 Project: Karaf Issue Type: Bug Components: karaf-shell Affects Versions: 3.0.0.RC1 Reporter: Christian Schneider Assignee: Christian Schneider Fix For: 3.0.0 Attachments: amq-4492.patch The ActiveMQ Karaf commands import the package org.apache.felix.gogo.commands.basic which was exported by karaf shell before version 3. I first tried to change the activemq commands like we did for cxf and camel. The problem is that the activemq commands are quite generic as they simply map the activemq console commands. So they really need the package above. So my aproach is to create the package in karaf shell with deperecated classes extending the new classes. So this should provide the necessary compat layer. There classes can be removed once all commands are switched to pure karaf 3. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KARAF-2307) ActiveMQ Karaf commands do not work with Karaf 3
[ https://issues.apache.org/jira/browse/KARAF-2307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13649834#comment-13649834 ] Christian Schneider commented on KARAF-2307: That should work. The only downside is that as soon as activemq switched it will not work with older karaf 2.x versions ActiveMQ Karaf commands do not work with Karaf 3 Key: KARAF-2307 URL: https://issues.apache.org/jira/browse/KARAF-2307 Project: Karaf Issue Type: Bug Components: karaf-shell Affects Versions: 3.0.0.RC1 Reporter: Christian Schneider Assignee: Christian Schneider Fix For: 3.0.0 Attachments: amq-4492.patch The ActiveMQ Karaf commands import the package org.apache.felix.gogo.commands.basic which was exported by karaf shell before version 3. I first tried to change the activemq commands like we did for cxf and camel. The problem is that the activemq commands are quite generic as they simply map the activemq console commands. So they really need the package above. So my aproach is to create the package in karaf shell with deperecated classes extending the new classes. So this should provide the necessary compat layer. There classes can be removed once all commands are switched to pure karaf 3. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
