[jira] [Commented] (KARAF-4666) Have karaf write pid file by default

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/KARAF-4666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15439371#comment-15439371
 ] 

ASF GitHub Bot commented on KARAF-4666:
---

Github user lburgazzoli closed the pull request at:

https://github.com/apache/karaf/pull/230


> Have karaf write pid file by default
> 
>
> Key: KARAF-4666
> URL: https://issues.apache.org/jira/browse/KARAF-4666
> Project: Karaf
>  Issue Type: Improvement
>  Components: karaf-core
>Reporter: Luca Burgazzoli
>Assignee: Jean-Baptiste Onofré
>Priority: Minor
>
>  As today karaf would write the pid file only if karaf.shutdown.pid.file is 
> defined but it would be nice to have a pid file always written.
> So I will open a PR with:
> - karaf.shutdown.pid.file renamed to karaf.pid.file
> - set default value to ${karaf.base}/karaf.pid



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (KARAF-4666) Have karaf write pid file by default

[JIRA]

[ 
https://issues.apache.org/jira/browse/KARAF-4666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15438836#comment-15438836
 ] 

Jean-Baptiste Onofré commented on KARAF-4666:
-

+1

> Have karaf write pid file by default
> 
>
> Key: KARAF-4666
> URL: https://issues.apache.org/jira/browse/KARAF-4666
> Project: Karaf
>  Issue Type: Improvement
>  Components: karaf-core
>Reporter: Luca Burgazzoli
>Assignee: Jean-Baptiste Onofré
>Priority: Minor
>
>  As today karaf would write the pid file only if karaf.shutdown.pid.file is 
> defined but it would be nice to have a pid file always written.
> So I will open a PR with:
> - karaf.shutdown.pid.file renamed to karaf.pid.file
> - set default value to ${karaf.base}/karaf.pid



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (KARAF-4666) Have karaf write pid file by default

[Guillaume Nodet (JIRA)]

[ 
https://issues.apache.org/jira/browse/KARAF-4666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15438828#comment-15438828
 ] 

Guillaume Nodet commented on KARAF-4666:


Sounds good to me.

> Have karaf write pid file by default
> 
>
> Key: KARAF-4666
> URL: https://issues.apache.org/jira/browse/KARAF-4666
> Project: Karaf
>  Issue Type: Improvement
>  Components: karaf-core
>Reporter: Luca Burgazzoli
>Assignee: Jean-Baptiste Onofré
>Priority: Minor
>
>  As today karaf would write the pid file only if karaf.shutdown.pid.file is 
> defined but it would be nice to have a pid file always written.
> So I will open a PR with:
> - karaf.shutdown.pid.file renamed to karaf.pid.file
> - set default value to ${karaf.base}/karaf.pid



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (KARAF-4666) Have karaf write pid file by default

[Luca Burgazzoli (JIRA)]

[ 
https://issues.apache.org/jira/browse/KARAF-4666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15438785#comment-15438785
 ] 

Luca Burgazzoli commented on KARAF-4666:


+1 for compatibility.

I wanted to avoid having "shutdown" if possible just because it may be 
confusing as my main reason to have the pid file written by default if to 
improve integration with init systems and it may not the best to say:

{code}
To use the system init scripts, please activate the shutdown pid
{code}

I would say:
- 4.1.x -> rename karaf.shutdown.pid.file to karaf.pid.file + backward 
compatibility
- 4.0.x -> make karaf.shutdown.pid.file active by default

Make sense ?



> Have karaf write pid file by default
> 
>
> Key: KARAF-4666
> URL: https://issues.apache.org/jira/browse/KARAF-4666
> Project: Karaf
>  Issue Type: Improvement
>  Components: karaf-core
>Reporter: Luca Burgazzoli
>Assignee: Jean-Baptiste Onofré
>Priority: Minor
>
>  As today karaf would write the pid file only if karaf.shutdown.pid.file is 
> defined but it would be nice to have a pid file always written.
> So I will open a PR with:
> - karaf.shutdown.pid.file renamed to karaf.pid.file
> - set default value to ${karaf.base}/karaf.pid



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (KARAF-4666) Have karaf write pid file by default

[JIRA]

[ 
https://issues.apache.org/jira/browse/KARAF-4666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15438756#comment-15438756
 ] 

Jean-Baptiste Onofré commented on KARAF-4666:
-

Agee with [~gnt]. On the other hand, I'm also fixing the wrapper pid file. I 
started to improve stop and instance to leverage PID.

> Have karaf write pid file by default
> 
>
> Key: KARAF-4666
> URL: https://issues.apache.org/jira/browse/KARAF-4666
> Project: Karaf
>  Issue Type: Improvement
>  Components: karaf-core
>Reporter: Luca Burgazzoli
>Assignee: Jean-Baptiste Onofré
>Priority: Minor
>
>  As today karaf would write the pid file only if karaf.shutdown.pid.file is 
> defined but it would be nice to have a pid file always written.
> So I will open a PR with:
> - karaf.shutdown.pid.file renamed to karaf.pid.file
> - set default value to ${karaf.base}/karaf.pid



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (KARAF-4666) Have karaf write pid file by default

[Guillaume Nodet (JIRA)]

[ 
https://issues.apache.org/jira/browse/KARAF-4666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15438743#comment-15438743
 ] 

Guillaume Nodet commented on KARAF-4666:


You're right, but I want to make sure there's no conflict in the file names.
There's a suggestion to move the wrapper pid file into KARAF_BASE too.

Also, I wonder if we should improve {{bin/stop}} to leverage the pid to call 
{{kill [pid]}}, especially if the shutdown port has been disabled, see 
KARAF-3825.

> Have karaf write pid file by default
> 
>
> Key: KARAF-4666
> URL: https://issues.apache.org/jira/browse/KARAF-4666
> Project: Karaf
>  Issue Type: Improvement
>  Components: karaf-core
>Reporter: Luca Burgazzoli
>Priority: Minor
>
>  As today karaf would write the pid file only if karaf.shutdown.pid.file is 
> defined but it would be nice to have a pid file always written.
> So I will open a PR with:
> - karaf.shutdown.pid.file renamed to karaf.pid.file
> - set default value to ${karaf.base}/karaf.pid



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (KARAF-4666) Have karaf write pid file by default

[Luca Burgazzoli (JIRA)]

[ 
https://issues.apache.org/jira/browse/KARAF-4666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15437240#comment-15437240
 ] 

Luca Burgazzoli commented on KARAF-4666:


At the moment there's no default file name nor location, isn't KARAF-4260  
about the pid file generated by the wrapper ?

> Have karaf write pid file by default
> 
>
> Key: KARAF-4666
> URL: https://issues.apache.org/jira/browse/KARAF-4666
> Project: Karaf
>  Issue Type: Improvement
>  Components: karaf-core
>Reporter: Luca Burgazzoli
>Priority: Minor
>
>  As today karaf would write the pid file only if karaf.shutdown.pid.file is 
> defined but it would be nice to have a pid file always written.
> So I will open a PR with:
> - karaf.shutdown.pid.file renamed to karaf.pid.file
> - set default value to ${karaf.base}/karaf.pid



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (KARAF-4666) Have karaf write pid file by default

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/KARAF-4666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15437213#comment-15437213
 ] 

ASF GitHub Bot commented on KARAF-4666:
---

GitHub user lburgazzoli opened a pull request:

https://github.com/apache/karaf/pull/230

KARAF-4666: Have karaf write pid file by default



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/lburgazzoli/apache-karaf KARAF-4666

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/karaf/pull/230.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #230


commit abc28dc9fb52877d2548ce78234a2400ba2a55af
Author: lburgazzoli 
Date:   2016-08-25T16:37:24Z

KARAF-4666: Have karaf write pid file by default




> Have karaf write pid file by default
> 
>
> Key: KARAF-4666
> URL: https://issues.apache.org/jira/browse/KARAF-4666
> Project: Karaf
>  Issue Type: Improvement
>  Components: karaf-core
>Reporter: Luca Burgazzoli
>Priority: Minor
>
>  As today karaf would write the pid file only if karaf.shutdown.pid.file is 
> defined but it would be nice to have a pid file always written.
> So I will open a PR with:
> - karaf.shutdown.pid.file renamed to karaf.pid.file
> - set default value to ${karaf.base}/karaf.pid



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (KARAF-4666) Have karaf write pid file by default

[Guillaume Nodet (JIRA)]

[ 
https://issues.apache.org/jira/browse/KARAF-4666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15437205#comment-15437205
 ] 

Guillaume Nodet commented on KARAF-4666:


If we were to rename the file, that would be only for 4.1 ...

> Have karaf write pid file by default
> 
>
> Key: KARAF-4666
> URL: https://issues.apache.org/jira/browse/KARAF-4666
> Project: Karaf
>  Issue Type: Improvement
>  Components: karaf-core
>Reporter: Luca Burgazzoli
>Priority: Minor
>
>  As today karaf would write the pid file only if karaf.shutdown.pid.file is 
> defined but it would be nice to have a pid file always written.
> So I will open a PR with:
> - karaf.shutdown.pid.file renamed to karaf.pid.file
> - set default value to ${karaf.base}/karaf.pid



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)