[jira] [Commented] (KARAF-5316) Jaas Encryption should be easier to use
[ https://issues.apache.org/jira/browse/KARAF-5316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136892#comment-16136892 ] ASF subversion and git services commented on KARAF-5316: Commit d6edb10e0cf65f1d9eafb98154add8f007f70653 in karaf's branch refs/heads/master from [~ch...@die-schneider.net] [ https://git-wip-us.apache.org/repos/asf?p=karaf.git;h=d6edb10 ] [KARAF-5316] Make EncryptionSupport easier to use > Jaas Encryption should be easier to use > --- > > Key: KARAF-5316 > URL: https://issues.apache.org/jira/browse/KARAF-5316 > Project: Karaf > Issue Type: Improvement > Components: karaf-core >Affects Versions: 4.2.0 >Reporter: Christian Schneider >Assignee: Christian Schneider > Fix For: 4.2.0 > > > Currently the EncryptionSupport is difficult to use. Each module needs to > check the presence of EncryptionSupport and an Encryption module and also > check the prefixes and suffixes. > I propose to have one method exposed by the EncryptionSupport: > String encrypt(String plain) > This method checks if plain is already encrypted and encrypts with the > selected Encryption. It also handles the !enabled or no suitable > EncryptionSupport case. > Besides that I propose a public static EncryptionSupport > noEncryptionSupport() that can be called instead of setting the > encryptionSupport=null in modules. This allows to leave out null checks. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KARAF-5316) Jaas Encryption should be easier to use
[ https://issues.apache.org/jira/browse/KARAF-5316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136861#comment-16136861 ] Christian Schneider commented on KARAF-5316: I will leave the current public methods of EncryptionSupport as deprecated so current modules outside of karaf still work. > Jaas Encryption should be easier to use > --- > > Key: KARAF-5316 > URL: https://issues.apache.org/jira/browse/KARAF-5316 > Project: Karaf > Issue Type: Improvement > Components: karaf-core >Affects Versions: 4.2.0 >Reporter: Christian Schneider >Assignee: Christian Schneider > Fix For: 4.2.0 > > > Currently the EncryptionSupport is difficult to use. Each module needs to > check the presence of EncryptionSupport and an Encryption module and also > check the prefixes and suffixes. > I propose to have one method exposed by the EncryptionSupport: > String encrypt(String plain) > This method checks if plain is already encrypted and encrypts with the > selected Encryption. It also handles the !enabled or no suitable > EncryptionSupport case. > Besides that I propose a public static EncryptionSupport > noEncryptionSupport() that can be called instead of setting the > encryptionSupport=null in modules. This allows to leave out null checks. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
