[jira] [Commented] (KARAF-5628) Corrupt gc.log due to unseparated VM settings
[ https://issues.apache.org/jira/browse/KARAF-5628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17013014#comment-17013014 ] ASF subversion and git services commented on KARAF-5628: Commit 240df3ce16df6e2b8e9a16c2495a9fe68bfbb81e in karaf's branch refs/heads/master from Jean-Baptiste Onofré [ https://gitbox.apache.org/repos/asf?p=karaf.git;h=240df3c ] Merge pull request #1058 from Talend/jgreffe/KARAF-5628 KARAF-5628: Corrupt gc.log due to unseparated VM settings > Corrupt gc.log due to unseparated VM settings > - > > Key: KARAF-5628 > URL: https://issues.apache.org/jira/browse/KARAF-5628 > Project: Karaf > Issue Type: Bug > Components: karaf >Reporter: Rico Neubauer >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 4.3.0, 4.2.8 > > > The VM properties used for the start, stop, status and client scripts all use > one common configuration of the VM properties, like Xmx and GC settings. > This has one particular issue when activating the gc.log (-Xloggc:gc.log with > Oracle-VM): Invoking e.g. status while Karaf is running, uses the same > settings, thus points to the same file and corrupts it with NUL values (see > here for details: > [Stackoverflow|[https://stackoverflow.com/questions/8353401/garbage-collector-log-loggc-file-rotation-with-logrotate-does-not-work-properl]] > ). > > I would like to request the possibility to configure the VM properties for > starting the instance independently from the maintenance scripts - due to the > issue and also since e.g. running status with lots of heap (if instance is > configured to it) is unneeded. > > Even making it broader, I think it would also make sense to be able to > configure the settings completely, since currently some things are hard-coded > in the scripts, like the _-Xdum_p and _-Xlp_ settings for AIX, where I > personally would like to configure it to _-Xdump:heap:events=gpf,opts=PHD_, > which is currently not possible using the configuration only. Also especially > for AIX, there is _LDR_CNTRL=MAXDATA=0xB000@DSA_, which might not be > desired when running with heaps larger than 3GB. > > If you agree on a separation, I would make a proposal as PR. Please let me > know. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KARAF-5628) Corrupt gc.log due to unseparated VM settings
[ https://issues.apache.org/jira/browse/KARAF-5628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17013015#comment-17013015 ] ASF subversion and git services commented on KARAF-5628: Commit 467eebf84439ee457e6d04d2ed5ab84fbc592c95 in karaf's branch refs/heads/karaf-4.2.x from Julien Greffe [ https://gitbox.apache.org/repos/asf?p=karaf.git;h=467eebf ] KARAF-5628: Corrupt gc.log due to unseparated VM settings Remove useless parameters on stop (cherry picked from commit 696bbe9ddc78e3227668504d5dd9bba79342190f) > Corrupt gc.log due to unseparated VM settings > - > > Key: KARAF-5628 > URL: https://issues.apache.org/jira/browse/KARAF-5628 > Project: Karaf > Issue Type: Bug > Components: karaf >Reporter: Rico Neubauer >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 4.3.0, 4.2.8 > > > The VM properties used for the start, stop, status and client scripts all use > one common configuration of the VM properties, like Xmx and GC settings. > This has one particular issue when activating the gc.log (-Xloggc:gc.log with > Oracle-VM): Invoking e.g. status while Karaf is running, uses the same > settings, thus points to the same file and corrupts it with NUL values (see > here for details: > [Stackoverflow|[https://stackoverflow.com/questions/8353401/garbage-collector-log-loggc-file-rotation-with-logrotate-does-not-work-properl]] > ). > > I would like to request the possibility to configure the VM properties for > starting the instance independently from the maintenance scripts - due to the > issue and also since e.g. running status with lots of heap (if instance is > configured to it) is unneeded. > > Even making it broader, I think it would also make sense to be able to > configure the settings completely, since currently some things are hard-coded > in the scripts, like the _-Xdum_p and _-Xlp_ settings for AIX, where I > personally would like to configure it to _-Xdump:heap:events=gpf,opts=PHD_, > which is currently not possible using the configuration only. Also especially > for AIX, there is _LDR_CNTRL=MAXDATA=0xB000@DSA_, which might not be > desired when running with heaps larger than 3GB. > > If you agree on a separation, I would make a proposal as PR. Please let me > know. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KARAF-5628) Corrupt gc.log due to unseparated VM settings
[ https://issues.apache.org/jira/browse/KARAF-5628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17013011#comment-17013011 ] ASF GitHub Bot commented on KARAF-5628: --- jbonofre commented on pull request #1058: KARAF-5628: Corrupt gc.log due to unseparated VM settings URL: https://github.com/apache/karaf/pull/1058 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Corrupt gc.log due to unseparated VM settings > - > > Key: KARAF-5628 > URL: https://issues.apache.org/jira/browse/KARAF-5628 > Project: Karaf > Issue Type: Bug > Components: karaf >Reporter: Rico Neubauer >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 4.3.0, 4.2.8 > > > The VM properties used for the start, stop, status and client scripts all use > one common configuration of the VM properties, like Xmx and GC settings. > This has one particular issue when activating the gc.log (-Xloggc:gc.log with > Oracle-VM): Invoking e.g. status while Karaf is running, uses the same > settings, thus points to the same file and corrupts it with NUL values (see > here for details: > [Stackoverflow|[https://stackoverflow.com/questions/8353401/garbage-collector-log-loggc-file-rotation-with-logrotate-does-not-work-properl]] > ). > > I would like to request the possibility to configure the VM properties for > starting the instance independently from the maintenance scripts - due to the > issue and also since e.g. running status with lots of heap (if instance is > configured to it) is unneeded. > > Even making it broader, I think it would also make sense to be able to > configure the settings completely, since currently some things are hard-coded > in the scripts, like the _-Xdum_p and _-Xlp_ settings for AIX, where I > personally would like to configure it to _-Xdump:heap:events=gpf,opts=PHD_, > which is currently not possible using the configuration only. Also especially > for AIX, there is _LDR_CNTRL=MAXDATA=0xB000@DSA_, which might not be > desired when running with heaps larger than 3GB. > > If you agree on a separation, I would make a proposal as PR. Please let me > know. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KARAF-5628) Corrupt gc.log due to unseparated VM settings
[ https://issues.apache.org/jira/browse/KARAF-5628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17013013#comment-17013013 ] ASF subversion and git services commented on KARAF-5628: Commit 240df3ce16df6e2b8e9a16c2495a9fe68bfbb81e in karaf's branch refs/heads/master from Jean-Baptiste Onofré [ https://gitbox.apache.org/repos/asf?p=karaf.git;h=240df3c ] Merge pull request #1058 from Talend/jgreffe/KARAF-5628 KARAF-5628: Corrupt gc.log due to unseparated VM settings > Corrupt gc.log due to unseparated VM settings > - > > Key: KARAF-5628 > URL: https://issues.apache.org/jira/browse/KARAF-5628 > Project: Karaf > Issue Type: Bug > Components: karaf >Reporter: Rico Neubauer >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 4.3.0, 4.2.8 > > > The VM properties used for the start, stop, status and client scripts all use > one common configuration of the VM properties, like Xmx and GC settings. > This has one particular issue when activating the gc.log (-Xloggc:gc.log with > Oracle-VM): Invoking e.g. status while Karaf is running, uses the same > settings, thus points to the same file and corrupts it with NUL values (see > here for details: > [Stackoverflow|[https://stackoverflow.com/questions/8353401/garbage-collector-log-loggc-file-rotation-with-logrotate-does-not-work-properl]] > ). > > I would like to request the possibility to configure the VM properties for > starting the instance independently from the maintenance scripts - due to the > issue and also since e.g. running status with lots of heap (if instance is > configured to it) is unneeded. > > Even making it broader, I think it would also make sense to be able to > configure the settings completely, since currently some things are hard-coded > in the scripts, like the _-Xdum_p and _-Xlp_ settings for AIX, where I > personally would like to configure it to _-Xdump:heap:events=gpf,opts=PHD_, > which is currently not possible using the configuration only. Also especially > for AIX, there is _LDR_CNTRL=MAXDATA=0xB000@DSA_, which might not be > desired when running with heaps larger than 3GB. > > If you agree on a separation, I would make a proposal as PR. Please let me > know. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KARAF-5628) Corrupt gc.log due to unseparated VM settings
[ https://issues.apache.org/jira/browse/KARAF-5628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17013012#comment-17013012 ] ASF subversion and git services commented on KARAF-5628: Commit 696bbe9ddc78e3227668504d5dd9bba79342190f in karaf's branch refs/heads/master from Julien Greffe [ https://gitbox.apache.org/repos/asf?p=karaf.git;h=696bbe9 ] KARAF-5628: Corrupt gc.log due to unseparated VM settings Remove useless parameters on stop > Corrupt gc.log due to unseparated VM settings > - > > Key: KARAF-5628 > URL: https://issues.apache.org/jira/browse/KARAF-5628 > Project: Karaf > Issue Type: Bug > Components: karaf >Reporter: Rico Neubauer >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 4.3.0, 4.2.8 > > > The VM properties used for the start, stop, status and client scripts all use > one common configuration of the VM properties, like Xmx and GC settings. > This has one particular issue when activating the gc.log (-Xloggc:gc.log with > Oracle-VM): Invoking e.g. status while Karaf is running, uses the same > settings, thus points to the same file and corrupts it with NUL values (see > here for details: > [Stackoverflow|[https://stackoverflow.com/questions/8353401/garbage-collector-log-loggc-file-rotation-with-logrotate-does-not-work-properl]] > ). > > I would like to request the possibility to configure the VM properties for > starting the instance independently from the maintenance scripts - due to the > issue and also since e.g. running status with lots of heap (if instance is > configured to it) is unneeded. > > Even making it broader, I think it would also make sense to be able to > configure the settings completely, since currently some things are hard-coded > in the scripts, like the _-Xdum_p and _-Xlp_ settings for AIX, where I > personally would like to configure it to _-Xdump:heap:events=gpf,opts=PHD_, > which is currently not possible using the configuration only. Also especially > for AIX, there is _LDR_CNTRL=MAXDATA=0xB000@DSA_, which might not be > desired when running with heaps larger than 3GB. > > If you agree on a separation, I would make a proposal as PR. Please let me > know. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KARAF-5628) Corrupt gc.log due to unseparated VM settings
[ https://issues.apache.org/jira/browse/KARAF-5628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17013008#comment-17013008 ] ASF GitHub Bot commented on KARAF-5628: --- jgreffe commented on pull request #1058: KARAF-5628: Corrupt gc.log due to unseparated VM settings URL: https://github.com/apache/karaf/pull/1058 Remove useless parameters on stop This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Corrupt gc.log due to unseparated VM settings > - > > Key: KARAF-5628 > URL: https://issues.apache.org/jira/browse/KARAF-5628 > Project: Karaf > Issue Type: Bug > Components: karaf >Reporter: Rico Neubauer >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 4.3.0, 4.2.8 > > > The VM properties used for the start, stop, status and client scripts all use > one common configuration of the VM properties, like Xmx and GC settings. > This has one particular issue when activating the gc.log (-Xloggc:gc.log with > Oracle-VM): Invoking e.g. status while Karaf is running, uses the same > settings, thus points to the same file and corrupts it with NUL values (see > here for details: > [Stackoverflow|[https://stackoverflow.com/questions/8353401/garbage-collector-log-loggc-file-rotation-with-logrotate-does-not-work-properl]] > ). > > I would like to request the possibility to configure the VM properties for > starting the instance independently from the maintenance scripts - due to the > issue and also since e.g. running status with lots of heap (if instance is > configured to it) is unneeded. > > Even making it broader, I think it would also make sense to be able to > configure the settings completely, since currently some things are hard-coded > in the scripts, like the _-Xdum_p and _-Xlp_ settings for AIX, where I > personally would like to configure it to _-Xdump:heap:events=gpf,opts=PHD_, > which is currently not possible using the configuration only. Also especially > for AIX, there is _LDR_CNTRL=MAXDATA=0xB000@DSA_, which might not be > desired when running with heaps larger than 3GB. > > If you agree on a separation, I would make a proposal as PR. Please let me > know. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KARAF-5628) Corrupt gc.log due to unseparated VM settings
[
https://issues.apache.org/jira/browse/KARAF-5628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17013006#comment-17013006
]
Julien Greffe commented on KARAF-5628:
--
Yes, this has been fixed on 4.2.x branch.
As this fix impacts only the executables, I picked them and replaced on a
apache-karaf-4.2.7 release.
And I'm still getting the issue on windows.
I suspect this is related to the {{stop}} execution which still pass on the
{{KARAF_OPTS}} value (and others).
I created a PR, tested locally with Windows + WSL and it seems there's no more
unprintable characters.
> Corrupt gc.log due to unseparated VM settings
> -
>
> Key: KARAF-5628
> URL: https://issues.apache.org/jira/browse/KARAF-5628
> Project: Karaf
> Issue Type: Bug
> Components: karaf
>Reporter: Rico Neubauer
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: 4.3.0, 4.2.8
>
>
> The VM properties used for the start, stop, status and client scripts all use
> one common configuration of the VM properties, like Xmx and GC settings.
> This has one particular issue when activating the gc.log (-Xloggc:gc.log with
> Oracle-VM): Invoking e.g. status while Karaf is running, uses the same
> settings, thus points to the same file and corrupts it with NUL values (see
> here for details:
> [Stackoverflow|[https://stackoverflow.com/questions/8353401/garbage-collector-log-loggc-file-rotation-with-logrotate-does-not-work-properl]]
> ).
>
> I would like to request the possibility to configure the VM properties for
> starting the instance independently from the maintenance scripts - due to the
> issue and also since e.g. running status with lots of heap (if instance is
> configured to it) is unneeded.
>
> Even making it broader, I think it would also make sense to be able to
> configure the settings completely, since currently some things are hard-coded
> in the scripts, like the _-Xdum_p and _-Xlp_ settings for AIX, where I
> personally would like to configure it to _-Xdump:heap:events=gpf,opts=PHD_,
> which is currently not possible using the configuration only. Also especially
> for AIX, there is _LDR_CNTRL=MAXDATA=0xB000@DSA_, which might not be
> desired when running with heaps larger than 3GB.
>
> If you agree on a separation, I would make a proposal as PR. Please let me
> know.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (KARAF-5628) Corrupt gc.log due to unseparated VM settings
[ https://issues.apache.org/jira/browse/KARAF-5628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17012015#comment-17012015 ] Jean-Baptiste Onofré commented on KARAF-5628: - Hold on: see the fixed version tag, it should be fixed with 4.2.8 (not 4.2.7). > Corrupt gc.log due to unseparated VM settings > - > > Key: KARAF-5628 > URL: https://issues.apache.org/jira/browse/KARAF-5628 > Project: Karaf > Issue Type: Bug > Components: karaf >Reporter: Rico Neubauer >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 4.3.0, 4.2.8 > > > The VM properties used for the start, stop, status and client scripts all use > one common configuration of the VM properties, like Xmx and GC settings. > This has one particular issue when activating the gc.log (-Xloggc:gc.log with > Oracle-VM): Invoking e.g. status while Karaf is running, uses the same > settings, thus points to the same file and corrupts it with NUL values (see > here for details: > [Stackoverflow|[https://stackoverflow.com/questions/8353401/garbage-collector-log-loggc-file-rotation-with-logrotate-does-not-work-properl]] > ). > > I would like to request the possibility to configure the VM properties for > starting the instance independently from the maintenance scripts - due to the > issue and also since e.g. running status with lots of heap (if instance is > configured to it) is unneeded. > > Even making it broader, I think it would also make sense to be able to > configure the settings completely, since currently some things are hard-coded > in the scripts, like the _-Xdum_p and _-Xlp_ settings for AIX, where I > personally would like to configure it to _-Xdump:heap:events=gpf,opts=PHD_, > which is currently not possible using the configuration only. Also especially > for AIX, there is _LDR_CNTRL=MAXDATA=0xB000@DSA_, which might not be > desired when running with heaps larger than 3GB. > > If you agree on a separation, I would make a proposal as PR. Please let me > know. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KARAF-5628) Corrupt gc.log due to unseparated VM settings
[
https://issues.apache.org/jira/browse/KARAF-5628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17012001#comment-17012001
]
Julien Greffe commented on KARAF-5628:
--
Hello,
not sure this is correctly fixed.
Still have the issue on Windows :
- use release apache-karaf-4.2.7.zip & unzip
- replace all {{bin/}} executables with the ones from the commit
- update {{bin/setenv.bat}} by adding :
{code}SET KARAF_OPTS=-verbose:gc -Xloggc:C:/tmp/gc.log -XX:+PrintGCDetails
-XX:+PrintGCDateStamps -XX:+UseGCLogFileRotation -XX:NumberOfGCLogFiles=20
-XX:GCLogFileSize=10m{code}
- execute {{karaf.bat}}
- check the content of {{C:/tmp/log.gc}}
- execute {{stop.bat}}, ensure karaf is stopped correctly
- check the content of {{C:/tmp/log.gc}} => still presence of non printable
characters
Could you please have a look again?
> Corrupt gc.log due to unseparated VM settings
> -
>
> Key: KARAF-5628
> URL: https://issues.apache.org/jira/browse/KARAF-5628
> Project: Karaf
> Issue Type: Bug
> Components: karaf
>Reporter: Rico Neubauer
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: 4.3.0, 4.2.8
>
>
> The VM properties used for the start, stop, status and client scripts all use
> one common configuration of the VM properties, like Xmx and GC settings.
> This has one particular issue when activating the gc.log (-Xloggc:gc.log with
> Oracle-VM): Invoking e.g. status while Karaf is running, uses the same
> settings, thus points to the same file and corrupts it with NUL values (see
> here for details:
> [Stackoverflow|[https://stackoverflow.com/questions/8353401/garbage-collector-log-loggc-file-rotation-with-logrotate-does-not-work-properl]]
> ).
>
> I would like to request the possibility to configure the VM properties for
> starting the instance independently from the maintenance scripts - due to the
> issue and also since e.g. running status with lots of heap (if instance is
> configured to it) is unneeded.
>
> Even making it broader, I think it would also make sense to be able to
> configure the settings completely, since currently some things are hard-coded
> in the scripts, like the _-Xdum_p and _-Xlp_ settings for AIX, where I
> personally would like to configure it to _-Xdump:heap:events=gpf,opts=PHD_,
> which is currently not possible using the configuration only. Also especially
> for AIX, there is _LDR_CNTRL=MAXDATA=0xB000@DSA_, which might not be
> desired when running with heaps larger than 3GB.
>
> If you agree on a separation, I would make a proposal as PR. Please let me
> know.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (KARAF-5628) Corrupt gc.log due to unseparated VM settings
[ https://issues.apache.org/jira/browse/KARAF-5628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16949965#comment-16949965 ] ASF subversion and git services commented on KARAF-5628: Commit acbe2c0a990f03fb362a619fec17074ca5ba1be4 in karaf's branch refs/heads/karaf-4.2.x from Aleksandar Vasilev [ https://gitbox.apache.org/repos/asf?p=karaf.git;h=acbe2c0 ] [KARAF-5628] Corrupt gc.log due to unseparated VM settings setenv would recognize original calling script. So EXTRA_JAVA_OPTS or JAVA_OPTS could be set from there script based with bat/sh if statement. (cherry picked from commit e66f121f2b9d619dcd9a78df52525aeb0bd6a0c9) > Corrupt gc.log due to unseparated VM settings > - > > Key: KARAF-5628 > URL: https://issues.apache.org/jira/browse/KARAF-5628 > Project: Karaf > Issue Type: Bug > Components: karaf >Reporter: Rico Neubauer >Assignee: Jean-Baptiste Onofré >Priority: Major > > The VM properties used for the start, stop, status and client scripts all use > one common configuration of the VM properties, like Xmx and GC settings. > This has one particular issue when activating the gc.log (-Xloggc:gc.log with > Oracle-VM): Invoking e.g. status while Karaf is running, uses the same > settings, thus points to the same file and corrupts it with NUL values (see > here for details: > [Stackoverflow|[https://stackoverflow.com/questions/8353401/garbage-collector-log-loggc-file-rotation-with-logrotate-does-not-work-properl]] > ). > > I would like to request the possibility to configure the VM properties for > starting the instance independently from the maintenance scripts - due to the > issue and also since e.g. running status with lots of heap (if instance is > configured to it) is unneeded. > > Even making it broader, I think it would also make sense to be able to > configure the settings completely, since currently some things are hard-coded > in the scripts, like the _-Xdum_p and _-Xlp_ settings for AIX, where I > personally would like to configure it to _-Xdump:heap:events=gpf,opts=PHD_, > which is currently not possible using the configuration only. Also especially > for AIX, there is _LDR_CNTRL=MAXDATA=0xB000@DSA_, which might not be > desired when running with heaps larger than 3GB. > > If you agree on a separation, I would make a proposal as PR. Please let me > know. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KARAF-5628) Corrupt gc.log due to unseparated VM settings
[ https://issues.apache.org/jira/browse/KARAF-5628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16949964#comment-16949964 ] ASF subversion and git services commented on KARAF-5628: Commit 25b1a00ab6b2330a469c244c4abc1389aaad5313 in karaf's branch refs/heads/master from Jean-Baptiste Onofré [ https://gitbox.apache.org/repos/asf?p=karaf.git;h=25b1a00 ] Merge pull request #952 from avasilev/master [KARAF-5628] Corrupt gc.log due to unseparated VM settings > Corrupt gc.log due to unseparated VM settings > - > > Key: KARAF-5628 > URL: https://issues.apache.org/jira/browse/KARAF-5628 > Project: Karaf > Issue Type: Bug > Components: karaf >Reporter: Rico Neubauer >Assignee: Jean-Baptiste Onofré >Priority: Major > > The VM properties used for the start, stop, status and client scripts all use > one common configuration of the VM properties, like Xmx and GC settings. > This has one particular issue when activating the gc.log (-Xloggc:gc.log with > Oracle-VM): Invoking e.g. status while Karaf is running, uses the same > settings, thus points to the same file and corrupts it with NUL values (see > here for details: > [Stackoverflow|[https://stackoverflow.com/questions/8353401/garbage-collector-log-loggc-file-rotation-with-logrotate-does-not-work-properl]] > ). > > I would like to request the possibility to configure the VM properties for > starting the instance independently from the maintenance scripts - due to the > issue and also since e.g. running status with lots of heap (if instance is > configured to it) is unneeded. > > Even making it broader, I think it would also make sense to be able to > configure the settings completely, since currently some things are hard-coded > in the scripts, like the _-Xdum_p and _-Xlp_ settings for AIX, where I > personally would like to configure it to _-Xdump:heap:events=gpf,opts=PHD_, > which is currently not possible using the configuration only. Also especially > for AIX, there is _LDR_CNTRL=MAXDATA=0xB000@DSA_, which might not be > desired when running with heaps larger than 3GB. > > If you agree on a separation, I would make a proposal as PR. Please let me > know. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KARAF-5628) Corrupt gc.log due to unseparated VM settings
[ https://issues.apache.org/jira/browse/KARAF-5628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16949963#comment-16949963 ] ASF subversion and git services commented on KARAF-5628: Commit e66f121f2b9d619dcd9a78df52525aeb0bd6a0c9 in karaf's branch refs/heads/master from Aleksandar Vasilev [ https://gitbox.apache.org/repos/asf?p=karaf.git;h=e66f121 ] [KARAF-5628] Corrupt gc.log due to unseparated VM settings setenv would recognize original calling script. So EXTRA_JAVA_OPTS or JAVA_OPTS could be set from there script based with bat/sh if statement. > Corrupt gc.log due to unseparated VM settings > - > > Key: KARAF-5628 > URL: https://issues.apache.org/jira/browse/KARAF-5628 > Project: Karaf > Issue Type: Bug > Components: karaf >Reporter: Rico Neubauer >Assignee: Jean-Baptiste Onofré >Priority: Major > > The VM properties used for the start, stop, status and client scripts all use > one common configuration of the VM properties, like Xmx and GC settings. > This has one particular issue when activating the gc.log (-Xloggc:gc.log with > Oracle-VM): Invoking e.g. status while Karaf is running, uses the same > settings, thus points to the same file and corrupts it with NUL values (see > here for details: > [Stackoverflow|[https://stackoverflow.com/questions/8353401/garbage-collector-log-loggc-file-rotation-with-logrotate-does-not-work-properl]] > ). > > I would like to request the possibility to configure the VM properties for > starting the instance independently from the maintenance scripts - due to the > issue and also since e.g. running status with lots of heap (if instance is > configured to it) is unneeded. > > Even making it broader, I think it would also make sense to be able to > configure the settings completely, since currently some things are hard-coded > in the scripts, like the _-Xdum_p and _-Xlp_ settings for AIX, where I > personally would like to configure it to _-Xdump:heap:events=gpf,opts=PHD_, > which is currently not possible using the configuration only. Also especially > for AIX, there is _LDR_CNTRL=MAXDATA=0xB000@DSA_, which might not be > desired when running with heaps larger than 3GB. > > If you agree on a separation, I would make a proposal as PR. Please let me > know. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KARAF-5628) Corrupt gc.log due to unseparated VM settings
[ https://issues.apache.org/jira/browse/KARAF-5628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16949962#comment-16949962 ] ASF GitHub Bot commented on KARAF-5628: --- jbonofre commented on pull request #952: [KARAF-5628] Corrupt gc.log due to unseparated VM settings URL: https://github.com/apache/karaf/pull/952 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Corrupt gc.log due to unseparated VM settings > - > > Key: KARAF-5628 > URL: https://issues.apache.org/jira/browse/KARAF-5628 > Project: Karaf > Issue Type: Bug > Components: karaf >Reporter: Rico Neubauer >Assignee: Jean-Baptiste Onofré >Priority: Major > > The VM properties used for the start, stop, status and client scripts all use > one common configuration of the VM properties, like Xmx and GC settings. > This has one particular issue when activating the gc.log (-Xloggc:gc.log with > Oracle-VM): Invoking e.g. status while Karaf is running, uses the same > settings, thus points to the same file and corrupts it with NUL values (see > here for details: > [Stackoverflow|[https://stackoverflow.com/questions/8353401/garbage-collector-log-loggc-file-rotation-with-logrotate-does-not-work-properl]] > ). > > I would like to request the possibility to configure the VM properties for > starting the instance independently from the maintenance scripts - due to the > issue and also since e.g. running status with lots of heap (if instance is > configured to it) is unneeded. > > Even making it broader, I think it would also make sense to be able to > configure the settings completely, since currently some things are hard-coded > in the scripts, like the _-Xdum_p and _-Xlp_ settings for AIX, where I > personally would like to configure it to _-Xdump:heap:events=gpf,opts=PHD_, > which is currently not possible using the configuration only. Also especially > for AIX, there is _LDR_CNTRL=MAXDATA=0xB000@DSA_, which might not be > desired when running with heaps larger than 3GB. > > If you agree on a separation, I would make a proposal as PR. Please let me > know. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KARAF-5628) Corrupt gc.log due to unseparated VM settings
[ https://issues.apache.org/jira/browse/KARAF-5628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16946949#comment-16946949 ] Aleksandar Vasilev commented on KARAF-5628: --- I have created pull request for this one: [https://github.com/apache/karaf/pull/952] > Corrupt gc.log due to unseparated VM settings > - > > Key: KARAF-5628 > URL: https://issues.apache.org/jira/browse/KARAF-5628 > Project: Karaf > Issue Type: Bug > Components: karaf >Reporter: Rico Neubauer >Assignee: Jean-Baptiste Onofré >Priority: Major > > The VM properties used for the start, stop, status and client scripts all use > one common configuration of the VM properties, like Xmx and GC settings. > This has one particular issue when activating the gc.log (-Xloggc:gc.log with > Oracle-VM): Invoking e.g. status while Karaf is running, uses the same > settings, thus points to the same file and corrupts it with NUL values (see > here for details: > [Stackoverflow|[https://stackoverflow.com/questions/8353401/garbage-collector-log-loggc-file-rotation-with-logrotate-does-not-work-properl]] > ). > > I would like to request the possibility to configure the VM properties for > starting the instance independently from the maintenance scripts - due to the > issue and also since e.g. running status with lots of heap (if instance is > configured to it) is unneeded. > > Even making it broader, I think it would also make sense to be able to > configure the settings completely, since currently some things are hard-coded > in the scripts, like the _-Xdum_p and _-Xlp_ settings for AIX, where I > personally would like to configure it to _-Xdump:heap:events=gpf,opts=PHD_, > which is currently not possible using the configuration only. Also especially > for AIX, there is _LDR_CNTRL=MAXDATA=0xB000@DSA_, which might not be > desired when running with heaps larger than 3GB. > > If you agree on a separation, I would make a proposal as PR. Please let me > know. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KARAF-5628) Corrupt gc.log due to unseparated VM settings
[ https://issues.apache.org/jira/browse/KARAF-5628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16946948#comment-16946948 ] ASF GitHub Bot commented on KARAF-5628: --- avasilev commented on pull request #952: [KARAF-5628] Corrupt gc.log due to unseparated VM settings URL: https://github.com/apache/karaf/pull/952 setenv would recognize original calling script. So EXTRA_JAVA_OPTS or JAVA_OPTS could be set from there script based with bat/sh if statement. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Corrupt gc.log due to unseparated VM settings > - > > Key: KARAF-5628 > URL: https://issues.apache.org/jira/browse/KARAF-5628 > Project: Karaf > Issue Type: Bug > Components: karaf >Reporter: Rico Neubauer >Assignee: Jean-Baptiste Onofré >Priority: Major > > The VM properties used for the start, stop, status and client scripts all use > one common configuration of the VM properties, like Xmx and GC settings. > This has one particular issue when activating the gc.log (-Xloggc:gc.log with > Oracle-VM): Invoking e.g. status while Karaf is running, uses the same > settings, thus points to the same file and corrupts it with NUL values (see > here for details: > [Stackoverflow|[https://stackoverflow.com/questions/8353401/garbage-collector-log-loggc-file-rotation-with-logrotate-does-not-work-properl]] > ). > > I would like to request the possibility to configure the VM properties for > starting the instance independently from the maintenance scripts - due to the > issue and also since e.g. running status with lots of heap (if instance is > configured to it) is unneeded. > > Even making it broader, I think it would also make sense to be able to > configure the settings completely, since currently some things are hard-coded > in the scripts, like the _-Xdum_p and _-Xlp_ settings for AIX, where I > personally would like to configure it to _-Xdump:heap:events=gpf,opts=PHD_, > which is currently not possible using the configuration only. Also especially > for AIX, there is _LDR_CNTRL=MAXDATA=0xB000@DSA_, which might not be > desired when running with heaps larger than 3GB. > > If you agree on a separation, I would make a proposal as PR. Please let me > know. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KARAF-5628) Corrupt gc.log due to unseparated VM settings
[ https://issues.apache.org/jira/browse/KARAF-5628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16400934#comment-16400934 ] Jean-Baptiste Onofré commented on KARAF-5628: - Understood. Let me prepare a PR to move JAVA_OPTS in a condition (based on the script). > Corrupt gc.log due to unseparated VM settings > - > > Key: KARAF-5628 > URL: https://issues.apache.org/jira/browse/KARAF-5628 > Project: Karaf > Issue Type: Bug > Components: karaf-core >Reporter: Rico Neubauer >Assignee: Jean-Baptiste Onofré >Priority: Major > > The VM properties used for the start, stop, status and client scripts all use > one common configuration of the VM properties, like Xmx and GC settings. > This has one particular issue when activating the gc.log (-Xloggc:gc.log with > Oracle-VM): Invoking e.g. status while Karaf is running, uses the same > settings, thus points to the same file and corrupts it with NUL values (see > here for details: > [Stackoverflow|[https://stackoverflow.com/questions/8353401/garbage-collector-log-loggc-file-rotation-with-logrotate-does-not-work-properl]] > ). > > I would like to request the possibility to configure the VM properties for > starting the instance independently from the maintenance scripts - due to the > issue and also since e.g. running status with lots of heap (if instance is > configured to it) is unneeded. > > Even making it broader, I think it would also make sense to be able to > configure the settings completely, since currently some things are hard-coded > in the scripts, like the _-Xdum_p and _-Xlp_ settings for AIX, where I > personally would like to configure it to _-Xdump:heap:events=gpf,opts=PHD_, > which is currently not possible using the configuration only. Also especially > for AIX, there is _LDR_CNTRL=MAXDATA=0xB000@DSA_, which might not be > desired when running with heaps larger than 3GB. > > If you agree on a separation, I would make a proposal as PR. Please let me > know. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KARAF-5628) Corrupt gc.log due to unseparated VM settings
[
https://issues.apache.org/jira/browse/KARAF-5628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16400926#comment-16400926
]
Rico Neubauer commented on KARAF-5628:
--
[~jbonofre] unfortunately not. Those are only *extra* JAVA_OPTS, that get
concatenated to some hard-coded values in the scripts, depending on VM-version
and -vendor.
see e.g. this part of the "inc" script:
{code:java}
if [ "x${EXTRA_JAVA_OPTS}" != "x" ]; then
JAVA_OPTS="${JAVA_OPTS} ${EXTRA_JAVA_OPTS}"
fi
{code}
and the part below "_#Set the JVM_VENDOR specific JVM flags_"
I can suggest a PR as said, just did not start since you mentioned you would do
the improvements.
> Corrupt gc.log due to unseparated VM settings
> -
>
> Key: KARAF-5628
> URL: https://issues.apache.org/jira/browse/KARAF-5628
> Project: Karaf
> Issue Type: Bug
> Components: karaf-core
>Reporter: Rico Neubauer
>Assignee: Jean-Baptiste Onofré
>Priority: Major
>
> The VM properties used for the start, stop, status and client scripts all use
> one common configuration of the VM properties, like Xmx and GC settings.
> This has one particular issue when activating the gc.log (-Xloggc:gc.log with
> Oracle-VM): Invoking e.g. status while Karaf is running, uses the same
> settings, thus points to the same file and corrupts it with NUL values (see
> here for details:
> [Stackoverflow|[https://stackoverflow.com/questions/8353401/garbage-collector-log-loggc-file-rotation-with-logrotate-does-not-work-properl]]
> ).
>
> I would like to request the possibility to configure the VM properties for
> starting the instance independently from the maintenance scripts - due to the
> issue and also since e.g. running status with lots of heap (if instance is
> configured to it) is unneeded.
>
> Even making it broader, I think it would also make sense to be able to
> configure the settings completely, since currently some things are hard-coded
> in the scripts, like the _-Xdum_p and _-Xlp_ settings for AIX, where I
> personally would like to configure it to _-Xdump:heap:events=gpf,opts=PHD_,
> which is currently not possible using the configuration only. Also especially
> for AIX, there is _LDR_CNTRL=MAXDATA=0xB000@DSA_, which might not be
> desired when running with heaps larger than 3GB.
>
> If you agree on a separation, I would make a proposal as PR. Please let me
> know.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (KARAF-5628) Corrupt gc.log due to unseparated VM settings
[
https://issues.apache.org/jira/browse/KARAF-5628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16400617#comment-16400617
]
Jean-Baptiste Onofré commented on KARAF-5628:
-
I think you can already do what you want. In {{bin/setenv}}, you can configure
settings for a particular script:
{code}
if [ "${KARAF_SCRIPT}" == "karaf" ]; then
EXTRA_JAVA_OPTS="..."
fi
{code}
Is it not what you are looking for ?
> Corrupt gc.log due to unseparated VM settings
> -
>
> Key: KARAF-5628
> URL: https://issues.apache.org/jira/browse/KARAF-5628
> Project: Karaf
> Issue Type: Bug
> Components: karaf-core
>Reporter: Rico Neubauer
>Assignee: Jean-Baptiste Onofré
>Priority: Major
>
> The VM properties used for the start, stop, status and client scripts all use
> one common configuration of the VM properties, like Xmx and GC settings.
> This has one particular issue when activating the gc.log (-Xloggc:gc.log with
> Oracle-VM): Invoking e.g. status while Karaf is running, uses the same
> settings, thus points to the same file and corrupts it with NUL values (see
> here for details:
> [Stackoverflow|[https://stackoverflow.com/questions/8353401/garbage-collector-log-loggc-file-rotation-with-logrotate-does-not-work-properl]]
> ).
>
> I would like to request the possibility to configure the VM properties for
> starting the instance independently from the maintenance scripts - due to the
> issue and also since e.g. running status with lots of heap (if instance is
> configured to it) is unneeded.
>
> Even making it broader, I think it would also make sense to be able to
> configure the settings completely, since currently some things are hard-coded
> in the scripts, like the _-Xdum_p and _-Xlp_ settings for AIX, where I
> personally would like to configure it to _-Xdump:heap:events=gpf,opts=PHD_,
> which is currently not possible using the configuration only. Also especially
> for AIX, there is _LDR_CNTRL=MAXDATA=0xB000@DSA_, which might not be
> desired when running with heaps larger than 3GB.
>
> If you agree on a separation, I would make a proposal as PR. Please let me
> know.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (KARAF-5628) Corrupt gc.log due to unseparated VM settings
[ https://issues.apache.org/jira/browse/KARAF-5628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16400500#comment-16400500 ] Guillaume Nodet commented on KARAF-5628: [~riconeubauer] feel free to work on a PR, that would definitely help speed things up ! > Corrupt gc.log due to unseparated VM settings > - > > Key: KARAF-5628 > URL: https://issues.apache.org/jira/browse/KARAF-5628 > Project: Karaf > Issue Type: Bug > Components: karaf-core >Reporter: Rico Neubauer >Assignee: Jean-Baptiste Onofré >Priority: Major > > The VM properties used for the start, stop, status and client scripts all use > one common configuration of the VM properties, like Xmx and GC settings. > This has one particular issue when activating the gc.log (-Xloggc:gc.log with > Oracle-VM): Invoking e.g. status while Karaf is running, uses the same > settings, thus points to the same file and corrupts it with NUL values (see > here for details: > [Stackoverflow|[https://stackoverflow.com/questions/8353401/garbage-collector-log-loggc-file-rotation-with-logrotate-does-not-work-properl]] > ). > > I would like to request the possibility to configure the VM properties for > starting the instance independently from the maintenance scripts - due to the > issue and also since e.g. running status with lots of heap (if instance is > configured to it) is unneeded. > > Even making it broader, I think it would also make sense to be able to > configure the settings completely, since currently some things are hard-coded > in the scripts, like the _-Xdum_p and _-Xlp_ settings for AIX, where I > personally would like to configure it to _-Xdump:heap:events=gpf,opts=PHD_, > which is currently not possible using the configuration only. Also especially > for AIX, there is _LDR_CNTRL=MAXDATA=0xB000@DSA_, which might not be > desired when running with heaps larger than 3GB. > > If you agree on a separation, I would make a proposal as PR. Please let me > know. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KARAF-5628) Corrupt gc.log due to unseparated VM settings
[ https://issues.apache.org/jira/browse/KARAF-5628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16369068#comment-16369068 ] Jean-Baptiste Onofré commented on KARAF-5628: - Fair enough. I will do the improvements. > Corrupt gc.log due to unseparated VM settings > - > > Key: KARAF-5628 > URL: https://issues.apache.org/jira/browse/KARAF-5628 > Project: Karaf > Issue Type: Bug > Components: karaf-core >Reporter: Rico Neubauer >Assignee: Jean-Baptiste Onofré >Priority: Major > > The VM properties used for the start, stop, status and client scripts all use > one common configuration of the VM properties, like Xmx and GC settings. > This has one particular issue when activating the gc.log (-Xloggc:gc.log with > Oracle-VM): Invoking e.g. status while Karaf is running, uses the same > settings, thus points to the same file and corrupts it with NUL values (see > here for details: > [Stackoverflow|[https://stackoverflow.com/questions/8353401/garbage-collector-log-loggc-file-rotation-with-logrotate-does-not-work-properl]] > ). > > I would like to request the possibility to configure the VM properties for > starting the instance independently from the maintenance scripts - due to the > issue and also since e.g. running status with lots of heap (if instance is > configured to it) is unneeded. > > Even making it broader, I think it would also make sense to be able to > configure the settings completely, since currently some things are hard-coded > in the scripts, like the _-Xdum_p and _-Xlp_ settings for AIX, where I > personally would like to configure it to _-Xdump:heap:events=gpf,opts=PHD_, > which is currently not possible using the configuration only. Also especially > for AIX, there is _LDR_CNTRL=MAXDATA=0xB000@DSA_, which might not be > desired when running with heaps larger than 3GB. > > If you agree on a separation, I would make a proposal as PR. Please let me > know. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
