[jira] [Commented] (KARAF-5851) Remove heading spaces in the cfg files

2018-07-31 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/KARAF-5851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564743#comment-16564743
 ] 

ASF subversion and git services commented on KARAF-5851:


Commit 96855638157a1e3f107667db5fc90d8350fb4769 in karaf's branch 
refs/heads/karaf-4.1.x from [~j...@nanthrax.net]
[ https://gitbox.apache.org/repos/asf?p=karaf.git;h=9685563 ]

[KARAF-5851] Remove heading spaces in the cfg files


> Remove heading spaces in the cfg files
> --
>
> Key: KARAF-5851
> URL: https://issues.apache.org/jira/browse/KARAF-5851
> Project: Karaf
>  Issue Type: Bug
>  Components: karaf-core
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Minor
> Fix For: 4.1.6, 4.2.1
>
>
> The {{cfg}} files in the Karaf distributions are created from the standard 
> features repository XML. However, as the features XML contains heading spaces 
> in {{}} elements, the resulting {{cfg}} files also contains those 
> heading spaces.
> There's no impact, but for a much more better looking, I will remove the 
> heading spaces from features XML.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KARAF-5851) Remove heading spaces in the cfg files

2018-07-31 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KARAF-5851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564214#comment-16564214
 ] 

ASF GitHub Bot commented on KARAF-5851:
---

jbonofre closed pull request #583: [KARAF-5851] Remove heading spaces in the 
cfg files
URL: https://github.com/apache/karaf/pull/583
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/assemblies/features/enterprise/src/main/feature/feature.xml 
b/assemblies/features/enterprise/src/main/feature/feature.xml
index 66fe319562..48e6100d0e 100644
--- a/assemblies/features/enterprise/src/main/feature/feature.xml
+++ b/assemblies/features/enterprise/src/main/feature/feature.xml
@@ -41,31 +41,31 @@
 
 JTA implementation provided by Apache Aries 
Transaction
 
-

-#
-#Licensed to the Apache Software Foundation (ASF) under one or 
more
-#contributor license agreements.  See the NOTICE file 
distributed with
-#this work for additional information regarding copyright 
ownership.
-#The ASF licenses this file to You under the Apache License, 
Version 2.0
-#(the "License"); you may not use this file except in 
compliance with
-#the License.  You may obtain a copy of the License at
-#
-#   http://www.apache.org/licenses/LICENSE-2.0
-#
-#Unless required by applicable law or agreed to in writing, 
software
-#distributed under the License is distributed on an "AS IS" 
BASIS,
-#WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express 
or implied.
-#See the License for the specific language governing 
permissions and
-#limitations under the License.
-#
-

+
+#
+#Licensed to the Apache Software Foundation (ASF) under one or more
+#contributor license agreements.  See the NOTICE file distributed with
+#this work for additional information regarding copyright ownership.
+#The ASF licenses this file to You under the Apache License, Version 2.0
+#(the "License"); you may not use this file except in compliance with
+#the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+#Unless required by applicable law or agreed to in writing, software
+#distributed under the License is distributed on an "AS IS" BASIS,
+#WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+#See the License for the specific language governing permissions and
+#limitations under the License.
+#
+
 
-org.apache.geronimo.tm.recoverable = true
-org.apache.geronimo.tm.timeout = 600
-org.apache.geronimo.tm.howl.logFileDir = ${karaf.data}/txlog
-org.apache.geronimo.tm.howl.maxLogFiles = 2
-org.apache.geronimo.tm.howl.maxBlocksPerFile = 512
-org.apache.geronimo.tm.howl.bufferSize = 4
+org.apache.geronimo.tm.recoverable = true
+org.apache.geronimo.tm.timeout = 600
+org.apache.geronimo.tm.howl.logFileDir = ${karaf.data}/txlog
+org.apache.geronimo.tm.howl.maxLogFiles = 2
+org.apache.geronimo.tm.howl.maxBlocksPerFile = 512
+org.apache.geronimo.tm.howl.bufferSize = 4
 
 transaction-api
 pax-transx-tm-geronimo
@@ -77,28 +77,28 @@
 
 JTA implementation provided by Narayana
 
-

-#
-#Licensed to the Apache Software Foundation (ASF) under one or 
more
-#contributor license agreements.  See the NOTICE file 
distributed with
-#this work for additional information regarding copyright 
ownership.
-#The ASF licenses this file to You under the Apache License, 
Version 2.0
-#(the "License"); you may not use this file except in 
compliance with
-#the License.  You may obtain a copy of the License at
-#
-#   http://www.apache.org/licenses/LICENSE-2.0
-#
-#Unless required by applicable law or agreed to in writing, 
software
-#distributed under the License is distributed on an "AS IS" 
BASIS,
-#WITHOUT 

[jira] [Commented] (KARAF-5851) Remove heading spaces in the cfg files

2018-07-31 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/KARAF-5851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564216#comment-16564216
 ] 

ASF subversion and git services commented on KARAF-5851:


Commit e1e6521500cd53ed05c40cffea3412d92c31b182 in karaf's branch 
refs/heads/master from [~j...@nanthrax.net]
[ https://gitbox.apache.org/repos/asf?p=karaf.git;h=e1e6521 ]

Merge pull request #583 from jbonofre/KARAF-5851

[KARAF-5851] Remove heading spaces in the cfg files

> Remove heading spaces in the cfg files
> --
>
> Key: KARAF-5851
> URL: https://issues.apache.org/jira/browse/KARAF-5851
> Project: Karaf
>  Issue Type: Bug
>  Components: karaf-core
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Minor
> Fix For: 4.1.6, 4.2.1
>
>
> The {{cfg}} files in the Karaf distributions are created from the standard 
> features repository XML. However, as the features XML contains heading spaces 
> in {{}} elements, the resulting {{cfg}} files also contains those 
> heading spaces.
> There's no impact, but for a much more better looking, I will remove the 
> heading spaces from features XML.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KARAF-5851) Remove heading spaces in the cfg files

2018-07-31 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/KARAF-5851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564217#comment-16564217
 ] 

ASF subversion and git services commented on KARAF-5851:


Commit e1e6521500cd53ed05c40cffea3412d92c31b182 in karaf's branch 
refs/heads/master from [~j...@nanthrax.net]
[ https://gitbox.apache.org/repos/asf?p=karaf.git;h=e1e6521 ]

Merge pull request #583 from jbonofre/KARAF-5851

[KARAF-5851] Remove heading spaces in the cfg files

> Remove heading spaces in the cfg files
> --
>
> Key: KARAF-5851
> URL: https://issues.apache.org/jira/browse/KARAF-5851
> Project: Karaf
>  Issue Type: Bug
>  Components: karaf-core
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Minor
> Fix For: 4.1.6, 4.2.1
>
>
> The {{cfg}} files in the Karaf distributions are created from the standard 
> features repository XML. However, as the features XML contains heading spaces 
> in {{}} elements, the resulting {{cfg}} files also contains those 
> heading spaces.
> There's no impact, but for a much more better looking, I will remove the 
> heading spaces from features XML.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KARAF-5851) Remove heading spaces in the cfg files

2018-07-31 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/KARAF-5851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564215#comment-16564215
 ] 

ASF subversion and git services commented on KARAF-5851:


Commit 5057aa441eb2df2f676d669b5bf0a5f223064e9f in karaf's branch 
refs/heads/master from [~j...@nanthrax.net]
[ https://gitbox.apache.org/repos/asf?p=karaf.git;h=5057aa4 ]

[KARAF-5851] Remove heading spaces in the cfg files


> Remove heading spaces in the cfg files
> --
>
> Key: KARAF-5851
> URL: https://issues.apache.org/jira/browse/KARAF-5851
> Project: Karaf
>  Issue Type: Bug
>  Components: karaf-core
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Minor
> Fix For: 4.1.6, 4.2.1
>
>
> The {{cfg}} files in the Karaf distributions are created from the standard 
> features repository XML. However, as the features XML contains heading spaces 
> in {{}} elements, the resulting {{cfg}} files also contains those 
> heading spaces.
> There's no impact, but for a much more better looking, I will remove the 
> heading spaces from features XML.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KARAF-5851) Remove heading spaces in the cfg files

2018-07-31 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KARAF-5851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16563757#comment-16563757
 ] 

ASF GitHub Bot commented on KARAF-5851:
---

jbonofre opened a new pull request #583: [KARAF-5851] Remove heading spaces in 
the cfg files
URL: https://github.com/apache/karaf/pull/583
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Remove heading spaces in the cfg files
> --
>
> Key: KARAF-5851
> URL: https://issues.apache.org/jira/browse/KARAF-5851
> Project: Karaf
>  Issue Type: Bug
>  Components: karaf-core
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Minor
> Fix For: 4.1.6, 4.2.1
>
>
> The {{cfg}} files in the Karaf distributions are created from the standard 
> features repository XML. However, as the features XML contains heading spaces 
> in {{}} elements, the resulting {{cfg}} files also contains those 
> heading spaces.
> There's no impact, but for a much more better looking, I will remove the 
> heading spaces from features XML.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)