[jira] [Commented] (KUDU-3354) Flaky test: DisableWriteWhenExceedingQuotaTest.TestDisableWritePrivilegeWhenExceedingSizeQuota

2022-06-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/KUDU-3354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17552967#comment-17552967
 ] 

ASF subversion and git services commented on KUDU-3354:
---

Commit 687bef89764640746deb27b3279e936acae4446e in kudu's branch 
refs/heads/master from zhangyifan27
[ https://gitbox.apache.org/repos/asf?p=kudu.git;h=687bef897 ]

KUDU-3354: Deflake DisableWriteWhenExceedingQuotaTest

I noticed that the TestDisableWritePrivilegeWhenExceedingSizeQuota
test failed some times in latest code review items because of test
timeout. From the test log we can see maintenance manager tends to
schedule a high score compact operation of some rowsets but do
nothing in the end because 'Compaction resulted in no output rows
(all input rows were GCed!)'. This leads to failures to schedule
flush operations and to hit the size limit until run out of time.

I think this weird high perf score most likely has something to do
with not explicitly initializing the 'value_' of RowsetInfo after
some debugging. The 'value_' can't be updated in FinalizeCDFVector()
either, because in the test scenario it has nearly one key in a
rowset, and the 'total_width' of the rowset is 0.

I run the test 10 times and see no failure with this fix, compared
to 5 failures without the fix but with a DCHECK[1] that indicates
the compaction error occurred in the test case.

[1] https://gerrit.cloudera.org/c/18584/1/src/kudu/tablet/tablet.cc#2135

Change-Id: Id257a1ce04fb2043d79641f770d03393ec5b844b
Reviewed-on: http://gerrit.cloudera.org:8080/18584
Reviewed-by: Yingchun Lai 
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin 


> Flaky test: 
> DisableWriteWhenExceedingQuotaTest.TestDisableWritePrivilegeWhenExceedingSizeQuota
> --
>
> Key: KUDU-3354
> URL: https://issues.apache.org/jira/browse/KUDU-3354
> Project: Kudu
>  Issue Type: Bug
>Reporter: YifanZhang
>Priority: Major
> Attachments: write_limit-itest.txt
>
>
> The test 
> `DisableWriteWhenExceedingQuotaTest.TestDisableWritePrivilegeWhenExceedingSizeQuota`
>  sometimes fails (at least in debug mode). The output is:
> /home/jenkins-slave/workspace/kudu-master/0/src/kudu/integration-tests/write_limit-itest.cc:229:
>  Failure
> Value of: s.IsIOError()
>   Actual: false
> Expected: true
> OK
> /home/jenkins-slave/workspace/kudu-master/0/src/kudu/integration-tests/write_limit-itest.cc:429:
>  Failure
> Expected: TestSizeLimit() doesn't generate new fatal failures in the current 
> thread.
>   Actual: it does.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Commented] (KUDU-3354) Flaky test: DisableWriteWhenExceedingQuotaTest.TestDisableWritePrivilegeWhenExceedingSizeQuota

2022-04-02 Thread YifanZhang (Jira)


[ 
https://issues.apache.org/jira/browse/KUDU-3354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17516304#comment-17516304
 ] 

YifanZhang commented on KUDU-3354:
--

{code:java}
I0221 04:22:12.031422  8866 maintenance_manager.cc:382] P 
c4e995dc9e264d6fbcd01aacff4212bd: Scheduling 
CompactRowSetsOp(64bf8251dd594197b493a8a5cd2e3e9c): perf 
score=1279494840443460300019357683777979923760955028182284084266695498710755807790412216956702667800111812783791998911358244116400294695993868288.00
I0221 04:22:12.032940  8806 tablet.cc:1898] T 64bf8251dd594197b493a8a5cd2e3e9c 
P c4e995dc9e264d6fbcd01aacff4212bd: Compaction resulted in no output rows (all 
input rows were GCed!)  Removing all input rowsets. {code}
Seems that the maintenance manager sometimes schedule strange compact ops as 
shown in the above log, these ops block flush ops because in the test tserver 
is configured with '--maintenance_manager_num_threads=1'(the default value).

> Flaky test: 
> DisableWriteWhenExceedingQuotaTest.TestDisableWritePrivilegeWhenExceedingSizeQuota
> --
>
> Key: KUDU-3354
> URL: https://issues.apache.org/jira/browse/KUDU-3354
> Project: Kudu
>  Issue Type: Bug
>Reporter: YifanZhang
>Priority: Major
> Attachments: write_limit-itest.txt
>
>
> The test 
> `DisableWriteWhenExceedingQuotaTest.TestDisableWritePrivilegeWhenExceedingSizeQuota`
>  sometimes fails (at least in debug mode). The output is:
> /home/jenkins-slave/workspace/kudu-master/0/src/kudu/integration-tests/write_limit-itest.cc:229:
>  Failure
> Value of: s.IsIOError()
>   Actual: false
> Expected: true
> OK
> /home/jenkins-slave/workspace/kudu-master/0/src/kudu/integration-tests/write_limit-itest.cc:429:
>  Failure
> Expected: TestSizeLimit() doesn't generate new fatal failures in the current 
> thread.
>   Actual: it does.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)