[jira] [Resolved] (KYLIN-2076) Improve sample cube and data

2016-10-10 Thread liyang (JIRA)

 [ 
https://issues.apache.org/jira/browse/KYLIN-2076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

liyang resolved KYLIN-2076.
---
   Resolution: Fixed
Fix Version/s: v1.6.0

> Improve sample cube and data
> 
>
> Key: KYLIN-2076
> URL: https://issues.apache.org/jira/browse/KYLIN-2076
> Project: Kylin
>  Issue Type: Improvement
>Reporter: liyang
>Assignee: Wang Cheng
> Fix For: v1.6.0
>
>
> Improve sample cube and data to include a user column.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (KYLIN-2068) Import hive comment when sync tables

2016-10-10 Thread Billy(Yiming) Liu (JIRA)

 [ 
https://issues.apache.org/jira/browse/KYLIN-2068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Billy(Yiming) Liu updated KYLIN-2068:
-
Attachment: KYLIN-2068.patch

Thanks Dong's review. The optional annotation added.

> Import hive comment when sync tables
> 
>
> Key: KYLIN-2068
> URL: https://issues.apache.org/jira/browse/KYLIN-2068
> Project: Kylin
>  Issue Type: Improvement
>  Components: Metadata
>Reporter: Billy(Yiming) Liu
>Assignee: Billy(Yiming) Liu
>Priority: Minor
>  Labels: newbie
> Attachments: KYLIN-2068.patch
>
>
> Current Sync Table imports the table names, column names and data type, 
> without comment. The "comment" is useful for understanding the column and 
> cube designing. May I propose to include the comment information into column 
> metadata.
> Both backend and GUI work needed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (KYLIN-2068) Import hive comment when sync tables

2016-10-10 Thread Billy(Yiming) Liu (JIRA)

 [ 
https://issues.apache.org/jira/browse/KYLIN-2068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Billy(Yiming) Liu updated KYLIN-2068:
-
Attachment: (was: KYLIN-2068.patch)

> Import hive comment when sync tables
> 
>
> Key: KYLIN-2068
> URL: https://issues.apache.org/jira/browse/KYLIN-2068
> Project: Kylin
>  Issue Type: Improvement
>  Components: Metadata
>Reporter: Billy(Yiming) Liu
>Assignee: Billy(Yiming) Liu
>Priority: Minor
>  Labels: newbie
> Attachments: KYLIN-2068.patch
>
>
> Current Sync Table imports the table names, column names and data type, 
> without comment. The "comment" is useful for understanding the column and 
> cube designing. May I propose to include the comment information into column 
> metadata.
> Both backend and GUI work needed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Comment Edited] (KYLIN-2068) Import hive comment when sync tables

2016-10-10 Thread Dong Li (JIRA)

[ 
https://issues.apache.org/jira/browse/KYLIN-2068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15562527#comment-15562527
 ] 

Dong Li edited comment on KYLIN-2068 at 10/10/16 3:07 PM:
--

Hi Yiming,

I saw a new field(comment) in ColumnDesc. This may cause compatible issue on 
metadata from old versions.
The old metadata (in json) may not be deserialized due to field missing, and 
user has to upgrade metadata for this field.

Maybe you can add following annotation to the field, to mark the field as 
optional.
@JsonInclude(JsonInclude.Include.NON_NULL)
You can find a reference in class org.apache.kylin.cube.model.RowKeyColDesc

Thanks,
Dong


was (Author: lidong_sjtu):
Hi Yiming,

I saw a new field(comment) in ColumnDesc. This may cause compatible issue on 
metadata from old versions.
The old metadata (in json) may not be deserialized due to field missing, and 
user must do metadata upgrade for this field.

Maybe you can add following annotation to the field, to mark the field as 
optional.
@JsonInclude(JsonInclude.Include.NON_NULL)
You can find a reference in class org.apache.kylin.cube.model.RowKeyColDesc

Thanks,
Dong

> Import hive comment when sync tables
> 
>
> Key: KYLIN-2068
> URL: https://issues.apache.org/jira/browse/KYLIN-2068
> Project: Kylin
>  Issue Type: Improvement
>  Components: Metadata
>Reporter: Billy(Yiming) Liu
>Assignee: Billy(Yiming) Liu
>Priority: Minor
>  Labels: newbie
> Attachments: KYLIN-2068.patch
>
>
> Current Sync Table imports the table names, column names and data type, 
> without comment. The "comment" is useful for understanding the column and 
> cube designing. May I propose to include the comment information into column 
> metadata.
> Both backend and GUI work needed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (KYLIN-2068) Import hive comment when sync tables

2016-10-10 Thread Dong Li (JIRA)

[ 
https://issues.apache.org/jira/browse/KYLIN-2068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15562527#comment-15562527
 ] 

Dong Li commented on KYLIN-2068:


Hi Yiming,

I saw a new field(comment) in ColumnDesc. This may cause compatible issue on 
metadata from old versions.
The old metadata (in json) may not be deserialized due to field missing, and 
user must do metadata upgrade for this field.

Maybe you can add following annotation to the field, to mark the field as 
optional.
@JsonInclude(JsonInclude.Include.NON_NULL)
You can find a reference in class org.apache.kylin.cube.model.RowKeyColDesc

Thanks,
Dong

> Import hive comment when sync tables
> 
>
> Key: KYLIN-2068
> URL: https://issues.apache.org/jira/browse/KYLIN-2068
> Project: Kylin
>  Issue Type: Improvement
>  Components: Metadata
>Reporter: Billy(Yiming) Liu
>Assignee: Billy(Yiming) Liu
>Priority: Minor
>  Labels: newbie
> Attachments: KYLIN-2068.patch
>
>
> Current Sync Table imports the table names, column names and data type, 
> without comment. The "comment" is useful for understanding the column and 
> cube designing. May I propose to include the comment information into column 
> metadata.
> Both backend and GUI work needed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (KYLIN-2068) Import hive comment when sync tables

2016-10-10 Thread Billy(Yiming) Liu (JIRA)

 [ 
https://issues.apache.org/jira/browse/KYLIN-2068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Billy(Yiming) Liu reassigned KYLIN-2068:


Assignee: Billy(Yiming) Liu  (was: Shaofeng SHI)

> Import hive comment when sync tables
> 
>
> Key: KYLIN-2068
> URL: https://issues.apache.org/jira/browse/KYLIN-2068
> Project: Kylin
>  Issue Type: Improvement
>  Components: Metadata
>Reporter: Billy(Yiming) Liu
>Assignee: Billy(Yiming) Liu
>Priority: Minor
>  Labels: newbie
> Attachments: KYLIN-2068.patch
>
>
> Current Sync Table imports the table names, column names and data type, 
> without comment. The "comment" is useful for understanding the column and 
> cube designing. May I propose to include the comment information into column 
> metadata.
> Both backend and GUI work needed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (KYLIN-2039) Refactor REST Request/Response Object into standalone library

2016-10-10 Thread Billy(Yiming) Liu (JIRA)

 [ 
https://issues.apache.org/jira/browse/KYLIN-2039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Billy(Yiming) Liu closed KYLIN-2039.

Resolution: Won't Fix

REST API could not guarantee the response body has the format backward 
compatible. So just leave the interface contract as simple as possible, to 
string only, not POJO objects. 

> Refactor REST Request/Response Object into standalone library
> -
>
> Key: KYLIN-2039
> URL: https://issues.apache.org/jira/browse/KYLIN-2039
> Project: Kylin
>  Issue Type: Improvement
>  Components: REST Service
>Reporter: Billy(Yiming) Liu
>Assignee: Zhong,Jason
>Priority: Minor
>
> Currently, the Request/Response objects locate at server-base project under 
> org/apache/kylin/rest/request[response,model]. They are POJOs which are used 
> to communicate between any REST client and Kylin Server. If someone wants to 
> integrate Kylin by REST API, he has to import kylin-server library. The 
> kylin-server is the project to host the Query/Job web server. This is library 
> will introduce almost all kylin backend libraries indirectly(by pom 
> dependency). But those are not the required components in client side. So I 
> will suggest refactoring some REST code into standalone lightweight library, 
> and make the client-server communication much easier. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (KYLIN-2076) Improve sample cube and data

2016-10-10 Thread Billy(Yiming) Liu (JIRA)

 [ 
https://issues.apache.org/jira/browse/KYLIN-2076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Billy(Yiming) Liu reassigned KYLIN-2076:


Assignee: Wang Cheng

> Improve sample cube and data
> 
>
> Key: KYLIN-2076
> URL: https://issues.apache.org/jira/browse/KYLIN-2076
> Project: Kylin
>  Issue Type: Improvement
>Reporter: liyang
>Assignee: Wang Cheng
>
> Improve sample cube and data to include a user column.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (KYLIN-2068) Import hive comment when sync tables

2016-10-10 Thread Billy(Yiming) Liu (JIRA)

 [ 
https://issues.apache.org/jira/browse/KYLIN-2068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Billy(Yiming) Liu updated KYLIN-2068:
-
Attachment: KYLIN-2068.patch

Hi [~Shaofengshi], the patch is ready for review.

> Import hive comment when sync tables
> 
>
> Key: KYLIN-2068
> URL: https://issues.apache.org/jira/browse/KYLIN-2068
> Project: Kylin
>  Issue Type: Improvement
>  Components: Metadata
>Reporter: Billy(Yiming) Liu
>Assignee: Shaofeng SHI
>Priority: Minor
>  Labels: newbie
> Attachments: KYLIN-2068.patch
>
>
> Current Sync Table imports the table names, column names and data type, 
> without comment. The "comment" is useful for understanding the column and 
> cube designing. May I propose to include the comment information into column 
> metadata.
> Both backend and GUI work needed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (KYLIN-2078) Can't see generated SQL at Web UI

2016-10-10 Thread Dayue Gao (JIRA)

 [ 
https://issues.apache.org/jira/browse/KYLIN-2078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dayue Gao resolved KYLIN-2078.
--
Resolution: Fixed

commit 94a9f38 to master

> Can't see generated SQL at Web UI
> -
>
> Key: KYLIN-2078
> URL: https://issues.apache.org/jira/browse/KYLIN-2078
> Project: Kylin
>  Issue Type: Bug
>Affects Versions: v1.5.4, v1.5.4.1
>Reporter: Dayue Gao
>Assignee: Dayue Gao
>
> After KYLIN-1966, user can't see generated SQL at cube page.
> {noformat}
> 2016-10-10 15:45:17,975 ERROR [http-bio-8080-exec-13] 
> controller.BasicController:44 :
> java.lang.NullPointerException
> at 
> org.apache.kylin.engine.EngineFactory.batchEngine(EngineFactory.java:44)
> at 
> org.apache.kylin.engine.EngineFactory.getJoinedFlatTableDesc(EngineFactory.java:58)
> at 
> org.apache.kylin.rest.controller.CubeController.getSql(CubeController.java:155)
> {noformat}
> Seems segmentName passed into CubeController#getSql is always null, should 
> use `EngineFactory.getJoinedFlatTableDesc(cube.getDescriptor())` instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (KYLIN-2076) Improve sample cube and data

2016-10-10 Thread liyang (JIRA)
liyang created KYLIN-2076:
-

 Summary: Improve sample cube and data
 Key: KYLIN-2076
 URL: https://issues.apache.org/jira/browse/KYLIN-2076
 Project: Kylin
  Issue Type: Improvement
Reporter: liyang


Improve sample cube and data to include a user column.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)