date:20180205

[jira] [Resolved] (KYLIN-3226) When user logs in with only query permission, 'N/A' is displayed in the cube's action list.

2018-02-05 Thread Zhixiong Chen (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zhixiong Chen resolved KYLIN-3226.
--
Resolution: Fixed

> When user logs in with only query permission, 'N/A' is displayed in the 
> cube's action list.
> ---
>
> Key: KYLIN-3226
> URL: https://issues.apache.org/jira/browse/KYLIN-3226
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.3.0
>Reporter: Peng Xing
>Assignee: Peng Xing
>Priority: Major
>  Labels: patch
> Fix For: v2.3.0
>
> Attachments: 
> 0001-KYLIN-3226-When-user-logs-in-with-only-query-permiss.patch, 
> NA_action.png, only_query_permission.png
>
>
> 1. Only give the 'QUERY' permission of project 'learn_kylin' for user 'xp', 
> refer to 'only_query_permission.png'.
> 2. When user 'xp' logins in, 'N/A' is displayed in the cube's action list, 
> refer to  'NA_action.png'.
> Please review the patch, thanks!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (KYLIN-3222) The function of editing 'Advanced Dictionaries' in cube is unavailable.

2018-02-05 Thread Zhixiong Chen (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zhixiong Chen resolved KYLIN-3222.
--
Resolution: Fixed

> The function of editing 'Advanced Dictionaries' in cube is unavailable.
> ---
>
> Key: KYLIN-3222
> URL: https://issues.apache.org/jira/browse/KYLIN-3222
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.3.0
>Reporter: Peng Xing
>Assignee: Peng Xing
>Priority: Major
>  Labels: patch
> Fix For: v2.3.0
>
> Attachments: 
> 0001-KYLIN-3222-The-function-of-editing-Advanced-Dictiona.patch, 
> modify_advanced_dictionary.png, modify_advanced_dictionary_no_effect.png
>
>
> There is a problem about editing 'Advanced Dictionaries' in cube, refer to 
> 'modify_advanced_dictionary.png' and 
> 'modify_advanced_dictionary_no_effect.png'.
> Please review the patch, thanks!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (KYLIN-3199) The login dialog should be closed when ldap user with no permission login correctly

2018-02-05 Thread Zhixiong Chen (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zhixiong Chen resolved KYLIN-3199.
--
Resolution: Fixed

> The login dialog should be closed when ldap user with no permission login 
> correctly
> ---
>
> Key: KYLIN-3199
> URL: https://issues.apache.org/jira/browse/KYLIN-3199
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.3.0
>Reporter: Peng Xing
>Assignee: Peng Xing
>Priority: Minor
>  Labels: patch
> Fix For: v2.3.0
>
> Attachments: 
> 0001-KYLIN-3199-The-login-dialog-should-be-closed-when-ld.patch, 
> ldap_user_login.png
>
>
> 1. Open ldap authentication, but I do not give the admin permission to group 
> 'xpGroup';
> 2. Create a ldap user 'xp', who belongs to group 'xpGroup', so this user has 
> none permission.
> 3. When user 'xp' login in, the above bar has showed and been enabled, but 
> the login dialog still show.
> 4. Then you can click any button on above bar.
> Please refer to 'ldap_user_login.png'
> I think the login dialog should be closed when you login in correctly, and 
> redirect to the 'Model' page, but this user has no permission.
> I have modified this issue, please review the patch, thanks!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (KYLIN-3226) When user logs in with only query permission, 'N/A' is displayed in the cube's action list.

2018-02-05 Thread Zhixiong Chen (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353487#comment-16353487
 ] 

Zhixiong Chen commented on KYLIN-3226:
--

Thanks [~xingpeng1]

This patch is fine with me.

I will merge it into Kylin master.

> When user logs in with only query permission, 'N/A' is displayed in the 
> cube's action list.
> ---
>
> Key: KYLIN-3226
> URL: https://issues.apache.org/jira/browse/KYLIN-3226
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.3.0
>Reporter: Peng Xing
>Assignee: Peng Xing
>Priority: Major
>  Labels: patch
> Fix For: v2.3.0
>
> Attachments: 
> 0001-KYLIN-3226-When-user-logs-in-with-only-query-permiss.patch, 
> NA_action.png, only_query_permission.png
>
>
> 1. Only give the 'QUERY' permission of project 'learn_kylin' for user 'xp', 
> refer to 'only_query_permission.png'.
> 2. When user 'xp' logins in, 'N/A' is displayed in the cube's action list, 
> refer to  'NA_action.png'.
> Please review the patch, thanks!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (KYLIN-3197) When ldap is opened, I use an ignored case user to login, the page does not respond.

2018-02-05 Thread jiatao.tao (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

jiatao.tao updated KYLIN-3197:
--
Attachment: image-2018-02-06-14-09-32-591.png

> When ldap is opened, I use an ignored case user to login, the page does not 
> respond.
> 
>
> Key: KYLIN-3197
> URL: https://issues.apache.org/jira/browse/KYLIN-3197
> Project: Kylin
>  Issue Type: Bug
>  Components: Security
>Affects Versions: v2.3.0
>Reporter: Peng Xing
>Assignee: Peng Xing
>Priority: Major
>  Labels: patch
> Fix For: v2.3.0
>
> Attachments: 
> 0001-KYLIN-3197-When-ldap-is-opened-I-use-an-ignored-case.patch, 
> image-2018-01-25-17-22-39-970.png, image-2018-02-06-14-09-32-591.png
>
>
> When ldap is opened, I config the kylin.properties, and give wkhGroup the 
> admin permission.
> {code:java}
> ## Admin roles in LDAP, for ldap and saml
> kylin.security.acl.admin-role=wkhGroup
> {code}
> then I create a new user named 'wkh' whose group is 'wkhGroup', then I use 
> '{color:#ff}wkh{color}' to login in, which is normal.
>  But when I use '{color:#ff}WKH{color}' to login in, the page does not 
> respond.
>  I analyze the backgroud code, and find the function of 
> 'org.apache.kylin.rest.security.LDAPAuthoritiesPopulator.getGroupMembershipRoles(String,
>  String)' has problem.
>  When userDn is 
> "uid={color:#ff}wkh{color},ou=People,ou=defaultCluster,dc=zdh,dc=com" and 
> username is "{color:#ff}WKH{color}", then authorities will be null by the 
> follow code:
> {code:java}
> Set authorities = super.getGroupMembershipRoles(userDn, 
> username);
> {code}
> So I have added 'getAdditionalRoles' function to get the authorities again.
>  I have test the patch, please review, thanks!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (KYLIN-3242) export result should use alias too

2018-02-05 Thread peng.jianhua (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

peng.jianhua updated KYLIN-3242:

Description: Now the column alias is not work on export result

> export result should use alias too
> --
>
> Key: KYLIN-3242
> URL: https://issues.apache.org/jira/browse/KYLIN-3242
> Project: Kylin
>  Issue Type: Bug
>Reporter: peng.jianhua
>Assignee: peng.jianhua
>Priority: Minor
> Attachments: 0001-KYLIN-3242.patch
>
>
> Now the column alias is not work on export result



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (KYLIN-3242) export result should use alias too

2018-02-05 Thread peng.jianhua (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

peng.jianhua updated KYLIN-3242:

Attachment: 0001-KYLIN-3242.patch

> export result should use alias too
> --
>
> Key: KYLIN-3242
> URL: https://issues.apache.org/jira/browse/KYLIN-3242
> Project: Kylin
>  Issue Type: Bug
>Reporter: peng.jianhua
>Assignee: peng.jianhua
>Priority: Minor
> Attachments: 0001-KYLIN-3242.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (KYLIN-3242) export result should use alias too

2018-02-05 Thread peng.jianhua (JIRA)

peng.jianhua created KYLIN-3242:
---

 Summary: export result should use alias too
 Key: KYLIN-3242
 URL: https://issues.apache.org/jira/browse/KYLIN-3242
 Project: Kylin
  Issue Type: Bug
Reporter: peng.jianhua
Assignee: peng.jianhua






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (KYLIN-2933) Fix compilation against the Kafka 1.0.0 release

2018-02-05 Thread Shaofeng SHI (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shaofeng SHI updated KYLIN-2933:

Fix Version/s: (was: v2.3.0)

> Fix compilation against the Kafka 1.0.0 release
> ---
>
> Key: KYLIN-2933
> URL: https://issues.apache.org/jira/browse/KYLIN-2933
> Project: Kylin
>  Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Shaofeng SHI
>Priority: Major
>
> Due to change of class location of SecurityProtocol, KafkaClusterConfig.java 
> needs to be modified so that it compiles against the Kafka 1.0.0 release:
> {code}
> -import org.apache.kafka.common.protocol.SecurityProtocol;
> +import org.apache.kafka.common.security.auth.SecurityProtocol;
> {code}
> A compatibility layer may be needed if we support multiple Kafka releases 
> simultaneously.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (KYLIN-3222) The function of editing 'Advanced Dictionaries' in cube is unavailable.

2018-02-05 Thread Zhixiong Chen (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353233#comment-16353233
 ] 

Zhixiong Chen commented on KYLIN-3222:
--

Thanks [~xingpeng1]

This patch is fine with me.

I will merge it into Kylin master.

> The function of editing 'Advanced Dictionaries' in cube is unavailable.
> ---
>
> Key: KYLIN-3222
> URL: https://issues.apache.org/jira/browse/KYLIN-3222
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.3.0
>Reporter: Peng Xing
>Assignee: Peng Xing
>Priority: Major
>  Labels: patch
> Fix For: v2.3.0
>
> Attachments: 
> 0001-KYLIN-3222-The-function-of-editing-Advanced-Dictiona.patch, 
> modify_advanced_dictionary.png, modify_advanced_dictionary_no_effect.png
>
>
> There is a problem about editing 'Advanced Dictionaries' in cube, refer to 
> 'modify_advanced_dictionary.png' and 
> 'modify_advanced_dictionary_no_effect.png'.
> Please review the patch, thanks!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (KYLIN-3239) Refactor the ACL code about "checkPermission" and "hasPermission"

2018-02-05 Thread Guangyao Li (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353215#comment-16353215
 ] 

Guangyao Li commented on KYLIN-3239:


There are two permissions patterns "checkPermission" and "hasPermission" in the 
file "AclEvaluate.Java".

The "checkPermission" method should check the permission of the current user 
and doesn't need to return a value. This is a void method.

The "hasPermission" method is a boolean method, and should return a value about 
"ture" or "false".

The refactoring covers the root file "AclEvaluate.Java" and some else files 
using "checkPermission" or "hasPermission" method.

Now, the files using "checkPermission" or "hasPermission" method have 
"ProjectController.Java, CubeService.Java, ModelService.Java, 
ProjectService.Java".

> Refactor the ACL code about "checkPermission" and "hasPermission"
> -
>
> Key: KYLIN-3239
> URL: https://issues.apache.org/jira/browse/KYLIN-3239
> Project: Kylin
>  Issue Type: Improvement
>  Components: Security
>Affects Versions: v2.2.0
>Reporter: Guangyao Li
>Priority: Minor
> Fix For: v2.3.0
>
>
> According to the design of "checkPermission" and "HasPermission",
> Refactoring the ACL code



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (KYLIN-3189) Documents for kylin python client

2018-02-05 Thread Billy Liu (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Billy Liu updated KYLIN-3189:
-
Priority: Major  (was: Minor)

> Documents for kylin python client
> -
>
> Key: KYLIN-3189
> URL: https://issues.apache.org/jira/browse/KYLIN-3189
> Project: Kylin
>  Issue Type: Task
>  Components: Documentation
>Reporter: yongjie zhao
>Assignee: yongjie zhao
>Priority: Major
> Fix For: v2.3.0
>
> Attachments: 0001-Documents-for-kylin-python-client.patch, 
> 0001-minor.-Update-Kylin-client-for-python-fix-homepage-d.patch
>
>
> * Update documents client for python
>  * Fix homepage docs link



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (KYLIN-3189) Documents for kylin python client

2018-02-05 Thread Billy Liu (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Billy Liu resolved KYLIN-3189.
--
Resolution: Fixed

Thanks [~zog]. Very good article. Commits at 
https://git1-us-west.apache.org/repos/asf?p=kylin.git;a=commit;h=d79adacf and 
https://git1-us-west.apache.org/repos/asf?p=kylin.git;a=commit;h=a75d7adc

> Documents for kylin python client
> -
>
> Key: KYLIN-3189
> URL: https://issues.apache.org/jira/browse/KYLIN-3189
> Project: Kylin
>  Issue Type: Task
>  Components: Documentation
>Reporter: yongjie zhao
>Assignee: yongjie zhao
>Priority: Minor
> Fix For: v2.3.0
>
> Attachments: 0001-Documents-for-kylin-python-client.patch, 
> 0001-minor.-Update-Kylin-client-for-python-fix-homepage-d.patch
>
>
> * Update documents client for python
>  * Fix homepage docs link



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (KYLIN-2980) Remove getKey/Value setKey/Value from Kylin's Pair.

2018-02-05 Thread Billy Liu (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-2980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16352498#comment-16352498
 ] 

Billy Liu commented on KYLIN-2980:
--

Since the original commit is lost, a new commit is appended. 
http://git-wip-us.apache.org/repos/asf/kylin/commit/5bc5e659

> Remove getKey/Value setKey/Value from Kylin's Pair.
> ---
>
> Key: KYLIN-2980
> URL: https://issues.apache.org/jira/browse/KYLIN-2980
> Project: Kylin
>  Issue Type: Improvement
>Reporter: jiatao.tao
>Assignee: jiatao.tao
>Priority: Trivial
> Fix For: v2.3.0
>
>
> Pair has no semantic about key/value. And when serializing/deserializing Pair 
> will both has first/second and key/value.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (KYLIN-3219) Fix NPE when updating metrics during Spark CubingJob

2018-02-05 Thread Billy Liu (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Billy Liu updated KYLIN-3219:
-
Summary: Fix NPE when updating metrics during Spark CubingJob  (was: Fix 
NPE in CubingJob)

> Fix NPE when updating metrics during Spark CubingJob
> 
>
> Key: KYLIN-3219
> URL: https://issues.apache.org/jira/browse/KYLIN-3219
> Project: Kylin
>  Issue Type: Bug
>  Components: Job Engine
>Affects Versions: v2.3.0
>Reporter: Peng Xing
>Assignee: Peng Xing
>Priority: Minor
> Fix For: v2.3.0
>
> Attachments: 0001-KYLIN-3219.patch
>
>
> When using spark engine, there is no 'Build Cube In-Mem' step task,
> 'getTaskByName(ExecutableConstants.STEP_NAME_BUILD_IN_MEM_CUBE).getDuration()'
>  will get NullPointerException
> error log:
> java.lang.NullPointerException
>  at org.apache.kylin.engine.mr.CubingJob.updateMetrics(CubingJob.java:284)
>  at org.apache.kylin.engine.mr.CubingJob.onStatusChange(CubingJob.java:272)
>  at 
> org.apache.kylin.job.execution.DefaultChainedExecutable.onExecuteFinished(DefaultChainedExecutable.java:132)
>  at org.apache.kylin.engine.mr.CubingJob.onExecuteFinished(CubingJob.java:266)
>  at 
> org.apache.kylin.job.execution.AbstractExecutable.onExecuteFinishedWithRetry(AbstractExecutable.java:98)
>  at 
> org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:175)
>  at 
> org.apache.kylin.job.impl.threadpool.DefaultScheduler$JobRunner.run(DefaultScheduler.java:300)
>  at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1152)
>  at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:622)
>  at java.lang.Thread.run(Thread.java:745)
> 2018-01-31 18:15:20,443 ERROR [pool-11-thread-10] 
> threadpool.DefaultScheduler:302 : ExecuteException 
> job:693e2cd6-c7e7-4ed9-b1d6-e7ad86f5c501
> org.apache.kylin.job.exception.ExecuteException: 
> java.lang.NullPointerException
>  at 
> org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:179)
>  at 
> org.apache.kylin.job.impl.threadpool.DefaultScheduler$JobRunner.run(DefaultScheduler.java:300)
>  at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1152)
>  at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:622)
>  at java.lang.Thread.run(Thread.java:745)
> Caused by: java.lang.NullPointerException
>  at org.apache.kylin.engine.mr.CubingJob.updateMetrics(CubingJob.java:284)
>  at org.apache.kylin.engine.mr.CubingJob.onStatusChange(CubingJob.java:272)
>  at 
> org.apache.kylin.job.execution.DefaultChainedExecutable.onExecuteFinished(DefaultChainedExecutable.java:132)
>  at org.apache.kylin.engine.mr.CubingJob.onExecuteFinished(CubingJob.java:266)
>  at 
> org.apache.kylin.job.execution.AbstractExecutable.onExecuteFinishedWithRetry(AbstractExecutable.java:98)
>  at 
> org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:175)
>  ... 4 more



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (KYLIN-3228) Should remove the related segment when deleting a job

2018-02-05 Thread Billy Liu (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Billy Liu resolved KYLIN-3228.
--
Resolution: Duplicate

> Should remove the related segment when deleting a job
> -
>
> Key: KYLIN-3228
> URL: https://issues.apache.org/jira/browse/KYLIN-3228
> Project: Kylin
>  Issue Type: Bug
>  Components: REST Service, Web 
>Affects Versions: v2.2.0
>Reporter: youcheng.zhang
>Priority: Major
> Fix For: v2.3.0
>
>
> When delete error job in the web page, kylin doesn't  delete the relative 
> segment, and the segment remain with status not ready, you can't delete it or 
> refresh it either.
> Even after use StorageCleanupJob, the segment still remains.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Closed] (KYLIN-3228) Should remove the related segment when deleting a job

2018-02-05 Thread Billy Liu (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Billy Liu closed KYLIN-3228.


> Should remove the related segment when deleting a job
> -
>
> Key: KYLIN-3228
> URL: https://issues.apache.org/jira/browse/KYLIN-3228
> Project: Kylin
>  Issue Type: Bug
>  Components: REST Service, Web 
>Affects Versions: v2.2.0
>Reporter: youcheng.zhang
>Priority: Major
> Fix For: v2.3.0
>
>
> When delete error job in the web page, kylin doesn't  delete the relative 
> segment, and the segment remain with status not ready, you can't delete it or 
> refresh it either.
> Even after use StorageCleanupJob, the segment still remains.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (KYLIN-3239) Refactor the ACL code about "checkPermission" and "hasPermission"

2018-02-05 Thread Billy Liu (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16352401#comment-16352401
 ] 

Billy Liu commented on KYLIN-3239:
--

Hello [~Guangyao Li], could you explain more why the refactor is required, and 
the scope to cover.

> Refactor the ACL code about "checkPermission" and "hasPermission"
> -
>
> Key: KYLIN-3239
> URL: https://issues.apache.org/jira/browse/KYLIN-3239
> Project: Kylin
>  Issue Type: Improvement
>  Components: Security
>Affects Versions: v2.2.0
>Reporter: Guangyao Li
>Priority: Minor
> Fix For: v2.3.0
>
>
> According to the design of "checkPermission" and "HasPermission",
> Refactoring the ACL code



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (KYLIN-3241) When refresh on 'Add Cube Page', a blank page will appear.

2018-02-05 Thread Peng Xing (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16352311#comment-16352311
 ] 

Peng Xing commented on KYLIN-3241:
--

OK，I have closed this issue.

> When refresh on 'Add Cube Page', a blank page will appear.
> --
>
> Key: KYLIN-3241
> URL: https://issues.apache.org/jira/browse/KYLIN-3241
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.3.0
>Reporter: Peng Xing
>Assignee: Peng Xing
>Priority: Minor
> Fix For: v2.3.0
>
> Attachments: 0001-KYLIN-3241.patch
>
>
> When refresh on 'Add Cube Page', a blank page will appear,
> there is a "Cannot read property 'indexOf' of undefined" error in the console



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Closed] (KYLIN-3241) When refresh on 'Add Cube Page', a blank page will appear.

2018-02-05 Thread Peng Xing (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peng Xing closed KYLIN-3241.

Resolution: Duplicate

> When refresh on 'Add Cube Page', a blank page will appear.
> --
>
> Key: KYLIN-3241
> URL: https://issues.apache.org/jira/browse/KYLIN-3241
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.3.0
>Reporter: Peng Xing
>Assignee: Peng Xing
>Priority: Minor
> Fix For: v2.3.0
>
> Attachments: 0001-KYLIN-3241.patch
>
>
> When refresh on 'Add Cube Page', a blank page will appear,
> there is a "Cannot read property 'indexOf' of undefined" error in the console



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (KYLIN-3241) When refresh on 'Add Cube Page', a blank page will appear.

2018-02-05 Thread peng.jianhua (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16352295#comment-16352295
 ] 

peng.jianhua commented on KYLIN-3241:
-

OK，I will close this jira.

> When refresh on 'Add Cube Page', a blank page will appear.
> --
>
> Key: KYLIN-3241
> URL: https://issues.apache.org/jira/browse/KYLIN-3241
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.3.0
>Reporter: Peng Xing
>Assignee: Peng Xing
>Priority: Minor
> Fix For: v2.3.0
>
> Attachments: 0001-KYLIN-3241.patch
>
>
> When refresh on 'Add Cube Page', a blank page will appear,
> there is a "Cannot read property 'indexOf' of undefined" error in the console



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Issue Comment Deleted] (KYLIN-3241) When refresh on 'Add Cube Page', a blank page will appear.

2018-02-05 Thread peng.jianhua (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

peng.jianhua updated KYLIN-3241:

Comment: was deleted

(was: OK，I will close this jira.)

> When refresh on 'Add Cube Page', a blank page will appear.
> --
>
> Key: KYLIN-3241
> URL: https://issues.apache.org/jira/browse/KYLIN-3241
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.3.0
>Reporter: Peng Xing
>Assignee: Peng Xing
>Priority: Minor
> Fix For: v2.3.0
>
> Attachments: 0001-KYLIN-3241.patch
>
>
> When refresh on 'Add Cube Page', a blank page will appear,
> there is a "Cannot read property 'indexOf' of undefined" error in the console



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (KYLIN-3241) When refresh on 'Add Cube Page', a blank page will appear.

2018-02-05 Thread Zhixiong Chen (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16352273#comment-16352273
 ] 

Zhixiong Chen commented on KYLIN-3241:
--

Hi,[~xingpeng1]

There is a jira about this issue already.  KYLIN-3130

https://issues.apache.org/jira/browse/KYLIN-3130

So I close this jira.

You could comment and attach patch in that jira

> When refresh on 'Add Cube Page', a blank page will appear.
> --
>
> Key: KYLIN-3241
> URL: https://issues.apache.org/jira/browse/KYLIN-3241
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.3.0
>Reporter: Peng Xing
>Assignee: Peng Xing
>Priority: Minor
> Fix For: v2.3.0
>
> Attachments: 0001-KYLIN-3241.patch
>
>
> When refresh on 'Add Cube Page', a blank page will appear,
> there is a "Cannot read property 'indexOf' of undefined" error in the console



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (KYLIN-3224) data can't show when use kylin pushdown model

2018-02-05 Thread peng.jianhua (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

peng.jianhua updated KYLIN-3224:

Component/s: Query Engine

> data can't show when use kylin pushdown model 
> --
>
> Key: KYLIN-3224
> URL: https://issues.apache.org/jira/browse/KYLIN-3224
> Project: Kylin
>  Issue Type: Bug
>  Components: Query Engine, Web 
>Affects Versions: v2.2.0, v2.3.0
>Reporter: peng.jianhua
>Assignee: peng.jianhua
>Priority: Major
> Fix For: v2.3.0
>
> Attachments: 0001-KYLIN-3224.patch, 01.PNG, 02.PNG, 03.PNG
>
>
> select * from kylin_sales
> use pushdown model,and the result shows like 01.png



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (KYLIN-3224) data can't show when use kylin pushdown model

2018-02-05 Thread peng.jianhua (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16352243#comment-16352243
 ] 

peng.jianhua commented on KYLIN-3224:
-

fine，i'll test and verify later.

> data can't show when use kylin pushdown model 
> --
>
> Key: KYLIN-3224
> URL: https://issues.apache.org/jira/browse/KYLIN-3224
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.2.0, v2.3.0
>Reporter: peng.jianhua
>Assignee: peng.jianhua
>Priority: Major
> Fix For: v2.3.0
>
> Attachments: 0001-KYLIN-3224.patch, 01.PNG, 02.PNG, 03.PNG
>
>
> select * from kylin_sales
> use pushdown model,and the result shows like 01.png



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (KYLIN-3241) When refresh on 'Add Cube Page', a blank page will appear.

2018-02-05 Thread Peng Xing (JIRA)

Peng Xing created KYLIN-3241:


 Summary: When refresh on 'Add Cube Page', a blank page will appear.
 Key: KYLIN-3241
 URL: https://issues.apache.org/jira/browse/KYLIN-3241
 Project: Kylin
  Issue Type: Bug
  Components: Web 
Affects Versions: v2.3.0
Reporter: Peng Xing
Assignee: Peng Xing
 Fix For: v2.3.0


When refresh on 'Add Cube Page', a blank page will appear,
there is a "Cannot read property 'indexOf' of undefined" error in the console



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (KYLIN-2672) Only clean necessary cache for CubeMigrationCLI

2018-02-05 Thread kangkaisen (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-2672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16352231#comment-16352231
 ] 

kangkaisen commented on KYLIN-2672:
---

Thanks liyang and Billy.  OK, I will add a test for the new API.

> Only clean necessary cache for CubeMigrationCLI
> ---
>
> Key: KYLIN-2672
> URL: https://issues.apache.org/jira/browse/KYLIN-2672
> Project: Kylin
>  Issue Type: Improvement
>  Components: Tools, Build and Test
>Affects Versions: v2.0.0
>Reporter: kangkaisen
>Assignee: kangkaisen
>Priority: Major
> Fix For: v2.3.0
>
> Attachments: KYLIN-2672.patch
>
>
> Currently, we simply clear ALL cache in  CubeMigrationCLI. which will make a 
> few of queries slower in prod env when we have many tables, models, cubes and 
> migrate cube often.
> So, we could only clean necessary cache for CubeMigrationCLI.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (KYLIN-2672) Only clean necessary cache for CubeMigrationCLI

2018-02-05 Thread liyang (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-2672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16352228#comment-16352228
 ] 

liyang commented on KYLIN-2672:
---

I rebased and merged the patch into branch KYLIN-2672. The code looks good. The 
only concern is the lack of test cases.

[~kangkaisen], could you add test cases to cover the newly added feature?

 

 

> Only clean necessary cache for CubeMigrationCLI
> ---
>
> Key: KYLIN-2672
> URL: https://issues.apache.org/jira/browse/KYLIN-2672
> Project: Kylin
>  Issue Type: Improvement
>  Components: Tools, Build and Test
>Affects Versions: v2.0.0
>Reporter: kangkaisen
>Assignee: kangkaisen
>Priority: Major
> Fix For: v2.3.0
>
> Attachments: KYLIN-2672.patch
>
>
> Currently, we simply clear ALL cache in  CubeMigrationCLI. which will make a 
> few of queries slower in prod env when we have many tables, models, cubes and 
> migrate cube often.
> So, we could only clean necessary cache for CubeMigrationCLI.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (KYLIN-3224) data can't show when use kylin pushdown model

2018-02-05 Thread Zhixiong Chen (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16352219#comment-16352219
 ] 

Zhixiong Chen commented on KYLIN-3224:
--

However if you query by cube , the data is normal.

So I don't think the issue is in front-end.

Maybe you could fine why query by cube and query by pushdown show differently ?

> data can't show when use kylin pushdown model 
> --
>
> Key: KYLIN-3224
> URL: https://issues.apache.org/jira/browse/KYLIN-3224
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.2.0, v2.3.0
>Reporter: peng.jianhua
>Assignee: peng.jianhua
>Priority: Major
> Fix For: v2.3.0
>
> Attachments: 0001-KYLIN-3224.patch, 01.PNG, 02.PNG, 03.PNG
>
>
> select * from kylin_sales
> use pushdown model,and the result shows like 01.png



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (KYLIN-3240) Refine the exception when cannot find JobInstance in JobController

2018-02-05 Thread Zhong Yanghong (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zhong Yanghong updated KYLIN-3240:
--
Description: When calling the rest api in {{JobController}}, if cannot 
initialize the related JobInstance based on the job id, BadRequestException 
should be thrown rather than InternalErrorException.

> Refine the exception when cannot find JobInstance in JobController
> --
>
> Key: KYLIN-3240
> URL: https://issues.apache.org/jira/browse/KYLIN-3240
> Project: Kylin
>  Issue Type: Sub-task
>Reporter: Zhong Yanghong
>Assignee: Zhong Yanghong
>Priority: Major
>
> When calling the rest api in {{JobController}}, if cannot initialize the 
> related JobInstance based on the job id, BadRequestException should be thrown 
> rather than InternalErrorException.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (KYLIN-3240) Refine the exception when cannot find JobInstance in JobController

2018-02-05 Thread Zhong Yanghong (JIRA)

Zhong Yanghong created KYLIN-3240:
-

 Summary: Refine the exception when cannot find JobInstance in 
JobController
 Key: KYLIN-3240
 URL: https://issues.apache.org/jira/browse/KYLIN-3240
 Project: Kylin
  Issue Type: Sub-task
Reporter: Zhong Yanghong
Assignee: Zhong Yanghong






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (KYLIN-3225) java.lang.ClassNotFoundException: org.apache.kylin.jdbc.Driver

2018-02-05 Thread Bowen Yang (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16352213#comment-16352213
 ] 

Bowen Yang commented on KYLIN-3225:
---

After changing test to compile , it works.

Thank you man

 

> java.lang.ClassNotFoundException: org.apache.kylin.jdbc.Driver
> --
>
> Key: KYLIN-3225
> URL: https://issues.apache.org/jira/browse/KYLIN-3225
> Project: Kylin
>  Issue Type: Bug
>  Components: Driver - JDBC
>Affects Versions: v2.2.0
>Reporter: Bowen Yang
>Assignee: Dong Li
>Priority: Major
> Attachments: KylinClient.java, 
> WeChatWorkScreenshot_9a071c7d-18b3-445a-8f99-1bed111250b3.png, 
> WeChatWorkScreenshot_de991bc7-7635-49ab-a53b-08899cd7ef4b.png, pom.xml
>
>
> Hi guys,
> I am using jdbc to connect kylin which version is 2.2.0 to analyze something, 
> but I got "java.lang.ClassNotFoundException: org.apache.kylin.jdbc.Driver" 
> exception.
> I tried 1.5.3 and 1.6.0 version, but this exception still happened.
> Is it a bug in the kylin jdbc driver? The attachments are my pom, java code 
> and screenshots, please help to see this issue. Thanks.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (KYLIN-3236) The function 'reGenerateAdvancedDict()' has an error logical judgment, which will cause an exception when you edit the cube.

2018-02-05 Thread Zhixiong Chen (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16352206#comment-16352206
 ] 

Zhixiong Chen commented on KYLIN-3236:
--

Do you use TRANS_ID in count_distinct measure ?

> The function 'reGenerateAdvancedDict()' has an error logical judgment, which 
> will cause an exception when you edit the cube.
> 
>
> Key: KYLIN-3236
> URL: https://issues.apache.org/jira/browse/KYLIN-3236
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.3.0
>Reporter: Peng Xing
>Assignee: Peng Xing
>Priority: Major
>  Labels: patch
> Attachments: 
> 0001-KYLIN-3236-The-function-reGenerateAdvancedDict-has-a.patch, 1.PNG, 
> 2.PNG, 3.PNG
>
>
> # When remove deprecated distinct measures, the code has an error logical 
> judgment In function 'reGenerateAdvancedDict()', as follows:
> {code:java}
> //remove deprecated distinct measures
> angular.forEach($scope.cubeMetaFrame.dictionaries, function (dict, index) 
> {
>   if (distinctMeasures.indexOf(dict.column) === -1 && 
> reuseColumns.indexOf(dict.column) === -1) {
> $scope.cubeMetaFrame.dictionaries.splice(index, 1);
>   }
> });
> {code}
> This will result in accidental deletion of advanced dictionaries.
>  Please review the patch, thanks!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (KYLIN-3236) The function 'reGenerateAdvancedDict()' has an error logical judgment, which will cause an exception when you edit the cube.

2018-02-05 Thread Peng Xing (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peng Xing updated KYLIN-3236:
-
Attachment: 2.PNG
1.PNG
3.PNG

> The function 'reGenerateAdvancedDict()' has an error logical judgment, which 
> will cause an exception when you edit the cube.
> 
>
> Key: KYLIN-3236
> URL: https://issues.apache.org/jira/browse/KYLIN-3236
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.3.0
>Reporter: Peng Xing
>Assignee: Peng Xing
>Priority: Major
>  Labels: patch
> Attachments: 
> 0001-KYLIN-3236-The-function-reGenerateAdvancedDict-has-a.patch, 1.PNG, 
> 2.PNG, 3.PNG
>
>
> # When remove deprecated distinct measures, the code has an error logical 
> judgment In function 'reGenerateAdvancedDict()', as follows:
> {code:java}
> //remove deprecated distinct measures
> angular.forEach($scope.cubeMetaFrame.dictionaries, function (dict, index) 
> {
>   if (distinctMeasures.indexOf(dict.column) === -1 && 
> reuseColumns.indexOf(dict.column) === -1) {
> $scope.cubeMetaFrame.dictionaries.splice(index, 1);
>   }
> });
> {code}
> This will result in accidental deletion of advanced dictionaries.
>  Please review the patch, thanks!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (KYLIN-3236) The function 'reGenerateAdvancedDict()' has an error logical judgment, which will cause an exception when you edit the cube.

2018-02-05 Thread Peng Xing (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16352201#comment-16352201
 ] 

Peng Xing commented on KYLIN-3236:
--

Hi [~Zhixiong Chen], thanks for your reply, I'm so sorry, maybe I did not 
express clearly.
Please look at these three picture attachments, it indeed has some problem, 
then I find out the code has an error logical judgment.

> The function 'reGenerateAdvancedDict()' has an error logical judgment, which 
> will cause an exception when you edit the cube.
> 
>
> Key: KYLIN-3236
> URL: https://issues.apache.org/jira/browse/KYLIN-3236
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.3.0
>Reporter: Peng Xing
>Assignee: Peng Xing
>Priority: Major
>  Labels: patch
> Attachments: 
> 0001-KYLIN-3236-The-function-reGenerateAdvancedDict-has-a.patch, 1.PNG, 
> 2.PNG, 3.PNG
>
>
> # When remove deprecated distinct measures, the code has an error logical 
> judgment In function 'reGenerateAdvancedDict()', as follows:
> {code:java}
> //remove deprecated distinct measures
> angular.forEach($scope.cubeMetaFrame.dictionaries, function (dict, index) 
> {
>   if (distinctMeasures.indexOf(dict.column) === -1 && 
> reuseColumns.indexOf(dict.column) === -1) {
> $scope.cubeMetaFrame.dictionaries.splice(index, 1);
>   }
> });
> {code}
> This will result in accidental deletion of advanced dictionaries.
>  Please review the patch, thanks!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Comment Edited] (KYLIN-3224) data can't show when use kylin pushdown model

2018-02-05 Thread peng.jianhua (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16352164#comment-16352164
 ] 

peng.jianhua edited comment on KYLIN-3224 at 2/5/18 9:45 AM:
-

Hi,[~Zhixiong Chen].
We can get the result from backend,the export result has result.
but it can't show on the webpage,I think it is a web issue.

In ui-grid.js,the function 
{code:java}
s.preEval = function (path) 
{code}
has description

{code:java}
* @description
 * Takes a field path and converts it to bracket notation to allow for 
special characters in path
 * @example
 * 
 * gridUtil.preEval('property') == 'property'
 * gridUtil.preEval('nested.deep.prop-erty') = "nested['deep']['prop-erty']"
 * 
{code}

if the data comes from pushdown,the column name will be 
kylin_sales.trans_id(just for example,if we don't add alias).
so the function preEval will be like this,
gridUtil.preEval('entity.kylin_sales.trans_id') = 
"entity['kylin_sales']['trans_id']",
so we can't find the value by the key ['kylin_sales']['trans_id'],
the function preEval should be like:
gridUtil.preEval('entity.kylin_sales.trans_id') = 
"entity['kylin_sales.trans_id']",



02.png is key and value.
03.png shows that we can't get value by [kylin_sales][slr_segment_cd]



was (Author: peng.jianhua):
Hi,[~Zhixiong Chen].
We can get the result from backend,the export result has result.
but it can't show on the webpage,I think it is a web issue.

In ui-grid.js,the function 
{code:java}
s.preEval = function (path) 
{code}
has description

{code:java}
* @description
 * Takes a field path and converts it to bracket notation to allow for 
special characters in path
 * @example
 * 
 * gridUtil.preEval('property') == 'property'
 * gridUtil.preEval('nested.deep.prop-erty') = "nested['deep']['prop-erty']"
 * 
{code}

if the data comes from pushdown,the column name will be 
kylin_sales.trans_id(just for example,if we don't add alias).
so the function preEval will be like this,
gridUtil.preEval('entity.kylin_sales.trans_id') = 
"entity['kylin_sales']['trans_id']",
so we can't find the value by the key ['kylin_sales']['trans_id'],
the function preEval should be like:
gridUtil.preEval('entity.kylin_sales.trans_id') = 
"entity['kylin_sales.trans_id']",




> data can't show when use kylin pushdown model 
> --
>
> Key: KYLIN-3224
> URL: https://issues.apache.org/jira/browse/KYLIN-3224
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.2.0, v2.3.0
>Reporter: peng.jianhua
>Assignee: peng.jianhua
>Priority: Major
> Fix For: v2.3.0
>
> Attachments: 0001-KYLIN-3224.patch, 01.PNG, 02.PNG, 03.PNG
>
>
> select * from kylin_sales
> use pushdown model,and the result shows like 01.png



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (KYLIN-3237) Fix NPE

2018-02-05 Thread Zhong Yanghong (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zhong Yanghong updated KYLIN-3237:
--
Summary: Fix NPE  (was: Improve the way of dealing with NPE)

> Fix NPE
> ---
>
> Key: KYLIN-3237
> URL: https://issues.apache.org/jira/browse/KYLIN-3237
> Project: Kylin
>  Issue Type: Improvement
>Reporter: Zhong Yanghong
>Assignee: Zhong Yanghong
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (KYLIN-3238) Fix NPE when CubeInstance.getLatestReadySegment() returns null

2018-02-05 Thread Zhong Yanghong (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zhong Yanghong updated KYLIN-3238:
--
Issue Type: Sub-task  (was: Improvement)
Parent: KYLIN-3237

> Fix NPE when CubeInstance.getLatestReadySegment() returns null
> --
>
> Key: KYLIN-3238
> URL: https://issues.apache.org/jira/browse/KYLIN-3238
> Project: Kylin
>  Issue Type: Sub-task
>Reporter: Zhong Yanghong
>Assignee: Zhong Yanghong
>Priority: Major
>
> Currently we suppose if a cube is in READY status, there should exist READY 
> segments. Then when this kind of cube is selected as a candidate for a query, 
> neither {{getLatestReadySegment}} in {{CubeInstance}} will return null, nor 
> {{cube.getSegments().get(0)}} will throw {{IndexOutOfBoundsException}}.
> However, currently we allow to delete segments by REST API when cube is in 
> READY status, which I think it's not reasonable. To deal with this issue, I 
> propose not to allow segment deletion by REST API when its cube is in READY 
> status.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (KYLIN-3224) data can't show when use kylin pushdown model

2018-02-05 Thread peng.jianhua (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

peng.jianhua updated KYLIN-3224:

Attachment: 03.PNG
02.PNG

> data can't show when use kylin pushdown model 
> --
>
> Key: KYLIN-3224
> URL: https://issues.apache.org/jira/browse/KYLIN-3224
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.2.0, v2.3.0
>Reporter: peng.jianhua
>Assignee: peng.jianhua
>Priority: Major
> Fix For: v2.3.0
>
> Attachments: 0001-KYLIN-3224.patch, 01.PNG, 02.PNG, 03.PNG
>
>
> select * from kylin_sales
> use pushdown model,and the result shows like 01.png



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (KYLIN-3236) The function 'reGenerateAdvancedDict()' has an error logical judgment, which will cause an exception when you edit the cube.

2018-02-05 Thread Zhixiong Chen (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16352184#comment-16352184
 ] 

Zhixiong Chen commented on KYLIN-3236:
--

Hi,[~xingpeng1]

I think it isn't a bug.

Global dictionary only used in count_distinct measure that return type is 
'bitmap'.

So Kaisen in KYLIN-2604 remove the dictionary that not be used in 
count_distinct.

 

> The function 'reGenerateAdvancedDict()' has an error logical judgment, which 
> will cause an exception when you edit the cube.
> 
>
> Key: KYLIN-3236
> URL: https://issues.apache.org/jira/browse/KYLIN-3236
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.3.0
>Reporter: Peng Xing
>Assignee: Peng Xing
>Priority: Major
>  Labels: patch
> Attachments: 
> 0001-KYLIN-3236-The-function-reGenerateAdvancedDict-has-a.patch
>
>
> # When remove deprecated distinct measures, the code has an error logical 
> judgment In function 'reGenerateAdvancedDict()', as follows:
> {code:java}
> //remove deprecated distinct measures
> angular.forEach($scope.cubeMetaFrame.dictionaries, function (dict, index) 
> {
>   if (distinctMeasures.indexOf(dict.column) === -1 && 
> reuseColumns.indexOf(dict.column) === -1) {
> $scope.cubeMetaFrame.dictionaries.splice(index, 1);
>   }
> });
> {code}
> This will result in accidental deletion of advanced dictionaries.
>  Please review the patch, thanks!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Closed] (KYLIN-2352) java.lang.IllegalStateException: GlobalDict /dict/tableName/column should have 0 or 1 append dict but 2! - in Step 4 - Build Dimension Dictionary

2018-02-05 Thread Shaofeng SHI (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-2352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shaofeng SHI closed KYLIN-2352.
---

>  java.lang.IllegalStateException: GlobalDict /dict/tableName/column should 
> have 0 or 1 append dict but 2! - in Step 4 - Build Dimension Dictionary
> --
>
> Key: KYLIN-2352
> URL: https://issues.apache.org/jira/browse/KYLIN-2352
> Project: Kylin
>  Issue Type: Bug
>  Components: Measure - Count Distinct
>Reporter: FunkyYang
>Assignee: hongbin ma
>Priority: Minor
>
> When I build a cube today.I meet a problem 
> more than one same object in cache at Global dictionary when build a cube
> I don't kown how this happend . and I found the code that it read data from 
> HDFS . 
> this is mine Global dict in HDFS . 
> ~
>  /kylin/kylin_metadata/resources/GlobalDict/dict/XXX/ROWKEY/.index
> /kylin/kylin_metadata/resources/GlobalDict/dict/XXX/ROWKEY/cached_00017DD03
> /kylin/kylin_metadata/resources/GlobalDict/dict/XXX/ROWKEY/cached_00017DD036D05070400014B4050F
> /kylin/kylin_metadata/resources/GlobalDict/dict/XXX/ROWKEY/cached_580a02758a9ae
> /kylin/kylin_metadata/resources/GlobalDict/dict/XXX/ROWKEY/cached_58605953e7290
>  
> /kylin/kylin_metadata/resources/GlobalDict/dict/XXX/ROWKEY/cached_58655d0a78681
> I get a file in local file system and read it.It is Serializable  so I can't 
> find any information .
> How can I fix this problem 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (KYLIN-2352) java.lang.IllegalStateException: GlobalDict /dict/tableName/column should have 0 or 1 append dict but 2! - in Step 4 - Build Dimension Dictionary

2018-02-05 Thread Shaofeng SHI (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-2352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shaofeng SHI updated KYLIN-2352:

Component/s: (was: Tools, Build and Test)
 Measure - Count Distinct

>  java.lang.IllegalStateException: GlobalDict /dict/tableName/column should 
> have 0 or 1 append dict but 2! - in Step 4 - Build Dimension Dictionary
> --
>
> Key: KYLIN-2352
> URL: https://issues.apache.org/jira/browse/KYLIN-2352
> Project: Kylin
>  Issue Type: Bug
>  Components: Measure - Count Distinct
>Reporter: FunkyYang
>Assignee: hongbin ma
>Priority: Minor
>
> When I build a cube today.I meet a problem 
> more than one same object in cache at Global dictionary when build a cube
> I don't kown how this happend . and I found the code that it read data from 
> HDFS . 
> this is mine Global dict in HDFS . 
> ~
>  /kylin/kylin_metadata/resources/GlobalDict/dict/XXX/ROWKEY/.index
> /kylin/kylin_metadata/resources/GlobalDict/dict/XXX/ROWKEY/cached_00017DD03
> /kylin/kylin_metadata/resources/GlobalDict/dict/XXX/ROWKEY/cached_00017DD036D05070400014B4050F
> /kylin/kylin_metadata/resources/GlobalDict/dict/XXX/ROWKEY/cached_580a02758a9ae
> /kylin/kylin_metadata/resources/GlobalDict/dict/XXX/ROWKEY/cached_58605953e7290
>  
> /kylin/kylin_metadata/resources/GlobalDict/dict/XXX/ROWKEY/cached_58655d0a78681
> I get a file in local file system and read it.It is Serializable  so I can't 
> find any information .
> How can I fix this problem 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (KYLIN-2352) java.lang.IllegalStateException: GlobalDict /dict/tableName/column should have 0 or 1 append dict but 2! - in Step 4 - Build Dimension Dictionary

2018-02-05 Thread Shaofeng SHI (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-2352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shaofeng SHI resolved KYLIN-2352.
-
Resolution: Duplicate

>  java.lang.IllegalStateException: GlobalDict /dict/tableName/column should 
> have 0 or 1 append dict but 2! - in Step 4 - Build Dimension Dictionary
> --
>
> Key: KYLIN-2352
> URL: https://issues.apache.org/jira/browse/KYLIN-2352
> Project: Kylin
>  Issue Type: Bug
>  Components: Measure - Count Distinct
>Reporter: FunkyYang
>Assignee: hongbin ma
>Priority: Minor
>
> When I build a cube today.I meet a problem 
> more than one same object in cache at Global dictionary when build a cube
> I don't kown how this happend . and I found the code that it read data from 
> HDFS . 
> this is mine Global dict in HDFS . 
> ~
>  /kylin/kylin_metadata/resources/GlobalDict/dict/XXX/ROWKEY/.index
> /kylin/kylin_metadata/resources/GlobalDict/dict/XXX/ROWKEY/cached_00017DD03
> /kylin/kylin_metadata/resources/GlobalDict/dict/XXX/ROWKEY/cached_00017DD036D05070400014B4050F
> /kylin/kylin_metadata/resources/GlobalDict/dict/XXX/ROWKEY/cached_580a02758a9ae
> /kylin/kylin_metadata/resources/GlobalDict/dict/XXX/ROWKEY/cached_58605953e7290
>  
> /kylin/kylin_metadata/resources/GlobalDict/dict/XXX/ROWKEY/cached_58655d0a78681
> I get a file in local file system and read it.It is Serializable  so I can't 
> find any information .
> How can I fix this problem 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Closed] (KYLIN-2372) build with global dictionary error at step:Build Dimension Dictionary

2018-02-05 Thread Shaofeng SHI (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-2372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shaofeng SHI closed KYLIN-2372.
---
Resolution: Incomplete

> build with global dictionary error at step:Build Dimension Dictionary
> -
>
> Key: KYLIN-2372
> URL: https://issues.apache.org/jira/browse/KYLIN-2372
> Project: Kylin
>  Issue Type: Bug
>  Components: Measure - Count Distinct
>Affects Versions: v1.6.0
> Environment: hadoop2.6.4,hive2.1.0,hbase1.2.3
>Reporter: readme_kylin
>Priority: Major
>
> when i build the second segment,error occurs.Here is the more info.
> java.lang.RuntimeException: Failed to create dictionary on X.UDID
>   at 
> org.apache.kylin.dict.DictionaryManager.buildDictionary(DictionaryManager.java:325)
>   at 
> org.apache.kylin.cube.CubeManager.buildDictionary(CubeManager.java:222)
>   at 
> org.apache.kylin.cube.cli.DictionaryGeneratorCLI.processSegment(DictionaryGeneratorCLI.java:50)
>   at 
> org.apache.kylin.cube.cli.DictionaryGeneratorCLI.processSegment(DictionaryGeneratorCLI.java:41)
>   at 
> org.apache.kylin.engine.mr.steps.CreateDictionaryJob.run(CreateDictionaryJob.java:54)
>   at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
>   at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:84)
>   at 
> org.apache.kylin.engine.mr.common.HadoopShellExecutable.doWork(HadoopShellExecutable.java:63)
>   at 
> org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:113)
>   at 
> org.apache.kylin.job.execution.DefaultChainedExecutable.doWork(DefaultChainedExecutable.java:57)
>   at 
> org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:113)
>   at 
> org.apache.kylin.job.impl.threadpool.DefaultScheduler$JobRunner.run(DefaultScheduler.java:136)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
>   at java.lang.Thread.run(Thread.java:745)
> Caused by: java.lang.RuntimeException
>   at 
> org.apache.kylin.dict.CachedTreeMap.writeValue(CachedTreeMap.java:240)
>   at org.apache.kylin.dict.CachedTreeMap.write(CachedTreeMap.java:374)
>   at 
> org.apache.kylin.dict.AppendTrieDictionary.flushIndex(AppendTrieDictionary.java:1043)
>   at 
> org.apache.kylin.dict.AppendTrieDictionary$Builder.build(AppendTrieDictionary.java:954)
>   at 
> org.apache.kylin.dict.GlobalDictionaryBuilder.build(GlobalDictionaryBuilder.java:82)
>   at 
> org.apache.kylin.dict.DictionaryGenerator.buildDictionary(DictionaryGenerator.java:81)
>   at 
> org.apache.kylin.dict.DictionaryManager.buildDictionary(DictionaryManager.java:323)
>   ... 14 more
> result code:2



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (KYLIN-3161) Enforce global dictionary for bitmap count distinct column

2018-02-05 Thread Shaofeng SHI (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shaofeng SHI reassigned KYLIN-3161:
---

   Assignee: (was: Shaofeng SHI)
Component/s: (was: Web )
 (was: Metadata)
 Measure - Count Distinct

> Enforce global dictionary for bitmap count distinct column
> --
>
> Key: KYLIN-3161
> URL: https://issues.apache.org/jira/browse/KYLIN-3161
> Project: Kylin
>  Issue Type: Improvement
>  Components: Measure - Count Distinct
>Reporter: Shaofeng SHI
>Priority: Major
>
> For bitmap based count distinct column (as the data type is not int), a 
> Global dictionary is required. But now user can use normal dictionary, which 
> may cause incorrect result.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (KYLIN-2372) build with global dictionary error at step:Build Dimension Dictionary

2018-02-05 Thread Shaofeng SHI (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-2372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shaofeng SHI updated KYLIN-2372:

Component/s: Measure - Count Distinct

> build with global dictionary error at step:Build Dimension Dictionary
> -
>
> Key: KYLIN-2372
> URL: https://issues.apache.org/jira/browse/KYLIN-2372
> Project: Kylin
>  Issue Type: Bug
>  Components: Measure - Count Distinct
>Affects Versions: v1.6.0
> Environment: hadoop2.6.4,hive2.1.0,hbase1.2.3
>Reporter: readme_kylin
>Priority: Major
>
> when i build the second segment,error occurs.Here is the more info.
> java.lang.RuntimeException: Failed to create dictionary on X.UDID
>   at 
> org.apache.kylin.dict.DictionaryManager.buildDictionary(DictionaryManager.java:325)
>   at 
> org.apache.kylin.cube.CubeManager.buildDictionary(CubeManager.java:222)
>   at 
> org.apache.kylin.cube.cli.DictionaryGeneratorCLI.processSegment(DictionaryGeneratorCLI.java:50)
>   at 
> org.apache.kylin.cube.cli.DictionaryGeneratorCLI.processSegment(DictionaryGeneratorCLI.java:41)
>   at 
> org.apache.kylin.engine.mr.steps.CreateDictionaryJob.run(CreateDictionaryJob.java:54)
>   at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
>   at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:84)
>   at 
> org.apache.kylin.engine.mr.common.HadoopShellExecutable.doWork(HadoopShellExecutable.java:63)
>   at 
> org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:113)
>   at 
> org.apache.kylin.job.execution.DefaultChainedExecutable.doWork(DefaultChainedExecutable.java:57)
>   at 
> org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:113)
>   at 
> org.apache.kylin.job.impl.threadpool.DefaultScheduler$JobRunner.run(DefaultScheduler.java:136)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
>   at java.lang.Thread.run(Thread.java:745)
> Caused by: java.lang.RuntimeException
>   at 
> org.apache.kylin.dict.CachedTreeMap.writeValue(CachedTreeMap.java:240)
>   at org.apache.kylin.dict.CachedTreeMap.write(CachedTreeMap.java:374)
>   at 
> org.apache.kylin.dict.AppendTrieDictionary.flushIndex(AppendTrieDictionary.java:1043)
>   at 
> org.apache.kylin.dict.AppendTrieDictionary$Builder.build(AppendTrieDictionary.java:954)
>   at 
> org.apache.kylin.dict.GlobalDictionaryBuilder.build(GlobalDictionaryBuilder.java:82)
>   at 
> org.apache.kylin.dict.DictionaryGenerator.buildDictionary(DictionaryGenerator.java:81)
>   at 
> org.apache.kylin.dict.DictionaryManager.buildDictionary(DictionaryManager.java:323)
>   ... 14 more
> result code:2



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (KYLIN-2617) SUM when rewritten as TOPN does not give consistent (correct) result?

2018-02-05 Thread Shaofeng SHI (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shaofeng SHI updated KYLIN-2617:

Component/s: Measure - TopN

> SUM when rewritten as TOPN does not give consistent (correct) result?
> -
>
> Key: KYLIN-2617
> URL: https://issues.apache.org/jira/browse/KYLIN-2617
> Project: Kylin
>  Issue Type: Bug
>  Components: Measure - TopN
>Reporter: liyang
>Priority: Major
>
> From Tingmao Lin 
> We found that SUM() query on a cardinality 1 dimension is not accurate (or 
> "not correct") when automatically  rewritten as TOPN.
> Is that the expected behavior of kylin or there are any other issue?
> We built a cube on a table ( measure1: bigint, dim1_id:varchar, 
> dim2_id:varchar, ... ) using kylin 1.6.0 (Kafka streaming source)
> The cube has two measures: SUM(measure1) and 
> TOPN(10,sum-orderby(measure1),group by dim2_id) . (other measures omitted)
> and two dimensions  dim1_id, dim2_id   (other dims omitted)
> About the source table data:  
> The cardinality of dim1_id  is 1 (same dim1_id for all rows in the source 
> table)
> The cardinality of dim2_id  is 1 (same dim2_id for all rows in the source 
> table)
> The possible value of measure1 is [1,0,-1]
>  
> When we query
> "select SUM(measure1) FROM table GROUP BY dim2_id"=>  
>the result has one row:"sum=7",
>   from the kylin logs we found that the query has been automatically  
> rewritten as TOPN(measure1,sum-orderby(measure1),group by dim2_id)
> When we write another query to prevent TOPN rewrite, for example: 
>"select SUM(measure1),count(*) FROM table GROUP BY dim2_id" =>   one 
> row -- "sum=-2,count=24576"
>"select SUM(measure1),count(*) FROM table" 
>=>   one row -- "sum=-2,count=24576"
> The result is different (7 and -2) when rewritting to TOPN or not.
> My question is: are the following behavior "works as expected" ,or TOPN 
> algorithm does not support negative counter values very well , or any issue 
> there?
> 1. SUM() query  automatically rewritten as TOPN and gives approximated result 
> when no TOPN present in the query.
> 2. When cardinality is 1, TOPN does not give accurate result.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (KYLIN-3224) data can't show when use kylin pushdown model

2018-02-05 Thread peng.jianhua (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16352164#comment-16352164
 ] 

peng.jianhua commented on KYLIN-3224:
-

Hi,[~Zhixiong Chen].
We can get the result from backend,the export result has result.
but it can't show on the webpage,I think it is a web issue.

In ui-grid.js,the function 
{code:java}
s.preEval = function (path) 
{code}
has description

{code:java}
* @description
 * Takes a field path and converts it to bracket notation to allow for 
special characters in path
 * @example
 * 
 * gridUtil.preEval('property') == 'property'
 * gridUtil.preEval('nested.deep.prop-erty') = "nested['deep']['prop-erty']"
 * 
{code}

if the data comes from pushdown,the column name will be 
kylin_sales.trans_id(just for example,if we don't add alias).
so the function preEval will be like this,
gridUtil.preEval('entity.kylin_sales.trans_id') = 
"entity['kylin_sales']['trans_id']",
so we can't find the value by the key ['kylin_sales']['trans_id'],
the function preEval should be like:
gridUtil.preEval('entity.kylin_sales.trans_id') = 
"entity['kylin_sales.trans_id']",




> data can't show when use kylin pushdown model 
> --
>
> Key: KYLIN-3224
> URL: https://issues.apache.org/jira/browse/KYLIN-3224
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.2.0, v2.3.0
>Reporter: peng.jianhua
>Assignee: peng.jianhua
>Priority: Major
> Fix For: v2.3.0
>
> Attachments: 0001-KYLIN-3224.patch, 01.PNG
>
>
> select * from kylin_sales
> use pushdown model,and the result shows like 01.png



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (KYLIN-3236) The function 'reGenerateAdvancedDict()' has an error logical judgment, which will cause an exception when you edit the cube.

2018-02-05 Thread Zhixiong Chen (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zhixiong Chen updated KYLIN-3236:
-
Description: 
# When remove deprecated distinct measures, the code has an error logical 
judgment In function 'reGenerateAdvancedDict()', as follows:

{code:java}
//remove deprecated distinct measures
angular.forEach($scope.cubeMetaFrame.dictionaries, function (dict, index) {
  if (distinctMeasures.indexOf(dict.column) === -1 && 
reuseColumns.indexOf(dict.column) === -1) {
$scope.cubeMetaFrame.dictionaries.splice(index, 1);
  }
});
{code}
This will result in accidental deletion of advanced dictionaries.
 Please review the patch, thanks!

  was:
When remove deprecated distinct measures, the code has an error logical 
judgment In function 'reGenerateAdvancedDict()', as follows:

{code:java}
//remove deprecated distinct measures
angular.forEach($scope.cubeMetaFrame.dictionaries, function (dict, index) {
  if (distinctMeasures.indexOf(dict.column) === -1 && 
reuseColumns.indexOf(dict.column) === -1) {
$scope.cubeMetaFrame.dictionaries.splice(index, 1);
  }
});
{code}

This will result in accidental deletion of advanced dictionaries.
Please review the patch, thanks!



> The function 'reGenerateAdvancedDict()' has an error logical judgment, which 
> will cause an exception when you edit the cube.
> 
>
> Key: KYLIN-3236
> URL: https://issues.apache.org/jira/browse/KYLIN-3236
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.3.0
>Reporter: Peng Xing
>Assignee: Peng Xing
>Priority: Major
>  Labels: patch
> Attachments: 
> 0001-KYLIN-3236-The-function-reGenerateAdvancedDict-has-a.patch
>
>
> # When remove deprecated distinct measures, the code has an error logical 
> judgment In function 'reGenerateAdvancedDict()', as follows:
> {code:java}
> //remove deprecated distinct measures
> angular.forEach($scope.cubeMetaFrame.dictionaries, function (dict, index) 
> {
>   if (distinctMeasures.indexOf(dict.column) === -1 && 
> reuseColumns.indexOf(dict.column) === -1) {
> $scope.cubeMetaFrame.dictionaries.splice(index, 1);
>   }
> });
> {code}
> This will result in accidental deletion of advanced dictionaries.
>  Please review the patch, thanks!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (KYLIN-3119) A few bugs in the function 'massageSql' of 'QueryUtil.java'

2018-02-05 Thread peng.jianhua (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

peng.jianhua updated KYLIN-3119:

Attachment: 0001-KYLIN-3119-add-test-cases.patch

> A few bugs in the function 'massageSql' of 'QueryUtil.java'
> ---
>
> Key: KYLIN-3119
> URL: https://issues.apache.org/jira/browse/KYLIN-3119
> Project: Kylin
>  Issue Type: Bug
>Reporter: peng.jianhua
>Assignee: peng.jianhua
>Priority: Major
> Attachments: 
> 0001-KYLIN-3119-A-few-bugs-in-the-function-massageSql-of-.patch, 
> 0001-KYLIN-3119-add-test-cases.patch, 01.PNG, 02.PNG
>
>
> in the function 'massageSql' of 'QueryUtil.java',there are a few bugs:
> 01:
> {code:java}
> while (sql.endsWith(";"))
> sql = sql.substring(0, sql.length() - 1);
> {code}
> if the sql end with ';' and after the ';' still has comments,will be 
> error.Because the sql will add ("\nLIMIT " + limit) at the end.
> 02:
> {code:java}
> if (limit > 0 && !sql.toLowerCase().contains("limit")) {
> sql += ("\nLIMIT " + limit);
> }
> if (offset > 0 && !sql.toLowerCase().contains("offset")) {
> sql += ("\nOFFSET " + offset);
> }
> {code}
> if the sql already has word 'limit' in it,such as Alias,Subquery,Comments,the 
> ‘limit’ in the Input box will be invalid.
> for example,the sql has subquery,and there is 'limit' in subquery.
> {code:java}
> select KYLIN_SALES.PART_DT, count(KYLIN_SALES.PRICE)
> from KYLIN_SALES
> inner join (select ACCOUNT_ID, ACCOUNT_BUYER_LEVEL from KYLIN_ACCOUNT where 
> ACCOUNT_COUNTRY = 'US' limit 1) as TT
> on KYLIN_SALES.BUYER_ID = TT.ACCOUNT_ID
> group by KYLIN_SALES.PART_DT
> {code}
> the ‘limit’ in the Input box will be invalid.please refer to 01.png and 
> 02.png.
> 03:
> {code:java}
> // https://issues.apache.org/jira/browse/KYLIN-2649
> if (kylinConfig.getForceLimit() > 0 && 
> !sql.toLowerCase().contains("limit")
> && sql.toLowerCase().contains("*")) {
> sql += ("\nLIMIT " + kylinConfig.getForceLimit());
> }
> {code}
> Because KYLIN-2649 is still unresolved,so I didn't change the code,but  it 
> has same 'limit' word bugs like above.
> And there are some situations that the sql contains \*,such as 
> {code:java}count(*),kylin_sales.*{code}
> Maybe the \* in subquery too.
> it seems improperly to deal with the sql just use {code:java}
> sql.toLowerCase().contains("*")
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (KYLIN-3224) data can't show when use kylin pushdown model

2018-02-05 Thread Zhixiong Chen (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16352155#comment-16352155
 ] 

Zhixiong Chen commented on KYLIN-3224:
--

Hi,[~peng.jianhua]

There isn't different part in query pushdown or query cube in web.

So I think it isn't issue in web.

Could you check the data in Hive ?

> data can't show when use kylin pushdown model 
> --
>
> Key: KYLIN-3224
> URL: https://issues.apache.org/jira/browse/KYLIN-3224
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.2.0, v2.3.0
>Reporter: peng.jianhua
>Assignee: peng.jianhua
>Priority: Major
> Fix For: v2.3.0
>
> Attachments: 0001-KYLIN-3224.patch, 01.PNG
>
>
> select * from kylin_sales
> use pushdown model,and the result shows like 01.png



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (KYLIN-3238) Fix NPE when CubeInstance.getLatestReadySegment() returns null

2018-02-05 Thread Zhong Yanghong (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zhong Yanghong updated KYLIN-3238:
--
Description: 
Currently we suppose if a cube is in READY status, there should exist READY 
segments. Then when this kind of cube is selected as a candidate for a query, 
neither {{getLatestReadySegment}} in {{CubeInstance}} will return null, nor 
{{cube.getSegments().get(0)}} will throw {{IndexOutOfBoundsException}}.

However, currently we allow to delete segments by REST API when cube is in 
READY status, which I think it's not reasonable. To deal with this issue, I 
propose not to allow segment deletion by REST API when its cube is in READY 
status.

  was:
Currently we suppose if a cube is in READY status, there should exist READY 
segments. Then when this kind of cube is selected as a candidate for a query, 
neither {{getLatestReadySegment}} in {{CubeInstance}} will return null, nor 
{{cube.getSegments().get(0)}} will throw {{IndexOutOfBoundsException}}.

However, there's no validation 


> Fix NPE when CubeInstance.getLatestReadySegment() returns null
> --
>
> Key: KYLIN-3238
> URL: https://issues.apache.org/jira/browse/KYLIN-3238
> Project: Kylin
>  Issue Type: Improvement
>Reporter: Zhong Yanghong
>Assignee: Zhong Yanghong
>Priority: Major
>
> Currently we suppose if a cube is in READY status, there should exist READY 
> segments. Then when this kind of cube is selected as a candidate for a query, 
> neither {{getLatestReadySegment}} in {{CubeInstance}} will return null, nor 
> {{cube.getSegments().get(0)}} will throw {{IndexOutOfBoundsException}}.
> However, currently we allow to delete segments by REST API when cube is in 
> READY status, which I think it's not reasonable. To deal with this issue, I 
> propose not to allow segment deletion by REST API when its cube is in READY 
> status.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (KYLIN-3219) Fix NPE in CubingJob

2018-02-05 Thread Peng Xing (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peng Xing updated KYLIN-3219:
-
Description: 
When using spark engine, there is no 'Build Cube In-Mem' step task,
'getTaskByName(ExecutableConstants.STEP_NAME_BUILD_IN_MEM_CUBE).getDuration()' 
will get NullPointerException

error log:

java.lang.NullPointerException
 at org.apache.kylin.engine.mr.CubingJob.updateMetrics(CubingJob.java:284)
 at org.apache.kylin.engine.mr.CubingJob.onStatusChange(CubingJob.java:272)
 at 
org.apache.kylin.job.execution.DefaultChainedExecutable.onExecuteFinished(DefaultChainedExecutable.java:132)
 at org.apache.kylin.engine.mr.CubingJob.onExecuteFinished(CubingJob.java:266)
 at 
org.apache.kylin.job.execution.AbstractExecutable.onExecuteFinishedWithRetry(AbstractExecutable.java:98)
 at 
org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:175)
 at 
org.apache.kylin.job.impl.threadpool.DefaultScheduler$JobRunner.run(DefaultScheduler.java:300)
 at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1152)
 at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:622)
 at java.lang.Thread.run(Thread.java:745)
2018-01-31 18:15:20,443 ERROR [pool-11-thread-10] 
threadpool.DefaultScheduler:302 : ExecuteException 
job:693e2cd6-c7e7-4ed9-b1d6-e7ad86f5c501
org.apache.kylin.job.exception.ExecuteException: java.lang.NullPointerException
 at 
org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:179)
 at 
org.apache.kylin.job.impl.threadpool.DefaultScheduler$JobRunner.run(DefaultScheduler.java:300)
 at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1152)
 at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:622)
 at java.lang.Thread.run(Thread.java:745)
Caused by: java.lang.NullPointerException
 at org.apache.kylin.engine.mr.CubingJob.updateMetrics(CubingJob.java:284)
 at org.apache.kylin.engine.mr.CubingJob.onStatusChange(CubingJob.java:272)
 at 
org.apache.kylin.job.execution.DefaultChainedExecutable.onExecuteFinished(DefaultChainedExecutable.java:132)
 at org.apache.kylin.engine.mr.CubingJob.onExecuteFinished(CubingJob.java:266)
 at 
org.apache.kylin.job.execution.AbstractExecutable.onExecuteFinishedWithRetry(AbstractExecutable.java:98)
 at 
org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:175)
 ... 4 more

  was:
When using spark engine, there is no 'Build Cube In-Mem' step task,

error log:

java.lang.NullPointerException
 at org.apache.kylin.engine.mr.CubingJob.updateMetrics(CubingJob.java:284)
 at org.apache.kylin.engine.mr.CubingJob.onStatusChange(CubingJob.java:272)
 at 
org.apache.kylin.job.execution.DefaultChainedExecutable.onExecuteFinished(DefaultChainedExecutable.java:132)
 at org.apache.kylin.engine.mr.CubingJob.onExecuteFinished(CubingJob.java:266)
 at 
org.apache.kylin.job.execution.AbstractExecutable.onExecuteFinishedWithRetry(AbstractExecutable.java:98)
 at 
org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:175)
 at 
org.apache.kylin.job.impl.threadpool.DefaultScheduler$JobRunner.run(DefaultScheduler.java:300)
 at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1152)
 at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:622)
 at java.lang.Thread.run(Thread.java:745)
2018-01-31 18:15:20,443 ERROR [pool-11-thread-10] 
threadpool.DefaultScheduler:302 : ExecuteException 
job:693e2cd6-c7e7-4ed9-b1d6-e7ad86f5c501
org.apache.kylin.job.exception.ExecuteException: java.lang.NullPointerException
 at 
org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:179)
 at 
org.apache.kylin.job.impl.threadpool.DefaultScheduler$JobRunner.run(DefaultScheduler.java:300)
 at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1152)
 at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:622)
 at java.lang.Thread.run(Thread.java:745)
Caused by: java.lang.NullPointerException
 at org.apache.kylin.engine.mr.CubingJob.updateMetrics(CubingJob.java:284)
 at org.apache.kylin.engine.mr.CubingJob.onStatusChange(CubingJob.java:272)
 at 
org.apache.kylin.job.execution.DefaultChainedExecutable.onExecuteFinished(DefaultChainedExecutable.java:132)
 at org.apache.kylin.engine.mr.CubingJob.onExecuteFinished(CubingJob.java:266)
 at 
org.apache.kylin.job.execution.AbstractExecutable.onExecuteFinishedWithRetry(AbstractExecutable.java:98)
 at 
org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:175)
 ... 4 more


> Fix NPE in CubingJob
> 
>
> Key: KYLIN-3219
> URL: https://issues.apache.org/jira/browse/KYLIN-3219
> Project: Kylin
>  Issue Type: Bug
>  Components: Job Engine
>Affects Versions: v2.3.0
>

[jira] [Created] (KYLIN-3239) Refactor the ACL code about "checkPermission" and "hasPermission"

2018-02-05 Thread Guangyao Li (JIRA)

Guangyao Li created KYLIN-3239:
--

 Summary: Refactor the ACL code about "checkPermission" and 
"hasPermission"
 Key: KYLIN-3239
 URL: https://issues.apache.org/jira/browse/KYLIN-3239
 Project: Kylin
  Issue Type: Improvement
  Components: Security
Affects Versions: v2.2.0
Reporter: Guangyao Li
 Fix For: v2.3.0


According to the design of "checkPermission" and "HasPermission",

Refactoring the ACL code



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (KYLIN-3215) remove 'drop' option when job status is stopped and error

2018-02-05 Thread Zhixiong Chen (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zhixiong Chen resolved KYLIN-3215.
--
Resolution: Fixed

> remove 'drop' option when job status is stopped and error
> -
>
> Key: KYLIN-3215
> URL: https://issues.apache.org/jira/browse/KYLIN-3215
> Project: Kylin
>  Issue Type: Improvement
>  Components: Web 
>Affects Versions: v2.2.0, v2.3.0
>Reporter: peng.jianhua
>Assignee: peng.jianhua
>Priority: Minor
> Fix For: v2.3.0
>
> Attachments: 0001-KYLIN-3215.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (KYLIN-3215) remove 'drop' option when job status is stopped and error

2018-02-05 Thread Zhixiong Chen (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16352136#comment-16352136
 ] 

Zhixiong Chen commented on KYLIN-3215:
--

OK.

It is fine with me.

I will merge it into Kylin master.

> remove 'drop' option when job status is stopped and error
> -
>
> Key: KYLIN-3215
> URL: https://issues.apache.org/jira/browse/KYLIN-3215
> Project: Kylin
>  Issue Type: Improvement
>  Components: Web 
>Affects Versions: v2.2.0, v2.3.0
>Reporter: peng.jianhua
>Assignee: peng.jianhua
>Priority: Minor
> Fix For: v2.3.0
>
> Attachments: 0001-KYLIN-3215.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (KYLIN-3069) Add proper time zone support to the WebUI instead of GMT/PST kludge

2018-02-05 Thread Zhixiong Chen (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zhixiong Chen resolved KYLIN-3069.
--
Resolution: Fixed

> Add proper time zone support to the WebUI instead of GMT/PST kludge
> ---
>
> Key: KYLIN-3069
> URL: https://issues.apache.org/jira/browse/KYLIN-3069
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.2.0
> Environment: HDP 2.5.3, Kylin 2.2.0
>Reporter: Vsevolod Ostapenko
>Assignee: peng.jianhua
>Priority: Minor
> Fix For: v2.3.0
>
> Attachments: 
> 0001-KYLIN-3069-Add-proper-time-zone-support-to-the-WebUI.patch, Screen Shot 
> 2017-12-05 at 10.01.39 PM.png, kylin_pic1.png, kylin_pic2.png, kylin_pic3.png
>
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> Time zone handling logic in the WebUI is a kludge, coded to parse only 
> "GMT-N" time zone specifications and defaulting to PST, if parsing is not 
> successful (kylin/webapp/app/js/filters/filter.js)
> Integrating moment and moment time zone (http://momentjs.com/timezone/docs/) 
> into the product, would allow correct time zone handling.
> For the users who happen to reside in the geographical locations that do 
> observe day light savings time, usage of GMT-N format is very inconvenient 
> and info reported by the UI in various places is perplexing.
> Needless to say that the GMT moniker itself is long deprecated.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (KYLIN-3069) Add proper time zone support to the WebUI instead of GMT/PST kludge

2018-02-05 Thread Zhixiong Chen (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16352128#comment-16352128
 ] 

Zhixiong Chen commented on KYLIN-3069:
--

Thanks jianhua.

It is fine with me.

I will merge it into master branch.

> Add proper time zone support to the WebUI instead of GMT/PST kludge
> ---
>
> Key: KYLIN-3069
> URL: https://issues.apache.org/jira/browse/KYLIN-3069
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.2.0
> Environment: HDP 2.5.3, Kylin 2.2.0
>Reporter: Vsevolod Ostapenko
>Assignee: peng.jianhua
>Priority: Minor
> Fix For: v2.3.0
>
> Attachments: 
> 0001-KYLIN-3069-Add-proper-time-zone-support-to-the-WebUI.patch, Screen Shot 
> 2017-12-05 at 10.01.39 PM.png, kylin_pic1.png, kylin_pic2.png, kylin_pic3.png
>
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> Time zone handling logic in the WebUI is a kludge, coded to parse only 
> "GMT-N" time zone specifications and defaulting to PST, if parsing is not 
> successful (kylin/webapp/app/js/filters/filter.js)
> Integrating moment and moment time zone (http://momentjs.com/timezone/docs/) 
> into the product, would allow correct time zone handling.
> For the users who happen to reside in the geographical locations that do 
> observe day light savings time, usage of GMT-N format is very inconvenient 
> and info reported by the UI in various places is perplexing.
> Needless to say that the GMT moniker itself is long deprecated.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (KYLIN-3238) Fix NPE when CubeInstance.getLatestReadySegment() returns null

2018-02-05 Thread Zhong Yanghong (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zhong Yanghong updated KYLIN-3238:
--
Description: 
Currently we suppose if a cube is in READY status, there should exist READY 
segments. Then when this kind of cube is selected as a candidate for a query, 
neither {{getLatestReadySegment}} in {{CubeInstance}} will return null, nor 
{{cube.getSegments().get(0)}} will throw {{IndexOutOfBoundsException}}.

However, there's no validation 

  was:Current we suppose {{}}


> Fix NPE when CubeInstance.getLatestReadySegment() returns null
> --
>
> Key: KYLIN-3238
> URL: https://issues.apache.org/jira/browse/KYLIN-3238
> Project: Kylin
>  Issue Type: Improvement
>Reporter: Zhong Yanghong
>Assignee: Zhong Yanghong
>Priority: Major
>
> Currently we suppose if a cube is in READY status, there should exist READY 
> segments. Then when this kind of cube is selected as a candidate for a query, 
> neither {{getLatestReadySegment}} in {{CubeInstance}} will return null, nor 
> {{cube.getSegments().get(0)}} will throw {{IndexOutOfBoundsException}}.
> However, there's no validation 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

59 matches

Mail list logo