[jira] [Resolved] (KYLIN-3339) Decoupling SQL keywords set with specify implementation in query pushdown

2018-05-28 Thread jiatao.tao (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

jiatao.tao resolved KYLIN-3339.
---
Resolution: Fixed

> Decoupling SQL keywords set with specify implementation in query pushdown
> -
>
> Key: KYLIN-3339
> URL: https://issues.apache.org/jira/browse/KYLIN-3339
> Project: Kylin
>  Issue Type: Improvement
>Reporter: jiatao.tao
>Assignee: jiatao.tao
>Priority: Trivial
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3299) When a column in int data type and encoding as date may will lead build wrong value

2018-05-28 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16493105#comment-16493105
 ] 

ASF GitHub Bot commented on KYLIN-3299:
---

asfgit commented on issue #146: KYLIN-3299, fix when year less than 1000 in int 
data type and date encoding
URL: https://github.com/apache/kylin/pull/146#issuecomment-392651882
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> When a column in int data type and encoding as date may will lead build wrong 
> value
> ---
>
> Key: KYLIN-3299
> URL: https://issues.apache.org/jira/browse/KYLIN-3299
> Project: Kylin
>  Issue Type: Bug
>Reporter: jiatao.tao
>Assignee: jiatao.tao
>Priority: Major
>
> When the year is less than 1000, build and query will result 1970.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3299) When a column in int data type and encoding as date may will lead build wrong value

2018-05-28 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16493104#comment-16493104
 ] 

ASF GitHub Bot commented on KYLIN-3299:
---

tttMelody opened a new pull request #146: KYLIN-3299, fix when year less than 
1000 in int data type and date encoding
URL: https://github.com/apache/kylin/pull/146
 
 
   …code.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> When a column in int data type and encoding as date may will lead build wrong 
> value
> ---
>
> Key: KYLIN-3299
> URL: https://issues.apache.org/jira/browse/KYLIN-3299
> Project: Kylin
>  Issue Type: Bug
>Reporter: jiatao.tao
>Assignee: jiatao.tao
>Priority: Major
>
> When the year is less than 1000, build and query will result 1970.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3295) Unused method SQLDigestUtil#appendTsFilterToExecute

2018-05-28 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16493103#comment-16493103
 ] 

ASF GitHub Bot commented on KYLIN-3295:
---

coveralls commented on issue #145: KYLIN-3295, clean unused class:SQLDigestUtil
URL: https://github.com/apache/kylin/pull/145#issuecomment-392651792
 
 
   ## Pull Request Test Coverage Report for [Build 
3181](https://coveralls.io/builds/17205617)
   
   * **0** of **0**   changed or added relevant lines in **0** files are 
covered.
   * **1** unchanged line in **1** file lost coverage.
   * Overall coverage increased (+**0.02%**) to **23.914%**
   
   ---
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-|--|--: |
   | 
[core-metadata/src/main/java/org/apache/kylin/source/datagen/ColumnGenerator.java](https://coveralls.io/builds/17205617/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fdatagen%2FColumnGenerator.java#L317)
 | 1 | 81.08% |
   
   
   |  Totals | [![Coverage 
Status](https://coveralls.io/builds/17205617/badge)](https://coveralls.io/builds/17205617)
 |
   | :-- | --: |
   | Change from base [Build 3180](https://coveralls.io/builds/17204937): |  
0.02% |
   | Covered Lines: | 14267 |
   | Relevant Lines: | 59660 |
   
   ---
   #   - [Coveralls](https://coveralls.io)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Unused method SQLDigestUtil#appendTsFilterToExecute
> ---
>
> Key: KYLIN-3295
> URL: https://issues.apache.org/jira/browse/KYLIN-3295
> Project: Kylin
>  Issue Type: Bug
>Reporter: Ted Yu
>Assignee: jiatao.tao
>Priority: Minor
> Fix For: v2.4.0
>
>
> SQLDigestUtil#appendTsFilterToExecute is not called anywhere.
> {code}
>T ret = action.apply(null);
> {code}
> Passing null to {{apply}} seems incorrect.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3295) Unused method SQLDigestUtil#appendTsFilterToExecute

2018-05-28 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16493099#comment-16493099
 ] 

ASF GitHub Bot commented on KYLIN-3295:
---

codecov-io commented on issue #145: KYLIN-3295, clean unused class:SQLDigestUtil
URL: https://github.com/apache/kylin/pull/145#issuecomment-392651611
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/145?src=pr=h1) Report
   > Merging [#145](https://codecov.io/gh/apache/kylin/pull/145?src=pr=desc) 
into 
[master](https://codecov.io/gh/apache/kylin/commit/4c67905d3cd82a0330a5ff212bd53187636623d0?src=pr=desc)
 will **increase** coverage by `0.02%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/kylin/pull/145/graphs/tree.svg?token=JawVgbgsVo=pr=150=650)](https://codecov.io/gh/apache/kylin/pull/145?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master #145  +/-   ##
   
   + Coverage 21.85%   21.87%   +0.02% 
   + Complexity 3889 3888   -1 
   
 Files   985  984   -1 
 Lines 5971659660  -56 
 Branches   8623 8608  -15 
   
 Hits  1305213052  
   + Misses4545245395  -57 
   - Partials   1212 1213   +1
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/kylin/pull/145?src=pr=tree) | Coverage Δ 
| Complexity Δ | |
   |---|---|---|---|
   | 
[...g/apache/kylin/source/datagen/ColumnGenerator.java](https://codecov.io/gh/apache/kylin/pull/145/diff?src=pr=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc291cmNlL2RhdGFnZW4vQ29sdW1uR2VuZXJhdG9yLmphdmE=)
 | `70.94% <0%> (-1.36%)` | `8% <0%> (ø)` | |
   | 
[...a/org/apache/kylin/dict/Number2BytesConverter.java](https://codecov.io/gh/apache/kylin/pull/145/diff?src=pr=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L051bWJlcjJCeXRlc0NvbnZlcnRlci5qYXZh)
 | `81.74% <0%> (-0.8%)` | `17% <0%> (-1%)` | |
   | 
[.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/145/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=)
 | `66.15% <0%> (+2.3%)` | `0% <0%> (ø)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/kylin/pull/145?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/kylin/pull/145?src=pr=footer). Last 
update 
[4c67905...4e2000a](https://codecov.io/gh/apache/kylin/pull/145?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Unused method SQLDigestUtil#appendTsFilterToExecute
> ---
>
> Key: KYLIN-3295
> URL: https://issues.apache.org/jira/browse/KYLIN-3295
> Project: Kylin
>  Issue Type: Bug
>Reporter: Ted Yu
>Assignee: jiatao.tao
>Priority: Minor
> Fix For: v2.4.0
>
>
> SQLDigestUtil#appendTsFilterToExecute is not called anywhere.
> {code}
>T ret = action.apply(null);
> {code}
> Passing null to {{apply}} seems incorrect.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3295) Unused method SQLDigestUtil#appendTsFilterToExecute

2018-05-28 Thread jiatao.tao (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16493092#comment-16493092
 ] 

jiatao.tao commented on KYLIN-3295:
---

SQLDigestUtil is no usage, so may be delete this class is better?

> Unused method SQLDigestUtil#appendTsFilterToExecute
> ---
>
> Key: KYLIN-3295
> URL: https://issues.apache.org/jira/browse/KYLIN-3295
> Project: Kylin
>  Issue Type: Bug
>Reporter: Ted Yu
>Assignee: jiatao.tao
>Priority: Minor
> Fix For: v2.4.0
>
>
> SQLDigestUtil#appendTsFilterToExecute is not called anywhere.
> {code}
>T ret = action.apply(null);
> {code}
> Passing null to {{apply}} seems incorrect.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3295) Unused method SQLDigestUtil#appendTsFilterToExecute

2018-05-28 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16493094#comment-16493094
 ] 

ASF GitHub Bot commented on KYLIN-3295:
---

asfgit commented on issue #145: KYLIN-3295, clean unused class:SQLDigestUtil
URL: https://github.com/apache/kylin/pull/145#issuecomment-392649913
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Unused method SQLDigestUtil#appendTsFilterToExecute
> ---
>
> Key: KYLIN-3295
> URL: https://issues.apache.org/jira/browse/KYLIN-3295
> Project: Kylin
>  Issue Type: Bug
>Reporter: Ted Yu
>Assignee: jiatao.tao
>Priority: Minor
> Fix For: v2.4.0
>
>
> SQLDigestUtil#appendTsFilterToExecute is not called anywhere.
> {code}
>T ret = action.apply(null);
> {code}
> Passing null to {{apply}} seems incorrect.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3295) Unused method SQLDigestUtil#appendTsFilterToExecute

2018-05-28 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16493093#comment-16493093
 ] 

ASF GitHub Bot commented on KYLIN-3295:
---

tttMelody opened a new pull request #145: KYLIN-3295, clean unused 
class:SQLDigestUtil
URL: https://github.com/apache/kylin/pull/145
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Unused method SQLDigestUtil#appendTsFilterToExecute
> ---
>
> Key: KYLIN-3295
> URL: https://issues.apache.org/jira/browse/KYLIN-3295
> Project: Kylin
>  Issue Type: Bug
>Reporter: Ted Yu
>Assignee: jiatao.tao
>Priority: Minor
> Fix For: v2.4.0
>
>
> SQLDigestUtil#appendTsFilterToExecute is not called anywhere.
> {code}
>T ret = action.apply(null);
> {code}
> Passing null to {{apply}} seems incorrect.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (KYLIN-3203) Upgrade Jacoco release

2018-05-28 Thread Ted Yu (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Yu updated KYLIN-3203:
--
Description: 
Jacoco is actively maintained by the community.

Here is the latest release:
https://github.com/jacoco/jacoco/releases/tag/v0.8.1

We should upgrade to 0.8.1 release

  was:
Jacoco is actively maintained by the community.


Here is the latest release:
https://github.com/jacoco/jacoco/releases/tag/v0.8.1

We should upgrade to 0.8.1 release


> Upgrade Jacoco release
> --
>
> Key: KYLIN-3203
> URL: https://issues.apache.org/jira/browse/KYLIN-3203
> Project: Kylin
>  Issue Type: Test
>  Components: Tools, Build and Test
>Reporter: Ted Yu
>Assignee: nichunen
>Priority: Minor
>
> Jacoco is actively maintained by the community.
> Here is the latest release:
> https://github.com/jacoco/jacoco/releases/tag/v0.8.1
> We should upgrade to 0.8.1 release



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (KYLIN-3290) Avoid calling Class#newInstance

2018-05-28 Thread Ted Yu (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Yu updated KYLIN-3290:
--
Description: 
Class#newInstance is deprecated starting in Java 9 - 
https://bugs.openjdk.java.net/browse/JDK-6850612 - because it may throw 
undeclared checked exceptions.


The suggested replacement is getDeclaredConstructor().newInstance(), which 
wraps the checked exceptions in InvocationException.

  was:
Class#newInstance is deprecated starting in Java 9 - 
https://bugs.openjdk.java.net/browse/JDK-6850612 - because it may throw 
undeclared checked exceptions.

The suggested replacement is getDeclaredConstructor().newInstance(), which 
wraps the checked exceptions in InvocationException.


> Avoid calling Class#newInstance
> ---
>
> Key: KYLIN-3290
> URL: https://issues.apache.org/jira/browse/KYLIN-3290
> Project: Kylin
>  Issue Type: Task
>Reporter: Ted Yu
>Assignee: jiatao.tao
>Priority: Minor
>
> Class#newInstance is deprecated starting in Java 9 - 
> https://bugs.openjdk.java.net/browse/JDK-6850612 - because it may throw 
> undeclared checked exceptions.
> The suggested replacement is getDeclaredConstructor().newInstance(), which 
> wraps the checked exceptions in InvocationException.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3372) Upgrade jackson-databind version due to security concerns

2018-05-28 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16493043#comment-16493043
 ] 

ASF GitHub Bot commented on KYLIN-3372:
---

codecov-io commented on issue #144: KYLIN-3372 upgrade jackson databind version 
to 2.9.5
URL: https://github.com/apache/kylin/pull/144#issuecomment-392640151
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/144?src=pr=h1) Report
   > Merging [#144](https://codecov.io/gh/apache/kylin/pull/144?src=pr=desc) 
into 
[master](https://codecov.io/gh/apache/kylin/commit/2b1e9f4b965a47dde999eca073bdbf49eecdb63d?src=pr=desc)
 will **increase** coverage by `0.02%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/kylin/pull/144/graphs/tree.svg?width=650=150=pr=JawVgbgsVo)](https://codecov.io/gh/apache/kylin/pull/144?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master #144  +/-   ##
   
   + Coverage 21.83%   21.85%   +0.02% 
   - Complexity 3888 3889   +1 
   
 Files   985  985  
 Lines 5971659716  
 Branches   8623 8623  
   
   + Hits  1303913052  +13 
   + Misses4545945452   -7 
   + Partials   1218 1212   -6
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/kylin/pull/144?src=pr=tree) | Coverage Δ 
| Complexity Δ | |
   |---|---|---|---|
   | 
[...a/org/apache/kylin/dict/Number2BytesConverter.java](https://codecov.io/gh/apache/kylin/pull/144/diff?src=pr=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L051bWJlcjJCeXRlc0NvbnZlcnRlci5qYXZh)
 | `82.53% <0%> (+0.79%)` | `18% <0%> (+1%)` | :arrow_up: |
   | 
[.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/144/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=)
 | `66.15% <0%> (+2.3%)` | `0% <0%> (ø)` | :arrow_down: |
   | 
[...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/144/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh)
 | `69.3% <0%> (+2.73%)` | `7% <0%> (ø)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/kylin/pull/144?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/kylin/pull/144?src=pr=footer). Last 
update 
[2b1e9f4...1c8](https://codecov.io/gh/apache/kylin/pull/144?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Upgrade jackson-databind version due to security concerns
> -
>
> Key: KYLIN-3372
> URL: https://issues.apache.org/jira/browse/KYLIN-3372
> Project: Kylin
>  Issue Type: Task
>Reporter: Ted Yu
>Assignee: Chao Long
>Priority: Major
> Fix For: v2.4.0
>
>
> * https://nvd.nist.gov/vuln/detail/CVE-2018-5968
> * https://nvd.nist.gov/vuln/detail/CVE-2018-7489
> * https://nvd.nist.gov/vuln/detail/CVE-2017-7525
> * https://nvd.nist.gov/vuln/detail/CVE-2017-17485
> * https://nvd.nist.gov/vuln/detail/CVE-2017-15095
> We should either remove the dependency or upgrade to version 2.8.11.1 or the 
> latest, if possible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3372) Upgrade jackson-databind version due to security concerns

2018-05-28 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16493042#comment-16493042
 ] 

ASF GitHub Bot commented on KYLIN-3372:
---

shaofengshi commented on issue #144: KYLIN-3372 upgrade jackson databind 
version to 2.9.5
URL: https://github.com/apache/kylin/pull/144#issuecomment-392639325
 
 
   LGTM, thanks long chao!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Upgrade jackson-databind version due to security concerns
> -
>
> Key: KYLIN-3372
> URL: https://issues.apache.org/jira/browse/KYLIN-3372
> Project: Kylin
>  Issue Type: Task
>Reporter: Ted Yu
>Assignee: Chao Long
>Priority: Major
> Fix For: v2.4.0
>
>
> * https://nvd.nist.gov/vuln/detail/CVE-2018-5968
> * https://nvd.nist.gov/vuln/detail/CVE-2018-7489
> * https://nvd.nist.gov/vuln/detail/CVE-2017-7525
> * https://nvd.nist.gov/vuln/detail/CVE-2017-17485
> * https://nvd.nist.gov/vuln/detail/CVE-2017-15095
> We should either remove the dependency or upgrade to version 2.8.11.1 or the 
> latest, if possible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3364) Make the behavior of BigDecimalSumAggregator consistent with hive

2018-05-28 Thread Zhong Yanghong (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16493041#comment-16493041
 ] 

Zhong Yanghong commented on KYLIN-3364:
---

Here, this patch is mainly for sum(case when). If no else in the case when 
expression, exception will happen without this patch. If other aggregators have 
the same issue, we may create other JIRAs.

> Make the behavior of BigDecimalSumAggregator consistent with hive
> -
>
> Key: KYLIN-3364
> URL: https://issues.apache.org/jira/browse/KYLIN-3364
> Project: Kylin
>  Issue Type: Sub-task
>Reporter: Zhong Yanghong
>Assignee: Zhong Yanghong
>Priority: Major
> Attachments: KYLIN-3364.patch
>
>
> When aggregating on a sequence of BigDecimal values, if all values are null, 
> the result should be null. Otherwise, null should be regarded as 0.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3372) Upgrade jackson-databind version due to security concerns

2018-05-28 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16493039#comment-16493039
 ] 

ASF GitHub Bot commented on KYLIN-3372:
---

shaofengshi closed pull request #144: KYLIN-3372 upgrade jackson databind 
version to 2.9.5
URL: https://github.com/apache/kylin/pull/144
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/pom.xml b/pom.xml
index a8e8312e1c..e6372c5417 100644
--- a/pom.xml
+++ b/pom.xml
@@ -82,7 +82,7 @@
 3.2.2
 
 
-2.6.7.1
+2.9.5
 
 
 3.4
@@ -595,11 +595,21 @@
 
 
 
+
+com.fasterxml.jackson.core
+jackson-core
+${jackson.version}
+
 
 com.fasterxml.jackson.core
 jackson-databind
 ${jackson.version}
 
+
+com.fasterxml.jackson.core
+jackson-annotations
+${jackson.version}
+
 
 
 


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Upgrade jackson-databind version due to security concerns
> -
>
> Key: KYLIN-3372
> URL: https://issues.apache.org/jira/browse/KYLIN-3372
> Project: Kylin
>  Issue Type: Task
>Reporter: Ted Yu
>Assignee: Chao Long
>Priority: Major
> Fix For: v2.4.0
>
>
> * https://nvd.nist.gov/vuln/detail/CVE-2018-5968
> * https://nvd.nist.gov/vuln/detail/CVE-2018-7489
> * https://nvd.nist.gov/vuln/detail/CVE-2017-7525
> * https://nvd.nist.gov/vuln/detail/CVE-2017-17485
> * https://nvd.nist.gov/vuln/detail/CVE-2017-15095
> We should either remove the dependency or upgrade to version 2.8.11.1 or the 
> latest, if possible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3372) Upgrade jackson-databind version due to security concerns

2018-05-28 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16493040#comment-16493040
 ] 

ASF subversion and git services commented on KYLIN-3372:


Commit 4c67905d3cd82a0330a5ff212bd53187636623d0 in kylin's branch 
refs/heads/master from [~Wayne0101]
[ https://gitbox.apache.org/repos/asf?p=kylin.git;h=4c67905 ]

KYLIN-3372 upgrade jackson databind version to 2.9.5


> Upgrade jackson-databind version due to security concerns
> -
>
> Key: KYLIN-3372
> URL: https://issues.apache.org/jira/browse/KYLIN-3372
> Project: Kylin
>  Issue Type: Task
>Reporter: Ted Yu
>Assignee: Chao Long
>Priority: Major
> Fix For: v2.4.0
>
>
> * https://nvd.nist.gov/vuln/detail/CVE-2018-5968
> * https://nvd.nist.gov/vuln/detail/CVE-2018-7489
> * https://nvd.nist.gov/vuln/detail/CVE-2017-7525
> * https://nvd.nist.gov/vuln/detail/CVE-2017-17485
> * https://nvd.nist.gov/vuln/detail/CVE-2017-15095
> We should either remove the dependency or upgrade to version 2.8.11.1 or the 
> latest, if possible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3372) Upgrade jackson-databind version due to security concerns

2018-05-28 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16493038#comment-16493038
 ] 

ASF GitHub Bot commented on KYLIN-3372:
---

coveralls commented on issue #144: KYLIN-3372 upgrade jackson databind version 
to 2.9.5
URL: https://github.com/apache/kylin/pull/144#issuecomment-392638708
 
 
   ## Pull Request Test Coverage Report for [Build 
3178](https://coveralls.io/builds/17204781)
   
   * **0** of **0**   changed or added relevant lines in **0** files are 
covered.
   * **4** unchanged lines in **1** file lost coverage.
   * Overall coverage increased (+**0.01%**) to **23.89%**
   
   ---
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-|--|--: |
   | 
[core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/17204781/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L555)
 | 4 | 77.81% |
   
   
   |  Totals | [![Coverage 
Status](https://coveralls.io/builds/17204781/badge)](https://coveralls.io/builds/17204781)
 |
   | :-- | --: |
   | Change from base [Build 3173](https://coveralls.io/builds/17185461): |  
0.01% |
   | Covered Lines: | 14266 |
   | Relevant Lines: | 59716 |
   
   ---
   #   - [Coveralls](https://coveralls.io)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Upgrade jackson-databind version due to security concerns
> -
>
> Key: KYLIN-3372
> URL: https://issues.apache.org/jira/browse/KYLIN-3372
> Project: Kylin
>  Issue Type: Task
>Reporter: Ted Yu
>Assignee: Chao Long
>Priority: Major
> Fix For: v2.4.0
>
>
> * https://nvd.nist.gov/vuln/detail/CVE-2018-5968
> * https://nvd.nist.gov/vuln/detail/CVE-2018-7489
> * https://nvd.nist.gov/vuln/detail/CVE-2017-7525
> * https://nvd.nist.gov/vuln/detail/CVE-2017-17485
> * https://nvd.nist.gov/vuln/detail/CVE-2017-15095
> We should either remove the dependency or upgrade to version 2.8.11.1 or the 
> latest, if possible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3250) Upgrade jetty version to 9.2.24.v20180105

2018-05-28 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16493034#comment-16493034
 ] 

ASF GitHub Bot commented on KYLIN-3250:
---

codecov-io commented on issue #143: KYLIN-3250 Upgrade jetty version to 
9.3.22.v20171030
URL: https://github.com/apache/kylin/pull/143#issuecomment-392638206
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/143?src=pr=h1) Report
   > Merging [#143](https://codecov.io/gh/apache/kylin/pull/143?src=pr=desc) 
into 
[master](https://codecov.io/gh/apache/kylin/commit/2b1e9f4b965a47dde999eca073bdbf49eecdb63d?src=pr=desc)
 will **increase** coverage by `0.02%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/kylin/pull/143/graphs/tree.svg?height=150=650=JawVgbgsVo=pr)](https://codecov.io/gh/apache/kylin/pull/143?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master #143  +/-   ##
   
   + Coverage 21.83%   21.86%   +0.02% 
 Complexity 3888 3888  
   
 Files   985  985  
 Lines 5971659716  
 Branches   8623 8623  
   
   + Hits  1303913056  +17 
   + Misses4545945449  -10 
   + Partials   1218 1211   -7
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/kylin/pull/143?src=pr=tree) | Coverage Δ 
| Complexity Δ | |
   |---|---|---|---|
   | 
[...g/apache/kylin/source/datagen/ColumnGenerator.java](https://codecov.io/gh/apache/kylin/pull/143/diff?src=pr=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc291cmNlL2RhdGFnZW4vQ29sdW1uR2VuZXJhdG9yLmphdmE=)
 | `72.29% <0%> (+1.35%)` | `8% <0%> (ø)` | :arrow_down: |
   | 
[.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/143/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=)
 | `66.15% <0%> (+2.3%)` | `0% <0%> (ø)` | :arrow_down: |
   | 
[...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/143/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh)
 | `70.21% <0%> (+3.64%)` | `7% <0%> (ø)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/kylin/pull/143?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/kylin/pull/143?src=pr=footer). Last 
update 
[2b1e9f4...4326c39](https://codecov.io/gh/apache/kylin/pull/143?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Upgrade jetty version to 9.2.24.v20180105
> -
>
> Key: KYLIN-3250
> URL: https://issues.apache.org/jira/browse/KYLIN-3250
> Project: Kylin
>  Issue Type: Improvement
>  Components: Tools, Build and Test
>Reporter: Ted Yu
>Priority: Minor
> Fix For: v2.4.0
>
>
> Currently Kylin depends on 9.2.20.v20161216 which is quite old.
> Memory leak was fixed in Jetty 9.4 and later backported however the version 
> of Jetty 9.2.20 came before this fix.  See 
> [https://github.com/eclipse/jetty.project/issues/1804] and 
> [https://github.com/apache/hbase/blob/master/pom.xml#L1416.]
> This issue is to upgrade to 
> [9.3.22.v20171030|https://mvnrepository.com/artifact/org.eclipse.jetty/jetty-server/9.3.22.v20171030]
>  which is the latest version of 9.3



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3250) Upgrade jetty version to 9.2.24.v20180105

2018-05-28 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16493033#comment-16493033
 ] 

ASF GitHub Bot commented on KYLIN-3250:
---

coveralls commented on issue #143: KYLIN-3250 Upgrade jetty version to 
9.3.22.v20171030
URL: https://github.com/apache/kylin/pull/143#issuecomment-392638177
 
 
   ## Pull Request Test Coverage Report for [Build 
3177](https://coveralls.io/builds/17204753)
   
   * **0** of **0**   changed or added relevant lines in **0** files are 
covered.
   * No unchanged relevant lines lost coverage.
   * Overall coverage increased (+**0.02%**) to **23.895%**
   
   ---
   
   
   
   |  Totals | [![Coverage 
Status](https://coveralls.io/builds/17204753/badge)](https://coveralls.io/builds/17204753)
 |
   | :-- | --: |
   | Change from base [Build 3173](https://coveralls.io/builds/17185461): |  
0.02% |
   | Covered Lines: | 14269 |
   | Relevant Lines: | 59716 |
   
   ---
   #   - [Coveralls](https://coveralls.io)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Upgrade jetty version to 9.2.24.v20180105
> -
>
> Key: KYLIN-3250
> URL: https://issues.apache.org/jira/browse/KYLIN-3250
> Project: Kylin
>  Issue Type: Improvement
>  Components: Tools, Build and Test
>Reporter: Ted Yu
>Priority: Minor
> Fix For: v2.4.0
>
>
> Currently Kylin depends on 9.2.20.v20161216 which is quite old.
> Memory leak was fixed in Jetty 9.4 and later backported however the version 
> of Jetty 9.2.20 came before this fix.  See 
> [https://github.com/eclipse/jetty.project/issues/1804] and 
> [https://github.com/apache/hbase/blob/master/pom.xml#L1416.]
> This issue is to upgrade to 
> [9.3.22.v20171030|https://mvnrepository.com/artifact/org.eclipse.jetty/jetty-server/9.3.22.v20171030]
>  which is the latest version of 9.3



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3250) Upgrade jetty version to 9.2.24.v20180105

2018-05-28 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16493026#comment-16493026
 ] 

ASF GitHub Bot commented on KYLIN-3250:
---

shaofengshi closed pull request #143: KYLIN-3250 Upgrade jetty version to 
9.3.22.v20171030
URL: https://github.com/apache/kylin/pull/143
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/pom.xml b/pom.xml
index 49f2da9c26..655e1d52bc 100644
--- a/pom.xml
+++ b/pom.xml
@@ -90,7 +90,7 @@
 1.1.0
 2.5.4
 1.4.196
-9.2.20.v20161216
+9.3.22.v20171030
 0.3.1
 2.7.14
 1.7.0


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Upgrade jetty version to 9.2.24.v20180105
> -
>
> Key: KYLIN-3250
> URL: https://issues.apache.org/jira/browse/KYLIN-3250
> Project: Kylin
>  Issue Type: Improvement
>  Components: Tools, Build and Test
>Reporter: Ted Yu
>Priority: Minor
> Fix For: v2.4.0
>
>
> Currently Kylin depends on 9.2.20.v20161216 which is quite old.
> Memory leak was fixed in Jetty 9.4 and later backported however the version 
> of Jetty 9.2.20 came before this fix.  See 
> [https://github.com/eclipse/jetty.project/issues/1804] and 
> [https://github.com/apache/hbase/blob/master/pom.xml#L1416.]
> This issue is to upgrade to 
> [9.3.22.v20171030|https://mvnrepository.com/artifact/org.eclipse.jetty/jetty-server/9.3.22.v20171030]
>  which is the latest version of 9.3



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3250) Upgrade jetty version to 9.2.24.v20180105

2018-05-28 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16493027#comment-16493027
 ] 

ASF subversion and git services commented on KYLIN-3250:


Commit 999f1f0089baf41bf4e3b546abe0af6384ab1b25 in kylin's branch 
refs/heads/master from [~Wayne0101]
[ https://gitbox.apache.org/repos/asf?p=kylin.git;h=999f1f0 ]

KYLIN-3250 Upgrade jetty version to 9.3.22.v20171030


> Upgrade jetty version to 9.2.24.v20180105
> -
>
> Key: KYLIN-3250
> URL: https://issues.apache.org/jira/browse/KYLIN-3250
> Project: Kylin
>  Issue Type: Improvement
>  Components: Tools, Build and Test
>Reporter: Ted Yu
>Priority: Minor
> Fix For: v2.4.0
>
>
> Currently Kylin depends on 9.2.20.v20161216 which is quite old.
> Memory leak was fixed in Jetty 9.4 and later backported however the version 
> of Jetty 9.2.20 came before this fix.  See 
> [https://github.com/eclipse/jetty.project/issues/1804] and 
> [https://github.com/apache/hbase/blob/master/pom.xml#L1416.]
> This issue is to upgrade to 
> [9.3.22.v20171030|https://mvnrepository.com/artifact/org.eclipse.jetty/jetty-server/9.3.22.v20171030]
>  which is the latest version of 9.3



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3250) Upgrade jetty version to 9.2.24.v20180105

2018-05-28 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16493025#comment-16493025
 ] 

ASF GitHub Bot commented on KYLIN-3250:
---

shaofengshi commented on issue #143: KYLIN-3250 Upgrade jetty version to 
9.3.22.v20171030
URL: https://github.com/apache/kylin/pull/143#issuecomment-392636333
 
 
   LGTM, thanks Long chao!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Upgrade jetty version to 9.2.24.v20180105
> -
>
> Key: KYLIN-3250
> URL: https://issues.apache.org/jira/browse/KYLIN-3250
> Project: Kylin
>  Issue Type: Improvement
>  Components: Tools, Build and Test
>Reporter: Ted Yu
>Priority: Minor
> Fix For: v2.4.0
>
>
> Currently Kylin depends on 9.2.20.v20161216 which is quite old.
> Memory leak was fixed in Jetty 9.4 and later backported however the version 
> of Jetty 9.2.20 came before this fix.  See 
> [https://github.com/eclipse/jetty.project/issues/1804] and 
> [https://github.com/apache/hbase/blob/master/pom.xml#L1416.]
> This issue is to upgrade to 
> [9.3.22.v20171030|https://mvnrepository.com/artifact/org.eclipse.jetty/jetty-server/9.3.22.v20171030]
>  which is the latest version of 9.3



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3372) Upgrade jackson-databind version due to security concerns

2018-05-28 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16493024#comment-16493024
 ] 

ASF GitHub Bot commented on KYLIN-3372:
---

asfgit commented on issue #144: KYLIN-3372 upgrade jackson databind version to 
2.9.5
URL: https://github.com/apache/kylin/pull/144#issuecomment-392636284
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Upgrade jackson-databind version due to security concerns
> -
>
> Key: KYLIN-3372
> URL: https://issues.apache.org/jira/browse/KYLIN-3372
> Project: Kylin
>  Issue Type: Task
>Reporter: Ted Yu
>Assignee: Chao Long
>Priority: Major
> Fix For: v2.4.0
>
>
> * https://nvd.nist.gov/vuln/detail/CVE-2018-5968
> * https://nvd.nist.gov/vuln/detail/CVE-2018-7489
> * https://nvd.nist.gov/vuln/detail/CVE-2017-7525
> * https://nvd.nist.gov/vuln/detail/CVE-2017-17485
> * https://nvd.nist.gov/vuln/detail/CVE-2017-15095
> We should either remove the dependency or upgrade to version 2.8.11.1 or the 
> latest, if possible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3372) Upgrade jackson-databind version due to security concerns

2018-05-28 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16493023#comment-16493023
 ] 

ASF GitHub Bot commented on KYLIN-3372:
---

Wayne1c opened a new pull request #144: KYLIN-3372 upgrade jackson databind 
version to 2.9.5
URL: https://github.com/apache/kylin/pull/144
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Upgrade jackson-databind version due to security concerns
> -
>
> Key: KYLIN-3372
> URL: https://issues.apache.org/jira/browse/KYLIN-3372
> Project: Kylin
>  Issue Type: Task
>Reporter: Ted Yu
>Assignee: Chao Long
>Priority: Major
> Fix For: v2.4.0
>
>
> * https://nvd.nist.gov/vuln/detail/CVE-2018-5968
> * https://nvd.nist.gov/vuln/detail/CVE-2018-7489
> * https://nvd.nist.gov/vuln/detail/CVE-2017-7525
> * https://nvd.nist.gov/vuln/detail/CVE-2017-17485
> * https://nvd.nist.gov/vuln/detail/CVE-2017-15095
> We should either remove the dependency or upgrade to version 2.8.11.1 or the 
> latest, if possible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3250) Upgrade jetty version to 9.2.24.v20180105

2018-05-28 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16493021#comment-16493021
 ] 

ASF GitHub Bot commented on KYLIN-3250:
---

asfgit commented on issue #143: KYLIN-3250 Upgrade jetty version to 
9.3.22.v20171030
URL: https://github.com/apache/kylin/pull/143#issuecomment-392636140
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Upgrade jetty version to 9.2.24.v20180105
> -
>
> Key: KYLIN-3250
> URL: https://issues.apache.org/jira/browse/KYLIN-3250
> Project: Kylin
>  Issue Type: Improvement
>  Components: Tools, Build and Test
>Reporter: Ted Yu
>Priority: Minor
> Fix For: v2.4.0
>
>
> Currently Kylin depends on 9.2.20.v20161216 which is quite old.
> Memory leak was fixed in Jetty 9.4 and later backported however the version 
> of Jetty 9.2.20 came before this fix.  See 
> [https://github.com/eclipse/jetty.project/issues/1804] and 
> [https://github.com/apache/hbase/blob/master/pom.xml#L1416.]
> This issue is to upgrade to 
> [9.3.22.v20171030|https://mvnrepository.com/artifact/org.eclipse.jetty/jetty-server/9.3.22.v20171030]
>  which is the latest version of 9.3



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3250) Upgrade jetty version to 9.2.24.v20180105

2018-05-28 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16493020#comment-16493020
 ] 

ASF GitHub Bot commented on KYLIN-3250:
---

Wayne1c opened a new pull request #143: KYLIN-3250 Upgrade jetty version to 
9.3.22.v20171030
URL: https://github.com/apache/kylin/pull/143
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Upgrade jetty version to 9.2.24.v20180105
> -
>
> Key: KYLIN-3250
> URL: https://issues.apache.org/jira/browse/KYLIN-3250
> Project: Kylin
>  Issue Type: Improvement
>  Components: Tools, Build and Test
>Reporter: Ted Yu
>Priority: Minor
> Fix For: v2.4.0
>
>
> Currently Kylin depends on 9.2.20.v20161216 which is quite old.
> Memory leak was fixed in Jetty 9.4 and later backported however the version 
> of Jetty 9.2.20 came before this fix.  See 
> [https://github.com/eclipse/jetty.project/issues/1804] and 
> [https://github.com/apache/hbase/blob/master/pom.xml#L1416.]
> This issue is to upgrade to 
> [9.3.22.v20171030|https://mvnrepository.com/artifact/org.eclipse.jetty/jetty-server/9.3.22.v20171030]
>  which is the latest version of 9.3



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3364) Make the behavior of BigDecimalSumAggregator consistent with hive

2018-05-28 Thread liyang (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16493008#comment-16493008
 ] 

liyang commented on KYLIN-3364:
---

Besides BigDecimalSumAggregator, other aggregators have the same issue I think.

Also at value ingestion time of MeasureType, the NULL value is already replaced 
by 0... so we still need a more complete solution of handling NULLs.

> Make the behavior of BigDecimalSumAggregator consistent with hive
> -
>
> Key: KYLIN-3364
> URL: https://issues.apache.org/jira/browse/KYLIN-3364
> Project: Kylin
>  Issue Type: Sub-task
>Reporter: Zhong Yanghong
>Assignee: Zhong Yanghong
>Priority: Major
> Attachments: KYLIN-3364.patch
>
>
> When aggregating on a sequence of BigDecimal values, if all values are null, 
> the result should be null. Otherwise, null should be regarded as 0.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (KYLIN-3391) BadQueryDetector only detect first query

2018-05-28 Thread yiming.xu (JIRA)
yiming.xu created KYLIN-3391:


 Summary: BadQueryDetector  only detect first query
 Key: KYLIN-3391
 URL: https://issues.apache.org/jira/browse/KYLIN-3391
 Project: Kylin
  Issue Type: Bug
Reporter: yiming.xu


BadQueryDetector  only detect first query.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (KYLIN-3390) QueryInterceptorUtil.queryInterceptors is not thread safe

2018-05-28 Thread yiming.xu (JIRA)
yiming.xu created KYLIN-3390:


 Summary: QueryInterceptorUtil.queryInterceptors is not thread safe
 Key: KYLIN-3390
 URL: https://issues.apache.org/jira/browse/KYLIN-3390
 Project: Kylin
  Issue Type: Bug
Reporter: yiming.xu


With concurrent case , org.apache.kylin.query.relnode.OLAPToEnumerableConverter 
throw ConcurrentModificationException



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (KYLIN-3389) intersect_count error

2018-05-28 Thread QingLi (JIRA)

 [ 
https://issues.apache.org/jira/browse/KYLIN-3389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

QingLi updated KYLIN-3389:
--
Description: 
select 
 city_name,
 intersect_count(server_user, dt,array['2018-05-10'] ) aaa
 from
 table 
 where dt>='2018-05-10'
 group by city_name

 return: Error while compiling statement: FAILED: SemanticException [Error 
10025]: Line 3:0 Expression not in GROUP BY key ''2018-05-10''

 

 

 

here is cube json:

{
 "uuid": "5fe19005-7b31-4225-b7b3-62fde2c72256",
 "last_modified": 1527489049614,
 "version": "2.2.0.0",
 "name": "CUBE_RETENTION_RD_LQ",
 "owner": "SY_DW_U_RD",
 "descriptor": "CUBE_RETENTION_RD_LQ",
 "cost": 50,
 "status": "READY",
 "segments": [
 {
 "uuid": "75336a8d-a7b6-4465-bb63-fc3ff59b379e",
 "name": "2018030100_2018052800",
 "storage_location_identifier": "KYLIN_JVERXYS4CG",
 "date_range_start": 151986240,
 "date_range_end": 152746560,
 "source_offset_start": 0,
 "source_offset_end": 0,
 "status": "READY",
 "size_kb": 99,
 "input_records": 7534006,
 "input_records_size": 136364517,
 "last_build_time": 1527489049614,
 "last_build_job_id": "729f584e-66aa-46e3-a5b5-837aef69253c",
 "create_time_utc": 1527488801260,
 "cuboid_shard_nums": {},
 "total_shards": 1,
 "blackout_cuboids": [],
 "binary_signature": null,
 "dictionaries": {
 "M_ORDER_DETAIL.CITY_NAME": 
"/dict/SY_MART_KYLIN.M_ORDER_DETAIL/CITY_NAME/e7373276-ee9a-4308-93cf-ba5f3fafcf23.dict",
 "M_ORDER_DETAIL.DT": 
"/dict/SY_MART_KYLIN.M_ORDER_DETAIL/DT/29ec1575-8497-4df2-bb51-dcb9e7dda1a1.dict"
 },
 "snapshots": null,
 "rowkey_stats": [
 [
 "M_ORDER_DETAIL.CITY_NAME",
 336,
 2
 ],
 [
 "M_ORDER_DETAIL.DT",
 57,
 1
 ]
 ]
 }
 ],
 "create_time_utc": 1527488778311,
 "cuboid_bytes": null,
 "cuboid_bytes_recommend": null,
 "cuboid_last_optimized": 0,
 "size_kb": 99,
 "input_records_count": 7534006,
 "input_records_size": 136364517
}

 

 

what's the problem?

  was:
select 
city_name,
intersect_count(server_user, dt,array['2018-05-10'] ) aaa
from
table 
where dt>='2018-05-10'
group by city_name

 

提示 Error while compiling statement: FAILED: SemanticException [Error 10025]: 
Line 3:0 Expression not in GROUP BY key ''2018-05-10''

Summary: intersect_count error  (was: intersect_count使用问题)

> intersect_count error
> -
>
> Key: KYLIN-3389
> URL: https://issues.apache.org/jira/browse/KYLIN-3389
> Project: Kylin
>  Issue Type: Bug
>  Components: Measure - Count Distinct
>Affects Versions: v2.2.0
> Environment: hive+kylin+hbase
>Reporter: QingLi
>Priority: Major
>  Labels: easyfix
> Fix For: Future
>
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> select 
>  city_name,
>  intersect_count(server_user, dt,array['2018-05-10'] ) aaa
>  from
>  table 
>  where dt>='2018-05-10'
>  group by city_name
>  return: Error while compiling statement: FAILED: SemanticException [Error 
> 10025]: Line 3:0 Expression not in GROUP BY key ''2018-05-10''
>  
>  
>  
> here is cube json:
> {
>  "uuid": "5fe19005-7b31-4225-b7b3-62fde2c72256",
>  "last_modified": 1527489049614,
>  "version": "2.2.0.0",
>  "name": "CUBE_RETENTION_RD_LQ",
>  "owner": "SY_DW_U_RD",
>  "descriptor": "CUBE_RETENTION_RD_LQ",
>  "cost": 50,
>  "status": "READY",
>  "segments": [
>  {
>  "uuid": "75336a8d-a7b6-4465-bb63-fc3ff59b379e",
>  "name": "2018030100_2018052800",
>  "storage_location_identifier": "KYLIN_JVERXYS4CG",
>  "date_range_start": 151986240,
>  "date_range_end": 152746560,
>  "source_offset_start": 0,
>  "source_offset_end": 0,
>  "status": "READY",
>  "size_kb": 99,
>  "input_records": 7534006,
>  "input_records_size": 136364517,
>  "last_build_time": 1527489049614,
>  "last_build_job_id": "729f584e-66aa-46e3-a5b5-837aef69253c",
>  "create_time_utc": 1527488801260,
>  "cuboid_shard_nums": {},
>  "total_shards": 1,
>  "blackout_cuboids": [],
>  "binary_signature": null,
>  "dictionaries": {
>  "M_ORDER_DETAIL.CITY_NAME": 
> "/dict/SY_MART_KYLIN.M_ORDER_DETAIL/CITY_NAME/e7373276-ee9a-4308-93cf-ba5f3fafcf23.dict",
>  "M_ORDER_DETAIL.DT": 
> "/dict/SY_MART_KYLIN.M_ORDER_DETAIL/DT/29ec1575-8497-4df2-bb51-dcb9e7dda1a1.dict"
>  },
>  "snapshots": null,
>  "rowkey_stats": [
>  [
>  "M_ORDER_DETAIL.CITY_NAME",
>  336,
>  2
>  ],
>  [
>  "M_ORDER_DETAIL.DT",
>  57,
>  1
>  ]
>  ]
>  }
>  ],
>  "create_time_utc": 1527488778311,
>  "cuboid_bytes": null,
>  "cuboid_bytes_recommend": null,
>  "cuboid_last_optimized": 0,
>  "size_kb": 99,
>  "input_records_count": 7534006,
>  "input_records_size": 136364517
> }
>  
>  
> what's the problem?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3250) Upgrade jetty version to 9.2.24.v20180105

2018-05-28 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/KYLIN-3250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16492446#comment-16492446
 ] 

ASF GitHub Bot commented on KYLIN-3250:
---

coveralls commented on issue #142: KYLIN-3250 Upgrade jetty version to 
9.3.22.v20171030
URL: https://github.com/apache/kylin/pull/142#issuecomment-392474405
 
 
   ## Pull Request Test Coverage Report for [Build 
3176](https://coveralls.io/builds/17194097)
   
   * **0** of **0**   changed or added relevant lines in **0** files are 
covered.
   * **1** unchanged line in **1** file lost coverage.
   * Overall coverage increased (+**0.01%**) to **23.891%**
   
   ---
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-|--|--: |
   | 
[core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/17194097/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L553)
 | 1 | 78.12% |
   
   
   |  Totals | [![Coverage 
Status](https://coveralls.io/builds/17194097/badge)](https://coveralls.io/builds/17194097)
 |
   | :-- | --: |
   | Change from base [Build 3173](https://coveralls.io/builds/17185461): |  
0.01% |
   | Covered Lines: | 14267 |
   | Relevant Lines: | 59716 |
   
   ---
   #   - [Coveralls](https://coveralls.io)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Upgrade jetty version to 9.2.24.v20180105
> -
>
> Key: KYLIN-3250
> URL: https://issues.apache.org/jira/browse/KYLIN-3250
> Project: Kylin
>  Issue Type: Improvement
>  Components: Tools, Build and Test
>Reporter: Ted Yu
>Priority: Minor
> Fix For: v2.4.0
>
>
> Currently Kylin depends on 9.2.20.v20161216 which is quite old.
> Memory leak was fixed in Jetty 9.4 and later backported however the version 
> of Jetty 9.2.20 came before this fix.  See 
> [https://github.com/eclipse/jetty.project/issues/1804] and 
> [https://github.com/apache/hbase/blob/master/pom.xml#L1416.]
> This issue is to upgrade to 
> [9.3.22.v20171030|https://mvnrepository.com/artifact/org.eclipse.jetty/jetty-server/9.3.22.v20171030]
>  which is the latest version of 9.3



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3250) Upgrade jetty version to 9.2.24.v20180105

2018-05-28 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/KYLIN-3250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16492444#comment-16492444
 ] 

ASF GitHub Bot commented on KYLIN-3250:
---

codecov-io commented on issue #142: KYLIN-3250 Upgrade jetty version to 
9.3.22.v20171030
URL: https://github.com/apache/kylin/pull/142#issuecomment-392474036
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/142?src=pr=h1) Report
   > Merging [#142](https://codecov.io/gh/apache/kylin/pull/142?src=pr=desc) 
into 
[master](https://codecov.io/gh/apache/kylin/commit/2b1e9f4b965a47dde999eca073bdbf49eecdb63d?src=pr=desc)
 will **increase** coverage by `0.02%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/kylin/pull/142/graphs/tree.svg?width=650=pr=JawVgbgsVo=150)](https://codecov.io/gh/apache/kylin/pull/142?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master #142  +/-   ##
   
   + Coverage 21.83%   21.86%   +0.02% 
   - Complexity 3888 3890   +2 
   
 Files   985  985  
 Lines 5971659716  
 Branches   8623 8623  
   
   + Hits  1303913054  +15 
   + Misses4545945451   -8 
   + Partials   1218 1211   -7
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/kylin/pull/142?src=pr=tree) | Coverage Δ 
| Complexity Δ | |
   |---|---|---|---|
   | 
[...a/org/apache/kylin/dict/Number2BytesConverter.java](https://codecov.io/gh/apache/kylin/pull/142/diff?src=pr=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L051bWJlcjJCeXRlc0NvbnZlcnRlci5qYXZh)
 | `82.53% <0%> (+0.79%)` | `18% <0%> (+1%)` | :arrow_up: |
   | 
[...g/apache/kylin/source/datagen/ColumnGenerator.java](https://codecov.io/gh/apache/kylin/pull/142/diff?src=pr=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc291cmNlL2RhdGFnZW4vQ29sdW1uR2VuZXJhdG9yLmphdmE=)
 | `72.29% <0%> (+1.35%)` | `8% <0%> (ø)` | :arrow_down: |
   | 
[...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/142/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh)
 | `69.6% <0%> (+3.03%)` | `7% <0%> (ø)` | :arrow_down: |
   | 
[...org/apache/kylin/rest/util/QueryRequestLimits.java](https://codecov.io/gh/apache/kylin/pull/142/diff?src=pr=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvdXRpbC9RdWVyeVJlcXVlc3RMaW1pdHMuamF2YQ==)
 | `40.47% <0%> (+4.76%)` | `6% <0%> (+1%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/kylin/pull/142?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/kylin/pull/142?src=pr=footer). Last 
update 
[2b1e9f4...3909951](https://codecov.io/gh/apache/kylin/pull/142?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Upgrade jetty version to 9.2.24.v20180105
> -
>
> Key: KYLIN-3250
> URL: https://issues.apache.org/jira/browse/KYLIN-3250
> Project: Kylin
>  Issue Type: Improvement
>  Components: Tools, Build and Test
>Reporter: Ted Yu
>Priority: Minor
> Fix For: v2.4.0
>
>
> Currently Kylin depends on 9.2.20.v20161216 which is quite old.
> Memory leak was fixed in Jetty 9.4 and later backported however the version 
> of Jetty 9.2.20 came before this fix.  See 
> [https://github.com/eclipse/jetty.project/issues/1804] and 
> [https://github.com/apache/hbase/blob/master/pom.xml#L1416.]
> This issue is to upgrade to 
> [9.3.22.v20171030|https://mvnrepository.com/artifact/org.eclipse.jetty/jetty-server/9.3.22.v20171030]
>  which is the latest version of 9.3



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (KYLIN-3389) intersect_count使用问题

2018-05-28 Thread QingLi (JIRA)

 [ 
https://issues.apache.org/jira/browse/KYLIN-3389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

QingLi updated KYLIN-3389:
--
Remaining Estimate: 168h  (was: 12h)
 Original Estimate: 168h  (was: 12h)

> intersect_count使用问题
> ---
>
> Key: KYLIN-3389
> URL: https://issues.apache.org/jira/browse/KYLIN-3389
> Project: Kylin
>  Issue Type: Bug
>  Components: Measure - Count Distinct
>Affects Versions: v2.2.0
> Environment: hive+kylin+hbase
>Reporter: QingLi
>Priority: Major
>  Labels: easyfix
> Fix For: Future
>
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> select 
> city_name,
> intersect_count(server_user, dt,array['2018-05-10'] ) aaa
> from
> table 
> where dt>='2018-05-10'
> group by city_name
>  
> 提示 Error while compiling statement: FAILED: SemanticException [Error 10025]: 
> Line 3:0 Expression not in GROUP BY key ''2018-05-10''



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (KYLIN-3389) intersect_count使用问题

2018-05-28 Thread QingLi (JIRA)
QingLi created KYLIN-3389:
-

 Summary: intersect_count使用问题
 Key: KYLIN-3389
 URL: https://issues.apache.org/jira/browse/KYLIN-3389
 Project: Kylin
  Issue Type: Bug
  Components: Measure - Count Distinct
Affects Versions: v2.2.0
 Environment: hive+kylin+hbase
Reporter: QingLi
 Fix For: Future


select 
city_name,
intersect_count(server_user, dt,array['2018-05-10'] ) aaa
from
table 
where dt>='2018-05-10'
group by city_name

 

提示 Error while compiling statement: FAILED: SemanticException [Error 10025]: 
Line 3:0 Expression not in GROUP BY key ''2018-05-10''



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3250) Upgrade jetty version to 9.2.24.v20180105

2018-05-28 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/KYLIN-3250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16492434#comment-16492434
 ] 

ASF GitHub Bot commented on KYLIN-3250:
---

asfgit commented on issue #142: KYLIN-3250 Upgrade jetty version to 
9.3.22.v20171030
URL: https://github.com/apache/kylin/pull/142#issuecomment-392469416
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Upgrade jetty version to 9.2.24.v20180105
> -
>
> Key: KYLIN-3250
> URL: https://issues.apache.org/jira/browse/KYLIN-3250
> Project: Kylin
>  Issue Type: Improvement
>  Components: Tools, Build and Test
>Reporter: Ted Yu
>Priority: Minor
> Fix For: v2.4.0
>
>
> Currently Kylin depends on 9.2.20.v20161216 which is quite old.
> Memory leak was fixed in Jetty 9.4 and later backported however the version 
> of Jetty 9.2.20 came before this fix.  See 
> [https://github.com/eclipse/jetty.project/issues/1804] and 
> [https://github.com/apache/hbase/blob/master/pom.xml#L1416.]
> This issue is to upgrade to 
> [9.3.22.v20171030|https://mvnrepository.com/artifact/org.eclipse.jetty/jetty-server/9.3.22.v20171030]
>  which is the latest version of 9.3



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3250) Upgrade jetty version to 9.2.24.v20180105

2018-05-28 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/KYLIN-3250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16492435#comment-16492435
 ] 

ASF GitHub Bot commented on KYLIN-3250:
---

Wayne1c closed pull request #142: KYLIN-3250 Upgrade jetty version to 
9.3.22.v20171030
URL: https://github.com/apache/kylin/pull/142
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/pom.xml b/pom.xml
index 49f2da9c26..655e1d52bc 100644
--- a/pom.xml
+++ b/pom.xml
@@ -90,7 +90,7 @@
 1.1.0
 2.5.4
 1.4.196
-9.2.20.v20161216
+9.3.22.v20171030
 0.3.1
 2.7.14
 1.7.0


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Upgrade jetty version to 9.2.24.v20180105
> -
>
> Key: KYLIN-3250
> URL: https://issues.apache.org/jira/browse/KYLIN-3250
> Project: Kylin
>  Issue Type: Improvement
>  Components: Tools, Build and Test
>Reporter: Ted Yu
>Priority: Minor
> Fix For: v2.4.0
>
>
> Currently Kylin depends on 9.2.20.v20161216 which is quite old.
> Memory leak was fixed in Jetty 9.4 and later backported however the version 
> of Jetty 9.2.20 came before this fix.  See 
> [https://github.com/eclipse/jetty.project/issues/1804] and 
> [https://github.com/apache/hbase/blob/master/pom.xml#L1416.]
> This issue is to upgrade to 
> [9.3.22.v20171030|https://mvnrepository.com/artifact/org.eclipse.jetty/jetty-server/9.3.22.v20171030]
>  which is the latest version of 9.3



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3250) Upgrade jetty version to 9.2.24.v20180105

2018-05-28 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/KYLIN-3250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16492433#comment-16492433
 ] 

ASF GitHub Bot commented on KYLIN-3250:
---

Wayne1c opened a new pull request #142: KYLIN-3250 Upgrade jetty version to 
9.3.22.v20171030
URL: https://github.com/apache/kylin/pull/142
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Upgrade jetty version to 9.2.24.v20180105
> -
>
> Key: KYLIN-3250
> URL: https://issues.apache.org/jira/browse/KYLIN-3250
> Project: Kylin
>  Issue Type: Improvement
>  Components: Tools, Build and Test
>Reporter: Ted Yu
>Priority: Minor
> Fix For: v2.4.0
>
>
> Currently Kylin depends on 9.2.20.v20161216 which is quite old.
> Memory leak was fixed in Jetty 9.4 and later backported however the version 
> of Jetty 9.2.20 came before this fix.  See 
> [https://github.com/eclipse/jetty.project/issues/1804] and 
> [https://github.com/apache/hbase/blob/master/pom.xml#L1416.]
> This issue is to upgrade to 
> [9.3.22.v20171030|https://mvnrepository.com/artifact/org.eclipse.jetty/jetty-server/9.3.22.v20171030]
>  which is the latest version of 9.3



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)