[jira] [Created] (KYLIN-3573) Upgrade Apache parent POM to version 21

2018-09-20 Thread Ted Yu (JIRA)
Ted Yu created KYLIN-3573:
-

 Summary: Upgrade Apache parent POM to version 21
 Key: KYLIN-3573
 URL: https://issues.apache.org/jira/browse/KYLIN-3573
 Project: Kylin
  Issue Type: Task
Reporter: Ted Yu


Apache parent POM 21 has just been released. It generates .sha512 checksums 
during release with Maven Release Plugin.

We should consider upgrading parent POM.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3445) Upgrade checkstyle version to 8.6

2018-09-20 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16622965#comment-16622965
 ] 

ASF GitHub Bot commented on KYLIN-3445:
---

asfgit commented on issue #240: KYLIN-3445 Upgrade checkstyle version to 8.6
URL: https://github.com/apache/kylin/pull/240#issuecomment-423391892
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Upgrade checkstyle version to 8.6
> -
>
> Key: KYLIN-3445
> URL: https://issues.apache.org/jira/browse/KYLIN-3445
> Project: Kylin
>  Issue Type: Improvement
>  Components: Tools, Build and Test
>Reporter: Ted Yu
>Priority: Minor
> Fix For: v2.6.0
>
>
> We should upgrade checkstyle version to 8.6+ so that we can use the "match 
> violation message to this regex" feature for suppression. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3445) Upgrade checkstyle version to 8.6

2018-09-20 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16622963#comment-16622963
 ] 

ASF GitHub Bot commented on KYLIN-3445:
---

GinaZhai opened a new pull request #240: KYLIN-3445 Upgrade checkstyle version 
to 8.6
URL: https://github.com/apache/kylin/pull/240
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Upgrade checkstyle version to 8.6
> -
>
> Key: KYLIN-3445
> URL: https://issues.apache.org/jira/browse/KYLIN-3445
> Project: Kylin
>  Issue Type: Improvement
>  Components: Tools, Build and Test
>Reporter: Ted Yu
>Priority: Minor
> Fix For: v2.6.0
>
>
> We should upgrade checkstyle version to 8.6+ so that we can use the "match 
> violation message to this regex" feature for suppression. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3445) Upgrade checkstyle version to 8.6

2018-09-20 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16622964#comment-16622964
 ] 

ASF GitHub Bot commented on KYLIN-3445:
---

asfgit commented on issue #240: KYLIN-3445 Upgrade checkstyle version to 8.6
URL: https://github.com/apache/kylin/pull/240#issuecomment-423391891
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Upgrade checkstyle version to 8.6
> -
>
> Key: KYLIN-3445
> URL: https://issues.apache.org/jira/browse/KYLIN-3445
> Project: Kylin
>  Issue Type: Improvement
>  Components: Tools, Build and Test
>Reporter: Ted Yu
>Priority: Minor
> Fix For: v2.6.0
>
>
> We should upgrade checkstyle version to 8.6+ so that we can use the "match 
> violation message to this regex" feature for suppression. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3445) Upgrade checkstyle version to 8.6

2018-09-20 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16623014#comment-16623014
 ] 

ASF GitHub Bot commented on KYLIN-3445:
---

shaofengshi closed pull request #240: KYLIN-3445 Upgrade checkstyle version to 
8.6
URL: https://github.com/apache/kylin/pull/240
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/pom.xml b/pom.xml
index 0377f42692..5c3b2cb979 100644
--- a/pom.xml
+++ b/pom.xml
@@ -1098,7 +1098,7 @@
 
   com.puppycrawl.tools
   checkstyle
-  6.19
+  8.6
 
   
   


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Upgrade checkstyle version to 8.6
> -
>
> Key: KYLIN-3445
> URL: https://issues.apache.org/jira/browse/KYLIN-3445
> Project: Kylin
>  Issue Type: Improvement
>  Components: Tools, Build and Test
>Reporter: Ted Yu
>Priority: Minor
> Fix For: v2.6.0
>
>
> We should upgrade checkstyle version to 8.6+ so that we can use the "match 
> violation message to this regex" feature for suppression. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3567) Change scala dependency to provided

2018-09-20 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16623013#comment-16623013
 ] 

ASF subversion and git services commented on KYLIN-3567:


Commit 82e1c01af3dee09c0c6a417210ff5dfa47571575 in kylin's branch 
refs/heads/master from chao long
[ https://gitbox.apache.org/repos/asf?p=kylin.git;h=82e1c01 ]

KYLIN-3567 Change scala dependency scope to provided


> Change scala dependency to provided
> ---
>
> Key: KYLIN-3567
> URL: https://issues.apache.org/jira/browse/KYLIN-3567
> Project: Kylin
>  Issue Type: Bug
>Reporter: Chao Long
>Assignee: Chao Long
>Priority: Minor
> Fix For: v2.5.1
>
>
> The scope of scala dependency in "engine-spark" module should be "provided".
> 
>  org.scala-lang
>  scala-library
> 
> 
>  org.scala-lang
>  scala-compiler
> 
> 
>  org.scala-lang
>  scala-reflect
> 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3567) Change scala dependency to provided

2018-09-20 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16623012#comment-16623012
 ] 

ASF GitHub Bot commented on KYLIN-3567:
---

shaofengshi closed pull request #239: KYLIN-3567 Change scala dependency scope 
to provided
URL: https://github.com/apache/kylin/pull/239
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/engine-spark/pom.xml b/engine-spark/pom.xml
index 9516b19ffe..26a3ad7c62 100644
--- a/engine-spark/pom.xml
+++ b/engine-spark/pom.xml
@@ -104,16 +104,19 @@
 
 org.scala-lang
 scala-library
+provided
 
 
 
 org.scala-lang
 scala-compiler
+provided
 
 
 
 org.scala-lang
 scala-reflect
+provided
 
 
 


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Change scala dependency to provided
> ---
>
> Key: KYLIN-3567
> URL: https://issues.apache.org/jira/browse/KYLIN-3567
> Project: Kylin
>  Issue Type: Bug
>Reporter: Chao Long
>Assignee: Chao Long
>Priority: Minor
> Fix For: v2.5.1
>
>
> The scope of scala dependency in "engine-spark" module should be "provided".
> 
>  org.scala-lang
>  scala-library
> 
> 
>  org.scala-lang
>  scala-compiler
> 
> 
>  org.scala-lang
>  scala-reflect
> 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3445) Upgrade checkstyle version to 8.6

2018-09-20 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16623015#comment-16623015
 ] 

ASF subversion and git services commented on KYLIN-3445:


Commit e093fac0aa98712560cb4438956730c849098953 in kylin's branch 
refs/heads/master from GinaZhai
[ https://gitbox.apache.org/repos/asf?p=kylin.git;h=e093fac ]

KYLIN-3445 Upgrade checkstyle version to 8.6


> Upgrade checkstyle version to 8.6
> -
>
> Key: KYLIN-3445
> URL: https://issues.apache.org/jira/browse/KYLIN-3445
> Project: Kylin
>  Issue Type: Improvement
>  Components: Tools, Build and Test
>Reporter: Ted Yu
>Priority: Minor
> Fix For: v2.6.0
>
>
> We should upgrade checkstyle version to 8.6+ so that we can use the "match 
> violation message to this regex" feature for suppression. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (KYLIN-3556) Interned string should not be used as lock object

2018-09-20 Thread Kaige Liu (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

 Kaige Liu reassigned KYLIN-3556:
-

Assignee:  Kaige Liu

> Interned string should not be used as lock object
> -
>
> Key: KYLIN-3556
> URL: https://issues.apache.org/jira/browse/KYLIN-3556
> Project: Kylin
>  Issue Type: Bug
>  Components: Metadata
>Affects Versions: v2.5.0
>Reporter: Ted Yu
>Assignee:  Kaige Liu
>Priority: Minor
> Fix For: v2.5.1
>
>
> In JDBCResourceDAO :
> {code}
> public void execute(Connection connection) throws SQLException {
> synchronized (resPath.intern()) {
> {code}
> Locking on an interned string can cause unexpected locking collisions with 
> other part of code.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3546) Kylin doesn't persist FK to intermediate table if FK is not a dimension

2018-09-20 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16623129#comment-16623129
 ] 

ASF GitHub Bot commented on KYLIN-3546:
---

hit-lacus opened a new pull request #241: KYLIN-3546 Add column which belongs 
to root fact table in join relation but lost
URL: https://github.com/apache/kylin/pull/241
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Kylin doesn't persist FK to intermediate table if FK is not a dimension
> ---
>
> Key: KYLIN-3546
> URL: https://issues.apache.org/jira/browse/KYLIN-3546
> Project: Kylin
>  Issue Type: Bug
>  Components: Streaming
>Affects Versions: v2.4.0
>Reporter: wlxie
>Assignee: XiaoXiang Yu
>Priority: Major
> Fix For: v2.4.2, v2.5.1
>
> Attachments: base_2018_09_18_09_23_53.zip, kylin_kafka.txt
>
>
> 各位老师好,
>    在使用kafka的streaming 
> table作为事实表创建cube时候,如果维度和指标都不选事实表中的关联键的话,在跑cube作业的时候,创建保存kafka数据的临时表会没有这个关联键,导致后面创建关联表的临时表会报错,具体报错信息请查看附件,谢谢。



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3546) Kylin doesn't persist FK to intermediate table if FK is not a dimension

2018-09-20 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16623131#comment-16623131
 ] 

ASF GitHub Bot commented on KYLIN-3546:
---

asfgit commented on issue #241: KYLIN-3546 Add column which belongs to root 
fact table in join relation but lost
URL: https://github.com/apache/kylin/pull/241#issuecomment-423427023
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Kylin doesn't persist FK to intermediate table if FK is not a dimension
> ---
>
> Key: KYLIN-3546
> URL: https://issues.apache.org/jira/browse/KYLIN-3546
> Project: Kylin
>  Issue Type: Bug
>  Components: Streaming
>Affects Versions: v2.4.0
>Reporter: wlxie
>Assignee: XiaoXiang Yu
>Priority: Major
> Fix For: v2.4.2, v2.5.1
>
> Attachments: base_2018_09_18_09_23_53.zip, kylin_kafka.txt
>
>
> 各位老师好,
>    在使用kafka的streaming 
> table作为事实表创建cube时候,如果维度和指标都不选事实表中的关联键的话,在跑cube作业的时候,创建保存kafka数据的临时表会没有这个关联键,导致后面创建关联表的临时表会报错,具体报错信息请查看附件,谢谢。



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3546) Kylin doesn't persist FK to intermediate table if FK is not a dimension

2018-09-20 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16623130#comment-16623130
 ] 

ASF GitHub Bot commented on KYLIN-3546:
---

asfgit commented on issue #241: KYLIN-3546 Add column which belongs to root 
fact table in join relation but lost
URL: https://github.com/apache/kylin/pull/241#issuecomment-423427022
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Kylin doesn't persist FK to intermediate table if FK is not a dimension
> ---
>
> Key: KYLIN-3546
> URL: https://issues.apache.org/jira/browse/KYLIN-3546
> Project: Kylin
>  Issue Type: Bug
>  Components: Streaming
>Affects Versions: v2.4.0
>Reporter: wlxie
>Assignee: XiaoXiang Yu
>Priority: Major
> Fix For: v2.4.2, v2.5.1
>
> Attachments: base_2018_09_18_09_23_53.zip, kylin_kafka.txt
>
>
> 各位老师好,
>    在使用kafka的streaming 
> table作为事实表创建cube时候,如果维度和指标都不选事实表中的关联键的话,在跑cube作业的时候,创建保存kafka数据的临时表会没有这个关联键,导致后面创建关联表的临时表会报错,具体报错信息请查看附件,谢谢。



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)