[jira] [Assigned] (KYLIN-3602) Enable more checkstyle rules
[ https://issues.apache.org/jira/browse/KYLIN-3602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaofeng SHI reassigned KYLIN-3602: --- Assignee: Yichen Zhou > Enable more checkstyle rules > > > Key: KYLIN-3602 > URL: https://issues.apache.org/jira/browse/KYLIN-3602 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Yichen Zhou >Assignee: Yichen Zhou >Priority: Major > Fix For: v2.6.0 > > Attachments: checkstyle-aggregate.html > > > The checkstyle rules of kylin are too weak. We need to reinfore them to > achieve better code quality. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (KYLIN-3272) Upgrade Spark dependency to 2.3.2
[ https://issues.apache.org/jira/browse/KYLIN-3272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lijun Cao reassigned KYLIN-3272: Assignee: Lijun Cao > Upgrade Spark dependency to 2.3.2 > - > > Key: KYLIN-3272 > URL: https://issues.apache.org/jira/browse/KYLIN-3272 > Project: Kylin > Issue Type: Improvement > Components: Spark Engine >Reporter: Ted Yu >Assignee: Lijun Cao >Priority: Minor > > Currently Spark 2.1.2 is used. > Spark 2.3.2 was released. > We should upgrade the dependency to 2.3.2 > https://sematext.com/opensee/m/Spark/q3RTtb4Q9LI4F6F?subj=+ANNOUNCE+Announcing+Apache+Spark+2+3+2 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16633313#comment-16633313 ] ASF GitHub Bot commented on KYLIN-3597: --- asfgit commented on issue #278: KYLIN-3597 Close JavaSparkContext after used. URL: https://github.com/apache/kylin/pull/278#issuecomment-425705185 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix sonar reported static code issues > - > > Key: KYLIN-3597 > URL: https://issues.apache.org/jira/browse/KYLIN-3597 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Shaofeng SHI >Priority: Major > Fix For: v2.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16633312#comment-16633312 ] ASF GitHub Bot commented on KYLIN-3597: --- asfgit commented on issue #278: KYLIN-3597 Close JavaSparkContext after used. URL: https://github.com/apache/kylin/pull/278#issuecomment-425705184 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix sonar reported static code issues > - > > Key: KYLIN-3597 > URL: https://issues.apache.org/jira/browse/KYLIN-3597 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Shaofeng SHI >Priority: Major > Fix For: v2.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16633311#comment-16633311 ] ASF GitHub Bot commented on KYLIN-3597: --- caolijun1166 opened a new pull request #278: KYLIN-3597 Close JavaSparkContext after used. URL: https://github.com/apache/kylin/pull/278 KYLIN-3597 Use try-with-resources to close JavaSparkContext after used. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix sonar reported static code issues > - > > Key: KYLIN-3597 > URL: https://issues.apache.org/jira/browse/KYLIN-3597 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Shaofeng SHI >Priority: Major > Fix For: v2.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16633318#comment-16633318 ] ASF GitHub Bot commented on KYLIN-3597: --- codecov-io commented on issue #278: KYLIN-3597 Close JavaSparkContext after used. URL: https://github.com/apache/kylin/pull/278#issuecomment-425706587 # [Codecov](https://codecov.io/gh/apache/kylin/pull/278?src=pr&el=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@8e98b8b`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is `0%`. [](https://codecov.io/gh/apache/kylin/pull/278?src=pr&el=tree) ```diff @@Coverage Diff@@ ## master #278 +/- ## = Coverage ? 21.28% Complexity? 4435 = Files ? 1087 Lines ?69977 Branches ?10126 = Hits ?14894 Misses?53680 Partials ? 1403 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/278?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ache/kylin/storage/hbase/steps/SparkCubeHFile.java](https://codecov.io/gh/apache/kylin/pull/278/diff?src=pr&el=tree#diff-c3RvcmFnZS1oYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9oYmFzZS9zdGVwcy9TcGFya0N1YmVIRmlsZS5qYXZh) | `3.53% <0%> (ø)` | `0 <0> (?)` | | | [...che/kylin/engine/spark/SparkMergingDictionary.java](https://codecov.io/gh/apache/kylin/pull/278/diff?src=pr&el=tree#diff-ZW5naW5lLXNwYXJrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvc3BhcmsvU3BhcmtNZXJnaW5nRGljdGlvbmFyeS5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...rg/apache/kylin/engine/spark/SparkCubingMerge.java](https://codecov.io/gh/apache/kylin/pull/278/diff?src=pr&el=tree#diff-ZW5naW5lLXNwYXJrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvc3BhcmsvU3BhcmtDdWJpbmdNZXJnZS5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...g/apache/kylin/engine/spark/SparkFactDistinct.java](https://codecov.io/gh/apache/kylin/pull/278/diff?src=pr&el=tree#diff-ZW5naW5lLXNwYXJrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvc3BhcmsvU3BhcmtGYWN0RGlzdGluY3QuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/278?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/278?src=pr&el=footer). Last update [8e98b8b...d5a57a8](https://codecov.io/gh/apache/kylin/pull/278?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix sonar reported static code issues > - > > Key: KYLIN-3597 > URL: https://issues.apache.org/jira/browse/KYLIN-3597 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Shaofeng SHI >Priority: Major > Fix For: v2.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16633319#comment-16633319 ] ASF GitHub Bot commented on KYLIN-3597: --- coveralls commented on issue #278: KYLIN-3597 Close JavaSparkContext after used. URL: https://github.com/apache/kylin/pull/278#issuecomment-425706651 ## Pull Request Test Coverage Report for [Build 3728](https://coveralls.io/builds/19267812) * **0** of **184** **(0.0%)** changed or added relevant lines in **4** files are covered. * **6** unchanged lines in **4** files lost coverage. * Overall coverage increased (+**0.003%**) to **23.292%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [engine-spark/src/main/java/org/apache/kylin/engine/spark/SparkMergingDictionary.java](https://coveralls.io/builds/19267812/source?filename=engine-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fspark%2FSparkMergingDictionary.java#L127) | 0 | 19 | 0.0% | [engine-spark/src/main/java/org/apache/kylin/engine/spark/SparkFactDistinct.java](https://coveralls.io/builds/19267812/source?filename=engine-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fspark%2FSparkFactDistinct.java#L167) | 0 | 38 | 0.0% | [storage-hbase/src/main/java/org/apache/kylin/storage/hbase/steps/SparkCubeHFile.java](https://coveralls.io/builds/19267812/source?filename=storage-hbase%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fhbase%2Fsteps%2FSparkCubeHFile.java#L137) | 0 | 58 | 0.0% | [engine-spark/src/main/java/org/apache/kylin/engine/spark/SparkCubingMerge.java](https://coveralls.io/builds/19267812/source?filename=engine-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fspark%2FSparkCubingMerge.java#L114) | 0 | 69 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [engine-spark/src/main/java/org/apache/kylin/engine/spark/SparkFactDistinct.java](https://coveralls.io/builds/19267812/source?filename=engine-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fspark%2FSparkFactDistinct.java#L236) | 1 | 0.0% | | [storage-hbase/src/main/java/org/apache/kylin/storage/hbase/steps/SparkCubeHFile.java](https://coveralls.io/builds/19267812/source?filename=storage-hbase%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fhbase%2Fsteps%2FSparkCubeHFile.java#L244) | 1 | 4.42% | | [engine-spark/src/main/java/org/apache/kylin/engine/spark/SparkMergingDictionary.java](https://coveralls.io/builds/19267812/source?filename=engine-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fspark%2FSparkMergingDictionary.java#L159) | 1 | 0.0% | | [engine-spark/src/main/java/org/apache/kylin/engine/spark/SparkCubingMerge.java](https://coveralls.io/builds/19267812/source?filename=engine-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fspark%2FSparkCubingMerge.java#L166) | 3 | 0.0% | | Totals | [](https://coveralls.io/builds/19267812) | | :-- | --: | | Change from base [Build 3727](https://coveralls.io/builds/19267255): | 0.003% | | Covered Lines: | 16299 | | Relevant Lines: | 69977 | --- # 💛 - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix sonar reported static code issues > - > > Key: KYLIN-3597 > URL: https://issues.apache.org/jira/browse/KYLIN-3597 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Shaofeng SHI >Priority: Major > Fix For: v2.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[
https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16633329#comment-16633329
]
ASF GitHub Bot commented on KYLIN-3597:
---
shaofengshi closed pull request #278: KYLIN-3597 Close JavaSparkContext after
used.
URL: https://github.com/apache/kylin/pull/278
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/engine-spark/src/main/java/org/apache/kylin/engine/spark/SparkCubingMerge.java
b/engine-spark/src/main/java/org/apache/kylin/engine/spark/SparkCubingMerge.java
index 0b03f7077d..5037647a6f 100644
---
a/engine-spark/src/main/java/org/apache/kylin/engine/spark/SparkCubingMerge.java
+++
b/engine-spark/src/main/java/org/apache/kylin/engine/spark/SparkCubingMerge.java
@@ -111,127 +111,128 @@ protected void execute(OptionsHelper optionsHelper)
throws Exception {
conf.set("spark.kryo.registrator",
"org.apache.kylin.engine.spark.KylinKryoRegistrator");
conf.set("spark.kryo.registrationRequired",
"true").registerKryoClasses(kryoClassArray);
-JavaSparkContext sc = new JavaSparkContext(conf);
-SparkUtil.modifySparkHadoopConfiguration(sc.sc()); // set
dfs.replication=2 and enable compress
-KylinSparkJobListener jobListener = new KylinSparkJobListener();
-sc.sc().addSparkListener(jobListener);
-
-HadoopUtil.deletePath(sc.hadoopConfiguration(), new Path(outputPath));
-final SerializableConfiguration sConf = new
SerializableConfiguration(sc.hadoopConfiguration());
-final KylinConfig envConfig =
AbstractHadoopJob.loadKylinConfigFromHdfs(sConf, metaUrl);
-
-final CubeInstance cubeInstance =
CubeManager.getInstance(envConfig).getCube(cubeName);
-final CubeDesc cubeDesc =
CubeDescManager.getInstance(envConfig).getCubeDesc(cubeInstance.getDescName());
-final CubeSegment cubeSegment = cubeInstance.getSegmentById(segmentId);
-final CubeStatsReader cubeStatsReader = new
CubeStatsReader(cubeSegment, envConfig);
-
-logger.info("Input path: {}", inputPath);
-logger.info("Output path: {}", outputPath);
-
-final Job job = Job.getInstance(sConf.get());
-
-SparkUtil.setHadoopConfForCuboid(job, cubeSegment, metaUrl);
-
-final MeasureAggregators aggregators = new
MeasureAggregators(cubeDesc.getMeasures());
-final Function2 reduceFunction = new Function2() {
-@Override
-public Object[] call(Object[] input1, Object[] input2) throws
Exception {
-Object[] measureObjs = new Object[input1.length];
-aggregators.aggregate(input1, input2, measureObjs);
-return measureObjs;
-}
-};
-
-final PairFunction convertTextFunction = new PairFunction, org.apache.hadoop.io.Text, org.apache.hadoop.io.Text>() {
-private transient volatile boolean initialized = false;
-BufferedMeasureCodec codec;
-
-@Override
-public Tuple2 call(Tuple2 tuple2)
-throws Exception {
-
-if (initialized == false) {
-synchronized (SparkCubingMerge.class) {
-if (initialized == false) {
-synchronized (SparkCubingMerge.class) {
-if (initialized == false) {
-KylinConfig kylinConfig =
AbstractHadoopJob.loadKylinConfigFromHdfs(sConf, metaUrl);
-try
(KylinConfig.SetAndUnsetThreadLocalConfig autoUnset = KylinConfig
-
.setAndUnsetThreadLocalConfig(kylinConfig)) {
-CubeDesc desc =
CubeDescManager.getInstance(kylinConfig).getCubeDesc(cubeName);
-codec = new
BufferedMeasureCodec(desc.getMeasures());
-initialized = true;
+try (JavaSparkContext sc = new JavaSparkContext(conf)) {
+SparkUtil.modifySparkHadoopConfiguration(sc.sc()); // set
dfs.replication=2 and enable compress
+KylinSparkJobListener jobListener = new KylinSparkJobListener();
+sc.sc().addSparkListener(jobListener);
+
+HadoopUtil.deletePath(sc.hadoopConfiguration(), new
Path(outputPath));
+final SerializableConfiguration sConf = new
SerializableConfiguration(sc.hadoopConfiguration());
+final KylinConfig envConfig =
AbstractHadoopJob.loadKylinConfigFromHdfs(sConf, metaUrl);
+
+final CubeInstance cubeInstance =
CubeManager.getInstance(envConfig).getCube(cubeName);
+final CubeDesc
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1660#comment-1660 ] ASF subversion and git services commented on KYLIN-3597: Commit f859e4363f4fea381ee65538f76c37882750a531 in kylin's branch refs/heads/master from [~caolijun1166] [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=f859e43 ] KYLIN-3597 Close JavaSparkContext after used. > Fix sonar reported static code issues > - > > Key: KYLIN-3597 > URL: https://issues.apache.org/jira/browse/KYLIN-3597 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Shaofeng SHI >Priority: Major > Fix For: v2.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (KYLIN-3561) Upgrade to JUnit 5
[ https://issues.apache.org/jira/browse/KYLIN-3561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated KYLIN-3561: -- Description: JUnit 5 brings multiple useful features so tests are easier to read and write. We can bump up the dependency version and create new tests with JUnit 5 features. Relevant features of JUnit 5: dynamic test, nested tests, parameterized tests https://twitter.com/nipafx/status/1027095088059559936 was: JUnit 5 brings multiple useful features so tests are easier to read and write. We can bump up the dependency version and create new tests with JUnit 5 features. Relevant features of JUnit 5: dynamic test, nested tests, parameterized tests https://twitter.com/nipafx/status/1027095088059559936 > Upgrade to JUnit 5 > -- > > Key: KYLIN-3561 > URL: https://issues.apache.org/jira/browse/KYLIN-3561 > Project: Kylin > Issue Type: Task >Reporter: Ted Yu >Priority: Major > > JUnit 5 brings multiple useful features so tests are easier to read and write. > We can bump up the dependency version and create new tests with JUnit 5 > features. > Relevant features of JUnit 5: dynamic test, nested tests, parameterized tests > https://twitter.com/nipafx/status/1027095088059559936 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (KYLIN-3450) Consider using google re2j
[ https://issues.apache.org/jira/browse/KYLIN-3450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16556761#comment-16556761 ] Ted Yu edited comment on KYLIN-3450 at 10/1/18 1:39 AM: It would be nice to see improvement from using re2j. was (Author: yuzhih...@gmail.com): It would be nice to see improvement from using re2j . > Consider using google re2j > -- > > Key: KYLIN-3450 > URL: https://issues.apache.org/jira/browse/KYLIN-3450 > Project: Kylin > Issue Type: Improvement >Reporter: Ted Yu >Priority: Minor > > RE2J : https://github.com/google/re2j > For regular expression patterns with a high degree of alternation, using RE2J > would exhibit higher performance. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (KYLIN-3484) Update Hadoop version to 2.7.7
[ https://issues.apache.org/jira/browse/KYLIN-3484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated KYLIN-3484: -- Description: We should upgrade the Hadoop 2.7 dependency to 2.7.7, to pick up bug and security fixes. (was: We should upgrade the Hadoop 2.7 dependency to 2.7.7, to pick up bug and security fixes .) > Update Hadoop version to 2.7.7 > -- > > Key: KYLIN-3484 > URL: https://issues.apache.org/jira/browse/KYLIN-3484 > Project: Kylin > Issue Type: Task >Reporter: Ted Yu >Priority: Minor > > We should upgrade the Hadoop 2.7 dependency to 2.7.7, to pick up bug and > security fixes. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (KYLIN-3394) Prepare for Kafka 2.0
[
https://issues.apache.org/jira/browse/KYLIN-3394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated KYLIN-3394:
--
Description:
Kafka 2.0 has been released.
I got the following when compiling against Kafka 2.0.0:
{code}
[ERROR] /a/kylin/kylin-it/src/test/scala/kafka/admin/AdminUtils.scala:266:
error: type mismatch;
[ERROR] found : Option[org.apache.kafka.common.Node]
[ERROR] required: org.apache.kafka.common.Node
[ERROR] getBrokerInfoFromCache(zkUtils, cachedBrokerInfo,
List(l)).head.getNode(listenerName)
[ERROR]
^
[ERROR] /a/kylin/kylin-it/src/test/scala/kafka/admin/AdminUtils.scala:273:
error: type mismatch;
[ERROR] found : Seq[Option[org.apache.kafka.common.Node]]
[ERROR] required: Seq[org.apache.kafka.common.Node]
[ERROR] replicaInfo = getBrokerInfoFromCache(zkUtils,
cachedBrokerInfo, replicas).map(_.getNode(listenerName))
[ERROR]
^
[ERROR] /a/kylin/kylin-it/src/test/scala/kafka/admin/AdminUtils.scala:274:
error: type mismatch;
[ERROR] found : Seq[Option[org.apache.kafka.common.Node]]
[ERROR] required: Seq[org.apache.kafka.common.Node]
[ERROR] isrInfo = getBrokerInfoFromCache(zkUtils, cachedBrokerInfo,
inSyncReplicas).map(_.getNode(listenerName))
[ERROR]
^
[ERROR] /a/kylin/kylin-it/src/test/scala/kafka/admin/AdminUtils.scala:476:
error: value getConsumersInGroup is not a member of kafka.utils.ZkUtils
[ERROR] zkUtils.getConsumersInGroup(group).nonEmpty
[ERROR] ^
[ERROR] /a/kylin/kylin-it/src/test/scala/kafka/admin/AdminUtils.scala:489:
error: not found: type ZKGroupDirs
[ERROR] val dir = new ZKGroupDirs(group)
[ERROR] ^
[ERROR] /a/kylin/kylin-it/src/test/scala/kafka/admin/AdminUtils.scala:507:
error: value getTopicsByConsumerGroup is not a member of kafka.utils.ZkUtils
[ERROR] val topics = zkUtils.getTopicsByConsumerGroup(group)
[ERROR] ^
[ERROR] /a/kylin/kylin-it/src/test/scala/kafka/admin/AdminUtils.scala:512:
error: not found: type ZKGroupTopicDirs
[ERROR] val dir = new ZKGroupTopicDirs(group, topic)
[ERROR] ^
[ERROR] /a/kylin/kylin-it/src/test/scala/kafka/admin/AdminUtils.scala:528:
error: value getAllConsumerGroupsForTopic is not a member of kafka.utils.ZkUtils
[ERROR] val groups = zkUtils.getAllConsumerGroupsForTopic(topic)
[ERROR] ^
[ERROR] /a/kylin/kylin-it/src/test/scala/kafka/admin/AdminUtils.scala:720:
error: value encode is not a member of object kafka.utils.Json
[ERROR] val content =
Json.encode(getConfigChangeZnodeData(sanitizedEntityPath))
[ERROR]^
[ERROR] /a/kylin/kylin-it/src/test/scala/kafka/admin/AdminUtils.scala:733:
error: value encode is not a member of object kafka.utils.Json
[ERROR] zkUtils.updatePersistentPath(entityPath, Json.encode(map))
{code}
was:
Kafka 2.0 is around the corner.
I got the following when compiling against Kafka 2.0.0:
{code}
[ERROR] /a/kylin/kylin-it/src/test/scala/kafka/admin/AdminUtils.scala:266:
error: type mismatch;
[ERROR] found : Option[org.apache.kafka.common.Node]
[ERROR] required: org.apache.kafka.common.Node
[ERROR] getBrokerInfoFromCache(zkUtils, cachedBrokerInfo,
List(l)).head.getNode(listenerName)
[ERROR]
^
[ERROR] /a/kylin/kylin-it/src/test/scala/kafka/admin/AdminUtils.scala:273:
error: type mismatch;
[ERROR] found : Seq[Option[org.apache.kafka.common.Node]]
[ERROR] required: Seq[org.apache.kafka.common.Node]
[ERROR] replicaInfo = getBrokerInfoFromCache(zkUtils,
cachedBrokerInfo, replicas).map(_.getNode(listenerName))
[ERROR]
^
[ERROR] /a/kylin/kylin-it/src/test/scala/kafka/admin/AdminUtils.scala:274:
error: type mismatch;
[ERROR] found : Seq[Option[org.apache.kafka.common.Node]]
[ERROR] required: Seq[org.apache.kafka.common.Node]
[ERROR] isrInfo = getBrokerInfoFromCache(zkUtils, cachedBrokerInfo,
inSyncReplicas).map(_.getNode(listenerName))
[ERROR]
^
[ERROR] /a/kylin/kylin-it/src/test/scala/kafka/admin/AdminUtils.scala:476:
error: value getConsumersInGroup is not a member of kafka.utils.ZkUtils
[ERROR] zkUtils.getConsumersInGroup(group).nonEmpty
[ERROR] ^
[ERROR] /a/kylin/kylin-it/src/test/scala/kafka/admin/AdminUtils.scala:489:
error: not found: type ZKGroupDirs
[ERROR] val dir = new ZKGroupDirs(group)
[ERROR] ^
[ER
[jira] [Comment Edited] (KYLIN-3310) Use lint for maven-compiler-plugin
[
https://issues.apache.org/jira/browse/KYLIN-3310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16560940#comment-16560940
]
Ted Yu edited comment on KYLIN-3310 at 10/1/18 1:40 AM:
Thanks, Jiatao.
was (Author: yuzhih...@gmail.com):
Thanks, Jiatao .
> Use lint for maven-compiler-plugin
> --
>
> Key: KYLIN-3310
> URL: https://issues.apache.org/jira/browse/KYLIN-3310
> Project: Kylin
> Issue Type: Improvement
> Components: Tools, Build and Test
>Reporter: Ted Yu
>Assignee: jiatao.tao
>Priority: Major
> Fix For: v2.6.0
>
>
> lint helps identify structural problems.
> We should enable lint for maven-compiler-plugin
> {code}
> maven-compiler-plugin
> ${maven-compiler-plugin.version}
>
> 1.8
> 1.8
>
> -Xlint:all
> ${compiler.error.flag}
>
> -Xlint:-options
>
> -Xlint:-cast
> -Xlint:-deprecation
> -Xlint:-processing
> -Xlint:-rawtypes
> -Xlint:-serial
> -Xlint:-try
> -Xlint:-unchecked
> -Xlint:-varargs
>
>
>
>
> true
>
> false
>
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
