[GitHub] coveralls commented on issue #422: KYLIN-3430 Global Dictionary Cleanup

2018-12-26 Thread GitBox
coveralls commented on issue #422: KYLIN-3430 Global Dictionary Cleanup
URL: https://github.com/apache/kylin/pull/422#issuecomment-450093826
 
 
   ## Pull Request Test Coverage Report for [Build 
4018](https://coveralls.io/builds/20808599)
   
   * **9** of **29**   **(31.03%)**  changed or added relevant lines in **1** 
file are covered.
   * **1** unchanged line in **1** file lost coverage.
   * Overall coverage increased (+**0.002%**) to **26.84%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-|--||---: |
   | 
[server-base/src/main/java/org/apache/kylin/rest/job/MetadataCleanupJob.java](https://coveralls.io/builds/20808599/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fjob%2FMetadataCleanupJob.java#L98)
 | 9 | 29 | 31.03%
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-|--|--: |
   | 
[core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://coveralls.io/builds/20808599/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2Flookup%2Fcache%2FRocksDBLookupTable.java#L62)
 | 1 | 81.08% |
   
   
   |  Totals | [![Coverage 
Status](https://coveralls.io/builds/20808599/badge)](https://coveralls.io/builds/20808599)
 |
   | :-- | --: |
   | Change from base [Build 4015](https://coveralls.io/builds/20806993): |  
0.002% |
   | Covered Lines: | 18606 |
   | Relevant Lines: | 69321 |
   
   ---
   #   - [Coveralls](https://coveralls.io)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (KYLIN-3430) Global Dictionary Cleanup

2018-12-26 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16729386#comment-16729386
 ] 

ASF GitHub Bot commented on KYLIN-3430:
---

TempleZhou commented on pull request #422: KYLIN-3430 Global Dictionary Cleanup
URL: https://github.com/apache/kylin/pull/422
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Global Dictionary Cleanup
> -
>
> Key: KYLIN-3430
> URL: https://issues.apache.org/jira/browse/KYLIN-3430
> Project: Kylin
>  Issue Type: Improvement
>  Components: Tools, Build and Test
>Affects Versions: v2.1.0, v2.2.0, v2.3.0, v2.3.1, v2.4.0
>Reporter: Temple Zhou
>Assignee: Temple Zhou
>Priority: Major
> Attachments: KYLIN-3430.master.001.patch
>
>
> I had run "{{./bin/metastore.sh clean --delete true" to cleanup my Kylin 
> metadata, but, after that, the Global Dictionary still exists in my HDFS and 
> the size of directory "/kylin_metadata/resources/GlobalDict/dict" hasn't 
> shrunk.}}
>  
> {{BTW: I'm very sure that there are redundant Global Dictionaries.}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] TempleZhou opened a new pull request #422: KYLIN-3430 Global Dictionary Cleanup

2018-12-26 Thread GitBox
TempleZhou opened a new pull request #422: KYLIN-3430 Global Dictionary Cleanup
URL: https://github.com/apache/kylin/pull/422
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] asfgit commented on issue #422: KYLIN-3430 Global Dictionary Cleanup

2018-12-26 Thread GitBox
asfgit commented on issue #422: KYLIN-3430 Global Dictionary Cleanup
URL: https://github.com/apache/kylin/pull/422#issuecomment-450088607
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (KYLIN-3430) Global Dictionary Cleanup

2018-12-26 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16729381#comment-16729381
 ] 

ASF GitHub Bot commented on KYLIN-3430:
---

TempleZhou commented on pull request #421: KYLIN-3430 Global Dictionary Cleanup
URL: https://github.com/apache/kylin/pull/421
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Global Dictionary Cleanup
> -
>
> Key: KYLIN-3430
> URL: https://issues.apache.org/jira/browse/KYLIN-3430
> Project: Kylin
>  Issue Type: Improvement
>  Components: Tools, Build and Test
>Affects Versions: v2.1.0, v2.2.0, v2.3.0, v2.3.1, v2.4.0
>Reporter: Temple Zhou
>Assignee: Temple Zhou
>Priority: Major
> Attachments: KYLIN-3430.master.001.patch
>
>
> I had run "{{./bin/metastore.sh clean --delete true" to cleanup my Kylin 
> metadata, but, after that, the Global Dictionary still exists in my HDFS and 
> the size of directory "/kylin_metadata/resources/GlobalDict/dict" hasn't 
> shrunk.}}
>  
> {{BTW: I'm very sure that there are redundant Global Dictionaries.}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3430) Global Dictionary Cleanup

2018-12-26 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16729382#comment-16729382
 ] 

ASF GitHub Bot commented on KYLIN-3430:
---

TempleZhou commented on pull request #421: KYLIN-3430 Global Dictionary Cleanup
URL: https://github.com/apache/kylin/pull/421
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Global Dictionary Cleanup
> -
>
> Key: KYLIN-3430
> URL: https://issues.apache.org/jira/browse/KYLIN-3430
> Project: Kylin
>  Issue Type: Improvement
>  Components: Tools, Build and Test
>Affects Versions: v2.1.0, v2.2.0, v2.3.0, v2.3.1, v2.4.0
>Reporter: Temple Zhou
>Assignee: Temple Zhou
>Priority: Major
> Attachments: KYLIN-3430.master.001.patch
>
>
> I had run "{{./bin/metastore.sh clean --delete true" to cleanup my Kylin 
> metadata, but, after that, the Global Dictionary still exists in my HDFS and 
> the size of directory "/kylin_metadata/resources/GlobalDict/dict" hasn't 
> shrunk.}}
>  
> {{BTW: I'm very sure that there are redundant Global Dictionaries.}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] TempleZhou closed pull request #421: KYLIN-3430 Global Dictionary Cleanup

2018-12-26 Thread GitBox
TempleZhou closed pull request #421: KYLIN-3430 Global Dictionary Cleanup
URL: https://github.com/apache/kylin/pull/421
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/server-base/src/main/java/org/apache/kylin/rest/job/MetadataCleanupJob.java 
b/server-base/src/main/java/org/apache/kylin/rest/job/MetadataCleanupJob.java
index 5ee5c7a370..2ac072a997 100644
--- 
a/server-base/src/main/java/org/apache/kylin/rest/job/MetadataCleanupJob.java
+++ 
b/server-base/src/main/java/org/apache/kylin/rest/job/MetadataCleanupJob.java
@@ -18,6 +18,7 @@
 
 package org.apache.kylin.rest.job;
 
+import java.io.FileNotFoundException;
 import java.io.IOException;
 import java.util.Collections;
 import java.util.List;
@@ -25,11 +26,18 @@
 import java.util.Set;
 import java.util.TreeSet;
 
+import org.apache.commons.lang3.ArrayUtils;
+import org.apache.hadoop.fs.FileStatus;
+import org.apache.hadoop.fs.FileSystem;
+import org.apache.hadoop.fs.Path;
 import org.apache.kylin.common.KylinConfig;
 import org.apache.kylin.common.persistence.ResourceStore;
+import org.apache.kylin.common.util.HadoopUtil;
 import org.apache.kylin.cube.CubeInstance;
 import org.apache.kylin.cube.CubeManager;
 import org.apache.kylin.cube.CubeSegment;
+import org.apache.kylin.dict.DictionaryInfo;
+import org.apache.kylin.dict.DictionaryInfoSerializer;
 import org.apache.kylin.job.dao.ExecutableDao;
 import org.apache.kylin.job.dao.ExecutablePO;
 import org.apache.kylin.job.execution.ExecutableState;
@@ -68,6 +76,7 @@ public MetadataCleanupJob(KylinConfig config) {
 CubeManager cubeManager = CubeManager.getInstance(config);
 ResourceStore store = ResourceStore.getStore(config);
 long newResourceTimeCut = System.currentTimeMillis() - 
NEW_RESOURCE_THREADSHOLD_MS;
+FileSystem fs = 
HadoopUtil.getWorkingFileSystem(HadoopUtil.getCurrentConfiguration());
 
 List toDeleteCandidates = Lists.newArrayList();
 
@@ -82,6 +91,23 @@ public MetadataCleanupJob(KylinConfig config) {
 }
 }
 
+// find all of the global dictionaries in HDFS
+try {
+FileStatus[] fStatus = new FileStatus[0];
+fStatus = ArrayUtils.addAll(fStatus, fs.listStatus(new 
Path(KylinConfig.getInstanceFromEnv().getHdfsWorkingDirectory() + 
"resources/GlobalDict/dict")));
+fStatus = ArrayUtils.addAll(fStatus, fs.listStatus(new 
Path(KylinConfig.getInstanceFromEnv().getHdfsWorkingDirectory() + 
"resources/SegmentDict/dict")));
+for (FileStatus status : fStatus) {
+String path = status.getPath().toString();
+FileStatus[] globalDicts = fs.listStatus(new Path(path));
+for (FileStatus globalDict : globalDicts) {
+String GlobalDictPath = globalDict.getPath().toString();
+toDeleteCandidates.add(GlobalDictPath);
+}
+}
+} catch (FileNotFoundException e) {
+logger.info("Working Directory does not exist on HDFS. ");
+}
+
 // three level resources, only dictionaries
 for (String resourceRoot : new String[] { 
ResourceStore.DICT_RESOURCE_ROOT }) {
 for (String dir : noNull(store.listResources(resourceRoot))) {
@@ -102,6 +128,20 @@ public MetadataCleanupJob(KylinConfig config) {
 activeResources.addAll(segment.getSnapshotPaths());
 activeResources.addAll(segment.getDictionaryPaths());
 activeResources.add(segment.getStatisticsResourcePath());
+for (String dictPath : segment.getDictionaryPaths()) {
+DictionaryInfo dictInfo = store.getResource(dictPath, 
DictionaryInfoSerializer.FULL_SERIALIZER);
+if 
("org.apache.kylin.dict.AppendTrieDictionary".equals(dictInfo != null ? 
dictInfo.getDictionaryClass() : null)){
+String dictObj = 
dictInfo.getDictionaryObject().toString();
+String basedir = 
dictObj.substring(dictObj.indexOf("(") + 1, dictObj.indexOf(")") - 1);
+if 
(basedir.startsWith(KylinConfig.getInstanceFromEnv().getHdfsWorkingDirectory() 
+ "/resources/GlobalDict")) {
+
activeResources.add(KylinConfig.getInstanceFromEnv().getHdfsWorkingDirectory()
++ "resources/GlobalDict" + 
dictInfo.getResourceDir());
+} else if 
(basedir.startsWith(KylinConfig.getInstanceFromEnv().getHdfsWorkingDirectory() 
+ "/resources/SegmentDict")) {
+
activeResources.add(KylinConfig.getInstanceFromEnv().getHdfsWorkingDirectory()
++ "resources/SegmentDict" + 
dictInfo.getResourceDir());
+ 

[GitHub] TempleZhou opened a new pull request #421: KYLIN-3430 Global Dictionary Cleanup

2018-12-26 Thread GitBox
TempleZhou opened a new pull request #421: KYLIN-3430 Global Dictionary Cleanup
URL: https://github.com/apache/kylin/pull/421
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] asfgit commented on issue #421: KYLIN-3430 Global Dictionary Cleanup

2018-12-26 Thread GitBox
asfgit commented on issue #421: KYLIN-3430 Global Dictionary Cleanup
URL: https://github.com/apache/kylin/pull/421#issuecomment-450087281
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (KYLIN-3430) Global Dictionary Cleanup

2018-12-26 Thread kangkaisen (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16729375#comment-16729375
 ] 

kangkaisen commented on KYLIN-3430:
---

[~temple.zhou]   LGTM,  +1. Thanks you.

> Global Dictionary Cleanup
> -
>
> Key: KYLIN-3430
> URL: https://issues.apache.org/jira/browse/KYLIN-3430
> Project: Kylin
>  Issue Type: Improvement
>  Components: Tools, Build and Test
>Affects Versions: v2.1.0, v2.2.0, v2.3.0, v2.3.1, v2.4.0
>Reporter: Temple Zhou
>Assignee: Temple Zhou
>Priority: Major
> Attachments: KYLIN-3430.master.001.patch
>
>
> I had run "{{./bin/metastore.sh clean --delete true" to cleanup my Kylin 
> metadata, but, after that, the Global Dictionary still exists in my HDFS and 
> the size of directory "/kylin_metadata/resources/GlobalDict/dict" hasn't 
> shrunk.}}
>  
> {{BTW: I'm very sure that there are redundant Global Dictionaries.}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (KYLIN-3723) Can't find bad query configuration in kylin config doc

2018-12-26 Thread Na Zhai (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Na Zhai resolved KYLIN-3723.

Resolution: Resolved

> Can't find bad query configuration in kylin config doc
> --
>
> Key: KYLIN-3723
> URL: https://issues.apache.org/jira/browse/KYLIN-3723
> Project: Kylin
>  Issue Type: Improvement
>  Components: Documentation
>Affects Versions: v2.5.2
>Reporter: yuzhang qiu
>Assignee: Na Zhai
>Priority: Major
>
> Well,I want to self-define the threshold of bad(slow) query in kylin, but 
> can't find the relative configuration in kylin config document. However, I 
> find the config properties by trace the code(KylinConfigBase.java). So, I 
> wonder why the document doesn't contain the bad query config?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (KYLIN-3658) The keywords of Hive are not supported By Kylin

2018-12-26 Thread Shaofeng SHI (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shaofeng SHI closed KYLIN-3658.
---
Resolution: Duplicate

> The keywords of Hive are not supported By Kylin
> ---
>
> Key: KYLIN-3658
> URL: https://issues.apache.org/jira/browse/KYLIN-3658
> Project: Kylin
>  Issue Type: Bug
>Affects Versions: v2.5.0
>Reporter: liuzhixin
>Priority: Major
>
> Hive2.x version strictly limited in the SQL keywords which must be added on 
> the quotes, 
> e.g.  ` date `, `timestamp` ...
> When Kylin visits Hive, the generated SQL statement does not add the quotes ` 
> ` governing the SQL keywords, it will bring some problems.
> #



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (KYLIN-3658) The keywords of Hive are not supported By Kylin

2018-12-26 Thread Shaofeng SHI (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shaofeng SHI updated KYLIN-3658:

Fix Version/s: (was: v2.6.0)

> The keywords of Hive are not supported By Kylin
> ---
>
> Key: KYLIN-3658
> URL: https://issues.apache.org/jira/browse/KYLIN-3658
> Project: Kylin
>  Issue Type: Bug
>Affects Versions: v2.5.0
>Reporter: liuzhixin
>Priority: Major
>
> Hive2.x version strictly limited in the SQL keywords which must be added on 
> the quotes, 
> e.g.  ` date `, `timestamp` ...
> When Kylin visits Hive, the generated SQL statement does not add the quotes ` 
> ` governing the SQL keywords, it will bring some problems.
> #



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3723) Can't find bad query configuration in kylin config doc

2018-12-26 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16729368#comment-16729368
 ] 

ASF subversion and git services commented on KYLIN-3723:


Commit eb971178d839adbf258781d8e8a9ed6fbd24e8da in kylin's branch 
refs/heads/document from GinaZhai
[ https://gitbox.apache.org/repos/asf?p=kylin.git;h=eb97117 ]

KYLIN-3723 Can't find bad query configuration in kylin config doc


> Can't find bad query configuration in kylin config doc
> --
>
> Key: KYLIN-3723
> URL: https://issues.apache.org/jira/browse/KYLIN-3723
> Project: Kylin
>  Issue Type: Improvement
>  Components: Documentation
>Affects Versions: v2.5.2
>Reporter: yuzhang qiu
>Assignee: Na Zhai
>Priority: Major
>
> Well,I want to self-define the threshold of bad(slow) query in kylin, but 
> can't find the relative configuration in kylin config document. However, I 
> find the config properties by trace the code(KylinConfigBase.java). So, I 
> wonder why the document doesn't contain the bad query config?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] shaofengshi closed pull request #420: KYLIN-3723 Can't find bad query configuration in kylin config doc

2018-12-26 Thread GitBox
shaofengshi closed pull request #420: KYLIN-3723 Can't find bad query 
configuration in kylin config doc
URL: https://github.com/apache/kylin/pull/420
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/website/_docs/install/configuration.cn.md 
b/website/_docs/install/configuration.cn.md
index ed476824b5..197b8d336c 100644
--- a/website/_docs/install/configuration.cn.md
+++ b/website/_docs/install/configuration.cn.md
@@ -48,6 +48,7 @@ permalink: /cn/docs/install/configuration.html
 - [模糊查询](#fuzzy)
- [查询缓存](#cache-config)
- [查询限制](#query-limit)
+   - [坏查询](#bad-query)
- [查询下压](#query-pushdown)
- [查询改写](#convert-sql)
- [收集查询指标到 JMX](#jmx-metrics)
@@ -587,6 +588,18 @@ Kylin 可以使用三种类型的压缩,分别是 HBase 表压缩,Hive 输
 
 
 
+### 坏查询{#bad-query}
+
+`kylin.query.timeout-seconds` 的值为大于 60 或为 
0,`kylin.query.timeout-seconds-coefficient` 其最大值为 double 
的上限。这两个参数的乘积为坏查询检查的间隔时间,如果为 0,那么会设为 60 秒,最长秒数是 int 的最大值。
+
+- `kylin.query.badquery-stacktrace-depth`:设置堆栈追踪的深度,默认值为 10
+- `kylin.query.badquery-history-number`:设置要展示的历史坏查询的数量,默认为 50
+- `kylin.query.badquery-alerting-seconds`:默认为 
90,如果运行时间大于这个值,那么首先就会打出该查询的日志信息,包括(时长、项目、线程、用户、查询 id)。至于是否保存最近的查询,取决于另一个参数。然后记录 
Stack 日志信息,记录的深度由另一个参数指定,方便后续问题分析
+- `kylin.query.badquery-persistent-enabled`:默认为 true,会保存最近的一些坏查询,而且不可在 Cube 
级别进行覆盖
+
+
+
+
 ### 查询下压   {#query-pushdown}
 
 - 
`kylin.query.pushdown.runner-class-name=org.apache.kylin.query.adhoc.PushDownRunnerJdbcImpl`:如果需要启用查询下压,需要移除这句配置的注释
diff --git a/website/_docs/install/configuration.md 
b/website/_docs/install/configuration.md
index cad8b967f9..206a11d83d 100644
--- a/website/_docs/install/configuration.md
+++ b/website/_docs/install/configuration.md
@@ -47,6 +47,7 @@ permalink: /docs/install/configuration.html
 - [Fuzzy Query](#fuzzy)
- [Query Cache](#cache-config)
- [Query Limits](#query-limit)
+   - [Bad Query](#bad-query)
- [Query Pushdown](#query-pushdown)
- [Query rewriting](#convert-sql)
- [Collect Query Metrics to JMX](#jmx-metrics)
@@ -573,7 +574,7 @@ This section introduces Kylin query related configuration.
 
 ### Query Limits {#query-limit}
 
-- `kylin.query.timeout-seconds`: specifies the query timeout in seconds. The 
default value is 0, that is, no timeout limit on query. If the value is less 
than 60, it will set to seconds.
+- `kylin.query.timeout-seconds`: specifies the query timeout in seconds. The 
default value is 0, that is, no timeout limit on query. If the value is less 
than 60, it will set to 60 seconds.
 - `kylin.query.timeout-seconds-coefficient`: specifies the coefficient of the 
query timeout seconds. The default value is 0.5.
 - `kylin.query.max-scan-bytes`: specifies the maximum bytes scanned by the 
query. The default value is 0, that is, there is no limit.
 - `kylin.storage.partition.max-scan-bytes`: specifies the maximum number of 
bytes for the query scan. The default value is 3221225472 (bytes), which is 3GB.
@@ -581,6 +582,16 @@ This section introduces Kylin query related configuration.
 
 
 
+### Bad Query {#bad-query}
+
+The value of `kylin.query.timeout-seconds` is greater than 60 or equals 0, the 
max value of `kylin.query.timeout-seconds-coefficient` is the upper limit of 
double. The result of multiplying two properties is the interval time of 
detecting bad query, if it equals 0, it will be set to 60 seconds, the max 
value of it is the upper limit of int.
+
+- `kylin.query.badquery-stacktrace-depth`: specifies the depth of stack trace. 
The default value is 10.
+- `kylin.query.badquery-history-number`: specifies the showing number of bad 
query history. The default value is 50.
+- `kylin.query.badquery-alerting-seconds`: The default value is 90, if the 
time of running is greater than the value of this property, it will print the 
log of query firstly, including (duration, project, thread, user, query id). 
Whether to save the recent query, it depends on another property. Secondly, 
record the stack log, the depth of log depend on another property, so as to the 
analysis later
+- `kylin.query.badquery-persistent-enabled`: The default value is true, it 
will save the recent bad query, and cannot override in Cube-level
+
+
 ### Query Pushdown {#query-pushdown}
 
 - 
`kylin.query.pushdown.runner-class-name=org.apache.kylin.query.adhoc.PushDownRunnerJdbcImpl`:
 whether to enable query pushdown


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With 

[jira] [Commented] (KYLIN-3723) Can't find bad query configuration in kylin config doc

2018-12-26 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16729367#comment-16729367
 ] 

ASF GitHub Bot commented on KYLIN-3723:
---

shaofengshi commented on pull request #420: KYLIN-3723 Can't find bad query 
configuration in kylin config doc
URL: https://github.com/apache/kylin/pull/420
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Can't find bad query configuration in kylin config doc
> --
>
> Key: KYLIN-3723
> URL: https://issues.apache.org/jira/browse/KYLIN-3723
> Project: Kylin
>  Issue Type: Improvement
>  Components: Documentation
>Affects Versions: v2.5.2
>Reporter: yuzhang qiu
>Assignee: Na Zhai
>Priority: Major
>
> Well,I want to self-define the threshold of bad(slow) query in kylin, but 
> can't find the relative configuration in kylin config document. However, I 
> find the config properties by trace the code(KylinConfigBase.java). So, I 
> wonder why the document doesn't contain the bad query config?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (KYLIN-3474) Tableau 10.5 get malformed token (multi-query instance)

2018-12-26 Thread Temple Zhou (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Temple Zhou reassigned KYLIN-3474:
--

Assignee: Temple Zhou

> Tableau 10.5 get malformed token (multi-query instance)
> ---
>
> Key: KYLIN-3474
> URL: https://issues.apache.org/jira/browse/KYLIN-3474
> Project: Kylin
>  Issue Type: Bug
>  Components: Query Engine, Security
>Affects Versions: v2.4.0
>Reporter: Temple Zhou
>Assignee: Temple Zhou
>Priority: Major
>
> I found that when I use Tableau 10.5 with Kylin 2.4.0(multi-query) , the 
> Tableau Server will get the malformed token error when do query via restful 
> API.
> However, when I use Tableau 10.5 with Kylin 2.4.0(single query instance), the 
> error will be gone.
> Now, I just annotate the following 
> lines(org.apache.kylin.rest.security.KylinAuthenticationProvider 84-87) and 
> the Tableau 10.5 can run regularly with Kylin 2.4.0(multi-query).
> {code:java}
>  @Override
> public Authentication authenticate(Authentication authentication) throws 
> AuthenticationException {
> byte[] hashKey = hf.hashString(authentication.getName() + 
> authentication.getCredentials()).asBytes();
> String userKey = Arrays.toString(hashKey);
> // if (userService.isEvictCacheFlag()) {
> // userCache.invalidateAll();
> // userService.setEvictCacheFlag(false);
> // }
> Authentication authed = userCache.getIfPresent(userKey);
> if (null != authed) {
> SecurityContextHolder.getContext().setAuthentication(authed);
> } else {
> {code}
> I don't know if you tested the Kylin(multi-query) Cluster Mode with Tableau?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3723) Can't find bad query configuration in kylin config doc

2018-12-26 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16729343#comment-16729343
 ] 

ASF GitHub Bot commented on KYLIN-3723:
---

GinaZhai commented on pull request #420: KYLIN-3723 Can't find bad query 
configuration in kylin config doc
URL: https://github.com/apache/kylin/pull/420
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Can't find bad query configuration in kylin config doc
> --
>
> Key: KYLIN-3723
> URL: https://issues.apache.org/jira/browse/KYLIN-3723
> Project: Kylin
>  Issue Type: Improvement
>  Components: Documentation
>Affects Versions: v2.5.2
>Reporter: yuzhang qiu
>Assignee: Na Zhai
>Priority: Major
>
> Well,I want to self-define the threshold of bad(slow) query in kylin, but 
> can't find the relative configuration in kylin config document. However, I 
> find the config properties by trace the code(KylinConfigBase.java). So, I 
> wonder why the document doesn't contain the bad query config?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3430) Global Dictionary Cleanup

2018-12-26 Thread Temple Zhou (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16729341#comment-16729341
 ] 

Temple Zhou commented on KYLIN-3430:


[~kangkaisen] Thanks for you reminder~

I have updated the attachment, please review it again. :D

> Global Dictionary Cleanup
> -
>
> Key: KYLIN-3430
> URL: https://issues.apache.org/jira/browse/KYLIN-3430
> Project: Kylin
>  Issue Type: Improvement
>  Components: Tools, Build and Test
>Affects Versions: v2.1.0, v2.2.0, v2.3.0, v2.3.1, v2.4.0
>Reporter: Temple Zhou
>Assignee: Temple Zhou
>Priority: Major
> Attachments: KYLIN-3430.master.001.patch
>
>
> I had run "{{./bin/metastore.sh clean --delete true" to cleanup my Kylin 
> metadata, but, after that, the Global Dictionary still exists in my HDFS and 
> the size of directory "/kylin_metadata/resources/GlobalDict/dict" hasn't 
> shrunk.}}
>  
> {{BTW: I'm very sure that there are redundant Global Dictionaries.}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] GinaZhai opened a new pull request #420: KYLIN-3723 Can't find bad query configuration in kylin config doc

2018-12-26 Thread GitBox
GinaZhai opened a new pull request #420: KYLIN-3723 Can't find bad query 
configuration in kylin config doc
URL: https://github.com/apache/kylin/pull/420
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] asfgit commented on issue #420: KYLIN-3723 Can't find bad query configuration in kylin config doc

2018-12-26 Thread GitBox
asfgit commented on issue #420: KYLIN-3723 Can't find bad query configuration 
in kylin config doc
URL: https://github.com/apache/kylin/pull/420#issuecomment-450076987
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Updated] (KYLIN-3430) Global Dictionary Cleanup

2018-12-26 Thread Temple Zhou (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Temple Zhou updated KYLIN-3430:
---
Attachment: (was: KYLIN-3430.master.002.patch)

> Global Dictionary Cleanup
> -
>
> Key: KYLIN-3430
> URL: https://issues.apache.org/jira/browse/KYLIN-3430
> Project: Kylin
>  Issue Type: Improvement
>  Components: Tools, Build and Test
>Affects Versions: v2.1.0, v2.2.0, v2.3.0, v2.3.1, v2.4.0
>Reporter: Temple Zhou
>Assignee: Temple Zhou
>Priority: Major
> Attachments: KYLIN-3430.master.001.patch
>
>
> I had run "{{./bin/metastore.sh clean --delete true" to cleanup my Kylin 
> metadata, but, after that, the Global Dictionary still exists in my HDFS and 
> the size of directory "/kylin_metadata/resources/GlobalDict/dict" hasn't 
> shrunk.}}
>  
> {{BTW: I'm very sure that there are redundant Global Dictionaries.}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (KYLIN-3430) Global Dictionary Cleanup

2018-12-26 Thread Temple Zhou (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Temple Zhou updated KYLIN-3430:
---
Attachment: KYLIN-3430.master.001.patch

> Global Dictionary Cleanup
> -
>
> Key: KYLIN-3430
> URL: https://issues.apache.org/jira/browse/KYLIN-3430
> Project: Kylin
>  Issue Type: Improvement
>  Components: Tools, Build and Test
>Affects Versions: v2.1.0, v2.2.0, v2.3.0, v2.3.1, v2.4.0
>Reporter: Temple Zhou
>Assignee: Temple Zhou
>Priority: Major
> Attachments: KYLIN-3430.master.001.patch, KYLIN-3430.master.002.patch
>
>
> I had run "{{./bin/metastore.sh clean --delete true" to cleanup my Kylin 
> metadata, but, after that, the Global Dictionary still exists in my HDFS and 
> the size of directory "/kylin_metadata/resources/GlobalDict/dict" hasn't 
> shrunk.}}
>  
> {{BTW: I'm very sure that there are redundant Global Dictionaries.}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3742) DataRequest fail to deserialized

2018-12-26 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16729286#comment-16729286
 ] 

ASF subversion and git services commented on KYLIN-3742:


Commit c406029bf6fea7dc78417aa4ff20a13c092e0079 in kylin's branch 
refs/heads/realtime-streaming from hit-lacus
[ https://gitbox.apache.org/repos/asf?p=kylin.git;h=c406029 ]

KYLIN-3742 Fix DataRequest for NPE and add some javadoc


> DataRequest fail to deserialized 
> -
>
> Key: KYLIN-3742
> URL: https://issues.apache.org/jira/browse/KYLIN-3742
> Project: Kylin
>  Issue Type: Bug
>  Components: Streaming
>Reporter: XiaoXiang Yu
>Assignee: XiaoXiang Yu
>Priority: Critical
> Attachments: image-2018-12-26-19-25-31-341.png, 
> image-2018-12-26-19-26-44-418.png, image-2018-12-26-19-27-15-397.png, 
> image-2018-12-26-19-29-13-404.png, image-2018-12-26-19-38-10-451.png, 
> image-2018-12-26-19-39-19-039.png, image-2018-12-26-19-42-10-589.png
>
>
> DataRequest send to Streaming Receiver is cannot be deserialized successfully 
> because of 
> ParameterDesc's equals method throw a NPE for field null +_colRef._+
>  1. This Receiver Server 's error log.
> !image-2018-12-26-19-25-31-341.png!
>  
>  
> 2. This the request send by query server. It is a Normal JSON.
> !image-2018-12-26-19-42-10-589.png!  
> !image-2018-12-26-19-29-13-404.png!
>  
>  
> 3. Spring MVC will try to deserialized json string into DataRequest. And 
> filed mertics of DataRequest it is a Set.
>  
> !image-2018-12-26-19-38-10-451.png!
>  
> 4. HashSet use equal method to distinct entry. But equals method will throw 
> NPE.
>  
> !image-2018-12-26-19-39-19-039.png!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3742) DataRequest fail to deserialized

2018-12-26 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16729285#comment-16729285
 ] 

ASF GitHub Bot commented on KYLIN-3742:
---

allenma commented on pull request #417: KYLIN-3742 Fix DataRequest for NPE and 
add some javadoc
URL: https://github.com/apache/kylin/pull/417
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> DataRequest fail to deserialized 
> -
>
> Key: KYLIN-3742
> URL: https://issues.apache.org/jira/browse/KYLIN-3742
> Project: Kylin
>  Issue Type: Bug
>  Components: Streaming
>Reporter: XiaoXiang Yu
>Assignee: XiaoXiang Yu
>Priority: Critical
> Attachments: image-2018-12-26-19-25-31-341.png, 
> image-2018-12-26-19-26-44-418.png, image-2018-12-26-19-27-15-397.png, 
> image-2018-12-26-19-29-13-404.png, image-2018-12-26-19-38-10-451.png, 
> image-2018-12-26-19-39-19-039.png, image-2018-12-26-19-42-10-589.png
>
>
> DataRequest send to Streaming Receiver is cannot be deserialized successfully 
> because of 
> ParameterDesc's equals method throw a NPE for field null +_colRef._+
>  1. This Receiver Server 's error log.
> !image-2018-12-26-19-25-31-341.png!
>  
>  
> 2. This the request send by query server. It is a Normal JSON.
> !image-2018-12-26-19-42-10-589.png!  
> !image-2018-12-26-19-29-13-404.png!
>  
>  
> 3. Spring MVC will try to deserialized json string into DataRequest. And 
> filed mertics of DataRequest it is a Set.
>  
> !image-2018-12-26-19-38-10-451.png!
>  
> 4. HashSet use equal method to distinct entry. But equals method will throw 
> NPE.
>  
> !image-2018-12-26-19-39-19-039.png!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] allenma closed pull request #417: KYLIN-3742 Fix DataRequest for NPE and add some javadoc

2018-12-26 Thread GitBox
allenma closed pull request #417: KYLIN-3742 Fix DataRequest for NPE and add 
some javadoc
URL: https://github.com/apache/kylin/pull/417
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/core-metadata/src/main/java/org/apache/kylin/metadata/model/ParameterDesc.java
 
b/core-metadata/src/main/java/org/apache/kylin/metadata/model/ParameterDesc.java
index f757503ebc..45af397278 100644
--- 
a/core-metadata/src/main/java/org/apache/kylin/metadata/model/ParameterDesc.java
+++ 
b/core-metadata/src/main/java/org/apache/kylin/metadata/model/ParameterDesc.java
@@ -149,8 +149,11 @@ public boolean equals(Object o) {
 if (p.isColumnType()) {
 if (q.isColumnType() == false)
 return false;
-if (q.getColRef().equals(p.getColRef()) == false)
+if (q.getColRef() != null && 
q.getColRef().equals(p.getColRef()) == false)
 return false;
+if (!(q.getType().equals(p.getType()) && 
q.getValue().equals(q.getValue( {
+return false;
+}
 } else {
 if (q.isColumnType() == true)
 return false;
@@ -185,8 +188,13 @@ public int hashCode() {
 
 @Override
 public String toString() {
-String thisStr = isColumnType() ? colRef.toString() : value;
-return nextParameter == null ? thisStr : thisStr + "," + 
nextParameter.toString();
+String tmp = null;
+if (isColumnType() && colRef != null) {
+tmp = colRef.toString();
+} else {
+tmp = value;
+}
+return nextParameter == null ? tmp : tmp + "," + 
nextParameter.toString();
 }
 
 /**
diff --git 
a/server-base/src/main/java/org/apache/kylin/rest/controller/StreamingCoordinatorController.java
 
b/server-base/src/main/java/org/apache/kylin/rest/controller/StreamingCoordinatorController.java
index bc3886fa97..afb6a43afb 100644
--- 
a/server-base/src/main/java/org/apache/kylin/rest/controller/StreamingCoordinatorController.java
+++ 
b/server-base/src/main/java/org/apache/kylin/rest/controller/StreamingCoordinatorController.java
@@ -100,21 +100,24 @@ public CoordinatorResponse reBalance(@RequestBody String 
reBalancePlanStr) {
 }
 }
 
-@RequestMapping(value = "/cubes/{cubeName}/assign", method = { 
RequestMethod.PUT })
+@RequestMapping(value = "/cubes/{cubeName}/assign", method = { 
RequestMethod.PUT }, produces = {
+"application/json" })
 @ResponseBody
 public CoordinatorResponse assignStreamingCube(@PathVariable String 
cubeName) {
 streamingCoordinartorService.assignCube(cubeName);
 return new CoordinatorResponse();
 }
 
-@RequestMapping(value = "/cubes/{cubeName}/unAssign", method = { 
RequestMethod.PUT })
+@RequestMapping(value = "/cubes/{cubeName}/unAssign", method = { 
RequestMethod.PUT }, produces = {
+"application/json" })
 @ResponseBody
 public CoordinatorResponse unAssignStreamingCube(@PathVariable String 
cubeName) {
 streamingCoordinartorService.unAssignCube(cubeName);
 return new CoordinatorResponse();
 }
 
-@RequestMapping(value = "/cubes/{cubeName}/reAssign", method = { 
RequestMethod.POST })
+@RequestMapping(value = "/cubes/{cubeName}/reAssign", method = { 
RequestMethod.POST }, produces = {
+"application/json" })
 @ResponseBody
 public CoordinatorResponse reAssignStreamingCube(@PathVariable String 
cubeName,
 @RequestBody CubeAssignment newAssignments) {
@@ -122,49 +125,55 @@ public CoordinatorResponse 
reAssignStreamingCube(@PathVariable String cubeName,
 return new CoordinatorResponse();
 }
 
-@RequestMapping(value = "/replicaSet", method = { RequestMethod.POST })
+@RequestMapping(value = "/replicaSet", method = { RequestMethod.POST }, 
produces = { "application/json" })
 @ResponseBody
 public CoordinatorResponse createReplicaSet(@RequestBody ReplicaSet rs) {
 streamingCoordinartorService.createReplicaSet(rs);
 return new CoordinatorResponse();
 }
 
-@RequestMapping(value = "/replicaSet/{replicaSetID}", method = { 
RequestMethod.DELETE })
+@RequestMapping(value = "/replicaSet/{replicaSetID}", method = { 
RequestMethod.DELETE }, produces = {
+"application/json" })
 @ResponseBody
 public CoordinatorResponse deleteReplicaSet(@PathVariable Integer 
replicaSetID) {
 streamingCoordinartorService.removeReplicaSet(replicaSetID);
 return new CoordinatorResponse();
 }
 
-@RequestMapping(value = "/replicaSet/{replicaSetID}/{nodeID:.+}", method = 
{ RequestMethod.PUT })
+@RequestMapping(value = 

[jira] [Assigned] (KYLIN-3743) kylin on druid query no data when partion column as filter

2018-12-26 Thread Shaofeng SHI (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shaofeng SHI reassigned KYLIN-3743:
---

Assignee: jinguowei

Good catch, thank you guowei!

> kylin on druid query no data when partion column as filter
> --
>
> Key: KYLIN-3743
> URL: https://issues.apache.org/jira/browse/KYLIN-3743
> Project: Kylin
>  Issue Type: Improvement
>  Components: Query Engine
>Affects Versions: v2.6.0
>Reporter: jinguowei
>Assignee: jinguowei
>Priority: Critical
> Attachments: 123123.pic.jpg, 231545815044_.pic_thumb.jpg
>
>
> kylin on druid,when query like [select * from tb where dt='MMdd'] will no 
> data return
> fix query no data when partion column as filter
> fix on : https://github.com/apache/kylin/pull/419



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3430) Global Dictionary Cleanup

2018-12-26 Thread kangkaisen (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16729282#comment-16729282
 ] 

kangkaisen commented on KYLIN-3430:
---

[~temple.zhou] , Thanks for your patch.

The global dict paths in HDFS have two format:

for `GlobalDictionaryBuilder`:the HDFS path is `String baseDir = hdfsDir + 
"resources/GlobalDict" + dictInfo.getResourceDir() + "/"`,

for `SegmentAppendTrieDictBuilder`: the HDFS path is `String baseDir = hdfsDir 
+ "resources/SegmentDict" + dictInfo.getResourceDir() + "/"+ 
RandomUtil.randomUUID().toString() + "_" + System.currentTimeMillis() + "/";`

Please handle the SegmentDict, thanks you.

> Global Dictionary Cleanup
> -
>
> Key: KYLIN-3430
> URL: https://issues.apache.org/jira/browse/KYLIN-3430
> Project: Kylin
>  Issue Type: Improvement
>  Components: Tools, Build and Test
>Affects Versions: v2.1.0, v2.2.0, v2.3.0, v2.3.1, v2.4.0
>Reporter: Temple Zhou
>Assignee: Temple Zhou
>Priority: Major
> Attachments: KYLIN-3430.master.002.patch
>
>
> I had run "{{./bin/metastore.sh clean --delete true" to cleanup my Kylin 
> metadata, but, after that, the Global Dictionary still exists in my HDFS and 
> the size of directory "/kylin_metadata/resources/GlobalDict/dict" hasn't 
> shrunk.}}
>  
> {{BTW: I'm very sure that there are redundant Global Dictionaries.}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (KYLIN-3743) Kylin on druid query no data when partion column as filter

2018-12-26 Thread Shaofeng SHI (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shaofeng SHI updated KYLIN-3743:

  Priority: Major  (was: Critical)
Issue Type: Bug  (was: Improvement)
   Summary: Kylin on druid query no data when partion column as filter  
(was: kylin on druid query no data when partion column as filter)

> Kylin on druid query no data when partion column as filter
> --
>
> Key: KYLIN-3743
> URL: https://issues.apache.org/jira/browse/KYLIN-3743
> Project: Kylin
>  Issue Type: Bug
>  Components: Query Engine
>Affects Versions: v2.6.0
>Reporter: jinguowei
>Assignee: jinguowei
>Priority: Major
> Attachments: 123123.pic.jpg, 231545815044_.pic_thumb.jpg
>
>
> kylin on druid,when query like [select * from tb where dt='MMdd'] will no 
> data return
> fix query no data when partion column as filter
> fix on : https://github.com/apache/kylin/pull/419



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (KYLIN-3743) Kylin on druid query no data when partion column as filter

2018-12-26 Thread Shaofeng SHI (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shaofeng SHI updated KYLIN-3743:

Fix Version/s: (was: v2.6.0)

> Kylin on druid query no data when partion column as filter
> --
>
> Key: KYLIN-3743
> URL: https://issues.apache.org/jira/browse/KYLIN-3743
> Project: Kylin
>  Issue Type: Bug
>  Components: Query Engine
>Affects Versions: v2.6.0
>Reporter: jinguowei
>Assignee: jinguowei
>Priority: Major
> Attachments: 123123.pic.jpg, 231545815044_.pic_thumb.jpg
>
>
> kylin on druid,when query like [select * from tb where dt='MMdd'] will no 
> data return
> fix query no data when partion column as filter
> fix on : https://github.com/apache/kylin/pull/419



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (KYLIN-3430) Global Dictionary Cleanup

2018-12-26 Thread Temple Zhou (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Temple Zhou updated KYLIN-3430:
---
Attachment: (was: KYLIN-3430.master.001.patch)

> Global Dictionary Cleanup
> -
>
> Key: KYLIN-3430
> URL: https://issues.apache.org/jira/browse/KYLIN-3430
> Project: Kylin
>  Issue Type: Improvement
>  Components: Tools, Build and Test
>Affects Versions: v2.1.0, v2.2.0, v2.3.0, v2.3.1, v2.4.0
>Reporter: Temple Zhou
>Assignee: Temple Zhou
>Priority: Major
> Attachments: KYLIN-3430.master.002.patch
>
>
> I had run "{{./bin/metastore.sh clean --delete true" to cleanup my Kylin 
> metadata, but, after that, the Global Dictionary still exists in my HDFS and 
> the size of directory "/kylin_metadata/resources/GlobalDict/dict" hasn't 
> shrunk.}}
>  
> {{BTW: I'm very sure that there are redundant Global Dictionaries.}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (KYLIN-3430) Global Dictionary Cleanup

2018-12-26 Thread Temple Zhou (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Temple Zhou updated KYLIN-3430:
---
Attachment: KYLIN-3430.master.002.patch

> Global Dictionary Cleanup
> -
>
> Key: KYLIN-3430
> URL: https://issues.apache.org/jira/browse/KYLIN-3430
> Project: Kylin
>  Issue Type: Improvement
>  Components: Tools, Build and Test
>Affects Versions: v2.1.0, v2.2.0, v2.3.0, v2.3.1, v2.4.0
>Reporter: Temple Zhou
>Assignee: Temple Zhou
>Priority: Major
> Attachments: KYLIN-3430.master.002.patch
>
>
> I had run "{{./bin/metastore.sh clean --delete true" to cleanup my Kylin 
> metadata, but, after that, the Global Dictionary still exists in my HDFS and 
> the size of directory "/kylin_metadata/resources/GlobalDict/dict" hasn't 
> shrunk.}}
>  
> {{BTW: I'm very sure that there are redundant Global Dictionaries.}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] kangkaisen closed pull request #419: fix query no data when partion column as filter

2018-12-26 Thread GitBox
kangkaisen closed pull request #419: fix query no data when partion column as 
filter 
URL: https://github.com/apache/kylin/pull/419
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/storage-druid/src/main/java/org/apache/kylin/storage/druid/read/filter/PruneIntervalsProcessor.java
 
b/storage-druid/src/main/java/org/apache/kylin/storage/druid/read/filter/PruneIntervalsProcessor.java
index d19e9cde4e..0b30452902 100644
--- 
a/storage-druid/src/main/java/org/apache/kylin/storage/druid/read/filter/PruneIntervalsProcessor.java
+++ 
b/storage-druid/src/main/java/org/apache/kylin/storage/druid/read/filter/PruneIntervalsProcessor.java
@@ -110,7 +110,7 @@ public FilterCondition apply(FilterCondition input) {
 // prune segments via extracted time ranges
 RangeSet segmentRanges = TreeRangeSet.create();
 for (CubeSegment segment : cube.getSegments(SegmentStatusEnum.READY)) {
-Range segmentRange = 
Range.closedOpen(segment.getTSRange().start.v, segment.getTSRange().start.v);
+Range segmentRange = 
Range.closedOpen(segment.getTSRange().start.v, segment.getTSRange().end.v);
 boolean containQueryRange = 
!result.timeRanges.subRangeSet(segmentRange).isEmpty();
 if (segment.getInputRecords() > 0 && containQueryRange) {
 segmentRanges.add(segmentRange);


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] kangkaisen commented on issue #419: fix query no data when partion column as filter

2018-12-26 Thread GitBox
kangkaisen commented on issue #419: fix query no data when partion column as 
filter 
URL: https://github.com/apache/kylin/pull/419#issuecomment-450058972
 
 
   LGTM. Thanks you!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Created] (KYLIN-3743) kylin on druid query no data when partion column as filter

2018-12-26 Thread jinguowei (JIRA)
jinguowei created KYLIN-3743:


 Summary: kylin on druid query no data when partion column as filter
 Key: KYLIN-3743
 URL: https://issues.apache.org/jira/browse/KYLIN-3743
 Project: Kylin
  Issue Type: Improvement
  Components: Query Engine
Affects Versions: v2.6.0
Reporter: jinguowei
 Fix For: v2.6.0
 Attachments: 231545815044_.pic.jpg, 231545815044_.pic_thumb.jpg

kylin on druid,when query like [select * from tb where dt='MMdd'] will no 
data return
fix query no data when partion column as filter

fix on : https://github.com/apache/kylin/pull/419



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] codecov-io commented on issue #419: fix query no data when partion column as filter

2018-12-26 Thread GitBox
codecov-io commented on issue #419: fix query no data when partion column as 
filter 
URL: https://github.com/apache/kylin/pull/419#issuecomment-450057216
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/419?src=pr=h1) Report
   > :exclamation: No coverage uploaded for pull request base 
(`kylin-on-druid@d250468`). [Click here to learn what that 
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `0%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/kylin/pull/419/graphs/tree.svg?width=650=JawVgbgsVo=150=pr)](https://codecov.io/gh/apache/kylin/pull/419?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ## kylin-on-druid #419   +/-   ##
   =
 Coverage  ?   20.43%   
 Complexity? 4443   
   =
 Files ? 1151   
 Lines ?73009   
 Branches  ?10553   
   =
 Hits  ?14919   
 Misses?56689   
 Partials  ? 1401
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/kylin/pull/419?src=pr=tree) | Coverage Δ 
| Complexity Δ | |
   |---|---|---|---|
   | 
[...age/druid/read/filter/PruneIntervalsProcessor.java](https://codecov.io/gh/apache/kylin/pull/419/diff?src=pr=tree#diff-c3RvcmFnZS1kcnVpZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9kcnVpZC9yZWFkL2ZpbHRlci9QcnVuZUludGVydmFsc1Byb2Nlc3Nvci5qYXZh)
 | `0% <0%> (ø)` | `0 <0> (?)` | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/kylin/pull/419?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/kylin/pull/419?src=pr=footer). Last 
update 
[d250468...6320bdf](https://codecov.io/gh/apache/kylin/pull/419?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues

2018-12-26 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16729264#comment-16729264
 ] 

ASF GitHub Bot commented on KYLIN-3597:
---

shaofengshi commented on pull request #418: KYLIN-3597 fix sonar problems
URL: https://github.com/apache/kylin/pull/418
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Fix sonar reported static code issues
> -
>
> Key: KYLIN-3597
> URL: https://issues.apache.org/jira/browse/KYLIN-3597
> Project: Kylin
>  Issue Type: Improvement
>  Components: Others
>Reporter: Shaofeng SHI
>Priority: Major
> Fix For: v2.6.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues

2018-12-26 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16729265#comment-16729265
 ] 

ASF subversion and git services commented on KYLIN-3597:


Commit 49e835a3b317ee79ecd4ed1ebbb25409e0ce6718 in kylin's branch 
refs/heads/master from Lijun Cao
[ https://gitbox.apache.org/repos/asf?p=kylin.git;h=49e835a ]

KYLIN-3597 fix sonar problems


> Fix sonar reported static code issues
> -
>
> Key: KYLIN-3597
> URL: https://issues.apache.org/jira/browse/KYLIN-3597
> Project: Kylin
>  Issue Type: Improvement
>  Components: Others
>Reporter: Shaofeng SHI
>Priority: Major
> Fix For: v2.6.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] shaofengshi closed pull request #418: KYLIN-3597 fix sonar problems

2018-12-26 Thread GitBox
shaofengshi closed pull request #418: KYLIN-3597 fix sonar problems
URL: https://github.com/apache/kylin/pull/418
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/core-cube/src/main/java/org/apache/kylin/cube/cuboid/algorithm/CuboidStatsUtil.java
 
b/core-cube/src/main/java/org/apache/kylin/cube/cuboid/algorithm/CuboidStatsUtil.java
index 90eafdd275..ec2f4965aa 100644
--- 
a/core-cube/src/main/java/org/apache/kylin/cube/cuboid/algorithm/CuboidStatsUtil.java
+++ 
b/core-cube/src/main/java/org/apache/kylin/cube/cuboid/algorithm/CuboidStatsUtil.java
@@ -34,6 +34,10 @@
 
 public class CuboidStatsUtil {
 
+private CuboidStatsUtil() {
+throw new IllegalStateException("Class CuboidStatsUtil is an utility 
class !");
+}
+
 /**
  * According to the cuboid hit frequencies and query uncertainty ratio
  * calculate each cuboid hit probability
@@ -57,8 +61,11 @@
 for (Long cuboid : selectionCuboidSet) {
 //Calculate hit probability for each cuboid
 if (hitFrequencyMap.get(cuboid) != null) {
-cuboidHitProbabilityMap.put(cuboid, unitUncertainProb
-+ (1 - queryUncertaintyRatio) * 
hitFrequencyMap.get(cuboid) / totalHitFrequency);
+if (totalHitFrequency != 0)
+cuboidHitProbabilityMap.put(cuboid, unitUncertainProb
++ (1 - queryUncertaintyRatio) * 
hitFrequencyMap.get(cuboid) / totalHitFrequency);
+else
+throw new ArithmeticException("/ by zero");
 } else {
 cuboidHitProbabilityMap.put(cuboid, unitUncertainProb);
 }
@@ -118,8 +125,11 @@
 nEffective++;
 }
 }
-
-srcCuboidsStats.put(cuboid, totalEstRowCount / nEffective);
+
+if (nEffective != 0)
+srcCuboidsStats.put(cuboid, totalEstRowCount / nEffective);
+else
+throw new ArithmeticException("/ by zero");
 }
 srcCuboidsStats.remove(0L);
 adjustCuboidStats(srcCuboidsStats, statistics);


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Updated] (KYLIN-3743) kylin on druid query no data when partion column as filter

2018-12-26 Thread jinguowei (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

jinguowei updated KYLIN-3743:
-
Attachment: 123123.pic.jpg

> kylin on druid query no data when partion column as filter
> --
>
> Key: KYLIN-3743
> URL: https://issues.apache.org/jira/browse/KYLIN-3743
> Project: Kylin
>  Issue Type: Improvement
>  Components: Query Engine
>Affects Versions: v2.6.0
>Reporter: jinguowei
>Priority: Critical
> Fix For: v2.6.0
>
> Attachments: 123123.pic.jpg, 231545815044_.pic_thumb.jpg
>
>
> kylin on druid,when query like [select * from tb where dt='MMdd'] will no 
> data return
> fix query no data when partion column as filter
> fix on : https://github.com/apache/kylin/pull/419



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (KYLIN-3743) kylin on druid query no data when partion column as filter

2018-12-26 Thread jinguowei (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

jinguowei updated KYLIN-3743:
-
Attachment: (was: 231545815044_.pic.jpg)

> kylin on druid query no data when partion column as filter
> --
>
> Key: KYLIN-3743
> URL: https://issues.apache.org/jira/browse/KYLIN-3743
> Project: Kylin
>  Issue Type: Improvement
>  Components: Query Engine
>Affects Versions: v2.6.0
>Reporter: jinguowei
>Priority: Critical
> Fix For: v2.6.0
>
> Attachments: 231545815044_.pic_thumb.jpg
>
>
> kylin on druid,when query like [select * from tb where dt='MMdd'] will no 
> data return
> fix query no data when partion column as filter
> fix on : https://github.com/apache/kylin/pull/419



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (KYLIN-2615) Need better documents that explains design choices

2018-12-26 Thread Zhong Yanghong (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-2615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zhong Yanghong updated KYLIN-2615:
--
Fix Version/s: (was: v2.6.0)
   Future

> Need better documents that explains design choices
> --
>
> Key: KYLIN-2615
> URL: https://issues.apache.org/jira/browse/KYLIN-2615
> Project: Kylin
>  Issue Type: Task
>  Components: Documentation
>Reporter: nirav patel
>Assignee: Shaofeng SHI
>Priority: Major
>
> I see there are documents that explains how Kylin ingest hive tables and 
> build cubes/cuboids using MR and/or spark but there is hardly anything about 
> how it defines Metadata for cubes/segments, what are Segments, how it builds 
> indexes (Dictionaries, Inverted index if any) and how that helps querying 
> against cubes stored on hbase.
> Other thing is how Kylin manages read-write isolation (read while write). Is 
> it snapshot based or something that user needs to take care of?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] javalife0312 commented on issue #419: fix query no data when partion column as filter

2018-12-26 Thread GitBox
javalife0312 commented on issue #419: fix query no data when partion column as 
filter 
URL: https://github.com/apache/kylin/pull/419#issuecomment-450054801
 
 
   kylin on druid,when query like [select * from tb where dt='MMdd'] will 
no data return
   fix query no data when partion column as filter


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Resolved] (KYLIN-3628) The wrong result when a query with one lookup table

2018-12-26 Thread Zhong Yanghong (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zhong Yanghong resolved KYLIN-3628.
---
Resolution: Resolved

> The wrong result when a query with one lookup table
> ---
>
> Key: KYLIN-3628
> URL: https://issues.apache.org/jira/browse/KYLIN-3628
> Project: Kylin
>  Issue Type: Improvement
>Reporter: Na Zhai
>Assignee: Na Zhai
>Priority: Major
> Fix For: v2.6.0
>
>
> Two cubes use the same lookup table, and then the lookup table data in Hive 
> changes. One of Kylin's cubes builds the new data, and the other doesn't. 
> When Kylin queries the lookup table, there is no mechanism to choose which 
> cube being used. So it maybe gets the error result. I have an idea, choose 
> the latest cube to answer the query.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3628) The wrong result when a query with one lookup table

2018-12-26 Thread Zhong Yanghong (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16729259#comment-16729259
 ] 

Zhong Yanghong commented on KYLIN-3628:
---

[~Na Zhai], thanks for your patch. PR has been merged and I'll mark this as 
Resolved.

> The wrong result when a query with one lookup table
> ---
>
> Key: KYLIN-3628
> URL: https://issues.apache.org/jira/browse/KYLIN-3628
> Project: Kylin
>  Issue Type: Improvement
>Reporter: Na Zhai
>Assignee: Na Zhai
>Priority: Major
> Fix For: v2.6.0
>
>
> Two cubes use the same lookup table, and then the lookup table data in Hive 
> changes. One of Kylin's cubes builds the new data, and the other doesn't. 
> When Kylin queries the lookup table, there is no mechanism to choose which 
> cube being used. So it maybe gets the error result. I have an idea, choose 
> the latest cube to answer the query.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] asfgit commented on issue #419: fix query no data when partion column as filter

2018-12-26 Thread GitBox
asfgit commented on issue #419: fix query no data when partion column as filter 
URL: https://github.com/apache/kylin/pull/419#issuecomment-450054589
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] javalife0312 opened a new pull request #419: fix query no data when partion column as filter

2018-12-26 Thread GitBox
javalife0312 opened a new pull request #419: fix query no data when partion 
column as filter 
URL: https://github.com/apache/kylin/pull/419
 
 
   kylin on druid,when query like [select * from tb where dt='MMdd'] will 
no data return
   fix query no data when partion column as filter 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Updated] (KYLIN-2615) Need better documents that explains design choices

2018-12-26 Thread Zhong Yanghong (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-2615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zhong Yanghong updated KYLIN-2615:
--
Fix Version/s: (was: Future)

> Need better documents that explains design choices
> --
>
> Key: KYLIN-2615
> URL: https://issues.apache.org/jira/browse/KYLIN-2615
> Project: Kylin
>  Issue Type: Task
>  Components: Documentation
>Reporter: nirav patel
>Assignee: Shaofeng SHI
>Priority: Major
>
> I see there are documents that explains how Kylin ingest hive tables and 
> build cubes/cuboids using MR and/or spark but there is hardly anything about 
> how it defines Metadata for cubes/segments, what are Segments, how it builds 
> indexes (Dictionaries, Inverted index if any) and how that helps querying 
> against cubes stored on hbase.
> Other thing is how Kylin manages read-write isolation (read while write). Is 
> it snapshot based or something that user needs to take care of?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3430) Global Dictionary Cleanup

2018-12-26 Thread Shaofeng SHI (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16729256#comment-16729256
 ] 

Shaofeng SHI commented on KYLIN-3430:
-

Thanks Temple; [~kangkaisen] Kaisen, can you review this patch? Thank you!

> Global Dictionary Cleanup
> -
>
> Key: KYLIN-3430
> URL: https://issues.apache.org/jira/browse/KYLIN-3430
> Project: Kylin
>  Issue Type: Improvement
>  Components: Tools, Build and Test
>Affects Versions: v2.1.0, v2.2.0, v2.3.0, v2.3.1, v2.4.0
>Reporter: Temple Zhou
>Assignee: Temple Zhou
>Priority: Major
> Attachments: KYLIN-3430.master.001.patch
>
>
> I had run "{{./bin/metastore.sh clean --delete true" to cleanup my Kylin 
> metadata, but, after that, the Global Dictionary still exists in my HDFS and 
> the size of directory "/kylin_metadata/resources/GlobalDict/dict" hasn't 
> shrunk.}}
>  
> {{BTW: I'm very sure that there are redundant Global Dictionaries.}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] codecov-io commented on issue #418: KYLIN-3597 fix sonar problems

2018-12-26 Thread GitBox
codecov-io commented on issue #418: KYLIN-3597 fix sonar problems
URL: https://github.com/apache/kylin/pull/418#issuecomment-450053398
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/418?src=pr=h1) Report
   > :exclamation: No coverage uploaded for pull request base 
(`master@e3896af`). [Click here to learn what that 
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `33.33%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/kylin/pull/418/graphs/tree.svg?width=650=JawVgbgsVo=150=pr)](https://codecov.io/gh/apache/kylin/pull/418?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ## master #418   +/-   ##
   =
 Coverage  ?   24.38%   
 Complexity? 4934   
   =
 Files ? 1143   
 Lines ?69293   
 Branches  ? 9870   
   =
 Hits  ?16895   
 Misses?50697   
 Partials  ? 1701
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/kylin/pull/418?src=pr=tree) | Coverage Δ 
| Complexity Δ | |
   |---|---|---|---|
   | 
[...e/kylin/cube/cuboid/algorithm/CuboidStatsUtil.java](https://codecov.io/gh/apache/kylin/pull/418/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9hbGdvcml0aG0vQ3Vib2lkU3RhdHNVdGlsLmphdmE=)
 | `84.11% <33.33%> (ø)` | `45 <0> (?)` | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/kylin/pull/418?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/kylin/pull/418?src=pr=footer). Last 
update 
[e3896af...be55240](https://codecov.io/gh/apache/kylin/pull/418?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Resolved] (KYLIN-3291) 在构建好的cube上提交逻辑相同的sql查询结果不同

2018-12-26 Thread Zhong Yanghong (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zhong Yanghong resolved KYLIN-3291.
---
Resolution: Not A Problem

> 在构建好的cube上提交逻辑相同的sql查询结果不同
> --
>
> Key: KYLIN-3291
> URL: https://issues.apache.org/jira/browse/KYLIN-3291
> Project: Kylin
>  Issue Type: Bug
>  Components: Query Engine
>Affects Versions: v2.0.0
> Environment: kylin 2.0hbase 1.2.0
>Reporter: zhang
>Assignee: Zhong Yanghong
>Priority: Blocker
>  Labels: patch
> Fix For: v2.6.0
>
>
> select 
> a.agent
>   ,b.channel_name
>   ,a.ONLINE_SECONDS_TYPE
>   ,a.pt_dt
>   ,count(*) ct
> from (
> select
> agent , ONLINE_SECONDS_TYPE ,pt_dt
> from zhangyc02.DM_CHL_REGUSER_1D_WIDETABLE_D 
> where pt_dt>='2017-12-01' and pt_dt<='2017-12-03' and agent in 
> (6,3)
> ) a
> left join zhangyc02.dim_res_info b
> on a.agent = b.channel_id
> group by a.agent,b.channel_name,a.ONLINE_SECONDS_TYPE,a.pt_dt
> order by agent, pt_dt , ONLINE_SECONDS_TYPE   ;
> 这种查询结果是错误的
> select
> a.agent
> ,b.channel_name agent_name
> ,a.ONLINE_SECONDS_TYPE
> ,pt_dt
> ,count(*) ct
> from zhangyc02.DM_CHL_REGUSER_1D_WIDETABLE_D a
> left join zhangyc02.dim_res_info b
> on a.agent = b.channel_id
> where pt_dt>='2017-12-01' and pt_dt<='2017-12-03' and a.agent in (6,3)
> group by a.agent,b.channel_name,a.ONLINE_SECONDS_TYPE,a.pt_dt
> order by agent, pt_dt , ONLINE_SECONDS_TYPE   ;
> 这种查询结果是正确的
> 校验方式:我将两个sql在impala中分别查询,结果一致并且与kylin中的下面的sql结果一致。



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] caolijun1166 opened a new pull request #418: KYLIN-3597 fix sonar problems

2018-12-26 Thread GitBox
caolijun1166 opened a new pull request #418: KYLIN-3597 fix sonar problems
URL: https://github.com/apache/kylin/pull/418
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues

2018-12-26 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16729249#comment-16729249
 ] 

ASF GitHub Bot commented on KYLIN-3597:
---

caolijun1166 commented on pull request #418: KYLIN-3597 fix sonar problems
URL: https://github.com/apache/kylin/pull/418
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Fix sonar reported static code issues
> -
>
> Key: KYLIN-3597
> URL: https://issues.apache.org/jira/browse/KYLIN-3597
> Project: Kylin
>  Issue Type: Improvement
>  Components: Others
>Reporter: Shaofeng SHI
>Priority: Major
> Fix For: v2.6.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] asfgit commented on issue #418: KYLIN-3597 fix sonar problems

2018-12-26 Thread GitBox
asfgit commented on issue #418: KYLIN-3597 fix sonar problems
URL: https://github.com/apache/kylin/pull/418#issuecomment-450050877
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] hit-lacus edited a comment on issue #417: KYLIN-3742 Fix DataRequest for NPE and add some javadoc

2018-12-26 Thread GitBox
hit-lacus edited a comment on issue #417: KYLIN-3742 Fix DataRequest for NPE 
and add some javadoc
URL: https://github.com/apache/kylin/pull/417#issuecomment-449959603
 
 
   
   1. Jenkin test failed because of maven plugins
   https://user-images.githubusercontent.com/14030549/50445862-8086e780-094c-11e9-8939-88b5d3fddbaa.png;>
   
   2. Travis CI failed because too long logs
   `The job exceeded the maximum log length, and has been terminated`


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] hit-lacus commented on issue #417: KYLIN-3742 Fix DataRequest for NPE and add some javadoc

2018-12-26 Thread GitBox
hit-lacus commented on issue #417: KYLIN-3742 Fix DataRequest for NPE and add 
some javadoc
URL: https://github.com/apache/kylin/pull/417#issuecomment-449959603
 
 
   https://user-images.githubusercontent.com/14030549/50445862-8086e780-094c-11e9-8939-88b5d3fddbaa.png;>
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (KYLIN-3742) DataRequest fail to deserialized

2018-12-26 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16729011#comment-16729011
 ] 

ASF GitHub Bot commented on KYLIN-3742:
---

hit-lacus commented on pull request #417: KYLIN-3742 Fix DataRequest for NPE 
and add some javadoc
URL: https://github.com/apache/kylin/pull/417
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> DataRequest fail to deserialized 
> -
>
> Key: KYLIN-3742
> URL: https://issues.apache.org/jira/browse/KYLIN-3742
> Project: Kylin
>  Issue Type: Bug
>  Components: Streaming
>Reporter: XiaoXiang Yu
>Assignee: XiaoXiang Yu
>Priority: Critical
> Attachments: image-2018-12-26-19-25-31-341.png, 
> image-2018-12-26-19-26-44-418.png, image-2018-12-26-19-27-15-397.png, 
> image-2018-12-26-19-29-13-404.png, image-2018-12-26-19-38-10-451.png, 
> image-2018-12-26-19-39-19-039.png, image-2018-12-26-19-42-10-589.png
>
>
> DataRequest send to Streaming Receiver is cannot be deserialized successfully 
> because of 
> ParameterDesc's equals method throw a NPE for field null +_colRef._+
>  1. This Receiver Server 's error log.
> !image-2018-12-26-19-25-31-341.png!
>  
>  
> 2. This the request send by query server. It is a Normal JSON.
> !image-2018-12-26-19-42-10-589.png!  
> !image-2018-12-26-19-29-13-404.png!
>  
>  
> 3. Spring MVC will try to deserialized json string into DataRequest. And 
> filed mertics of DataRequest it is a Set.
>  
> !image-2018-12-26-19-38-10-451.png!
>  
> 4. HashSet use equal method to distinct entry. But equals method will throw 
> NPE.
>  
> !image-2018-12-26-19-39-19-039.png!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] asfgit commented on issue #417: KYLIN-3742 Fix DataRequest for NPE and add some javadoc

2018-12-26 Thread GitBox
asfgit commented on issue #417: KYLIN-3742 Fix DataRequest for NPE and add some 
javadoc
URL: https://github.com/apache/kylin/pull/417#issuecomment-449956881
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] hit-lacus opened a new pull request #417: KYLIN-3742 Fix DataRequest for NPE and add some javadoc

2018-12-26 Thread GitBox
hit-lacus opened a new pull request #417: KYLIN-3742 Fix DataRequest for NPE 
and add some javadoc
URL: https://github.com/apache/kylin/pull/417
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Updated] (KYLIN-3742) DataRequest fail to deserialized

2018-12-26 Thread XiaoXiang Yu (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

XiaoXiang Yu updated KYLIN-3742:

Description: 
DataRequest send to Streaming Receiver is cannot be deserialized successfully 
because of 

ParameterDesc's equals method throw a NPE for field null +_colRef._+

 1. This Receiver Server 's error log.

!image-2018-12-26-19-25-31-341.png!

 

 

2. Normal JSON

!image-2018-12-26-19-29-13-404.png!

 

 

3. Spring MVC will try to json string into DataRequest.mertics, it is a Set.

 

!image-2018-12-26-19-38-10-451.png!

 

4. HashSet use equal method to distinct entry. But equals method will throw NPE.

 

!image-2018-12-26-19-39-19-039.png!

  was:
DataRequest send to Streaming Receiver is cannot be deserialized successfully 
because of 

ParameterDesc's equals method throw a NPE for field null +_colRef._+

 

!image-2018-12-26-19-25-31-341.png!

 

 

2. Normal JSON

!image-2018-12-26-19-29-13-404.png!

 

 

3. Spring MVC will try to json string into DataRequest.mertics, it is a Set.

 

!image-2018-12-26-19-38-10-451.png!

 

4. HashSet use equal method to distinct entry. But equals method will throw NPE.

 

!image-2018-12-26-19-39-19-039.png!


> DataRequest fail to deserialized 
> -
>
> Key: KYLIN-3742
> URL: https://issues.apache.org/jira/browse/KYLIN-3742
> Project: Kylin
>  Issue Type: Bug
>  Components: Streaming
>Reporter: XiaoXiang Yu
>Assignee: XiaoXiang Yu
>Priority: Critical
> Attachments: image-2018-12-26-19-25-31-341.png, 
> image-2018-12-26-19-26-44-418.png, image-2018-12-26-19-27-15-397.png, 
> image-2018-12-26-19-29-13-404.png, image-2018-12-26-19-38-10-451.png, 
> image-2018-12-26-19-39-19-039.png
>
>
> DataRequest send to Streaming Receiver is cannot be deserialized successfully 
> because of 
> ParameterDesc's equals method throw a NPE for field null +_colRef._+
>  1. This Receiver Server 's error log.
> !image-2018-12-26-19-25-31-341.png!
>  
>  
> 2. Normal JSON
> !image-2018-12-26-19-29-13-404.png!
>  
>  
> 3. Spring MVC will try to json string into DataRequest.mertics, it is a Set.
>  
> !image-2018-12-26-19-38-10-451.png!
>  
> 4. HashSet use equal method to distinct entry. But equals method will throw 
> NPE.
>  
> !image-2018-12-26-19-39-19-039.png!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (KYLIN-3742) DataRequest fail to deserialized

2018-12-26 Thread XiaoXiang Yu (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

XiaoXiang Yu updated KYLIN-3742:

Description: 
DataRequest send to Streaming Receiver is cannot be deserialized successfully 
because of 

ParameterDesc's equals method throw a NPE for field null +_colRef._+

 1. This Receiver Server 's error log.

!image-2018-12-26-19-25-31-341.png!

 

 

2. This the request send by query server. It is a Normal JSON.

!image-2018-12-26-19-42-10-589.png!  

!image-2018-12-26-19-29-13-404.png!

 

 

3. Spring MVC will try to deserialized json string into DataRequest. And filed 
mertics of DataRequest it is a Set.

 

!image-2018-12-26-19-38-10-451.png!

 

4. HashSet use equal method to distinct entry. But equals method will throw NPE.

 

!image-2018-12-26-19-39-19-039.png!

  was:
DataRequest send to Streaming Receiver is cannot be deserialized successfully 
because of 

ParameterDesc's equals method throw a NPE for field null +_colRef._+

 1. This Receiver Server 's error log.

!image-2018-12-26-19-25-31-341.png!

 

 

2. Normal JSON

!image-2018-12-26-19-29-13-404.png!

 

 

3. Spring MVC will try to json string into DataRequest.mertics, it is a Set.

 

!image-2018-12-26-19-38-10-451.png!

 

4. HashSet use equal method to distinct entry. But equals method will throw NPE.

 

!image-2018-12-26-19-39-19-039.png!


> DataRequest fail to deserialized 
> -
>
> Key: KYLIN-3742
> URL: https://issues.apache.org/jira/browse/KYLIN-3742
> Project: Kylin
>  Issue Type: Bug
>  Components: Streaming
>Reporter: XiaoXiang Yu
>Assignee: XiaoXiang Yu
>Priority: Critical
> Attachments: image-2018-12-26-19-25-31-341.png, 
> image-2018-12-26-19-26-44-418.png, image-2018-12-26-19-27-15-397.png, 
> image-2018-12-26-19-29-13-404.png, image-2018-12-26-19-38-10-451.png, 
> image-2018-12-26-19-39-19-039.png, image-2018-12-26-19-42-10-589.png
>
>
> DataRequest send to Streaming Receiver is cannot be deserialized successfully 
> because of 
> ParameterDesc's equals method throw a NPE for field null +_colRef._+
>  1. This Receiver Server 's error log.
> !image-2018-12-26-19-25-31-341.png!
>  
>  
> 2. This the request send by query server. It is a Normal JSON.
> !image-2018-12-26-19-42-10-589.png!  
> !image-2018-12-26-19-29-13-404.png!
>  
>  
> 3. Spring MVC will try to deserialized json string into DataRequest. And 
> filed mertics of DataRequest it is a Set.
>  
> !image-2018-12-26-19-38-10-451.png!
>  
> 4. HashSet use equal method to distinct entry. But equals method will throw 
> NPE.
>  
> !image-2018-12-26-19-39-19-039.png!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (KYLIN-3742) DataRequest fail to deserialized

2018-12-26 Thread XiaoXiang Yu (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

XiaoXiang Yu updated KYLIN-3742:

Attachment: image-2018-12-26-19-42-10-589.png

> DataRequest fail to deserialized 
> -
>
> Key: KYLIN-3742
> URL: https://issues.apache.org/jira/browse/KYLIN-3742
> Project: Kylin
>  Issue Type: Bug
>  Components: Streaming
>Reporter: XiaoXiang Yu
>Assignee: XiaoXiang Yu
>Priority: Critical
> Attachments: image-2018-12-26-19-25-31-341.png, 
> image-2018-12-26-19-26-44-418.png, image-2018-12-26-19-27-15-397.png, 
> image-2018-12-26-19-29-13-404.png, image-2018-12-26-19-38-10-451.png, 
> image-2018-12-26-19-39-19-039.png, image-2018-12-26-19-42-10-589.png
>
>
> DataRequest send to Streaming Receiver is cannot be deserialized successfully 
> because of 
> ParameterDesc's equals method throw a NPE for field null +_colRef._+
>  1. This Receiver Server 's error log.
> !image-2018-12-26-19-25-31-341.png!
>  
>  
> 2. Normal JSON
> !image-2018-12-26-19-29-13-404.png!
>  
>  
> 3. Spring MVC will try to json string into DataRequest.mertics, it is a Set.
>  
> !image-2018-12-26-19-38-10-451.png!
>  
> 4. HashSet use equal method to distinct entry. But equals method will throw 
> NPE.
>  
> !image-2018-12-26-19-39-19-039.png!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (KYLIN-3742) DataRequest fail to deserialized

2018-12-26 Thread XiaoXiang Yu (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

XiaoXiang Yu updated KYLIN-3742:

Description: 
DataRequest send to Streaming Receiver is cannot be deserialized successfully 
because of 

ParameterDesc's equals method throw a NPE for field null +_colRef._+

 

!image-2018-12-26-19-25-31-341.png!

 

 

2. Normal JSON

!image-2018-12-26-19-29-13-404.png!

 

 

3. Spring MVC will try to json string into DataRequest.mertics, it is a Set.

 

!image-2018-12-26-19-38-10-451.png!

 

4. HashSet use equal method to distinct entry. But equals method will throw NPE.

 

!image-2018-12-26-19-39-19-039.png!

  was:
DataRequest send to Streaming Receiver is cannot be deserialized successfully 
because of 

ParameterDesc's equals method throw a NPE for field null +_colRef._+

 

!image-2018-12-26-19-25-31-341.png!


> DataRequest fail to deserialized 
> -
>
> Key: KYLIN-3742
> URL: https://issues.apache.org/jira/browse/KYLIN-3742
> Project: Kylin
>  Issue Type: Bug
>  Components: Streaming
>Reporter: XiaoXiang Yu
>Assignee: XiaoXiang Yu
>Priority: Critical
> Attachments: image-2018-12-26-19-25-31-341.png, 
> image-2018-12-26-19-26-44-418.png, image-2018-12-26-19-27-15-397.png, 
> image-2018-12-26-19-29-13-404.png, image-2018-12-26-19-38-10-451.png, 
> image-2018-12-26-19-39-19-039.png
>
>
> DataRequest send to Streaming Receiver is cannot be deserialized successfully 
> because of 
> ParameterDesc's equals method throw a NPE for field null +_colRef._+
>  
> !image-2018-12-26-19-25-31-341.png!
>  
>  
> 2. Normal JSON
> !image-2018-12-26-19-29-13-404.png!
>  
>  
> 3. Spring MVC will try to json string into DataRequest.mertics, it is a Set.
>  
> !image-2018-12-26-19-38-10-451.png!
>  
> 4. HashSet use equal method to distinct entry. But equals method will throw 
> NPE.
>  
> !image-2018-12-26-19-39-19-039.png!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (KYLIN-3742) DataRequest fail to deserialized

2018-12-26 Thread XiaoXiang Yu (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

XiaoXiang Yu updated KYLIN-3742:

Attachment: image-2018-12-26-19-39-19-039.png

> DataRequest fail to deserialized 
> -
>
> Key: KYLIN-3742
> URL: https://issues.apache.org/jira/browse/KYLIN-3742
> Project: Kylin
>  Issue Type: Bug
>  Components: Streaming
>Reporter: XiaoXiang Yu
>Assignee: XiaoXiang Yu
>Priority: Critical
> Attachments: image-2018-12-26-19-25-31-341.png, 
> image-2018-12-26-19-26-44-418.png, image-2018-12-26-19-27-15-397.png, 
> image-2018-12-26-19-29-13-404.png, image-2018-12-26-19-38-10-451.png, 
> image-2018-12-26-19-39-19-039.png
>
>
> DataRequest send to Streaming Receiver is cannot be deserialized successfully 
> because of 
> ParameterDesc's equals method throw a NPE for field null +_colRef._+
>  
> !image-2018-12-26-19-25-31-341.png!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (KYLIN-3742) DataRequest fail to deserialized

2018-12-26 Thread XiaoXiang Yu (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

XiaoXiang Yu updated KYLIN-3742:

Attachment: image-2018-12-26-19-38-10-451.png

> DataRequest fail to deserialized 
> -
>
> Key: KYLIN-3742
> URL: https://issues.apache.org/jira/browse/KYLIN-3742
> Project: Kylin
>  Issue Type: Bug
>  Components: Streaming
>Reporter: XiaoXiang Yu
>Assignee: XiaoXiang Yu
>Priority: Critical
> Attachments: image-2018-12-26-19-25-31-341.png, 
> image-2018-12-26-19-26-44-418.png, image-2018-12-26-19-27-15-397.png, 
> image-2018-12-26-19-29-13-404.png, image-2018-12-26-19-38-10-451.png
>
>
> DataRequest send to Streaming Receiver is cannot be deserialized successfully 
> because of 
> ParameterDesc's equals method throw a NPE for field null +_colRef._+
>  
> !image-2018-12-26-19-25-31-341.png!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (KYLIN-3742) DataRequest fail to deserialized

2018-12-26 Thread XiaoXiang Yu (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

XiaoXiang Yu updated KYLIN-3742:

Description: 
DataRequest send to Streaming Receiver is cannot be deserialized successfully 
because of 

ParameterDesc's equals method throw a NPE for field null +_colRef._+

 

!image-2018-12-26-19-25-31-341.png!

  was:
DataRequest send to Streaming Receiver is cannot be deserialized successfully 
because of 

ParameterDesc's equals method throw a NPE for field null +_colRef._+

 

!image-2018-12-26-19-12-11-788.png!


> DataRequest fail to deserialized 
> -
>
> Key: KYLIN-3742
> URL: https://issues.apache.org/jira/browse/KYLIN-3742
> Project: Kylin
>  Issue Type: Bug
>  Components: Streaming
>Reporter: XiaoXiang Yu
>Assignee: XiaoXiang Yu
>Priority: Critical
> Attachments: image-2018-12-26-19-25-31-341.png
>
>
> DataRequest send to Streaming Receiver is cannot be deserialized successfully 
> because of 
> ParameterDesc's equals method throw a NPE for field null +_colRef._+
>  
> !image-2018-12-26-19-25-31-341.png!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (KYLIN-3742) DataRequest fail to deserialized

2018-12-26 Thread XiaoXiang Yu (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

XiaoXiang Yu updated KYLIN-3742:

Attachment: image-2018-12-26-19-29-13-404.png

> DataRequest fail to deserialized 
> -
>
> Key: KYLIN-3742
> URL: https://issues.apache.org/jira/browse/KYLIN-3742
> Project: Kylin
>  Issue Type: Bug
>  Components: Streaming
>Reporter: XiaoXiang Yu
>Assignee: XiaoXiang Yu
>Priority: Critical
> Attachments: image-2018-12-26-19-25-31-341.png, 
> image-2018-12-26-19-26-44-418.png, image-2018-12-26-19-27-15-397.png, 
> image-2018-12-26-19-29-13-404.png
>
>
> DataRequest send to Streaming Receiver is cannot be deserialized successfully 
> because of 
> ParameterDesc's equals method throw a NPE for field null +_colRef._+
>  
> !image-2018-12-26-19-25-31-341.png!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (KYLIN-3742) DataRequest fail to deserialized

2018-12-26 Thread XiaoXiang Yu (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

XiaoXiang Yu updated KYLIN-3742:

Attachment: image-2018-12-26-19-27-15-397.png

> DataRequest fail to deserialized 
> -
>
> Key: KYLIN-3742
> URL: https://issues.apache.org/jira/browse/KYLIN-3742
> Project: Kylin
>  Issue Type: Bug
>  Components: Streaming
>Reporter: XiaoXiang Yu
>Assignee: XiaoXiang Yu
>Priority: Critical
> Attachments: image-2018-12-26-19-25-31-341.png, 
> image-2018-12-26-19-26-44-418.png, image-2018-12-26-19-27-15-397.png
>
>
> DataRequest send to Streaming Receiver is cannot be deserialized successfully 
> because of 
> ParameterDesc's equals method throw a NPE for field null +_colRef._+
>  
> !image-2018-12-26-19-25-31-341.png!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (KYLIN-3742) DataRequest fail to deserialized

2018-12-26 Thread XiaoXiang Yu (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

XiaoXiang Yu updated KYLIN-3742:

Attachment: image-2018-12-26-19-26-44-418.png

> DataRequest fail to deserialized 
> -
>
> Key: KYLIN-3742
> URL: https://issues.apache.org/jira/browse/KYLIN-3742
> Project: Kylin
>  Issue Type: Bug
>  Components: Streaming
>Reporter: XiaoXiang Yu
>Assignee: XiaoXiang Yu
>Priority: Critical
> Attachments: image-2018-12-26-19-25-31-341.png, 
> image-2018-12-26-19-26-44-418.png
>
>
> DataRequest send to Streaming Receiver is cannot be deserialized successfully 
> because of 
> ParameterDesc's equals method throw a NPE for field null +_colRef._+
>  
> !image-2018-12-26-19-25-31-341.png!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (KYLIN-3742) DataRequest fail to deserialized

2018-12-26 Thread XiaoXiang Yu (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

XiaoXiang Yu updated KYLIN-3742:

Attachment: image-2018-12-26-19-25-31-341.png

> DataRequest fail to deserialized 
> -
>
> Key: KYLIN-3742
> URL: https://issues.apache.org/jira/browse/KYLIN-3742
> Project: Kylin
>  Issue Type: Bug
>  Components: Streaming
>Reporter: XiaoXiang Yu
>Assignee: XiaoXiang Yu
>Priority: Critical
> Attachments: image-2018-12-26-19-25-31-341.png
>
>
> DataRequest send to Streaming Receiver is cannot be deserialized successfully 
> because of 
> ParameterDesc's equals method throw a NPE for field null +_colRef._+
>  
> !image-2018-12-26-19-12-11-788.png!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (KYLIN-3742) DataRequest fail to deserialized

2018-12-26 Thread XiaoXiang Yu (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

XiaoXiang Yu updated KYLIN-3742:

Attachment: (was: image-2018-12-26-19-12-11-788.png)

> DataRequest fail to deserialized 
> -
>
> Key: KYLIN-3742
> URL: https://issues.apache.org/jira/browse/KYLIN-3742
> Project: Kylin
>  Issue Type: Bug
>  Components: Streaming
>Reporter: XiaoXiang Yu
>Assignee: XiaoXiang Yu
>Priority: Critical
> Attachments: image-2018-12-26-19-25-31-341.png
>
>
> DataRequest send to Streaming Receiver is cannot be deserialized successfully 
> because of 
> ParameterDesc's equals method throw a NPE for field null +_colRef._+
>  
> !image-2018-12-26-19-12-11-788.png!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (KYLIN-3742) DataRequest fail to deserialized

2018-12-26 Thread XiaoXiang Yu (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

XiaoXiang Yu updated KYLIN-3742:

Description: 
DataRequest send to Streaming Receiver is cannot be deserialized successfully 
because of 

ParameterDesc's equals method throw a NPE for field null +_colRef._+

 

!image-2018-12-26-19-12-11-788.png!

  was:
DataRequest send to Streaming Receiver is cannot be deserialized successfully 
because of 

ParameterDesc's equals method throw a NPE for field null +_colRef._+


> DataRequest fail to deserialized 
> -
>
> Key: KYLIN-3742
> URL: https://issues.apache.org/jira/browse/KYLIN-3742
> Project: Kylin
>  Issue Type: Bug
>  Components: Streaming
>Reporter: XiaoXiang Yu
>Assignee: XiaoXiang Yu
>Priority: Critical
> Attachments: image-2018-12-26-19-12-11-788.png
>
>
> DataRequest send to Streaming Receiver is cannot be deserialized successfully 
> because of 
> ParameterDesc's equals method throw a NPE for field null +_colRef._+
>  
> !image-2018-12-26-19-12-11-788.png!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (KYLIN-3742) DataRequest fail to deserialized

2018-12-26 Thread XiaoXiang Yu (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

XiaoXiang Yu updated KYLIN-3742:

Attachment: image-2018-12-26-19-12-11-788.png

> DataRequest fail to deserialized 
> -
>
> Key: KYLIN-3742
> URL: https://issues.apache.org/jira/browse/KYLIN-3742
> Project: Kylin
>  Issue Type: Bug
>  Components: Streaming
>Reporter: XiaoXiang Yu
>Assignee: XiaoXiang Yu
>Priority: Critical
> Attachments: image-2018-12-26-19-12-11-788.png
>
>
> DataRequest send to Streaming Receiver is cannot be deserialized successfully 
> because of 
> ParameterDesc's equals method throw a NPE for field null +_colRef._+



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (KYLIN-3742) DataRequest fail to deserialized

2018-12-26 Thread XiaoXiang Yu (JIRA)
XiaoXiang Yu created KYLIN-3742:
---

 Summary: DataRequest fail to deserialized 
 Key: KYLIN-3742
 URL: https://issues.apache.org/jira/browse/KYLIN-3742
 Project: Kylin
  Issue Type: Bug
  Components: Streaming
Reporter: XiaoXiang Yu
Assignee: XiaoXiang Yu


DataRequest send to Streaming Receiver is cannot be deserialized successfully 
because of 

ParameterDesc's equals method throw a NPE for field null +_colRef._+



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (KYLIN-3430) Global Dictionary Cleanup

2018-12-26 Thread Temple Zhou (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Temple Zhou updated KYLIN-3430:
---
Attachment: KYLIN-3430.master.001.patch

> Global Dictionary Cleanup
> -
>
> Key: KYLIN-3430
> URL: https://issues.apache.org/jira/browse/KYLIN-3430
> Project: Kylin
>  Issue Type: Improvement
>  Components: Tools, Build and Test
>Affects Versions: v2.1.0, v2.2.0, v2.3.0, v2.3.1, v2.4.0
>Reporter: Temple Zhou
>Assignee: Temple Zhou
>Priority: Major
> Attachments: KYLIN-3430.master.001.patch
>
>
> I had run "{{./bin/metastore.sh clean --delete true" to cleanup my Kylin 
> metadata, but, after that, the Global Dictionary still exists in my HDFS and 
> the size of directory "/kylin_metadata/resources/GlobalDict/dict" hasn't 
> shrunk.}}
>  
> {{BTW: I'm very sure that there are redundant Global Dictionaries.}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3509) Allocate more memory for "Merge dictionary on yarn" step

2018-12-26 Thread wangxianbin (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728937#comment-16728937
 ] 

wangxianbin commented on KYLIN-3509:


is this only related to spark engine? 

> Allocate more memory for "Merge dictionary on yarn" step
> 
>
> Key: KYLIN-3509
> URL: https://issues.apache.org/jira/browse/KYLIN-3509
> Project: Kylin
>  Issue Type: Improvement
>Reporter: Chao Long
>Assignee: Chao Long
>Priority: Major
> Fix For: v2.5.0
>
>
> "Merge dictionary on yarn" step has been finished in KYLIN-3471,  but this 
> step will consume a great deal of memory, we should allocate more memory for 
> it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)