[jira] [Commented] (KYLIN-3826) MergeCuboidJob only uploads necessary segment's dictionary

2019-02-23 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16776109#comment-16776109
 ] 

ASF GitHub Bot commented on KYLIN-3826:
---

shaofengshi commented on pull request #479: KYLIN-3826 MergeCuboidJob only 
uploads necessary segment's dictionary
URL: https://github.com/apache/kylin/pull/479
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> MergeCuboidJob only uploads necessary segment's dictionary
> --
>
> Key: KYLIN-3826
> URL: https://issues.apache.org/jira/browse/KYLIN-3826
> Project: Kylin
>  Issue Type: Improvement
>  Components: Job Engine
>Reporter: Shaofeng SHI
>Priority: Major
> Fix For: v2.6.1
>
>
> On yesterday's Kylin meetup, Zhang Wei mentioned that the "MergeCuboidJob" 
> will upload all segment's metadata, which will take extra long time when the 
> segment number is large. While this is unnecessary.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] shaofengshi merged pull request #479: KYLIN-3826 MergeCuboidJob only uploads necessary segment's dictionary

2019-02-23 Thread GitBox
shaofengshi merged pull request #479: KYLIN-3826 MergeCuboidJob only uploads 
necessary segment's dictionary
URL: https://github.com/apache/kylin/pull/479
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (KYLIN-3826) MergeCuboidJob only uploads necessary segment's dictionary

2019-02-23 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16776110#comment-16776110
 ] 

ASF subversion and git services commented on KYLIN-3826:


Commit 500f1025326a16d71deb1c96075336d03316306e in kylin's branch 
refs/heads/master from Shao Feng Shi
[ https://gitbox.apache.org/repos/asf?p=kylin.git;h=500f102 ]

KYLIN-3826 MergeCuboidJob only uploads necessary segment's dictionary


> MergeCuboidJob only uploads necessary segment's dictionary
> --
>
> Key: KYLIN-3826
> URL: https://issues.apache.org/jira/browse/KYLIN-3826
> Project: Kylin
>  Issue Type: Improvement
>  Components: Job Engine
>Reporter: Shaofeng SHI
>Priority: Major
> Fix For: v2.6.1
>
>
> On yesterday's Kylin meetup, Zhang Wei mentioned that the "MergeCuboidJob" 
> will upload all segment's metadata, which will take extra long time when the 
> segment number is large. While this is unnecessary.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (KYLIN-3687) Top_N measure requires related SUM() measure to be defined as part of the cube to work, but Web UI allows creation of the cube that has Top_N measure only, resulting in

2019-02-23 Thread Shaofeng SHI (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shaofeng SHI resolved KYLIN-3687.
-
Resolution: Duplicate

> Top_N measure requires related SUM() measure to be defined as part of the 
> cube to work, but Web UI allows creation of the cube that has Top_N measure 
> only, resulting in NPE at query time
> --
>
> Key: KYLIN-3687
> URL: https://issues.apache.org/jira/browse/KYLIN-3687
> Project: Kylin
>  Issue Type: Improvement
>  Components: Measure - TopN, Metadata, Web 
>Affects Versions: v2.5.0
> Environment: HDP 2.5.6, Kylin 2.5
>Reporter: Vsevolod Ostapenko
>Priority: Major
>
> Web UI allows defining a cube with Top_N measure without defining a related 
> SUM() measure. E.g. a variation of the kylin_sales_cube can be successfully 
> defined via UI with just TOP_SELLER without actually defining GVM_SUM measure.
> Such cube builds just fine, but at the query time an NPE is thrown similar to 
> the following:
> {quote}Caused by: java.lang.NullPointerException
>  at 
> org.apache.kylin.query.relnode.OLAPAggregateRel.rewriteAggregateCall(OLAPAggregateRel.java:561)
>  at 
> org.apache.kylin.query.relnode.OLAPAggregateRel.implementRewrite(OLAPAggregateRel.java:419)
>  at 
> org.apache.kylin.query.relnode.OLAPRel$RewriteImplementor.visitChild(OLAPRel.java:174)
>  at 
> org.apache.kylin.query.relnode.OLAPSortRel.implementRewrite(OLAPSortRel.java:86)
>  at 
> org.apache.kylin.query.relnode.OLAPRel$RewriteImplementor.visitChild(OLAPRel.java:174)
>  at 
> org.apache.kylin.query.relnode.OLAPLimitRel.implementRewrite(OLAPLimitRel.java:109)
>  at 
> org.apache.kylin.query.relnode.OLAPRel$RewriteImplementor.visitChild(OLAPRel.java:174)
>  at 
> org.apache.kylin.query.relnode.OLAPToEnumerableConverter.implement(OLAPToEnumerableConverter.java:100)
>  at 
> org.apache.calcite.adapter.enumerable.EnumerableRelImplementor.implementRoot(EnumerableRelImplementor.java:108)
>  at 
> org.apache.calcite.adapter.enumerable.EnumerableInterpretable.toBindable(EnumerableInterpretable.java:92)
>  at 
> org.apache.calcite.prepare.CalcitePrepareImpl$CalcitePreparingStmt.implement(CalcitePrepareImpl.java:1281)
>  at org.apache.calcite.prepare.Prepare.prepareSql(Prepare.java:331)
>  at org.apache.calcite.prepare.Prepare.prepareSql(Prepare.java:228)
> {quote}
> There need to be some checks in the UI and in the Top_N query processing code 
> to ensure that all the required measures are defined (as Top_N is actually 
> dependent on another measure to function properly) and inform the user that 
> Top_N definition is incomplete and cube definition is invalid.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (KYLIN-3687) Top_N measure requires related SUM() measure to be defined as part of the cube to work, but Web UI allows creation of the cube that has Top_N measure only, resulting in NP

2019-02-23 Thread Shaofeng SHI (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shaofeng SHI closed KYLIN-3687.
---

Let's use KYLIN-3322 to discuss.

> Top_N measure requires related SUM() measure to be defined as part of the 
> cube to work, but Web UI allows creation of the cube that has Top_N measure 
> only, resulting in NPE at query time
> --
>
> Key: KYLIN-3687
> URL: https://issues.apache.org/jira/browse/KYLIN-3687
> Project: Kylin
>  Issue Type: Improvement
>  Components: Measure - TopN, Metadata, Web 
>Affects Versions: v2.5.0
> Environment: HDP 2.5.6, Kylin 2.5
>Reporter: Vsevolod Ostapenko
>Priority: Major
>
> Web UI allows defining a cube with Top_N measure without defining a related 
> SUM() measure. E.g. a variation of the kylin_sales_cube can be successfully 
> defined via UI with just TOP_SELLER without actually defining GVM_SUM measure.
> Such cube builds just fine, but at the query time an NPE is thrown similar to 
> the following:
> {quote}Caused by: java.lang.NullPointerException
>  at 
> org.apache.kylin.query.relnode.OLAPAggregateRel.rewriteAggregateCall(OLAPAggregateRel.java:561)
>  at 
> org.apache.kylin.query.relnode.OLAPAggregateRel.implementRewrite(OLAPAggregateRel.java:419)
>  at 
> org.apache.kylin.query.relnode.OLAPRel$RewriteImplementor.visitChild(OLAPRel.java:174)
>  at 
> org.apache.kylin.query.relnode.OLAPSortRel.implementRewrite(OLAPSortRel.java:86)
>  at 
> org.apache.kylin.query.relnode.OLAPRel$RewriteImplementor.visitChild(OLAPRel.java:174)
>  at 
> org.apache.kylin.query.relnode.OLAPLimitRel.implementRewrite(OLAPLimitRel.java:109)
>  at 
> org.apache.kylin.query.relnode.OLAPRel$RewriteImplementor.visitChild(OLAPRel.java:174)
>  at 
> org.apache.kylin.query.relnode.OLAPToEnumerableConverter.implement(OLAPToEnumerableConverter.java:100)
>  at 
> org.apache.calcite.adapter.enumerable.EnumerableRelImplementor.implementRoot(EnumerableRelImplementor.java:108)
>  at 
> org.apache.calcite.adapter.enumerable.EnumerableInterpretable.toBindable(EnumerableInterpretable.java:92)
>  at 
> org.apache.calcite.prepare.CalcitePrepareImpl$CalcitePreparingStmt.implement(CalcitePrepareImpl.java:1281)
>  at org.apache.calcite.prepare.Prepare.prepareSql(Prepare.java:331)
>  at org.apache.calcite.prepare.Prepare.prepareSql(Prepare.java:228)
> {quote}
> There need to be some checks in the UI and in the Top_N query processing code 
> to ensure that all the required measures are defined (as Top_N is actually 
> dependent on another measure to function properly) and inform the user that 
> Top_N definition is incomplete and cube definition is invalid.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3322) TopN requires a SUM to work

2019-02-23 Thread Shaofeng SHI (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16776087#comment-16776087
 ] 

Shaofeng SHI commented on KYLIN-3322:
-

Hi Kang-sen, thanks for your feedback!

 

"In side the TOPN-cube, the correct answer would be go after the SUM(X) metric 
directly. But my experiment seems to suggest the kylin took the path of going 
after TOPN(SUM(X)), then sum over the dimension B, which in general has a hugh 
cardinality, and therefore, takes a long tim eto finish." If this is true, then 
it is a bug, we should fix it.

 

The reason of TopN need a separate SUM measure is, user's query may not have 
the high-cardinality column (which is the B in your sample), in this case, if 
we use TopN to answer, the result will be wrong (because only has limited B 
values), and its performance is bad. While if we add a SUM, there is no such 
issue: when user's query has B, we use TopN to anwer; if not, using the 
accurate SUM measure to answer. Besides, a SUM measure's size is much less than 
a TopN, it almost won't add overhead.

 

 

Let's work together to make Kylin better !

> TopN requires a SUM to work
> ---
>
> Key: KYLIN-3322
> URL: https://issues.apache.org/jira/browse/KYLIN-3322
> Project: Kylin
>  Issue Type: Bug
>  Components: Measure - TopN
>Reporter: liyang
>Assignee: Na Zhai
>Priority: Major
>
> Currently if user creates a measure of TopN seller by sum of price, it is 
> required that user also creates a measure of SUM(price). Otherwise, NPE will 
> be thrown at query time.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] asfgit commented on issue #480: Update documents

2019-02-23 Thread GitBox
asfgit commented on issue #480: Update documents
URL: https://github.com/apache/kylin/pull/480#issuecomment-466725279
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] GinaZhai opened a new pull request #480: Update documents

2019-02-23 Thread GitBox
GinaZhai opened a new pull request #480: Update documents
URL: https://github.com/apache/kylin/pull/480
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (KYLIN-3811) Support the standalone HBase cluster using HDFS HA

2019-02-23 Thread Shaofeng SHI (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16776086#comment-16776086
 ] 

Shaofeng SHI commented on KYLIN-3811:
-

Hi Wei, I see the main change is using KylinLoadIncrementalHFiles to replace 
HBase's "LoadIncrementalHFiles", what's the behavior change there? Is it a 
limitation of HBase "LoadIncrementalHFiles"? Thank you!

> Support the standalone HBase cluster using HDFS HA
> --
>
> Key: KYLIN-3811
> URL: https://issues.apache.org/jira/browse/KYLIN-3811
> Project: Kylin
>  Issue Type: Improvement
>  Components: Storage - HBase
>Affects Versions: v2.3.1
>Reporter: zhangwei
>Assignee: zhangwei
>Priority: Minor
> Attachments: hdfs_ha.patch, hdfs_ha_2.patch
>
>
> 独立hbase 集群的 hdfs namenode主备切换导致Kylin无法正常工作的问题
> 痛点:
> ylin.hbase.cluster.fs=hdfs://namenode:54310,在hbase的hdfs namenode切换之后会,和hbase 
> hdfs相关的步骤会出现失败
> 我们的方案:(所有的修改都基于kylin的代码,不需要hbase 做修改) 
> kylin.properties 
> kylin.hbase.cluster.fs=hdfs://nshbase
> kylin.storage.hbase.cluster-hdfs-config-file=hbase-hdfs-site.xml
> hbase-hdfs-site.xml配置 hbase hdfs的HA连接方式,其中dfs.nameservices= nshbase



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] codecov-io commented on issue #479: KYLIN-3826 MergeCuboidJob only uploads necessary segment's dictionary

2019-02-23 Thread GitBox
codecov-io commented on issue #479: KYLIN-3826 MergeCuboidJob only uploads 
necessary segment's dictionary
URL: https://github.com/apache/kylin/pull/479#issuecomment-466723919
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/479?src=pr&el=h1) Report
   > :exclamation: No coverage uploaded for pull request base 
(`master@9d125e1`). [Click here to learn what that 
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `0%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/kylin/pull/479/graphs/tree.svg?width=650&token=JawVgbgsVo&height=150&src=pr)](https://codecov.io/gh/apache/kylin/pull/479?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff@@
   ## master #479   +/-   ##
   =
 Coverage  ?   24.46%   
 Complexity? 4961   
   =
 Files ? 1144   
 Lines ?69420   
 Branches  ? 9895   
   =
 Hits  ?16987   
 Misses?50719   
 Partials  ? 1714
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/kylin/pull/479?src=pr&el=tree) | Coverage Δ 
| Complexity Δ | |
   |---|---|---|---|
   | 
[...g/apache/kylin/engine/mr/steps/MergeCuboidJob.java](https://codecov.io/gh/apache/kylin/pull/479/diff?src=pr&el=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvc3RlcHMvTWVyZ2VDdWJvaWRKb2IuamF2YQ==)
 | `0% <0%> (ø)` | `0 <0> (?)` | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/kylin/pull/479?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/kylin/pull/479?src=pr&el=footer). Last 
update 
[9d125e1...4958f52](https://codecov.io/gh/apache/kylin/pull/479?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] asfgit commented on issue #479: KYLIN-3826 MergeCuboidJob only uploads necessary segment's dictionary

2019-02-23 Thread GitBox
asfgit commented on issue #479: KYLIN-3826 MergeCuboidJob only uploads 
necessary segment's dictionary
URL: https://github.com/apache/kylin/pull/479#issuecomment-466720183
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (KYLIN-3826) MergeCuboidJob only uploads necessary segment's dictionary

2019-02-23 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16776083#comment-16776083
 ] 

ASF GitHub Bot commented on KYLIN-3826:
---

shaofengshi commented on pull request #479: KYLIN-3826 MergeCuboidJob only 
uploads necessary segment's dictionary
URL: https://github.com/apache/kylin/pull/479
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> MergeCuboidJob only uploads necessary segment's dictionary
> --
>
> Key: KYLIN-3826
> URL: https://issues.apache.org/jira/browse/KYLIN-3826
> Project: Kylin
>  Issue Type: Improvement
>  Components: Job Engine
>Reporter: Shaofeng SHI
>Priority: Major
> Fix For: v2.6.1
>
>
> On yesterday's Kylin meetup, Zhang Wei mentioned that the "MergeCuboidJob" 
> will upload all segment's metadata, which will take extra long time when the 
> segment number is large. While this is unnecessary.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] shaofengshi opened a new pull request #479: KYLIN-3826 MergeCuboidJob only uploads necessary segment's dictionary

2019-02-23 Thread GitBox
shaofengshi opened a new pull request #479: KYLIN-3826 MergeCuboidJob only 
uploads necessary segment's dictionary
URL: https://github.com/apache/kylin/pull/479
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Updated] (KYLIN-3826) MergeCuboidJob only uploads necessary segment's dictionary

2019-02-23 Thread Shaofeng SHI (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shaofeng SHI updated KYLIN-3826:

Fix Version/s: v2.6.1

> MergeCuboidJob only uploads necessary segment's dictionary
> --
>
> Key: KYLIN-3826
> URL: https://issues.apache.org/jira/browse/KYLIN-3826
> Project: Kylin
>  Issue Type: Improvement
>  Components: Job Engine
>Reporter: Shaofeng SHI
>Priority: Major
> Fix For: v2.6.1
>
>
> On yesterday's Kylin meetup, Zhang Wei mentioned that the "MergeCuboidJob" 
> will upload all segment's metadata, which will take extra long time when the 
> segment number is large. While this is unnecessary.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (KYLIN-3826) MergeCuboidJob only uploads necessary segment's dictionary

2019-02-23 Thread Shaofeng SHI (JIRA)
Shaofeng SHI created KYLIN-3826:
---

 Summary: MergeCuboidJob only uploads necessary segment's dictionary
 Key: KYLIN-3826
 URL: https://issues.apache.org/jira/browse/KYLIN-3826
 Project: Kylin
  Issue Type: Improvement
  Components: Job Engine
Reporter: Shaofeng SHI


On yesterday's Kylin meetup, Zhang Wei mentioned that the "MergeCuboidJob" will 
upload all segment's metadata, which will take extra long time when the segment 
number is large. While this is unnecessary.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] coveralls edited a comment on issue #476: KYLIN-3822 fix the param parse error in DeployCoprocessorCLI

2019-02-23 Thread GitBox
coveralls edited a comment on issue #476: KYLIN-3822 fix the param parse error 
in DeployCoprocessorCLI
URL: https://github.com/apache/kylin/pull/476#issuecomment-466635385
 
 
   ## Pull Request Test Coverage Report for [Build 
4154](https://coveralls.io/builds/21785516)
   
   * **0** of **4**   **(0.0%)**  changed or added relevant lines in **1** file 
are covered.
   * **2** unchanged lines in **2** files lost coverage.
   * Overall coverage decreased (**-0.002%**) to **26.944%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-|--||---: |
   | 
[storage-hbase/src/main/java/org/apache/kylin/storage/hbase/util/DeployCoprocessorCLI.java](https://coveralls.io/builds/21785516/source?filename=storage-hbase%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fhbase%2Futil%2FDeployCoprocessorCLI.java#L101)
 | 0 | 4 | 0.0%
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-|--|--: |
   | 
[storage-hbase/src/main/java/org/apache/kylin/storage/hbase/util/DeployCoprocessorCLI.java](https://coveralls.io/builds/21785516/source?filename=storage-hbase%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fhbase%2Futil%2FDeployCoprocessorCLI.java#L115)
 | 1 | 0.0% |
   | 
[core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://coveralls.io/builds/21785516/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2Flookup%2Fcache%2FRocksDBLookupTable.java#L62)
 | 1 | 81.08% |
   
   
   |  Totals | [![Coverage 
Status](https://coveralls.io/builds/21785516/badge)](https://coveralls.io/builds/21785516)
 |
   | :-- | --: |
   | Change from base [Build 4151](https://coveralls.io/builds/21781536): |  
-0.002% |
   | Covered Lines: | 18704 |
   | Relevant Lines: | 69418 |
   
   ---
   # 💛  - [Coveralls](https://coveralls.io)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] coveralls edited a comment on issue #476: KYLIN-3822 fix the param parse error in DeployCoprocessorCLI

2019-02-23 Thread GitBox
coveralls edited a comment on issue #476: KYLIN-3822 fix the param parse error 
in DeployCoprocessorCLI
URL: https://github.com/apache/kylin/pull/476#issuecomment-466635385
 
 
   ## Pull Request Test Coverage Report for [Build 
4153](https://coveralls.io/builds/21784954)
   
   * **0** of **5**   **(0.0%)**  changed or added relevant lines in **1** file 
are covered.
   * **102** unchanged lines in **3** files lost coverage.
   * Overall coverage decreased (**-0.006%**) to **26.94%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-|--||---: |
   | 
[storage-hbase/src/main/java/org/apache/kylin/storage/hbase/util/DeployCoprocessorCLI.java](https://coveralls.io/builds/21784954/source?filename=storage-hbase%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fhbase%2Futil%2FDeployCoprocessorCLI.java#L101)
 | 0 | 5 | 0.0%
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-|--|--: |
   | 
[core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://coveralls.io/builds/21784954/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcuboid%2FTreeCuboidScheduler.java#L124)
 | 2 | 68.46% |
   | 
[core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/21784954/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L439)
 | 5 | 77.81% |
   | 
[storage-hbase/src/main/java/org/apache/kylin/storage/hbase/util/DeployCoprocessorCLI.java](https://coveralls.io/builds/21784954/source?filename=storage-hbase%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fhbase%2Futil%2FDeployCoprocessorCLI.java#L116)
 | 95 | 0.0% |
   
   
   |  Totals | [![Coverage 
Status](https://coveralls.io/builds/21784954/badge)](https://coveralls.io/builds/21784954)
 |
   | :-- | --: |
   | Change from base [Build 4151](https://coveralls.io/builds/21781536): |  
-0.006% |
   | Covered Lines: | 18701 |
   | Relevant Lines: | 69418 |
   
   ---
   # 💛  - [Coveralls](https://coveralls.io)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] coveralls commented on issue #476: KYLIN-3822 fix the param parse error in DeployCoprocessorCLI

2019-02-23 Thread GitBox
coveralls commented on issue #476: KYLIN-3822 fix the param parse error in 
DeployCoprocessorCLI
URL: https://github.com/apache/kylin/pull/476#issuecomment-466635385
 
 
   ## Pull Request Test Coverage Report for [Build 
4152](https://coveralls.io/builds/21783697)
   
   * **0** of **3**   **(0.0%)**  changed or added relevant lines in **1** file 
are covered.
   * **11** unchanged lines in **4** files lost coverage.
   * Overall coverage decreased (**-0.006%**) to **26.94%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-|--||---: |
   | 
[storage-hbase/src/main/java/org/apache/kylin/storage/hbase/util/DeployCoprocessorCLI.java](https://coveralls.io/builds/21783697/source?filename=storage-hbase%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fhbase%2Futil%2FDeployCoprocessorCLI.java#L101)
 | 0 | 3 | 0.0%
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-|--|--: |
   | 
[core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://coveralls.io/builds/21783697/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2Flookup%2Fcache%2FRocksDBLookupTable.java#L62)
 | 1 | 81.08% |
   | 
[core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://coveralls.io/builds/21783697/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcuboid%2FTreeCuboidScheduler.java#L124)
 | 2 | 68.46% |
   | 
[storage-hbase/src/main/java/org/apache/kylin/storage/hbase/util/DeployCoprocessorCLI.java](https://coveralls.io/builds/21783697/source?filename=storage-hbase%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fhbase%2Futil%2FDeployCoprocessorCLI.java#L105)
 | 3 | 0.0% |
   | 
[core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/21783697/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L439)
 | 5 | 77.81% |
   
   
   |  Totals | [![Coverage 
Status](https://coveralls.io/builds/21783697/badge)](https://coveralls.io/builds/21783697)
 |
   | :-- | --: |
   | Change from base [Build 4151](https://coveralls.io/builds/21781536): |  
-0.006% |
   | Covered Lines: | 18701 |
   | Relevant Lines: | 69418 |
   
   ---
   # 💛  - [Coveralls](https://coveralls.io)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services