[GitHub] coveralls edited a comment on issue #489: KYLIN-2620 Make the condition stricter to answer query with topN

2019-02-28 Thread GitBox
coveralls edited a comment on issue #489: KYLIN-2620 Make the condition 
stricter to answer query with topN
URL: https://github.com/apache/kylin/pull/489#issuecomment-467762777
 
 
   ## Pull Request Test Coverage Report for [Build 
4178](https://coveralls.io/builds/21894643)
   
   * **0** of **36**   **(0.0%)**  changed or added relevant lines in **6** 
files are covered.
   * **10** unchanged lines in **5** files lost coverage.
   * Overall coverage decreased (**-0.01%**) to **26.946%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-|--||---: |
   | 
[core-metadata/src/main/java/org/apache/kylin/metadata/realization/SQLDigest.java](https://coveralls.io/builds/21894643/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetadata%2Frealization%2FSQLDigest.java#L125)
 | 0 | 1 | 0.0%
   | 
[query/src/main/java/org/apache/kylin/query/relnode/OLAPContext.java](https://coveralls.io/builds/21894643/source?filename=query%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fquery%2Frelnode%2FOLAPContext.java#L135)
 | 0 | 1 | 0.0%
   | 
[query/src/main/java/org/apache/kylin/query/relnode/OLAPLimitRel.java](https://coveralls.io/builds/21894643/source?filename=query%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fquery%2Frelnode%2FOLAPLimitRel.java#L81)
 | 0 | 1 | 0.0%
   | 
[core-cube/src/main/java/org/apache/kylin/cube/CubeInstance.java](https://coveralls.io/builds/21894643/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2FCubeInstance.java#L537)
 | 0 | 2 | 0.0%
   | 
[query/src/main/java/org/apache/kylin/query/relnode/OLAPSortRel.java](https://coveralls.io/builds/21894643/source?filename=query%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fquery%2Frelnode%2FOLAPSortRel.java#L77)
 | 0 | 8 | 0.0%
   | 
[core-metadata/src/main/java/org/apache/kylin/measure/topn/TopNMeasureType.java](https://coveralls.io/builds/21894643/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmeasure%2Ftopn%2FTopNMeasureType.java#L266)
 | 0 | 23 | 0.0%
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-|--|--: |
   | 
[query/src/main/java/org/apache/kylin/query/relnode/OLAPSortRel.java](https://coveralls.io/builds/21894643/source?filename=query%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fquery%2Frelnode%2FOLAPSortRel.java#L86)
 | 1 | 0.0% |
   | 
[core-cube/src/main/java/org/apache/kylin/cube/CubeInstance.java](https://coveralls.io/builds/21894643/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2FCubeInstance.java#L539)
 | 1 | 43.88% |
   | 
[server-base/src/main/java/org/apache/kylin/rest/util/QueryRequestLimits.java](https://coveralls.io/builds/21894643/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Futil%2FQueryRequestLimits.java#L72)
 | 1 | 47.62% |
   | 
[core-metadata/src/main/java/org/apache/kylin/measure/topn/TopNMeasureType.java](https://coveralls.io/builds/21894643/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmeasure%2Ftopn%2FTopNMeasureType.java#L298)
 | 2 | 4.0% |
   | 
[core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/21894643/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L439)
 | 5 | 77.81% |
   
   
   |  Totals | [![Coverage 
Status](https://coveralls.io/builds/21894643/badge)](https://coveralls.io/builds/21894643)
 |
   | :-- | --: |
   | Change from base [Build 4170](https://coveralls.io/builds/21871775): |  
-0.01% |
   | Covered Lines: | 18716 |
   | Relevant Lines: | 69458 |
   
   ---
   #   - [Coveralls](https://coveralls.io)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Created] (KYLIN-3838) retry mechanism is invalid when build with spark

2019-02-28 Thread Chao Long (JIRA)
Chao Long created KYLIN-3838:


 Summary: retry mechanism is invalid when build with spark
 Key: KYLIN-3838
 URL: https://issues.apache.org/jira/browse/KYLIN-3838
 Project: Kylin
  Issue Type: Bug
  Components: Spark Engine
Reporter: Chao Long
Assignee: Chao Long


description:http://mail-archives.apache.org/mod_mbox/kylin-dev/201902.mbox/%3C1550482835832-0.post%40n6.nabble.com%3E



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (KYLIN-2620) Check for "ORDER BY LIMIT" clause when rewrite SUM query as TOPN

2019-02-28 Thread Shaofeng SHI (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-2620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shaofeng SHI reassigned KYLIN-2620:
---

Assignee: Chao Long  (was: Shaofeng SHI)

> Check for "ORDER BY LIMIT" clause when rewrite SUM query as TOPN
> 
>
> Key: KYLIN-2620
> URL: https://issues.apache.org/jira/browse/KYLIN-2620
> Project: Kylin
>  Issue Type: Bug
>  Components: Measure - TopN
>Reporter: Lin Tingmao
>Assignee: Chao Long
>Priority: Major
> Fix For: v2.6.1
>
>
> When running the following query
> select sum(measure) from table group by col_id
> if there exists TOPN(measure, group by col_id)  measure, 
> TopNMeasureType.isTopNCompatibleSum()will pass, so the SUM is rewritten 
> to TOPN. This confuses the user since they may expect a accurate result for 
> every distinct value of group by column(s). 
> Kylin should check if "ORDER BY col_id LIMIT topncapacity" is present in the 
> query to determine whether to rewrite.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3836) Kylin StringUtil.join() may cause NPE if iterator is empty

2019-02-28 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16781241#comment-16781241
 ] 

ASF subversion and git services commented on KYLIN-3836:


Commit 7ca653e3be25394a380bd3cb159410099a111584 in kylin's branch 
refs/heads/2.5.x from chao long
[ https://gitbox.apache.org/repos/asf?p=kylin.git;h=7ca653e ]

KYLIN-3836 fix Kylin StringUtil.join() may cause NPE if iterator is empty


> Kylin StringUtil.join() may cause NPE if iterator is empty
> --
>
> Key: KYLIN-3836
> URL: https://issues.apache.org/jira/browse/KYLIN-3836
> Project: Kylin
>  Issue Type: Bug
>Reporter: Chao Long
>Assignee: Chao Long
>Priority: Major
> Fix For: v2.6.1
>
>
> {code}
> public static String join(Iterable parts, String separator) {
>     StringBuilder buf = new StringBuilder();
>     Iterator iterator = parts.iterator();
>     if (iterator == null || (!iterator.hasNext())) {
>         return null;
>     }
> {code}
> org.apache.kylin.job.exception.ExecuteException: 
> org.apache.kylin.job.exception.ExecuteException: 
> java.lang.NullPointerException
>  at 
> org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:183)
>  at 
> org.apache.kylin.job.impl.threadpool.DefaultScheduler$JobRunner.run(DefaultScheduler.java:114)
>  at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
>  at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
>  at java.lang.Thread.run(Thread.java:748)
>  Caused by: org.apache.kylin.job.exception.ExecuteException: 
> java.lang.NullPointerException
>  at 
> org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:183)
>  at 
> org.apache.kylin.job.execution.DefaultChainedExecutable.doWork(DefaultChainedExecutable.java:71)
>  at 
> org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:168)
>  ... 4 more
>  Caused by: java.lang.NullPointerException
>  at com.google.common.base.Preconditions.checkNotNull(Preconditions.java:191)
>  at com.google.common.base.Splitter.split(Splitter.java:383)
>  at org.apache.kylin.common.util.StringUtil.splitAndTrim(StringUtil.java:181)
>  at 
> org.apache.kylin.source.hive.GarbageCollectionStep.getIntermediateTables(GarbageCollectionStep.java:95)
>  at 
> org.apache.kylin.source.hive.GarbageCollectionStep.cleanUpIntermediateFlatTable(GarbageCollectionStep.java:62)
>  at 
> org.apache.kylin.source.hive.GarbageCollectionStep.doWork(GarbageCollectionStep.java:48)
>  at 
> org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:168)
>  ... 6 more



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3836) Kylin StringUtil.join() may cause NPE if iterator is empty

2019-02-28 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16781240#comment-16781240
 ] 

ASF subversion and git services commented on KYLIN-3836:


Commit e4459d5b93906f63bcde0e0d3d97efe2d9bfa899 in kylin's branch 
refs/heads/2.6.x from chao long
[ https://gitbox.apache.org/repos/asf?p=kylin.git;h=e4459d5 ]

KYLIN-3836 fix Kylin StringUtil.join() may cause NPE if iterator is empty


> Kylin StringUtil.join() may cause NPE if iterator is empty
> --
>
> Key: KYLIN-3836
> URL: https://issues.apache.org/jira/browse/KYLIN-3836
> Project: Kylin
>  Issue Type: Bug
>Reporter: Chao Long
>Assignee: Chao Long
>Priority: Major
> Fix For: v2.6.1
>
>
> {code}
> public static String join(Iterable parts, String separator) {
>     StringBuilder buf = new StringBuilder();
>     Iterator iterator = parts.iterator();
>     if (iterator == null || (!iterator.hasNext())) {
>         return null;
>     }
> {code}
> org.apache.kylin.job.exception.ExecuteException: 
> org.apache.kylin.job.exception.ExecuteException: 
> java.lang.NullPointerException
>  at 
> org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:183)
>  at 
> org.apache.kylin.job.impl.threadpool.DefaultScheduler$JobRunner.run(DefaultScheduler.java:114)
>  at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
>  at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
>  at java.lang.Thread.run(Thread.java:748)
>  Caused by: org.apache.kylin.job.exception.ExecuteException: 
> java.lang.NullPointerException
>  at 
> org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:183)
>  at 
> org.apache.kylin.job.execution.DefaultChainedExecutable.doWork(DefaultChainedExecutable.java:71)
>  at 
> org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:168)
>  ... 4 more
>  Caused by: java.lang.NullPointerException
>  at com.google.common.base.Preconditions.checkNotNull(Preconditions.java:191)
>  at com.google.common.base.Splitter.split(Splitter.java:383)
>  at org.apache.kylin.common.util.StringUtil.splitAndTrim(StringUtil.java:181)
>  at 
> org.apache.kylin.source.hive.GarbageCollectionStep.getIntermediateTables(GarbageCollectionStep.java:95)
>  at 
> org.apache.kylin.source.hive.GarbageCollectionStep.cleanUpIntermediateFlatTable(GarbageCollectionStep.java:62)
>  at 
> org.apache.kylin.source.hive.GarbageCollectionStep.doWork(GarbageCollectionStep.java:48)
>  at 
> org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:168)
>  ... 6 more



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] Wayne1c commented on issue #489: KYLIN-2620 Make the condition stricter to answer query with topN

2019-02-28 Thread GitBox
Wayne1c commented on issue #489: KYLIN-2620 Make the condition stricter to 
answer query with topN
URL: https://github.com/apache/kylin/pull/489#issuecomment-468513152
 
 
   CI passed


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Updated] (KYLIN-3727) Can not build empty segment, HadoopShellException

2019-02-28 Thread Shaofeng SHI (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shaofeng SHI updated KYLIN-3727:

Summary: Can not build empty segment, HadoopShellException  (was:  
kylin2.5.2 不能构建空的cube,否则出现 HadoopShellException异常)

> Can not build empty segment, HadoopShellException
> -
>
> Key: KYLIN-3727
> URL: https://issues.apache.org/jira/browse/KYLIN-3727
> Project: Kylin
>  Issue Type: Bug
>  Components: Job Engine
>Affects Versions: v2.5.2
>Reporter: shiyu
>Assignee: Alexander
>Priority: Major
>  Labels: Kylin
> Attachments: KYLIN-3727.master.001.patch, 
> image-2018-12-19-08-38-19-791.png
>
>
> 注:kylin 已经开启,是否容忍数据源为空,默认值为 TRUE
> kylin.job.allow-empty-segment=true
> 出错位置:#12 Step Name: Load HFile to HBase Table
> !image-2018-12-19-08-38-19-791.png!
> 异常信息:HadoopShellException
> org.apache.kylin.engine.mr.exception.HadoopShellException: result code:-1
> at 
> org.apache.kylin.engine.mr.common.HadoopShellExecutable.doWork(HadoopShellExecutable.java:73)
> at 
> org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:164)
> at 
> org.apache.kylin.job.execution.DefaultChainedExecutable.doWork(DefaultChainedExecutable.java:70)
> at 
> org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:164)
> at 
> org.apache.kylin.job.impl.threadpool.DefaultScheduler$JobRunner.run(DefaultScheduler.java:113)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3836) Kylin StringUtil.join() may cause NPE if iterator is empty

2019-02-28 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16780543#comment-16780543
 ] 

ASF GitHub Bot commented on KYLIN-3836:
---

shaofengshi commented on pull request #493: KYLIN-3836 fix Kylin 
StringUtil.join() may cause NPE if iterator is e…
URL: https://github.com/apache/kylin/pull/493
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Kylin StringUtil.join() may cause NPE if iterator is empty
> --
>
> Key: KYLIN-3836
> URL: https://issues.apache.org/jira/browse/KYLIN-3836
> Project: Kylin
>  Issue Type: Bug
>Reporter: Chao Long
>Assignee: Chao Long
>Priority: Major
> Fix For: v2.6.1
>
>
> {code}
> public static String join(Iterable parts, String separator) {
>     StringBuilder buf = new StringBuilder();
>     Iterator iterator = parts.iterator();
>     if (iterator == null || (!iterator.hasNext())) {
>         return null;
>     }
> {code}
> org.apache.kylin.job.exception.ExecuteException: 
> org.apache.kylin.job.exception.ExecuteException: 
> java.lang.NullPointerException
>  at 
> org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:183)
>  at 
> org.apache.kylin.job.impl.threadpool.DefaultScheduler$JobRunner.run(DefaultScheduler.java:114)
>  at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
>  at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
>  at java.lang.Thread.run(Thread.java:748)
>  Caused by: org.apache.kylin.job.exception.ExecuteException: 
> java.lang.NullPointerException
>  at 
> org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:183)
>  at 
> org.apache.kylin.job.execution.DefaultChainedExecutable.doWork(DefaultChainedExecutable.java:71)
>  at 
> org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:168)
>  ... 4 more
>  Caused by: java.lang.NullPointerException
>  at com.google.common.base.Preconditions.checkNotNull(Preconditions.java:191)
>  at com.google.common.base.Splitter.split(Splitter.java:383)
>  at org.apache.kylin.common.util.StringUtil.splitAndTrim(StringUtil.java:181)
>  at 
> org.apache.kylin.source.hive.GarbageCollectionStep.getIntermediateTables(GarbageCollectionStep.java:95)
>  at 
> org.apache.kylin.source.hive.GarbageCollectionStep.cleanUpIntermediateFlatTable(GarbageCollectionStep.java:62)
>  at 
> org.apache.kylin.source.hive.GarbageCollectionStep.doWork(GarbageCollectionStep.java:48)
>  at 
> org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:168)
>  ... 6 more



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3836) Kylin StringUtil.join() may cause NPE if iterator is empty

2019-02-28 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16780544#comment-16780544
 ] 

ASF subversion and git services commented on KYLIN-3836:


Commit 6bc2aaeb7032aa89feed91316a2179263c4c4c35 in kylin's branch 
refs/heads/master from chao long
[ https://gitbox.apache.org/repos/asf?p=kylin.git;h=6bc2aae ]

KYLIN-3836 fix Kylin StringUtil.join() may cause NPE if iterator is empty


> Kylin StringUtil.join() may cause NPE if iterator is empty
> --
>
> Key: KYLIN-3836
> URL: https://issues.apache.org/jira/browse/KYLIN-3836
> Project: Kylin
>  Issue Type: Bug
>Reporter: Chao Long
>Assignee: Chao Long
>Priority: Major
> Fix For: v2.6.1
>
>
> {code}
> public static String join(Iterable parts, String separator) {
>     StringBuilder buf = new StringBuilder();
>     Iterator iterator = parts.iterator();
>     if (iterator == null || (!iterator.hasNext())) {
>         return null;
>     }
> {code}
> org.apache.kylin.job.exception.ExecuteException: 
> org.apache.kylin.job.exception.ExecuteException: 
> java.lang.NullPointerException
>  at 
> org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:183)
>  at 
> org.apache.kylin.job.impl.threadpool.DefaultScheduler$JobRunner.run(DefaultScheduler.java:114)
>  at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
>  at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
>  at java.lang.Thread.run(Thread.java:748)
>  Caused by: org.apache.kylin.job.exception.ExecuteException: 
> java.lang.NullPointerException
>  at 
> org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:183)
>  at 
> org.apache.kylin.job.execution.DefaultChainedExecutable.doWork(DefaultChainedExecutable.java:71)
>  at 
> org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:168)
>  ... 4 more
>  Caused by: java.lang.NullPointerException
>  at com.google.common.base.Preconditions.checkNotNull(Preconditions.java:191)
>  at com.google.common.base.Splitter.split(Splitter.java:383)
>  at org.apache.kylin.common.util.StringUtil.splitAndTrim(StringUtil.java:181)
>  at 
> org.apache.kylin.source.hive.GarbageCollectionStep.getIntermediateTables(GarbageCollectionStep.java:95)
>  at 
> org.apache.kylin.source.hive.GarbageCollectionStep.cleanUpIntermediateFlatTable(GarbageCollectionStep.java:62)
>  at 
> org.apache.kylin.source.hive.GarbageCollectionStep.doWork(GarbageCollectionStep.java:48)
>  at 
> org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:168)
>  ... 6 more



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] shaofengshi merged pull request #493: KYLIN-3836 fix Kylin StringUtil.join() may cause NPE if iterator is e…

2019-02-28 Thread GitBox
shaofengshi merged pull request #493: KYLIN-3836 fix Kylin StringUtil.join() 
may cause NPE if iterator is e…
URL: https://github.com/apache/kylin/pull/493
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] codecov-io commented on issue #494: KYLIN-3727 Check if where is no directories, then finish job successf…

2019-02-28 Thread GitBox
codecov-io commented on issue #494: KYLIN-3727 Check if where is no 
directories, then finish job successf…
URL: https://github.com/apache/kylin/pull/494#issuecomment-468257977
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/494?src=pr=h1) Report
   > :exclamation: No coverage uploaded for pull request base 
(`master@e5c7c0d`). [Click here to learn what that 
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `0%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/kylin/pull/494/graphs/tree.svg?width=650=JawVgbgsVo=150=pr)](https://codecov.io/gh/apache/kylin/pull/494?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ## master #494   +/-   ##
   =
 Coverage  ?   24.47%   
 Complexity? 4963   
   =
 Files ? 1144   
 Lines ?69444   
 Branches  ? 9902   
   =
 Hits  ?16994   
 Misses?50731   
 Partials  ? 1719
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/kylin/pull/494?src=pr=tree) | Coverage Δ 
| Complexity Δ | |
   |---|---|---|---|
   | 
[.../apache/kylin/storage/hbase/steps/BulkLoadJob.java](https://codecov.io/gh/apache/kylin/pull/494/diff?src=pr=tree#diff-c3RvcmFnZS1oYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9oYmFzZS9zdGVwcy9CdWxrTG9hZEpvYi5qYXZh)
 | `0% <0%> (ø)` | `0 <0> (?)` | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/kylin/pull/494?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/kylin/pull/494?src=pr=footer). Last 
update 
[e5c7c0d...0920a3d](https://codecov.io/gh/apache/kylin/pull/494?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (KYLIN-3727) kylin2.5.2 不能构建空的cube,否则出现 HadoopShellException异常

2019-02-28 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16780443#comment-16780443
 ] 

ASF GitHub Bot commented on KYLIN-3727:
---

Sidonet commented on pull request #494: KYLIN-3727 Check if where is no 
directories, then finish job successf…
URL: https://github.com/apache/kylin/pull/494
 
 
   …ully.
   
   Input path for HBase load consists
   _SUCCESS
   F1
   F2
   etc...
   
   So, check if no folders exist, then skip loading step.
   
   Test for non-empty cube:
   2019-02-28 14:56:20,333 INFO  [Scheduler 136668115 Job 
0143a095-92fe-c8e0-a919-428682e2f15d-238] execution.ExecutableManager:453 : job 
id:0143a095-92fe-c8e0-a919-428682e2f15d-08 from READY to RUNNING
   2019-02-28 14:56:20,354 INFO  [Scheduler 136668115 Job 
0143a095-92fe-c8e0-a919-428682e2f15d-238] common.HadoopShellExecutable:59 : 
parameters of the HadoopShellExecutable:  -input 
hdfs://***:8020/kylin/kylin_metadata/kylin-0143a095-92fe-c8e0-a919-428682e2f15d/ORCTESTCUBE/hfile
 -htablename KYLIN_D9OV6ZF44W -cubename ORCTESTCUBE
   2019-02-28 14:56:25,416 DEBUG [Scheduler 136668115 Job 
0143a095-92fe-c8e0-a919-428682e2f15d-238] steps.BulkLoadJob:95 : Start to run 
LoadIncrementalHFiles
   
   Test in my env for empty cube:
   2019-02-28 14:42:15,699 INFO  [Scheduler 136668115 Job 
199180ac-8ab3-708f-c89c-6f2166a7d27d-102] execution.ExecutableManager:453 : job 
id:199180ac-8ab3-708f-c89c-6f2166a7d27d-08 from READY to RUNNING
   2019-02-28 14:42:15,784 INFO  [Scheduler 136668115 Job 
199180ac-8ab3-708f-c89c-6f2166a7d27d-102] common.HadoopShellExecutable:59 : 
parameters of the HadoopShellExecutable:  -input 
hdfs://***:8020/kylin/kylin_metadata/kylin-199180ac-8ab3-708f-c89c-6f2166a7d27d/kylin_sales_cube_orc/hfile
 -htablename KYLIN_MP2UWUVS0X -cubename kylin_sales_cube_orc
   2019-02-28 14:42:21,402 DEBUG [Scheduler 136668115 Job 
199180ac-8ab3-708f-c89c-6f2166a7d27d-102] steps.BulkLoadJob:100 : Nothing to 
load, cube is empty
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


>  kylin2.5.2 不能构建空的cube,否则出现 HadoopShellException异常
> --
>
> Key: KYLIN-3727
> URL: https://issues.apache.org/jira/browse/KYLIN-3727
> Project: Kylin
>  Issue Type: Bug
>  Components: Job Engine
>Affects Versions: v2.5.2
>Reporter: shiyu
>Assignee: Alexander
>Priority: Major
>  Labels: Kylin
> Attachments: KYLIN-3727.master.001.patch, 
> image-2018-12-19-08-38-19-791.png
>
>
> 注:kylin 已经开启,是否容忍数据源为空,默认值为 TRUE
> kylin.job.allow-empty-segment=true
> 出错位置:#12 Step Name: Load HFile to HBase Table
> !image-2018-12-19-08-38-19-791.png!
> 异常信息:HadoopShellException
> org.apache.kylin.engine.mr.exception.HadoopShellException: result code:-1
> at 
> org.apache.kylin.engine.mr.common.HadoopShellExecutable.doWork(HadoopShellExecutable.java:73)
> at 
> org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:164)
> at 
> org.apache.kylin.job.execution.DefaultChainedExecutable.doWork(DefaultChainedExecutable.java:70)
> at 
> org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:164)
> at 
> org.apache.kylin.job.impl.threadpool.DefaultScheduler$JobRunner.run(DefaultScheduler.java:113)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] Sidonet opened a new pull request #494: KYLIN-3727 Check if where is no directories, then finish job successf…

2019-02-28 Thread GitBox
Sidonet opened a new pull request #494: KYLIN-3727 Check if where is no 
directories, then finish job successf…
URL: https://github.com/apache/kylin/pull/494
 
 
   …ully.
   
   Input path for HBase load consists
   _SUCCESS
   F1
   F2
   etc...
   
   So, check if no folders exist, then skip loading step.
   
   Test for non-empty cube:
   2019-02-28 14:56:20,333 INFO  [Scheduler 136668115 Job 
0143a095-92fe-c8e0-a919-428682e2f15d-238] execution.ExecutableManager:453 : job 
id:0143a095-92fe-c8e0-a919-428682e2f15d-08 from READY to RUNNING
   2019-02-28 14:56:20,354 INFO  [Scheduler 136668115 Job 
0143a095-92fe-c8e0-a919-428682e2f15d-238] common.HadoopShellExecutable:59 : 
parameters of the HadoopShellExecutable:  -input 
hdfs://***:8020/kylin/kylin_metadata/kylin-0143a095-92fe-c8e0-a919-428682e2f15d/ORCTESTCUBE/hfile
 -htablename KYLIN_D9OV6ZF44W -cubename ORCTESTCUBE
   2019-02-28 14:56:25,416 DEBUG [Scheduler 136668115 Job 
0143a095-92fe-c8e0-a919-428682e2f15d-238] steps.BulkLoadJob:95 : Start to run 
LoadIncrementalHFiles
   
   Test in my env for empty cube:
   2019-02-28 14:42:15,699 INFO  [Scheduler 136668115 Job 
199180ac-8ab3-708f-c89c-6f2166a7d27d-102] execution.ExecutableManager:453 : job 
id:199180ac-8ab3-708f-c89c-6f2166a7d27d-08 from READY to RUNNING
   2019-02-28 14:42:15,784 INFO  [Scheduler 136668115 Job 
199180ac-8ab3-708f-c89c-6f2166a7d27d-102] common.HadoopShellExecutable:59 : 
parameters of the HadoopShellExecutable:  -input 
hdfs://***:8020/kylin/kylin_metadata/kylin-199180ac-8ab3-708f-c89c-6f2166a7d27d/kylin_sales_cube_orc/hfile
 -htablename KYLIN_MP2UWUVS0X -cubename kylin_sales_cube_orc
   2019-02-28 14:42:21,402 DEBUG [Scheduler 136668115 Job 
199180ac-8ab3-708f-c89c-6f2166a7d27d-102] steps.BulkLoadJob:100 : Nothing to 
load, cube is empty
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] asfgit commented on issue #494: KYLIN-3727 Check if where is no directories, then finish job successf…

2019-02-28 Thread GitBox
asfgit commented on issue #494: KYLIN-3727 Check if where is no directories, 
then finish job successf…
URL: https://github.com/apache/kylin/pull/494#issuecomment-468250666
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Updated] (KYLIN-3727) kylin2.5.2 不能构建空的cube,否则出现 HadoopShellException异常

2019-02-28 Thread Alexander (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alexander updated KYLIN-3727:
-
Attachment: KYLIN-3727.master.001.patch

>  kylin2.5.2 不能构建空的cube,否则出现 HadoopShellException异常
> --
>
> Key: KYLIN-3727
> URL: https://issues.apache.org/jira/browse/KYLIN-3727
> Project: Kylin
>  Issue Type: Bug
>  Components: Job Engine
>Affects Versions: v2.5.2
>Reporter: shiyu
>Assignee: Lijun Cao
>Priority: Major
>  Labels: Kylin
> Attachments: KYLIN-3727.master.001.patch, 
> image-2018-12-19-08-38-19-791.png
>
>
> 注:kylin 已经开启,是否容忍数据源为空,默认值为 TRUE
> kylin.job.allow-empty-segment=true
> 出错位置:#12 Step Name: Load HFile to HBase Table
> !image-2018-12-19-08-38-19-791.png!
> 异常信息:HadoopShellException
> org.apache.kylin.engine.mr.exception.HadoopShellException: result code:-1
> at 
> org.apache.kylin.engine.mr.common.HadoopShellExecutable.doWork(HadoopShellExecutable.java:73)
> at 
> org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:164)
> at 
> org.apache.kylin.job.execution.DefaultChainedExecutable.doWork(DefaultChainedExecutable.java:70)
> at 
> org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:164)
> at 
> org.apache.kylin.job.impl.threadpool.DefaultScheduler$JobRunner.run(DefaultScheduler.java:113)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (KYLIN-3727) kylin2.5.2 不能构建空的cube,否则出现 HadoopShellException异常

2019-02-28 Thread Alexander (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alexander reassigned KYLIN-3727:


Assignee: Alexander  (was: Lijun Cao)

>  kylin2.5.2 不能构建空的cube,否则出现 HadoopShellException异常
> --
>
> Key: KYLIN-3727
> URL: https://issues.apache.org/jira/browse/KYLIN-3727
> Project: Kylin
>  Issue Type: Bug
>  Components: Job Engine
>Affects Versions: v2.5.2
>Reporter: shiyu
>Assignee: Alexander
>Priority: Major
>  Labels: Kylin
> Attachments: KYLIN-3727.master.001.patch, 
> image-2018-12-19-08-38-19-791.png
>
>
> 注:kylin 已经开启,是否容忍数据源为空,默认值为 TRUE
> kylin.job.allow-empty-segment=true
> 出错位置:#12 Step Name: Load HFile to HBase Table
> !image-2018-12-19-08-38-19-791.png!
> 异常信息:HadoopShellException
> org.apache.kylin.engine.mr.exception.HadoopShellException: result code:-1
> at 
> org.apache.kylin.engine.mr.common.HadoopShellExecutable.doWork(HadoopShellExecutable.java:73)
> at 
> org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:164)
> at 
> org.apache.kylin.job.execution.DefaultChainedExecutable.doWork(DefaultChainedExecutable.java:70)
> at 
> org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:164)
> at 
> org.apache.kylin.job.impl.threadpool.DefaultScheduler$JobRunner.run(DefaultScheduler.java:113)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (KYLIN-3836) Kylin StringUtil.join() may cause NPE if iterator is empty

2019-02-28 Thread Chao Long (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chao Long updated KYLIN-3836:
-
Description: 
{code}
public static String join(Iterable parts, String separator) {
    StringBuilder buf = new StringBuilder();
    Iterator iterator = parts.iterator();
    if (iterator == null || (!iterator.hasNext())) {
        return null;
    }
{code}
org.apache.kylin.job.exception.ExecuteException: 
org.apache.kylin.job.exception.ExecuteException: java.lang.NullPointerException
 at 
org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:183)
 at 
org.apache.kylin.job.impl.threadpool.DefaultScheduler$JobRunner.run(DefaultScheduler.java:114)
 at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
 at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
 at java.lang.Thread.run(Thread.java:748)
 Caused by: org.apache.kylin.job.exception.ExecuteException: 
java.lang.NullPointerException
 at 
org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:183)
 at 
org.apache.kylin.job.execution.DefaultChainedExecutable.doWork(DefaultChainedExecutable.java:71)
 at 
org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:168)
 ... 4 more
 Caused by: java.lang.NullPointerException
 at com.google.common.base.Preconditions.checkNotNull(Preconditions.java:191)
 at com.google.common.base.Splitter.split(Splitter.java:383)
 at org.apache.kylin.common.util.StringUtil.splitAndTrim(StringUtil.java:181)
 at 
org.apache.kylin.source.hive.GarbageCollectionStep.getIntermediateTables(GarbageCollectionStep.java:95)
 at 
org.apache.kylin.source.hive.GarbageCollectionStep.cleanUpIntermediateFlatTable(GarbageCollectionStep.java:62)
 at 
org.apache.kylin.source.hive.GarbageCollectionStep.doWork(GarbageCollectionStep.java:48)
 at 
org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:168)
 ... 6 more

  was:
{quote}
public static String join(Iterable parts, String separator) {
    StringBuilder buf = new StringBuilder();
    Iterator iterator = parts.iterator();
    if (iterator == null || (!iterator.hasNext())) {
        return null;
    }
{quote}
org.apache.kylin.job.exception.ExecuteException: 
org.apache.kylin.job.exception.ExecuteException: java.lang.NullPointerException
 at 
org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:183)
 at 
org.apache.kylin.job.impl.threadpool.DefaultScheduler$JobRunner.run(DefaultScheduler.java:114)
 at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
 at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
 at java.lang.Thread.run(Thread.java:748)
 Caused by: org.apache.kylin.job.exception.ExecuteException: 
java.lang.NullPointerException
 at 
org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:183)
 at 
org.apache.kylin.job.execution.DefaultChainedExecutable.doWork(DefaultChainedExecutable.java:71)
 at 
org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:168)
 ... 4 more
 Caused by: java.lang.NullPointerException
 at com.google.common.base.Preconditions.checkNotNull(Preconditions.java:191)
 at com.google.common.base.Splitter.split(Splitter.java:383)
 at org.apache.kylin.common.util.StringUtil.splitAndTrim(StringUtil.java:181)
 at 
org.apache.kylin.source.hive.GarbageCollectionStep.getIntermediateTables(GarbageCollectionStep.java:95)
 at 
org.apache.kylin.source.hive.GarbageCollectionStep.cleanUpIntermediateFlatTable(GarbageCollectionStep.java:62)
 at 
org.apache.kylin.source.hive.GarbageCollectionStep.doWork(GarbageCollectionStep.java:48)
 at 
org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:168)
 ... 6 more


> Kylin StringUtil.join() may cause NPE if iterator is empty
> --
>
> Key: KYLIN-3836
> URL: https://issues.apache.org/jira/browse/KYLIN-3836
> Project: Kylin
>  Issue Type: Bug
>Reporter: Chao Long
>Assignee: Chao Long
>Priority: Major
> Fix For: v2.6.1
>
>
> {code}
> public static String join(Iterable parts, String separator) {
>     StringBuilder buf = new StringBuilder();
>     Iterator iterator = parts.iterator();
>     if (iterator == null || (!iterator.hasNext())) {
>         return null;
>     }
> {code}
> org.apache.kylin.job.exception.ExecuteException: 
> org.apache.kylin.job.exception.ExecuteException: 
> java.lang.NullPointerException
>  at 
> org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:183)
>  at 
> org.apache.kylin.job.impl.threadpool.DefaultScheduler$JobRunner.run(DefaultScheduler.java:114)
>  at 
> 

[jira] [Created] (KYLIN-3837) hadoop3.0 mapreduce task can not run successfully

2019-02-28 Thread JIRA
梁龙 created KYLIN-3837:
-

 Summary: hadoop3.0 mapreduce task can not run successfully
 Key: KYLIN-3837
 URL: https://issues.apache.org/jira/browse/KYLIN-3837
 Project: Kylin
  Issue Type: Bug
  Components: Job Engine
Affects Versions: v2.5.1
Reporter: 梁龙


In the hadoop3.0, The port of namenode is 8020,  not 9820.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (KYLIN-3837) hadoop3.0 mapreduce task can not run successfully

2019-02-28 Thread JIRA


 [ 
https://issues.apache.org/jira/browse/KYLIN-3837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

梁龙 updated KYLIN-3837:
--
Description: 
In the hadoop3.0, The port of namenode is 8020,  not 9820.

mapreduce error:

Port 9820 specified in URI 
hdfs://nameservice1:9820/user/yarn/.staging/job_1543198806940_3775/job.splitmetainfo
 but host 'nameservice1' is a logical (HA) namenode and does not use port 
information.
java.io.IOException: Port 9820 specified in URI 
hdfs://nameservice1:9820/user/yarn/.staging/job_1543198806940_3775/job.splitmetainfo
 but host 'nameservice1' is a logical (HA) namenode and does not use port 
information.

  was:In the hadoop3.0, The port of namenode is 8020,  not 9820.


> hadoop3.0 mapreduce task can not run successfully
> -
>
> Key: KYLIN-3837
> URL: https://issues.apache.org/jira/browse/KYLIN-3837
> Project: Kylin
>  Issue Type: Bug
>  Components: Job Engine
>Affects Versions: v2.5.1
>Reporter: 梁龙
>Priority: Major
>
> In the hadoop3.0, The port of namenode is 8020,  not 9820.
> mapreduce error:
> Port 9820 specified in URI 
> hdfs://nameservice1:9820/user/yarn/.staging/job_1543198806940_3775/job.splitmetainfo
>  but host 'nameservice1' is a logical (HA) namenode and does not use port 
> information.
> java.io.IOException: Port 9820 specified in URI 
> hdfs://nameservice1:9820/user/yarn/.staging/job_1543198806940_3775/job.splitmetainfo
>  but host 'nameservice1' is a logical (HA) namenode and does not use port 
> information.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)