[GitHub] [kylin] codecov-io commented on issue #540: KYLIN-3851 Flink cubing step : merge dictionary
codecov-io commented on issue #540: KYLIN-3851 Flink cubing step : merge dictionary URL: https://github.com/apache/kylin/pull/540#issuecomment-475104023 # [Codecov](https://codecov.io/gh/apache/kylin/pull/540?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`engine-flink@ea34ffc`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is `0%`. [](https://codecov.io/gh/apache/kylin/pull/540?src=pr=tree) ```diff @@ Coverage Diff @@ ## engine-flink #540 +/- ## === Coverage? 24.14% Complexity ? 5029 === Files ? 1173 Lines ?71300 Branches?10111 === Hits?17215 Misses ?52345 Partials? 1740 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/540?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...he/kylin/engine/mr/steps/UpdateDictionaryStep.java](https://codecov.io/gh/apache/kylin/pull/540/diff?src=pr=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvc3RlcHMvVXBkYXRlRGljdGlvbmFyeVN0ZXAuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...kylin/engine/flink/FlinkBatchMergeJobBuilder2.java](https://codecov.io/gh/apache/kylin/pull/540/diff?src=pr=tree#diff-ZW5naW5lLWZsaW5rL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvZmxpbmsvRmxpbmtCYXRjaE1lcmdlSm9iQnVpbGRlcjIuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...che/kylin/engine/flink/FlinkMergingDictionary.java](https://codecov.io/gh/apache/kylin/pull/540/diff?src=pr=tree#diff-ZW5naW5lLWZsaW5rL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvZmxpbmsvRmxpbmtNZXJnaW5nRGljdGlvbmFyeS5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/540?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/540?src=pr=footer). Last update [ea34ffc...48e1bdd](https://codecov.io/gh/apache/kylin/pull/540?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (KYLIN-3890) Add doc about usage of ./bin/metadata.sh
[ https://issues.apache.org/jira/browse/KYLIN-3890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16797778#comment-16797778 ] ASF GitHub Bot commented on KYLIN-3890: --- Qsimple commented on pull request #541: KYLIN-3890 Add doc about usage of ./bin/metadata.sh URL: https://github.com/apache/kylin/pull/541 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add doc about usage of ./bin/metadata.sh > > > Key: KYLIN-3890 > URL: https://issues.apache.org/jira/browse/KYLIN-3890 > Project: Kylin > Issue Type: Improvement > Components: Documentation >Affects Versions: v2.5.2 >Reporter: Yuzhang QIU >Priority: Minor > > JIRA title descript the JIRA -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [kylin] Qsimple opened a new pull request #541: KYLIN-3890 Add doc about usage of ./bin/metadata.sh
Qsimple opened a new pull request #541: KYLIN-3890 Add doc about usage of ./bin/metadata.sh URL: https://github.com/apache/kylin/pull/541 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] asfgit commented on issue #541: KYLIN-3890 Add doc about usage of ./bin/metadata.sh
asfgit commented on issue #541: KYLIN-3890 Add doc about usage of ./bin/metadata.sh URL: https://github.com/apache/kylin/pull/541#issuecomment-475102717 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] asfgit commented on issue #541: KYLIN-3890 Add doc about usage of ./bin/metadata.sh
asfgit commented on issue #541: KYLIN-3890 Add doc about usage of ./bin/metadata.sh URL: https://github.com/apache/kylin/pull/541#issuecomment-475102718 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (KYLIN-3474) Tableau 10.5 get malformed token (multi-query instance)
[ https://issues.apache.org/jira/browse/KYLIN-3474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16797752#comment-16797752 ] ASF subversion and git services commented on KYLIN-3474: Commit 14d0a37cbc93c1fd05d6b815011cbe6b8923503c in kylin's branch refs/heads/master from Temple Zhou [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=14d0a37 ] KYLIN-3474 Tableau 10.5 get malformed token > Tableau 10.5 get malformed token (multi-query instance) > --- > > Key: KYLIN-3474 > URL: https://issues.apache.org/jira/browse/KYLIN-3474 > Project: Kylin > Issue Type: Bug > Components: Query Engine, Security >Affects Versions: v2.3.0, v2.4.0, v2.5.0, v2.6.1 >Reporter: Temple Zhou >Assignee: Temple Zhou >Priority: Major > Fix For: v2.4.1, v2.4.2 > > Attachments: KYLIN-3474.master.001.patch, kylin.log, > tableau-malformed-token.png > > > I found that when I use Tableau 10.5 with Kylin 2.4.0(multi-query) , the > Tableau Server will get the malformed token error when do query via restful > API. > However, when I use Tableau 10.5 with Kylin 2.4.0(single query instance), the > error will be gone. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (KYLIN-3474) Tableau 10.5 get malformed token (multi-query instance)
[ https://issues.apache.org/jira/browse/KYLIN-3474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaofeng SHI updated KYLIN-3474: Fix Version/s: (was: v2.4.2) (was: v2.4.1) v2.6.2 > Tableau 10.5 get malformed token (multi-query instance) > --- > > Key: KYLIN-3474 > URL: https://issues.apache.org/jira/browse/KYLIN-3474 > Project: Kylin > Issue Type: Bug > Components: Query Engine, Security >Affects Versions: v2.3.0, v2.4.0, v2.5.0, v2.6.1 >Reporter: Temple Zhou >Assignee: Temple Zhou >Priority: Major > Fix For: v2.6.2 > > Attachments: KYLIN-3474.master.001.patch, kylin.log, > tableau-malformed-token.png > > > I found that when I use Tableau 10.5 with Kylin 2.4.0(multi-query) , the > Tableau Server will get the malformed token error when do query via restful > API. > However, when I use Tableau 10.5 with Kylin 2.4.0(single query instance), the > error will be gone. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3474) Tableau 10.5 get malformed token (multi-query instance)
[ https://issues.apache.org/jira/browse/KYLIN-3474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16797751#comment-16797751 ] ASF GitHub Bot commented on KYLIN-3474: --- shaofengshi commented on pull request #536: KYLIN-3474 Tableau 10.5 get malformed token URL: https://github.com/apache/kylin/pull/536 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Tableau 10.5 get malformed token (multi-query instance) > --- > > Key: KYLIN-3474 > URL: https://issues.apache.org/jira/browse/KYLIN-3474 > Project: Kylin > Issue Type: Bug > Components: Query Engine, Security >Affects Versions: v2.3.0, v2.4.0, v2.5.0, v2.6.1 >Reporter: Temple Zhou >Assignee: Temple Zhou >Priority: Major > Fix For: v2.4.1, v2.4.2 > > Attachments: KYLIN-3474.master.001.patch, kylin.log, > tableau-malformed-token.png > > > I found that when I use Tableau 10.5 with Kylin 2.4.0(multi-query) , the > Tableau Server will get the malformed token error when do query via restful > API. > However, when I use Tableau 10.5 with Kylin 2.4.0(single query instance), the > error will be gone. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [kylin] shaofengshi merged pull request #536: KYLIN-3474 Tableau 10.5 get malformed token
shaofengshi merged pull request #536: KYLIN-3474 Tableau 10.5 get malformed token URL: https://github.com/apache/kylin/pull/536 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Comment Edited] (KYLIN-3474) Tableau 10.5 get malformed token (multi-query instance)
[
https://issues.apache.org/jira/browse/KYLIN-3474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16796732#comment-16796732
]
Temple Zhou edited comment on KYLIN-3474 at 3/21/19 1:49 AM:
-
{code:java}
public class KylinUserManager {
private static final Logger logger =
LoggerFactory.getLogger(KylinUserManager.class);
public static KylinUserManager getInstance(KylinConfig config) {
return config.getManager(KylinUserManager.class);
}
// called by reflection
static KylinUserManager newInstance(KylinConfig config) throws IOException {
return new KylinUserManager(config);
}
//
private KylinConfig config;
// user ==> ManagedUser
private CaseInsensitiveStringCache userMap;
private CachedCrudAssist crud;
private AutoReadWriteLock lock = new AutoReadWriteLock();
{code}
{code:java}
public void update(ManagedUser user) {
try (AutoReadWriteLock.AutoLock l = lock.lockForWrite()) {
ManagedUser exist = userMap.get(user.getUsername());
if (exist != null) {
user.setLastModified(exist.getLastModified());
}
user.setUsername(user.getUsername().toUpperCase(Locale.ROOT));
crud.save(user);
} catch (IOException e) {
throw new RuntimeException("Can not update user.", e);
}
}{code}
The userMap is case-insensitive and Kylin will transform the username to
uppercase(ADMIN) even I authenticate with lowercase (admin)，but
org.apache.kylin.rest.security.ManagedUser#equals compare the username in a
case sensitive method.
org.apache.kylin.rest.security.KylinAuthenticationProvider#authenticate
{code:java}
String username = user.getUsername();
logger.debug("User {} authorities : {}", username,
user.getAuthorities());
if (!userService.userExists(username)) {
userService.createUser(user);
} else if
(!userService.loadUserByUsername(username).equals(user)) {
// in case ldap users changing.
userService.updateUser(user);
}
{code}
Finally, the userService.loadUserByUsername(username).equals(user) will always
be false, and the
org.springframework.security.provisioning.UserDetailsManager#updateUser will be
called many times per second.
was (Author: temple.zhou):
{code:java}
public class KylinUserManager {
private static final Logger logger =
LoggerFactory.getLogger(KylinUserManager.class);
public static KylinUserManager getInstance(KylinConfig config) {
return config.getManager(KylinUserManager.class);
}
// called by reflection
static KylinUserManager newInstance(KylinConfig config) throws IOException {
return new KylinUserManager(config);
}
//
private KylinConfig config;
// user ==> ManagedUser
private CaseInsensitiveStringCache userMap;
private CachedCrudAssist crud;
private AutoReadWriteLock lock = new AutoReadWriteLock();
{code}
The userMap is case-insensitive, so I can authenticate successfully with
uppercase or lowercase username such as ADMIN or admin，but
org.apache.kylin.rest.security.ManagedUser#equals compare the username in a
case sensitive method.
org.apache.kylin.rest.security.KylinAuthenticationProvider#authenticate
{code:java}
String username = user.getUsername();
logger.debug("User {} authorities : {}", username,
user.getAuthorities());
if (!userService.userExists(username)) {
userService.createUser(user);
} else if
(!userService.loadUserByUsername(username).equals(user)) {
// in case ldap users changing.
userService.updateUser(user);
}
{code}
Finally, the userService.loadUserByUsername(username).equals(user) will always
be false, and the
org.springframework.security.provisioning.UserDetailsManager#updateUser will be
called many times per second.
> Tableau 10.5 get malformed token (multi-query instance)
> ---
>
> Key: KYLIN-3474
> URL: https://issues.apache.org/jira/browse/KYLIN-3474
> Project: Kylin
> Issue Type: Bug
> Components: Query Engine, Security
>Affects Versions: v2.3.0, v2.4.0, v2.5.0, v2.6.1
>Reporter: Temple Zhou
>Assignee: Temple Zhou
>Priority: Major
> Fix For: v2.4.1, v2.4.2
>
> Attachments: KYLIN-3474.master.001.patch, kylin.log,
> tableau-malformed-token.png
>
>
> I found that when I use Tableau 10.5 with Kylin 2.4.0(multi-query) , the
> Tableau Server will get the malformed token error when do
[jira] [Commented] (KYLIN-3896) Implement IFlinkOutput based on HBase
[ https://issues.apache.org/jira/browse/KYLIN-3896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16797226#comment-16797226 ] ASF GitHub Bot commented on KYLIN-3896: --- shaofengshi commented on pull request #537: KYLIN-3896 Implement IFlinkOutput based on HBase URL: https://github.com/apache/kylin/pull/537 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Implement IFlinkOutput based on HBase > - > > Key: KYLIN-3896 > URL: https://issues.apache.org/jira/browse/KYLIN-3896 > Project: Kylin > Issue Type: Sub-task > Components: Flink Engine >Reporter: vinoyang >Assignee: vinoyang >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3896) Implement IFlinkOutput based on HBase
[ https://issues.apache.org/jira/browse/KYLIN-3896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16797227#comment-16797227 ] ASF subversion and git services commented on KYLIN-3896: Commit ea34ffceaef91beba81a95087ab998e6a2f736c4 in kylin's branch refs/heads/engine-flink from yanghua [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=ea34ffc ] KYLIN-3896 Implement IFlinkOutput based on HBase > Implement IFlinkOutput based on HBase > - > > Key: KYLIN-3896 > URL: https://issues.apache.org/jira/browse/KYLIN-3896 > Project: Kylin > Issue Type: Sub-task > Components: Flink Engine >Reporter: vinoyang >Assignee: vinoyang >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [kylin] shaofengshi merged pull request #537: KYLIN-3896 Implement IFlinkOutput based on HBase
shaofengshi merged pull request #537: KYLIN-3896 Implement IFlinkOutput based on HBase URL: https://github.com/apache/kylin/pull/537 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (KYLIN-3897) Implement IFlinkInput based on Hive
[ https://issues.apache.org/jira/browse/KYLIN-3897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16797223#comment-16797223 ] ASF GitHub Bot commented on KYLIN-3897: --- shaofengshi commented on pull request #539: KYLIN-3897 Implement IFlinkInput based on Hive URL: https://github.com/apache/kylin/pull/539 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Implement IFlinkInput based on Hive > --- > > Key: KYLIN-3897 > URL: https://issues.apache.org/jira/browse/KYLIN-3897 > Project: Kylin > Issue Type: Sub-task > Components: Flink Engine >Reporter: vinoyang >Assignee: vinoyang >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3897) Implement IFlinkInput based on Hive
[ https://issues.apache.org/jira/browse/KYLIN-3897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16797224#comment-16797224 ] ASF subversion and git services commented on KYLIN-3897: Commit 5eac35a3bcc534125ef12c936a5e12f56a889921 in kylin's branch refs/heads/engine-flink from yanghua [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=5eac35a ] KYLIN-3897 Implement IFlinkInput based on Hive > Implement IFlinkInput based on Hive > --- > > Key: KYLIN-3897 > URL: https://issues.apache.org/jira/browse/KYLIN-3897 > Project: Kylin > Issue Type: Sub-task > Components: Flink Engine >Reporter: vinoyang >Assignee: vinoyang >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [kylin] shaofengshi merged pull request #539: KYLIN-3897 Implement IFlinkInput based on Hive
shaofengshi merged pull request #539: KYLIN-3897 Implement IFlinkInput based on Hive URL: https://github.com/apache/kylin/pull/539 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (KYLIN-3851) Flink cubing step : merge dictionary
[ https://issues.apache.org/jira/browse/KYLIN-3851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16797128#comment-16797128 ] ASF GitHub Bot commented on KYLIN-3851: --- yanghua commented on pull request #540: KYLIN-3851 Flink cubing step : merge dictionary URL: https://github.com/apache/kylin/pull/540 JIRA ref : https://issues.apache.org/jira/browse/KYLIN-3851 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Flink cubing step : merge dictionary > > > Key: KYLIN-3851 > URL: https://issues.apache.org/jira/browse/KYLIN-3851 > Project: Kylin > Issue Type: Sub-task > Components: Flink Engine >Reporter: vinoyang >Assignee: vinoyang >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [kylin] asfgit commented on issue #540: KYLIN-3851 Flink cubing step : merge dictionary
asfgit commented on issue #540: KYLIN-3851 Flink cubing step : merge dictionary URL: https://github.com/apache/kylin/pull/540#issuecomment-474811835 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] yanghua opened a new pull request #540: KYLIN-3851 Flink cubing step : merge dictionary
yanghua opened a new pull request #540: KYLIN-3851 Flink cubing step : merge dictionary URL: https://github.com/apache/kylin/pull/540 JIRA ref : https://issues.apache.org/jira/browse/KYLIN-3851 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] asfgit commented on issue #540: KYLIN-3851 Flink cubing step : merge dictionary
asfgit commented on issue #540: KYLIN-3851 Flink cubing step : merge dictionary URL: https://github.com/apache/kylin/pull/540#issuecomment-474811834 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (KYLIN-3897) Implement IFlinkInput based on Hive
[ https://issues.apache.org/jira/browse/KYLIN-3897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16797062#comment-16797062 ] ASF GitHub Bot commented on KYLIN-3897: --- yanghua commented on pull request #539: KYLIN-3897 Implement IFlinkInput based on Hive URL: https://github.com/apache/kylin/pull/539 JIRA ref : https://issues.apache.org/jira/browse/KYLIN-3897 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Implement IFlinkInput based on Hive > --- > > Key: KYLIN-3897 > URL: https://issues.apache.org/jira/browse/KYLIN-3897 > Project: Kylin > Issue Type: Sub-task > Components: Flink Engine >Reporter: vinoyang >Assignee: vinoyang >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [kylin] asfgit commented on issue #539: KYLIN-3897 Implement IFlinkInput based on Hive
asfgit commented on issue #539: KYLIN-3897 Implement IFlinkInput based on Hive URL: https://github.com/apache/kylin/pull/539#issuecomment-474788907 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] asfgit commented on issue #539: KYLIN-3897 Implement IFlinkInput based on Hive
asfgit commented on issue #539: KYLIN-3897 Implement IFlinkInput based on Hive URL: https://github.com/apache/kylin/pull/539#issuecomment-474788908 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] yanghua opened a new pull request #539: KYLIN-3897 Implement IFlinkInput based on Hive
yanghua opened a new pull request #539: KYLIN-3897 Implement IFlinkInput based on Hive URL: https://github.com/apache/kylin/pull/539 JIRA ref : https://issues.apache.org/jira/browse/KYLIN-3897 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] asfgit commented on issue #538: KYLIN-3898 Cube level properties are ineffective in the some build steps
asfgit commented on issue #538: KYLIN-3898 Cube level properties are ineffective in the some build steps URL: https://github.com/apache/kylin/pull/538#issuecomment-474753669 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (KYLIN-3898) Cube level properties are ineffective in the some build steps
[ https://issues.apache.org/jira/browse/KYLIN-3898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16796956#comment-16796956 ] ASF GitHub Bot commented on KYLIN-3898: --- TempleZhou commented on pull request #538: KYLIN-3898 Cube level properties are ineffective in the some build steps URL: https://github.com/apache/kylin/pull/538 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Cube level properties are ineffective in the some build steps > - > > Key: KYLIN-3898 > URL: https://issues.apache.org/jira/browse/KYLIN-3898 > Project: Kylin > Issue Type: Bug > Components: Job Engine >Affects Versions: v2.4.0, v2.5.0, v2.6.0 >Reporter: Temple Zhou >Assignee: Temple Zhou >Priority: Major > > I overwrite the property kylin.source.hive.flat-table-storage-format with > "RCFILE" in my cube, but there are no effect, the "#1 Step Name: Create > Intermediate Flat Hive Table" still use the configuration in kylin.properties. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [kylin] TempleZhou opened a new pull request #538: KYLIN-3898 Cube level properties are ineffective in the some build steps
TempleZhou opened a new pull request #538: KYLIN-3898 Cube level properties are ineffective in the some build steps URL: https://github.com/apache/kylin/pull/538 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] asfgit commented on issue #538: KYLIN-3898 Cube level properties are ineffective in the some build steps
asfgit commented on issue #538: KYLIN-3898 Cube level properties are ineffective in the some build steps URL: https://github.com/apache/kylin/pull/538#issuecomment-474753667 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (KYLIN-3898) Cube level properties are ineffective in the some build steps
[ https://issues.apache.org/jira/browse/KYLIN-3898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Temple Zhou updated KYLIN-3898: --- Description: I overwrite the property kylin.source.hive.flat-table-storage-format with "RCFILE" in my cube, but there are no effect, the "#1 Step Name: Create Intermediate Flat Hive Table" still use the configuration in kylin.properties. > Cube level properties are ineffective in the some build steps > - > > Key: KYLIN-3898 > URL: https://issues.apache.org/jira/browse/KYLIN-3898 > Project: Kylin > Issue Type: Bug > Components: Job Engine >Affects Versions: v2.4.0, v2.5.0, v2.6.0 >Reporter: Temple Zhou >Assignee: Temple Zhou >Priority: Major > > I overwrite the property kylin.source.hive.flat-table-storage-format with > "RCFILE" in my cube, but there are no effect, the "#1 Step Name: Create > Intermediate Flat Hive Table" still use the configuration in kylin.properties. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (KYLIN-3898) Cube level properties are ineffective in the some build steps
Temple Zhou created KYLIN-3898: -- Summary: Cube level properties are ineffective in the some build steps Key: KYLIN-3898 URL: https://issues.apache.org/jira/browse/KYLIN-3898 Project: Kylin Issue Type: Bug Components: Job Engine Affects Versions: v2.6.0, v2.5.0, v2.4.0 Reporter: Temple Zhou Assignee: Temple Zhou -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [kylin] codecov-io commented on issue #537: KYLIN-3896 Implement IFlinkOutput based on HBase
codecov-io commented on issue #537: KYLIN-3896 Implement IFlinkOutput based on HBase URL: https://github.com/apache/kylin/pull/537#issuecomment-474698645 # [Codecov](https://codecov.io/gh/apache/kylin/pull/537?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`engine-flink@e9b520b`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is `0%`. [](https://codecov.io/gh/apache/kylin/pull/537?src=pr=tree) ```diff @@ Coverage Diff @@ ## engine-flink#537 +/- ## == Coverage? 24.2% Complexity ?5029 == Files ?1171 Lines ? 71146 Branches? 10096 == Hits? 17218 Misses ? 52189 Partials?1739 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/537?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...a/org/apache/kylin/storage/hbase/HBaseStorage.java](https://codecov.io/gh/apache/kylin/pull/537/diff?src=pr=tree#diff-c3RvcmFnZS1oYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9oYmFzZS9IQmFzZVN0b3JhZ2UuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...torage/hbase/steps/HBaseFlinkOutputTransition.java](https://codecov.io/gh/apache/kylin/pull/537/diff?src=pr=tree#diff-c3RvcmFnZS1oYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9oYmFzZS9zdGVwcy9IQmFzZUZsaW5rT3V0cHV0VHJhbnNpdGlvbi5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/537?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/537?src=pr=footer). Last update [e9b520b...e880db6](https://codecov.io/gh/apache/kylin/pull/537?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
