[GitHub] [kylin] codecov-io edited a comment on issue #528: KYLIN-3883 Kylin supports column count aggregation
codecov-io edited a comment on issue #528: KYLIN-3883 Kylin supports column count aggregation URL: https://github.com/apache/kylin/pull/528#issuecomment-475183764 # [Codecov](https://codecov.io/gh/apache/kylin/pull/528?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@6ee0212`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is `0%`. [](https://codecov.io/gh/apache/kylin/pull/528?src=pr=tree) ```diff @@Coverage Diff@@ ## master #528 +/- ## = Coverage ? 24.42% Complexity? 5025 = Files ? 1161 Lines ?70469 Branches ?10026 = Hits ?17211 Misses?51525 Partials ? 1733 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/528?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...kylin/cube/model/validation/rule/FunctionRule.java](https://codecov.io/gh/apache/kylin/pull/528/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL3ZhbGlkYXRpb24vcnVsZS9GdW5jdGlvblJ1bGUuamF2YQ==) | `44.92% <ø> (ø)` | `9 <0> (?)` | | | [...a/org/apache/kylin/cube/CubeCapabilityChecker.java](https://codecov.io/gh/apache/kylin/pull/528/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL0N1YmVDYXBhYmlsaXR5Q2hlY2tlci5qYXZh) | `0% <ø> (ø)` | `0 <0> (?)` | | | [.../org/apache/kylin/metadata/model/FunctionDesc.java](https://codecov.io/gh/apache/kylin/pull/528/diff?src=pr=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvbW9kZWwvRnVuY3Rpb25EZXNjLmphdmE=) | `21.91% <0%> (ø)` | `17 <0> (?)` | | | [...va/org/apache/kylin/cube/util/KeyValueBuilder.java](https://codecov.io/gh/apache/kylin/pull/528/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL3V0aWwvS2V5VmFsdWVCdWlsZGVyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/528?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/528?src=pr=footer). Last update [6ee0212...cf0247d](https://codecov.io/gh/apache/kylin/pull/528?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] xbirbird commented on a change in pull request #528: KYLIN-3883 Kylin supports column count aggregation
xbirbird commented on a change in pull request #528: KYLIN-3883 Kylin supports
column count aggregation
URL: https://github.com/apache/kylin/pull/528#discussion_r268373480
##
File path:
core-metadata/src/main/java/org/apache/kylin/metadata/model/FunctionDesc.java
##
@@ -316,12 +321,22 @@ public boolean equals(Object obj) {
} else {
return parameter.equalInArbitraryOrder(other.parameter);
}
-} else if (!isCount()) { // NOTE: don't check the parameter of count()
+} else {
if (parameter == null) {
-if (other.parameter != null)
+if (isCount()) {
+if (other.parameter != null &&
!other.parameter.getType().equals("constant")) {
Review comment:
done
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] xbirbird commented on a change in pull request #528: KYLIN-3883 Kylin supports column count aggregation
xbirbird commented on a change in pull request #528: KYLIN-3883 Kylin supports
column count aggregation
URL: https://github.com/apache/kylin/pull/528#discussion_r268373494
##
File path:
core-metadata/src/main/java/org/apache/kylin/metadata/model/FunctionDesc.java
##
@@ -289,7 +293,8 @@ public int hashCode() {
final int prime = 31;
int result = 1;
result = prime * result + ((expression == null) ? 0 :
expression.hashCode());
-result = prime * result + ((isCount() || parameter == null) ? 0 :
parameter.hashCode());
+result = prime * result + ((parameter == null || (isCount() &&
parameter.getType().equals("constant")))
Review comment:
done
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] xbirbird commented on a change in pull request #528: KYLIN-3883 Kylin supports column count aggregation
xbirbird commented on a change in pull request #528: KYLIN-3883 Kylin supports
column count aggregation
URL: https://github.com/apache/kylin/pull/528#discussion_r268373487
##
File path:
core-metadata/src/main/java/org/apache/kylin/metadata/model/FunctionDesc.java
##
@@ -146,7 +146,11 @@ public boolean needRewriteField() {
public String getRewriteFieldName() {
if (isCount()) {
-return "_KY_" + "COUNT__"; // ignores parameter, count(*),
count(1), count(col) are all the same
+if (parameter == null || parameter.getType().equals("constant")) {
Review comment:
done
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] shaofengshi commented on issue #538: KYLIN-3898 Cube level properties are ineffective in the some build steps
shaofengshi commented on issue #538: KYLIN-3898 Cube level properties are ineffective in the some build steps URL: https://github.com/apache/kylin/pull/538#issuecomment-475638101 Hi Temple, I think the more clear way is in : org.apache.kylin.job.JoinedFlatTable#generateCreateTableStatement(org.apache.kylin.metadata.model.IJoinedFlatTableDesc, java.lang.String) Change ` String storageFormat = flatDesc.getDataModel().getConfig().getFlatTableStorageFormat();` to ` String storageFormat = flatDesc.getSegment().getConfig().getFlatTableStorageFormat();` Which is to say, here using segment level config (which is also the cube level) is better than the model level config. Just let me know your idea. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (KYLIN-3898) Cube level properties are ineffective in the some build steps
[ https://issues.apache.org/jira/browse/KYLIN-3898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaofeng SHI updated KYLIN-3898: Priority: Minor (was: Major) Fix Version/s: v2.6.2 > Cube level properties are ineffective in the some build steps > - > > Key: KYLIN-3898 > URL: https://issues.apache.org/jira/browse/KYLIN-3898 > Project: Kylin > Issue Type: Bug > Components: Job Engine >Affects Versions: v2.4.0, v2.5.0, v2.6.0 >Reporter: Temple Zhou >Assignee: Temple Zhou >Priority: Minor > Fix For: v2.6.2 > > > I overwrite the property kylin.source.hive.flat-table-storage-format with > "RCFILE" in my cube, but there are no effect, the "#1 Step Name: Create > Intermediate Flat Hive Table" still use the configuration in kylin.properties. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [kylin] shaofengshi merged pull request #547: Update 2018-12-12-why-did-meituan-develop-kylin-on-druid-part1-of-2.md
shaofengshi merged pull request #547: Update 2018-12-12-why-did-meituan-develop-kylin-on-druid-part1-of-2.md URL: https://github.com/apache/kylin/pull/547 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] NickJain07 opened a new pull request #547: Update 2018-12-12-why-did-meituan-develop-kylin-on-druid-part1-of-2.md
NickJain07 opened a new pull request #547: Update 2018-12-12-why-did-meituan-develop-kylin-on-druid-part1-of-2.md URL: https://github.com/apache/kylin/pull/547 Corrected the field name used in the example. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] asfgit commented on issue #547: Update 2018-12-12-why-did-meituan-develop-kylin-on-druid-part1-of-2.md
asfgit commented on issue #547: Update 2018-12-12-why-did-meituan-develop-kylin-on-druid-part1-of-2.md URL: https://github.com/apache/kylin/pull/547#issuecomment-475564760 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (KYLIN-3895) Failed to register new MBean when "kylin.server.query-metrics-enabled" set true
[
https://issues.apache.org/jira/browse/KYLIN-3895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shaofeng SHI updated KYLIN-3895:
Fix Version/s: v2.6.2
> Failed to register new MBean when "kylin.server.query-metrics-enabled" set
> true
>
>
> Key: KYLIN-3895
> URL: https://issues.apache.org/jira/browse/KYLIN-3895
> Project: Kylin
> Issue Type: Bug
>Reporter: Guangxu Cheng
>Assignee: Guangxu Cheng
>Priority: Major
> Fix For: v2.6.2
>
>
> {code}
> 2019-03-20 10:17:25,753 WARN [Query 46cd99cc-8eb2-8370-d24c-6c10f18da9e0-54]
> util.MBeans:94 : Error creating MBean object name: Ha
> doop:service=Kylin,name=KYLIN_SYSTEM,sub=CUBE[name=KYLIN_HIVE_METRICS_JOB_QA]
> org.apache.hadoop.metrics2.MetricsException:
> javax.management.MalformedObjectNameException: Invalid character '=' in value
> part of property
> at
> org.apache.hadoop.metrics2.lib.DefaultMetricsSystem.newObjectName(DefaultMetricsSystem.java:122)
> at
> org.apache.hadoop.metrics2.lib.DefaultMetricsSystem.newMBeanName(DefaultMetricsSystem.java:102)
> at
> org.apache.hadoop.metrics2.util.MBeans.getMBeanName(MBeans.java:92)
> at org.apache.hadoop.metrics2.util.MBeans.register(MBeans.java:55)
> {code}
> The subname can't contain '='
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [kylin] yiming187 merged pull request #546: Update 2015-12-25-support-powerbi-tableau9.md
yiming187 merged pull request #546: Update 2015-12-25-support-powerbi-tableau9.md URL: https://github.com/apache/kylin/pull/546 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] yiming187 commented on issue #546: Update 2015-12-25-support-powerbi-tableau9.md
yiming187 commented on issue #546: Update 2015-12-25-support-powerbi-tableau9.md URL: https://github.com/apache/kylin/pull/546#issuecomment-475510024 @NickJain07 Thanks Nick. LGTM. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (KYLIN-3903) Fix dependence issue when debug in local
Chao Long created KYLIN-3903: Summary: Fix dependence issue when debug in local Key: KYLIN-3903 URL: https://issues.apache.org/jira/browse/KYLIN-3903 Project: Kylin Issue Type: Sub-task Reporter: Chao Long Assignee: Chao Long -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [kylin] asfgit commented on issue #546: Update 2015-12-25-support-powerbi-tableau9.md
asfgit commented on issue #546: Update 2015-12-25-support-powerbi-tableau9.md URL: https://github.com/apache/kylin/pull/546#issuecomment-475506853 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] NickJain07 opened a new pull request #546: Update 2015-12-25-support-powerbi-tableau9.md
NickJain07 opened a new pull request #546: Update 2015-12-25-support-powerbi-tableau9.md URL: https://github.com/apache/kylin/pull/546 Corrected some typos in the doc. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] asfgit commented on issue #546: Update 2015-12-25-support-powerbi-tableau9.md
asfgit commented on issue #546: Update 2015-12-25-support-powerbi-tableau9.md URL: https://github.com/apache/kylin/pull/546#issuecomment-475506854 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (KYLIN-3895) Failed to register new MBean when "kylin.server.query-metrics-enabled" set true
[
https://issues.apache.org/jira/browse/KYLIN-3895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16798743#comment-16798743
]
ASF subversion and git services commented on KYLIN-3895:
Commit 6ee0212af9d5b50096850c9cb76031b7cdd67402 in kylin's branch
refs/heads/master from Guangxu Cheng
[ https://gitbox.apache.org/repos/asf?p=kylin.git;h=6ee0212 ]
KYLIN-3895 Failed to register new MBean when
"kylin.server.query-metrics-enabled" set true
> Failed to register new MBean when "kylin.server.query-metrics-enabled" set
> true
>
>
> Key: KYLIN-3895
> URL: https://issues.apache.org/jira/browse/KYLIN-3895
> Project: Kylin
> Issue Type: Bug
>Reporter: Guangxu Cheng
>Assignee: Guangxu Cheng
>Priority: Major
>
> {code}
> 2019-03-20 10:17:25,753 WARN [Query 46cd99cc-8eb2-8370-d24c-6c10f18da9e0-54]
> util.MBeans:94 : Error creating MBean object name: Ha
> doop:service=Kylin,name=KYLIN_SYSTEM,sub=CUBE[name=KYLIN_HIVE_METRICS_JOB_QA]
> org.apache.hadoop.metrics2.MetricsException:
> javax.management.MalformedObjectNameException: Invalid character '=' in value
> part of property
> at
> org.apache.hadoop.metrics2.lib.DefaultMetricsSystem.newObjectName(DefaultMetricsSystem.java:122)
> at
> org.apache.hadoop.metrics2.lib.DefaultMetricsSystem.newMBeanName(DefaultMetricsSystem.java:102)
> at
> org.apache.hadoop.metrics2.util.MBeans.getMBeanName(MBeans.java:92)
> at org.apache.hadoop.metrics2.util.MBeans.register(MBeans.java:55)
> {code}
> The subname can't contain '='
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (KYLIN-3895) Failed to register new MBean when "kylin.server.query-metrics-enabled" set true
[
https://issues.apache.org/jira/browse/KYLIN-3895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16798742#comment-16798742
]
ASF GitHub Bot commented on KYLIN-3895:
---
shaofengshi commented on pull request #535: KYLIN-3895 Failed to register new
MBean when "kylin.server.query-metrics-enabled" set true
URL: https://github.com/apache/kylin/pull/535
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Failed to register new MBean when "kylin.server.query-metrics-enabled" set
> true
>
>
> Key: KYLIN-3895
> URL: https://issues.apache.org/jira/browse/KYLIN-3895
> Project: Kylin
> Issue Type: Bug
>Reporter: Guangxu Cheng
>Assignee: Guangxu Cheng
>Priority: Major
>
> {code}
> 2019-03-20 10:17:25,753 WARN [Query 46cd99cc-8eb2-8370-d24c-6c10f18da9e0-54]
> util.MBeans:94 : Error creating MBean object name: Ha
> doop:service=Kylin,name=KYLIN_SYSTEM,sub=CUBE[name=KYLIN_HIVE_METRICS_JOB_QA]
> org.apache.hadoop.metrics2.MetricsException:
> javax.management.MalformedObjectNameException: Invalid character '=' in value
> part of property
> at
> org.apache.hadoop.metrics2.lib.DefaultMetricsSystem.newObjectName(DefaultMetricsSystem.java:122)
> at
> org.apache.hadoop.metrics2.lib.DefaultMetricsSystem.newMBeanName(DefaultMetricsSystem.java:102)
> at
> org.apache.hadoop.metrics2.util.MBeans.getMBeanName(MBeans.java:92)
> at org.apache.hadoop.metrics2.util.MBeans.register(MBeans.java:55)
> {code}
> The subname can't contain '='
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [kylin] shaofengshi merged pull request #535: KYLIN-3895 Failed to register new MBean when "kylin.server.query-metrics-enabled" set true
shaofengshi merged pull request #535: KYLIN-3895 Failed to register new MBean when "kylin.server.query-metrics-enabled" set true URL: https://github.com/apache/kylin/pull/535 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] shaofengshi commented on a change in pull request #535: KYLIN-3895 Failed to register new MBean when "kylin.server.query-metrics-enabled" set true
shaofengshi commented on a change in pull request #535: KYLIN-3895 Failed to
register new MBean when "kylin.server.query-metrics-enabled" set true
URL: https://github.com/apache/kylin/pull/535#discussion_r268046087
##
File path:
server-base/src/main/java/org/apache/kylin/rest/metrics/QueryMetricsFacade.java
##
@@ -79,12 +79,11 @@ private static void updateMetricsToLocal(SQLRequest
sqlRequest, SQLResponse sqlR
return;
String projectName = sqlRequest.getProject();
-String cubeName = sqlResponse.getCube();
-
update(getQueryMetrics("Server_Total"), sqlResponse);
-
update(getQueryMetrics(projectName), sqlResponse);
+String cube = sqlResponse.getCube();
+String cubeName = cube.replace("=", "->");
Review comment:
I see, thank you for the information!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
