[jira] [Assigned] (KYLIN-3948) org.apache.hadoop.hive.metastore.HiveMetaStoreClint.(Lorg/apache/hadoop/conf/configuration;)V

2019-04-16 Thread Jiatao Tao (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jiatao Tao reassigned KYLIN-3948:
-

Assignee: (was: Jiatao Tao)

> org.apache.hadoop.hive.metastore.HiveMetaStoreClint.(Lorg/apache/hadoop/conf/configuration;)V
> ---
>
> Key: KYLIN-3948
> URL: https://issues.apache.org/jira/browse/KYLIN-3948
> Project: Kylin
>  Issue Type: Test
>  Components: Environment 
>Affects Versions: v2.5.2
> Environment: hadoop-3.1.1
> apache-hive-2.3.4-bin
> hbase-2.1.1
> apache-kylin-2.5.2-bin-hadoop3
>Reporter: praveenece
>Priority: Critical
>
> hadoop-3.1.1
> apache-hive-2.3.4-bin
> hbase-2.1.1
> apache-kylin-2.5.2-bin-hadoop3
> Now I tried with above environment, kylin is stated but i unable to load 
> metadata from hbase to kylin getting this below error in kylin UI.
> org.apache.hadoop.hive.metastore.HiveMetaStoreClint.(Lorg/apache/hadoop/conf/configuration;)V
> 2019-04-09 15:02:44,979 DEBUG [http-nio-7070-exec-9] common.KylinConfig:327 : 
> KYLIN_CONF property was not set, will seek KYLIN_HOME env variable
> 2019-04-09 15:02:50,071 ERROR [http-nio-7070-exec-6] 
> controller.TableController:190 : 
> org.apache.hadoop.hive.metastore.HiveMetaStoreClient.(Lorg/apache/hadoop/conf/Configuration;)V
> java.lang.NoSuchMethodError: 
> org.apache.hadoop.hive.metastore.HiveMetaStoreClient.(Lorg/apache/hadoop/conf/Configuration;)V
> at 
> org.apache.kylin.source.hive.CLIHiveClient.getMetaStoreClient(CLIHiveClient.java:132)
> at 
> org.apache.kylin.source.hive.CLIHiveClient.getHiveDbNames(CLIHiveClient.java:116)
> at 
> org.apache.kylin.source.hive.HiveMetadataExplorer.listDatabases(HiveMetadataExplorer.java:47)
> at 
> org.apache.kylin.rest.service.TableService.getSourceDbNames(TableService.java:277)
> at 
> org.apache.kylin.rest.controller.TableController.showHiveDatabases(TableController.java:188)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at 
> org.springframework.web.method.support.InvocableHandlerMethod.doInvoke(InvocableHandlerMethod.java:205)
> at 
> org.springframework.web.method.support.InvocableHandlerMethod.invokeForRequest(InvocableHandlerMethod.java:133)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (KYLIN-3948) org.apache.hadoop.hive.metastore.HiveMetaStoreClint.(Lorg/apache/hadoop/conf/configuration;)V

2019-04-16 Thread Jiatao Tao (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jiatao Tao reassigned KYLIN-3948:
-

Assignee: Jiatao Tao

> org.apache.hadoop.hive.metastore.HiveMetaStoreClint.(Lorg/apache/hadoop/conf/configuration;)V
> ---
>
> Key: KYLIN-3948
> URL: https://issues.apache.org/jira/browse/KYLIN-3948
> Project: Kylin
>  Issue Type: Test
>  Components: Environment 
>Affects Versions: v2.5.2
> Environment: hadoop-3.1.1
> apache-hive-2.3.4-bin
> hbase-2.1.1
> apache-kylin-2.5.2-bin-hadoop3
>Reporter: praveenece
>Assignee: Jiatao Tao
>Priority: Critical
>
> hadoop-3.1.1
> apache-hive-2.3.4-bin
> hbase-2.1.1
> apache-kylin-2.5.2-bin-hadoop3
> Now I tried with above environment, kylin is stated but i unable to load 
> metadata from hbase to kylin getting this below error in kylin UI.
> org.apache.hadoop.hive.metastore.HiveMetaStoreClint.(Lorg/apache/hadoop/conf/configuration;)V
> 2019-04-09 15:02:44,979 DEBUG [http-nio-7070-exec-9] common.KylinConfig:327 : 
> KYLIN_CONF property was not set, will seek KYLIN_HOME env variable
> 2019-04-09 15:02:50,071 ERROR [http-nio-7070-exec-6] 
> controller.TableController:190 : 
> org.apache.hadoop.hive.metastore.HiveMetaStoreClient.(Lorg/apache/hadoop/conf/Configuration;)V
> java.lang.NoSuchMethodError: 
> org.apache.hadoop.hive.metastore.HiveMetaStoreClient.(Lorg/apache/hadoop/conf/Configuration;)V
> at 
> org.apache.kylin.source.hive.CLIHiveClient.getMetaStoreClient(CLIHiveClient.java:132)
> at 
> org.apache.kylin.source.hive.CLIHiveClient.getHiveDbNames(CLIHiveClient.java:116)
> at 
> org.apache.kylin.source.hive.HiveMetadataExplorer.listDatabases(HiveMetadataExplorer.java:47)
> at 
> org.apache.kylin.rest.service.TableService.getSourceDbNames(TableService.java:277)
> at 
> org.apache.kylin.rest.controller.TableController.showHiveDatabases(TableController.java:188)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at 
> org.springframework.web.method.support.InvocableHandlerMethod.doInvoke(InvocableHandlerMethod.java:205)
> at 
> org.springframework.web.method.support.InvocableHandlerMethod.invokeForRequest(InvocableHandlerMethod.java:133)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3562) TS conflict when kylin update metadata in HBase

2019-04-16 Thread Jiatao Tao (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16819678#comment-16819678
 ] 

Jiatao Tao commented on KYLIN-3562:
---

Hi [~zhao jintao]

As I commented in 25/九月/18 11:09, I also think "The updating operation is 
pretty confusing and useless", I wanted to delete this at first but then I was 
told that may be used by LDAP, so I changed the update logic, now it will only 
update user when the user is changed, you can check out this in the latest code.

 

And the perfect solution, I think, is separate LDAP, and make a new 
implementation.

> TS conflict when kylin update metadata in HBase
> ---
>
> Key: KYLIN-3562
> URL: https://issues.apache.org/jira/browse/KYLIN-3562
> Project: Kylin
>  Issue Type: Bug
>Affects Versions: v2.4.0
>Reporter: Lingang Deng
>Assignee: Jiatao Tao
>Priority: Major
> Fix For: v2.4.2, v2.5.1
>
> Attachments: image-2018-09-17-16-40-56-212.png, 
> image-2018-09-25-15-03-51-009.png, image-2018-09-25-16-43-50-277.png
>
>
> Error log was as follows,
> {code:java}
> org.apache.kylin.common.persistence.WriteConflictException: Overwriting 
> conflict /user/admin, expect old TS 1536928877043, but it is 1536928907207
>      at 
> org.apache.kylin.storage.hbase.HBaseResourceStore.checkAndPutResourceImpl(HBaseResourceStore.java:325)
>      at 
> org.apache.kylin.common.persistence.ResourceStore.checkAndPutResourceCheckpoint(ResourceStore.java:318)
>      at 
> org.apache.kylin.common.persistence.ResourceStore.putResource(ResourceStore.java:303)
>      at 
> org.apache.kylin.common.persistence.ResourceStore.putResource(ResourceStore.java:282)
>      at 
> org.apache.kylin.metadata.cachesync.CachedCrudAssist.save(CachedCrudAssist.java:192){code}
>  
> what disturbs me the most was that the error was happened several hours,  
> then my all build job and query job failed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3562) TS conflict when kylin update metadata in HBase

2019-04-16 Thread zhao jintao (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16819675#comment-16819675
 ] 

zhao jintao commented on KYLIN-3562:


Hi, [~Aron.tao],[~Shaofengshi]:

I want to know why save user information  to HBase  after user login?

User authentication is in kylin process,it is not necessary to save the user to 
HBase.

In kylin-cluster mode, if same user login kylin in multiple nodes at the same 
time, multiple nodes simultaneously save user information to HBase, This is 
easy to cause “Overwriting conflict” error.

In my Kylin System, I use kylin jdbc  to access kylin-cluster and query sql. 
But sometimes kylin mistakes and throw 500 error code exception. I removed the 
mechanism of saving to HBase after login kylin, Then it works fine.

> TS conflict when kylin update metadata in HBase
> ---
>
> Key: KYLIN-3562
> URL: https://issues.apache.org/jira/browse/KYLIN-3562
> Project: Kylin
>  Issue Type: Bug
>Affects Versions: v2.4.0
>Reporter: Lingang Deng
>Assignee: Jiatao Tao
>Priority: Major
> Fix For: v2.4.2, v2.5.1
>
> Attachments: image-2018-09-17-16-40-56-212.png, 
> image-2018-09-25-15-03-51-009.png, image-2018-09-25-16-43-50-277.png
>
>
> Error log was as follows,
> {code:java}
> org.apache.kylin.common.persistence.WriteConflictException: Overwriting 
> conflict /user/admin, expect old TS 1536928877043, but it is 1536928907207
>      at 
> org.apache.kylin.storage.hbase.HBaseResourceStore.checkAndPutResourceImpl(HBaseResourceStore.java:325)
>      at 
> org.apache.kylin.common.persistence.ResourceStore.checkAndPutResourceCheckpoint(ResourceStore.java:318)
>      at 
> org.apache.kylin.common.persistence.ResourceStore.putResource(ResourceStore.java:303)
>      at 
> org.apache.kylin.common.persistence.ResourceStore.putResource(ResourceStore.java:282)
>      at 
> org.apache.kylin.metadata.cachesync.CachedCrudAssist.save(CachedCrudAssist.java:192){code}
>  
> what disturbs me the most was that the error was happened several hours,  
> then my all build job and query job failed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3562) TS conflict when kylin update metadata in HBase

2019-04-16 Thread zhao jintao (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16819672#comment-16819672
 ] 

zhao jintao commented on KYLIN-3562:


Hi, [~Aron.tao],[~Shaofengshi]:

I want to know why save user information  to HBase when user authentication?

user authenticate is in kylin process,it is not necessary to save the user to 
HBase.


In kylin-cluster mode, if same user login kylin in multiple nodes at the same 
time, multiple nodes simultaneously save user information to HBase, This is 
easy to cause “Overwriting conflict” error.

In my Kylin System, I use kylin jdbc  to access kylin-cluster and query sql. 
But sometimes kylin mistakes and throw 500 error code exception. I removed the 
mechanism of saving to HBase after login kylin, Then it works fine.

> TS conflict when kylin update metadata in HBase
> ---
>
> Key: KYLIN-3562
> URL: https://issues.apache.org/jira/browse/KYLIN-3562
> Project: Kylin
>  Issue Type: Bug
>Affects Versions: v2.4.0
>Reporter: Lingang Deng
>Assignee: Jiatao Tao
>Priority: Major
> Fix For: v2.4.2, v2.5.1
>
> Attachments: image-2018-09-17-16-40-56-212.png, 
> image-2018-09-25-15-03-51-009.png, image-2018-09-25-16-43-50-277.png
>
>
> Error log was as follows,
> {code:java}
> org.apache.kylin.common.persistence.WriteConflictException: Overwriting 
> conflict /user/admin, expect old TS 1536928877043, but it is 1536928907207
>      at 
> org.apache.kylin.storage.hbase.HBaseResourceStore.checkAndPutResourceImpl(HBaseResourceStore.java:325)
>      at 
> org.apache.kylin.common.persistence.ResourceStore.checkAndPutResourceCheckpoint(ResourceStore.java:318)
>      at 
> org.apache.kylin.common.persistence.ResourceStore.putResource(ResourceStore.java:303)
>      at 
> org.apache.kylin.common.persistence.ResourceStore.putResource(ResourceStore.java:282)
>      at 
> org.apache.kylin.metadata.cachesync.CachedCrudAssist.save(CachedCrudAssist.java:192){code}
>  
> what disturbs me the most was that the error was happened several hours,  
> then my all build job and query job failed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] [kylin] coveralls commented on issue #609: KYLIN-3959 shutdown query cache for realtime olap

2019-04-16 Thread GitBox
coveralls commented on issue #609: KYLIN-3959 shutdown query cache for realtime 
olap
URL: https://github.com/apache/kylin/pull/609#issuecomment-483605779
 
 
   ## Pull Request Test Coverage Report for [Build 
4396](https://coveralls.io/builds/22839061)
   
   * **0** of **13**   **(0.0%)**  changed or added relevant lines in **1** 
file are covered.
   * **10** unchanged lines in **4** files lost coverage.
   * Overall coverage decreased (**-0.009%**) to **27.75%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-|--||---: |
   | 
[server-base/src/main/java/org/apache/kylin/rest/service/QueryService.java](https://coveralls.io/builds/22839061/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FQueryService.java#L485)
 | 0 | 13 | 0.0%
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-|--|--: |
   | 
[core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://coveralls.io/builds/22839061/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2Flookup%2Fcache%2FRocksDBLookupTable.java#L62)
 | 1 | 81.08% |
   | 
[stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/ColumnarStoreCache.java](https://coveralls.io/builds/22839061/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2Fcolumnar%2FColumnarStoreCache.java#L71)
 | 2 | 55.81% |
   | 
[core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java](https://coveralls.io/builds/22839061/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2Fimpl%2Fthreadpool%2FDefaultScheduler.java#L194)
 | 2 | 80.23% |
   | 
[core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/22839061/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L439)
 | 5 | 77.81% |
   
   
   |  Totals | [![Coverage 
Status](https://coveralls.io/builds/22839061/badge)](https://coveralls.io/builds/22839061)
 |
   | :-- | --: |
   | Change from base [Build 4393](https://coveralls.io/builds/22832303): |  
-0.009% |
   | Covered Lines: | 22681 |
   | Relevant Lines: | 81732 |
   
   ---
   #   - [Coveralls](https://coveralls.io)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (KYLIN-3959) Realtime OLAP query result should not be cached

2019-04-16 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16818809#comment-16818809
 ] 

ASF GitHub Bot commented on KYLIN-3959:
---

hit-lacus commented on pull request #609: KYLIN-3959 shutdown query cache for 
realtime olap
URL: https://github.com/apache/kylin/pull/609
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Realtime OLAP query result should not be cached
> ---
>
> Key: KYLIN-3959
> URL: https://issues.apache.org/jira/browse/KYLIN-3959
> Project: Kylin
>  Issue Type: Bug
>  Components: Real-time Streaming
>Affects Versions: v3.0.0-alpha
>Reporter: XiaoXiang Yu
>Assignee: XiaoXiang Yu
>Priority: Major
> Fix For: v3.0.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] [kylin] asfgit commented on issue #609: KYLIN-3959 shutdown query cache for realtime olap

2019-04-16 Thread GitBox
asfgit commented on issue #609: KYLIN-3959 shutdown query cache for realtime 
olap
URL: https://github.com/apache/kylin/pull/609#issuecomment-483578874
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [kylin] hit-lacus opened a new pull request #609: KYLIN-3959 shutdown query cache for realtime olap

2019-04-16 Thread GitBox
hit-lacus opened a new pull request #609: KYLIN-3959 shutdown query cache for 
realtime olap
URL: https://github.com/apache/kylin/pull/609
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Created] (KYLIN-3959) Realtime OLAP query result should not be cached

2019-04-16 Thread XiaoXiang Yu (JIRA)
XiaoXiang Yu created KYLIN-3959:
---

 Summary: Realtime OLAP query result should not be cached
 Key: KYLIN-3959
 URL: https://issues.apache.org/jira/browse/KYLIN-3959
 Project: Kylin
  Issue Type: Bug
  Components: Real-time Streaming
Affects Versions: v3.0.0-alpha
Reporter: XiaoXiang Yu
Assignee: XiaoXiang Yu
 Fix For: v3.0.0






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3948) org.apache.hadoop.hive.metastore.HiveMetaStoreClint.(Lorg/apache/hadoop/conf/configuration;)V

2019-04-16 Thread Chao Long (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16818761#comment-16818761
 ] 

Chao Long commented on KYLIN-3948:
--

Hi [~praveenece], you can try to use the latest binary for 
hadoop3(apache-kylin-2.6.1-bin-hadoop3.tar.gz).

> org.apache.hadoop.hive.metastore.HiveMetaStoreClint.(Lorg/apache/hadoop/conf/configuration;)V
> ---
>
> Key: KYLIN-3948
> URL: https://issues.apache.org/jira/browse/KYLIN-3948
> Project: Kylin
>  Issue Type: Test
>  Components: Environment 
>Affects Versions: v2.5.2
> Environment: hadoop-3.1.1
> apache-hive-2.3.4-bin
> hbase-2.1.1
> apache-kylin-2.5.2-bin-hadoop3
>Reporter: praveenece
>Priority: Critical
>
> hadoop-3.1.1
> apache-hive-2.3.4-bin
> hbase-2.1.1
> apache-kylin-2.5.2-bin-hadoop3
> Now I tried with above environment, kylin is stated but i unable to load 
> metadata from hbase to kylin getting this below error in kylin UI.
> org.apache.hadoop.hive.metastore.HiveMetaStoreClint.(Lorg/apache/hadoop/conf/configuration;)V
> 2019-04-09 15:02:44,979 DEBUG [http-nio-7070-exec-9] common.KylinConfig:327 : 
> KYLIN_CONF property was not set, will seek KYLIN_HOME env variable
> 2019-04-09 15:02:50,071 ERROR [http-nio-7070-exec-6] 
> controller.TableController:190 : 
> org.apache.hadoop.hive.metastore.HiveMetaStoreClient.(Lorg/apache/hadoop/conf/Configuration;)V
> java.lang.NoSuchMethodError: 
> org.apache.hadoop.hive.metastore.HiveMetaStoreClient.(Lorg/apache/hadoop/conf/Configuration;)V
> at 
> org.apache.kylin.source.hive.CLIHiveClient.getMetaStoreClient(CLIHiveClient.java:132)
> at 
> org.apache.kylin.source.hive.CLIHiveClient.getHiveDbNames(CLIHiveClient.java:116)
> at 
> org.apache.kylin.source.hive.HiveMetadataExplorer.listDatabases(HiveMetadataExplorer.java:47)
> at 
> org.apache.kylin.rest.service.TableService.getSourceDbNames(TableService.java:277)
> at 
> org.apache.kylin.rest.controller.TableController.showHiveDatabases(TableController.java:188)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at 
> org.springframework.web.method.support.InvocableHandlerMethod.doInvoke(InvocableHandlerMethod.java:205)
> at 
> org.springframework.web.method.support.InvocableHandlerMethod.invokeForRequest(InvocableHandlerMethod.java:133)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] [kylin] codecov-io edited a comment on issue #605: KYLIN-3942 Support multi-level json event in backend

2019-04-16 Thread GitBox
codecov-io edited a comment on issue #605: KYLIN-3942 Support multi-level json 
event in backend
URL: https://github.com/apache/kylin/pull/605#issuecomment-483026163
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/605?src=pr=h1) Report
   > Merging [#605](https://codecov.io/gh/apache/kylin/pull/605?src=pr=desc) 
into 
[master](https://codecov.io/gh/apache/kylin/commit/595c4e2112afeaea8c2881626959e37bbed50c84?src=pr=desc)
 will **increase** coverage by `0.05%`.
   > The diff coverage is `80%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/kylin/pull/605/graphs/tree.svg?width=650=JawVgbgsVo=150=pr)](https://codecov.io/gh/apache/kylin/pull/605?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master #605  +/-   ##
   
   + Coverage 25.28%   25.34%   +0.05% 
   - Complexity 5825 5836  +11 
   
 Files  1379 1379  
 Lines 8172081754  +34 
 Branches  1144411452   +8 
   
   + Hits  2066620719  +53 
   + Misses5903959012  -27 
   - Partials   2015 2023   +8
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/kylin/pull/605?src=pr=tree) | Coverage Δ 
| Complexity Δ | |
   |---|---|---|---|
   | 
[...n/stream/source/kafka/consumer/KafkaConnector.java](https://codecov.io/gh/apache/kylin/pull/605/diff?src=pr=tree#diff-c3RyZWFtLXNvdXJjZS1rYWZrYS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RyZWFtL3NvdXJjZS9rYWZrYS9jb25zdW1lci9LYWZrYUNvbm5lY3Rvci5qYXZh)
 | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | 
[...lin/stream/source/kafka/TimedJsonStreamParser.java](https://codecov.io/gh/apache/kylin/pull/605/diff?src=pr=tree#diff-c3RyZWFtLXNvdXJjZS1rYWZrYS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RyZWFtL3NvdXJjZS9rYWZrYS9UaW1lZEpzb25TdHJlYW1QYXJzZXIuamF2YQ==)
 | `76.71% <83.72%> (+76.71%)` | `12 <8> (+12)` | :arrow_up: |
   | 
[...he/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://codecov.io/gh/apache/kylin/pull/605/diff?src=pr=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGUuamF2YQ==)
 | `72.97% <0%> (-5.41%)` | `6% <0%> (-1%)` | |
   | 
[...ream/core/storage/columnar/ColumnarStoreCache.java](https://codecov.io/gh/apache/kylin/pull/605/diff?src=pr=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvQ29sdW1uYXJTdG9yZUNhY2hlLmphdmE=)
 | `48.83% <0%> (-3.49%)` | `7% <0%> (ø)` | |
   | 
[...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/605/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh)
 | `70.21% <0%> (+0.6%)` | `7% <0%> (ø)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/kylin/pull/605?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/kylin/pull/605?src=pr=footer). Last 
update 
[595c4e2...fb5fafe](https://codecov.io/gh/apache/kylin/pull/605?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [kylin] coveralls edited a comment on issue #605: KYLIN-3942 Support multi-level json event in backend

2019-04-16 Thread GitBox
coveralls edited a comment on issue #605: KYLIN-3942 Support multi-level json 
event in backend
URL: https://github.com/apache/kylin/pull/605#issuecomment-483025205
 
 
   ## Pull Request Test Coverage Report for [Build 
4394](https://coveralls.io/builds/22834192)
   
   * **40** of **45**   **(88.89%)**  changed or added relevant lines in **2** 
files are covered.
   * **3** unchanged lines in **2** files lost coverage.
   * Overall coverage increased (+**0.06%**) to **27.822%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-|--||---: |
   | 
[stream-source-kafka/src/main/java/org/apache/kylin/stream/source/kafka/consumer/KafkaConnector.java](https://coveralls.io/builds/22834192/source?filename=stream-source-kafka%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fsource%2Fkafka%2Fconsumer%2FKafkaConnector.java#L111)
 | 0 | 2 | 0.0%
   | 
[stream-source-kafka/src/main/java/org/apache/kylin/stream/source/kafka/TimedJsonStreamParser.java](https://coveralls.io/builds/22834192/source?filename=stream-source-kafka%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fsource%2Fkafka%2FTimedJsonStreamParser.java#L75)
 | 40 | 43 | 93.02%
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-|--|--: |
   | 
[core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://coveralls.io/builds/22834192/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2Flookup%2Fcache%2FRocksDBLookupTable.java#L62)
 | 1 | 81.08% |
   | 
[stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/ColumnarStoreCache.java](https://coveralls.io/builds/22834192/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2Fcolumnar%2FColumnarStoreCache.java#L71)
 | 2 | 55.81% |
   
   
   |  Totals | [![Coverage 
Status](https://coveralls.io/builds/22834192/badge)](https://coveralls.io/builds/22834192)
 |
   | :-- | --: |
   | Change from base [Build 4393](https://coveralls.io/builds/22832303): |  
0.06% |
   | Covered Lines: | 22746 |
   | Relevant Lines: | 81754 |
   
   ---
   #   - [Coveralls](https://coveralls.io)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [kylin] hit-lacus commented on issue #605: KYLIN-3942 Support multi-level json event in backend

2019-04-16 Thread GitBox
hit-lacus commented on issue #605: KYLIN-3942 Support multi-level json event in 
backend
URL: https://github.com/apache/kylin/pull/605#issuecomment-483529232
 
 
   After disscussion, I use `ParseInfo`'s `columnToSourceFieldMapping` to parse 
multi-level json event.
   
   
![企业微信截图_36c7f0aa-3f32-4c27-bf6f-0801a393e2ed](https://user-images.githubusercontent.com/14030549/56187064-13f73c00-6054-11e9-99d6-53bdc914b0da.png)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services