[jira] [Commented] (KYLIN-4002) Cleanup job does not delete Hive intermediate VIEW tables
[
https://issues.apache.org/jira/browse/KYLIN-4002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16840306#comment-16840306
]
Na Zhai commented on KYLIN-4002:
Hi, [~inigoml]
I can not reproduce your situation. I use the following sql to create the
view. Then build cubes using these two views as the fact table.
{code:sql}
CREATE VIEW IF NOT EXISTS kylin_sales_view (trans_num, cal_dt, lf_name) as
select trans_id, part_dt, lstg_format_name from kylin_sales limit 800;{code}
{code:sql}
CREATE VIEW IF NOT EXISTS ks_view_view (t_id, l_format_name) as select
trans_num, lf_name from kylin_sales_view limit 500;{code}
And StorageCleanupJob can delete hive intermediate tables that based on these
two views.
> Cleanup job does not delete Hive intermediate VIEW tables
> --
>
> Key: KYLIN-4002
> URL: https://issues.apache.org/jira/browse/KYLIN-4002
> Project: Kylin
> Issue Type: Bug
> Components: Job Engine
>Affects Versions: v2.6.1
>Reporter: Iñigo Martinez
>Priority: Major
>
> Kylin org.apache.kylin.tool.StorageCleanupJob does not delete hive
> intermediate tables if they are view based.
> After several weeks running Kylin 2.6.1 after a successful upgrade from
> 2.4.1, we have a lot of temporary tables that have not been deleted. All of
> them come from a VIEW.
> However, those tables built directly from a table and not from a view, are
> properly deleted.
> Tables from view not deleted: 263079
> Tables not form view not deleted: 0
>
> At log level, we can see:
> {code:java}
> 2019-05-14 08:10:00,293 DEBUG [main] job.StorageCleanupJob:326 : Checking if
> table is garbage --
> kylin_intermediate_dw_di_paises_view_238e3004_13e8_2be6_5f0e_df545b481986
> 2019-05-14 10:17:53,235 INFO [main] job.StorageCleanupJob:407 : Deleting Hive
> table
> kylin_intermediate_dw_di_paises_view_238e3004_13e8_2be6_5f0e_df545b481986
> drop table if exists
> kylin_intermediate_dw_di_paises_view_238e3004_13e8_2be6_5f0e_df545b481986;{code}
> So, it's properly detected and drop sentence properly created. But it's not
> executed and table is still there.
> We have launched the 263079 drop sentences via script and all are being
> removed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [kylin] nichunen merged pull request #619: #KYLIN-3977
nichunen merged pull request #619: #KYLIN-3977 URL: https://github.com/apache/kylin/pull/619 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (KYLIN-3977) Aviod mistaken deleting dicts by storage cleanup while building jobs are running
[ https://issues.apache.org/jira/browse/KYLIN-3977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16840397#comment-16840397 ] ASF subversion and git services commented on KYLIN-3977: Commit bb44678f11a830c13d1550d8510e303132cf176f in kylin's branch refs/heads/master from PENG Zhengshuai [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=bb44678 ] #KYLIN-3977 Aviod mistaken deleting dicts by storage cleanup while building jobs are running * #KYLIN-3977, Aviod mistaken deleting dicts by storage cleanup while building jobs are running > Aviod mistaken deleting dicts by storage cleanup while building jobs are > running > > > Key: KYLIN-3977 > URL: https://issues.apache.org/jira/browse/KYLIN-3977 > Project: Kylin > Issue Type: Improvement > Components: Metadata >Reporter: PENG Zhengshuai >Assignee: PENG Zhengshuai >Priority: Major > > When there are cube building jobs running, storage cleanup may delete some > dictionaries which the cubes are not referenced to. But the in build jobs, > those dictionaries may be reused. > If these reused dictionaries have been deleted by storage cleanup, the build > job will be failed -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3977) Aviod mistaken deleting dicts by storage cleanup while building jobs are running
[ https://issues.apache.org/jira/browse/KYLIN-3977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16840396#comment-16840396 ] ASF GitHub Bot commented on KYLIN-3977: --- nichunen commented on pull request #619: #KYLIN-3977 URL: https://github.com/apache/kylin/pull/619 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Aviod mistaken deleting dicts by storage cleanup while building jobs are > running > > > Key: KYLIN-3977 > URL: https://issues.apache.org/jira/browse/KYLIN-3977 > Project: Kylin > Issue Type: Improvement > Components: Metadata >Reporter: PENG Zhengshuai >Assignee: PENG Zhengshuai >Priority: Major > > When there are cube building jobs running, storage cleanup may delete some > dictionaries which the cubes are not referenced to. But the in build jobs, > those dictionaries may be reused. > If these reused dictionaries have been deleted by storage cleanup, the build > job will be failed -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3977) Aviod mistaken deleting dicts by storage cleanup while building jobs are running
[ https://issues.apache.org/jira/browse/KYLIN-3977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16840398#comment-16840398 ] ASF subversion and git services commented on KYLIN-3977: Commit bb44678f11a830c13d1550d8510e303132cf176f in kylin's branch refs/heads/master from PENG Zhengshuai [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=bb44678 ] #KYLIN-3977 Aviod mistaken deleting dicts by storage cleanup while building jobs are running * #KYLIN-3977, Aviod mistaken deleting dicts by storage cleanup while building jobs are running > Aviod mistaken deleting dicts by storage cleanup while building jobs are > running > > > Key: KYLIN-3977 > URL: https://issues.apache.org/jira/browse/KYLIN-3977 > Project: Kylin > Issue Type: Improvement > Components: Metadata >Reporter: PENG Zhengshuai >Assignee: PENG Zhengshuai >Priority: Major > > When there are cube building jobs running, storage cleanup may delete some > dictionaries which the cubes are not referenced to. But the in build jobs, > those dictionaries may be reused. > If these reused dictionaries have been deleted by storage cleanup, the build > job will be failed -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3971) InternalErrorException thrown when querying cube with TOP_N measure
[
https://issues.apache.org/jira/browse/KYLIN-3971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16840403#comment-16840403
]
Na Zhai commented on KYLIN-3971:
Hi. [~grzegorz_kolakowski].
Yes, you need to add sum measure. In this page
[http://kylin.apache.org/docs/tutorial/create_cube.html], you can search for
the top_n usage method.
> InternalErrorException thrown when querying cube with TOP_N measure
> ---
>
> Key: KYLIN-3971
> URL: https://issues.apache.org/jira/browse/KYLIN-3971
> Project: Kylin
> Issue Type: Bug
>Affects Versions: v2.6.1
>Reporter: Grzegorz Kołakowski
>Priority: Major
> Attachments: top_n_measure.png
>
>
> I have created a cube with only one measure TOP_N (except mandatory
> `_COUNT_`) and several dimensions.
> !top_n_measure.png!
> When I query it:
> {noformat}
> SELECT
> "DIC_ARTICLE"."SUPPLIER_NAME" AS "SUPPLIER_NAME",
> SUM("KYLIN_TICKETS"."SALE_VALUE") AS "X__alias__0"
> FROM
> "REPORT_SALES"."KYLIN_TICKETS" "KYLIN_TICKETS"
> LEFT JOIN
> "REPORT_SALES"."DIC_ARTICLE" "DIC_ARTICLE" ON
> ("KYLIN_TICKETS"."ID_ARTICLE" = "DIC_ARTICLE"."ID_ARTICLE")
> LEFT JOIN
> "REPORT_SALES"."KYLIN_DIC_STORE" "KYLIN_DIC_STORE" ON
> ("KYLIN_TICKETS"."ID_STORE" = "KYLIN_DIC_STORE"."ID_STORE")
> WHERE
> "KYLIN_TICKETS"."WORKING_DATE" = '2019-01-02'
> GROUP BY
> "DIC_ARTICLE"."SUPPLIER_NAME"
> ORDER BY
> "X__alias__0" DESC
> {noformat}
> I get the following exception:
> {noformat}
> 2019-04-23 09:10:46,618 ERROR [http-nio-7070-exec-3]
> controller.BasicController:63 :
> org.apache.kylin.rest.exception.InternalErrorException: RowType=91,
> ColumnRowType=90
> while executing SQL: "SELECT "DIC_ARTICLE"."SUPPLIER_NAME" AS
> "SUPPLIER_NAME", SUM("KYLIN_TICKETS"."SALE_VALUE") AS
> "X__alias__0"FROM "REPORT_SALES"."KYLIN_TICKETS"
> "KYLIN_TICKETS" LEFT JOIN "REPORT_SALES"."DIC_ARTICLE" "DIC_ARTICLE"
> ON ("KYLIN_TICKETS"."ID_ARTICLE" = "DIC_ARTICLE"."ID_ARTICLE") LEFT
> JOIN "REPORT_SALES"."KYLIN_DIC_STORE" "KYLIN_DIC_STORE" ON
> ("KYLIN_TICKETS"."ID_STORE" = "KYLIN_DIC_STORE"."ID_STORE")WHERE
>"KYLIN_TICKETS"."WORKING_DATE" = '2019-01-02' GROUP BY
> "DIC_ARTICLE"."SUPPLIER_NAME" ORDER BY "X__alias__0" DESC LIMIT 5"
> at
> org.apache.kylin.rest.service.QueryService.doQueryWithCache(QueryService.java:441)
> at
> org.apache.kylin.rest.service.QueryService.doQueryWithCache(QueryService.java:367)
> at
> org.apache.kylin.rest.controller.QueryController.query(QueryController.java:87)
> at sun.reflect.GeneratedMethodAccessor186.invoke(Unknown Source)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.springframework.web.method.support.InvocableHandlerMethod.doInvoke(InvocableHandlerMethod.java:205)
> at
> org.springframework.web.method.support.InvocableHandlerMethod.invokeForRequest(InvocableHandlerMethod.java:133)
> at
> org.springframework.web.servlet.mvc.method.annotation.ServletInvocableHandlerMethod.invokeAndHandle(ServletInvocableHandlerMethod.java:97)
> at
> org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.invokeHandlerMethod(RequestMappingHandlerAdapter.java:827)
> at
> org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.handleInternal(RequestMappingHandlerAdapter.java:738)
> at
> org.springframework.web.servlet.mvc.method.AbstractHandlerMethodAdapter.handle(AbstractHandlerMethodAdapter.java:85)
> at
> org.springframework.web.servlet.DispatcherServlet.doDispatch(DispatcherServlet.java:967)
> at
> org.springframework.web.servlet.DispatcherServlet.doService(DispatcherServlet.java:901)
> at
> org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:970)
> at
> org.springframework.web.servlet.FrameworkServlet.doPost(FrameworkServlet.java:872)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:661)
> at
> org.springframework.web.servlet.FrameworkServlet.service(FrameworkServlet.java:846)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:742)
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:231)
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
> at
> org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52)
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
[GitHub] [kylin] nichunen commented on issue #640: Add unit tests four
nichunen commented on issue #640: Add unit tests four URL: https://github.com/apache/kylin/pull/640#issuecomment-492676891 Hi @TheRealHaui It seems that you do not set "import order" in your IDE with file "core-common/.settings/org.eclipse.jdt.core.prefs", with this setting, java.* should be above of org.* This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] TheRealHaui commented on issue #640: Add unit tests four
TheRealHaui commented on issue #640: Add unit tests four URL: https://github.com/apache/kylin/pull/640#issuecomment-492703100 @nichunen, I reordered the import statements like Eclipse does. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] TheRealHaui edited a comment on issue #640: Add unit tests four
TheRealHaui edited a comment on issue #640: Add unit tests four URL: https://github.com/apache/kylin/pull/640#issuecomment-492703100 @nichunen, I am using Intellij but I reordered the import statements like Eclipse does. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] TheRealHaui commented on issue #640: Add unit tests four
TheRealHaui commented on issue #640: Add unit tests four URL: https://github.com/apache/kylin/pull/640#issuecomment-492732082 Obviously Travis has crashed or at least hangs. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] codecov-io edited a comment on issue #640: Add unit tests four
codecov-io edited a comment on issue #640: Add unit tests four URL: https://github.com/apache/kylin/pull/640#issuecomment-492119779 # [Codecov](https://codecov.io/gh/apache/kylin/pull/640?src=pr&el=h1) Report > Merging [#640](https://codecov.io/gh/apache/kylin/pull/640?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/20fa8b1530e0d09f4393242db282dff43b930b00?src=pr&el=desc) will **increase** coverage by `0.19%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/kylin/pull/640?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#640 +/- ## === + Coverage 25.5% 25.7% +0.19% - Complexity 59005975 +75 === Files 13791379 Lines 81871 82103 +232 Branches 11479 11509 +30 === + Hits 20883 21105 +222 + Misses58960 58957 -3 - Partials 20282041 +13 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/640?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...he/kylin/common/persistence/HDFSResourceStore.java](https://codecov.io/gh/apache/kylin/pull/640/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9wZXJzaXN0ZW5jZS9IREZTUmVzb3VyY2VTdG9yZS5qYXZh) | `18.65% <0%> (-2.53%)` | `5% <0%> (ø)` | | | [.../org/apache/kylin/rest/job/MetadataCleanupJob.java](https://codecov.io/gh/apache/kylin/pull/640/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvam9iL01ldGFkYXRhQ2xlYW51cEpvYi5qYXZh) | `66.42% <0%> (-0.91%)` | `26% <0%> (+2%)` | | | [...a/org/apache/kylin/dict/Number2BytesConverter.java](https://codecov.io/gh/apache/kylin/pull/640/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L051bWJlcjJCeXRlc0NvbnZlcnRlci5qYXZh) | `81.74% <0%> (-0.8%)` | `17% <0%> (-1%)` | | | [...in/storage/hbase/cube/v2/CubeHBaseEndpointRPC.java](https://codecov.io/gh/apache/kylin/pull/640/diff?src=pr&el=tree#diff-c3RvcmFnZS1oYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9oYmFzZS9jdWJlL3YyL0N1YmVIQmFzZUVuZHBvaW50UlBDLmphdmE=) | `7.91% <0%> (-0.03%)` | `4% <0%> (ø)` | | | [...che/kylin/engine/mr/steps/CreateDictionaryJob.java](https://codecov.io/gh/apache/kylin/pull/640/diff?src=pr&el=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvc3RlcHMvQ3JlYXRlRGljdGlvbmFyeUpvYi5qYXZh) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: | | [.../apache/kylin/cube/cli/DictionaryGeneratorCLI.java](https://codecov.io/gh/apache/kylin/pull/640/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2NsaS9EaWN0aW9uYXJ5R2VuZXJhdG9yQ0xJLmphdmE=) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: | | [...ache/kylin/common/persistence/JDBCResourceSQL.java](https://codecov.io/gh/apache/kylin/pull/640/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9wZXJzaXN0ZW5jZS9KREJDUmVzb3VyY2VTUUwuamF2YQ==) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: | | [...apache/kylin/storage/hbase/HBaseResourceStore.java](https://codecov.io/gh/apache/kylin/pull/640/diff?src=pr&el=tree#diff-c3RvcmFnZS1oYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9oYmFzZS9IQmFzZVJlc291cmNlU3RvcmUuamF2YQ==) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: | | [...he/kylin/common/persistence/JDBCResourceStore.java](https://codecov.io/gh/apache/kylin/pull/640/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9wZXJzaXN0ZW5jZS9KREJDUmVzb3VyY2VTdG9yZS5qYXZh) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: | | [...ylin/common/persistence/PushdownResourceStore.java](https://codecov.io/gh/apache/kylin/pull/640/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9wZXJzaXN0ZW5jZS9QdXNoZG93blJlc291cmNlU3RvcmUuamF2YQ==) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: | | ... and [11 more](https://codecov.io/gh/apache/kylin/pull/640/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/640?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/640?src=pr&el=footer). Last update [20fa8b1...48da176](https://codecov.io/gh/apache/kylin/pull/640?src=pr&el=lastupdated). Read the [comment docs](https:
[GitHub] [kylin] coveralls commented on issue #640: Add unit tests four
coveralls commented on issue #640: Add unit tests four URL: https://github.com/apache/kylin/pull/640#issuecomment-492734397 ## Pull Request Test Coverage Report for [Build 4497](https://coveralls.io/builds/23407874) * **0** of **0** changed or added relevant lines in **0** files are covered. * **557** unchanged lines in **14** files lost coverage. * Overall coverage increased (+**0.2%**) to **28.195%** --- | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [storage-hbase/src/main/java/org/apache/kylin/storage/hbase/cube/v2/CubeHBaseEndpointRPC.java](https://coveralls.io/builds/23407874/source?filename=storage-hbase%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fhbase%2Fcube%2Fv2%2FCubeHBaseEndpointRPC.java#L568) | 3 | 7.91% | | [core-common/src/main/java/org/apache/kylin/common/persistence/FileResourceStore.java](https://coveralls.io/builds/23407874/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Fpersistence%2FFileResourceStore.java#L200) | 4 | 77.55% | | [engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/CreateDictionaryJob.java](https://coveralls.io/builds/23407874/source?filename=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2Fsteps%2FCreateDictionaryJob.java#L98) | 7 | 0.0% | | [core-common/src/main/java/org/apache/kylin/common/persistence/PushdownResourceStore.java](https://coveralls.io/builds/23407874/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Fpersistence%2FPushdownResourceStore.java#L207) | 8 | 0.0% | | [core-common/src/main/java/org/apache/kylin/common/persistence/JDBCResourceSQL.java](https://coveralls.io/builds/23407874/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Fpersistence%2FJDBCResourceSQL.java#L40) | 13 | 0.0% | | [core-dictionary/src/main/java/org/apache/kylin/dict/lookup/SnapshotManager.java](https://coveralls.io/builds/23407874/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2Flookup%2FSnapshotManager.java#L87) | 17 | 75.0% | | [core-common/src/main/java/org/apache/kylin/common/persistence/HDFSResourceStore.java](https://coveralls.io/builds/23407874/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Fpersistence%2FHDFSResourceStore.java#L265) | 18 | 21.64% | | [server-base/src/main/java/org/apache/kylin/rest/job/MetadataCleanupJob.java](https://coveralls.io/builds/23407874/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fjob%2FMetadataCleanupJob.java#L76) | 38 | 71.53% | | [core-common/src/main/java/org/apache/kylin/common/persistence/JDBCResourceStore.java](https://coveralls.io/builds/23407874/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Fpersistence%2FJDBCResourceStore.java#L506) | 48 | 0.0% | | [core-common/src/main/java/org/apache/kylin/common/persistence/ResourceStore.java](https://coveralls.io/builds/23407874/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Fpersistence%2FResourceStore.java#L202) | 56 | 76.9% | | Totals | [](https://coveralls.io/builds/23407874) | | :-- | --: | | Change from base [Build 4495](https://coveralls.io/builds/23392647): | 0.2% | | Covered Lines: | 23149 | | Relevant Lines: | 82103 | --- # 💛 - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] TheRealHaui opened a new pull request #643: Small performance improvements
TheRealHaui opened a new pull request #643: Small performance improvements URL: https://github.com/apache/kylin/pull/643 Small performance improvements This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] asfgit commented on issue #643: Small performance improvements
asfgit commented on issue #643: Small performance improvements URL: https://github.com/apache/kylin/pull/643#issuecomment-492746474 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] codecov-io commented on issue #643: Small performance improvements
codecov-io commented on issue #643: Small performance improvements URL: https://github.com/apache/kylin/pull/643#issuecomment-492757761 # [Codecov](https://codecov.io/gh/apache/kylin/pull/643?src=pr&el=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@bb44678`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is `0%`. [](https://codecov.io/gh/apache/kylin/pull/643?src=pr&el=tree) ```diff @@Coverage Diff@@ ## master #643 +/- ## = Coverage ? 25.66% Complexity? 5956 = Files ? 1379 Lines ?82097 Branches ?11507 = Hits ?21068 Misses?58988 Partials ? 2041 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/643?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ache/kylin/engine/mr/common/AbstractHadoopJob.java](https://codecov.io/gh/apache/kylin/pull/643/diff?src=pr&el=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvY29tbW9uL0Fic3RyYWN0SGFkb29wSm9iLmphdmE=) | `15.25% <0%> (ø)` | `2 <0> (?)` | | | [...org/apache/kylin/common/util/ClasspathScanner.java](https://codecov.io/gh/apache/kylin/pull/643/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi91dGlsL0NsYXNzcGF0aFNjYW5uZXIuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...n/engine/mr/steps/lookup/LookupExecutableUtil.java](https://codecov.io/gh/apache/kylin/pull/643/diff?src=pr&el=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvc3RlcHMvbG9va3VwL0xvb2t1cEV4ZWN1dGFibGVVdGlsLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...kylin/engine/mr/common/HadoopJobStatusChecker.java](https://codecov.io/gh/apache/kylin/pull/643/diff?src=pr&el=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvY29tbW9uL0hhZG9vcEpvYlN0YXR1c0NoZWNrZXIuamF2YQ==) | `12.5% <0%> (ø)` | `3 <0> (?)` | | | [.../main/java/org/apache/kylin/common/util/Bytes.java](https://codecov.io/gh/apache/kylin/pull/643/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi91dGlsL0J5dGVzLmphdmE=) | `1.01% <0%> (ø)` | `3 <0> (?)` | | | [...ylin/cache/cachemanager/MemcachedCacheManager.java](https://codecov.io/gh/apache/kylin/pull/643/diff?src=pr&el=tree#diff-Y2FjaGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NhY2hlL2NhY2hlbWFuYWdlci9NZW1jYWNoZWRDYWNoZU1hbmFnZXIuamF2YQ==) | `43.33% <0%> (ø)` | `7 <0> (?)` | | | [...java/org/apache/kylin/common/util/MailService.java](https://codecov.io/gh/apache/kylin/pull/643/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi91dGlsL01haWxTZXJ2aWNlLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...kylin/storage/gtrecord/GTCubeStorageQueryBase.java](https://codecov.io/gh/apache/kylin/pull/643/diff?src=pr&el=tree#diff-Y29yZS1zdG9yYWdlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9zdG9yYWdlL2d0cmVjb3JkL0dUQ3ViZVN0b3JhZ2VRdWVyeUJhc2UuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/643?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/643?src=pr&el=footer). Last update [bb44678...addc83d](https://codecov.io/gh/apache/kylin/pull/643?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (KYLIN-4003) Get java.sql.SQLException: No suitable driver found when use DriverManager.getConnection("jdbc:kylin://
wei su created KYLIN-4003:
-
Summary: Get java.sql.SQLException: No suitable driver found when
use DriverManager.getConnection("jdbc:kylin://
Key: KYLIN-4003
URL: https://issues.apache.org/jira/browse/KYLIN-4003
Project: Kylin
Issue Type: Bug
Components: Driver - JDBC
Affects Versions: v2.6.1
Environment: windows, eclipse.
Reporter: wei su
Fix For: Future
here is sample code:
Properties localProperties = new Properties();
Connection conn =
DriverManager.getConnection("jdbc:kylin://clouderahadoop.test.tsi.lan:15000",
localProperties);
here here is guild.gradle:
compile(group: 'com.google.guava', name: 'guava', version: '23+')
compile(group: 'org.apache.httpcomponents', name: 'httpclient', version:
'4.5+')
compile(group: 'org.apache.calcite.avatica', name: 'avatica-core', version:
'1.15.0')
compile(group: 'org.apache.kylin', name: 'kylin-jdbc', version: '2.6.+')
but I still get no suitable driver problem.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (KYLIN-4003) Get java.sql.SQLException: No suitable driver found when use DriverManager.getConnection("jdbc:kylin://
[
https://issues.apache.org/jira/browse/KYLIN-4003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16840863#comment-16840863
]
wei su commented on KYLIN-4003:
---
do I need load driver use this way:
Driver driver = (Driver)
Class.forName("org.apache.kylin.jdbc.Driver").newInstance();
can I DriverManager?
> Get java.sql.SQLException: No suitable driver found when use
> DriverManager.getConnection("jdbc:kylin://
> ---
>
> Key: KYLIN-4003
> URL: https://issues.apache.org/jira/browse/KYLIN-4003
> Project: Kylin
> Issue Type: Bug
> Components: Driver - JDBC
>Affects Versions: v2.6.1
> Environment: windows, eclipse.
>Reporter: wei su
>Priority: Major
> Fix For: Future
>
>
> here is sample code:
> Properties localProperties = new Properties();
> Connection conn =
> DriverManager.getConnection("jdbc:kylin://clouderahadoop.test.tsi.lan:15000",
> localProperties);
>
> here here is guild.gradle:
> compile(group: 'com.google.guava', name: 'guava', version: '23+')
> compile(group: 'org.apache.httpcomponents', name: 'httpclient', version:
> '4.5+')
> compile(group: 'org.apache.calcite.avatica', name: 'avatica-core', version:
> '1.15.0')
> compile(group: 'org.apache.kylin', name: 'kylin-jdbc', version: '2.6.+')
>
> but I still get no suitable driver problem.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (KYLIN-4004) Multi user groups table permission error
haifeng wang created KYLIN-4004: --- Summary: Multi user groups table permission error Key: KYLIN-4004 URL: https://issues.apache.org/jira/browse/KYLIN-4004 Project: Kylin Issue Type: Bug Components: Others Affects Versions: all Reporter: haifeng wang Fix For: v2.6.1 When a user has multiple user groups, When collecting the blacklist of the table, Using the union of the blacklists of each group -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [kylin] nichunen merged pull request #643: Small performance improvements
nichunen merged pull request #643: Small performance improvements URL: https://github.com/apache/kylin/pull/643 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] asfgit commented on issue #644: KYLIN-4004, fix table acl when use groups
asfgit commented on issue #644: KYLIN-4004, fix table acl when use groups URL: https://github.com/apache/kylin/pull/644#issuecomment-492892600 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] yuexingri opened a new pull request #644: KYLIN-4004, fix table acl when use groups
yuexingri opened a new pull request #644: KYLIN-4004, fix table acl when use groups URL: https://github.com/apache/kylin/pull/644 rt This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (KYLIN-4004) Multi user groups table permission error
[ https://issues.apache.org/jira/browse/KYLIN-4004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16840931#comment-16840931 ] ASF GitHub Bot commented on KYLIN-4004: --- yuexingri commented on pull request #644: KYLIN-4004, fix table acl when use groups URL: https://github.com/apache/kylin/pull/644 rt This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Multi user groups table permission error > > > Key: KYLIN-4004 > URL: https://issues.apache.org/jira/browse/KYLIN-4004 > Project: Kylin > Issue Type: Bug > Components: Others >Affects Versions: all >Reporter: haifeng wang >Priority: Major > Fix For: v2.6.1 > > > When a user has multiple user groups, When collecting the blacklist of the > table, Using the union of the blacklists of each group -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-4003) Get java.sql.SQLException: No suitable driver found when use DriverManager.getConnection("jdbc:kylin://
[
https://issues.apache.org/jira/browse/KYLIN-4003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16840943#comment-16840943
]
nichunen commented on KYLIN-4003:
-
Hi, seems duplicate with https://issues.apache.org/jira/browse/KYLIN-3965
It's fixed in 2.6.2
> Get java.sql.SQLException: No suitable driver found when use
> DriverManager.getConnection("jdbc:kylin://
> ---
>
> Key: KYLIN-4003
> URL: https://issues.apache.org/jira/browse/KYLIN-4003
> Project: Kylin
> Issue Type: Bug
> Components: Driver - JDBC
>Affects Versions: v2.6.1
> Environment: windows, eclipse.
>Reporter: wei su
>Priority: Major
> Fix For: Future
>
>
> here is sample code:
> Properties localProperties = new Properties();
> Connection conn =
> DriverManager.getConnection("jdbc:kylin://clouderahadoop.test.tsi.lan:15000",
> localProperties);
>
> here here is guild.gradle:
> compile(group: 'com.google.guava', name: 'guava', version: '23+')
> compile(group: 'org.apache.httpcomponents', name: 'httpclient', version:
> '4.5+')
> compile(group: 'org.apache.calcite.avatica', name: 'avatica-core', version:
> '1.15.0')
> compile(group: 'org.apache.kylin', name: 'kylin-jdbc', version: '2.6.+')
>
> but I still get no suitable driver problem.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
