[jira] [Closed] (KYLIN-4152) Should Disable Before Deleting HBase Table using HBaseAdmin

2019-08-28 Thread Tian Hong Wang (Jira)


 [ 
https://issues.apache.org/jira/browse/KYLIN-4152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tian Hong Wang closed KYLIN-4152.
-
Resolution: Won't Fix

> Should Disable Before Deleting HBase Table using HBaseAdmin 
> 
>
> Key: KYLIN-4152
> URL: https://issues.apache.org/jira/browse/KYLIN-4152
> Project: Kylin
>  Issue Type: Bug
>  Components: Storage - HBase
>Affects Versions: v2.5.2
>Reporter: Tian Hong Wang
>Assignee: Tian Hong Wang
>Priority: Major
> Fix For: v2.6.4
>
> Attachments: kylin-4152.patch
>
>
> In LookupTableToHFileJob.java, it should disable before deleting hbase table 
> when using HBaseAdmin API. Otherwise, it will throw Exception.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (KYLIN-4152) Should Disable Before Deleting HBase Table using HBaseAdmin

2019-08-28 Thread Tian Hong Wang (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-4152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16918259#comment-16918259
 ] 

Tian Hong Wang commented on KYLIN-4152:
---

This issue has been fixed in recent release. So close this issue.

> Should Disable Before Deleting HBase Table using HBaseAdmin 
> 
>
> Key: KYLIN-4152
> URL: https://issues.apache.org/jira/browse/KYLIN-4152
> Project: Kylin
>  Issue Type: Bug
>  Components: Storage - HBase
>Affects Versions: v2.5.2
>Reporter: Tian Hong Wang
>Assignee: Tian Hong Wang
>Priority: Major
> Fix For: v2.6.4
>
> Attachments: kylin-4152.patch
>
>
> In LookupTableToHFileJob.java, it should disable before deleting hbase table 
> when using HBaseAdmin API. Otherwise, it will throw Exception.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (KYLIN-4152) Should Disable Before Deleting HBase Table using HBaseAdmin

2019-08-28 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-4152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16918255#comment-16918255
 ] 

ASF GitHub Bot commented on KYLIN-4152:
---

tianhonglouis commented on pull request #814: KYLIN-4152: disable before 
deleting HBase table
URL: https://github.com/apache/kylin/pull/814
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Should Disable Before Deleting HBase Table using HBaseAdmin 
> 
>
> Key: KYLIN-4152
> URL: https://issues.apache.org/jira/browse/KYLIN-4152
> Project: Kylin
>  Issue Type: Bug
>  Components: Storage - HBase
>Affects Versions: v2.5.2
>Reporter: Tian Hong Wang
>Assignee: Tian Hong Wang
>Priority: Major
> Fix For: v2.6.4
>
> Attachments: kylin-4152.patch
>
>
> In LookupTableToHFileJob.java, it should disable before deleting hbase table 
> when using HBaseAdmin API. Otherwise, it will throw Exception.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[GitHub] [kylin] tianhonglouis closed pull request #814: KYLIN-4152: disable before deleting HBase table

2019-08-28 Thread GitBox
tianhonglouis closed pull request #814: KYLIN-4152: disable before deleting 
HBase table
URL: https://github.com/apache/kylin/pull/814
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (KYLIN-4152) Should Disable Before Deleting HBase Table using HBaseAdmin

2019-08-28 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-4152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16918248#comment-16918248
 ] 

ASF GitHub Bot commented on KYLIN-4152:
---

tianhonglouis commented on pull request #814: KYLIN-4152: disable before 
deleting HBase table
URL: https://github.com/apache/kylin/pull/814
 
 
   It should disable hbase table before deleting hbase table. Otherwise it will 
cause exception.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Should Disable Before Deleting HBase Table using HBaseAdmin 
> 
>
> Key: KYLIN-4152
> URL: https://issues.apache.org/jira/browse/KYLIN-4152
> Project: Kylin
>  Issue Type: Bug
>  Components: Storage - HBase
>Affects Versions: v2.5.2
>Reporter: Tian Hong Wang
>Assignee: Tian Hong Wang
>Priority: Major
> Fix For: v2.6.4
>
> Attachments: kylin-4152.patch
>
>
> In LookupTableToHFileJob.java, it should disable before deleting hbase table 
> when using HBaseAdmin API. Otherwise, it will throw Exception.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[GitHub] [kylin] tianhonglouis opened a new pull request #814: KYLIN-4152: disable before deleting HBase table

2019-08-28 Thread GitBox
tianhonglouis opened a new pull request #814: KYLIN-4152: disable before 
deleting HBase table
URL: https://github.com/apache/kylin/pull/814
 
 
   It should disable hbase table before deleting hbase table. Otherwise it will 
cause exception.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [kylin] asf-ci commented on issue #814: KYLIN-4152: disable before deleting HBase table

2019-08-28 Thread GitBox
asf-ci commented on issue #814: KYLIN-4152: disable before deleting HBase table
URL: https://github.com/apache/kylin/pull/814#issuecomment-526005173
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (KYLIN-4152) Should Disable Before Deleting HBase Table using HBaseAdmin

2019-08-28 Thread Tian Hong Wang (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-4152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16918232#comment-16918232
 ] 

Tian Hong Wang commented on KYLIN-4152:
---

sure, thank you for your quick response.

> Should Disable Before Deleting HBase Table using HBaseAdmin 
> 
>
> Key: KYLIN-4152
> URL: https://issues.apache.org/jira/browse/KYLIN-4152
> Project: Kylin
>  Issue Type: Bug
>  Components: Storage - HBase
>Affects Versions: v2.5.2
>Reporter: Tian Hong Wang
>Assignee: Tian Hong Wang
>Priority: Major
> Fix For: v2.6.4
>
> Attachments: kylin-4152.patch
>
>
> In LookupTableToHFileJob.java, it should disable before deleting hbase table 
> when using HBaseAdmin API. Otherwise, it will throw Exception.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (KYLIN-4152) Should Disable Before Deleting HBase Table using HBaseAdmin

2019-08-28 Thread Shaofeng SHI (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-4152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16917790#comment-16917790
 ] 

Shaofeng SHI commented on KYLIN-4152:
-

Hi Tianhong, this patch doesn't have author information. Could you please 
re-generate with "git format-patch", or create a PR to Kylin's git repository 
on github.com? Thank you!

> Should Disable Before Deleting HBase Table using HBaseAdmin 
> 
>
> Key: KYLIN-4152
> URL: https://issues.apache.org/jira/browse/KYLIN-4152
> Project: Kylin
>  Issue Type: Bug
>  Components: Storage - HBase
>Affects Versions: v2.5.2
>Reporter: Tian Hong Wang
>Assignee: Tian Hong Wang
>Priority: Major
> Fix For: v2.6.4
>
> Attachments: kylin-4152.patch
>
>
> In LookupTableToHFileJob.java, it should disable before deleting hbase table 
> when using HBaseAdmin API. Otherwise, it will throw Exception.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Updated] (KYLIN-4152) Should Disable Before Deleting HBase Table using HBaseAdmin

2019-08-28 Thread Shaofeng SHI (Jira)


 [ 
https://issues.apache.org/jira/browse/KYLIN-4152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shaofeng SHI updated KYLIN-4152:

Fix Version/s: (was: all)
   v2.6.4

> Should Disable Before Deleting HBase Table using HBaseAdmin 
> 
>
> Key: KYLIN-4152
> URL: https://issues.apache.org/jira/browse/KYLIN-4152
> Project: Kylin
>  Issue Type: Bug
>  Components: Storage - HBase
>Affects Versions: v2.5.2
>Reporter: Tian Hong Wang
>Assignee: Tian Hong Wang
>Priority: Major
> Fix For: v2.6.4
>
> Attachments: kylin-4152.patch
>
>
> In LookupTableToHFileJob.java, it should disable before deleting hbase table 
> when using HBaseAdmin API. Otherwise, it will throw Exception.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Assigned] (KYLIN-4152) Should Disable Before Deleting HBase Table using HBaseAdmin

2019-08-28 Thread Shaofeng SHI (Jira)


 [ 
https://issues.apache.org/jira/browse/KYLIN-4152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shaofeng SHI reassigned KYLIN-4152:
---

Assignee: Tian Hong Wang

Good catch, thank you Tian hong!

> Should Disable Before Deleting HBase Table using HBaseAdmin 
> 
>
> Key: KYLIN-4152
> URL: https://issues.apache.org/jira/browse/KYLIN-4152
> Project: Kylin
>  Issue Type: Bug
>  Components: Storage - HBase
>Affects Versions: v2.5.2
>Reporter: Tian Hong Wang
>Assignee: Tian Hong Wang
>Priority: Major
> Fix For: all
>
> Attachments: kylin-4152.patch
>
>
> In LookupTableToHFileJob.java, it should disable before deleting hbase table 
> when using HBaseAdmin API. Otherwise, it will throw Exception.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Updated] (KYLIN-4152) Should Disable Before Deleting HBase Table using HBaseAdmin

2019-08-28 Thread Tian Hong Wang (Jira)


 [ 
https://issues.apache.org/jira/browse/KYLIN-4152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tian Hong Wang updated KYLIN-4152:
--
Attachment: kylin-4152.patch

> Should Disable Before Deleting HBase Table using HBaseAdmin 
> 
>
> Key: KYLIN-4152
> URL: https://issues.apache.org/jira/browse/KYLIN-4152
> Project: Kylin
>  Issue Type: Bug
>  Components: Storage - HBase
>Affects Versions: v2.5.2
>Reporter: Tian Hong Wang
>Priority: Major
> Fix For: all
>
> Attachments: kylin-4152.patch
>
>
> In LookupTableToHFileJob.java, it should disable before deleting hbase table 
> when using HBaseAdmin API. Otherwise, it will throw Exception.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Created] (KYLIN-4152) Should Disable Before Deleting HBase Table using HBaseAdmin

2019-08-28 Thread Tian Hong Wang (Jira)
Tian Hong Wang created KYLIN-4152:
-

 Summary: Should Disable Before Deleting HBase Table using 
HBaseAdmin 
 Key: KYLIN-4152
 URL: https://issues.apache.org/jira/browse/KYLIN-4152
 Project: Kylin
  Issue Type: Bug
  Components: Storage - HBase
Affects Versions: v2.5.2
Reporter: Tian Hong Wang
 Fix For: all


In LookupTableToHFileJob.java, it should disable before deleting hbase table 
when using HBaseAdmin API. Otherwise, it will throw Exception.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Updated] (KYLIN-4151) FileSplit ClassCastException in KafkaMRInput

2019-08-28 Thread Tian Hong Wang (Jira)


 [ 
https://issues.apache.org/jira/browse/KYLIN-4151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tian Hong Wang updated KYLIN-4151:
--
Attachment: KafkaMRInput.patch

> FileSplit ClassCastException in KafkaMRInput
> 
>
> Key: KYLIN-4151
> URL: https://issues.apache.org/jira/browse/KYLIN-4151
> Project: Kylin
>  Issue Type: Bug
>  Components: Others
>Affects Versions: v2.5.2
>Reporter: Tian Hong Wang
>Priority: Major
> Fix For: all
>
> Attachments: 20190828172850.png, KafkaMRInput.patch
>
>
> It wil cause ClassCastException in KafkaMRInput:
> org.apache.hadoop.mapreduce.lib.input.FileSplit cannot be cast to 
> org.apache.hadoop.mapred.FileSplit.
> The stack trace see the attachment.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Updated] (KYLIN-4151) FileSplit ClassCastException in KafkaMRInput

2019-08-28 Thread Tian Hong Wang (Jira)


 [ 
https://issues.apache.org/jira/browse/KYLIN-4151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tian Hong Wang updated KYLIN-4151:
--
Flags: Patch

> FileSplit ClassCastException in KafkaMRInput
> 
>
> Key: KYLIN-4151
> URL: https://issues.apache.org/jira/browse/KYLIN-4151
> Project: Kylin
>  Issue Type: Bug
>  Components: Others
>Affects Versions: v2.5.2
>Reporter: Tian Hong Wang
>Priority: Major
> Fix For: all
>
> Attachments: 20190828172850.png, KafkaMRInput.patch
>
>
> It wil cause ClassCastException in KafkaMRInput:
> org.apache.hadoop.mapreduce.lib.input.FileSplit cannot be cast to 
> org.apache.hadoop.mapred.FileSplit.
> The stack trace see the attachment.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Created] (KYLIN-4151) FileSplit ClassCastException in KafkaMRInput

2019-08-28 Thread Tian Hong Wang (Jira)
Tian Hong Wang created KYLIN-4151:
-

 Summary: FileSplit ClassCastException in KafkaMRInput
 Key: KYLIN-4151
 URL: https://issues.apache.org/jira/browse/KYLIN-4151
 Project: Kylin
  Issue Type: Bug
  Components: Others
Affects Versions: v2.5.2
Reporter: Tian Hong Wang
 Fix For: all
 Attachments: 20190828172850.png

It wil cause ClassCastException in KafkaMRInput:

org.apache.hadoop.mapreduce.lib.input.FileSplit cannot be cast to 
org.apache.hadoop.mapred.FileSplit.

The stack trace see the attachment.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[GitHub] [kylin] codecov-io commented on issue #813: Add JoinedFormatter for dynamic variables in where sentence

2019-08-28 Thread GitBox
codecov-io commented on issue #813: Add JoinedFormatter for dynamic variables 
in where sentence
URL: https://github.com/apache/kylin/pull/813#issuecomment-525609865
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/813?src=pr=h1) Report
   > Merging [#813](https://codecov.io/gh/apache/kylin/pull/813?src=pr=desc) 
into 
[master](https://codecov.io/gh/apache/kylin/commit/6e1d48ebb86089b185b10fdbc5eea40cf4df0ea7?src=pr=desc)
 will **increase** coverage by `0.02%`.
   > The diff coverage is `57.89%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/kylin/pull/813/graphs/tree.svg?width=650=JawVgbgsVo=150=pr)](https://codecov.io/gh/apache/kylin/pull/813?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master #813  +/-   ##
   
   + Coverage 25.61%   25.63%   +0.02% 
   - Complexity 6048 6060  +12 
   
 Files  1398 1399   +1 
 Lines 8351183566  +55 
 Branches  1169911705   +6 
   
   + Hits  2139121423  +32 
   - Misses6006560087  +22 
   - Partials   2055 2056   +1
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/kylin/pull/813?src=pr=tree) | Coverage Δ 
| Complexity Δ | |
   |---|---|---|---|
   | 
[...ain/java/org/apache/kylin/job/JoinedFlatTable.java](https://codecov.io/gh/apache/kylin/pull/813/diff?src=pr=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9Kb2luZWRGbGF0VGFibGUuamF2YQ==)
 | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | 
[...ain/java/org/apache/kylin/job/JoinedFormatter.java](https://codecov.io/gh/apache/kylin/pull/813/diff?src=pr=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9Kb2luZWRGb3JtYXR0ZXIuamF2YQ==)
 | `61.11% <61.11%> (ø)` | `11 <11> (?)` | |
   | 
[...he/kylin/job/impl/threadpool/DefaultScheduler.java](https://codecov.io/gh/apache/kylin/pull/813/diff?src=pr=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9pbXBsL3RocmVhZHBvb2wvRGVmYXVsdFNjaGVkdWxlci5qYXZh)
 | `74.41% <0%> (-2.33%)` | `12% <0%> (ø)` | |
   | 
[.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/813/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=)
 | `63.84% <0%> (-2.31%)` | `0% <0%> (ø)` | |
   | 
[...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/813/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh)
 | `70.21% <0%> (+0.6%)` | `7% <0%> (ø)` | :arrow_down: |
   | 
[...org/apache/kylin/rest/util/QueryRequestLimits.java](https://codecov.io/gh/apache/kylin/pull/813/diff?src=pr=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvdXRpbC9RdWVyeVJlcXVlc3RMaW1pdHMuamF2YQ==)
 | `40.47% <0%> (+4.76%)` | `6% <0%> (+1%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/kylin/pull/813?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/kylin/pull/813?src=pr=footer). Last 
update 
[6e1d48e...4d9b7e6](https://codecov.io/gh/apache/kylin/pull/813?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [kylin] asf-ci commented on issue #813: Add JoinedFormatter for dynamic variables in where sentence

2019-08-28 Thread GitBox
asf-ci commented on issue #813: Add JoinedFormatter for dynamic variables in 
where sentence
URL: https://github.com/apache/kylin/pull/813#issuecomment-525600980
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [kylin] liuzx32 opened a new pull request #813: Add JoinedFormatter for dynamic variables in where sentence

2019-08-28 Thread GitBox
liuzx32 opened a new pull request #813: Add JoinedFormatter for dynamic 
variables in where sentence
URL: https://github.com/apache/kylin/pull/813
 
 
   **Description**
   The users can use ${START_DATE} and ${END_DATE} in where filter which in the 
WebUI.
   And the dynamic variables ${START_DATE} and ${END_DATE} are from the 
building date of Cube.
   #
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [kylin] hit-lacus commented on issue #812: KYLIN-4150 Improve docker for kylin instructions

2019-08-28 Thread GitBox
hit-lacus commented on issue #812: KYLIN-4150 Improve docker for kylin 
instructions
URL: https://github.com/apache/kylin/pull/812#issuecomment-525598081
 
 
   I think this is fine to me.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services