[jira] [Commented] (KYLIN-3807) Error during sample_cube build "Build Dimension Dictionary"

2019-11-21 Thread Sonu Singh (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-3807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979944#comment-16979944
 ] 

Sonu Singh commented on KYLIN-3807:
---

I am also facing the same issue. Can you update on this? still facing the same 
or you resolved ?

> Error during sample_cube build "Build Dimension Dictionary"
> ---
>
> Key: KYLIN-3807
> URL: https://issues.apache.org/jira/browse/KYLIN-3807
> Project: Kylin
>  Issue Type: Bug
> Environment: kylin 2.5.2-cdh60
> impala 3.0.0-cdh6.0.1
> spark version 2.2.0-cdh6.0.1
>Reporter: Davide Malagoli
>Priority: Major
> Attachments: kylin-compose.zip
>
>
> It seems that a duplicate key value is found [null].
> But there are no null in that four fields in my table, could it be a wrong 
> interpretation of the "timestamp" columns?
>  
> org.apache.kylin.engine.mr.exception.HadoopShellException: 
> java.lang.RuntimeException: Checking snapshot of TableRef[KYLIN_CAL_DT] 
> failed.
>  at 
> org.apache.kylin.cube.cli.DictionaryGeneratorCLI.processSegment(DictionaryGeneratorCLI.java:103)
>  at 
> org.apache.kylin.cube.cli.DictionaryGeneratorCLI.processSegment(DictionaryGeneratorCLI.java:50)
>  at 
> org.apache.kylin.engine.mr.steps.CreateDictionaryJob.run(CreateDictionaryJob.java:73)
>  at org.apache.kylin.engine.mr.MRUtil.runMRJob(MRUtil.java:92)
>  at 
> org.apache.kylin.engine.mr.common.HadoopShellExecutable.doWork(HadoopShellExecutable.java:63)
>  at 
> org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:164)
>  at 
> org.apache.kylin.job.execution.DefaultChainedExecutable.doWork(DefaultChainedExecutable.java:70)
>  at 
> org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:164)
>  at 
> org.apache.kylin.job.impl.threadpool.DefaultScheduler$JobRunner.run(DefaultScheduler.java:113)
>  at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
>  at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
>  at java.lang.Thread.run(Thread.java:748)
>  Caused by: java.lang.IllegalStateException: The table: KYLIN_CAL_DT Dup key 
> found, key=[null], 
> value1=[null,null,null,null,null,0,-1,-3,-15,-103,0,-1,-4,-15,-15,41501,228,47,16,6,33,5928,2,8,1364,3,455,114,2012-12-31,2012-09-30,2012-08-31,2012-08-17,16-Aug-2012,Aug
>  16th 2012,Fri 
> 08-16-13,1,0,0,0,2012-06-21,365,92,31,7,2012-12-30,2012-06-30,2012-07-28,2012-08-11,2012-08-12,2012-08-16,Fri
>  ,2012M08,Aug-2012,N,2012M08 ,N,Year 2012 - Quarter 03,2012Q03 
> ,N,33,2012,2012-08-11,2012-08-17,N,Wk.33 - 13,2012-08-11 00:00:00,2012-08-17 
> 00:00:00,2012W33 ,2012W33 ,08/11/13 - 08/17/13,08/11 - 
> 08/17,2012,N,2012-08-16,2011-08-16,2012-05-16,2012-02-16,2012-07-16,2012-06-16,2012-08-09,2012-08-02,0,0,0,0,0,0,0,0,8,3,33,3,1,1,1,2005-09-07,USER_X
>  ,2012-11-27 00:16:56,USER_X], 
> value2=[null,null,null,null,null,0,-3,-10,-47,-328,0,-3,-11,-47,-47,41276,3,3,3,5,1,5896,1,1,1357,1,453,114,2012-12-31,2012-03-31,2012-01-31,2012-01-05,03-Jan-2012,Jan
>  3rd 2012,Thu 
> 01-03-13,1,0,0,0,2012-12-21,365,90,31,5,2012-12-30,2012-12-30,2012-12-30,2012-12-30,2012-12-31,2012-01-03,Thu
>  ,2012M01,Jan-2012,N,2012M01 ,N,Year 2012 - Quarter 01,2012Q01 
> ,N,1,2012,2012-12-30,2012-01-05,N,Wk.01 - 13,2012-01-01 00:00:00,2012-01-05 
> 00:00:00,2012W01 ,2012W01 ,01/01/13 - 01/05/13,01/01 - 
> 01/05,2012,N,2012-01-03,2011-01-03,2012-10-03,2012-07-03,2012-12-03,2012-11-03,2012-12-27,2012-12-20,0,0,0,0,0,0,0,0,1,1,1,1,1,1,1,2005-09-07,USER_X
>  ,2012-11-27 00:16:56,USER_X]
>  at org.apache.kylin.dict.lookup.LookupTable.initRow(LookupTable.java:86)
>  at org.apache.kylin.dict.lookup.LookupTable.init(LookupTable.java:69)
>  at 
> org.apache.kylin.dict.lookup.LookupStringTable.init(LookupStringTable.java:80)
>  at org.apache.kylin.dict.lookup.LookupTable.(LookupTable.java:57)
>  at 
> org.apache.kylin.dict.lookup.LookupStringTable.(LookupStringTable.java:66)
>  at 
> org.apache.kylin.dict.lookup.LookupProviderFactory.getInMemLookupTable(LookupProviderFactory.java:63)
>  at 
> org.apache.kylin.cube.CubeManager.getInMemLookupTable(CubeManager.java:481)
>  at org.apache.kylin.cube.CubeManager.getLookupTable(CubeManager.java:467)
>  at 
> org.apache.kylin.cube.cli.DictionaryGeneratorCLI.processSegment(DictionaryGeneratorCLI.java:101)
>  ... 11 more
> result code:2
>  at 
> org.apache.kylin.engine.mr.common.HadoopShellExecutable.doWork(HadoopShellExecutable.java:73)
>  at 
> org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:164)
>  at 
> org.apache.kylin.job.execution.DefaultChainedExecutable.doWork(DefaultChainedExecutable.java:70)
>  at 
> org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:164)
>  at 
> 

[GitHub] [kylin] hit-lacus commented on a change in pull request #952: KYLIN-4257 Build histroical data by layer in real time Lambda cube

2019-11-21 Thread GitBox
hit-lacus commented on a change in pull request #952: KYLIN-4257 Build 
histroical data by layer in real time Lambda cube
URL: https://github.com/apache/kylin/pull/952#discussion_r349466616
 
 

 ##
 File path: 
core-metadata/src/main/java/org/apache/kylin/metadata/model/TableDesc.java
 ##
 @@ -434,4 +434,11 @@ public boolean isStreamingTable() {
 return false;
 }
 
+public boolean isLambdaTable() {
 
 Review comment:
   Could we reuse `isStreamingTable` method?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [kylin] codecov-io commented on issue #957: KYLIN-4265 SQL tab of cube failed when filter is not empty

2019-11-21 Thread GitBox
codecov-io commented on issue #957: KYLIN-4265 SQL tab of cube failed when 
filter is not empty
URL: https://github.com/apache/kylin/pull/957#issuecomment-557428366
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/957?src=pr=h1) Report
   > :exclamation: No coverage uploaded for pull request base 
(`master@2c79a24`). [Click here to learn what that 
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `80%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/kylin/pull/957/graphs/tree.svg?width=650=JawVgbgsVo=150=pr)](https://codecov.io/gh/apache/kylin/pull/957?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ## master #957   +/-   ##
   =
 Coverage  ?   25.57%   
 Complexity? 6139   
   =
 Files ? 1412   
 Lines ?85095   
 Branches  ?11935   
   =
 Hits  ?21762   
 Misses?61225   
 Partials  ? 2108
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/kylin/pull/957?src=pr=tree) | Coverage Δ 
| Complexity Δ | |
   |---|---|---|---|
   | 
[...ain/java/org/apache/kylin/job/JoinedFlatTable.java](https://codecov.io/gh/apache/kylin/pull/957/diff?src=pr=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9Kb2luZWRGbGF0VGFibGUuamF2YQ==)
 | `23.52% <80%> (ø)` | `9 <0> (?)` | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/kylin/pull/957?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/kylin/pull/957?src=pr=footer). Last 
update 
[2c79a24...ec47595](https://codecov.io/gh/apache/kylin/pull/957?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [kylin] hit-lacus commented on issue #956: KYLIN-4172 Enable renaming column name for streaming table

2019-11-21 Thread GitBox
hit-lacus commented on issue #956: KYLIN-4172 Enable renaming column name for 
streaming table
URL: https://github.com/apache/kylin/pull/956#issuecomment-557427076
 
 
   I only find one issue, when you change name of time derived time dimension, 
you can not get right query result, you can try protect these column.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [kylin] TempleZhou opened a new pull request #957: KYLIN-4265 SQL tab of cube failed when filter is not empty

2019-11-21 Thread GitBox
TempleZhou opened a new pull request #957: KYLIN-4265 SQL tab of cube failed 
when filter is not empty
URL: https://github.com/apache/kylin/pull/957
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [kylin] asf-ci commented on issue #957: KYLIN-4265 SQL tab of cube failed when filter is not empty

2019-11-21 Thread GitBox
asf-ci commented on issue #957: KYLIN-4265 SQL tab of cube failed when filter 
is not empty
URL: https://github.com/apache/kylin/pull/957#issuecomment-557420307
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (KYLIN-4265) SQL tab of cube failed when filter is not empty

2019-11-21 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-4265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979924#comment-16979924
 ] 

ASF GitHub Bot commented on KYLIN-4265:
---

TempleZhou commented on pull request #957: KYLIN-4265 SQL tab of cube failed 
when filter is not empty
URL: https://github.com/apache/kylin/pull/957
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> SQL tab of cube failed when filter is not empty
> ---
>
> Key: KYLIN-4265
> URL: https://issues.apache.org/jira/browse/KYLIN-4265
> Project: Kylin
>  Issue Type: Bug
>  Components: Metadata
>Affects Versions: all
>Reporter: Temple Zhou
>Assignee: Temple Zhou
>Priority: Major
> Attachments: screenshot.png
>
>
> The SQL tab of Cube with filter condition will be failed to display.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [kylin] hit-lacus commented on issue #956: KYLIN-4172 Enable renaming column name for streaming table

2019-11-21 Thread GitBox
hit-lacus commented on issue #956: KYLIN-4172 Enable renaming column name for 
streaming table
URL: https://github.com/apache/kylin/pull/956#issuecomment-557415862
 
 
   ### Table Info
   
   
![image](https://user-images.githubusercontent.com/14030549/69404419-38c53780-0d38-11ea-8e74-3c20671eebb4.png)
   
![image](https://user-images.githubusercontent.com/14030549/69404439-411d7280-0d38-11ea-98dd-c052a6242e09.png)
   
   ### Cube Design
   
![image](https://user-images.githubusercontent.com/14030549/69404466-50042500-0d38-11ea-94ad-b57ad6b0aafd.png)
   
   
![image](https://user-images.githubusercontent.com/14030549/69404554-8c378580-0d38-11ea-9e14-ed5c76f15c6b.png)
   
   
   ### Test Query
   
![image](https://user-images.githubusercontent.com/14030549/69404224-b63c7800-0d37-11ea-8c25-314230acecdb.png)
   
   
![image](https://user-images.githubusercontent.com/14030549/69404322-0287b800-0d38-11ea-878a-35c404748e13.png)
   
   
![image](https://user-images.githubusercontent.com/14030549/69404380-277c2b00-0d38-11ea-957d-f20a75b2950c.png)
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [kylin] hit-lacus commented on issue #956: KYLIN-4172 Enable renaming column name for streaming table

2019-11-21 Thread GitBox
hit-lacus commented on issue #956: KYLIN-4172 Enable renaming column name for 
streaming table
URL: https://github.com/apache/kylin/pull/956#issuecomment-557412923
 
 
   I have give it a test, so I apply your patch and build a new package, and 
deploy in my test env.
   
   If we have the following sample message:
   
    Sample
   ```json
   {
   "act_type":"dislike",
   "event_ts_2":1574403423000,
   "pageview_id":"4dcc916f271e17",
   "event_ts":1574403423000,
   "play_duration":20.22,
   "multi_2":[
   "ele_1",
   "__%s",
   3
   ],
   "event_date_2":"2019-11-22 06:17:03",
   "video_type":"Sports",
   "play_times":16,
   "multi_1":{
   "key3":494593,
   "key2":17,
   "key1":{
   "key2":99
   }
   },
   "str_minute":"17",
   "str_minute_second":"6_17_3",
   "video_id":12,
   "event_date":"2019-11-22 06:17:03",
   "str_second":"3",
   "uid":7
   }
   ```
   
    Change the dimension name 
   
![image](https://user-images.githubusercontent.com/14030549/69403785-71fca800-0d36-11ea-8ee8-aebca17fbd4a.png)
   
    Change the dimension name  for derived time dimension
   
![image](https://user-images.githubusercontent.com/14030549/69403903-c4d65f80-0d36-11ea-8101-0038c8e2cd52.png)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [kylin] zhoukangcn commented on issue #858: KYLIN-4178: job scheduler safe mode

2019-11-21 Thread GitBox
zhoukangcn commented on issue #858: KYLIN-4178: job scheduler safe mode
URL: https://github.com/apache/kylin/pull/858#issuecomment-557408426
 
 
   OK,I will update document  later.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Updated] (KYLIN-4258) Real-time OLAP may return incorrect result for some case

2019-11-21 Thread nichunen (Jira)


 [ 
https://issues.apache.org/jira/browse/KYLIN-4258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

nichunen updated KYLIN-4258:

Fix Version/s: v3.0.0

> Real-time OLAP may return incorrect result for some case
> 
>
> Key: KYLIN-4258
> URL: https://issues.apache.org/jira/browse/KYLIN-4258
> Project: Kylin
>  Issue Type: Improvement
>  Components: Real-time Streaming
>Affects Versions: v3.0.0-alpha, v3.0.0-alpha2
>Reporter: Gang Ma
>Assignee: Gang Ma
>Priority: Major
> Fix For: v3.0.0
>
>
> 1. When real-time query group by minute_start and filter by another column, 
> the aggregate result maybe not correct, the issue has been addressed in 
> [KYLIN-4184|https://issues.apache.org/jira/browse/KYLIN-4184] , the fix is 
> good, but in  
> NoCompressedColumnReader class, the readBuffer bytes is still shared, it is a 
> potential issue, need to be fixed.
> 2. When filter by a minute_start range, the first minute data may not be 
> correct, it is caused 
> by:[https://github.com/apache/kylin/blob/master/stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/ColumnarSegmentStoreFilesSearcher.java#L68],
>  the fragment's max time is inclusive, but this method's max time is 
> exclusive, that may skip some fragments for the first minute by mistake.
> 3. Need to add some UT to cover these two cases.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (KYLIN-4008) Real-time Streaming submit streaming job failed for spark engine

2019-11-21 Thread weibin0516 (Jira)


 [ 
https://issues.apache.org/jira/browse/KYLIN-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

weibin0516 reassigned KYLIN-4008:
-

Assignee: weibin0516

> Real-time Streaming submit streaming job failed for spark engine
> 
>
> Key: KYLIN-4008
> URL: https://issues.apache.org/jira/browse/KYLIN-4008
> Project: Kylin
>  Issue Type: New Feature
>  Components: Real-time Streaming
>Affects Versions: v3.0.0-alpha
>Reporter: zengrui
>Assignee: weibin0516
>Priority: Minor
> Attachments: error.bmp
>
>
> Create a Realtime Streaming Cube and the Cube Engine is Spark, when the 
> coordinator node receive a remoteStoreCompelete request and exist some 
> segments can build, the streaming job submit failed.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (KYLIN-4178) Job scheduler support safe mode

2019-11-21 Thread nichunen (Jira)


 [ 
https://issues.apache.org/jira/browse/KYLIN-4178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

nichunen resolved KYLIN-4178.
-
Resolution: Fixed

> Job scheduler support safe mode 
> 
>
> Key: KYLIN-4178
> URL: https://issues.apache.org/jira/browse/KYLIN-4178
> Project: Kylin
>  Issue Type: Improvement
>Reporter: ZhouKang
>Priority: Major
> Fix For: v3.0.0
>
>
> Job scheduler should support safe mode in case of the HBase cluster change.
> In xiaomi, we want update the HBase cluster from hbase0.98 to HBase 2.0. The 
> history data can be migrated previously, but the job has been submitted will 
> keep running and write data to the old cluster. So we need a method to ensure 
> that, job create htable in the old cluster will write data to the old 
> cluster, and the job have not create htable should not be scheduled.
> So we need  job scheduler safe mode. Open safe mode before changing cluster 
> config,  the  running jobs can run continuous, and the new job cannot be 
> scheduled. 
> After all running job finished, we can change the cluster config to the new 
> one,  and rest of job can be scheduled again.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [kylin] nichunen commented on issue #858: KYLIN-4178: job scheduler safe mode

2019-11-21 Thread GitBox
nichunen commented on issue #858: KYLIN-4178: job scheduler safe mode
URL: https://github.com/apache/kylin/pull/858#issuecomment-557407574
 
 
   @zhoukangcn Hi,it's merged. Would you please submit another pr for the new 
configs of this enhancement in the branch "document"?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (KYLIN-4178) Job scheduler support safe mode

2019-11-21 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-4178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979894#comment-16979894
 ] 

ASF subversion and git services commented on KYLIN-4178:


Commit 2c79a24daf88ef86b16376e56f193aebe863e984 in kylin's branch 
refs/heads/master from Zhou Kang
[ https://gitbox.apache.org/repos/asf?p=kylin.git;h=2c79a24 ]

KYLIN-4178: job scheduler safe mode


> Job scheduler support safe mode 
> 
>
> Key: KYLIN-4178
> URL: https://issues.apache.org/jira/browse/KYLIN-4178
> Project: Kylin
>  Issue Type: Improvement
>Reporter: ZhouKang
>Priority: Major
> Fix For: v3.0.0
>
>
> Job scheduler should support safe mode in case of the HBase cluster change.
> In xiaomi, we want update the HBase cluster from hbase0.98 to HBase 2.0. The 
> history data can be migrated previously, but the job has been submitted will 
> keep running and write data to the old cluster. So we need a method to ensure 
> that, job create htable in the old cluster will write data to the old 
> cluster, and the job have not create htable should not be scheduled.
> So we need  job scheduler safe mode. Open safe mode before changing cluster 
> config,  the  running jobs can run continuous, and the new job cannot be 
> scheduled. 
> After all running job finished, we can change the cluster config to the new 
> one,  and rest of job can be scheduled again.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [kylin] nichunen merged pull request #858: KYLIN-4178: job scheduler safe mode

2019-11-21 Thread GitBox
nichunen merged pull request #858: KYLIN-4178: job scheduler safe mode
URL: https://github.com/apache/kylin/pull/858
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (KYLIN-4178) Job scheduler support safe mode

2019-11-21 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-4178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979893#comment-16979893
 ] 

ASF GitHub Bot commented on KYLIN-4178:
---

nichunen commented on pull request #858: KYLIN-4178: job scheduler safe mode
URL: https://github.com/apache/kylin/pull/858
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Job scheduler support safe mode 
> 
>
> Key: KYLIN-4178
> URL: https://issues.apache.org/jira/browse/KYLIN-4178
> Project: Kylin
>  Issue Type: Improvement
>Reporter: ZhouKang
>Priority: Major
> Fix For: v3.0.0
>
>
> Job scheduler should support safe mode in case of the HBase cluster change.
> In xiaomi, we want update the HBase cluster from hbase0.98 to HBase 2.0. The 
> history data can be migrated previously, but the job has been submitted will 
> keep running and write data to the old cluster. So we need a method to ensure 
> that, job create htable in the old cluster will write data to the old 
> cluster, and the job have not create htable should not be scheduled.
> So we need  job scheduler safe mode. Open safe mode before changing cluster 
> config,  the  running jobs can run continuous, and the new job cannot be 
> scheduled. 
> After all running job finished, we can change the cluster config to the new 
> one,  and rest of job can be scheduled again.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [kylin] zhoukangcn commented on a change in pull request #858: KYLIN-4178: job scheduler safe mode

2019-11-21 Thread GitBox
zhoukangcn commented on a change in pull request #858: KYLIN-4178: job 
scheduler safe mode
URL: https://github.com/apache/kylin/pull/858#discussion_r349434949
 
 

 ##
 File path: 
core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java
 ##
 @@ -836,6 +837,14 @@ public Integer getSchedulerPollIntervalSecond() {
 return 
Integer.parseInt(getOptional("kylin.job.scheduler.poll-interval-second", "30"));
 }
 
+public boolean isSchedulerSafeMode() {
+return 
Boolean.parseBoolean(getOptional("kylin.job.scheduler.safemode", "false"));
+}
+
+public List getSafeModeRunableProjects() {
+return 
Arrays.asList(getOptionalStringArray("kylin.job.scheduler.safemode.runable-projects",
 null));
 
 Review comment:
   fixed. Please help to review again.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [kylin] codecov-io edited a comment on issue #858: KYLIN-4178: job scheduler safe mode

2019-11-21 Thread GitBox
codecov-io edited a comment on issue #858: KYLIN-4178: job scheduler safe mode
URL: https://github.com/apache/kylin/pull/858#issuecomment-535297590
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/858?src=pr=h1) Report
   > :exclamation: No coverage uploaded for pull request base 
(`master@2e571e6`). [Click here to learn what that 
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `5%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/kylin/pull/858/graphs/tree.svg?width=650=JawVgbgsVo=150=pr)](https://codecov.io/gh/apache/kylin/pull/858?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ## master #858   +/-   ##
   =
 Coverage  ?   25.56%   
 Complexity? 6138   
   =
 Files ? 1412   
 Lines ?85093   
 Branches  ?11934   
   =
 Hits  ?21751   
 Misses?61232   
 Partials  ? 2110
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/kylin/pull/858?src=pr=tree) | Coverage Δ 
| Complexity Δ | |
   |---|---|---|---|
   | 
[...lin/job/impl/threadpool/PriorityFetcherRunner.java](https://codecov.io/gh/apache/kylin/pull/858/diff?src=pr=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9pbXBsL3RocmVhZHBvb2wvUHJpb3JpdHlGZXRjaGVyUnVubmVyLmphdmE=)
 | `0% <0%> (ø)` | `0 <0> (?)` | |
   | 
[.../java/org/apache/kylin/common/KylinConfigBase.java](https://codecov.io/gh/apache/kylin/pull/858/diff?src=pr=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZ0Jhc2UuamF2YQ==)
 | `13.45% <0%> (ø)` | `44 <0> (?)` | |
   | 
[...ylin/job/impl/threadpool/DefaultFetcherRunner.java](https://codecov.io/gh/apache/kylin/pull/858/diff?src=pr=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9pbXBsL3RocmVhZHBvb2wvRGVmYXVsdEZldGNoZXJSdW5uZXIuamF2YQ==)
 | `62.5% <11.11%> (ø)` | `6 <0> (?)` | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/kylin/pull/858?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/kylin/pull/858?src=pr=footer). Last 
update 
[2e571e6...c10c9a3](https://codecov.io/gh/apache/kylin/pull/858?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [kylin] codecov-io edited a comment on issue #858: KYLIN-4178: job scheduler safe mode

2019-11-21 Thread GitBox
codecov-io edited a comment on issue #858: KYLIN-4178: job scheduler safe mode
URL: https://github.com/apache/kylin/pull/858#issuecomment-535297590
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/858?src=pr=h1) Report
   > :exclamation: No coverage uploaded for pull request base 
(`master@2e571e6`). [Click here to learn what that 
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `5%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/kylin/pull/858/graphs/tree.svg?width=650=JawVgbgsVo=150=pr)](https://codecov.io/gh/apache/kylin/pull/858?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ## master #858   +/-   ##
   =
 Coverage  ?   25.56%   
 Complexity? 6138   
   =
 Files ? 1412   
 Lines ?85093   
 Branches  ?11934   
   =
 Hits  ?21752   
 Misses?61231   
 Partials  ? 2110
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/kylin/pull/858?src=pr=tree) | Coverage Δ 
| Complexity Δ | |
   |---|---|---|---|
   | 
[...lin/job/impl/threadpool/PriorityFetcherRunner.java](https://codecov.io/gh/apache/kylin/pull/858/diff?src=pr=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9pbXBsL3RocmVhZHBvb2wvUHJpb3JpdHlGZXRjaGVyUnVubmVyLmphdmE=)
 | `0% <0%> (ø)` | `0 <0> (?)` | |
   | 
[.../java/org/apache/kylin/common/KylinConfigBase.java](https://codecov.io/gh/apache/kylin/pull/858/diff?src=pr=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZ0Jhc2UuamF2YQ==)
 | `13.45% <0%> (ø)` | `44 <0> (?)` | |
   | 
[...ylin/job/impl/threadpool/DefaultFetcherRunner.java](https://codecov.io/gh/apache/kylin/pull/858/diff?src=pr=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9pbXBsL3RocmVhZHBvb2wvRGVmYXVsdEZldGNoZXJSdW5uZXIuamF2YQ==)
 | `62.5% <11.11%> (ø)` | `6 <0> (?)` | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/kylin/pull/858?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/kylin/pull/858?src=pr=footer). Last 
update 
[2e571e6...c10c9a3](https://codecov.io/gh/apache/kylin/pull/858?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [kylin] zhoukangcn commented on issue #910: KYLIN-4226: Skip current unavailable tables when updating hbase copro…

2019-11-21 Thread GitBox
zhoukangcn commented on issue #910: KYLIN-4226: Skip current unavailable tables 
when updating hbase copro…
URL: https://github.com/apache/kylin/pull/910#issuecomment-557381467
 
 
   @lshmouse @nichunen Could you help to review this? Thanks~


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [kylin] zhoukangcn commented on issue #909: KYLIN-4225 close hive session manually

2019-11-21 Thread GitBox
zhoukangcn commented on issue #909: KYLIN-4225 close hive session manually
URL: https://github.com/apache/kylin/pull/909#issuecomment-557381053
 
 
   @nichunen Could you help to review it? Thanks


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [kylin] codecov-io edited a comment on issue #840: KYLIN-4162 After the paragraph is dropped, continue to build the subsequent segment and provide REST API to resubmit the segment

2019-11-21 Thread GitBox
codecov-io edited a comment on issue #840: KYLIN-4162 After the paragraph is 
dropped, continue to build the subsequent segment and provide REST API to 
resubmit the segment
URL: https://github.com/apache/kylin/pull/840#issuecomment-531734445
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/840?src=pr=h1) Report
   > :exclamation: No coverage uploaded for pull request base 
(`master@2e571e6`). [Click here to learn what that 
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `0%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/kylin/pull/840/graphs/tree.svg?width=650=JawVgbgsVo=150=pr)](https://codecov.io/gh/apache/kylin/pull/840?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ## master #840   +/-   ##
   =
 Coverage  ?   25.55%   
 Complexity? 6138   
   =
 Files ? 1412   
 Lines ?85107   
 Branches  ?11928   
   =
 Hits  ?21753   
 Misses?61246   
 Partials  ? 2108
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/kylin/pull/840?src=pr=tree) | Coverage Δ 
| Complexity Δ | |
   |---|---|---|---|
   | 
[...java/org/apache/kylin/rest/service/JobService.java](https://codecov.io/gh/apache/kylin/pull/840/diff?src=pr=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VydmljZS9Kb2JTZXJ2aWNlLmphdmE=)
 | `0% <0%> (ø)` | `0 <0> (?)` | |
   | 
[...rg/apache/kylin/rest/controller/JobController.java](https://codecov.io/gh/apache/kylin/pull/840/diff?src=pr=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvY29udHJvbGxlci9Kb2JDb250cm9sbGVyLmphdmE=)
 | `0% <0%> (ø)` | `0 <0> (?)` | |
   | 
[...g/apache/kylin/stream/coordinator/Coordinator.java](https://codecov.io/gh/apache/kylin/pull/840/diff?src=pr=tree#diff-c3RyZWFtLWNvb3JkaW5hdG9yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9zdHJlYW0vY29vcmRpbmF0b3IvQ29vcmRpbmF0b3IuamF2YQ==)
 | `24.85% <0%> (ø)` | `35 <0> (?)` | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/kylin/pull/840?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/kylin/pull/840?src=pr=footer). Last 
update 
[2e571e6...9f57fc7](https://codecov.io/gh/apache/kylin/pull/840?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (KYLIN-4125) Kylin upgraded from springmvc architecture to spring boot architecture

2019-11-21 Thread Sonu Singh (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-4125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979286#comment-16979286
 ] 

Sonu Singh commented on KYLIN-4125:
---

Hi Team,

I want to contribute for Kylin Spring Boot migration. I am new to this 
community, please advise how can I start?

> Kylin upgraded from springmvc architecture to spring boot architecture
> --
>
> Key: KYLIN-4125
> URL: https://issues.apache.org/jira/browse/KYLIN-4125
> Project: Kylin
>  Issue Type: Improvement
>  Components: REST Service
>Reporter: zhao jintao
>Assignee: zhao jintao
>Priority: Minor
>
> Hi Team:
> Kylin is based on the spring mvc architecture, but the spring mvc 
> configuration is more complicated. It is cumbersome when integrateing new 
> components.
> Now, The mainstream of the industry has been based on the spring boot 
> architecture. Spring boot can be automatically configured to reduce the 
> complexity of project integration; promote the expansion and implementation 
> of microservice architecture. More and more project architectures have been 
> upgraded from springmvc to spring boot.
> Kylin can also be upgraded from the springmvc architecture to the spring boot 
> architecture.
> Do you have any suggestions?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (KYLIN-4266) Kylin Metrics Cubes : need to clean deleted project metrics data from hive & cube.

2019-11-21 Thread Sonu Singh (Jira)
Sonu Singh created KYLIN-4266:
-

 Summary: Kylin Metrics Cubes : need to clean deleted project 
metrics data from hive & cube.
 Key: KYLIN-4266
 URL: https://issues.apache.org/jira/browse/KYLIN-4266
 Project: Kylin
  Issue Type: Improvement
  Components: Metrics
Affects Versions: Future
Reporter: Sonu Singh
 Fix For: v3.0.0-beta






--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [kylin] nichunen commented on a change in pull request #858: KYLIN-4178: job scheduler safe mode

2019-11-21 Thread GitBox
nichunen commented on a change in pull request #858: KYLIN-4178: job scheduler 
safe mode
URL: https://github.com/apache/kylin/pull/858#discussion_r349073113
 
 

 ##
 File path: 
core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java
 ##
 @@ -836,6 +837,14 @@ public Integer getSchedulerPollIntervalSecond() {
 return 
Integer.parseInt(getOptional("kylin.job.scheduler.poll-interval-second", "30"));
 }
 
+public boolean isSchedulerSafeMode() {
+return 
Boolean.parseBoolean(getOptional("kylin.job.scheduler.safemode", "false"));
+}
+
+public List getSafeModeRunableProjects() {
+return 
Arrays.asList(getOptionalStringArray("kylin.job.scheduler.safemode.runable-projects",
 null));
 
 Review comment:
   Typo of "runable" here, typos in config items should not exist


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Created] (KYLIN-4265) SQL tab of cube failed when filter is not empty

2019-11-21 Thread Temple Zhou (Jira)
Temple Zhou created KYLIN-4265:
--

 Summary: SQL tab of cube failed when filter is not empty
 Key: KYLIN-4265
 URL: https://issues.apache.org/jira/browse/KYLIN-4265
 Project: Kylin
  Issue Type: Bug
  Components: Metadata
Affects Versions: all
Reporter: Temple Zhou
Assignee: Temple Zhou
 Attachments: screenshot.png

The SQL tab of Cube with filter condition will be failed to display.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [kylin] nichunen merged pull request #855: Update BatchMergeJobBuilder2.java

2019-11-21 Thread GitBox
nichunen merged pull request #855: Update BatchMergeJobBuilder2.java
URL: https://github.com/apache/kylin/pull/855
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [kylin] yz490700477 opened a new pull request #855: Update BatchMergeJobBuilder2.java

2019-11-21 Thread GitBox
yz490700477 opened a new pull request #855: Update BatchMergeJobBuilder2.java
URL: https://github.com/apache/kylin/pull/855
 
 
   "Merge Cuboid Dictionary" step should load MapReduce config from 
kylin_job_conf.xml instead of kylin_job_conf_inmem.xml


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [kylin] yz490700477 closed pull request #855: Update BatchMergeJobBuilder2.java

2019-11-21 Thread GitBox
yz490700477 closed pull request #855: Update BatchMergeJobBuilder2.java
URL: https://github.com/apache/kylin/pull/855
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [kylin] codecov-io edited a comment on issue #855: Update BatchMergeJobBuilder2.java

2019-11-21 Thread GitBox
codecov-io edited a comment on issue #855: Update BatchMergeJobBuilder2.java
URL: https://github.com/apache/kylin/pull/855#issuecomment-534015654
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/855?src=pr=h1) Report
   > :exclamation: No coverage uploaded for pull request base 
(`master@1fcb731`). [Click here to learn what that 
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `0%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/kylin/pull/855/graphs/tree.svg?width=650=JawVgbgsVo=150=pr)](https://codecov.io/gh/apache/kylin/pull/855?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ## master #855   +/-   ##
   =
 Coverage  ?   25.56%   
 Complexity? 6138   
   =
 Files ? 1412   
 Lines ?85073   
 Branches  ?11928   
   =
 Hits  ?21752   
 Misses?61212   
 Partials  ? 2109
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/kylin/pull/855?src=pr=tree) | Coverage Δ 
| Complexity Δ | |
   |---|---|---|---|
   | 
[.../apache/kylin/engine/mr/BatchMergeJobBuilder2.java](https://codecov.io/gh/apache/kylin/pull/855/diff?src=pr=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvQmF0Y2hNZXJnZUpvYkJ1aWxkZXIyLmphdmE=)
 | `0% <0%> (ø)` | `0 <0> (?)` | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/kylin/pull/855?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/kylin/pull/855?src=pr=footer). Last 
update 
[1fcb731...47276c9](https://codecov.io/gh/apache/kylin/pull/855?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [kylin] codecov-io commented on issue #956: KYLIN-4172 Enable renaming column name for streaming table

2019-11-21 Thread GitBox
codecov-io commented on issue #956: KYLIN-4172 Enable renaming column name for 
streaming table
URL: https://github.com/apache/kylin/pull/956#issuecomment-557018744
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/956?src=pr=h1) Report
   > :exclamation: No coverage uploaded for pull request base 
(`master@1fcb731`). [Click here to learn what that 
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `66.66%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/kylin/pull/956/graphs/tree.svg?width=650=JawVgbgsVo=150=pr)](https://codecov.io/gh/apache/kylin/pull/956?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ## master #956   +/-   ##
   =
 Coverage  ?   25.57%   
 Complexity? 6138   
   =
 Files ? 1412   
 Lines ?85074   
 Branches  ?11928   
   =
 Hits  ?21756   
 Misses?61210   
 Partials  ? 2108
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/kylin/pull/956?src=pr=tree) | Coverage Δ 
| Complexity Δ | |
   |---|---|---|---|
   | 
[...lin/stream/source/kafka/TimedJsonStreamParser.java](https://codecov.io/gh/apache/kylin/pull/956/diff?src=pr=tree#diff-c3RyZWFtLXNvdXJjZS1rYWZrYS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RyZWFtL3NvdXJjZS9rYWZrYS9UaW1lZEpzb25TdHJlYW1QYXJzZXIuamF2YQ==)
 | `70.93% <66.66%> (ø)` | `12 <3> (?)` | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/kylin/pull/956?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/kylin/pull/956?src=pr=footer). Last 
update 
[1fcb731...ae418fb](https://codecov.io/gh/apache/kylin/pull/956?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [kylin] nichunen commented on issue #855: Update BatchMergeJobBuilder2.java

2019-11-21 Thread GitBox
nichunen commented on issue #855: Update BatchMergeJobBuilder2.java
URL: https://github.com/apache/kylin/pull/855#issuecomment-557012908
 
 
   Would you please update this PR?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [kylin] nichunen commented on issue #855: Update BatchMergeJobBuilder2.java

2019-11-21 Thread GitBox
nichunen commented on issue #855: Update BatchMergeJobBuilder2.java
URL: https://github.com/apache/kylin/pull/855#issuecomment-557012392
 
 
   @yz490700477 Hi, it's better to add a new job conf file for merging jobs


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [kylin] asf-ci commented on issue #956: KYLIN-4172 Enable renaming column name for streaming table

2019-11-21 Thread GitBox
asf-ci commented on issue #956: KYLIN-4172 Enable renaming column name for 
streaming table
URL: https://github.com/apache/kylin/pull/956#issuecomment-557003673
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [kylin] nichunen opened a new pull request #956: KYLIN-4172 Enable renaming column name for streaming table

2019-11-21 Thread GitBox
nichunen opened a new pull request #956: KYLIN-4172 Enable renaming column name 
for streaming table
URL: https://github.com/apache/kylin/pull/956
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [kylin] nichunen commented on issue #956: KYLIN-4172 Enable renaming column name for streaming table

2019-11-21 Thread GitBox
nichunen commented on issue #956: KYLIN-4172 Enable renaming column name for 
streaming table
URL: https://github.com/apache/kylin/pull/956#issuecomment-557003930
 
 
   @hit-lacus Would you please review this PR?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (KYLIN-4172) Can't rename field when map streaming schema to table

2019-11-21 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-4172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979132#comment-16979132
 ] 

ASF GitHub Bot commented on KYLIN-4172:
---

nichunen commented on pull request #956: KYLIN-4172 Enable renaming column name 
for streaming table
URL: https://github.com/apache/kylin/pull/956
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Can't rename field when map streaming schema to table
> -
>
> Key: KYLIN-4172
> URL: https://issues.apache.org/jira/browse/KYLIN-4172
> Project: Kylin
>  Issue Type: Bug
>  Components: Real-time Streaming
>Affects Versions: v3.0.0-alpha2
>Reporter: Peng Huang
>Priority: Major
> Fix For: v3.0.0
>
> Attachments: 微信截图_20190919102424.png
>
>
> When I map streaming schema to table, I don't know how to do it by myself. I 
> have to use auto-mapping by which i can't rename field.  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [kylin] nichunen merged pull request #954: Add more supported date format

2019-11-21 Thread GitBox
nichunen merged pull request #954: Add more supported date format
URL: https://github.com/apache/kylin/pull/954
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Resolved] (KYLIN-4193) More user-friendly page for loading streaming tables

2019-11-21 Thread nichunen (Jira)


 [ 
https://issues.apache.org/jira/browse/KYLIN-4193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

nichunen resolved KYLIN-4193.
-
Resolution: Fixed

> More user-friendly page for loading streaming tables
> 
>
> Key: KYLIN-4193
> URL: https://issues.apache.org/jira/browse/KYLIN-4193
> Project: Kylin
>  Issue Type: Improvement
>  Components: Real-time Streaming
>Affects Versions: v3.0.0-alpha
>Reporter: nichunen
>Priority: Major
> Fix For: v3.0.0
>
>
> After click "Add Streaming Table V2", the user has to set "TSParser" and 
> "TSPattern", these items may confuse users, they should be made more 
> user-friendly.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (KYLIN-4193) More user-friendly page for loading streaming tables

2019-11-21 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-4193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979120#comment-16979120
 ] 

ASF GitHub Bot commented on KYLIN-4193:
---

luguosheng1314 commented on pull request #955: KYLIN-4193 More user-friendly 
page for loading streaming tables
URL: https://github.com/apache/kylin/pull/955
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> More user-friendly page for loading streaming tables
> 
>
> Key: KYLIN-4193
> URL: https://issues.apache.org/jira/browse/KYLIN-4193
> Project: Kylin
>  Issue Type: Improvement
>  Components: Real-time Streaming
>Affects Versions: v3.0.0-alpha
>Reporter: nichunen
>Priority: Major
> Fix For: v3.0.0
>
>
> After click "Add Streaming Table V2", the user has to set "TSParser" and 
> "TSPattern", these items may confuse users, they should be made more 
> user-friendly.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (KYLIN-4193) More user-friendly page for loading streaming tables

2019-11-21 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-4193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979121#comment-16979121
 ] 

ASF subversion and git services commented on KYLIN-4193:


Commit 3e9c142db5436edf451651a1a9cb78b0403d438b in kylin's branch 
refs/heads/master from Chunen Ni
[ https://gitbox.apache.org/repos/asf?p=kylin.git;h=3e9c142 ]

KYLIN-4193 More user-friendly page for loading streaming tables


> More user-friendly page for loading streaming tables
> 
>
> Key: KYLIN-4193
> URL: https://issues.apache.org/jira/browse/KYLIN-4193
> Project: Kylin
>  Issue Type: Improvement
>  Components: Real-time Streaming
>Affects Versions: v3.0.0-alpha
>Reporter: nichunen
>Priority: Major
> Fix For: v3.0.0
>
>
> After click "Add Streaming Table V2", the user has to set "TSParser" and 
> "TSPattern", these items may confuse users, they should be made more 
> user-friendly.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [kylin] luguosheng1314 merged pull request #955: KYLIN-4193 More user-friendly page for loading streaming tables

2019-11-21 Thread GitBox
luguosheng1314 merged pull request #955: KYLIN-4193 More user-friendly page for 
loading streaming tables
URL: https://github.com/apache/kylin/pull/955
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (KYLIN-4193) More user-friendly page for loading streaming tables

2019-11-21 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-4193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979107#comment-16979107
 ] 

ASF GitHub Bot commented on KYLIN-4193:
---

nichunen commented on pull request #955: KYLIN-4193 More user-friendly page for 
loading streaming tables
URL: https://github.com/apache/kylin/pull/955
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> More user-friendly page for loading streaming tables
> 
>
> Key: KYLIN-4193
> URL: https://issues.apache.org/jira/browse/KYLIN-4193
> Project: Kylin
>  Issue Type: Improvement
>  Components: Real-time Streaming
>Affects Versions: v3.0.0-alpha
>Reporter: nichunen
>Priority: Major
> Fix For: v3.0.0
>
>
> After click "Add Streaming Table V2", the user has to set "TSParser" and 
> "TSPattern", these items may confuse users, they should be made more 
> user-friendly.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [kylin] nichunen opened a new pull request #955: KYLIN-4193 More user-friendly page for loading streaming tables

2019-11-21 Thread GitBox
nichunen opened a new pull request #955: KYLIN-4193 More user-friendly page for 
loading streaming tables
URL: https://github.com/apache/kylin/pull/955
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [kylin] asf-ci commented on issue #955: KYLIN-4193 More user-friendly page for loading streaming tables

2019-11-21 Thread GitBox
asf-ci commented on issue #955: KYLIN-4193 More user-friendly page for loading 
streaming tables
URL: https://github.com/apache/kylin/pull/955#issuecomment-556987438
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Updated] (KYLIN-4172) Can't rename field when map streaming schema to table

2019-11-21 Thread nichunen (Jira)


 [ 
https://issues.apache.org/jira/browse/KYLIN-4172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

nichunen updated KYLIN-4172:

Fix Version/s: (was: Future)
   v3.0.0

> Can't rename field when map streaming schema to table
> -
>
> Key: KYLIN-4172
> URL: https://issues.apache.org/jira/browse/KYLIN-4172
> Project: Kylin
>  Issue Type: Bug
>  Components: Real-time Streaming
>Affects Versions: v3.0.0-alpha2
>Reporter: Peng Huang
>Priority: Major
> Fix For: v3.0.0
>
> Attachments: 微信截图_20190919102424.png
>
>
> When I map streaming schema to table, I don't know how to do it by myself. I 
> have to use auto-mapping by which i can't rename field.  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)