[jira] [Created] (KYLIN-4430) Failed to find metadata store by url: kylin_metadata@hbase

2020-03-17 Thread Skywalker Yu (Jira)
Skywalker Yu created KYLIN-4430:
---

 Summary: Failed to find metadata store by url: kylin_metadata@hbase
 Key: KYLIN-4430
 URL: https://issues.apache.org/jira/browse/KYLIN-4430
 Project: Kylin
  Issue Type: Bug
  Components: Environment 
Affects Versions: v2.6.5
 Environment: kylin-2.6.5+hadoop-2.10.0+hbase-1.6.0+hive-3.1.2
Reporter: Skywalker Yu


2020-03-18 11:35:54,835 INFO  [main-SendThread(slave1:2181)] 
zookeeper.ClientCnxn:975 : Opening socket connection to server 
slave1/192.168.1.114:2181. Will not attempt to authenticate using SASL (unknown 
error)
2020-03-18 11:35:54,847 INFO  [main-SendThread(slave1:2181)] 
zookeeper.ClientCnxn:852 : Socket connection established to 
slave1/192.168.1.114:2181, initiating session
2020-03-18 11:35:54,858 INFO  [main-SendThread(slave1:2181)] 
zookeeper.ClientCnxn:1235 : Session establishment complete on server 
slave1/192.168.1.114:2181, sessionid = 0x170ebab574f0005, negotiated timeout = 
9
Exception in thread "main" java.lang.IllegalArgumentException: Failed to find 
metadata store by url: kylin_metadata@hbase
at 
org.apache.kylin.common.persistence.ResourceStore.createResourceStore(ResourceStore.java:99)
at 
org.apache.kylin.common.persistence.ResourceStore.getStore(ResourceStore.java:111)
at 
org.apache.kylin.rest.service.AclTableMigrationTool.checkIfNeedMigrate(AclTableMigrationTool.java:99)
at 
org.apache.kylin.tool.AclTableMigrationCLI.main(AclTableMigrationCLI.java:43)
Caused by: java.lang.reflect.InvocationTargetException
at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
at 
sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
at 
sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
at 
org.apache.kylin.common.persistence.ResourceStore.createResourceStore(ResourceStore.java:92)
... 3 more
Caused by: org.apache.hadoop.hbase.regionserver.NoSuchColumnFamilyException: 
org.apache.hadoop.hbase.regionserver.NoSuchColumnFamilyException: Column family 
table does not exist in region hbase:meta,,1.1588230740 in table 'hbase:meta', 
{TABLE_ATTRIBUTES => {IS_META => 'true', coprocessor$1 => 
'|org.apache.hadoop.hbase.coprocessor.MultiRowMutationEndpoint|536870911|'}, 
{NAME => 'info', BLOOMFILTER => 'NONE', VERSIONS => '3', IN_MEMORY => 'true', 
KEEP_DELETED_CELLS => 'FALSE', DATA_BLOCK_ENCODING => 'NONE', TTL => 'FOREVER', 
COMPRESSION => 'NONE', CACHE_DATA_IN_L1 => 'true', MIN_VERSIONS => '0', 
BLOCKCACHE => 'true', BLOCKSIZE => '8192', REPLICATION_SCOPE => '0'}
at 
org.apache.hadoop.hbase.regionserver.HRegion.checkFamily(HRegion.java:8414)
at org.apache.hadoop.hbase.regionserver.HRegion.get(HRegion.java:7398)
at 
org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2325)
at 
org.apache.hadoop.hbase.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:36800)
at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2399)
at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:124)
at 
org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:311)
at 
org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:291)

at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
at 
sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
at 
sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
at 
org.apache.hadoop.hbase.ipc.RemoteWithExtrasException.instantiateException(RemoteWithExtrasException.java:93)
at 
org.apache.hadoop.hbase.ipc.RemoteWithExtrasException.unwrapRemoteException(RemoteWithExtrasException.java:83)
at 
org.apache.hadoop.hbase.protobuf.ProtobufUtil.makeIOExceptionOfException(ProtobufUtil.java:277)
at 
org.apache.hadoop.hbase.protobuf.ProtobufUtil.handleRemoteException(ProtobufUtil.java:264)
at 
org.apache.hadoop.hbase.client.RegionServerCallable.call(RegionServerCallable.java:128)
at 
org.apache.hadoop.hbase.client.RpcRetryingCallerImpl.callWithRetries(RpcRetryingCallerImpl.java:106)
at org.apache.hadoop.hbase.client.HTable.get(HTable.java:395)
at org.apache.hadoop.hbase.client.HTable.get(HTable.java:369)
at 
org.apache.hadoop.hbase.MetaTableAccessor.getTableState(MetaTableAccessor.java:1108)
at 
org.apache.hadoop.hbase.MetaTableAccessor.tableExists(MetaTableAccessor.java:427)
at 
org.apache.hadoop.hbase.client.HBaseAdmin$6.rpcCall(HBaseAdmin.

[jira] [Updated] (KYLIN-4429) For LEAST_RESTRICTIVE consistency, which is the '=' operator, convert implicitly

2020-03-17 Thread Zhong Yanghong (Jira)


 [ 
https://issues.apache.org/jira/browse/KYLIN-4429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zhong Yanghong updated KYLIN-4429:
--
Parent: KYLIN-4419
Issue Type: Sub-task  (was: Improvement)

> For LEAST_RESTRICTIVE consistency, which is the '=' operator, convert 
> implicitly
> 
>
> Key: KYLIN-4429
> URL: https://issues.apache.org/jira/browse/KYLIN-4429
> Project: Kylin
>  Issue Type: Sub-task
>Reporter: Zhong Yanghong
>Assignee: Zhong Yanghong
>Priority: Major
>
> For the following sql,
> {code}
> select count(*)
> from TEST_KYLIN_FACT
> where cal_dt = date'2012-01-01'
> {code}
> , if the data type of *cal_dt* is varchar, the sql cannot run successfully 
> due to no implicitly data type conversion.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (KYLIN-4429) For LEAST_RESTRICTIVE consistency, which is the '=' operator, convert implicitly

2020-03-17 Thread Zhong Yanghong (Jira)
Zhong Yanghong created KYLIN-4429:
-

 Summary: For LEAST_RESTRICTIVE consistency, which is the '=' 
operator, convert implicitly
 Key: KYLIN-4429
 URL: https://issues.apache.org/jira/browse/KYLIN-4429
 Project: Kylin
  Issue Type: Improvement
Reporter: Zhong Yanghong
Assignee: Zhong Yanghong


For the following sql,
{code}
select count(*)
from TEST_KYLIN_FACT
where cal_dt = date'2012-01-01'
{code}
, if the data type of *cal_dt* is varchar, the sql cannot run successfully due 
to no implicitly data type conversion.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [kylin] coveralls edited a comment on issue #1162: KYLIN-4426 Refine CliCommandExecutor

2020-03-17 Thread GitBox
coveralls edited a comment on issue #1162: KYLIN-4426 Refine CliCommandExecutor
URL: https://github.com/apache/kylin/pull/1162#issuecomment-599816679
 
 
   ## Pull Request Test Coverage Report for [Build 
5773](https://coveralls.io/builds/29434005)
   
   * **4** of **11**   **(36.36%)**  changed or added relevant lines in **2** 
files are covered.
   * **8** unchanged lines in **4** files lost coverage.
   * Overall coverage decreased (**-0.002%**) to **27.512%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-|--||---: |
   | 
[server-base/src/main/java/org/apache/kylin/rest/service/CubeService.java](https://coveralls.io/builds/29434005/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FCubeService.java#L1133)
 | 0 | 7 | 0.0%
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-|--|--: |
   | 
[stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/ColumnarStoreCache.java](https://coveralls.io/builds/29434005/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2Fcolumnar%2FColumnarStoreCache.java#L146)
 | 1 | 56.82% |
   | 
[core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://coveralls.io/builds/29434005/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcuboid%2FTreeCuboidScheduler.java#L124)
 | 2 | 68.46% |
   | 
[core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java](https://coveralls.io/builds/29434005/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2Fimpl%2Fthreadpool%2FDefaultScheduler.java#L194)
 | 2 | 80.23% |
   | 
[core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/29434005/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L449)
 | 3 | 78.42% |
   
   
   |  Totals | [![Coverage 
Status](https://coveralls.io/builds/29434005/badge)](https://coveralls.io/builds/29434005)
 |
   | :-- | --: |
   | Change from base [Build 5753](https://coveralls.io/builds/29295116): |  
-0.002% |
   | Covered Lines: | 24297 |
   | Relevant Lines: | 88314 |
   
   ---
   # 💛  - [Coveralls](https://coveralls.io)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (KYLIN-4426) Refine CliCommandExecutor

2020-03-17 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-4426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17061336#comment-17061336
 ] 

ASF subversion and git services commented on KYLIN-4426:


Commit 9cc3793ab2f2f0053c467a9b3f38cb7791cd436a in kylin's branch 
refs/heads/master from XiaoxiangYu
[ https://gitbox.apache.org/repos/asf?p=kylin.git;h=9cc3793 ]

KYLIN-4426 Refine CliCommandExecutor


> Refine CliCommandExecutor 
> --
>
> Key: KYLIN-4426
> URL: https://issues.apache.org/jira/browse/KYLIN-4426
> Project: Kylin
>  Issue Type: Bug
>  Components: Tools, Build and Test
>Affects Versions: all
>Reporter: Xiaoxiang Yu
>Assignee: Xiaoxiang Yu
>Priority: Major
> Fix For: v3.1.0, v3.0.2, v2.6.6
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (KYLIN-4426) Refine CliCommandExecutor

2020-03-17 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-4426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17061335#comment-17061335
 ] 

ASF GitHub Bot commented on KYLIN-4426:
---

hit-lacus commented on pull request #1162: KYLIN-4426 Refine CliCommandExecutor
URL: https://github.com/apache/kylin/pull/1162
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Refine CliCommandExecutor 
> --
>
> Key: KYLIN-4426
> URL: https://issues.apache.org/jira/browse/KYLIN-4426
> Project: Kylin
>  Issue Type: Bug
>  Components: Tools, Build and Test
>Affects Versions: all
>Reporter: Xiaoxiang Yu
>Assignee: Xiaoxiang Yu
>Priority: Major
> Fix For: v3.1.0, v3.0.2, v2.6.6
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [kylin] hit-lacus merged pull request #1162: KYLIN-4426 Refine CliCommandExecutor

2020-03-17 Thread GitBox
hit-lacus merged pull request #1162: KYLIN-4426 Refine CliCommandExecutor
URL: https://github.com/apache/kylin/pull/1162
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [kylin] hit-lacus opened a new pull request #1162: KYLIN-4426 Refine CliCommandExecutor

2020-03-17 Thread GitBox
hit-lacus opened a new pull request #1162: KYLIN-4426 Refine CliCommandExecutor
URL: https://github.com/apache/kylin/pull/1162
 
 
   ## Proposed changes
   
   Describe the big picture of your changes here to communicate to the 
maintainers why we should accept this pull request. If it fixes a bug or 
resolves a feature request, be sure to link to that issue.
   
   ## Types of changes
   
   What types of changes does your code introduce to Kylin?
   _Put an `x` in the boxes that apply_
   
   - [x] Bugfix (non-breaking change which fixes an issue)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to not work as expected)
   - [ ] Documentation Update (if none of the other choices apply)
   
   ## Checklist
   
   _Put an `x` in the boxes that apply. You can also fill these out after 
creating the PR. If you're unsure about any of them, don't hesitate to ask. 
We're here to help! This is simply a reminder of what we are going to look for 
before merging your code._
   
   - [x] I have create an issue on [Kylin's 
jira](https://issues.apache.org/jira/browse/KYLIN), and have described the 
bug/feature there in detail
   - [x] Commit messages in my PR start with the related jira ID, like 
"KYLIN- Make Kylin project open-source"
   - [x] Compiling and unit tests pass locally with my changes
   - [x] I have added tests that prove my fix is effective or that my feature 
works
   - [ ] If this change need a document change, I will prepare another pr 
against the `document` branch
   - [x] Any dependent changes have been merged
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
user@kylin or dev@kylin by explaining why you chose the solution you did and 
what alternatives you considered, etc...
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (KYLIN-4426) Refine CliCommandExecutor

2020-03-17 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-4426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17061333#comment-17061333
 ] 

ASF GitHub Bot commented on KYLIN-4426:
---

hit-lacus commented on pull request #1162: KYLIN-4426 Refine CliCommandExecutor
URL: https://github.com/apache/kylin/pull/1162
 
 
   ## Proposed changes
   
   Describe the big picture of your changes here to communicate to the 
maintainers why we should accept this pull request. If it fixes a bug or 
resolves a feature request, be sure to link to that issue.
   
   ## Types of changes
   
   What types of changes does your code introduce to Kylin?
   _Put an `x` in the boxes that apply_
   
   - [x] Bugfix (non-breaking change which fixes an issue)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to not work as expected)
   - [ ] Documentation Update (if none of the other choices apply)
   
   ## Checklist
   
   _Put an `x` in the boxes that apply. You can also fill these out after 
creating the PR. If you're unsure about any of them, don't hesitate to ask. 
We're here to help! This is simply a reminder of what we are going to look for 
before merging your code._
   
   - [x] I have create an issue on [Kylin's 
jira](https://issues.apache.org/jira/browse/KYLIN), and have described the 
bug/feature there in detail
   - [x] Commit messages in my PR start with the related jira ID, like 
"KYLIN- Make Kylin project open-source"
   - [x] Compiling and unit tests pass locally with my changes
   - [x] I have added tests that prove my fix is effective or that my feature 
works
   - [ ] If this change need a document change, I will prepare another pr 
against the `document` branch
   - [x] Any dependent changes have been merged
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
user@kylin or dev@kylin by explaining why you chose the solution you did and 
what alternatives you considered, etc...
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Refine CliCommandExecutor 
> --
>
> Key: KYLIN-4426
> URL: https://issues.apache.org/jira/browse/KYLIN-4426
> Project: Kylin
>  Issue Type: Bug
>  Components: Tools, Build and Test
>Affects Versions: all
>Reporter: Xiaoxiang Yu
>Assignee: Xiaoxiang Yu
>Priority: Major
> Fix For: v3.1.0, v3.0.2, v2.6.6
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [kylin] coveralls edited a comment on issue #1156: KYLIN-4411 Job Engine Improvement

2020-03-17 Thread GitBox
coveralls edited a comment on issue #1156: KYLIN-4411 Job Engine Improvement
URL: https://github.com/apache/kylin/pull/1156#issuecomment-597011894
 
 
   ## Pull Request Test Coverage Report for [Build 
5772](https://coveralls.io/builds/29433624)
   
   * **1** of **139**   **(0.72%)**  changed or added relevant lines in **9** 
files are covered.
   * **12** unchanged lines in **9** files lost coverage.
   * Overall coverage decreased (**-0.03%**) to **27.481%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-|--||---: |
   | 
[core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java](https://coveralls.io/builds/29433624/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2FKylinConfigBase.java#L1263)
 | 0 | 2 | 0.0%
   | 
[engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/FactDistinctColumnsMapper.java](https://coveralls.io/builds/29433624/source?filename=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2Fsteps%2FFactDistinctColumnsMapper.java#L288)
 | 0 | 3 | 0.0%
   | 
[storage-hbase/src/main/java/org/apache/kylin/storage/hbase/steps/CreateHTableJob.java](https://coveralls.io/builds/29433624/source?filename=storage-hbase%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fhbase%2Fsteps%2FCreateHTableJob.java#L120)
 | 0 | 3 | 0.0%
   | 
[storage-hbase/src/main/java/org/apache/kylin/storage/hbase/steps/CubeHFileJob.java](https://coveralls.io/builds/29433624/source?filename=storage-hbase%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fhbase%2Fsteps%2FCubeHFileJob.java#L100)
 | 0 | 4 | 0.0%
   | 
[engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/ConvergeCuboidDataPartitioner.java](https://coveralls.io/builds/29433624/source?filename=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2Fsteps%2FConvergeCuboidDataPartitioner.java#L34)
 | 0 | 6 | 0.0%
   | 
[engine-mr/src/main/java/org/apache/kylin/engine/mr/common/AbstractHadoopJob.java](https://coveralls.io/builds/29433624/source?filename=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2Fcommon%2FAbstractHadoopJob.java#L599)
 | 0 | 13 | 0.0%
   | 
[storage-hbase/src/main/java/org/apache/kylin/storage/hbase/steps/CubeHTableUtil.java](https://coveralls.io/builds/29433624/source?filename=storage-hbase%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fhbase%2Fsteps%2FCubeHTableUtil.java#L63)
 | 0 | 42 | 0.0%
   | 
[storage-hbase/src/main/java/org/apache/kylin/storage/hbase/steps/HFileOutputFormat3.java](https://coveralls.io/builds/29433624/source?filename=storage-hbase%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fhbase%2Fsteps%2FHFileOutputFormat3.java#L171)
 | 0 | 65 | 0.0%
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-|--|--: |
   | 
[engine-mr/src/main/java/org/apache/kylin/engine/mr/common/AbstractHadoopJob.java](https://coveralls.io/builds/29433624/source?filename=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2Fcommon%2FAbstractHadoopJob.java#L636)
 | 1 | 15.7% |
   | 
[engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/ConvergeCuboidDataPartitioner.java](https://coveralls.io/builds/29433624/source?filename=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2Fsteps%2FConvergeCuboidDataPartitioner.java#L45)
 | 1 | 0% |
   | 
[engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/FactDistinctColumnsMapper.java](https://coveralls.io/builds/29433624/source?filename=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2Fsteps%2FFactDistinctColumnsMapper.java#L293)
 | 1 | 5.6% |
   | 
[storage-hbase/src/main/java/org/apache/kylin/storage/hbase/steps/CubeHFileJob.java](https://coveralls.io/builds/29433624/source?filename=storage-hbase%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fhbase%2Fsteps%2FCubeHFileJob.java#L107)
 | 1 | 0% |
   | 
[storage-hbase/src/main/java/org/apache/kylin/storage/hbase/steps/CubeHTableUtil.java](https://coveralls.io/builds/29433624/source?filename=storage-hbase%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fhbase%2Fsteps%2FCubeHTableUtil.java#L167)
 | 1 | 0% |
   | 
[storage-hbase/src/main/java/org/apache/kylin/storage/hbase/steps/HFileOutputFormat3.java](https://coveralls.io/builds/29433624/source?filename=storage-hbase%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fhbase%2Fsteps%2FHFileOutputFormat3.java#L173)
 | 1 | 0% |
   | 
[stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/ColumnarStoreCache.java](https://coveralls.io/builds/29433624/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2Fcolumnar%2FColumnarStoreCache.java#L146)
 | 1 | 56.82% |
   | 
[core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java](https://coveralls.io/builds/29433624/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin

[GitHub] [kylin] hit-lacus closed pull request #1042: Add user/user group management doc

2020-03-17 Thread GitBox
hit-lacus closed pull request #1042: Add user/user group management doc
URL: https://github.com/apache/kylin/pull/1042
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (KYLIN-4305) Streaming Receiver cannot limit income query request or cancel long-running query

2020-03-17 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-4305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17061304#comment-17061304
 ] 

ASF GitHub Bot commented on KYLIN-4305:
---

hit-lacus commented on pull request #1120: KYLIN-4305 Streaming Receiver cannot 
limit income query
URL: https://github.com/apache/kylin/pull/1120
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Streaming Receiver cannot limit income query request or cancel long-running 
> query
> -
>
> Key: KYLIN-4305
> URL: https://issues.apache.org/jira/browse/KYLIN-4305
> Project: Kylin
>  Issue Type: Improvement
>  Components: Real-time Streaming
>Reporter: Xiaoxiang Yu
>Assignee: Xiaoxiang Yu
>Priority: Major
> Fix For: v3.1.0
>
> Attachments: Jietu20191217-221025.png, after_repair_receiver.jstack, 
> image-2019-12-17-22-12-01-098.png, streaming_receiver_jstack.log
>
>
> When under heavy load(high rate of query request), receiver can not stand it, 
> and most quey may timeout, but the query processing thread cannot be 
> cancelled in receiver side, which will cause receiver's crash. You have to 
> restart it.
> kylin.log
> {code:java}
> Caused by: java.lang.RuntimeException: timeout when call stream rpc
>   at 
> org.apache.kylin.storage.stream.rpc.HttpStreamDataSearchClient$QueuedStreamingTupleIterator.hasNext(HttpStreamDataSearchClient.java:298)
>   at com.google.common.collect.Iterators$5.hasNext(Iterators.java:596)
>   at 
> org.apache.kylin.metadata.tuple.CompoundTupleIterator.hasNext(CompoundTupleIterator.java:52)
>   at 
> org.apache.kylin.query.enumerator.OLAPEnumerator.moveNext(OLAPEnumerator.java:63)
>   at Baz$1$1.moveNext(Unknown Source)
>   at 
> org.apache.calcite.linq4j.EnumerableDefaults.groupBy_(EnumerableDefaults.java:825)
>   at 
> org.apache.calcite.linq4j.EnumerableDefaults.groupBy(EnumerableDefaults.java:761)
>   at 
> org.apache.calcite.linq4j.DefaultEnumerable.groupBy(DefaultEnumerable.java:302)
>   at Baz.bind(Unknown Source)
>   at 
> org.apache.calcite.jdbc.CalcitePrepare$CalciteSignature.enumerable(CalcitePrepare.java:365)
>   at 
> org.apache.calcite.jdbc.CalciteConnectionImpl.enumerable(CalciteConnectionImpl.java:301)
>   at 
> org.apache.calcite.jdbc.CalciteMetaImpl._createIterable(CalciteMetaImpl.java:559)
>   at 
> org.apache.calcite.jdbc.CalciteMetaImpl.createIterable(CalciteMetaImpl.java:550)
>   at 
> org.apache.calcite.avatica.AvaticaResultSet.execute(AvaticaResultSet.java:182)
>   at 
> org.apache.calcite.jdbc.CalciteResultSet.execute(CalciteResultSet.java:67)
>   at 
> org.apache.calcite.jdbc.CalciteResultSet.execute(CalciteResultSet.java:44)
>   at 
> org.apache.calcite.avatica.AvaticaConnection$1.execute(AvaticaConnection.java:667)
>   at 
> org.apache.calcite.jdbc.CalciteMetaImpl.prepareAndExecute(CalciteMetaImpl.java:619)
>   at 
> org.apache.calcite.avatica.AvaticaConnection.prepareAndExecuteInternal(AvaticaConnection.java:675)
>   at 
> org.apache.calcite.avatica.AvaticaStatement.executeInternal(AvaticaStatement.java:156)
>   ... 83 more
> {code}
> jstack
> {code:java}
> "qtp1901663135-48" #48 prio=5 os_prio=0 tid=0x7f839995f800 nid=0x3cdd 
> runnable [0x7f83674fe000]
>java.lang.Thread.State: RUNNABLE
>   at java.lang.Thread.yield(Native Method)
>   at 
> org.apache.kylin.stream.core.query.MultiThreadsResultCollector$1.hasNext(MultiThreadsResultCollector.java:75)
>   at 
> org.apache.kylin.stream.core.query.RecordsAggregator.aggregate(RecordsAggregator.java:100)
>   at 
> org.apache.kylin.stream.core.query.StreamingCubeDataSearcher$StreamAggregateSearchResult.iterator(StreamingCubeDataSearcher.java:191)
>   at 
> org.apache.kylin.stream.server.rest.controller.DataController.query(DataController.java:119)
>   at sun.reflect.GeneratedMethodAccessor87.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.springframework.web.method.support.InvocableHandlerMethod.doInvoke(InvocableHandlerMethod.java:205)
>   at 
> org.springframework.web.method.support.InvocableHandlerMethod.invokeForRequest(InvocableHandlerMethod.java:133)
>   at 
> org.springframework.web.servlet.mvc.method.annotation.ServletInvocableHandlerMethod.invokeAndHandle(ServletInvocableHandlerMethod.java:97)
>   at 
> o

[jira] [Commented] (KYLIN-4355) Add validation for cube re-assignmnet(Realtime OLAP)

2020-03-17 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-4355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17061305#comment-17061305
 ] 

ASF GitHub Bot commented on KYLIN-4355:
---

hit-lacus commented on pull request #1121: KYLIN-4355 Add validation for cube 
assignment
URL: https://github.com/apache/kylin/pull/1121
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add validation for cube re-assignmnet(Realtime OLAP)
> 
>
> Key: KYLIN-4355
> URL: https://issues.apache.org/jira/browse/KYLIN-4355
> Project: Kylin
>  Issue Type: Bug
>  Components: Real-time Streaming
>Affects Versions: v3.0.0
>Reporter: Xiaoxiang Yu
>Assignee: Xiaoxiang Yu
>Priority: Minor
> Fix For: v3.1.0
>
>
> Case 1. In assignment, specific partition can be assign to more than one 
> replica set, thus cause receiver consumed duplicate kafka message.
> Case 2. In assignment, you can remove all partition for one repilca set, 
> which is make no sense at all.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [kylin] hit-lacus closed pull request #1121: KYLIN-4355 Add validation for cube assignment

2020-03-17 Thread GitBox
hit-lacus closed pull request #1121: KYLIN-4355 Add validation for cube 
assignment
URL: https://github.com/apache/kylin/pull/1121
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (KYLIN-4426) Refine CliCommandExecutor

2020-03-17 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-4426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17061302#comment-17061302
 ] 

ASF GitHub Bot commented on KYLIN-4426:
---

hit-lacus commented on pull request #1162: KYLIN-4426 Refine CliCommandExecutor
URL: https://github.com/apache/kylin/pull/1162
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Refine CliCommandExecutor 
> --
>
> Key: KYLIN-4426
> URL: https://issues.apache.org/jira/browse/KYLIN-4426
> Project: Kylin
>  Issue Type: Bug
>  Components: Tools, Build and Test
>Affects Versions: all
>Reporter: Xiaoxiang Yu
>Assignee: Xiaoxiang Yu
>Priority: Major
> Fix For: v3.1.0, v3.0.2, v2.6.6
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [kylin] hit-lacus closed pull request #1106: Read/write separated deployment doc

2020-03-17 Thread GitBox
hit-lacus closed pull request #1106: Read/write separated deployment doc
URL: https://github.com/apache/kylin/pull/1106
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [kylin] hit-lacus closed pull request #1120: KYLIN-4305 Streaming Receiver cannot limit income query

2020-03-17 Thread GitBox
hit-lacus closed pull request #1120: KYLIN-4305 Streaming Receiver cannot limit 
income query
URL: https://github.com/apache/kylin/pull/1120
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [kylin] hit-lacus closed pull request #1162: KYLIN-4426 Refine CliCommandExecutor

2020-03-17 Thread GitBox
hit-lacus closed pull request #1162: KYLIN-4426 Refine CliCommandExecutor
URL: https://github.com/apache/kylin/pull/1162
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [kylin] zzcclp commented on a change in pull request #1163: KYLIN-4423 fix bug: null input for EncryptUtil raise IllegalArgumentException

2020-03-17 Thread GitBox
zzcclp commented on a change in pull request #1163: KYLIN-4423 fix bug: null 
input for EncryptUtil raise IllegalArgumentException
URL: https://github.com/apache/kylin/pull/1163#discussion_r394024960
 
 

 ##
 File path: 
core-common/src/main/java/org/apache/kylin/common/util/EncryptUtil.java
 ##
 @@ -32,6 +32,9 @@
 0x65, 0x79 };
 
 public static String encrypt(String strToEncrypt) {
+if (strToEncrypt == null) {
 
 Review comment:
   Got it. Thanks for your explanation. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [kylin] coveralls edited a comment on issue #1157: KYLIN-4423 use spring session to support clustered sessions

2020-03-17 Thread GitBox
coveralls edited a comment on issue #1157: KYLIN-4423 use spring session to 
support clustered sessions
URL: https://github.com/apache/kylin/pull/1157#issuecomment-597203624
 
 
   ## Pull Request Test Coverage Report for [Build 
5771](https://coveralls.io/builds/29423040)
   
   * **13** of **42**   **(30.95%)**  changed or added relevant lines in **2** 
files are covered.
   * **3** unchanged lines in **1** file lost coverage.
   * Overall coverage increased (+**0.006%**) to **27.52%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-|--||---: |
   | 
[server-base/src/main/java/org/apache/kylin/rest/session/KylinSessionFilter.java](https://coveralls.io/builds/29423040/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fsession%2FKylinSessionFilter.java#L43)
 | 4 | 12 | 33.33%
   | 
[server-base/src/main/java/org/apache/kylin/rest/session/KylinSessionConfig.java](https://coveralls.io/builds/29423040/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fsession%2FKylinSessionConfig.java#L66)
 | 9 | 30 | 30.0%
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-|--|--: |
   | 
[core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/29423040/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L449)
 | 3 | 78.42% |
   
   
   |  Totals | [![Coverage 
Status](https://coveralls.io/builds/29423040/badge)](https://coveralls.io/builds/29423040)
 |
   | :-- | --: |
   | Change from base [Build 5753](https://coveralls.io/builds/29295116): |  
0.006% |
   | Covered Lines: | 24313 |
   | Relevant Lines: | 88347 |
   
   ---
   # 💛  - [Coveralls](https://coveralls.io)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [kylin] xiacongling commented on a change in pull request #1163: KYLIN-4423 fix bug: null input for EncryptUtil raise IllegalArgumentException

2020-03-17 Thread GitBox
xiacongling commented on a change in pull request #1163: KYLIN-4423 fix bug: 
null input for EncryptUtil raise IllegalArgumentException
URL: https://github.com/apache/kylin/pull/1163#discussion_r393752193
 
 

 ##
 File path: 
core-common/src/main/java/org/apache/kylin/common/util/EncryptUtil.java
 ##
 @@ -32,6 +32,9 @@
 0x65, 0x79 };
 
 public static String encrypt(String strToEncrypt) {
+if (strToEncrypt == null) {
 
 Review comment:
   Hi, zzcclp:
   Thanks for the suggestion. But actually, a blank string can be encrypted and 
its cypher text is not a blank string. 
   e.g. result of EncryptUtil.encrypt("") is "719bTBvphWewRiCiCj3D/A=="
   So only null check is needed, I think.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [kylin] zzcclp commented on a change in pull request #1163: KYLIN-4423 fix bug: null input for EncryptUtil raise IllegalArgumentException

2020-03-17 Thread GitBox
zzcclp commented on a change in pull request #1163: KYLIN-4423 fix bug: null 
input for EncryptUtil raise IllegalArgumentException
URL: https://github.com/apache/kylin/pull/1163#discussion_r393545950
 
 

 ##
 File path: 
core-common/src/main/java/org/apache/kylin/common/util/EncryptUtil.java
 ##
 @@ -32,6 +32,9 @@
 0x65, 0x79 };
 
 public static String encrypt(String strToEncrypt) {
+if (strToEncrypt == null) {
 
 Review comment:
   it's better use 'org.apache.commons.lang3.StringUtils.isBlank' to check 
blank string case.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [kylin] coveralls commented on issue #1163: KYLIN-4423 fix bug: null input for EncryptUtil raise IllegalArgumentException

2020-03-17 Thread GitBox
coveralls commented on issue #1163: KYLIN-4423 fix bug: null input for 
EncryptUtil raise IllegalArgumentException
URL: https://github.com/apache/kylin/pull/1163#issuecomment-599963168
 
 
   ## Pull Request Test Coverage Report for [Build 
5770](https://coveralls.io/builds/29412955)
   
   * **4** of **4**   **(100.0%)**  changed or added relevant lines in **1** 
file are covered.
   * **8** unchanged lines in **3** files lost coverage.
   * Overall coverage decreased (**-0.0001%**) to **27.514%**
   
   ---
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-|--|--: |
   | 
[core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://coveralls.io/builds/29412955/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcuboid%2FTreeCuboidScheduler.java#L124)
 | 2 | 68.46% |
   | 
[core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java](https://coveralls.io/builds/29412955/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2Fimpl%2Fthreadpool%2FDefaultScheduler.java#L194)
 | 2 | 80.23% |
   | 
[core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/29412955/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L449)
 | 4 | 78.12% |
   
   
   |  Totals | [![Coverage 
Status](https://coveralls.io/builds/29412955/badge)](https://coveralls.io/builds/29412955)
 |
   | :-- | --: |
   | Change from base [Build 5753](https://coveralls.io/builds/29295116): |  
-0.0001% |
   | Covered Lines: | 24297 |
   | Relevant Lines: | 88309 |
   
   ---
   # 💛  - [Coveralls](https://coveralls.io)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (KYLIN-4282) support case when in count (distinct)

2020-03-17 Thread Zhong Yanghong (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-4282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17060750#comment-17060750
 ] 

Zhong Yanghong commented on KYLIN-4282:
---

https://github.com/apache/kylin/pull/1144

> support case when in count (distinct)
> -
>
> Key: KYLIN-4282
> URL: https://issues.apache.org/jira/browse/KYLIN-4282
> Project: Kylin
>  Issue Type: Improvement
>Reporter: Zhong Yanghong
>Assignee: Zhong Yanghong
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (KYLIN-4423) use spring session to support clustered sessions

2020-03-17 Thread Yaqian Zhang (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-4423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17060729#comment-17060729
 ] 

Yaqian Zhang commented on KYLIN-4423:
-

Thanks congling!

Nice to see you fix it and update PR!

> use spring session to support clustered sessions
> 
>
> Key: KYLIN-4423
> URL: https://issues.apache.org/jira/browse/KYLIN-4423
> Project: Kylin
>  Issue Type: New Feature
>Reporter: Congling Xia
>Assignee: Congling Xia
>Priority: Major
>
> When routing different APIs to different kylin instances, user may encounter 
> permission problems since there are separate sessions.
> To share the sessions, one can config tomcat cluster to replicate all 
> sessions to all instances. It's a HA solution for Tomcat, and is rarely used 
> in recent years. Another idea is to store sessions in shared external 
> storages like Redis. 
> We choose the latter solution. Spring Session is used to help manage user 
> sessions and some work has been done to make it pluggable.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [kylin] xiacongling opened a new pull request #1163: fix bug: null input for EncryptUtil raise RuntimeException

2020-03-17 Thread GitBox
xiacongling opened a new pull request #1163: fix bug: null input for 
EncryptUtil raise RuntimeException
URL: https://github.com/apache/kylin/pull/1163
 
 
   ## Proposed changes
   Add condition to treet null input for EncryptUtil methods.  For default 
settings, password may not be set, so `null` will passed to 
`PasswordPlaceholderConfigurer#resolvePlaceholder`.  This will cause an 
"IllegalArgumentException: Null input buffer" and lead to startup failure. This 
fix treets `null` as a legal input and returns `null` for both encrytion and 
decrytion.
   
   ## Types of changes
   
   - [x] Bugfix (non-breaking change which fixes an issue)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to not work as expected)
   - [ ] Documentation Update (if none of the other choices apply)
   
   ## Checklist
   
   - [x] I have create an issue on [Kylin's 
jira](https://issues.apache.org/jira/browse/KYLIN-4423), and have described the 
bug/feature there in detail
   - [x] Commit messages in my PR start with the related jira ID, like 
"KYLIN- Make Kylin project open-source"
   - [x] Compiling and unit tests pass locally with my changes
   - [x] I have added tests that prove my fix is effective or that my feature 
works
   - [x] If this change need a document change, I will prepare another pr 
against the `document` branch
   - [ ] Any dependent changes have been merged
   
   ## Further comments
N/A


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [kylin] coveralls edited a comment on issue #1156: KYLIN-4411 Job Engine Improvement

2020-03-17 Thread GitBox
coveralls edited a comment on issue #1156: KYLIN-4411 Job Engine Improvement
URL: https://github.com/apache/kylin/pull/1156#issuecomment-597011894
 
 
   ## Pull Request Test Coverage Report for [Build 
5769](https://coveralls.io/builds/29412043)
   
   * **1** of **139**   **(0.72%)**  changed or added relevant lines in **9** 
files are covered.
   * **11** unchanged lines in **8** files lost coverage.
   * Overall coverage decreased (**-0.03%**) to **27.485%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-|--||---: |
   | 
[core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java](https://coveralls.io/builds/29412043/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2FKylinConfigBase.java#L1263)
 | 0 | 2 | 0.0%
   | 
[engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/FactDistinctColumnsMapper.java](https://coveralls.io/builds/29412043/source?filename=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2Fsteps%2FFactDistinctColumnsMapper.java#L288)
 | 0 | 3 | 0.0%
   | 
[storage-hbase/src/main/java/org/apache/kylin/storage/hbase/steps/CreateHTableJob.java](https://coveralls.io/builds/29412043/source?filename=storage-hbase%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fhbase%2Fsteps%2FCreateHTableJob.java#L120)
 | 0 | 3 | 0.0%
   | 
[storage-hbase/src/main/java/org/apache/kylin/storage/hbase/steps/CubeHFileJob.java](https://coveralls.io/builds/29412043/source?filename=storage-hbase%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fhbase%2Fsteps%2FCubeHFileJob.java#L100)
 | 0 | 4 | 0.0%
   | 
[engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/ConvergeCuboidDataPartitioner.java](https://coveralls.io/builds/29412043/source?filename=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2Fsteps%2FConvergeCuboidDataPartitioner.java#L34)
 | 0 | 6 | 0.0%
   | 
[engine-mr/src/main/java/org/apache/kylin/engine/mr/common/AbstractHadoopJob.java](https://coveralls.io/builds/29412043/source?filename=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2Fcommon%2FAbstractHadoopJob.java#L599)
 | 0 | 13 | 0.0%
   | 
[storage-hbase/src/main/java/org/apache/kylin/storage/hbase/steps/CubeHTableUtil.java](https://coveralls.io/builds/29412043/source?filename=storage-hbase%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fhbase%2Fsteps%2FCubeHTableUtil.java#L63)
 | 0 | 42 | 0.0%
   | 
[storage-hbase/src/main/java/org/apache/kylin/storage/hbase/steps/HFileOutputFormat3.java](https://coveralls.io/builds/29412043/source?filename=storage-hbase%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fhbase%2Fsteps%2FHFileOutputFormat3.java#L171)
 | 0 | 65 | 0.0%
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-|--|--: |
   | 
[engine-mr/src/main/java/org/apache/kylin/engine/mr/common/AbstractHadoopJob.java](https://coveralls.io/builds/29412043/source?filename=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2Fcommon%2FAbstractHadoopJob.java#L636)
 | 1 | 15.7% |
   | 
[engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/ConvergeCuboidDataPartitioner.java](https://coveralls.io/builds/29412043/source?filename=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2Fsteps%2FConvergeCuboidDataPartitioner.java#L45)
 | 1 | 0% |
   | 
[engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/FactDistinctColumnsMapper.java](https://coveralls.io/builds/29412043/source?filename=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2Fsteps%2FFactDistinctColumnsMapper.java#L293)
 | 1 | 5.6% |
   | 
[storage-hbase/src/main/java/org/apache/kylin/storage/hbase/steps/CubeHFileJob.java](https://coveralls.io/builds/29412043/source?filename=storage-hbase%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fhbase%2Fsteps%2FCubeHFileJob.java#L107)
 | 1 | 0% |
   | 
[storage-hbase/src/main/java/org/apache/kylin/storage/hbase/steps/CubeHTableUtil.java](https://coveralls.io/builds/29412043/source?filename=storage-hbase%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fhbase%2Fsteps%2FCubeHTableUtil.java#L167)
 | 1 | 0% |
   | 
[storage-hbase/src/main/java/org/apache/kylin/storage/hbase/steps/HFileOutputFormat3.java](https://coveralls.io/builds/29412043/source?filename=storage-hbase%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fhbase%2Fsteps%2FHFileOutputFormat3.java#L173)
 | 1 | 0% |
   | 
[core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://coveralls.io/builds/29412043/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcuboid%2FTreeCuboidScheduler.java#L124)
 | 2 | 68.46% |
   | 
[core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/29412043/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L44

[jira] [Commented] (KYLIN-4423) use spring session to support clustered sessions

2020-03-17 Thread Congling Xia (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-4423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17060695#comment-17060695
 ] 

Congling Xia commented on KYLIN-4423:
-

Hi, Yaqian:
Thanks for the feedback. I found the stacktrace like this: 

{code:java}
2020-03-17 07:23:07,392 ERROR [localhost-startStop-1] context.ContextLoader:350 
: Context initialization failed
org.springframework.beans.factory.BeanDefinitionStoreException: Invalid bean 
definition with name 'redisConnectionFactory' defined in file 
[/home/admin/apache-kylin-3.0.1-bin-hbase1x/tomcat/webapps/kylin/WEB-INF/classes/kylin-session-plugin.xml]:
 Null input buffer; nested exception is java.lang.RuntimeException: Null input 
buffer
at 
org.springframework.beans.factory.config.PlaceholderConfigurerSupport.doProcessProperties(PlaceholderConfigurerSupport.java:223)
at 
org.springframework.beans.factory.config.PropertyPlaceholderConfigurer.processProperties(PropertyPlaceholderConfigurer.java:222)
at 
org.springframework.beans.factory.config.PropertyResourceConfigurer.postProcessBeanFactory(PropertyResourceConfigurer.java:86)
at 
org.springframework.context.support.PostProcessorRegistrationDelegate.invokeBeanFactoryPostProcessors(PostProcessorRegistrationDelegate.java:281)
at 
org.springframework.context.support.PostProcessorRegistrationDelegate.invokeBeanFactoryPostProcessors(PostProcessorRegistrationDelegate.java:161)
at 
org.springframework.context.support.AbstractApplicationContext.invokeBeanFactoryPostProcessors(AbstractApplicationContext.java:687)
at 
org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:525)
at 
org.springframework.web.context.ContextLoader.configureAndRefreshWebApplicationContext(ContextLoader.java:443)
at 
org.springframework.web.context.ContextLoader.initWebApplicationContext(ContextLoader.java:325)
at 
org.springframework.web.context.ContextLoaderListener.contextInitialized(ContextLoaderListener.java:107)
at 
org.apache.catalina.core.StandardContext.listenerStart(StandardContext.java:5197)
at 
org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:5720)
at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
at 
org.apache.catalina.core.ContainerBase.addChildInternal(ContainerBase.java:1016)
at 
org.apache.catalina.core.ContainerBase.addChild(ContainerBase.java:992)
at org.apache.catalina.core.StandardHost.addChild(StandardHost.java:639)
at 
org.apache.catalina.startup.HostConfig.deployWAR(HostConfig.java:1127)
at 
org.apache.catalina.startup.HostConfig$DeployWar.run(HostConfig.java:2020)
at 
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
Caused by: java.lang.RuntimeException: Null input buffer
at org.apache.kylin.common.util.EncryptUtil.decrypt(EncryptUtil.java:55)
at 
org.apache.kylin.rest.security.PasswordPlaceholderConfigurer.resolvePlaceholder(PasswordPlaceholderConfigurer.java:77)
at 
org.springframework.beans.factory.config.PropertyPlaceholderConfigurer.resolvePlaceholder(PropertyPlaceholderConfigurer.java:162)
at 
org.springframework.beans.factory.config.PropertyPlaceholderConfigurer$PropertyPlaceholderConfigurerResolver.resolvePlaceholder(PropertyPlaceholderConfigurer.java:277)
at 
org.springframework.util.PropertyPlaceholderHelper.parseStringValue(PropertyPlaceholderHelper.java:147)
at 
org.springframework.util.PropertyPlaceholderHelper.replacePlaceholders(PropertyPlaceholderHelper.java:126)
at 
org.springframework.beans.factory.config.PropertyPlaceholderConfigurer$PlaceholderResolvingStringValueResolver.resolveStringValue(PropertyPlaceholderConfigurer.java:258)
at 
org.springframework.beans.factory.config.BeanDefinitionVisitor.resolveStringValue(BeanDefinitionVisitor.java:282)
at 
org.springframework.beans.factory.config.BeanDefinitionVisitor.resolveValue(BeanDefinitionVisitor.java:204)
at 
org.springframework.beans.factory.config.BeanDefinitionVisitor.visitPropertyValues(BeanDefinitionVisitor.java:141)
at 
org.springframework.beans.factory.config.BeanDefinitionVisitor.visitBeanDefinition(BeanDefinitionVisitor.java:82)
at 
org.springframework.beans.factory.config.PlaceholderConfigurerSupport.doProcessProperties(PlaceholderConfigurerSupport.java:220)
... 22 more
Caused by: java.lang.IllegalArgumentException: Null input buffer
at javax.crypto.Cipher.doFinal(Cipher.jav