[jira] [Commented] (KYLIN-3271) Optimize sub-path check of ResourceTool

2020-10-14 Thread Zhong Yanghong (Jira) 


[ 
https://issues.apache.org/jira/browse/KYLIN-3271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214421#comment-17214421
 ] 

Zhong Yanghong commented on KYLIN-3271:
---

This change blocks the following command:
{code}
${KYLIN_HOME}/bin/metastore.sh fetch /execute
{code}

> Optimize sub-path check of ResourceTool
> ---
>
> Key: KYLIN-3271
> URL: https://issues.apache.org/jira/browse/KYLIN-3271
> Project: Kylin
>  Issue Type: Improvement
>  Components: Metadata
>Affects Versions: v2.2.0
>Reporter: nichunen
>Assignee: nichunen
>Priority: Minor
> Fix For: v2.4.0
>
>
> kylin uses class org.apache.kylin.common.persistence.ResourceTool to do 
> metadata download, upload, remove, etc. The algorithm for resource 
> transversal is not very effective. For instance, for an "execute_output" with 
> key "/execute_output/\{uuid}", the algorithm will try to check whether it's a 
> folder with sub-resources, this makes un-necessary time cost, and in cases of 
> metadata with lots of jobs, it may last for a long time before the finish.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Reopened] (KYLIN-3271) Optimize sub-path check of ResourceTool

2020-10-14 Thread Zhong Yanghong (Jira) 


 [ 
https://issues.apache.org/jira/browse/KYLIN-3271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zhong Yanghong reopened KYLIN-3271:
---

> Optimize sub-path check of ResourceTool
> ---
>
> Key: KYLIN-3271
> URL: https://issues.apache.org/jira/browse/KYLIN-3271
> Project: Kylin
>  Issue Type: Improvement
>  Components: Metadata
>Affects Versions: v2.2.0
>Reporter: nichunen
>Assignee: nichunen
>Priority: Minor
> Fix For: v2.4.0
>
>
> kylin uses class org.apache.kylin.common.persistence.ResourceTool to do 
> metadata download, upload, remove, etc. The algorithm for resource 
> transversal is not very effective. For instance, for an "execute_output" with 
> key "/execute_output/\{uuid}", the algorithm will try to check whether it's a 
> folder with sub-resources, this makes un-necessary time cost, and in cases of 
> metadata with lots of jobs, it may last for a long time before the finish.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [kylin] coveralls edited a comment on pull request #1448: Auto add USE $DATABASE; to the beginning of create_sample_tables.sql

2020-10-14 Thread GitBox 


coveralls edited a comment on pull request #1448:
URL: https://github.com/apache/kylin/pull/1448#issuecomment-708347841


   ## Pull Request Test Coverage Report for [Build 
6457](https://coveralls.io/builds/34186811)
   
   * **0** of **0**   changed or added relevant lines in **0** files are 
covered.
   * **9** unchanged lines in **2** files lost coverage.
   * Overall coverage decreased (**-0.005%**) to **28.045%**
   
   ---
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-|--|--: |
   | 
[stream-core/src/main/java/org/apache/kylin/stream/core/storage/CheckPointStore.java](https://coveralls.io/builds/34186811/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2FCheckPointStore.java#L98)
 | 2 | 73.74% |
   | 
[core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/34186811/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L193)
 | 7 | 76.29% |
   
   
   |  Totals | [![Coverage 
Status](https://coveralls.io/builds/34186811/badge)](https://coveralls.io/builds/34186811)
 |
   | :-- | --: |
   | Change from base [Build 6452](https://coveralls.io/builds/34141224): |  
-0.005% |
   | Covered Lines: | 26250 |
   | Relevant Lines: | 93598 |
   
   ---
   #   - [Coveralls](https://coveralls.io)
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kylin] coveralls edited a comment on pull request #1448: Auto add USE $DATABASE; to the beginning of create_sample_tables.sql

2020-10-14 Thread GitBox 


coveralls edited a comment on pull request #1448:
URL: https://github.com/apache/kylin/pull/1448#issuecomment-708347841


   ## Pull Request Test Coverage Report for [Build 
6458](https://coveralls.io/builds/34186813)
   
   * **0** of **0**   changed or added relevant lines in **0** files are 
covered.
   * **5** unchanged lines in **3** files lost coverage.
   * Overall coverage decreased (**-0.002%**) to **28.049%**
   
   ---
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-|--|--: |
   | 
[tool/src/main/java/org/apache/kylin/tool/query/ProbabilityGenerator.java](https://coveralls.io/builds/34186813/source?filename=tool%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Ftool%2Fquery%2FProbabilityGenerator.java#L42)
 | 1 | 81.58% |
   | 
[core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://coveralls.io/builds/34186813/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcuboid%2FTreeCuboidScheduler.java#L124)
 | 2 | 68.46% |
   | 
[stream-core/src/main/java/org/apache/kylin/stream/core/storage/CheckPointStore.java](https://coveralls.io/builds/34186813/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2FCheckPointStore.java#L98)
 | 2 | 73.74% |
   
   
   |  Totals | [![Coverage 
Status](https://coveralls.io/builds/34186813/badge)](https://coveralls.io/builds/34186813)
 |
   | :-- | --: |
   | Change from base [Build 6452](https://coveralls.io/builds/34141224): |  
-0.002% |
   | Covered Lines: | 26253 |
   | Relevant Lines: | 93598 |
   
   ---
   #   - [Coveralls](https://coveralls.io)
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (KYLIN-4788) add segmentName and regionName in Coprocessor deadline info

2020-10-14 Thread ASF GitHub Bot (Jira) 


[ 
https://issues.apache.org/jira/browse/KYLIN-4788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214386#comment-17214386
 ] 

ASF GitHub Bot commented on KYLIN-4788:
---

coveralls commented on pull request #1449:
URL: https://github.com/apache/kylin/pull/1449#issuecomment-708869790


   ## Pull Request Test Coverage Report for [Build 
6456](https://coveralls.io/builds/34186266)
   
   * **13** of **152**   **(8.55%)**  changed or added relevant lines in **3** 
files are covered.
   * **16** unchanged lines in **5** files lost coverage.
   * Overall coverage decreased (**-0.04%**) to **28.01%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-|--||---: |
   | 
[storage-hbase/src/main/java/org/apache/kylin/storage/hbase/cube/v2/CubeHBaseEndpointRPC.java](https://coveralls.io/builds/34186266/source?filename=storage-hbase%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fhbase%2Fcube%2Fv2%2FCubeHBaseEndpointRPC.java#L274)
 | 0 | 1 | 0.0%
   | 
[storage-hbase/src/main/java/org/apache/kylin/storage/hbase/cube/v2/coprocessor/endpoint/CubeVisitService.java](https://coveralls.io/builds/34186266/source?filename=storage-hbase%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fhbase%2Fcube%2Fv2%2Fcoprocessor%2Fendpoint%2FCubeVisitService.java#L227)
 | 2 | 4 | 50.0%
   | 
[storage-hbase/src/main/java/org/apache/kylin/storage/hbase/cube/v2/coprocessor/endpoint/generated/CubeVisitProtos.java](https://coveralls.io/builds/34186266/source?filename=storage-hbase%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fhbase%2Fcube%2Fv2%2Fcoprocessor%2Fendpoint%2Fgenerated%2FCubeVisitProtos.java#L264)
 | 11 | 147 | 7.48%
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-|--|--: |
   | 
[stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/ColumnarStoreCache.java](https://coveralls.io/builds/34186266/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2Fcolumnar%2FColumnarStoreCache.java#L146)
 | 1 | 56.82% |
   | 
[stream-core/src/main/java/org/apache/kylin/stream/core/storage/CheckPointStore.java](https://coveralls.io/builds/34186266/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2FCheckPointStore.java#L98)
 | 2 | 73.74% |
   | 
[tool/src/main/java/org/apache/kylin/tool/query/ProbabilityGenerator.java](https://coveralls.io/builds/34186266/source?filename=tool%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Ftool%2Fquery%2FProbabilityGenerator.java#L42)
 | 3 | 76.32% |
   | 
[core-metrics/src/main/java/org/apache/kylin/metrics/lib/impl/MetricsSystem.java](https://coveralls.io/builds/34186266/source?filename=core-metrics%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetrics%2Flib%2Fimpl%2FMetricsSystem.java#L46)
 | 5 | 66.67% |
   | 
[storage-hbase/src/main/java/org/apache/kylin/storage/hbase/cube/v2/coprocessor/endpoint/generated/CubeVisitProtos.java](https://coveralls.io/builds/34186266/source?filename=storage-hbase%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fhbase%2Fcube%2Fv2%2Fcoprocessor%2Fendpoint%2Fgenerated%2FCubeVisitProtos.java#L261)
 | 5 | 18.16% |
   
   
   |  Totals | [![Coverage 
Status](https://coveralls.io/builds/34186266/badge)](https://coveralls.io/builds/34186266)
 |
   | :-- | --: |
   | Change from base [Build 6452](https://coveralls.io/builds/34141224): |  
-0.04% |
   | Covered Lines: | 26259 |
   | Relevant Lines: | 93749 |
   
   ---
   #   - [Coveralls](https://coveralls.io)
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> add segmentName and regionName in Coprocessor deadline info
> ---
>
> Key: KYLIN-4788
> URL: https://issues.apache.org/jira/browse/KYLIN-4788
> Project: Kylin
>  Issue Type: Improvement
>  Components: Storage - HBase
>Affects Versions: v3.1.0
>Reporter: fengpod
>Priority: Minor
>
> For locating the cube and region exactly when Coprocessor throws deadline 
> exception，add segmentName and regionName to the exception info。
> The exception info will looks like this：
> !https://user-images.githubusercontent.com/4843586/96071432-b7890d00-0ed4-11eb-8f16-15caa6efcc39.png!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [kylin] coveralls commented on pull request #1449: KYLIN-4788 add segmentName and regionName in Coprocessor deadline info

2020-10-14 Thread GitBox 


coveralls commented on pull request #1449:
URL: https://github.com/apache/kylin/pull/1449#issuecomment-708869790


   ## Pull Request Test Coverage Report for [Build 
6456](https://coveralls.io/builds/34186266)
   
   * **13** of **152**   **(8.55%)**  changed or added relevant lines in **3** 
files are covered.
   * **16** unchanged lines in **5** files lost coverage.
   * Overall coverage decreased (**-0.04%**) to **28.01%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-|--||---: |
   | 
[storage-hbase/src/main/java/org/apache/kylin/storage/hbase/cube/v2/CubeHBaseEndpointRPC.java](https://coveralls.io/builds/34186266/source?filename=storage-hbase%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fhbase%2Fcube%2Fv2%2FCubeHBaseEndpointRPC.java#L274)
 | 0 | 1 | 0.0%
   | 
[storage-hbase/src/main/java/org/apache/kylin/storage/hbase/cube/v2/coprocessor/endpoint/CubeVisitService.java](https://coveralls.io/builds/34186266/source?filename=storage-hbase%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fhbase%2Fcube%2Fv2%2Fcoprocessor%2Fendpoint%2FCubeVisitService.java#L227)
 | 2 | 4 | 50.0%
   | 
[storage-hbase/src/main/java/org/apache/kylin/storage/hbase/cube/v2/coprocessor/endpoint/generated/CubeVisitProtos.java](https://coveralls.io/builds/34186266/source?filename=storage-hbase%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fhbase%2Fcube%2Fv2%2Fcoprocessor%2Fendpoint%2Fgenerated%2FCubeVisitProtos.java#L264)
 | 11 | 147 | 7.48%
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-|--|--: |
   | 
[stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/ColumnarStoreCache.java](https://coveralls.io/builds/34186266/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2Fcolumnar%2FColumnarStoreCache.java#L146)
 | 1 | 56.82% |
   | 
[stream-core/src/main/java/org/apache/kylin/stream/core/storage/CheckPointStore.java](https://coveralls.io/builds/34186266/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2FCheckPointStore.java#L98)
 | 2 | 73.74% |
   | 
[tool/src/main/java/org/apache/kylin/tool/query/ProbabilityGenerator.java](https://coveralls.io/builds/34186266/source?filename=tool%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Ftool%2Fquery%2FProbabilityGenerator.java#L42)
 | 3 | 76.32% |
   | 
[core-metrics/src/main/java/org/apache/kylin/metrics/lib/impl/MetricsSystem.java](https://coveralls.io/builds/34186266/source?filename=core-metrics%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetrics%2Flib%2Fimpl%2FMetricsSystem.java#L46)
 | 5 | 66.67% |
   | 
[storage-hbase/src/main/java/org/apache/kylin/storage/hbase/cube/v2/coprocessor/endpoint/generated/CubeVisitProtos.java](https://coveralls.io/builds/34186266/source?filename=storage-hbase%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fhbase%2Fcube%2Fv2%2Fcoprocessor%2Fendpoint%2Fgenerated%2FCubeVisitProtos.java#L261)
 | 5 | 18.16% |
   
   
   |  Totals | [![Coverage 
Status](https://coveralls.io/builds/34186266/badge)](https://coveralls.io/builds/34186266)
 |
   | :-- | --: |
   | Change from base [Build 6452](https://coveralls.io/builds/34141224): |  
-0.04% |
   | Covered Lines: | 26259 |
   | Relevant Lines: | 93749 |
   
   ---
   #   - [Coveralls](https://coveralls.io)
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Created] (KYLIN-4788) add segmentName and regionName in Coprocessor deadline info

2020-10-14 Thread fengpod (Jira) 
fengpod created KYLIN-4788:
--

 Summary: add segmentName and regionName in Coprocessor deadline 
info
 Key: KYLIN-4788
 URL: https://issues.apache.org/jira/browse/KYLIN-4788
 Project: Kylin
  Issue Type: Improvement
  Components: Storage - HBase
Affects Versions: v3.1.0
Reporter: fengpod


For locating the cube and region exactly when Coprocessor throws deadline 
exception，add segmentName and regionName to the exception info。

The exception info will looks like this：

!https://user-images.githubusercontent.com/4843586/96071432-b7890d00-0ed4-11eb-8f16-15caa6efcc39.png!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [kylin] fengpod commented on pull request #1449: add segmentName and regionName in Coprocessor deadline info

2020-10-14 Thread GitBox 


fengpod commented on pull request #1449:
URL: https://github.com/apache/kylin/pull/1449#issuecomment-708862735


   Add segmentName and regionName to Coprocessor deadline exception info,for 
locating the cube and region exactly。
   When Coprocessor throws dealline expcetion，the info will looks like this：
   
![image](https://user-images.githubusercontent.com/4843586/96071432-b7890d00-0ed4-11eb-8f16-15caa6efcc39.png)
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kylin] fengpod opened a new pull request #1449: add segmentName and regionName in Coprocessor deadline info

2020-10-14 Thread GitBox 


fengpod opened a new pull request #1449:
URL: https://github.com/apache/kylin/pull/1449


   ## Proposed changes
   
   Describe the big picture of your changes here to communicate to the 
maintainers why we should accept this pull request. If it fixes a bug or 
resolves a feature request, be sure to link to that issue.
   
   ## Types of changes
   
   What types of changes does your code introduce to Kylin?
   _Put an `x` in the boxes that apply_
   
   - [ ] Bugfix (non-breaking change which fixes an issue)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to not work as expected)
   - [ ] Documentation Update (if none of the other choices apply)
   
   ## Checklist
   
   _Put an `x` in the boxes that apply. You can also fill these out after 
creating the PR. If you're unsure about any of them, don't hesitate to ask. 
We're here to help! This is simply a reminder of what we are going to look for 
before merging your code._
   
   - [ ] I have create an issue on [Kylin's 
jira](https://issues.apache.org/jira/browse/KYLIN), and have described the 
bug/feature there in detail
   - [ ] Commit messages in my PR start with the related jira ID, like 
"KYLIN- Make Kylin project open-source"
   - [ ] Compiling and unit tests pass locally with my changes
   - [ ] I have added tests that prove my fix is effective or that my feature 
works
   - [ ] If this change need a document change, I will prepare another pr 
against the `document` branch
   - [ ] Any dependent changes have been merged
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
user@kylin or dev@kylin by explaining why you chose the solution you did and 
what alternatives you considered, etc...
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kylin] zzcclp commented on pull request #1448: Auto add USE $DATABASE; to the beginning of create_sample_tables.sql

2020-10-14 Thread GitBox 


zzcclp commented on pull request #1448:
URL: https://github.com/apache/kylin/pull/1448#issuecomment-708851074


   LGTM



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kylin] coveralls commented on pull request #1448: Auto add USE $DATABASE; to the beginning of create_sample_tables.sql

2020-10-14 Thread GitBox 


coveralls commented on pull request #1448:
URL: https://github.com/apache/kylin/pull/1448#issuecomment-708347841


   ## Pull Request Test Coverage Report for [Build 
6454](https://coveralls.io/builds/34165485)
   
   * **0** of **0**   changed or added relevant lines in **0** files are 
covered.
   * **2** unchanged lines in **1** file lost coverage.
   * Overall coverage decreased (**-0.001%**) to **28.05%**
   
   ---
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-|--|--: |
   | 
[core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://coveralls.io/builds/34165485/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcuboid%2FTreeCuboidScheduler.java#L124)
 | 2 | 68.46% |
   
   
   |  Totals | [![Coverage 
Status](https://coveralls.io/builds/34165485/badge)](https://coveralls.io/builds/34165485)
 |
   | :-- | --: |
   | Change from base [Build 6452](https://coveralls.io/builds/34141224): |  
-0.001% |
   | Covered Lines: | 26254 |
   | Relevant Lines: | 93598 |
   
   ---
   #   - [Coveralls](https://coveralls.io)
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kylin] zhangayqian opened a new pull request #1448: Auto add USE $DATABASE; to the beginning of create_sample_tables.sql

2020-10-14 Thread GitBox 


zhangayqian opened a new pull request #1448:
URL: https://github.com/apache/kylin/pull/1448


   ## Proposed changes
   
   Describe the big picture of your changes here to communicate to the 
maintainers why we should accept this pull request. If it fixes a bug or 
resolves a feature request, be sure to link to that issue.
   
   ## Types of changes
   
   What types of changes does your code introduce to Kylin?
   _Put an `x` in the boxes that apply_
   
   - [ ] Bugfix (non-breaking change which fixes an issue)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to not work as expected)
   - [ ] Documentation Update (if none of the other choices apply)
   
   ## Checklist
   
   _Put an `x` in the boxes that apply. You can also fill these out after 
creating the PR. If you're unsure about any of them, don't hesitate to ask. 
We're here to help! This is simply a reminder of what we are going to look for 
before merging your code._
   
   - [ ] I have create an issue on [Kylin's 
jira](https://issues.apache.org/jira/browse/KYLIN), and have described the 
bug/feature there in detail
   - [ ] Commit messages in my PR start with the related jira ID, like 
"KYLIN- Make Kylin project open-source"
   - [ ] Compiling and unit tests pass locally with my changes
   - [ ] I have added tests that prove my fix is effective or that my feature 
works
   - [ ] If this change need a document change, I will prepare another pr 
against the `document` branch
   - [ ] Any dependent changes have been merged
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
user@kylin or dev@kylin by explaining why you chose the solution you did and 
what alternatives you considered, etc...
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Created] (KYLIN-4787) The script sample.sh cannot automatically switch to the hive database set by the user to create sample hive tables

2020-10-14 Thread Yaqian Zhang (Jira) 
Yaqian Zhang created KYLIN-4787:
---

 Summary: The script sample.sh cannot automatically switch to the 
hive database set by the user to create sample hive tables
 Key: KYLIN-4787
 URL: https://issues.apache.org/jira/browse/KYLIN-4787
 Project: Kylin
  Issue Type: Bug
  Components: Client - CLI
Affects Versions: v3.1.0, v3.1.1
 Environment: HDP3
Reporter: Yaqian Zhang
Assignee: Yaqian Zhang
 Fix For: v3.1.2


The script sample.sh use --database to specifies create_sample_ tables.sql 
execute in which database, but this parameter has been cancelled in hive3.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [kylin] zhangayqian opened a new pull request #1447: Add some missing tutorial

2020-10-14 Thread GitBox 


zhangayqian opened a new pull request #1447:
URL: https://github.com/apache/kylin/pull/1447


   ## Proposed changes
   
   Describe the big picture of your changes here to communicate to the 
maintainers why we should accept this pull request. If it fixes a bug or 
resolves a feature request, be sure to link to that issue.
   
   ## Types of changes
   
   What types of changes does your code introduce to Kylin?
   _Put an `x` in the boxes that apply_
   
   - [ ] Bugfix (non-breaking change which fixes an issue)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to not work as expected)
   - [ ] Documentation Update (if none of the other choices apply)
   
   ## Checklist
   
   _Put an `x` in the boxes that apply. You can also fill these out after 
creating the PR. If you're unsure about any of them, don't hesitate to ask. 
We're here to help! This is simply a reminder of what we are going to look for 
before merging your code._
   
   - [ ] I have create an issue on [Kylin's 
jira](https://issues.apache.org/jira/browse/KYLIN), and have described the 
bug/feature there in detail
   - [ ] Commit messages in my PR start with the related jira ID, like 
"KYLIN- Make Kylin project open-source"
   - [ ] Compiling and unit tests pass locally with my changes
   - [ ] I have added tests that prove my fix is effective or that my feature 
works
   - [ ] If this change need a document change, I will prepare another pr 
against the `document` branch
   - [ ] Any dependent changes have been merged
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
user@kylin or dev@kylin by explaining why you chose the solution you did and 
what alternatives you considered, etc...
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org