[jira] [Commented] (KYLIN-5217) Create a initial commit
[ https://issues.apache.org/jira/browse/KYLIN-5217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17574491#comment-17574491 ] ASF GitHub Bot commented on KYLIN-5217: --- hit-lacus merged PR #1907: URL: https://github.com/apache/kylin/pull/1907 > Create a initial commit > --- > > Key: KYLIN-5217 > URL: https://issues.apache.org/jira/browse/KYLIN-5217 > Project: Kylin > Issue Type: Sub-task >Reporter: Xiaoxiang Yu >Assignee: Xiaoxiang Yu >Priority: Major > Fix For: 5.0-alpha > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5217) Create a initial commit
[ https://issues.apache.org/jira/browse/KYLIN-5217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17574492#comment-17574492 ] ASF subversion and git services commented on KYLIN-5217: Commit 6d03e21244a56d4a6669b42a22b05e3a64bc7440 in kylin's branch refs/heads/kylin5 from Mukvin [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=6d03e21244 ] KYLIN-5217, fix ut in kylin-modeling-service module > Create a initial commit > --- > > Key: KYLIN-5217 > URL: https://issues.apache.org/jira/browse/KYLIN-5217 > Project: Kylin > Issue Type: Sub-task >Reporter: Xiaoxiang Yu >Assignee: Xiaoxiang Yu >Priority: Major > Fix For: 5.0-alpha > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [kylin] hit-lacus merged pull request #1907: KYLIN-5217, fix ut in kylin-modeling-service module
hit-lacus merged PR #1907: URL: https://github.com/apache/kylin/pull/1907 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (KYLIN-5223) Prepare simple CI for kylin5 branch
[ https://issues.apache.org/jira/browse/KYLIN-5223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17574489#comment-17574489 ] ASF subversion and git services commented on KYLIN-5223: Commit b6891750a589b5b6d820a4d0721487123ab69f21 in kylin's branch refs/heads/kylin5 from Xiaoxiang Yu [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=b6891750a5 ] KYLIN-5223 Create a "Integration Test" module create a empty maven module upload sql and meta files > Prepare simple CI for kylin5 branch > --- > > Key: KYLIN-5223 > URL: https://issues.apache.org/jira/browse/KYLIN-5223 > Project: Kylin > Issue Type: Sub-task >Reporter: Xiaoxiang Yu >Assignee: Xiaoxiang Yu >Priority: Major > Fix For: 5.0-alpha > > > Run `mvn clean package -DskipTests` for PR check. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [kylin] hit-lacus merged pull request #1904: Fix UT for Kylin 5.0
hit-lacus merged PR #1904: URL: https://github.com/apache/kylin/pull/1904 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (KYLIN-5217) Create a initial commit
[ https://issues.apache.org/jira/browse/KYLIN-5217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17574462#comment-17574462 ] ASF GitHub Bot commented on KYLIN-5217: --- Mukvin opened a new pull request, #1907: URL: https://github.com/apache/kylin/pull/1907 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. ## Github Branch As most of the development works are on Kylin 4, we need to switch it as main branch. Apache Kylin community changes the branch settings on Github since 2021-08-04 : 1. The default branch _main_ is for **Kylin 4.x** (Parquet storage); 2. The original branch _master_ for **Kylin 3.x** (HBase storage) has been renamed to **kylin3** ; Please check [Intro to Kylin 4 architecture](https://kylin.apache.org/blog/2021/07/02/Apache-Kylin4-A-new-storage-and-compute-architecture/) and [INFRA-22166](https://issues.apache.org/jira/browse/INFRA-22166) if you are interested. ## Types of changes What types of changes does your code introduce to Kylin? _Put an `x` in the boxes that apply_ - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation Update (if none of the other choices apply) ## Checklist _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._ - [ ] I have create an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail - [ ] Commit messages in my PR start with the related jira ID, like "KYLIN- Make Kylin project open-source" - [ ] Compiling and unit tests pass locally with my changes - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have added necessary documentation (if appropriate) - [ ] Any dependent changes have been merged ## Further comments If this is a relatively large or complex change, kick off the discussion at u...@kylin.apache.org or d...@kylin.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc... > Create a initial commit > --- > > Key: KYLIN-5217 > URL: https://issues.apache.org/jira/browse/KYLIN-5217 > Project: Kylin > Issue Type: Sub-task >Reporter: Xiaoxiang Yu >Assignee: Xiaoxiang Yu >Priority: Major > Fix For: 5.0-alpha > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [kylin] Mukvin opened a new pull request, #1907: KYLIN-5217, fix ut in kylin-modeling-service module
Mukvin opened a new pull request, #1907: URL: https://github.com/apache/kylin/pull/1907 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. ## Github Branch As most of the development works are on Kylin 4, we need to switch it as main branch. Apache Kylin community changes the branch settings on Github since 2021-08-04 : 1. The default branch _main_ is for **Kylin 4.x** (Parquet storage); 2. The original branch _master_ for **Kylin 3.x** (HBase storage) has been renamed to **kylin3** ; Please check [Intro to Kylin 4 architecture](https://kylin.apache.org/blog/2021/07/02/Apache-Kylin4-A-new-storage-and-compute-architecture/) and [INFRA-22166](https://issues.apache.org/jira/browse/INFRA-22166) if you are interested. ## Types of changes What types of changes does your code introduce to Kylin? _Put an `x` in the boxes that apply_ - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation Update (if none of the other choices apply) ## Checklist _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._ - [ ] I have create an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail - [ ] Commit messages in my PR start with the related jira ID, like "KYLIN- Make Kylin project open-source" - [ ] Compiling and unit tests pass locally with my changes - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have added necessary documentation (if appropriate) - [ ] Any dependent changes have been merged ## Further comments If this is a relatively large or complex change, kick off the discussion at u...@kylin.apache.org or d...@kylin.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (KYLIN-5215) The metadata information returned by Kylin pushdown query and Cube query is inconsistent
[
https://issues.apache.org/jira/browse/KYLIN-5215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17574455#comment-17574455
]
gaogao commented on KYLIN-5215:
---
example: select count(*) as "COUNT__stime" from tabletest
在指标查询的时候加上 as 和双引号就会这样。
cube query result:
{isNullable: 0, displaySize: 19, label: "COUNT__stime", name: "COUNT__stime",
schemaName: null,…}
pushdown query result:
{isNullable: 0, displaySize: 2147483647, label: "COUNT__STIME", name:
"COUNT__STIME", schemaName: null,…}
> The metadata information returned by Kylin pushdown query and Cube query is
> inconsistent
>
>
> Key: KYLIN-5215
> URL: https://issues.apache.org/jira/browse/KYLIN-5215
> Project: Kylin
> Issue Type: Bug
> Components: Spark Engine
>Affects Versions: all, v4.0.1
> Environment: kylin 4.0.1
>Reporter: gaogao
>Priority: Major
> Attachments: cube_query.png, pushdown_query.png
>
>
> 问题：
> 在下压查询中返回的结果 和 cube 查询的结果不一致，下压查询中 columnMetas 的 label 和 name 字段会默认转换成大写！
> 对应源码类
> PushDownRunnerSparkImpl 50行
> ：
>
> {code:java}
> // fill in selected column meta
> for (int i = 0; i < columnCount; ++i) {
> int nullable = fieldList.get(i).isNullable() ? 1 : 0;
> columnMetas.add(new SelectedColumnMeta(false, false, false, false, nullable,
> true, Integer.MAX_VALUE,
> fieldList.get(i).getName().toUpperCase(Locale.ROOT),
> fieldList.get(i).getName().toUpperCase(Locale.ROOT), null, null,
> null, fieldList.get(i).getPrecision(), fieldList.get(i).getScale(),
> fieldList.get(i).getDataType(),
> fieldList.get(i).getDataTypeName(), false, false, false));
> }
>
> {code}
>
> pushdown query:
> !c:\Users\Administrator\AppData\Local\YNote\data\weixinobU7VjlOcNgcm0ZbmNGYzYRPZ__4\401fe7a7ea05495799145f2d413b0da4\clipboard.png!
> cube query:
> !c:\Users\Administrator\AppData\Local\YNote\data\weixinobU7VjlOcNgcm0ZbmNGYzYRPZ__4\0ef826f0229f42b59c4ad946a08bf6f3\clipboard.png!
>
> 我认为这个问题应该修复，因为在尝试对接superset时发现，有些此类框架会强校验元数据列的大小写，如果默认进行转换会导致无法适配，且cube
> query和pushdown query查询的元数据列结果不一致这也是无法接受的。
>
> 如果讨论有需要的话，我可以修复他，谢谢~
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [kylin] hit-lacus commented on pull request #1904: Travis CI
hit-lacus commented on PR #1904: URL: https://github.com/apache/kylin/pull/1904#issuecomment-1203386481 ### UT Fail Detail ``` [INFO] Results: [INFO] [ERROR] Errors: [ERROR] NDefaultSchedulerTest.testSubmitParallelTasksReachMemoryQuota:1894 » ConditionTimeout [INFO] [ERROR] Tests run: 101, Failures: 0, Errors: 1, Skipped: 1 [INFO] [INFO] [INFO] BUILD FAILURE [INFO] [INFO] Total time: 16:02 min [INFO] Finished at: 2022-08-02T23:06:50+08:00 [INFO] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test (default-test) on project kylin-core-job: There are test failures. [ERROR] [ERROR] Please refer to /Users/xiaoxiang.yu/IDEA_Project/Kylin5/src/core-job/../../target/surefire-reports for the individual test results. [ERROR] Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream. [ERROR] -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException [INFO] Results: [INFO] [ERROR] Errors: [ERROR] SparkSourceServiceTest.testExecuteSQL:115 » NoClassDefFound Could not initiali... [ERROR] SparkSourceServiceTest.testGetTableDesc:154 » NoClassDefFound Could not initia... [ERROR] SparkSourceServiceTest.testLoadSamples2:267 » NoClassDefFound Could not initia... [ERROR] SparkSourceServiceTest.setUp:80 » NoSuchMethod com.google.common.base.Enums.va... [INFO] [ERROR] Tests run: 38, Failures: 0, Errors: 4, Skipped: 0 [INFO] [INFO] [INFO] BUILD FAILURE [INFO] [INFO] Total time: 27:31 min [INFO] Finished at: 2022-08-02T23:47:30+08:00 [INFO] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test (default-test) on project kylin-datasource-service: There are test failures. [ERROR] [ERROR] Please refer to /Users/xiaoxiang.yu/IDEA_Project/Kylin5/src/datasource-service/../../target/surefire-reports for the individual test results. [ERROR] Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream. [INFO] Results: [INFO] [ERROR] Errors: [ERROR] MetaStoreServiceTest.testCheckModelMetadataModelDifferentMultiplePartitionColumnWithEmptyValue:677 » FileNotFound [ERROR] MetaStoreServiceTest.testCheckModelMetadataModelEmptyMultiplePartitionValues:663 » FileNotFound [ERROR] MetaStoreServiceTest.testCheckModelMetadataModelMultiplePartition:640 » FileNotFound [ERROR] MetaStoreServiceTest.testCheckModelMetadataModelMultiplePartitionColumnsChanged:623 » FileNotFound [ERROR] MetaStoreServiceTest.testCheckModelMetadataModelMultiplePartitionWithDifferentPartitionValueOrder:698 » FileNotFound [ERROR] MetaStoreServiceTest.testCheckModelMetadataModelMultiplePartitionWithPartitionValueReduce:712 » FileNotFound [ERROR] MetaStoreServiceTest.testGetModelMetadataProjectName:1357 » FileNotFound ../. [ERROR] MetaStoreServiceTest.testImportModelMetadataWithMultiplePartitionValue:1097 » FileNotFound [ERROR] MetaStoreServiceTest.testImportModelMetadataWithoutMultiplePartitionValue:1152 » FileNotFound [ERROR] MetaStoreServiceTest.testReduceColumn:1340 » FileNotFound ../../../kyligence/s... [ERROR] TableServiceTest.testRefreshSparkTable:1240 » NoSuchMethod com.google.common.b... [INFO] [ERROR] Tests run: 526, Failures: 0, Errors: 11, Skipped: 3 [INFO] [INFO] [INFO] BUILD FAILURE [INFO] [INFO] Total time: 01:19 h [INFO] Finished at: 2022-08-03T01:12:09+08:00 [INFO] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test (default-test) on project kylin-modeling-service: There are test failures. [ERROR] [ERROR] Please refer to /Users/xiaoxiang.yu/IDEA_Project/Kylin5/src/modeling-service/../../target/surefire-reports for the individual test results. [INFO] Results: [INFO] [ERROR] Errors:
[GitHub] [kylin] hit-lacus commented on pull request #1904: Travis CI
hit-lacus commented on PR #1904:
URL: https://github.com/apache/kylin/pull/1904#issuecomment-1203384012
## Running UT in Mac
```
##ci_output="/root/xiaoxiang.yu/reports/kylin_ci_output-`date
+"%Y-%m-%d"`.txt"
ci_output=kylin.txt
mvn -U clean install -T 2C -Dmaven.compile.fork=true -DskipTests
echo "--- Kylin Install Success ---"
mvn clean test --fail-at-end -pl src/assembly >>${ci_output}
mvn clean test --fail-at-end -pl src/common-booter >>${ci_output}
mvn clean test --fail-at-end -pl src/common-server >>${ci_output}
mvn clean test --fail-at-end -pl src/common-service >>${ci_output}
mvn clean test --fail-at-end -pl src/core-common >>${ci_output}
mvn clean test --fail-at-end -pl src/core-job >>${ci_output}
mvn clean test --fail-at-end -pl src/core-metadata >>${ci_output}
mvn clean test --fail-at-end -pl src/core-storage >>${ci_output}
mvn clean test --fail-at-end -pl src/data-loading-booter >>${ci_output}
mvn clean test --fail-at-end -pl src/data-loading-server >>${ci_output}
mvn clean test --fail-at-end -pl src/data-loading-service >>${ci_output}
mvn clean test --fail-at-end -pl src/datasource-sdk >>${ci_output}
mvn clean test --fail-at-end -pl src/datasource-service >>${ci_output}
mvn clean test --fail-at-end -pl src/examples >>${ci_output}
mvn clean test --fail-at-end -pl src/external >>${ci_output}
mvn clean test --fail-at-end -pl src/external-catalog >>${ci_output}
mvn clean test --fail-at-end -pl src/integration-service >>${ci_output}
mvn clean test --fail-at-end -pl src/job-service >>${ci_output}
mvn clean test --fail-at-end -pl src/license >>${ci_output}
mvn clean test --fail-at-end -pl src/metadata-server >>${ci_output}
mvn clean test --fail-at-end -pl src/modeling-service >>${ci_output}
mvn clean test --fail-at-end -pl src/query >>${ci_output}
mvn clean test --fail-at-end -pl src/query-booter >>${ci_output}
mvn clean test --fail-at-end -pl src/query-common >>${ci_output}
mvn clean test --fail-at-end -pl src/query-server >>${ci_output}
mvn clean test --fail-at-end -pl src/query-service >>${ci_output}
mvn clean test --fail-at-end -pl src/second-storage >>${ci_output}
mvn clean test --fail-at-end -pl src/server >>${ci_output}
mvn clean test --fail-at-end -pl src/server-base >>${ci_output}
mvn clean test --fail-at-end -pl src/source-hive >>${ci_output}
mvn clean test --fail-at-end -pl src/spark-project >>${ci_output}
mvn clean test --fail-at-end -pl src/streaming >>${ci_output}
mvn clean test --fail-at-end -pl src/streaming-service >>${ci_output}
mvn clean test --fail-at-end -pl src/systools >>${ci_output}
mvn clean test --fail-at-end -pl src/target >>${ci_output}
mvn clean test --fail-at-end -pl src/tool >>${ci_output}
echo "--- Kylin Test Success ---"
```
### Results
```
(base) XXYU-MBP:Kylin5 xiaoxiang.yu$ cat kylin.txt | grep
"maven-surefire-plugin:3.0.0-M5:test"
[INFO] --- maven-surefire-plugin:3.0.0-M5:test (default-test) @
kylin-assembly ---
[INFO] --- maven-surefire-plugin:3.0.0-M5:test (default-test) @
kylin-common-booter ---
[INFO] --- maven-surefire-plugin:3.0.0-M5:test (default-test) @
kylin-common-server ---
[INFO] --- maven-surefire-plugin:3.0.0-M5:test (default-test) @
kylin-common-service ---
[INFO] --- maven-surefire-plugin:3.0.0-M5:test (default-test) @
kylin-core-common ---
[INFO] --- maven-surefire-plugin:3.0.0-M5:test (default-test) @
kylin-core-job ---
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test (default-test) on
project kylin-core-job: There are test failures.
[INFO] --- maven-surefire-plugin:3.0.0-M5:test (default-test) @
kylin-core-metadata ---
[INFO] --- maven-surefire-plugin:3.0.0-M5:test (default-test) @
kylin-core-storage ---
[INFO] --- maven-surefire-plugin:3.0.0-M5:test (default-test) @
kylin-data-loading-booter ---
[INFO] --- maven-surefire-plugin:3.0.0-M5:test (default-test) @
kylin-data-loading-server ---
[INFO] --- maven-surefire-plugin:3.0.0-M5:test (default-test) @
kylin-data-loading-service ---
[INFO] --- maven-surefire-plugin:3.0.0-M5:test (default-test) @
kylin-datasource-sdk ---
[INFO] --- maven-surefire-plugin:3.0.0-M5:test (default-test) @
kylin-datasource-service ---
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test (default-test) on
project kylin-datasource-service: There are test failures.
[INFO] --- maven-surefire-plugin:3.0.0-M5:test (default-test) @
kylin-integration-service ---
[INFO] --- maven-surefire-plugin:3.0.0-M5:test (default-test) @
kylin-job-service ---
[INFO] --- maven-surefire-plugin:3.0.0-M5:test (default-test) @
kylin-metadata-server ---
[INFO] --- maven-surefire-plugin:3.0.0-M5:test (default-test) @
kylin-modeling-service ---
[ERROR] Failed to execute goal
[GitHub] [kylin] hit-lacus commented on pull request #1904: Travis CI
hit-lacus commented on PR #1904: URL: https://github.com/apache/kylin/pull/1904#issuecomment-1203338080  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (KYLIN-5223) Prepare simple CI for kylin5 branch
[ https://issues.apache.org/jira/browse/KYLIN-5223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17574250#comment-17574250 ] ASF subversion and git services commented on KYLIN-5223: Commit 9066b89d3e277578921a188928cf38713cf0c015 in kylin's branch refs/heads/kylin5 from Xiaoxiang Yu [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=9066b89d3e ] KYLIN-5223 simple travis ci > Prepare simple CI for kylin5 branch > --- > > Key: KYLIN-5223 > URL: https://issues.apache.org/jira/browse/KYLIN-5223 > Project: Kylin > Issue Type: Sub-task >Reporter: Xiaoxiang Yu >Assignee: Xiaoxiang Yu >Priority: Major > Fix For: 5.0-alpha > > > Run `mvn clean package -DskipTests` for PR check. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5217) Create a initial commit
[ https://issues.apache.org/jira/browse/KYLIN-5217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17574187#comment-17574187 ] ASF GitHub Bot commented on KYLIN-5217: --- hit-lacus merged PR #1906: URL: https://github.com/apache/kylin/pull/1906 > Create a initial commit > --- > > Key: KYLIN-5217 > URL: https://issues.apache.org/jira/browse/KYLIN-5217 > Project: Kylin > Issue Type: Sub-task >Reporter: Xiaoxiang Yu >Assignee: Xiaoxiang Yu >Priority: Major > Fix For: 5.0-alpha > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5217) Create a initial commit
[ https://issues.apache.org/jira/browse/KYLIN-5217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17574188#comment-17574188 ] ASF subversion and git services commented on KYLIN-5217: Commit da6be7fccf27704d0a4ac1a5c542adca9ec5f62c in kylin's branch refs/heads/kylin5 from Mukvin [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=da6be7fccf ] KYLIN-5217, fix ut in kylin-query module > Create a initial commit > --- > > Key: KYLIN-5217 > URL: https://issues.apache.org/jira/browse/KYLIN-5217 > Project: Kylin > Issue Type: Sub-task >Reporter: Xiaoxiang Yu >Assignee: Xiaoxiang Yu >Priority: Major > Fix For: 5.0-alpha > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [kylin] hit-lacus merged pull request #1906: KYLIN-5217, fix ut in kylin-query module
hit-lacus merged PR #1906: URL: https://github.com/apache/kylin/pull/1906 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (KYLIN-5217) Create a initial commit
[ https://issues.apache.org/jira/browse/KYLIN-5217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17574183#comment-17574183 ] ASF GitHub Bot commented on KYLIN-5217: --- Mukvin opened a new pull request, #1906: URL: https://github.com/apache/kylin/pull/1906 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. ## Github Branch As most of the development works are on Kylin 4, we need to switch it as main branch. Apache Kylin community changes the branch settings on Github since 2021-08-04 : 1. The default branch _main_ is for **Kylin 4.x** (Parquet storage); 2. The original branch _master_ for **Kylin 3.x** (HBase storage) has been renamed to **kylin3** ; Please check [Intro to Kylin 4 architecture](https://kylin.apache.org/blog/2021/07/02/Apache-Kylin4-A-new-storage-and-compute-architecture/) and [INFRA-22166](https://issues.apache.org/jira/browse/INFRA-22166) if you are interested. ## Types of changes What types of changes does your code introduce to Kylin? _Put an `x` in the boxes that apply_ - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation Update (if none of the other choices apply) ## Checklist _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._ - [ ] I have create an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail - [ ] Commit messages in my PR start with the related jira ID, like "KYLIN- Make Kylin project open-source" - [ ] Compiling and unit tests pass locally with my changes - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have added necessary documentation (if appropriate) - [ ] Any dependent changes have been merged ## Further comments If this is a relatively large or complex change, kick off the discussion at u...@kylin.apache.org or d...@kylin.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc... > Create a initial commit > --- > > Key: KYLIN-5217 > URL: https://issues.apache.org/jira/browse/KYLIN-5217 > Project: Kylin > Issue Type: Sub-task >Reporter: Xiaoxiang Yu >Assignee: Xiaoxiang Yu >Priority: Major > Fix For: 5.0-alpha > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [kylin] Mukvin opened a new pull request, #1906: KYLIN-5217, fix ut in kylin-query module
Mukvin opened a new pull request, #1906: URL: https://github.com/apache/kylin/pull/1906 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. ## Github Branch As most of the development works are on Kylin 4, we need to switch it as main branch. Apache Kylin community changes the branch settings on Github since 2021-08-04 : 1. The default branch _main_ is for **Kylin 4.x** (Parquet storage); 2. The original branch _master_ for **Kylin 3.x** (HBase storage) has been renamed to **kylin3** ; Please check [Intro to Kylin 4 architecture](https://kylin.apache.org/blog/2021/07/02/Apache-Kylin4-A-new-storage-and-compute-architecture/) and [INFRA-22166](https://issues.apache.org/jira/browse/INFRA-22166) if you are interested. ## Types of changes What types of changes does your code introduce to Kylin? _Put an `x` in the boxes that apply_ - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation Update (if none of the other choices apply) ## Checklist _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._ - [ ] I have create an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail - [ ] Commit messages in my PR start with the related jira ID, like "KYLIN- Make Kylin project open-source" - [ ] Compiling and unit tests pass locally with my changes - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have added necessary documentation (if appropriate) - [ ] Any dependent changes have been merged ## Further comments If this is a relatively large or complex change, kick off the discussion at u...@kylin.apache.org or d...@kylin.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (KYLIN-5215) The metadata information returned by Kylin pushdown query and Cube query is inconsistent
[
https://issues.apache.org/jira/browse/KYLIN-5215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17574178#comment-17574178
]
ASF GitHub Bot commented on KYLIN-5215:
---
liyang-kylin commented on PR #1900:
URL: https://github.com/apache/kylin/pull/1900#issuecomment-1202333933
pending on design discussion in
https://issues.apache.org/jira/projects/KYLIN/issues/KYLIN-5215
> The metadata information returned by Kylin pushdown query and Cube query is
> inconsistent
>
>
> Key: KYLIN-5215
> URL: https://issues.apache.org/jira/browse/KYLIN-5215
> Project: Kylin
> Issue Type: Bug
> Components: Spark Engine
>Affects Versions: all, v4.0.1
> Environment: kylin 4.0.1
>Reporter: gaogao
>Priority: Major
> Attachments: cube_query.png, pushdown_query.png
>
>
> 问题：
> 在下压查询中返回的结果 和 cube 查询的结果不一致，下压查询中 columnMetas 的 label 和 name 字段会默认转换成大写！
> 对应源码类
> PushDownRunnerSparkImpl 50行
> ：
>
> {code:java}
> // fill in selected column meta
> for (int i = 0; i < columnCount; ++i) {
> int nullable = fieldList.get(i).isNullable() ? 1 : 0;
> columnMetas.add(new SelectedColumnMeta(false, false, false, false, nullable,
> true, Integer.MAX_VALUE,
> fieldList.get(i).getName().toUpperCase(Locale.ROOT),
> fieldList.get(i).getName().toUpperCase(Locale.ROOT), null, null,
> null, fieldList.get(i).getPrecision(), fieldList.get(i).getScale(),
> fieldList.get(i).getDataType(),
> fieldList.get(i).getDataTypeName(), false, false, false));
> }
>
> {code}
>
> pushdown query:
> !c:\Users\Administrator\AppData\Local\YNote\data\weixinobU7VjlOcNgcm0ZbmNGYzYRPZ__4\401fe7a7ea05495799145f2d413b0da4\clipboard.png!
> cube query:
> !c:\Users\Administrator\AppData\Local\YNote\data\weixinobU7VjlOcNgcm0ZbmNGYzYRPZ__4\0ef826f0229f42b59c4ad946a08bf6f3\clipboard.png!
>
> 我认为这个问题应该修复，因为在尝试对接superset时发现，有些此类框架会强校验元数据列的大小写，如果默认进行转换会导致无法适配，且cube
> query和pushdown query查询的元数据列结果不一致这也是无法接受的。
>
> 如果讨论有需要的话，我可以修复他，谢谢~
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [kylin] liyang-kylin commented on pull request #1900: [KYLIN-5215] Fix Kylin pushdown query and Cube query is inconsistent
liyang-kylin commented on PR #1900: URL: https://github.com/apache/kylin/pull/1900#issuecomment-1202333933 pending on design discussion in https://issues.apache.org/jira/projects/KYLIN/issues/KYLIN-5215 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (KYLIN-5215) The metadata information returned by Kylin pushdown query and Cube query is inconsistent
[
https://issues.apache.org/jira/browse/KYLIN-5215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17574176#comment-17574176
]
liyang commented on KYLIN-5215:
---
Kylin 的对外元数据默认都是大写，也就是比如 hive 数据源中用的是小写的表名和列名，从 Kylin 暴漏出来后将都是大写。
估计这也就是为什么原来代码里用了 upperCase() 把下推返回 name & label 也变成默认大写。
例子中的情况比较神奇是，cube 查询返回的 name & label 为什么是小写的值得研究一下。
> The metadata information returned by Kylin pushdown query and Cube query is
> inconsistent
>
>
> Key: KYLIN-5215
> URL: https://issues.apache.org/jira/browse/KYLIN-5215
> Project: Kylin
> Issue Type: Bug
> Components: Spark Engine
>Affects Versions: all, v4.0.1
> Environment: kylin 4.0.1
>Reporter: gaogao
>Priority: Major
> Attachments: cube_query.png, pushdown_query.png
>
>
> 问题：
> 在下压查询中返回的结果 和 cube 查询的结果不一致，下压查询中 columnMetas 的 label 和 name 字段会默认转换成大写！
> 对应源码类
> PushDownRunnerSparkImpl 50行
> ：
>
> {code:java}
> // fill in selected column meta
> for (int i = 0; i < columnCount; ++i) {
> int nullable = fieldList.get(i).isNullable() ? 1 : 0;
> columnMetas.add(new SelectedColumnMeta(false, false, false, false, nullable,
> true, Integer.MAX_VALUE,
> fieldList.get(i).getName().toUpperCase(Locale.ROOT),
> fieldList.get(i).getName().toUpperCase(Locale.ROOT), null, null,
> null, fieldList.get(i).getPrecision(), fieldList.get(i).getScale(),
> fieldList.get(i).getDataType(),
> fieldList.get(i).getDataTypeName(), false, false, false));
> }
>
> {code}
>
> pushdown query:
> !c:\Users\Administrator\AppData\Local\YNote\data\weixinobU7VjlOcNgcm0ZbmNGYzYRPZ__4\401fe7a7ea05495799145f2d413b0da4\clipboard.png!
> cube query:
> !c:\Users\Administrator\AppData\Local\YNote\data\weixinobU7VjlOcNgcm0ZbmNGYzYRPZ__4\0ef826f0229f42b59c4ad946a08bf6f3\clipboard.png!
>
> 我认为这个问题应该修复，因为在尝试对接superset时发现，有些此类框架会强校验元数据列的大小写，如果默认进行转换会导致无法适配，且cube
> query和pushdown query查询的元数据列结果不一致这也是无法接受的。
>
> 如果讨论有需要的话，我可以修复他，谢谢~
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (KYLIN-5217) Create a initial commit
[ https://issues.apache.org/jira/browse/KYLIN-5217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17574123#comment-17574123 ] ASF subversion and git services commented on KYLIN-5217: Commit 8509f15c84f12700074525a250ad648436ff77d0 in kylin's branch refs/heads/kylin5 from yahoNanJing [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=8509f15c84 ] KYLIN-5217 Fix init commit (#1905) * Remove postgresql rpm * Fix spark log path issue Co-authored-by: yangzhong > Create a initial commit > --- > > Key: KYLIN-5217 > URL: https://issues.apache.org/jira/browse/KYLIN-5217 > Project: Kylin > Issue Type: Sub-task >Reporter: Xiaoxiang Yu >Assignee: Xiaoxiang Yu >Priority: Major > Fix For: 5.0-alpha > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5217) Create a initial commit
[ https://issues.apache.org/jira/browse/KYLIN-5217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17574121#comment-17574121 ] ASF GitHub Bot commented on KYLIN-5217: --- hit-lacus commented on PR #1905: URL: https://github.com/apache/kylin/pull/1905#issuecomment-1202200901 LGTM > Create a initial commit > --- > > Key: KYLIN-5217 > URL: https://issues.apache.org/jira/browse/KYLIN-5217 > Project: Kylin > Issue Type: Sub-task >Reporter: Xiaoxiang Yu >Assignee: Xiaoxiang Yu >Priority: Major > Fix For: 5.0-alpha > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5217) Create a initial commit
[ https://issues.apache.org/jira/browse/KYLIN-5217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17574122#comment-17574122 ] ASF GitHub Bot commented on KYLIN-5217: --- hit-lacus merged PR #1905: URL: https://github.com/apache/kylin/pull/1905 > Create a initial commit > --- > > Key: KYLIN-5217 > URL: https://issues.apache.org/jira/browse/KYLIN-5217 > Project: Kylin > Issue Type: Sub-task >Reporter: Xiaoxiang Yu >Assignee: Xiaoxiang Yu >Priority: Major > Fix For: 5.0-alpha > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [kylin] hit-lacus merged pull request #1905: KYLIN-5217 Fix init commit
hit-lacus merged PR #1905: URL: https://github.com/apache/kylin/pull/1905 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] hit-lacus commented on pull request #1905: KYLIN-5217 Fix init commit
hit-lacus commented on PR #1905: URL: https://github.com/apache/kylin/pull/1905#issuecomment-1202200901 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
